#instantbird log on 10 13 2010

All times are UTC.

00:36:53 --> mchaincn has joined #instantbird
00:37:08 <-- mchaincn has left #instantbird ()
00:55:16 <-- clokep has quit (Ping timeout)
01:01:16 --> clokep has joined #instantbird
01:23:26 <-- skeledrew has quit (Ping timeout)
01:32:32 <-- micahg has quit (Ping timeout)
01:41:07 --> skeledrew has joined #instantbird
01:51:09 --> rikki has joined #instantbird
02:09:18 --> micahg has joined #instantbird
02:10:16 <-- rikki has left #instantbird ()
02:20:00 <-- micahg has quit (Quit: Leaving.)
02:21:25 --> micahg has joined #instantbird
02:25:35 --> tymerkaev has joined #instantbird
02:51:18 <-- tymerkaev has quit (Ping timeout)
03:11:15 --> tymerkaev has joined #instantbird
03:16:18 <-- tymerkaev has quit (Ping timeout)
03:16:33 --> rikki has joined #instantbird
03:54:14 <-- clokep has quit (Quit: Instantbird 0.3a1pre)
04:05:45 --> tymerkaev has joined #instantbird
06:44:11 --> Ornthalas has joined #instantbird
06:58:31 --> flo has joined #instantbird
06:58:31 * ChanServ sets mode +qo flo flo 
07:00:05 <-- Even has quit (Input/output error)
07:39:40 --> GeekShadow has joined #instantbird
07:54:25 <-- Tonnes has quit (Input/output error)
08:10:19 <-- flo has quit (Quit: Instantbird 0.3a1pre)
08:18:57 --> RezzoRix has joined #instantbird
08:20:09 <-- RezzoRix has quit (Quit: Instantbird 0.2)
08:37:42 <-- GeekShadow has quit (Ping timeout)
08:41:13 --> Even has joined #instantbird
08:41:13 * ChanServ sets mode +o Even 
08:47:18 <-- Even has quit (Quit: Instantbird 0.3a1pre)
08:47:25 --> Even has joined #instantbird
08:47:25 * ChanServ sets mode +o Even 
08:47:25 <-- Ornthalas has quit (Quit: KTHXBYE)
09:00:09 --> GeekShadow has joined #instantbird
09:45:41 <-- rikki has left #instantbird ()
10:03:00 --> mokush has joined #instantbird
10:08:18 --> Mic has joined #instantbird
10:27:40 <-- GeekShadow has quit (Ping timeout)
10:41:56 --> GeekShadow has joined #instantbird
11:27:08 <-- chrisccoulson has quit (Ping timeout)
11:44:15 <instantbot> New Instantbird (UI) bug 544 filed by mikk.own.cz@gmail.com.
11:44:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=544 nor, --, ---, nobody, UNCO, Missing scrollbar in add-ons manager
11:44:35 --> chrisccoulson has joined #instantbird
11:53:39 <instantbot> New Instantbird (UI) bug 545 filed by mikk.own.cz@gmail.com.
11:53:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=545 nor, --, ---, nobody, UNCO, Back/forward buttons in add-ons manager are broken
11:55:10 <instantbot> mikk.own.cz@gmail.com added attachment 370 to bug 545.
12:04:14 <instantbot> New Instantbird (UI) bug 546 filed by mikk.own.cz@gmail.com.
12:04:15 <instantbot> mikk.own.cz@gmail.com added attachment 371 to bug 546.
12:04:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=546 nor, --, ---, nobody, UNCO, Add-ons manager opened from General Options
12:11:01 --> Tonnes has joined #instantbird
12:12:49 <-- mokush has quit (Client exited)
12:13:21 <instantbot> New Instantbird (UI) bug 547 filed by mikk.own.cz@gmail.com.
12:13:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=547 nor, --, ---, nobody, UNCO, Emoticon text codes are not decoded instantly
12:18:23 <instantbot> New Instantbird (UI) bug 548 filed by mikk.own.cz@gmail.com.
12:18:24 <instantbot> mikk.own.cz@gmail.com added attachment 372 to bug 548.
12:18:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=548 nor, --, ---, nobody, UNCO, Not properly highlighted rollers
12:19:24 <instantbot> benediktp@ymail.com set the Resolution field on bug 547 to DUPLICATE of bug 345.
12:19:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=547 nor, --, ---, nobody, RESO DUPLICATE, Emoticon text codes are not decoded instantly
12:19:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=345 tri, --, ---, nobody, NEW, Changing the selected emoticons theme should refresh the message theme preview
12:24:38 --> clokep has joined #instantbird
12:37:10 <-- GeekShadow has quit (Ping timeout)
12:47:09 <-- tymerkaev has quit (Ping timeout)
12:50:44 --> GeekShadow has joined #instantbird
13:08:42 <-- GeekShadow has quit (Ping timeout)
13:12:07 <-- clokep has quit (Quit: Instantbird 0.3a1pre)
13:12:10 --> clokep has joined #instantbird
13:12:42 <Mic> clokep: thanks for the pointer to the extension code .. I found a better bug there ;)
13:12:56 <clokep> :)
13:13:07 <Mic> You can open two instances of the extension manager since the window names don't match
13:13:09 <clokep> It might be trying to open the extension manager the oldw ay also?
13:13:12 <clokep> I didn't lookc losely.
13:13:17 <clokep> Ohhh. Haha. Nice. :)
13:13:22 <Mic> Try using the menu item and the button from the options
13:13:28 <Mic> You get two ..
13:13:52 <clokep> Yup. :)
13:16:44 <Mic> wait, I'm wrong but you get two anyways for some reason
13:18:14 <Mic> Filing a new bug about that
13:19:04 <clokep> Did you check if adding the extensions fixes the other bug? ;)
13:19:09 <Mic> Will you patch 546 then?
13:19:17 <Mic> No
13:19:30 <clokep> Probably.
13:19:46 <clokep> Windows wants to restart my other computer though (Patch Tuesday and all that. ;)), but give me a few minutes.
13:23:40 --> GeekShadow has joined #instantbird
13:26:02 <instantbot> New Instantbird (UI) bug 549 filed by benediktp@ymail.com.
13:26:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=549 nor, --, ---, nobody, NEW, Possible to open Add-ons Manager twice
13:41:42 <-- Mic has quit (Quit: Instantbird 0.3a1pre)
13:55:42 --> tymerkaev has joined #instantbird
14:17:43 --> flo has joined #instantbird
14:17:43 * ChanServ sets mode +qo flo flo 
14:21:19 <clokep> Hey flo.
14:21:23 <flo> hi :)
14:22:15 <clokep> Any problems w/ my smiley patch? :)
14:28:48 <flo> I didn't know we had that many problems with the new add-on manager in addition to it being ugly :-S
14:29:12 <clokep> I just fixed one of them. ;)
14:30:44 <instantbot> clokep@gmail.com added attachment 373 to bug 546.
14:30:46 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 373 on bug 546.
14:30:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=546 nor, --, ---, clokep, NEW, Add-ons manager opened from General Options
14:31:10 --> Mic has joined #instantbird
14:31:22 <clokep> Mic: I fixed bug 546
14:31:26 <Mic> clokep: I have fixes for the two bugs we discussed
14:31:28 <clokep> And I think it fixes the one you just filed too.
14:31:39 <clokep> Maybe your fixes are better than mine. ;) Go ahead.
14:31:43 <Mic> I had to add "Addons" as window name as well
14:32:26 <clokep> Right.
14:32:26 * flo wonders why the mac nightly failed
14:33:14 <Mic> oh, you cp'ed the menu.js code, ok
14:33:56 <clokep> Yup. I figured it made the most sense and was a lot more readable. :)
14:34:33 <flo> and as it's a copy of my code, I can't even blame you for not adding the { } around a multi line instruction ;)
14:34:50 <clokep> flo: I was going to complain to you about not doing it in fact. ;)
14:34:50 <Mic> Yes, the first bit is not so nice
14:35:17 <Mic> even though I think I'd keep the EMURL and the EMFEATURES const's for readability
14:35:53 <clokep> It'd actually be nicer if all those were in a file somewhere and included. ;)
14:36:07 <Mic> indeed
14:36:29 <clokep> Mic: did you have the arrows pop up for you?
14:37:00 <Mic> I'm sorry I don't understand
14:37:01 <clokep> (Actually it'd be even nicer to use the same function twice instead of having two different ones?)
14:37:05 <flo> clokep: have you tested that code?
14:37:32 <clokep> bug 545
14:37:34 <flo> ah, the focus function is defined there too
14:37:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=545 nor, --, ---, nobody, NEW, Back/forward buttons in add-ons manager are broken
14:37:54 <clokep> flo: Yes.
14:37:59 <Mic> I don't have the most recent nightly and won't update today, so I couldn't check
14:38:15 <clokep> Oh OK. I have two copies of the most ecently nightly, one with that issue and one without. :-\
14:38:55 <clokep> flo: All that code does the same as menus.js though. :-( Not using what I teach the kids I TA for == code reuse. ;)
14:38:55 <Mic> The red box is hopefully just a fancy marking so nobody can miss the forward/backward icons? ;)
14:39:14 <clokep> I think so. :)
14:39:58 <clokep> I can also make a very ugly black box pop up around my addons manager (and a bunch of warnings popup when I open it).
14:41:00 <flo> TA = ?
14:41:22 <clokep> Teaching Assistant, although I just used it as a verb, "to teaching assistant" which doesn't make sense. :)
14:41:42 <Mic> flo, I had the same problem
14:41:53 <flo> you are teaching programming?
14:41:55 <Mic> urbandictionary is quite helpful in these cases ( http://www.urbandictionary.com/define.php?term=TA&defid=345199 )
14:42:29 <clokep> flo: I "TA" for two classes (Laboratory Introduction to) "Embedded Control" and "Electric Circuits".
14:43:01 <clokep> The first is embedded programming in C for basic feedback control and some other things.
14:43:12 <clokep> http://litec.rpi.edu/intro.php ;)
14:43:40 <clokep> I don't really "teach" though -- its a lab class, so I help students out with their code and hardware when it doesn't work.
14:43:44 <flo> I think my debug build is in a state that will let me try your emoticons patch :)
14:45:31 <clokep> Awesome. :)
14:46:22 <flo> I'm not sure how "finished" the new buddy list code should be before I start showing it and asking for comments
14:46:55 <flo> I have currently:  21 files changed, 1401 insertions(+), 222 deletions(-) (note: I haven't removed yet the old unused code, just ifdef'd it out)
14:47:09 <-- Mic has left #instantbird ()
14:47:20 --> Mic has joined #instantbird
14:47:31 <clokep> I hope some of those insertions are comments. ;)
14:47:40 <flo> yeah
14:47:48 <flo> there are lots of comments in the .idl file
14:48:22 <flo> there's also a lot of code though. But js code is shorted than C++ code doing mostly the same
14:48:23 <instantbot> c++ is e-- ah, nevermind.
14:48:23 * sumobot mumbles something about c++ being evil
14:49:19 <Mic> clokep: btw what were your test cases for the smiley bug?
14:49:42 <clokep> Mic: I don't have them written down...I can post them in the bug if you want though (at least th eones I remember).
14:50:36 <clokep> flo: If its usable (runs) and there are comments I wouldn't mind looking at it, not sure exactly what you're looking for though? (Just whether you did something crazy?)
14:50:39 <Mic> na, some are there
14:51:09 <flo> It's not usable yet
14:51:29 <flo> some of the notifications are not sent properly, so the buddy list won't fully update
14:51:51 <flo> adding/removing/moving buddies is not re-implemented yet.
14:52:50 <clokep> I don't add/remove/move buddies often, that's an optional feature. Let an extension implement it. ;)
14:53:31 <clokep> Mic: Added some test cases to bug 207
14:53:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=207 min, --, ---, clokep, ASSI, URLs should not contain Smileys
14:54:23 <Mic> Maybe you should have added the expected outcome of the tests ;)
14:55:08 <clokep> No smileys in them. :)
14:55:27 <clokep> Oh. I also did a few tests that are supposed to have smileys though. Like www.google.com XD
14:55:30 <flo> which protocols gives satisfying results with /raw ?
14:55:38 <clokep> I was testing with AIM.
14:55:50 <clokep> Since I have a few screenames on it.
14:56:01 <clokep> s/screenames/screen names/
14:57:01 <flo> :-S
14:57:07 <flo> that build is more broken than I thought
14:57:09 <Mic> Sorry, I can't tell what the source of your last example was
14:57:39 <Mic> What's there between google.com and XD ?
14:57:44 <clokep> Mic: "www.google.com<space>X<>D"
14:57:51 <clokep> (remove anything in <>)
14:58:14 <Mic> They all work for me as expected
14:59:43 <clokep> You don't get smileys in the middle of your links?
14:59:50 <Mic> No
15:00:03 <clokep> Are you running w/ my patch?
15:00:19 <Mic> Now you're kidding me? ;)
15:00:33 <clokep> Nope. I'm confused. :)
15:01:23 <flo> To test the multiple node case for which .textContent helps: /raw <a href="http://google.com/XD">http://google.co<toto>m</toto>/XD</a>
15:01:50 <Mic> www.google.com
15:01:55 <Mic> oops
15:02:05 <flo> someday we will need to figure out where that stupid ";" comes from :-S
15:02:39 <Mic> wfm
15:02:50 <flo> you are trying the patch too?
15:03:07 <Mic> Why else should I do that?
15:03:30 <-- GeekShadow has quit (Ping timeout)
15:04:43 <flo> <toto>XD doesn't give what I would like :-S.
15:05:00 <flo> maybe the fact that we can have several consecutif text nodes is just a bug :-/
15:05:14 <flo> arg, I meant "/raw <toto>X</toto>D"
15:05:31 <clokep> Isn't there a command to combine adjacent textnodes? i forget it...
15:05:41 <clokep> (And by command I mean function. :))
15:05:48 <flo> I think I've read something about it
15:05:50 <flo> method? ;)
15:06:02 <flo> it's possible it's a recent addition to the API
15:06:11 <clokep> document.normalizeDocument
15:06:17 <Mic> What would you like the result to be on your xd-toto case?
15:06:25 <Mic> A smiley?
15:06:29 <clokep> Or actually flo: https://developer.mozilla.org/En/DOM/Node.normalize
15:06:49 <clokep> So after each text modifier it should be normalized?
15:06:54 <clokep> Maybe...?
15:06:55 <flo> Mic: yes
15:06:58 <Mic> Could it be possibly been meant as smiley if the markup looked like this?
15:07:07 <flo> clokep: maybe only after filtering out some markup?
15:07:28 <flo> Mic: I don't think so.
15:07:46 <flo> but the reason why this is not a smiley is not understandable to any regular user, so it's probably not a good one ;)
15:07:54 <clokep> flo: Maybe. Do you want me to file a bug to normalize text nodes so we don't forget about it? ;)
15:08:07 <flo> would be great! :)
15:10:28 --> kaie has joined #instantbird
15:11:46 <clokep> flo: Any opinion on bug 543? :)
15:11:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=543 enh, --, ---, nobody, NEW, Text Modifier for plaintext formatting
15:13:24 <instantbot> New Instantbird (UI) bug 550 filed by clokep@gmail.com.
15:13:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=550 nor, --, ---, nobody, NEW, Normalize nodes to remove empty/combine adjacent text nodes
15:13:50 <flo> clokep: isn't it just a flag to turn on?
15:13:55 <clokep> Yes.
15:14:11 <clokep> It'd be trivial to do, I'm just not sure its wanted or not.
15:14:17 <flo> would you do it before sending the messages, or after?
15:14:26 <flo> (after = before displaying)
15:14:35 <clokep> On displaying text I think.
15:15:23 <flo> is there any potential harm (= should we add a pref to disable it?)?
15:15:35 <clokep> I don't know. :-\
15:15:59 <clokep> Well it would depend on whehter you want to see markup or not I think. :)
15:17:40 <Mic> Might not be covered by the setting we have
15:18:10 <Mic> What happens if you receive such a text markup and have selected "Display formatting: None"
15:18:44 <clokep> It shouldn't be formatted I would think.
15:18:45 <Mic> If links are still linkified we'd still get this markup
15:18:55 <clokep> No, you could check the preference.
15:19:22 <flo> checking that pref sounds like a good idea
15:19:37 <Mic> If links are disabled as well by this setting it wouldn't matter anyways
15:20:23 <clokep> Links are only disabled if !aMessage.noLinkification
15:23:11 <clokep> I'm not sure where the formatting occurs? insertHTMLForMessage maybe.
15:24:36 <instantbot> florian@instantbird.org granted review for attachment 368 on bug 207.
15:24:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=207 min, --, ---, clokep, ASSI, URLs should not contain Smileys
15:25:14 <flo> clokep: http://lxr.instantbird.org/instantbird/source/instantbird/content/convbrowser.xml#287
15:25:30 <clokep> Yes, I'm looking at that. :)
15:25:32 <Mic> I think you wanted to add another flag on the linkification method?
15:25:38 <clokep> Yes.
15:25:55 <flo> probably just want to change the "2" magic value
15:26:12 <clokep> I think if we do it automatically and you have selected not formatting it'll just get ripped back out by cleanupImMarkup, so I think it'd be OK to "always" do it.
15:26:14 <clokep> Yes.
15:26:15 <flo> I suspect you don't even need to care about the formatting pref, as the cleanup happens later :)
15:26:32 <clokep> :)
15:26:42 <Mic> sounds good :)
15:28:35 <flo> in the patch for bug 546, do you mind if I edit your patch to keep the constants?
15:28:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=546 nor, --, ---, clokep, NEW, Add-ons manager opened from General Options
15:30:11 <clokep> flo: No, go for it. :)
15:30:30 <clokep> As I said eaerlier to Mic it'd be much nicer if both that and menus.js used the same constants though. :(
15:30:46 <Mic> I think it would
15:31:06 <Mic> * be nicer if we'd have a combined place to have a set of these methods
15:31:30 <flo> http://pastebin.instantbird.com/434 looks ok?
15:32:18 <clokep> Yes flo.
15:32:22 <-- Mic has quit (Quit: Instantbird 0.3a1pre)
15:32:29 <clokep> Maybe put {} around it? ;)
15:32:35 --> Mic has joined #instantbird
15:33:45 <Mic> ah, the text markup keeps the markup characters anyways
15:34:00 <Mic> so we get bold text enclosed in asterisks for example
15:34:19 <clokep> Mic: Yup!
15:35:23 <clokep> I'd also get rid of the magic #. ;)
15:38:38 <Mic> Works fine, gets filtered by the content filter and has reasonable replacement rules
15:41:28 --> GeekShadow has joined #instantbird
15:41:53 <instantbot> florian@instantbird.org granted review for attachment 373 on bug 546.
15:41:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=546 nor, --, ---, clokep, NEW, Add-ons manager opened from General Options
15:44:59 <clokep> So bug 546 I /think/ fixes bug 549, but it seems to close the window and open it again? Or at least flash.
15:45:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=546 nor, --, ---, clokep, NEW, Add-ons manager opened from General Options
15:45:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=549 nor, --, ---, nobody, NEW, Possible to open Add-ons Manager twice
15:45:26 <instantbot> florian@instantbird.org set the Resolution field on bug 546 to FIXED.
15:45:28 <Mic> It did that before as well
15:45:52 <clokep> Oh OK. :) So then we can mark that as fixed. (Or wait until the next nightly, then we can verify.)
15:46:06 <Mic> I don't think it actually closes it, it could as well be something like minimize
15:46:47 <Mic> hmm, the taskbar button of the AOM vanishes though..
15:47:38 <Mic> It does the same no matter which of both ways you try when the aom is already opened
15:47:51 <clokep> Yup.
15:47:51 <clokep> :)
15:47:59 <instantbot> florian@instantbird.org set the Resolution field on bug 207 to FIXED.
15:48:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=207 min, --, 0.3a1, clokep, RESO FIXED, URLs should not contain Smileys
15:48:19 <clokep> The accounts window doesn't do that though Mic if you open from Tools or from Options. :\
15:48:30 <Mic> Checked that as well ;)
15:48:52 <clokep> So I think we should investigate it a bit more..
15:49:22 <flo> I've got to go. Good evening! :)
15:49:32 <clokep> 'night.
15:49:37 <clokep> I have to go too. Be back in a bit maybe.
15:49:43 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/a078133a0492 - Patrick Cloke - Bug 207 - URLs should not contain Smileys, r=fqueze.
15:49:44 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/b6c87968f528 - Patrick Cloke - Bug 546 - Fix opening the add-ons manager from the preferences dialog. r=fqueze
15:49:49 <Mic> hmm, we're not only focusing the window
15:50:05 <Mic> We're changing categories to "extensions" as well
15:50:15 <-- flo has quit (Quit: Instantbird 0.3a1pre)
15:51:35 <Mic> leaving too
15:51:43 <Mic> Have a nice evening/afternoon
15:52:07 <-- Mic has left #instantbird ()
15:52:48 <-- clokep has quit (Ping timeout)
16:00:46 --> clokep has joined #instantbird
16:03:43 --> Ornthalas has joined #instantbird
16:03:44 --> clokep1 has joined #instantbird
16:05:19 <-- clokep has quit (Ping timeout)
16:06:28 <-- clokep1 has quit (Quit: Instantbird 0.3a1pre)
16:07:38 --> clokep has joined #instantbird
16:11:32 --> Andrey has joined #instantbird
16:30:52 <-- Andrey has quit (Quit: )
17:04:35 <-- clokep has quit (Ping timeout)
17:05:33 --> clokep has joined #instantbird
17:07:55 --> Cutler has joined #instantbird
17:07:56 <Cutler> New Farmville cheats and autoers added! http://tinyurl.com/10-11-2010-Farmville-Cheats
17:07:58 <-- Cutler has left #instantbird ()
17:10:56 <-- micahg has quit (Ping timeout)
17:15:23 <-- Even has quit (Connection reset by peer)
17:34:48 --> clokep1 has joined #instantbird
17:36:02 <-- clokep has quit (Connection reset by peer)
17:39:42 --> clokep has joined #instantbird
17:41:11 <-- clokep1 has quit (Ping timeout)
17:47:21 --> clokep1 has joined #instantbird
17:47:54 <-- clokep has quit (Ping timeout)
17:49:18 --> micahg has joined #instantbird
17:50:08 <-- micahg has quit (Quit: Leaving.)
17:50:22 --> clokep has joined #instantbird
17:50:26 --> micahg has joined #instantbird
17:51:56 <-- clokep1 has quit (Ping timeout)
17:52:11 --> clokep1 has joined #instantbird
17:54:58 <-- clokep has quit (Ping timeout)
17:58:13 <-- clokep1 has quit (Ping timeout)
18:00:25 --> clokep has joined #instantbird
18:03:42 <-- clokep has quit (Ping timeout)
18:03:46 --> clokep has joined #instantbird
18:17:31 <-- Mitch has quit (Quit: ChatZilla 0.9.86-2010081522 [SeaMonkey 2.0.8/20100914140239])
18:26:49 <-- clokep has quit (Ping timeout)
18:27:14 --> clokep has joined #instantbird
18:28:56 <-- GeekShadow has quit (Ping timeout)
18:30:17 <-- clokep has quit (Ping timeout)
19:03:42 --> DGMurdockIII has joined #instantbird
19:28:19 --> Mic has joined #instantbird
20:02:02 --> GeekShadow has joined #instantbird
20:57:23 <-- tymerkaev has quit (Ping timeout)
21:01:17 <-- GeekShadow has quit (Quit: The cake is a lie !)
21:07:38 --> clokep has joined #instantbird
21:43:48 <-- DGMurdockIII has quit (Quit: get satisfied! • :: www.unitedservers.de ««« (Gamers.IRC) »»» gamersirc.net ::)
21:53:42 <instantbot> clokep@gmail.com added attachment 374 to bug 543.
21:53:44 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 374 on bug 543.
21:53:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=543 enh, --, ---, clokep, NEW, Text Modifier for plaintext formatting
22:02:08 <Mic> clokep: a comment on kStructPhrase could be useful
22:02:23 <clokep> Mic: I was just about to post about:support stuff on that bug. :)
22:02:27 <Mic> It's a bit cryptic without
22:02:39 <clokep> Hmm...yeah< i suppose it is.
22:03:10 <clokep> (The other question is, if noLinkification is true, do we still want to do plaintext formatting?
22:03:28 <Mic> I wondered too
22:03:41 <Mic> and can't answer the question since I don't know when this flag is set
22:04:38 <clokep> Yeah, I should probably put that in...(I'll add a comment too.)
22:09:47 <clokep> Mic: Can you think of a better name than "txt2htmlconv"? :)
22:11:04 <Mic> converter?
22:11:15 <clokep> txt2htmlconvert?
22:11:19 <clokep> *converter?
22:12:08 <Mic> I'd say "conv" is bad since it's used as abbreviation for conversation at many other places
22:12:21 <clokep> Ah, good though. :)
22:12:34 <Mic> txt2htmlconverter is better, even though longer and might give you even more troubles with the line length
22:12:35 <clokep> s/though/thought/
22:12:45 <clokep> I think I'm gonna do the whole thing though. :-\
22:13:28 <Mic> What about mozITXTToHtmlConverterService? ;)
22:14:36 <Mic> (thought I guess nothing reasonable will ever beat "getAnonymousElementByAttribute" ;)
22:15:25 <clokep> :)
22:15:37 <clokep> I was thinking TXTToHTMLConverterService, but that's very long...
22:16:07 <Mic> What does the counter say about Buddy Status' "download level"? ...  It's over ONE THOUSAND!
22:16:30 <Mic> Sorry, couldn't resist posting a reference to pop culture;)
22:16:31 <clokep> =-o
22:23:25 <Mic> Are you changing the patch btw?
22:23:45 <clokep> Yes, what's up?
22:23:50 <clokep> SOmething else you want to change? ;)
22:23:58 <clokep> (I'm testing again right now.)
22:24:45 <Mic> I'd have suggested doing something like: move things out of the if and replace it with something like
22:25:54 <clokep> I did that.
22:25:57 <Mic> let kFlags = !noLinkification ? kUrls + kStructPhrase: kStructPhrase;
22:25:58 <clokep> One sec -- pastebin what I have?
22:26:08 <clokep> Oh, that's a clever way to do it. :)
22:26:13 <clokep> I like that.
22:26:47 <Mic> :)
22:29:24 <Mic> I think get rid of the "not" completely
22:30:23 <clokep> Do you think flo will go for !!aMsg.noLinkification * kURLs | kStructPhrase?
22:30:23 <Mic> It's obscuring the meaning, so it might be better to use
22:30:25 <Mic> let kFlags = noLinkification ? kStructPhrase : kUrls + kStructPhrase;
22:32:05 <clokep> Yours might be a bit more readable
22:32:15 <-- chrisccoulson has quit (Ping timeout)
22:32:22 <Mic> !! is not a special operator, is it?
22:33:13 <Mic> It's just a very bad way of doing a type conversion to boolean, isn't it? ;)
22:34:03 <clokep> Its a way to force "false" to 0 and anything that's not false (aka true) to a 1.
22:34:43 <clokep> I'll go with the ternary, its only like 2 characters longer.
22:39:39 <instantbot> clokep@gmail.com added attachment 375 to bug 543.
22:39:41 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 374 on bug 543.
22:39:41 <-- Ornthalas has quit (Quit: KTHXBYE)
22:39:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=543 enh, --, ---, clokep, NEW, Text Modifier for plaintext formatting
22:42:12 <instantbot> clokep@gmail.com added attachment 376 to bug 543.
22:42:14 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 376 on bug 543.
22:42:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=543 enh, --, ---, clokep, NEW, Text Modifier for plaintext formatting
22:42:29 <clokep> Sometimes I wonder how much email flo gets just from you and me Mic.
22:43:16 <Mic> It's called bugspam for a reason ;)
22:49:18 <clokep> True.
22:50:51 <Mic> txt2htmlconverter should be camel case most likely to follow the coding style of the file
22:51:08 <clokep> Did I not make it camel case?
22:51:14 <clokep> Oops.
22:51:17 <Mic> Sorry for nitpicking :S
22:51:25 <clokep> Well I'll let flo review it first to see if he even likes the style at all.
22:52:40 <Mic> ahm, sorry. One more thing:
22:53:37 <Mic> Shouldn't it be " ? txt2htmlconverter.kStructPhrase :  " instead of  " ? 0 : "
22:53:46 <clokep> No.
22:53:52 <Mic> or is it evaluated as (flag?true:false) | otherFlag
22:54:07 <clokep> The second way.
22:55:08 <Mic> I think it could be more readable the other way
22:55:46 <clokep> But its not right.
22:56:06 <clokep> You'd be including kStructPhrase twice then, I don't like that.
22:56:26 <clokep> I could have put () around it, but I figured it being on its own line was readable enough. :)
22:56:40 --> chrisccoulson has joined #instantbird
22:56:57 <Mic> I think it's obscured
22:57:02 <Mic> but I gtg now
22:57:09 <clokep> OK.
22:57:17 <Mic> It's ways too late here
22:57:19 <clokep> I'll think about it and see if there's a better way I like.
22:57:22 <clokep> Haha, good night.
23:15:00 <-- Mic has quit (Quit: Instantbird 0.3a1pre)
23:53:38 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 376 on bug 543.
23:53:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=543 enh, --, ---, clokep, NEW, Text Modifier for plaintext formatting