#instantbird log on 10 08 2010

All times are UTC.

00:54:12 <-- micahg has quit (Ping timeout)
01:20:20 --> clokep has joined #instantbird
01:54:15 --> rikki has joined #instantbird
02:52:00 <-- chrisccoulson has quit (Quit: Ex-Chat)
03:00:04 --> micahg has joined #instantbird
03:08:49 <-- goulagman has quit (Quit: Instantbird 0.3a1pre)
03:21:45 <-- micahg has quit (Quit: Leaving.)
03:21:59 --> micahg has joined #instantbird
04:09:31 <-- clokep has quit (Quit: Instantbird 0.3a1pre)
04:10:03 --> tymerkaev has joined #instantbird
04:23:48 <-- rikki has quit (Ping timeout)
04:24:29 --> rikki has joined #instantbird
04:55:54 <-- tymerkaev has quit (Ping timeout)
06:48:49 --> tymerkaev has joined #instantbird
07:09:54 --> patrickjdempsey has joined #instantbird
07:10:48 <patrickjdempsey> Hi guys, I haven't checked the nightlies in awhile and just updated and noticed you guys landed the new add-ons manager.
07:15:21 <patrickjdempsey> All seems to be working well!
07:15:36 <-- tymerkaev has quit (Ping timeout)
07:18:56 --> Even has joined #instantbird
07:18:57 * ChanServ sets mode +o Even 
08:14:44 <-- Even has quit (Quit: Instantbird 0.3a1pre)
08:14:50 --> Even has joined #instantbird
08:14:51 * ChanServ sets mode +o Even 
08:53:27 --> patrickjdempsey1 has joined #instantbird
08:54:54 <-- patrickjdempsey has quit (Ping timeout)
09:04:19 <-- Even has quit (Quit: Instantbird 0.3a1pre)
09:08:16 --> Even has joined #instantbird
09:08:17 * ChanServ sets mode +o Even 
09:32:57 --> chrisccoulson has joined #instantbird
10:08:43 --> Andrey has joined #instantbird
10:14:27 --> tymerkaev has joined #instantbird
10:33:46 --> flo has joined #instantbird
10:33:46 * ChanServ sets mode +qo flo flo 
10:34:17 <flo> Hello ! :)
10:49:06 <tymerkaev> HELLO!
10:49:29 <Andrey> q
10:59:36 <-- IRCMonkey18274 has quit (Quit: Instantbird 0.3a1pre)
11:03:56 <-- patrickjdempsey1 has left #instantbird ()
11:10:20 <-- flo has quit (Quit: Instantbird 0.3a1pre)
11:31:41 <-- tymerkaev has quit (Ping timeout)
12:12:56 --> Mic has joined #instantbird
12:13:05 <Mic> hi
12:19:48 --> clokep has joined #instantbird
12:20:33 <-- clokep has quit (Quit: Instantbird 0.3a1pre)
12:20:43 --> clokep has joined #instantbird
12:24:19 <Mic> welcome clokep
12:24:51 <clokep> Hi Mic
12:37:52 <clokep> How's everything going?
12:38:42 <Mic> Fine, going back to lab now
12:39:03 <Mic> This afternoon I can finally check if my apparatus works .. even though I expect the worst :S
12:39:37 <Mic> I think we had to make too many compromises in design. Let's see how it turns out.
12:40:21 <Mic> compromises? concessions? My dictionary is not clear on this. gtg
12:48:05 <clokep> Eithter works. :)
12:48:07 <clokep> Good luck!
13:01:44 --> flo has joined #instantbird
13:01:44 * ChanServ sets mode +qo flo flo 
13:12:37 --> tymerkaev has joined #instantbird
13:50:46 <-- clokep has quit (Ping timeout)
14:13:57 --> hicham has joined #instantbird
14:17:33 <-- Andrey has quit (Ping timeout)
14:17:36 <-- rikki has quit (Quit: Instantbird 0.2)
14:32:54 <-- hicham has quit (Client exited)
15:11:14 <-- fqueze_ has quit (Quit: Instantbird 0.3a1pre)
15:11:35 --> fqueze_ has joined #instantbird
15:11:56 <-- flo has quit (Quit: Instantbird 0.3a1pre)
15:12:09 --> flo has joined #instantbird
15:12:09 * ChanServ sets mode +qo flo flo 
15:38:55 --> clokep has joined #instantbird
15:45:02 <-- Even has quit (Quit: Instantbird 0.3a1pre)
15:51:46 --> Andrey has joined #instantbird
16:18:03 --> clokep1 has joined #instantbird
16:18:31 <-- clokep has quit (Connection reset by peer)
16:19:47 * flo is not sure of what we can do for bug 535
16:19:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=535 nor, --, ---, nobody, NEW, Large default database files
16:20:15 <flo> they certainly won't back it out if we complain
16:20:23 <flo> making it a pref doesn't sound good
16:21:05 <-- clokep1 has quit (Ping timeout)
16:26:56 --> clokep has joined #instantbird
16:26:58 <clokep> Hey flo.
16:27:30 <clokep> re bug 207
16:27:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=207 min, --, ---, clokep, ASSI, URLs should not contain Smileys
16:27:54 <clokep> We could easily make it so linkification skips "a" links.
16:28:07 <clokep> I found it kind of clunky in general that textModifiers work on nodes as opposed to the raw text.
16:28:13 <flo> then just do if for emoticons and close that bug ;)
16:28:21 <flo> *it
16:28:45 <clokep> And bug 535....is 10.24 MB & 512 KB really a large file? I mean....11 MB -- who cares.
16:28:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=535 nor, --, ---, nobody, NEW, Large default database files
16:28:50 <clokep> Thta's /nothing'.
16:29:28 <flo> if you are a student and your high school / university imposes a stupid 50MB quota on your account... it's significant
16:29:56 <flo> I guees quotas have increased since I'm no longer in high school
16:30:04 <flo> but at the time they were stupidly low
16:31:15 <flo> (except mine, idechix, and vicnet's quotas that got accidentally disabled by the network administrator... we had access to the whole hard disk :-P)
16:31:16 <clokep> Oh, in the US everyone has their own laptop/desktop for the most part so....idk what my quota is on diskspace on the network.
16:32:49 <flo> it's part of the roamed profile... it needs to be downloaded by the machine you log onto before you can use it. One an overloaded network, it's very slow
16:33:29 <clokep> Ah, OK. :) I see. I didn't even consider that. :) I withdraw my consideration then.
16:34:13 --> DGMurdockIII has joined #instantbird
16:34:22 <clokep> So for bug 207 you'd be OK w/ just no smilies in links at all? :) That'd make the bug super easy to fix.
16:34:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=207 min, --, ---, clokep, ASSI, URLs should not contain Smileys
16:34:27 <flo> typically a few dozen students login more or less at the same time when the class begins, and the network gets suddenly overloaded :-D
16:34:54 <clokep> Yes. I always get kicked off when I TA cause of that. :( As the network seems to prioritize new logins. :-\
16:35:37 <flo> if I was the one writing the patch, I think I would attempt to check that the .textContent of the a node equals the a node's href before skipping it.
16:35:50 <flo> but I may r+ a patch that doesn't do it
16:35:56 --> idechix has joined #instantbird
16:35:56 * ChanServ sets mode +o idechix 
16:38:22 <clokep> That could be doable. :)
16:38:26 <clokep> I'll check it out again.
16:39:05 <flo> If I remember well it's not easy, because you need to change the way text modifiers work for them to be able to access that much data
16:39:49 <flo> hmm, or maybe you can check the text node's parent node. Not sure if you can stop the recursion easily though.
16:40:10 <clokep> I'll look into doing it thta way, I didn't think about doing it like that.
16:47:39 <clokep> Maybe I'll get some more work on IRC done this weekend too. :)
16:48:02 <flo> I really need to get more work done on that buddy list stuff :(
16:48:47 <flo> I spent time yesterday evening thinking about the notifications that we need to fire when some changes related to the contacts happen
16:50:51 <clokep> "changes" like status or like a tag changes?
16:51:10 <flo> http://pastebin.instantbird.com/427
16:53:06 <clokep> That's messay. :-\
16:53:10 <clokep> *messy.
16:53:20 <flo> ah?
16:54:26 <flo> I'm wondering if I help add-on developers more by providing very specific notifications, or less notifications (so that it's easier to find which one is interesting)
16:54:29 <DGMurdockIII> Is the auto updating not working right noe?
16:55:06 <flo> are you having a problem with it?
16:55:23 <clokep> Specific ones are nice cause they tell you exactly what occurred, but a lot of the time you just want to know it changed then you update stuff.
16:55:23 <DGMurdockIII> yes
16:55:41 * clokep is updating right now.
16:55:46 <-- clokep has quit (Quit: Instantbird 0.3a1pre)
16:56:03 <DGMurdockIII> i even tryed manly updating my nightly verson from website
16:56:13 --> clokep has joined #instantbird
16:56:14 <flo> clokep: If we want less notifications, we can get rid of signed-on, signed-off, status-changed, status-message-changed and idle-changed, and ask add-on developers to use availability-changed instead
16:56:38 <clokep> flo: I think Mic would be the one to ask -- he's done the most w/ capturing this stuff AFAIK?
16:57:07 <DGMurdockIII> when i try to run a update i get a error that say partial update could no be installed going to try full update
16:57:21 <flo> if we fired detailed notifications, there's also the problem of when you become away+idle, are you away first or idle first?
16:57:34 <flo> and is the availability-changed signal sent first or after the specific notifications?
16:57:56 <flo> DGMurdockIII: and what about the full update?
17:02:33 <DGMurdockIII> fails as well
17:03:11 <flo> what's your build id?
17:03:27 <DGMurdockIII> 20101008041844
17:03:29 <clokep> flo: Its confusing. :(
17:03:37 <DGMurdockIII> you meanthat
17:03:51 <Mic> I'll comment later, got to catch my bus now
17:03:52 <Mic> bbl
17:03:56 * Mic is now known as Mic|away
17:04:00 <flo> DGMurdockIII: your build is already up to date
17:04:13 <flo> clokep: which part of it is the most confusing? :)
17:04:41 <clokep> flo: I don't find it confusing once a decision is made, I find it confusing to decide which way is best. :)
17:04:57 <flo> ah, so what I'm doing is confusing. Ok :)
17:05:02 <DGMurdockIII> but ever time i do the update t says i fail
17:05:28 <flo> creating good APIs is a bit like an art ;)
17:05:46 <flo> and we rarely succeed the first time :(
17:05:48 <DGMurdockIII> if i close and open it there no window to show me if it is installing
17:06:16 <clokep> flo: I'm glad you're not afraid to change APIs when you think they're bad though, especially since Instantbird is new.
17:06:22 <clokep> Some people like to freeze everything. :)
17:06:38 <clokep> Did you decide about imIAccount etc. vs. purpleIAccount?
17:06:39 <flo> I'm a bit scared of announcing I'm going to change everything though ;)
17:07:09 <flo> not really yet for the account.
17:07:41 <flo> I find the current purpleIAccount/purpleIAccountBase separation confusing, so I may revisit both of these interfaces before renaming
17:08:01 <flo> if the changes I want to make are backward incompatible, renaming it is no worse :)
17:08:31 <clokep> Might even be better actually!
17:08:32 <flo> I'm also interested in simplifying the APIs around status.
17:09:02 <flo> and maybe the purpleIConv* APIs too.
17:09:15 <flo> does the purpleIConvIM vs purpleIConvChat separation really make sense?
17:09:53 <flo> purpleICoreService will also change a lot with js-proto/js-blist.
17:10:00 <-- micahg has quit (Ping timeout)
17:10:14 <flo> a1pre is a good time to break APIs :)
17:11:56 * flo is going home, and looks forward to read potential comments (from Mic?) about the buddy list APIs.
17:12:17 <flo> Good evening :)
17:12:21 <-- flo has quit (Quit: Instantbird 0.3a1pre)
17:12:46 <clokep> flo: purpleIConvIM and purpleIConvChat make sense I think, I'm not sure how I feel about purpleIConvChatBuddy. :-\
17:13:14 <clokep> I feel like there's a bit more that could be done with them besides just having a name and some flags.
17:24:00 <instantbot> New Instantbird (UI) bug 539 filed by Prescience500@gmail.com.
17:24:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=539 enh, --, ---, nobody, UNCO, Merge the "My Status" extension into Instantbird to remember status
17:25:13 <-- clokep has quit (Ping timeout)
17:36:57 --> clokep has joined #instantbird
17:40:28 <-- DGMurdockIII has quit (Connection reset by peer)
17:45:50 --> Even has joined #instantbird
17:45:51 * ChanServ sets mode +o Even 
17:47:19 <-- Even has quit (Input/output error)
17:58:11 <-- chrisccoulson has quit (Ping timeout)
17:58:32 --> chrisccoulson has joined #instantbird
17:59:14 --> micahg has joined #instantbird
17:59:17 <-- Andrey has quit (Quit: )
18:02:54 --> clokep_dev has joined #instantbird
18:03:02 <-- clokep_dev has left #instantbird ()
18:03:39 --> clokep_dev has joined #instantbird
18:03:55 <-- clokep_dev has quit (Quit: Instantbird 0.3a1pre)
18:07:52 --> goulagman has joined #instantbird
18:08:40 <-- goulagman has quit (Quit: Instantbird 0.3a1pre)
18:08:48 --> goulagman has joined #instantbird
18:19:01 <-- goulagman has quit (Connection reset by peer)
18:19:53 --> clokep_dev has joined #instantbird
18:20:01 <-- clokep_dev has quit (Quit: clokep_dev)
18:36:46 --> clokep_dev has joined #instantbird
18:37:05 <-- clokep_dev has quit (Quit: Instantbird 0.3a1pre)
19:11:42 <-- micahg has quit (Ping timeout)
19:12:13 <-- idechix has quit (Quit: Instantbird 0.3a1pre)
19:13:30 --> micahg has joined #instantbird
19:20:47 --> Mic has joined #instantbird
19:23:22 <Mic> good evening
19:24:01 <clokep> Hey Mic.
19:25:12 <Mic> btwe I think 10MB is pretty large for something that we don't  use
19:25:29 --> Even has joined #instantbird
19:25:29 * ChanServ sets mode +o Even 
19:26:47 <clokep> cookies.sqlite could be used by some protocols.
19:26:57 <clokep> If something is going to do XHR then it could use them.
19:27:04 <clokep> (I.e. Twitter.)
19:27:25 <clokep> But places we probably don't need. :)
19:31:26 <Mic> The detailed notifications have been a bit annoying for my extension
19:31:53 <clokep> I can't get anything to work when I change imSmiles.jsm
19:31:59 <clokep> I can't even get it to output.
19:32:17 <Mic> what are you trying?
19:32:37 <clokep> flo Suggesting I patch it to just skip links.
19:32:55 <Mic> You explicitly need to write to the console if you want some output
19:33:10 <clokep> Component.utils.reportError ?
19:33:26 <Mic> yes, for example .. or use the console component
19:33:44 <Mic> I think I saw that somewhere in your code already?
19:34:02 <clokep> Right, its not working. :P
19:34:08 <clokep> That's my point.
19:34:13 <Mic> reportError works
19:34:14 <clokep> So idk if the function is getting called.
19:34:37 <Mic> *I'm quite sure that reportError works
19:34:56 <clokep> I agree, it should, but nothing is popping up. So I'm doing something wrong. :)
19:35:34 <Mic> I'd like it if you'd get both the old and the new status and could use it as you like
19:35:47 <clokep> :) Yes, that'd be nice.
19:36:29 <Mic> displayname-changed should provide the old name as well in my opinion
19:36:49 <Mic> Has mobile been dropped?
19:37:06 <clokep> I don't know.
19:37:25 <Mic> I wonder how the mobile status changes? Maybe when you sign on from somewhere else?
19:37:28 <clokep> Mic: Is it possible my module isn't being reloaded?
19:38:17 --> flo has joined #instantbird
19:38:17 * ChanServ sets mode +qo flo flo 
19:38:27 <Mic> I think this can be if you have a major problem?
19:38:48 <Mic> well, this one was helpful, for sure :D
19:39:36 <clokep> Oh, apparently I was int he wrong function.
19:39:46 <clokep> There's like 8 functions in imSmileys and only like 2 rae used.
19:40:04 <clokep> flo ^ You can take that comment as a complaint. ;)
19:40:17 <instantbot> florian@instantbird.org set the Resolution field on bug 539 to DUPLICATE of bug 449.
19:40:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=539 enh, --, ---, nobody, RESO DUPLICATE, Merge the "My Status" extension into Instantbird to remember status
19:40:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=449 nor, --, ---, nobody, NEW, Status message is lost on restart
19:45:42 <flo> clokep: I'm not sure JS protocol plugins could/should use cookies.sqlite. Wouldn't that completely messup users connecting several accounts on the same protocol?
19:46:16 <clokep> flo: Possibly, but by default don't HTTP connections use cookies? Can we force that another way?
19:46:48 <flo> if we *need* to do it, it's not relevant to look for if we *can* ;).
19:47:19 <flo> (but yeah... I don't really know how we can actually do it :-/)
19:47:32 <flo> I'm sure we will find something if we search hard enough :)
19:47:41 <clokep> OK.
19:49:31 <flo> Mic: "I'd like it if you'd get both the old and the new status and could use it as you like" was this about a specific notification?
19:50:26 <Mic> http://pastebin.instantbird.com/428
19:50:32 <Mic> hi, by the way
19:51:19 <Mic> I wouldn't mind if you'd only get status-changed notifications and by checking the old and new status you can tell what happened
19:51:22 * clokep might have just fixed links.
19:51:39 <flo> clokep: "There's like 8 functions in imSmileys and only like 2 rae used." are the figures exact here?
19:51:52 <clokep> flo: No, that's what the "8" was for. ;)
19:52:01 <clokep> "like", not 8.
19:53:10 <flo> have you found an easy solution?
19:53:12 <clokep> OK, I lied a lot.
19:53:21 <clokep> There's like 3 unused functions AFAI can tell.
19:53:26 <flo> checking the parent node like I suggested may work :)
19:53:26 <clokep> Yes. :)
19:53:53 <Mic> away + idle notifications were annoying and I think I also had problems with signed-on and successive status changes
19:54:03 <flo> smileString and smileImMarkup (which uses smileNode)?
19:54:13 <clokep> flo: Fixed it. :)
19:54:21 <-- tymerkaev has quit (Ping timeout)
19:54:31 <Mic> Like "ABC signed on" and immediately after that a "ABC has changed status to away" ..
19:54:32 <clokep> smileString, smileNode and smileImMarkup
19:54:34 <clokep> Yes.
19:55:09 <Mic> would have been nicer to have a notification where the old status was offline and the new was away
19:55:19 * clokep now needs to make a patch...
19:55:29 <Mic> (maybe this was a problem specific to a certain protocol though)
19:55:50 <flo> Mic: I don't think we have ever had a notification for mobile
19:56:22 <Mic> no idea.. I haven't checked the list to be honest. It just seemed missing
19:56:31 <Mic> Let me see
19:56:47 <Mic> no, there's none for mobile, you are right
19:57:02 <clokep> I don't think I've updated my local Hg repo since before we switched to Mozilla2 branch. :-\
19:58:40 <Mic> flo: does what I wrote even make sense? If the old/new thing is not feasible or reasonable then you can ignore most of the comments there
19:59:17 <flo> Mic: I think we will change the way status work. The current think looks like a mess to me.
19:59:44 <flo> a buddy is either available or unavailable, and it can also be idle, and can also be mobile at the same time.
20:00:06 <flo> it's non sense, and to display that in the UI we had to decide that mobile is less available than idle, and things like that
20:00:14 <Mic> That's also possible at the moment
20:00:20 <clokep> flo: You want git diff right? Anything else I need to do special?
20:00:22 <Mic> These are different flags
20:00:44 <flo> I was describing what we have at the moment and is confusing ;)
20:01:20 <Mic> but we have different flags already , we just chose what to display, don't we?
20:01:21 <flo> http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/public/purpleICoreService.idl#119 Would using something like this for buddies too work? (it's currently used for our own status)
20:01:50 <flo> I would switch the order of MOBILE and INVISIBLE if we do that.
20:02:51 <clokep> flo: Is there something where I need to like add a header to the diff? I don' t know how to do that. :)
20:03:06 <flo> clokep: just run hg diff :)
20:04:51 <flo> Mic: yes, what you wrote makes sense. The old/new thing is not really easy to do, but it's probably worth it
20:05:48 <flo> it's easy to send a string with the notification, so for the display-name-changed, sending the old nick too is easy.
20:06:53 <instantbot> clokep@gmail.com added attachment 364 to bug 207.
20:06:53 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 324 on bug 207.
20:06:54 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 364 on bug 207.
20:06:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=207 min, --, ---, clokep, ASSI, URLs should not contain Smileys
20:07:21 <Mic> How do we currently tell what the previous status was when coming out of idle?
20:07:46 <clokep> Bah.
20:07:55 <clokep> I had added a comment in there, bug I guess it didn't go through...:-\
20:07:56 <flo> currently I think we don't tell
20:07:59 <Mic> These status' are mutually exclusive
20:08:24 <Mic> let me check
20:08:29 <flo> I think at some point we will want/need to rewrite the way system messages are displayed in conversations
20:08:38 <flo> want -> because the current messages suck
20:08:55 <flo> need -> because I suspect they only work with libpurple protocol plugins. It's implemented in C...
20:10:45 <Mic> Shouldn't we fail to set the correct status when coming out of idle then?
20:10:56 <Mic> Or is it handled internally by libpurple
20:11:12 <flo> the current status are handled (mostly) by libpurple
20:12:02 <flo> the getters of the attributes we have exposed do libpurple function calls. http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleAccountBuddy.cpp#442 for example for mobile
20:13:07 <flo> clokep: your comment appeared in the bug (if the comment was the 2 lines saying I suggested this approach)
20:13:31 <clokep> flo: Nope, I had added comment in the code, but I think I added it to the other file I had open. :)
20:13:58 <flo> do we want to compare the href with the text of the current textnode, or the text content of the a node?
20:13:58 <clokep> Its pretty obvious what the code is doing anyway.
20:15:28 <Mic> Shouldn't it check if any parent of the node is a link?
20:15:43 <clokep> Hmm....
20:16:03 <clokep> I only tested it with things that were automatically linked.
20:17:19 <flo> Mic: That's exactly what I was wondering while driving home
20:17:24 <flo> the answer is probably "no" :)
20:19:20 <clokep> Sorry I got a phone call.
20:19:49 <clokep> I have an issue though...I can't test that.
20:19:54 <clokep> Since Instantbird can't send links AFAIK?
20:21:17 <flo> doesn't it linkify the outgoing messages before sending them?
20:21:29 <clokep> Only if it looks like a link though.
20:21:49 <clokep> Mic, flo, what situation are you expecting this not to work for?
20:22:14 <flo> Mic: if the a node is not the direct parent of the text node, then we have another tag which is the parent of the text node. This means that the content of the a node is not *only* an URL, and so, it's OK to add emoticons.
20:22:41 <flo> so the proposed check is enough :)
20:22:55 <clokep> flo: That was my assumption too. :)
20:23:06 <clokep> I.e. we're really only checking ones that were auto-linkified.
20:23:17 <flo> no
20:23:21 <flo> we are checking all of them
20:23:37 <flo> either if they were linkified after being received or before being sent
20:25:55 <clokep> Right, but the only ones we have to worry about not linking are the ones that we autolinkified and the href exactly matches the text. If there's other tags we can not worry about it (unless you have some weird sitatuion of lik e <a href="*"><b>*</b></a>
20:26:39 <flo> ah, well, that case sucks :(
20:26:56 <flo> bah, I don't mind not fixing it.
20:27:19 <clokep> :)
20:27:28 <clokep> I think my patch will fix >90% of the time it happens.
20:27:29 <Mic> The bold tag was exactly was I was thinking about :D
20:27:35 <clokep> I mean no one /really/ inserts links, the yjust type them in.
20:28:37 <flo> s/type/paste/ ;)
20:32:47 <flo> clokep: do you care about the case where there are several text nodes? (= the text of the URL has been split across several consecutive text nodes)
20:33:04 <flo> if so it's probably better to check parentNode.textContent rather than aNode.data
20:33:48 <clokep> I was thinking about that. But by using aNode.data it gets this case: <a href="URL">URL some other text</a> and the "some other text" should still have smilies?
20:34:17 <flo> this would also fix some of you 10% cases. If for example there's <a href="http://XD/bla">http://XD/<b>bla</b></a>
20:35:05 <clokep> Hmm....maybe.
20:35:08 <flo> you get that other case only if "some other text" is a separate text node.
20:35:24 <clokep> Yeah, I just realized that.
20:35:35 <flo> if you really want to fix that (unlikely?) case, you can also deliberately split the text node if it starts with your URL.
20:35:39 <flo> but it is worth it?
20:35:42 <clokep> No. :)
20:35:50 * flo agrees
20:36:12 <clokep> flo: I'm gonna a test with parentNode.textContent real quick.
20:37:32 <flo> try the other thing in the review comment too :)
20:37:36 <instantbot> florian@instantbird.org denied review for attachment 364 on bug 207.
20:37:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=207 min, --, ---, clokep, ASSI, URLs should not contain Smileys
20:37:46 <clokep> flo: I'll check it out.
20:37:50 --> GeekShadow has joined #instantbird
20:38:24 <flo> checking .tagName is not enough if you happen to be in an XML document and there are nodes in multiple namespaces.
20:38:35 <clokep> Mmmm. I didn't realize that.
20:38:44 <clokep> Quick question, anyway I can test the multiple text modes?
20:38:50 <clokep> Or make someone IM me that can do bold and stuff?
20:39:16 <flo> you can use /raw to send HTML code
20:39:23 <flo> and talk to yourself :)
20:39:43 <clokep> :) Didn't know that.
20:39:44 <clokep> Thanks!
20:39:44 <flo> for the split node, you only need to put an HTML tag that will be filtered out
20:39:49 * Mic niether
20:39:51 <Mic> *neither
20:40:14 <flo> it's still not clear if we should keep it or put it only when building with --enable-debug
20:40:25 <flo> but it's currently here :)
20:40:47 <Mic> omg, this is awesome :)
20:41:09 <flo> Mic: :-D
20:41:21 <clokep> <b>http://google.com</b>
20:41:25 <clokep> Oops. :)
20:41:28 <clokep> Wrong conversation. ;)
20:41:29 <flo> clokep: IRC doesn't support HTML
20:41:56 <Mic> well, worked fine on the IRC pm that I just wrote to myself
20:42:15 <clokep> Uhh...When I type "<b>http://google.com</b>" into my AIM conversation, on the otherside it links it, the "<b>" tags are plain text and I get a semi-colon. :-\ That doesn't seem right?
20:42:37 <flo> I get the same here on IRC
20:43:03 <clokep> That doesn't seem right....
20:43:44 <flo> I don't know where the semicolon can come from
20:44:07 <clokep> I wonder if it comes from the Mozilla code.
20:44:11 <Mic> sorry, I was wrong ..
20:44:20 <clokep> Cause the </b> is linked too.
20:44:46 <flo> or libpurple maybe?
20:44:55 <clokep> Maybe.
20:44:56 <flo> they have their linkification code too
20:45:25 <flo> I've always wanted to nuke it because we do our own and it's stupid to have it done twice (and I don't trust the way they "parse" it at all)
20:45:40 <flo> I guess someday I will :-D
20:46:49 <flo> by the way, for javascript code that is excuted in a normal js file in a window, you can use HTMLAnchorElement as a shorthand for Components.interfaces.nsIDOMHTMLAnchorElement
20:46:55 <flo> I don't think it work in modules or components though :(
20:49:58 <Mic> I managed to create some formatting that looks like the average AIM message :)
20:50:15 <Mic> Unfortunately you can't use gradients on the background though :S
20:51:36 <skeledrew> tengo mucho tarea por el fin de semana :(
20:51:58 <skeledrew> uhh
20:51:58 <skeledrew> oops
20:53:21 <Mic> Buena suerte con tu trabajo?
20:53:39 <skeledrew> room's getting larger and larger every time...
20:53:43 <Mic> ok, that was google-translate :D
20:53:50 <skeledrew> lolz
20:53:51 <skeledrew> huh?
20:54:19 <skeledrew> school work's kinda ok. if that's what you asked...
20:54:41 <skeledrew> gonna be a busy weekend though
20:54:51 <Mic> no, the question mark's only there because I wasn't sure if it's correct
20:54:54 <clokep> Partying I bet. ;)
20:54:59 * clokep is now known as clokep_halo
20:55:05 <Mic> I wanted to say "good luck with your work"
20:55:11 <skeledrew> clokep: lol
20:55:14 <skeledrew> Mic: k
20:55:22 <skeledrew> ah yes
20:55:54 <skeledrew> should be "tu trabajas"
20:56:25 <skeledrew> Spanish is making me crazier
20:59:27 <-- micahg has quit (Ping timeout)
21:12:28 <clokep_halo> flo: made the changes you suggested.
21:12:35 <clokep_halo> I'll see about playing with the other thing if I can.
21:13:22 <-- Seji has quit (Ping timeout)
21:13:58 <flo> ok :)
21:14:45 --> Seji has joined #instantbird
21:38:58 --> GeekShad0w has joined #instantbird
21:40:31 <-- GeekShadow has quit (Ping timeout)
21:40:48 --> GeekSh4dow has joined #instantbird
21:43:22 <-- GeekShad0w has quit (Ping timeout)
22:01:45 --> micahg has joined #instantbird
22:20:00 <flo> Good night
22:22:20 <-- micahg has quit (Quit: Leaving.)
23:02:19 <-- clokep_halo has quit (Ping timeout)
23:05:02 --> clokep has joined #instantbird
23:12:22 <-- GeekSh4dow has quit (Quit: The cake is a lie !)
23:36:44 --> hicham has joined #instantbird