All times are UTC.
00:11:49 --> abdelrhman has joined #instantbird 00:15:04 --> Alex2 has joined #instantbird 00:19:25 <-- nhnt11 has quit (Ping timeout: 121 seconds) 00:54:55 <-- abdelrhman has quit (Connection closed) 00:54:58 --> abdelrhman has joined #instantbird 01:18:37 --> nhnt11 has joined #instantbird 01:18:37 * ChanServ sets mode +h nhnt11 01:33:45 <-- abdelrhman has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 01:41:19 <-- bogdan_maris has quit (Ping timeout: 121 seconds) 02:00:29 <-- clokep_work has quit (Ping timeout: 121 seconds) 02:12:21 <-- nhnt11 has quit (Connection closed) 02:13:37 --> nhnt11 has joined #instantbird 02:13:37 * ChanServ sets mode +h nhnt11 02:28:15 <instant-buildbot> build #3153 of macosx-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/3153 03:23:43 <-- nhnt11 has quit (Ping timeout: 121 seconds) 03:59:48 --> nhnt11 has joined #instantbird 03:59:48 * ChanServ sets mode +h nhnt11 04:02:42 --> nhnt12 has joined #instantbird 04:02:42 * ChanServ sets mode +h nhnt12 04:06:02 <-- nhnt11 has quit (Ping timeout: 121 seconds) 04:06:02 * nhnt12 is now known as nhnt11 04:14:06 <-- nhnt11 has quit (Ping timeout: 121 seconds) 04:19:23 --> nhnt11 has joined #instantbird 04:19:23 * ChanServ sets mode +h nhnt11 04:19:49 <instant-buildbot> build #680 of linux64-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/680 04:45:49 --> Bollebib has joined #instantbird 05:00:42 <-- nhnt11 has quit (Connection closed) 05:01:54 --> nhnt11 has joined #instantbird 05:01:54 * ChanServ sets mode +h nhnt11 05:30:16 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 05:50:08 <-- EionRobb has quit (Quit: Leaving.) 06:03:28 --> bogdan_maris has joined #instantbird 06:45:18 --> EionRobb has joined #instantbird 06:48:02 <-- nhnt11 has quit (Ping timeout: 121 seconds) 06:50:28 --> unghost has joined #instantbird 07:13:58 --> nhnt11 has joined #instantbird 07:13:58 * ChanServ sets mode +h nhnt11 07:55:22 <-- unghost has quit (A TLS packet with unexpected length was received.) 08:01:08 <-- nhnt11 has quit (Ping timeout: 121 seconds) 08:20:21 --> gerard-majax has joined #instantbird 08:34:40 --> nhnt11 has joined #instantbird 08:34:40 * ChanServ sets mode +h nhnt11 08:40:06 <-- gerard-majax has quit (Ping timeout: 121 seconds) 08:43:03 --> gerard-majax has joined #instantbird 09:07:10 <-- gerard-majax has quit (Ping timeout: 121 seconds) 09:21:52 <-- nhnt11 has quit (Connection closed) 09:22:58 --> nhnt11 has joined #instantbird 09:22:59 * ChanServ sets mode +h nhnt11 09:29:30 <-- Alex2 has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 09:33:04 <-- nhnt11 has quit (Ping timeout: 121 seconds) 09:50:44 --> gerard-majax has joined #instantbird 09:57:30 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 10:18:29 --> flo-retina has joined #instantbird 10:18:29 * ChanServ sets mode +qo flo-retina flo-retina 10:43:49 --> aleth has joined #instantbird 10:43:49 * ChanServ sets mode +o aleth 11:06:21 --> mpmc has joined #instantbird 11:29:29 --> clokep_work has joined #instantbird 11:29:30 * ChanServ sets mode +o clokep_work 12:03:16 --> abdelrhman has joined #instantbird 12:05:52 <clokep_work> abdelrhman: Hello! :) 12:06:03 <abdelrhman> Hi :) 12:09:44 <clokep_work> We gonna see another patch today for that DNS RV stuff? :) 12:09:53 <abdelrhman> Yeah, sure 12:09:54 <abdelrhman> aleth: I moved SRV code to XMPPSession as it will be simple there (since we won't cache records) 12:13:11 <abdelrhman> aleth: although the doConnect is called one, I needed it as the SRV lookup part is a promise, so we do not know when it will return with its results 12:14:18 <clokep_work> abdelrhman: It might be clearer to define it as a method on the XMPPSession objects instead of an inline function though? 12:14:19 <-- abdelrhman has quit (Connection closed) 12:14:45 <aleth> You don't need it - just use a Task for the whole thing, or a promise that immediately fulfils when no lookup is needed 12:15:16 --> abdelrhman has joined #instantbird 12:15:22 <aleth> abdelrhman: ^^ 12:15:56 <aleth> If I understand right, you may need multiple attempts to try the various srv records anyway. 12:16:06 <clokep_work> Promise.succeed or whatever? 12:17:43 <abdelrhman> aleth: yes 12:21:50 <aleth> The multiple connection attempts bit is the hard part 12:22:08 <-- clokep_work has quit (Ping timeout: 121 seconds) 12:23:47 <aleth> You shouldn't really use the automatic reconnection mechanism of the whole account for that, as that will add timeouts and delays 12:25:48 <abdelrhman> OK 12:30:53 <aleth> But maybe for the first version of the patch, use it so that the patch doesn't become too big 12:31:51 <aleth> Have you found any server with a SRV record that gives multiple addresses to try? 12:33:32 <aleth> https://xmpp.net/ might be a useful resource 12:33:55 <abdelrhman> yes, jabber.org 12:37:27 <abdelrhman> and gmail.com 12:37:36 <abdelrhman> check this https://kingant.net/check_xmpp_dns/?h=jabber.org 12:42:27 <abdelrhman> aleth: the error of catch part, what should be like? (this error happens when we fail to load resolv library or something wrong happens while loading it) 12:42:34 <aleth> ah right, gmail has a couple. 12:43:50 <aleth> abdelrhman: It's good to report a detailed error with this.ERROR or this.WARN for the logs, but use something less technical for what is shown to the user in the account manager. 12:44:13 <abdelrhman> OK 12:49:06 --> clokep_work has joined #instantbird 12:49:07 * ChanServ sets mode +o clokep_work 13:10:47 <-- abdelrhman has quit (Connection closed) 13:10:55 --> abdelrhman has joined #instantbird 14:08:33 <clokep_work> aleth, abdelrhman: I don't think that should be very hard...? But I haven't seen the code in a while so... 14:10:13 <aleth> clokep_work: It may turn out to be easy, all I mean is if it turns out to require some refactoring, it would be better to get the straightforward case working first 14:12:15 <aleth> Would be nice to have tests... but that would mean adding tests for socket.jsm. 14:24:02 <aleth> Is there a good way to do that? 14:26:43 <clokep_work> Tests? 14:26:49 <clokep_work> I don't think it requires tests for socket.jsm? 14:27:02 <clokep_work> But again...I have *no* idea how the code is arranged. 14:27:06 <clokep_work> So I can't really give a good opinion. 14:27:41 <aleth> XMPPSession's prototype is Socket 14:28:16 <clokep_work> So? 14:28:21 <clokep_work> If it's separate methods it shouldn't matter too much. 14:45:33 <-- abdelrhman has quit (Connection closed) 14:45:33 --> abdelrhman has joined #instantbird 14:55:39 <-- abdelrhman has quit (Ping timeout: 121 seconds) 15:17:51 --> gerard-majax_ has joined #instantbird 15:19:10 <-- gerard-majax has quit (Ping timeout: 121 seconds) 15:28:45 --> Bollebib has joined #instantbird 15:46:47 * gerard-majax_ is now known as gerard-majax 15:56:38 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:02:44 <-- gerard-majax has quit (Ping timeout: 121 seconds) 16:18:59 --> flo-retina has joined #instantbird 16:19:00 * ChanServ sets mode +qo flo-retina flo-retina 16:27:44 --> gerard-majax has joined #instantbird 16:46:21 <-- gerard-majax has quit (Ping timeout: 121 seconds) 16:49:52 --> gerard-majax has joined #instantbird 16:51:08 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:51:14 --> mpmc has joined #instantbird 16:54:00 --> mpmc1 has joined #instantbird 16:57:16 <-- mpmc has quit (Ping timeout: 121 seconds) 16:57:16 * mpmc1 is now known as mpmc 17:03:03 <-- gerard-majax has quit (Quit: Leaving) 17:03:08 --> gerard-majax has joined #instantbird 17:04:28 --> abdelrhman has joined #instantbird 17:16:45 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:17:15 --> gerard-majax has joined #instantbird 17:26:29 <-- abdelrhman has quit (Connection closed) 17:26:37 --> abdelrhman has joined #instantbird 17:37:46 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:43:48 <-- abdelrhman has quit (Connection closed) 17:44:35 --> abdelrhman has joined #instantbird 18:07:45 <-- abdelrhman has quit (Connection closed) 18:09:33 --> abdelrhman has joined #instantbird 18:17:33 <-- clokep_work has quit (Ping timeout: 121 seconds) 18:18:08 --> clokep_work has joined #instantbird 18:18:09 * ChanServ sets mode +o clokep_work 18:49:53 <-- abdelrhman has quit (Ping timeout: 121 seconds) 18:52:28 <-- chrisccoulson has quit (Quit: Ex-Chat) 18:52:52 --> abdelrhman has joined #instantbird 18:53:46 --> chrisccoulson has joined #instantbird 18:55:42 --> gerard-majax has joined #instantbird 18:56:55 <-- abdelrhman has quit (Ping timeout: 121 seconds) 18:57:10 <-- Tonnes has quit (Connection closed) 19:06:44 --> abdelrhman has joined #instantbird 19:10:15 <abdelrhman> the async methods in socket.jsm make it harder to get the result of trying to connect 19:12:16 --> Tonnes has joined #instantbird 19:13:06 <aleth> abdelrhman: https://dxr.mozilla.org/comm-central/source/chat/modules/socket.jsm#653 19:13:16 <aleth> xmppsession will already override these 19:14:33 <aleth> async is usually harder, and usually needed ;) 19:16:31 <-- abdelrhman has quit (Connection closed) 19:16:37 --> abdelrhman has joined #instantbird 19:26:27 <abdelrhman> the hardest part is to notify the loop that tries to connect SRV records and stop the reconnection mechanism! 19:26:51 <-- gerard-majax has quit (Ping timeout: 121 seconds) 19:28:27 <-- mpmc has quit (A TLS packet with unexpected length was received.) 19:30:18 <aleth> Maybe connecting to gmail can give you some debug logs of what a failed connection attempt looks like (if that helps) 19:31:17 <-- abdelrhman has quit (Connection closed) 19:31:24 --> abdelrhman has joined #instantbird 19:31:48 <aleth> If you put the loop inside a task it shouldn't be too bad. 19:34:06 <aleth> Or do it without a task if you prefer... 19:34:25 --> Mnyromyr has joined #instantbird 19:35:25 <-- abdelrhman has quit (Ping timeout: 121 seconds) 19:39:58 <clokep_work> abdelrhman: I'd be curious to see how the code looks now too. 19:40:04 <clokep_work> Hard to give thoughts on it without seein git 19:42:51 --> nhnt11 has joined #instantbird 19:42:51 * ChanServ sets mode +h nhnt11 19:59:09 --> abdelrhman has joined #instantbird 20:08:45 <-- clokep_work has quit (Ping timeout: 121 seconds) 20:27:40 <-- abdelrhman has quit (Connection closed) 20:36:36 --> abdelrhman has joined #instantbird 20:40:51 <-- abdelrhman has quit (Ping timeout: 121 seconds) 20:42:03 --> abdelrhman has joined #instantbird 20:48:13 <-- abdelrhman has quit (Ping timeout: 121 seconds) 20:56:50 --> abdelrhman has joined #instantbird 21:05:44 <-- abdelrhman has quit (Ping timeout: 121 seconds) 21:08:19 --> abdelrhman has joined #instantbird 21:16:27 <-- abdelrhman has quit (Ping timeout: 121 seconds) 21:24:45 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 21:26:06 --> clokep_work has joined #instantbird 21:26:06 * ChanServ sets mode +o clokep_work 21:27:03 --> nhnt11 has joined #instantbird 21:27:04 * ChanServ sets mode +h nhnt11 21:48:19 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.92 [SeaMonkey 2.40/20160118183220]) 22:45:43 --> abdelrhman has joined #instantbird 23:07:07 <-- abdelrhman has quit (Connection closed) 23:14:49 <-- Bollebib has quit (Ping timeout: 121 seconds) 23:40:21 --> abdelrhman has joined #instantbird 23:44:19 <-- aleth has quit (Quit: Instantbird 49) 23:49:09 <-- abdelrhman has quit (Connection closed) 23:49:53 --> abdelrhman has joined #instantbird 23:57:06 <-- abdelrhman has quit (Connection closed) 23:57:19 <-- nhnt11 has quit (Ping timeout: 121 seconds)