All times are UTC.
00:07:57 --> Alex1 has joined #instantbird 00:17:43 <-- myk has quit (Ping timeout: 121 seconds) 00:45:39 <Matth3w> has anyone here tried wrapping libpurple in node? or using instantbird's wrapping outside of instantbird? 00:45:54 <Matth3w> am experimenting with a matrix<->libpurple gateway 01:04:28 <EionRobb> node-purple? 01:04:59 <EionRobb> we're working on adding js plugin support to libpurple via gplugin for purple3.0 01:05:41 <EionRobb> but we've had to temporarily disable support since gjs-seed dropped support for C to be C++ only 01:05:42 <instantbot> c++ sucks 01:30:16 <-- Bollebib has quit (Ping timeout: 121 seconds) 02:06:10 --> clokep_work has joined #instantbird 02:06:10 * ChanServ sets mode +o clokep_work 02:06:34 <clokep_work> EionRobb: Does tooltip text just throw a whole thing of text at you while get_info actually returns it as elements? 02:08:45 <EionRobb> no, tooltip_text still does it as title/value pairs 02:14:17 <clokep_work> Hmmm....I'm unsure then. 02:14:20 <clokep_work> Is it a newer API? :-D 02:14:37 <EionRobb> lol 02:14:38 <EionRobb> oh, you 02:15:10 <clokep_work> Is that a no? ;) 02:42:33 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 02:42:38 --> clokep_work has joined #instantbird 02:42:38 * ChanServ sets mode +o clokep_work 03:51:32 <-- clokep_work has quit (Ping timeout: 121 seconds) 04:53:16 --> myk has joined #instantbird 05:24:43 --> afiksof has joined #instantbird 05:30:56 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 05:31:03 --> nhnt11 has joined #instantbird 05:31:03 * ChanServ sets mode +h nhnt11 05:35:00 <-- EionRobb has quit (Quit: Leaving.) 05:37:06 <-- nhnt11 has quit (Ping timeout: 121 seconds) 05:47:45 --> nhnt11 has joined #instantbird 05:47:46 * ChanServ sets mode +h nhnt11 05:59:24 <instant-buildbot> build #2895 of macosx-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2895 06:04:50 <-- afiksof has quit (Ping timeout: 121 seconds) 06:21:43 --> mpmc has joined #instantbird 06:29:36 --> afiksof has joined #instantbird 06:45:39 <-- afiksof has quit (Ping timeout: 121 seconds) 07:42:43 <-- Matth3w has quit (Quit: node-irc says goodbye) 07:42:57 --> M-matthew has joined #instantbird 07:43:18 <-- M-matthew has quit (Quit: node-irc says goodbye) 07:43:31 --> M-matthew has joined #instantbird 07:43:32 <-- M-matthew has quit (Quit: node-irc says goodbye) 07:43:46 --> M-matthew has joined #instantbird 08:00:23 <-- nhnt11 has quit (Ping timeout: 121 seconds) 08:04:45 --> afiksof has joined #instantbird 08:08:58 --> nhnt11 has joined #instantbird 08:08:59 * ChanServ sets mode +h nhnt11 08:12:21 --> gerard-majax has joined #instantbird 08:18:52 --> EionRobb has joined #instantbird 08:22:43 <flo-retina> looks like EionRobb thinks we are crazy whenever we do a user interface that doesn't strictly match what Pidgin does :-P 08:24:33 <flo-retina> aleth: I'm pretty sure our prpls objects implement nsIClassInfo, which conveniently contains an "implementationLanguage" property: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIClassInfo 08:24:39 --> aleth has joined #instantbird 08:24:40 * ChanServ sets mode +o aleth 08:24:56 <flo-retina> aleth: ^ 08:24:59 <flo-retina> (good morning! :)) 08:25:14 <-- afiksof has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 08:25:14 <-- gerard-majax has quit (Ping timeout: 121 seconds) 08:25:41 --> gerard-majax has joined #instantbird 08:25:54 <aleth> flo-retina: Oh, that's prettier than checking for wrappedJSObject :D 08:26:29 <flo-retina> #ifdef MOZ_THUNDERBIRD doesn't seem like a solution either, given the purple add-on 08:27:52 <flo-retina> I see clokep has been bolder than me with his drive by r- :-D. My comment also meant "I'll r- unless given a pretty solid reason why this is reasonable" ;). 08:28:17 <aleth> Yes 08:30:55 --> Bollebib has joined #instantbird 08:31:44 <-- gerard-majax has quit (Ping timeout: 121 seconds) 08:33:16 <aleth> I was also unhappy with the hacks piling up there 08:55:41 <flo-retina> btw, the search engines in TB seem significantly outdated too. At least the icons are quite ugly, and not retina-friendly 08:56:49 <flo-retina> Fallen: sorry for messing up that comment, thanks for pasting the actual try link! 08:57:09 <Fallen> flo-retina: no problem :) 08:57:15 <Fallen> yes, icons are pretty much outdated 08:57:19 <flo-retina> Fallen: do you find it greener enough? 08:57:48 <Fallen> flo-retina: yes, definitely. The other failures are other issues afaik 08:57:49 <Fallen> https://l10n.mozilla-community.org/~flod/p12n/collage/?channel=release&product=mail 08:57:53 <flo-retina> Fallen: somehow locally a different set of tests failed, but for some reason I couldn't really figure out (it seems locally the xpcshell HTTP servers only answered the first requests...) 08:58:12 <Fallen> yes, that bug has cost me at least half a week 08:58:18 <Fallen> I still haven't found a solution 08:58:21 <flo-retina> ah, so it's known? 08:58:33 <flo-retina> is it only happening locally, or also on treeherder? 08:59:07 <Fallen> well, known to me, not to toolkit folks. See bug 1199907 comment 0 08:59:09 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1199907 nor, --, ---, nobody, NEW, TEST-UNEXPECTED-FAIL | all-test-dirs.list:toolkit/mozapps/extensions/test/xpcshell/test_hotfix_cert. 08:59:21 <flo-retina> Fallen: well, it works outside of c-c... 08:59:33 <flo-retina> if it was also failing in m-c, I would make the search tests reset the http server after each request 08:59:35 <Fallen> it happens on TH for the hotfix_cert thingy, or at least I think it is the same issue 08:59:59 <flo-retina> but I've no good reason to add such a hack in toolkit/ if the server only fails when testing c-c 09:00:34 <Fallen> The only way to fix is is to fully re-initialize the httpd server, I tried this in the gdata provider and it worked for most test. But then I had a test that did a few more requests and it broke again 09:00:44 <Fallen> (well, "fix" is the wrong word :) 09:00:49 <flo-retina> Fallen: btw, search was actually NOT broken in TB. It's just the tests that were broken, because for some reason http://mxr.mozilla.org/comm-central/source/mail/components/shell/DirectoryProvider.cpp is not loaded when running the toolkit xpcshell tests 09:00:51 <Fallen> I hope jduell can help 09:01:32 <flo-retina> but I figured updating TB to load engines in the same was as Firefox43 does wouldn't hurt, and would make it more future proof. 09:01:45 <Fallen> heh, that has been the case so often. Thanks for updating our code there! 09:02:07 <flo-retina> do we know why the mailnews components are not loaded when running xpcshell tests from c-c? 09:02:18 <flo-retina> IMHO that makes running these tests pointless. 09:02:21 <Fallen> no idea 09:02:46 <flo-retina> because they flag non-existent issues, and would fail to catch real issues caused by mailnews. 09:03:30 <Fallen> is it easy to have them loaded? 09:03:41 <flo-retina> I have no idea 09:03:51 * flo-retina should probably paste all of that in the bug for Joshua to see 09:04:52 <flo-retina> Fallen: IIRC the browser/ components are also not loaded when running the toolkit xpcshell tests, so maybe it's non trivial, or not wanted 09:06:57 <Fallen> hm ok, maybe there is a reason then 09:32:52 <-- Alex1 has quit (Connection closed) 09:37:08 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 09:44:57 --> gerard-majax has joined #instantbird 10:09:21 --> flo-retina has joined #instantbird 10:09:21 * ChanServ sets mode +qo flo-retina flo-retina 10:34:34 <-- freaktechnik has quit (Ping timeout: 121 seconds) 10:35:59 --> freaktechnik has joined #instantbird 10:40:56 <-- BWMerlin has quit (Client exited) 10:41:14 --> BWMerlin has joined #instantbird 11:45:16 <-- EionRobb has quit (Quit: Leaving.) 12:17:55 --> clokep_work has joined #instantbird 12:17:55 * ChanServ sets mode +o clokep_work 12:22:43 <clokep_work> Is the URL-generating code in chat/ or separate for IB/TB? (re bug 1202929) 12:22:46 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1202929 nor, --, ---, nobody, UNCO, in chat, urls delimited by inferior/superior are not parsed correctly 12:23:13 <flo-retina> it's in m-c 12:23:20 <flo-retina> that's the piece from BenB, right? 12:24:16 <clokep_work> Well, yes. I know that. 12:24:19 <clokep_work> But we call it from somewhere. 12:24:44 <clokep_work> I.e. do I dup that to bug 954848 (which is an IB bug) 12:24:46 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=954848 nor, --, ---, nobody, NEW, angle bracket-delimited URL linkified with closing bracket included in link and semi-colon appended 12:24:47 <clokep_work> Or leave it as separate. 12:25:43 <flo-retina> I think it's http://mxr.mozilla.org/comm-central/source/chat/content/convbrowser.xml#499 12:28:39 <clokep_work> There's also https://dxr.mozilla.org/comm-central/source/im/content/conversation.xml#330 :) 12:28:54 <clokep_work> (But I don't think that's linking) 12:41:06 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 12:41:34 --> flo-retina has joined #instantbird 12:41:34 * ChanServ sets mode +qo flo-retina flo-retina 12:59:04 <-- myk has quit (Ping timeout: 121 seconds) 13:00:37 <-- clokep_work has quit (Ping timeout: 121 seconds) 13:03:07 <-- mpmc has quit (Connection closed) 13:03:09 --> mpmc has joined #instantbird 13:09:11 <-- Bollebib has quit (Ping timeout: 121 seconds) 14:01:00 --> myk has joined #instantbird 14:01:57 --> clokep_work has joined #instantbird 14:01:57 * ChanServ sets mode +o clokep_work 14:04:15 <-- flo-retina has quit (Connection closed) 14:04:18 --> flo-retina has joined #instantbird 14:04:19 * ChanServ sets mode +qo flo-retina flo-retina 14:10:01 <-- clokep_work has quit (Ping timeout: 121 seconds) 14:45:15 --> afiksof has joined #instantbird 14:47:56 <-- myk has quit (Ping timeout: 121 seconds) 14:55:45 --> clokep_work has joined #instantbird 14:55:45 * ChanServ sets mode +o clokep_work 14:58:23 --> clokep_work1 has joined #instantbird 14:58:23 * ChanServ sets mode +o clokep_work1 14:59:57 <-- clokep_work has quit (Ping timeout: 121 seconds) 14:59:57 * clokep_work1 is now known as clokep_work 15:05:30 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 15:06:23 --> flo-retina has joined #instantbird 15:06:23 * ChanServ sets mode +qo flo-retina flo-retina 15:06:43 --> myk has joined #instantbird 15:19:52 <-- aleth has quit (Ping timeout: 121 seconds) 15:40:57 --> aleth has joined #instantbird 15:40:58 * ChanServ sets mode +o aleth 15:58:48 --> Mnyromyr has joined #instantbird 16:10:08 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:12:28 --> flo-retina has joined #instantbird 16:12:29 * ChanServ sets mode +qo flo-retina flo-retina 16:26:39 --> arlolra has joined #instantbird 16:44:43 <-- clokep_work has quit (Ping timeout: 121 seconds) 16:45:25 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:57:29 <-- gerard-majax has quit (Ping timeout: 121 seconds) 18:14:48 --> gerard-majax has joined #instantbird 18:18:19 --> Bollebib has joined #instantbird 18:22:31 --> clokep_work has joined #instantbird 18:22:31 * ChanServ sets mode +o clokep_work 18:25:34 <-- gerard-majax has quit (Ping timeout: 121 seconds) 18:38:39 <-- clokep_work has quit (Ping timeout: 121 seconds) 18:39:37 --> gerard-majax has joined #instantbird 18:44:14 --> hadi has joined #instantbird 19:00:10 <-- gerard-majax has quit (Ping timeout: 121 seconds) 19:11:19 --> clokep_work has joined #instantbird 19:11:19 * ChanServ sets mode +o clokep_work 19:13:18 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 19:14:53 <-- Mnyromyr has quit (Ping timeout: 121 seconds) 19:15:44 --> Mnyromyr has joined #instantbird 19:30:11 --> abdelrhman has joined #instantbird 19:43:32 <-- clokep_work has quit (Ping timeout: 121 seconds) 19:45:53 <-- aleth has quit (Ping timeout: 121 seconds) 20:01:32 --> aleth has joined #instantbird 20:01:33 * ChanServ sets mode +o aleth 20:02:31 --> clokep_work has joined #instantbird 20:02:31 * ChanServ sets mode +o clokep_work 20:13:38 <abdelrhman> aleth: the interface nsIClassInfo does not have attribute implementationLanguage (http://mxr.mozilla.org/mozilla-central/source/xpcom/components/nsIClassInfo.idl) 20:18:58 <clokep_work> abdelrhman: I think that was removed recently. 20:19:00 <aleth> abdelrhman: you're right, it was removed 20:19:02 <aleth> bug 1147572 20:19:05 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1147572 nor, --, mozilla40, continuation, RESO FIXED, Remove GetImplementationLanguage from DOMClassInfo 20:19:15 <aleth> Someone forgot to update mdn... 20:21:14 <clokep_work> Add dev doc needed? 20:21:19 <aleth> Already done 20:21:55 <aleth> So... what to use instead? That wrappedJSObject check, after all? 20:27:20 <clokep_work> I still don't understand why we can't remove that check for specific protocols. 20:27:47 <aleth> The idea now is to remove it and replace it with a check for JS prpl 20:29:24 <aleth> If you just want to go ahead and throw whatever libpurple returns on get_info into a tooltip... idk, maybe check what that would mean? 20:30:45 <aleth> e.g. whether that can end up being way too much data 20:31:46 <clokep_work> I'd like to understand why that was added. :-D 20:37:29 <abdelrhman> aleth: I think we won't be able to use implementationLanguage, as this can cause a crash as we do not guarantee it's implemented by other classes under this interface, right? 20:37:43 <aleth> abdelrhman: You can't use it, it's gone. 20:39:01 <abdelrhman> :( is there any alternative? 20:41:16 --> EionRobb has joined #instantbird 20:42:20 <abdelrhman> I think also we also need to remove it from c-c (http://mxr.mozilla.org/comm-central/search?string=implementationLanguage) 20:42:49 <aleth> Yes, you're right, that should be done. 20:49:58 <abdelrhman> aleth: where the current code of libpurple that we use? 20:50:23 <aleth> http://hg.mozilla.org/users/florian_queze.net/purple 20:50:30 <abdelrhman> thanks 20:57:45 <abdelrhman> can we modify/add code in libpurble? 21:00:25 <-- redDragon has quit (Ping timeout: 121 seconds) 21:01:25 <clokep_work> abdelrhman: I'd expect purplexpcom to be modified, not libpurple. 21:03:36 --> redDragon has joined #instantbird 21:03:59 <abdelrhman> yes, I mean there ( I thought repo. is called libpurple). Actually, I think we need to modify here (http://hg.mozilla.org/users/florian_queze.net/purple/file/cfb3392fcd20/purplexpcom/src/purpleProtocol.cpp) 21:05:57 <abdelrhman> clokep_work: I've noticed in irc that you have method called baseId, what's the main use of it? (https://dxr.mozilla.org/comm-central/source/chat/protocols/irc/irc.js#1912) 21:06:26 <freaktechnik> (Aren't the classIDs unique?) 21:06:59 <clokep_work> abdelrhman: The repo is called "purple". 21:07:11 <abdelrhman> yes, I noticed that. 21:07:16 <EionRobb> abdelrhman: if you want to modify libpurple, we'd love to have the IB patches ported! :) 21:07:36 <clokep_work> freaktechnik: They should be, I don't know how that would help though. 21:07:49 <freaktechnik> good old blocklist. 21:08:10 <freaktechnik> if you don't want something like canShowRealTooltip 21:08:25 <clokep_work> abdelrhman: I believe baseId is used in jsProtoHelper. 21:08:30 <clokep_work> freaktechnik: Not following, sorry. 21:08:54 <abdelrhman> freaktechnik: but when id is changed for any reason, you need to search in code for the old one to replace with the new one. I think this way is not efficient. 21:09:26 <freaktechnik> well, then an attribute stating support is probably the cleanest, tbh. 21:09:33 <abdelrhman> clokep_work: are you sure (https://dxr.mozilla.org/comm-central/source/chat/modules/jsProtoHelper.jsm#848)? 21:09:46 <clokep_work> abdelrhman: No, that's why I said "I believe" 21:10:00 <abdelrhman> :D 21:10:27 <clokep_work> abdelrhman: It looks unused: https://dxr.mozilla.org/comm-central/search?q=baseId+path%3Achat%2F&redirect=true&case=true&limit=68&offset=0 21:12:22 <abdelrhman> EionRobb: sure ;) 21:23:38 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.92 [SeaMonkey 2.35/20150825182814]) 21:25:59 <abdelrhman> clokep_work: I'm seeking to add method in jsProtoHelper and purplexpcom to help us differentiate between js protocols and purple. I'm not sure if this is OK? 21:26:46 <clokep_work> abdelrhman: It is not. 21:26:55 <clokep_work> If you want to add something, I'd say add something about whether to call that method or not. 21:26:55 <abdelrhman> something like implementationLanguage 21:27:01 <clokep_work> But I *still* don't understand why we need it. 21:28:23 <aleth> My guess is: because noone could be bothered to go through all the libpurple prpls and check what they might return :P 21:28:52 <abdelrhman> :D actually, I'm checking that now 21:30:20 <aleth> clokep_work: as an example, JS-XMPP doesn't put all of the vcard in the tooltip, as tha might make the tooltip too huge. 21:30:48 <clokep_work> aleth: Then why don't we just return EmptyEnumerator from purplexpcom? 21:31:25 <aleth> I guess we didn't want to break libpurple's requestBuddyInfo for addons? 21:31:46 <aleth> Not sure. 21:36:24 <aleth> clokep_work: Hmm, actually looking at the code now, I'm confused. There's no prpl check when calling requestBuddyInfo for MUC participant tooltips, only for contact tooltips. 21:36:51 <-- clokep_work has quit (Ping timeout: 121 seconds) 22:01:03 --> hadi1 has joined #instantbird 22:02:57 <-- hadi has quit (Ping timeout: 121 seconds) 22:03:10 --> hadi has joined #instantbird 22:05:04 <-- hadi1 has quit (Ping timeout: 121 seconds) 22:34:09 <-- Bollebib has quit (Ping timeout: 121 seconds) 22:40:18 <-- afiksof has quit (Connection closed) 22:40:34 --> afiksof has joined #instantbird 23:11:37 <-- afiksof has quit (Connection closed) 23:12:13 --> afiksof has joined #instantbird 23:47:43 <abdelrhman> aleth: for regression bug, if you can fix it and I'm not available tomorrow, just take that bug ;) 23:49:38 <abdelrhman> Good night 23:49:43 <-- abdelrhman has quit (Quit: Leaving) 23:58:33 <-- aleth has quit (Ping timeout: 121 seconds)