#instantbird log on 09 08 2015

All times are UTC.

00:09:49 --> Alex1 has joined #instantbird
01:23:39 <-- nhnt11 has quit (Ping timeout: 121 seconds)
01:25:33 --> nhnt11 has joined #instantbird
01:25:33 * ChanServ sets mode +h nhnt11 
01:50:33 <-- chrisccoulson has quit (Connection closed)
02:05:10 <Mook> Hmm, does anybody recall what I need to get remote debugging from Firefox to work?
02:05:14 <-- micahg has quit (Quit: Ex-Chat)
02:05:28 --> micahg has joined #instantbird
02:26:29 --> myk has joined #instantbird
02:27:32 --> clokep_work has joined #instantbird
02:27:32 * ChanServ sets mode +o clokep_work 
02:28:37 <clokep_work> Mook: You likely want to ask Fallen.
02:28:42 <clokep_work> Who's definitely asleep right now.
02:29:12 <-- clokep_work has quit (Connection closed)
02:29:14 --> clokep_work has joined #instantbird
02:29:14 * ChanServ sets mode +o clokep_work 
02:31:58 <Mook> My current workaround is to work on the prpl in Thunderbird... where the debugging does work.
02:40:01 <clokep_work> Hah OK. :)
02:40:05 <clokep_work> Sorry I don't know. :-\
02:40:09 <clokep_work> I suspect we have to port something
03:18:59 <-- clokep_work has quit (Ping timeout: 121 seconds)
04:34:01 <instant-buildbot> build #2891 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2891
04:49:39 <-- myk has quit (Ping timeout: 121 seconds)
05:21:56 --> afiksof has joined #instantbird
05:46:00 <-- afiksof has quit (Ping timeout: 121 seconds)
05:59:07 --> afiksof has joined #instantbird
06:14:41 <-- EionRobb has quit (Quit: Leaving.)
06:17:23 --> afiksof1 has joined #instantbird
06:19:31 <-- afiksof has quit (Ping timeout: 121 seconds)
06:19:31 * afiksof1 is now known as afiksof 
06:49:35 <-- afiksof has quit (Ping timeout: 121 seconds)
07:25:26 --> gerard-majax has joined #instantbird
07:27:35 --> mpmc has joined #instantbird
07:50:25 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
07:50:30 --> nhnt11 has joined #instantbird
07:50:31 * ChanServ sets mode +h nhnt11 
08:12:40 --> EionRobb has joined #instantbird
08:24:29 --> aleth has joined #instantbird
08:24:30 * ChanServ sets mode +o aleth 
08:34:18 <Fallen> Mook: https://developer.mozilla.org/en-US/docs/Tools/Remote_Debugging/Thunderbird
08:34:47 <Fallen> oh for instantbird I guess
08:35:04 <Fallen> what gecko version?
08:50:53 <Fallen> generally you'll need to install the remote devtools extension, but I haven't updated it on amo since gecko 29 since it worked until somewhere in the 30's
08:53:20 --> afiksof has joined #instantbird
08:59:04 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:32:11 --> chrisccoulson has joined #instantbird
09:32:43 --> flo-retina has joined #instantbird
09:32:43 * ChanServ sets mode +qo flo-retina flo-retina 
09:34:45 <-- Alex1 has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
10:29:24 <-- BWMerlin has quit (Client exited)
10:29:41 --> BWMerlin has joined #instantbird
10:31:12 --> afiksof1 has joined #instantbird
10:31:33 <-- afiksof has quit (Ping timeout: 121 seconds)
10:31:33 * afiksof1 is now known as afiksof 
10:33:34 --> freaktechnik_ has joined #instantbird
10:34:48 <-- freaktechnik has quit (Ping timeout: 121 seconds)
10:34:48 * freaktechnik_ is now known as freaktechnik 
10:37:35 <-- afiksof has quit (Ping timeout: 121 seconds)
10:57:14 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:57:45 --> flo-retina has joined #instantbird
10:57:45 * ChanServ sets mode +qo flo-retina flo-retina 
11:31:30 --> clokep_work has joined #instantbird
11:31:30 * ChanServ sets mode +o clokep_work 
11:32:31 <-- clokep_work has quit (Connection closed)
11:32:33 --> clokep_work has joined #instantbird
11:32:33 * ChanServ sets mode +o clokep_work 
11:42:04 <-- dustinm` has quit (Ping timeout: 121 seconds)
12:14:26 <-- EionRobb has quit (Quit: Leaving.)
12:16:34 --> dustinm` has joined #instantbird
13:06:49 <-- clokep_work has quit (Ping timeout: 121 seconds)
13:55:42 --> clokep_work has joined #instantbird
13:55:43 * ChanServ sets mode +o clokep_work 
14:02:42 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:09:49 <-- clokep_work has quit (Ping timeout: 121 seconds)
14:19:24 <-- gerard-majax has quit (Ping timeout: 121 seconds)
14:19:51 --> gerard-majax has joined #instantbird
14:27:46 --> flo-retina has joined #instantbird
14:27:46 * ChanServ sets mode +qo flo-retina flo-retina 
14:30:32 --> clokep_work has joined #instantbird
14:30:32 * ChanServ sets mode +o clokep_work 
15:22:49 <-- aleth has quit (Ping timeout: 121 seconds)
15:37:18 <-- clokep_work has quit (Ping timeout: 121 seconds)
15:38:18 <-- dustinm` has quit (Ping timeout: 121 seconds)
15:40:39 --> aleth has joined #instantbird
15:40:39 * ChanServ sets mode +o aleth 
15:45:07 --> myk has joined #instantbird
15:50:37 --> clokep_work has joined #instantbird
15:50:38 * ChanServ sets mode +o clokep_work 
15:53:38 --> arlolra has joined #instantbird
15:58:42 <-- clokep_work has quit (Ping timeout: 121 seconds)
16:00:27 --> clokep_work has joined #instantbird
16:00:28 * ChanServ sets mode +o clokep_work 
16:02:09 --> Mnyromyr has joined #instantbird
16:04:40 --> dustinm` has joined #instantbird
16:12:34 <-- clokep_work has quit (Ping timeout: 121 seconds)
16:20:52 <-- myk has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:20:54 --> myk has joined #instantbird
16:31:26 --> afiksof has joined #instantbird
16:42:32 --> clokep_work has joined #instantbird
16:42:32 * ChanServ sets mode +o clokep_work 
17:22:17 --> abdelrhman has joined #instantbird
17:24:07 <-- clokep_work has quit (Ping timeout: 121 seconds)
17:52:11 <-- abdelrhman has quit (Quit: Leaving)
17:58:49 --> myk1 has joined #instantbird
18:01:19 <-- myk has quit (Connection closed)
18:01:28 --> myk has joined #instantbird
18:02:51 <-- myk1 has quit (Ping timeout: 121 seconds)
18:19:20 --> clokep_work has joined #instantbird
18:19:20 * ChanServ sets mode +o clokep_work 
18:29:06 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:33:10 <-- myk has quit (Ping timeout: 121 seconds)
18:34:16 <-- gerard-majax has quit (Ping timeout: 121 seconds)
18:36:19 <-- clokep_work has quit (Ping timeout: 121 seconds)
18:43:32 --> abdelrhman has joined #instantbird
19:08:51 --> myk has joined #instantbird
19:23:57 <-- Suiseiseki has quit (Connection closed)
19:33:43 <abdelrhman> aleth: for bug 1172354, I think we need to spit it as I expect many revisions of patches, also many comments!
19:33:45 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1172354 nor, --, ---, a.ahmed1026, NEW, Add ban, kick, invite, msg, nick commands for XMPP MUCs
19:34:38 <aleth> abdelrhman: No problem
19:35:04 <aleth> abdelrhman: Can you take care of the TB tooltip regression from your tooltip patch?
19:37:36 <abdelrhman> aleth: yes, sure
19:38:07 <aleth> Just add the missing pref
19:38:16 <abdelrhman> OK
19:55:20 <abdelrhman> aleth: For bug 1201306, just add name and later will be one patch for all names, or add patch for name?
19:55:22 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1201306 nor, --, ---, nobody, NEW, Update the credits for Instantbird
19:56:22 --> Suiseiseki has joined #instantbird
19:57:04 <aleth> You can just add yourself if you like for now, but before the release one should check for all new contributors
19:57:45 * freaktechnik <_<
19:58:32 <abdelrhman> OK, just leave it to be added later by anyone before release :-)
20:02:08 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
20:02:19 --> chrisccoulson has joined #instantbird
20:14:33 <-- afiksof has quit (Ping timeout: 121 seconds)
20:44:19 <-- myk has quit (Ping timeout: 121 seconds)
20:50:53 --> EionRobb has joined #instantbird
20:54:55 --> Bollebib has joined #instantbird
21:46:38 <-- aleth has quit (Connection closed)
21:46:40 --> aleth has joined #instantbird
21:46:41 * ChanServ sets mode +o aleth 
21:52:25 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.92 [SeaMonkey 2.35/20150825182814])
22:09:33 --> myk has joined #instantbird
22:09:56 --> clokep_work has joined #instantbird
22:09:56 * ChanServ sets mode +o clokep_work 
22:14:54 <clokep_work> aleth, abdelrhman: I'm not sure I have a good solution, but I don't think the current one is adequate.
22:15:31 <aleth> clokep_work: I don't disagree
22:15:44 <abdelrhman> I agree with you.
22:17:00 <clokep_work> What happens if we just don't try to differentiate between the two?
22:17:02 <clokep_work> Does IB break?
22:17:15 <aleth> Don't differentiate between...?
22:17:18 <clokep_work> Do we need libpurple prpls to implement a method that returns [] or something?
22:17:25 <clokep_work> Hm....
22:17:33 <clokep_work> Let me think.
22:17:34 <aleth> libpurple prpls do implement that method, that's the problem
22:17:49 <EionRobb> which method?
22:17:57 <aleth> requestBuddyInfo
22:20:08 <abdelrhman> can we assume if chat.prpls.forcePurple pref does not exist, the current is JS-prpls.
22:20:11 <abdelrhman> ?
22:21:29 <aleth> Yes, but a try...catch around the pref call is just a worse way of doing an #ifdef TB
22:22:37 <clokep_work> Which file is thi sin?
22:22:38 <clokep_work> imtooltips?
22:22:42 <abdelrhman> I think there is a method we can use to check that (e.g. let forcePurple = hasPref(..) ? getPref(..) : "";)
22:22:57 <abdelrhman> yes, line 230
22:23:29 <clokep_work> What ahppens if we just don't restrict it like the comment says? https://dxr.mozilla.org/comm-central/source/chat/content/imtooltip.xml#226-234
22:24:16 <aleth> We have no idea whether what libpurple prpls return is suitable for a tooltip
22:24:52 <aleth> Otherwise it's OK
22:25:01 <clokep_work> I'm confused.
22:25:06 <clokep_work> How do we not know?
22:25:32 <aleth> Nobody has gone through all the prpls and checked? ;)
22:26:12 <EionRobb> are you calling libpurple's  prpl_info->get_info or prpl_info->tooltip_text?
22:26:13 <clokep_work> Worst case it shows some additional information that's not really useful?
22:28:11 <clokep_work> EionRobb: http://hg.mozilla.org/users/florian_queze.net/purple/file/cfb3392fcd20/purplexpcom/src/purpleAccount.cpp#l590
22:28:13 <clokep_work> get_info
22:28:29 <clokep_work> I need to go, be back later
22:28:41 <aleth> I don't remember exactly what the concern was at the time
22:28:42 <EionRobb> seems odd to call get_info to get a tooltip when there's a perfectly good tooltip_text function there for the taking
22:31:17 <EionRobb> you have that mapped in purpleAccountBuddy::GetTooltipInfo() from the looks of it
22:32:30 <-- clokep_work has quit (Ping timeout: 121 seconds)
22:32:33 <aleth> Yes, that info is already displayed.
22:33:07 <EionRobb> so why the devil are you doing that extra get_info call?  especially when it can take several seconds for a response?
22:33:38 <aleth> It's done asynchronously, originally to fetch WHOIS info for IRC.
22:33:53 <EionRobb> crazy
22:34:18 <-- arlolra has quit (Client exited)
22:35:29 <aleth> You're right that the delay is visible (the tooltip grows when the info arrives)
22:35:59 <EionRobb> especially crazy if the goal is to get whois, which isn't always accurate or its hidden etc
22:36:40 <aleth> It's not like you don't get a tooltip if it fails
22:36:42 <EionRobb> or for prpl-jabber, which will attempt download buddy icons
22:37:27 <EionRobb> and prpl-irc will send a VERSION thing to the other party, so you'll be spamming them if their client doesn't handle that transparently
22:37:45 <aleth> We don't use prpl-irc, thankfully ;)
22:37:46 <EionRobb> which probably explains why I keep getting VERSION pings from clokep all the time
22:37:50 <abdelrhman> aleth: this is the method that I'm talking about (https://developer.mozilla.org/en-US/Add-ons/Code_snippets/Preferences). Check last section (Checking for existence of a key)
22:38:03 <aleth> No, you get those because he's running some extension
22:39:25 <aleth> abdelrhman: Yes, it's possible, but it's not a great solution either.
22:39:36 <EionRobb> ok, I'm just getting confused by that code that says if the protocol is prpl-irc then get the buddy info
22:40:02 <aleth> EionRobb: The problem with XMPP is that it takes much longer for the average server to respond to fetching the vcard, indeed.
22:40:45 <aleth> It might be throttled or something.
22:41:09 <EionRobb> and it has to ask each resource for its vcard separately, right?
22:42:11 <aleth> iirc it currently only shows results for the current preferred resource
22:42:35 <EionRobb> but the libpurple get_info call is getting the info for all resources
22:43:07 <aleth> Right, so that's why the existing code makes sure we don't call it
22:43:52 <EionRobb> I know I'm just an outsider, but IMO hackily calling the get-info to override what the tooltip functions think is a sensible tooltip is mental
22:45:33 <aleth> You may be right
22:46:13 <aleth> It's a JS-IRC special case hack that's becoming less special, I suppose we should consider that.
22:46:40 <EionRobb> wait a sec, do your protocol id's conflict between libpurple and js-prpls?
22:47:17 <aleth> EionRobb: Yes, the protocol id is the same. You can never have both JS-IRC and libpurple-irc.
22:47:23 <EionRobb> oh dear
22:47:48 <freaktechnik> else igration to enable js-* would be fun...
22:47:51 <freaktechnik> "migration
22:48:00 <aleth> You'd have to ask flo-retina, but I suspect that was done so migration is painless.
22:48:13 <EionRobb> you guys do some crazy hacks :)
22:52:29 <-- aleth has quit (Quit: :tiuQ)
23:05:25 <-- abdelrhman has quit (Quit: Leaving)