All times are UTC.
00:11:06 <-- Mnyromyr has quit (Connection closed) 00:32:20 <-- EionRobb has quit (Ping timeout: 121 seconds) 00:35:47 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 00:36:18 --> myk has joined #instantbird 00:42:04 --> EionRobb has joined #instantbird 00:50:55 --> Tobin has joined #instantbird 00:51:49 <-- MattATobin has quit (Ping timeout: 121 seconds) 01:12:30 <-- Bollebib has quit (Connection closed) 01:30:50 <-- Nazadel has quit (Quit: Bye) 02:09:29 <-- DGMurdockIII has quit (Quit: Leaving) 02:11:34 <-- mconley has quit (Connection closed) 02:13:46 --> mconley has joined #instantbird 02:21:52 <-- mconley has quit (Connection closed) 02:26:29 --> mconley has joined #instantbird 02:33:25 <-- mconley has quit (Connection closed) 02:57:37 <-- myk has quit (Ping timeout: 121 seconds) 03:32:00 --> Widdershins has joined #instantbird 03:35:36 --> DGMurdockIII has joined #instantbird 03:35:41 <-- DGMurdockIII has quit (Connection closed) 03:42:15 --> sherief has joined #instantbird 03:51:39 <-- micahg has quit (Ping timeout: 121 seconds) 04:37:19 <-- EionRobb has quit (Quit: Leaving.) 05:02:51 --> nhnt11 has joined #instantbird 05:02:51 * ChanServ sets mode +h nhnt11 05:05:22 <instant-buildbot> build #1336 of linux-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1336 05:09:56 --> EionRobb has joined #instantbird 05:12:27 <instant-buildbot> build #1659 of win32-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1659 05:12:51 <-- nhnt11 has quit (Connection closed) 05:12:54 --> nhnt11 has joined #instantbird 05:12:54 * ChanServ sets mode +h nhnt11 05:17:28 <-- nhnt11 has quit (Connection closed) 05:17:31 --> nhnt11 has joined #instantbird 05:17:31 * ChanServ sets mode +h nhnt11 05:18:49 <instant-buildbot> build #2587 of macosx-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2587 05:46:03 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 05:46:12 --> nhnt11 has joined #instantbird 05:46:12 * ChanServ sets mode +h nhnt11 05:48:54 <-- nhnt11 has quit (Connection closed) 05:48:57 --> nhnt11 has joined #instantbird 05:48:57 * ChanServ sets mode +h nhnt11 06:14:26 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 06:14:33 --> nhnt11 has joined #instantbird 06:14:33 * ChanServ sets mode +h nhnt11 06:18:36 <-- nhnt11 has quit (Ping timeout: 121 seconds) 06:37:14 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 07:03:31 --> mudpit has joined #instantbird 07:07:41 <-- mudpit has quit (Ping timeout: 121 seconds) 07:13:09 --> Even has joined #instantbird 07:13:10 * ChanServ sets mode +o Even 07:17:43 <instant-buildbot> build #247 of linux64-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/247 07:35:37 --> ArchaicEX has joined #instantbird 07:36:15 <ArchaicEX> Has anyone else seen things like this happening in Instantbird? http://puu.sh/gy4uJ/bf4fc5aca2.png 07:37:47 <ArchaicEX> I'd never seen anything like it, but I would get brief flashes of this kind of graphical issue when I moved my mouse. 07:38:40 <ArchaicEX> It would go away if my mouse moved at all, so it took a while to get lucky enough to capture that image. 07:52:03 <ArchaicEX> Even worse, Opera, Firefox, and Steam started exhibiting the same issues. Uninstalling Instantbird didn't help. 07:54:57 <ArchaicEX> I then installed 1.2, and Instatnbird no longer had these issues, but the other programs still did. 07:58:47 <ArchaicEX> Even Firefox, which I uninstalled after removing Instantbird 1.5 and reinstalled after 1.5, still has these issues. 07:58:54 <ArchaicEX> I mean "after 1.2". 08:12:14 <-- gerard-majax has quit (Ping timeout: 121 seconds) 08:19:22 * Fallen|away is now known as Fallen 08:45:31 --> mudpit has joined #instantbird 08:46:54 --> Nazadel has joined #instantbird 08:47:29 <Fallen> ArchaicEX: I've had that with old Thunderbird versions on first time install and it didn't go away 08:47:55 <Fallen> I've just learned to live with it since its only old versions for me 08:48:39 <ArchaicEX> No idea how to get rid of it? Installing an old version of Instantbird made it work there, but reinstalling Opera and SeaMonkey didn't help. Most programs are still working fine. 08:51:40 <Fallen> No idea :-/ 08:51:56 <Fallen> Maybe talk with #gfx folks 09:30:11 --> gerard-majax has joined #instantbird 09:36:35 <-- gerard-majax has quit (Ping timeout: 121 seconds) 09:37:52 --> Bollebib has joined #instantbird 09:38:18 <-- chrisccoulson_ has quit (Quit: OSError: [Errno 130] Owner died) 09:38:53 --> chrisccoulson has joined #instantbird 09:41:37 --> nhnt11 has joined #instantbird 09:41:37 * ChanServ sets mode +h nhnt11 09:45:29 --> gerard-majax has joined #instantbird 09:52:02 <-- mudpit has quit (Ping timeout: 121 seconds) 09:56:06 --> BWMerlin has joined #instantbird 09:56:11 <-- nhnt11 has quit (Connection closed) 09:56:16 --> nhnt11 has joined #instantbird 09:56:16 * ChanServ sets mode +h nhnt11 10:02:48 <-- nhnt11 has quit (Connection closed) 10:02:50 <-- gerard-majax has quit (Ping timeout: 121 seconds) 10:02:53 --> nhnt11 has joined #instantbird 10:02:54 * ChanServ sets mode +h nhnt11 10:03:01 * Fallen is now known as Fallen|away 10:07:43 <-- ArchaicEX has quit (Client exited) 10:08:45 --> mudpit has joined #instantbird 10:20:47 <-- EionRobb has quit (Quit: Leaving.) 10:20:57 * Fallen|away is now known as Fallen 10:28:24 <-- nhnt11 has quit (Connection closed) 10:28:29 --> nhnt11 has joined #instantbird 10:28:30 * ChanServ sets mode +h nhnt11 10:33:51 <-- Tonnes has quit (Connection closed) 10:35:02 <-- nhnt11 has quit (Connection closed) 10:35:09 --> nhnt11 has joined #instantbird 10:35:10 * ChanServ sets mode +h nhnt11 10:37:37 --> Tonnes has joined #instantbird 10:49:18 <-- nhnt11 has quit (Ping timeout: 121 seconds) 11:00:07 <-- Even has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 11:00:12 --> Even has joined #instantbird 11:00:13 * ChanServ sets mode +o Even 11:00:23 <-- Even has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 11:00:26 --> Even has joined #instantbird 11:00:27 * ChanServ sets mode +o Even 11:00:28 <-- Even has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 11:00:35 --> Even has joined #instantbird 11:00:36 * ChanServ sets mode +o Even 11:08:34 --> mpmc has joined #instantbird 11:12:08 --> mudpit1 has joined #instantbird 11:12:56 <-- mudpit has quit (Ping timeout: 121 seconds) 11:13:08 --> mudpit has joined #instantbird 11:16:11 <-- mudpit1 has quit (Ping timeout: 121 seconds) 11:22:31 --> gerard-majax has joined #instantbird 11:37:59 --> qheaden has joined #instantbird 11:41:02 --> aleth has joined #instantbird 11:41:03 * ChanServ sets mode +o aleth 11:46:07 --> mpmc1 has joined #instantbird 11:46:42 <-- mpmc has quit (Ping timeout: 121 seconds) 11:46:42 * mpmc1 is now known as mpmc 11:48:38 <-- Nazadel has quit (Connection closed) 11:48:59 --> Nazadel has joined #instantbird 12:00:08 <-- mudpit has quit (Ping timeout: 121 seconds) 12:10:32 <-- BWMerlin has quit (Client exited) 12:50:14 --> Bollebib1 has joined #instantbird 12:51:53 <-- Bollebib has quit (Ping timeout: 121 seconds) 12:53:08 <-- gerard-majax has quit (Ping timeout: 121 seconds) 13:02:59 --> gerard-majax has joined #instantbird 13:33:33 --> bernard has joined #instantbird 13:42:00 <-- bernard has quit (Quit: Leaving.) 13:42:06 --> bernard has joined #instantbird 13:42:07 <-- bernard has quit (Quit: Leaving.) 14:26:38 --> mconley has joined #instantbird 14:34:59 --> bogdan_maris has joined #instantbird 14:57:26 --> Mnyromyr has joined #instantbird 15:07:24 --> myk has joined #instantbird 15:10:19 --> micahg has joined #instantbird 15:16:39 * Fallen is now known as Fallen|away 15:24:44 <-- myk has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 15:24:46 --> myk has joined #instantbird 15:27:13 <-- aleth has quit (Ping timeout: 121 seconds) 15:27:18 --> aleth has joined #instantbird 15:27:19 * ChanServ sets mode +o aleth 15:29:24 --> bernard has joined #instantbird 15:29:27 * Fallen|away is now known as Fallen 16:17:36 <-- qheaden has quit (A TLS packet with unexpected length was received.) 16:49:01 <-- gerard-majax has quit (Ping timeout: 121 seconds) 16:52:34 --> mudpit has joined #instantbird 16:58:32 --> Mook_as has joined #instantbird 17:01:12 <-- bogdan_maris has quit (A TLS packet with unexpected length was received.) 17:02:32 --> harshit has joined #instantbird 17:06:38 <-- harshit has quit (Quit: Leaving) 17:19:53 --> gerard-majax has joined #instantbird 17:22:24 <-- bernard has quit (Quit: Leaving.) 17:29:27 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:29:43 --> Defman has joined #instantbird 17:36:03 --> gerard-majax has joined #instantbird 17:46:01 --> DGMurdockIII has joined #instantbird 17:46:38 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:48:03 --> gerard-majax has joined #instantbird 17:55:35 --> nhnt11 has joined #instantbird 17:55:36 * ChanServ sets mode +h nhnt11 17:55:43 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:59:45 --> gerard-majax has joined #instantbird 18:05:00 <-- mudpit has quit (Ping timeout: 121 seconds) 18:05:24 <-- gerard-majax has quit (Ping timeout: 121 seconds) 18:11:09 <-- nhnt11 has quit (Connection closed) 18:11:13 --> nhnt11 has joined #instantbird 18:11:14 * ChanServ sets mode +h nhnt11 18:15:54 <-- Tonnes has quit (Connection closed) 18:18:12 --> Tonnes has joined #instantbird 18:20:04 <-- Widdershins has quit (Ping timeout: 121 seconds) 18:22:43 <-- aleth has quit (Ping timeout: 121 seconds) 18:23:48 <-- nhnt11 has quit (Ping timeout: 121 seconds) 18:25:55 <-- Mook_as has quit (Ping timeout: 121 seconds) 18:32:21 --> mudpit has joined #instantbird 18:36:30 <-- mudpit has quit (Ping timeout: 121 seconds) 18:42:20 --> mudpit has joined #instantbird 18:50:48 --> mconley_ has joined #instantbird 18:53:32 <-- mconley has quit (Ping timeout: 121 seconds) 18:54:35 --> aleth has joined #instantbird 18:54:36 * ChanServ sets mode +o aleth 18:56:03 <-- sherief has quit (Ping timeout: 121 seconds) 19:18:33 --> gerard-majax has joined #instantbird 19:29:03 * mconley_ is now known as mconley 19:33:37 <-- aleth has quit (Quit: :tiuQ) 19:33:41 --> aleth has joined #instantbird 19:33:41 * ChanServ sets mode +o aleth 19:36:48 <-- aleth has quit (Quit: :tiuQ) 19:37:27 --> bernard has joined #instantbird 19:39:18 --> bernard1 has joined #instantbird 19:41:29 <-- bernard has quit (Ping timeout: 121 seconds) 19:49:46 --> abdelrhman has joined #instantbird 19:50:22 <-- abdelrhman has quit (Quit: Leaving) 19:55:33 <-- myk has quit (Ping timeout: 121 seconds) 19:55:36 --> EionRobb has joined #instantbird 20:01:34 --> myk has joined #instantbird 20:18:10 --> aleth has joined #instantbird 20:18:11 * ChanServ sets mode +o aleth 20:20:20 <-- mudpit has quit (Ping timeout: 121 seconds) 20:30:05 --> flo-retina has joined #instantbird 20:30:05 * ChanServ sets mode +qo flo-retina flo-retina 20:30:24 <flo-retina> when I open the account manager, I have the "no account configured" message flashing for a split second before the accounts are displayed. I've never seen that mis-behavior before :-S 20:33:23 --> abdelrhman has joined #instantbird 20:34:10 <-- bernard1 has quit (Connection closed) 20:34:24 --> bernard has joined #instantbird 20:34:29 <abdelrhman> aleth: in the review for line 1021 in else if 20:34:45 <abdelrhman> what about moving it to this line https://dxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm?from=xmpp.jsm#979 20:35:01 <abdelrhman> as separate if condition 20:41:37 <aleth> abdelrhman: I think you probably want it here https://dxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm?from=xmpp.jsm#993 but structured like: if (muc namespace) { if (muc.left) {...} ... } 20:42:36 <aleth> The existing onPresenceStanza looks a bit sloppy to me (no namespace checks), that should be checked against the spec some other time 20:46:56 --> mudpit has joined #instantbird 20:47:30 <aleth> flo-retina: I can reproduce that, seems new 20:48:11 <flo-retina> I had very strange behaviors yesterday 20:48:31 <flo-retina> I managed to somehow disconnect my main IRC account (and only that one) using only the keyboard, while attempting to type something 20:48:32 <aleth> IB currently is broken for me after the laptop wakes from sleep 20:49:00 <flo-retina> I had also extremely slow responses when typing in the input box 20:49:03 <aleth> Very recent m-c regression... 20:53:01 <abdelrhman> ok, and In line 1031. if there is an error it will return also false 20:53:18 <abdelrhman> but do we need to print a system message? 20:54:35 <abdelrhman> and also line 1036, why "This isn't a presence stanza."? 20:55:47 <aleth> abdelrhman: if there is an error, shouldn't it be handled? 20:56:27 <aleth> That means the joining process has ended and the user should be told what happened. 20:56:39 <abdelrhman> just inform the user 20:56:44 <flo-retina> is your "very recent m-c regression" bug 1142957? 20:56:46 <aleth> In line 1036, aStanza is not a presence stanza 20:56:47 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1142957 blo, --, ---, mchang, ASSI, Resuming OS X freezes a previously opened Firefox instance 20:56:48 <flo-retina> aleth: ^ 20:57:11 <aleth> flo-retina: Yes, I think it's likely the same thing 20:58:21 <abdelrhman> why? 20:58:31 <aleth> it's an iq stanza, the argument of the callback 20:59:15 <aleth> also you shouldn't postpone the handling of the original stanza, pass it on to the muc unless you know for sure there is nothing in it that muc.onpresencestanza needs to know about 20:59:30 <abdelrhman> the iq stanza is aStanzaReceived 21:00:02 <aleth> abdelrhman: you're right, sorry. 21:00:23 <aleth> You still shouldn't put calling muc.onPresenceStanza in the callback though ;) 21:00:30 <abdelrhman> :D 21:00:34 <aleth> We should handle stanzas as they arrive. 21:01:17 <abdelrhman> ok, just moving it before this.sendStanza 21:02:09 <aleth> why not leave it where it is? 21:02:59 <aleth> otherwise you have to duplicate code. 21:03:35 <abdelrhman> you mean here https://dxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm?from=xmpp.jsm#1016 21:03:45 <aleth> yes 21:03:55 <abdelrhman> so I must not return 21:04:42 <aleth> The existing code returns early if the stanza was an error stanza. If we handle the error, we don't have to handle it again in muc.onPresenceStanza. 21:05:02 <aleth> You should return if you know everything in the stanza was handled. 21:05:19 <aleth> Otherwise, pass it on to muc.onPresenceStanza. 21:06:03 <aleth> Just read what muc.onPresenceStanza does and you can figure out for yourself... 21:06:14 <abdelrhman> but the error may come from the callback 21:06:33 <abdelrhman> ok 21:07:17 <aleth> I'm talking about this error handler https://dxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm?from=xmpp.jsm#993 21:09:53 <aleth> Just keep in your mind that onPresenceStanza is called for *all* presence stanzas not just the room joining/creating ones you are adding support for. 21:11:26 <aleth> Maybe it would help you if you took a look around the specs to get an idea of the different kinds of presence stanzas? 21:11:43 <abdelrhman> I know, but if callback returned error so onIQStanza will be called so we need to add handler there? 21:11:46 <aleth> RFC 6120, 6121, XEP 0045 21:12:21 <aleth> If the server can respond to the iq stanza you send with an error stanza, then yes you should detect it in the callback. 21:12:32 <aleth> The spec should tell you if that can happen. 21:13:50 <-- bernard has quit (Quit: Leaving.) 21:13:50 <abdelrhman> per spec it seems no 21:13:58 <aleth> Then don't worry about it. 21:14:12 <abdelrhman> ok 21:15:15 <aleth> Well, it says "If the room creation fails because the specified room configuration options violate one or more service policies (e.g., because the password for a password-protected room is blank), the service MUST return a <not-acceptable/> error." but that is for reserved rooms 21:16:46 <abdelrhman> great 21:17:19 <aleth> If you want to be future proof, check for the not-acceptable error it mentions. 21:17:31 <aleth> But it doesn't seem to matter for now. 21:19:34 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 21:20:40 <abdelrhman> ok, thanks :) 21:29:52 <-- DGMurdockIII has quit (Quit: Leaving) 21:39:36 <-- Defman has quit (A TLS packet with unexpected length was received.) 21:46:39 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.91.1 [SeaMonkey 2.33/20150308222602]) 21:54:40 <abdelrhman> aleth:I need to add flag in case of status code is 201 to avoid setting flag of muc.left 21:54:40 <abdelrhman> https://dxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm?from=xmpp.jsm#1015 21:55:01 <abdelrhman> and do that in callback 21:55:44 <aleth> all you need is an else {...} around the muc.left = false 21:55:55 <aleth> don't forget this code also runs when joining an existing room 21:56:07 <abdelrhman> aha this case I mean 22:00:57 <abdelrhman> the else of condition of checking muc spacename 22:01:44 <aleth> check the spec, but I'm guessing if you join an existing room the presence stanza has the same namespace 22:02:29 <abdelrhman> I mean this check if (x && x.uri == Stanza.NS.muc_user) 22:03:16 <abdelrhman> I put it after error handler 22:03:17 <abdelrhman> https://dxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm?from=xmpp.jsm#998 22:09:10 <aleth> I'm not sure what you're asking. Maybe section 7.2.2, 7.2.3 of the XEP will help. 22:09:40 <aleth> You can rearrange the code however you think makes the most sense ;) 22:09:59 <abdelrhman> ok :) 22:10:38 <-- mconley has quit (Connection closed) 22:10:47 <aleth> example 67 is another error you should handle 22:11:18 <aleth> ah no, sorry, that's in response to an iq stanza 22:11:46 <aleth> big spec ;) 22:12:21 <abdelrhman> :D 22:13:13 --> mconley has joined #instantbird 22:13:35 <-- myk has quit (Ping timeout: 121 seconds) 22:15:05 <-- abdelrhman has quit (Quit: Leaving) 22:17:01 --> myk has joined #instantbird 22:18:51 <-- mconley has quit (Connection closed) 22:24:38 <-- aleth has quit (Quit: :tiuQ) 22:24:54 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died) 22:40:34 --> clokep_wp8 has joined #instantbird 22:40:53 <-- clokep_wp8 has quit (Connection closed) 23:15:09 --> mconley has joined #instantbird 23:53:58 <-- Nazadel has quit (Quit: Bye)