All times are UTC.
00:12:44 <-- mconley has quit (Connection closed) 00:16:36 <-- clokep_work has quit (Ping timeout: 121 seconds) 00:18:01 <-- Bollebib has quit (Connection closed) 00:31:38 <-- DGMurdockIII has quit (Connection closed) 00:31:38 <-- dgmurdock has quit (Connection closed) 00:37:58 <abdelrhman> I got Instantbird source and build it. but when I run it, I don't see option for XMPP. 00:39:00 <clokep> abdelrhman: Tools > Preferences > Advanced > Config editor 00:39:14 <clokep> Type forcePurple 00:39:16 <clokep> And clear out the pref 00:41:09 <clokep> (If that doesn't make sense, I can provide more details. :P) 00:53:51 <abdelrhman> It worked!, thanks :) 00:56:35 <-- Tonnes has quit (Connection closed) 01:01:01 <abdelrhman> I'd like to work in this bug 1127596. but I don't know where to start! 01:01:04 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1127596 nor, --, ---, nobody, NEW, First incoming message from someone who is not a contact is dropped on the floor 01:01:38 <clokep> abdelrhman: I'd suggest you connect an account, have someone who is not a contact send you a message, ensuring you can reproduce. 01:01:57 <clokep> Then look at the protocol log to see the data that's being transferred. 01:01:58 <aleth> Use /debug in the conversation to look at the debug log. 01:02:07 <clokep> And then looking at xmpp.jsm to see how it's being parsed. 01:02:49 <aleth> You'll also need to look at xmpp-session.jsm. 01:04:58 --> Tonnes has joined #instantbird 01:04:58 <aleth> Also, when you can reproduce, compare what happens to the case that works (when the sender is a contact). 01:05:11 <clokep> Apparently we've picked up some users with the Google Talk death. 01:11:51 <-- myk has quit (Ping timeout: 121 seconds) 01:13:54 <clokep> Ironically you can't test that with Instantbird since you can't send messages to non-contacts? :-S 01:22:36 <abdelrhman> :D I tested it with web client ;) 01:22:52 <clokep> :) 01:23:20 <clokep> Occasionally we'll test stuff by sending each other messages and stuff, but generally it's better to have a way to test yourself. :) 01:23:33 <abdelrhman> the error was from "Trying to create a conversation; buddy not present:" 01:24:30 <abdelrhman> Line 1297 XMPP.jsm 01:24:55 <clokep> MXR is a good resource: https://mxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm#1297 01:25:20 <clokep> I think that error is just non-sense though, you can have a conversation even without a buddy. 01:25:40 <aleth> But the current code probably doesn't support it yet ;) 01:26:05 <clokep> aleth: I'm pretty sure you ca njust remove that if statement that abdelrhman found. 01:26:20 <aleth> clokep: Sure, remove that if statement and then see if something breaks ;) 01:27:08 <-- arlolra has quit (Client exited) 01:28:03 --> mconley has joined #instantbird 01:30:33 <-- Nazadel has quit (Connection closed) 01:30:37 --> Nazadel has joined #instantbird 01:35:12 <abdelrhman> Actually, if we commented first if statement. next issue will come from 01:35:14 <abdelrhman> this._buddies.get(aNormalizedName) 01:35:30 <clokep> Why is that an issue 01:36:37 <abdelrhman> because sender(non-contact) won't be in _buddies 01:36:53 <clokep> It's a map though, so .get will return null. 01:36:55 <aleth> True. 01:36:58 <clokep> Which I *think* is OK to send in there. 01:37:00 --> myk has joined #instantbird 01:37:17 <aleth> If it's not, you should fix it ;) 01:37:50 <clokep> I'm 99% sure that's what the IRC code does. 01:38:13 <aleth> Yeah, but it was likely fixed for the IRC code by you or me some time ago ;) 01:38:27 <aleth> And presence is still snafu if you're not a contact. 01:38:33 <clokep> https://mxr.mozilla.org/comm-central/source/chat/protocols/irc/irc.js#606 Yeah it just blindly attempts to get it. 01:38:45 <clokep> I'm slowly working on that. :-\ 01:43:46 <abdelrhman> Can we add this sender in buddies but flag it as temp. 01:44:00 <abdelrhman> and when we removeConversion 01:44:16 <abdelrhman> delete this buddy by checking flag 01:44:19 <abdelrhman> ? 01:44:20 <clokep> That's the gist of the approach I was taking. 01:44:37 <aleth> Probably not what is wanted for this bug though. 01:44:45 <clokep> So the issue with that (I think) is that a prplIAccountBuddy requires a prplIBuddy? I think. 01:45:09 <aleth> I think adding a fake buddy is out of scope for this bug. 01:47:31 <clokep> You're essentialy talking about bug 954049 01:47:34 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=954049 min, --, ---, clokep, ASSI, Presence information for IRC private messages from people not on the buddy list 01:47:43 <clokep> (But for XMPP) 01:49:21 <aleth> Yes, I don't think abdelrhman should attempt to fix that in his bug. 01:49:38 <clokep> Agreed. 01:50:05 <aleth> abdelrhman: You can take a look at what the IRC code does (which is more mature) for comparison. 01:50:23 <clokep> Hmm...my IRC code is almost in kindergarten. 01:50:25 <clokep> No longer a toddler. 01:57:57 --> mpmc has joined #instantbird 02:07:05 <-- mconley has quit (Connection closed) 02:07:06 <-- Nazadel has quit (Quit: Bye) 02:15:49 <-- Mnyromyr has quit (Connection closed) 02:16:41 <-- aleth has quit (Quit: :tiuQ) 02:21:14 <-- myk has quit (Connection closed) 02:24:06 --> myk has joined #instantbird 02:32:19 <-- myk has quit (Ping timeout: 121 seconds) 02:39:56 --> BWMerlin has joined #instantbird 02:47:26 <-- abdelrhman has quit (Quit: Leaving) 02:54:51 --> mconley has joined #instantbird 02:57:36 --> DGMurdockIII has joined #instantbird 02:58:00 <-- clokep has quit (Ping timeout: 121 seconds) 03:28:41 <instant-buildbot> build #1641 of win32-nightly-default is complete: Failure [4failed hg_1] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1641 04:02:36 <-- Mook_as has quit (Client exited) 04:31:24 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 04:59:53 <-- mudpit has quit (Ping timeout: 121 seconds) 05:03:37 <instant-buildbot> build #1320 of linux-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1320 05:15:25 <instant-buildbot> build #2563 of macosx-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2563 05:22:04 --> nhnt11 has joined #instantbird 05:22:04 * ChanServ sets mode +h nhnt11 05:24:26 <instant-buildbot> build #231 of linux64-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/231 05:28:02 <-- mconley has quit (Connection closed) 05:33:02 <-- nhnt11 has quit (Connection closed) 05:33:08 --> nhnt11 has joined #instantbird 05:33:08 * ChanServ sets mode +h nhnt11 05:33:10 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 05:52:13 --> mudpit has joined #instantbird 05:56:49 --> mudpit1 has joined #instantbird 06:00:15 <-- mudpit has quit (Ping timeout: 121 seconds) 06:00:15 * mudpit1 is now known as mudpit 06:12:22 --> myk has joined #instantbird 06:28:30 <-- myk has quit (Ping timeout: 121 seconds) 07:07:25 --> myk has joined #instantbird 07:11:43 --> mudpit1 has joined #instantbird 07:14:48 <-- mudpit has quit (Ping timeout: 121 seconds) 07:14:49 * mudpit1 is now known as mudpit 07:17:30 <-- myk has quit (Ping timeout: 121 seconds) 08:29:25 --> Defman has joined #instantbird 08:44:55 <-- DGMurdockIII has quit (Quit: Leaving) 09:23:18 <-- Defman has quit (A TLS packet with unexpected length was received.) 09:39:23 --> gerard-majax has joined #instantbird 10:12:20 --> Bollebib has joined #instantbird 10:15:11 * Fallen|away is now known as Fallen 10:31:14 --> Nazadel has joined #instantbird 10:32:43 <-- EionRobb has quit (Quit: Leaving.) 10:41:42 --> sawrubh has joined #instantbird 11:00:20 --> mudpit1 has joined #instantbird 11:04:01 <-- mudpit has quit (Ping timeout: 121 seconds) 11:04:01 * mudpit1 is now known as mudpit 12:33:39 --> sherief has joined #instantbird 12:35:44 --> mpmc has joined #instantbird 12:37:09 <flo-retina> FYI I'm touching stuff on the electricity install, so I (and the Mac & Linux slaves) will be offline for at least an hour, probably more. 12:40:41 <flo-retina> hmm, looks like there's no sshd on the linux slaves :-D 12:42:02 <-- flo-retina has quit (Connection closed) 12:43:22 --> flo-retina has joined #instantbird 12:43:23 * ChanServ sets mode +qo flo-retina flo-retina 12:43:42 <flo-retina> alright, screen+keyboard+mouse worked 12:43:45 <flo-retina> all the slaves are off 12:43:49 --> clokep has joined #instantbird 12:43:49 * ChanServ sets mode +o clokep 12:44:22 <flo-retina> now unplugging the modem, bye :) 12:44:46 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 12:46:32 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 13:13:13 --> aleth has joined #instantbird 13:13:14 * ChanServ sets mode +o aleth 13:13:44 <-- sawrubh has quit (Quit: Connection closed for inactivity) 13:17:36 <-- sukhe has quit (Quit: leaving) 13:20:50 --> sukhe has joined #instantbird 13:29:54 --> Mnyromyr has joined #instantbird 13:30:47 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 13:30:56 --> clokep has joined #instantbird 13:30:56 * ChanServ sets mode +o clokep 13:31:24 --> mikk_s has joined #instantbird 13:42:30 --> clokep_work has joined #instantbird 13:42:30 * ChanServ sets mode +o clokep_work 13:46:32 <-- clokep_work has quit (Ping timeout: 121 seconds) 13:46:47 --> harshit has joined #instantbird 14:01:08 --> mudpit1 has joined #instantbird 14:04:06 <-- mudpit has quit (Ping timeout: 121 seconds) 14:04:06 * mudpit1 is now known as mudpit 14:08:40 <-- aleth has quit (Ping timeout: 121 seconds) 14:08:46 --> aleth has joined #instantbird 14:08:47 * ChanServ sets mode +o aleth 14:19:40 <-- harshit has quit (Ping timeout: 121 seconds) 14:26:03 --> mpmc has joined #instantbird 14:33:07 --> harshit has joined #instantbird 14:37:37 <-- harshit has quit (Ping timeout: 121 seconds) 14:46:37 <-- aleth has quit (Quit: :tiuQ) 14:50:42 --> harshit has joined #instantbird 14:54:44 <-- harshit has quit (Connection closed) 15:00:28 <-- Tonnes has quit (Connection closed) 15:01:33 --> Tonnes has joined #instantbird 15:07:41 <-- BWMerlin has quit (Client exited) 15:09:59 --> harshit has joined #instantbird 15:10:27 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.91.1 [SeaMonkey 2.32/20150112202503]) 15:24:37 <-- harshit has quit (Ping timeout: 121 seconds) 15:38:05 --> harshit has joined #instantbird 15:41:30 <-- harshit has quit (Connection closed) 15:55:35 --> unghost has joined #instantbird 16:02:25 --> harshit has joined #instantbird 16:06:50 <-- harshit has quit (Ping timeout: 121 seconds) 16:15:23 --> aleth has joined #instantbird 16:15:23 * ChanServ sets mode +o aleth 16:19:51 <-- Bollebib has quit (Ping timeout: 121 seconds) 16:20:59 --> harshit has joined #instantbird 16:25:02 <-- harshit has quit (Ping timeout: 121 seconds) 16:27:50 * Fallen is now known as Fallen|away 16:32:22 <clokep> My builds failed last night. 16:32:25 <clokep> And i'm too angry to figure out why 16:32:30 --> mudpit1 has joined #instantbird 16:32:49 <-- Widdershins has quit (Ping timeout: 121 seconds) 16:33:34 <aleth> rage against the try server? 16:34:19 --> flo-retina has joined #instantbird 16:34:19 * ChanServ sets mode +qo flo-retina flo-retina 16:34:28 <clokep> Maybe. 16:34:31 --> Defman has joined #instantbird 16:34:34 <clokep> 3 failed in packaging. 16:34:41 <clokep> Linux tried to package libsipe, but I thought I removed that line? 16:34:46 <aleth> Which is odd as they didn't fail the previous time 16:34:50 <clokep> And...Mac failed in packaging purplexpcom. 16:34:57 <clokep> aleth: They didn't try to package anything the first time. 16:35:07 <aleth> ah. 16:35:08 <-- mudpit has quit (Ping timeout: 121 seconds) 16:35:08 * mudpit1 is now known as mudpit 16:36:33 <aleth> "Log could not be found" isn't really helpful. 16:37:50 <-- mikk_s has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 16:39:30 --> harshit has joined #instantbird 16:40:38 <aleth> clokep: the Mac failure has an intermittent bug filed for it 16:41:59 <clokep> aleth: But if you look at the log, it says missing files for purplexpcom. 16:42:03 <clokep> I thought of retriggering it though 16:42:08 <aleth> For Linux, https://hg.mozilla.org/try-comm-central/rev/ae41d65a536b#l2.40 maybe ? 16:42:10 <clokep> Then couldn't find my LDAP password. 16:42:26 <clokep> aleth: I'm 99% sure I removed that. :( 16:42:29 <clokep> Maybe I didn't qref? 16:45:23 <-- harshit has quit (Ping timeout: 121 seconds) 17:01:26 --> harshit has joined #instantbird 17:06:24 <-- harshit has quit (Ping timeout: 121 seconds) 17:08:07 --> abdelrhman has joined #instantbird 17:11:27 <-- mudpit has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:20:16 --> harshit has joined #instantbird 17:24:37 <-- harshit has quit (Ping timeout: 121 seconds) 17:31:38 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:34:10 --> mudpit has joined #instantbird 17:37:19 --> harshit has joined #instantbird 17:40:41 <-- harshit has quit (Connection closed) 17:54:26 <abdelrhman> aleth: I have read code in IRC https://mxr.mozilla.org/comm-central/source/chat/protocols/irc/irc.js#1634 17:54:58 --> harshit has joined #instantbird 17:55:32 <abdelrhman> but it's also a bit different because here in xmpp, we have list of buddies. 17:56:58 <abdelrhman> and this (sender) is not in it. but we need a buddy object to keep other functions denpend on that work well 18:05:44 <clokep> abdelrhman: I don't tihnk you do. I think if you just pass null it will work. 18:05:49 <clokep> Did you try that? 18:07:04 <clokep> The IRC code has a list of buddies too. 18:07:19 <clokep> And we don't always have a buddy, e.g. if I open a conversation with you right now the conversation wouldn't have a 'buddy' associated with it. 18:07:23 <clokep> Since you're not on my contact list 18:11:00 <aleth> abdelrhman: the _init function of a conversation takes a name not a buddy as the parameter, unless it is overridden for XMPP https://dxr.mozilla.org/comm-central/source/chat/modules/jsProtoHelper.jsm#451 18:16:01 <-- harshit has quit (Ping timeout: 121 seconds) 18:18:10 <abdelrhman> clokep: I did that. but It didn't work. 18:18:20 <clokep> abdelrhman: What does "didn't work" mean? 18:18:25 <aleth> abdelrhman: WHY didn't it work? 18:18:30 <abdelrhman> https://mxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm?from=xmpp.jsm#195 18:19:36 <clokep> Ah cause it's using _init wrong! 18:19:45 <clokep> As aleth said earlier, you should just pass the name into it, not the buddy. 18:19:53 <aleth> It's not wrong. 18:20:02 <aleth> It's just that you have to change it to fix this bug. 18:20:20 <clokep> aleth: sorry, I meant the constructor is wrong. 18:20:20 <aleth> You don't want _init to be overridden any more. 18:20:37 <aleth> clokep: https://mxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm?from=xmpp.jsm#193 18:20:48 <clokep> Yeah. 18:20:51 <clokep> That's wrong. 18:21:03 <clokep> It should pass in the name and try to get a buddy off that. 18:21:06 <clokep> Like the IRC code. 18:30:05 --> harshit has joined #instantbird 18:30:44 <clokep> Any chance someone wants to do a post for the IB blog? 18:32:24 <clokep> abdelrhman: Btw if what we say doesn't make sense, please feel free to ask more questions. We attribute silence to mean understanding (or at least investigating) :) 18:32:35 --> mconley has joined #instantbird 18:33:51 <abdelrhman> I'm investigating now :) 18:34:24 <abdelrhman> for further understanding 18:35:07 <clokep> :) 18:37:50 <abdelrhman> Can I create a buddy object (_accountBuddyConstructor) and pass it to conversion constructor ? 18:38:03 <-- harshit has quit (Ping timeout: 121 seconds) 18:38:55 <clokep> You can...but the issue is that a prplIAccountBuddy needs to have a imIBuddy attached to it, which needs to have an imITag attached to it so it can show up in the UI... 18:39:02 <clokep> But you don't want random people to show up in the contact list. 18:39:07 <clokep> (aleth that seem right? ^) 18:40:45 <-- gerard-majax has quit (Ping timeout: 121 seconds) 18:45:48 --> mudpit1 has joined #instantbird 18:47:07 <aleth> Yes, the problem is there is currently no notion of a temporary contact. 18:47:34 <aleth> So when you create a buddy, you're adding it to the database/the contact list etc 18:48:30 <-- mudpit has quit (Ping timeout: 121 seconds) 18:48:31 * mudpit1 is now known as mudpit 18:51:27 --> harshit has joined #instantbird 18:57:03 <-- harshit has quit (Ping timeout: 121 seconds) 18:57:14 --> mpmc has joined #instantbird 19:36:20 <abdelrhman> after changing constructor to use name instead of buddy. I need to edit buddy getters because it has nothing in this.buddy ? 19:36:54 <aleth> yes 19:36:58 * Fallen|away is now known as Fallen 19:41:10 <abdelrhman> will we let buddy be used if passed to the constructor or only rely on name? 19:41:44 <aleth> It's cleaner if you always pass a name 19:43:58 --> Bollebib has joined #instantbird 19:44:25 <-- Bollebib has quit (Connection closed) 19:44:28 --> Bollebib has joined #instantbird 19:47:15 <clokep> We should likely have someone fix that issue of "Fake account buddies" this summmer. 19:50:40 <aleth> Yes, would be nice to get that into the next release. 19:51:11 <aleth> "someone" likely you or me though... 19:51:28 <aleth> didn't you have a WIP that almost worked? 19:55:09 * Fallen is now known as Fallen|away 19:55:14 <-- Defman has quit (Quit: Going to develop something in my dreams) 19:55:18 --> Defman has joined #instantbird 20:00:30 --> abdelrhman_ has joined #instantbird 20:01:16 <clokep> Yes, the bug I linked to before had a WIP 20:01:41 <-- abdelrhman has quit (Ping timeout: 121 seconds) 20:01:59 <-- abdelrhman_ has quit (Quit: Leaving) 20:02:12 --> abdelrhman has joined #instantbird 20:06:38 <abdelrhman> I want to use MPPAccountBuddy._buddies inside XMPPConversation. 20:08:02 <clokep> I think _buddies is on the account object. 20:16:16 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:16:19 <abdelrhman> thanks 20:43:25 --> hadi has joined #instantbird 20:46:04 --> hadi1 has joined #instantbird 20:46:44 <-- hadi has quit (Connection closed) 20:46:44 * hadi1 is now known as hadi 21:03:50 --> EionRobb has joined #instantbird 21:07:11 * Fallen|away is now known as Fallen 21:17:49 --> Widdershins has joined #instantbird 21:36:20 <-- mconley has quit (Connection closed) 21:45:56 <-- Defman has quit (A TLS packet with unexpected length was received.) 21:50:03 <abdelrhman> I want your check about that and also I have problem 21:50:03 <abdelrhman> http://pastebin.instantbird.com/1207975 21:51:49 <aleth> you shouldn't need line 16-18, just use the inherited _init 21:52:39 <aleth> line 50-52 looks like stuff you should do in the constructor, not every time the getter is called 21:53:27 <aleth> you can simplify everything a lot if you add a buddy getter to XMPPConversation 21:54:01 <aleth> otherwise it looks like you are on the right track! :-) 21:59:16 <instantbot> New Instantbird - Other bug 1138094 filed by arai.unmht@gmail.com. 21:59:17 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1138094 nor, --, ---, nobody, NEW, Fix in-tree consumers that use non-standard flag argument of String.prototype.{search,match,replace} 22:14:33 --> abdelrhman_ has joined #instantbird 22:14:43 <-- abdelrhman_ has quit (Quit: Leaving) 22:15:04 --> abdelrhman_ has joined #instantbird 22:16:06 <-- abdelrhman has quit (Ping timeout: 121 seconds) 22:24:23 * Fallen is now known as Fallen|away 22:30:43 <-- sherief has quit (Ping timeout: 121 seconds) 22:36:17 <-- abdelrhman_ has quit (Quit: Leaving) 22:36:54 * Fallen|away is now known as Fallen 22:39:03 --> BWMerlin has joined #instantbird 22:46:56 * Fallen is now known as Fallen|away 22:48:20 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 22:51:29 --> mconley has joined #instantbird 23:01:24 <-- mconley has quit (Ping timeout: 121 seconds) 23:04:35 --> mconley has joined #instantbird 23:06:17 <-- hadi has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 23:22:30 <-- mconley has quit (Ping timeout: 121 seconds) 23:22:58 --> abdelrhman has joined #instantbird 23:23:25 --> mconley has joined #instantbird 23:40:47 <-- mconley has quit (Connection closed)