All times are UTC.
00:02:37 <aleth> nhnt11: That sneaky hack sounds like it should work, indeed. 00:03:00 <nhnt11> aleth: You've already reviewed it once ;) 00:03:22 <aleth> Haha, at least I agreed with my former self then ;) 00:03:27 * nhnt11 had to re-research to understand again some of what's going on here :] 00:03:29 <nhnt11> yeah 00:22:09 * Fallen is now known as Fallen|away 00:25:04 <nhnt11> aleth: Sorry, but did we agree on something about this convObj business 00:25:14 <nhnt11> I'm not sure where to add comments 00:25:48 <aleth> The places where you were initially most confused? 00:25:55 <aleth> at the time I pointed at http://log.bezut.info/instantbird/141127/#m384 00:27:23 <aleth> and you had a bunch of definitions after http://log.bezut.info/instantbird/141127/#m373 00:29:26 <-- Nazadel has quit (Quit: Bye) 00:31:07 --> mconley has joined #instantbird 00:36:40 <-- arlolra has quit (Client exited) 00:39:52 <aleth> nhnt11: I'm seeing |JavaScript strict warning: resource:///modules/index_im.js, line 341: ReferenceError: reference to undefined property this._knownConversations[convId]| when closing the active conversation, I assume your patch fixes that? 00:40:37 <nhnt11> That's weird :S 00:40:47 <nhnt11> That means convId is undefined, which shouldn't be possible 00:40:59 <aleth> It only happens when closing the conversation via the context menu. 00:41:06 <nhnt11> Hold on 00:42:20 <nhnt11> I'll look at that in a bit 00:43:02 <nhnt11> Right now I'm wondering why I shouldn't just change knownConversations from being a tree to just an array of full log paths relative to the logs directory 00:43:40 <nhnt11> I wonder if that's implemented the way it is so that it won't cause regressions if we change the logs directory strucutre 00:43:42 <nhnt11> structure* 00:43:48 <nhnt11> I think I'll leave it alone for now 00:45:03 <-- Bollebib has quit (Connection closed) 00:45:32 <nhnt11> aleth: http://pastebin.mozilla.org/8815993 00:46:29 <nhnt11> Uh, s/knownConversations/knownFiles/ 00:47:16 <aleth> That seems useful. Add a line explaining the naming scheme for the various *Objs? 00:47:25 <nhnt11> okay 00:50:38 --> Rym has joined #instantbird 00:51:37 <aleth> nhnt11: Might be a good idea to kick off a try build after you attach the patch for review. 00:54:30 <nhnt11> aleth: http://pastebin.mozilla.org/8816126 00:54:48 <nhnt11> s/represnting/representing 00:55:16 * nhnt11 doesn't like it much 00:55:55 <nhnt11> http://puu.sh/g1CcH/3edbe42751.png 00:59:55 <aleth> The previous pastebin was more readable. Should we use both? ;) 01:13:20 <aleth> nhnt11: Don't worry too much about perfecting that comment. 01:13:33 <-- Rym has quit (Ping timeout: 121 seconds) 01:13:37 <nhnt11> aleth: I actually haven't made any further changes to it :] 01:13:51 <aleth> OK :-] 01:14:11 <nhnt11> aleth: How about we (=you) pick one of them and we go with it :] 01:14:28 <aleth> Keep the one you have now. 01:14:28 <-- Mnyromyr has quit (Connection closed) 01:14:32 <nhnt11> okay 01:15:01 --> Widders has joined #instantbird 01:19:17 --> Rym has joined #instantbird 01:20:09 <nhnt11> Hmm, I think this is good to go... 01:20:48 <nhnt11> I'm testing it locally. Meanwhile, here's a diff... http://pastebin.mozilla.org/8816511 01:22:53 --> nhnt11-tb has joined #instantbird 01:23:26 <-- nhnt11-tb has quit (Client exited) 01:23:33 --> nhnt11-tb has joined #instantbird 01:23:38 <-- nhnt11-tb has quit (Client exited) 01:23:49 --> nhnt11-tb has joined #instantbird 01:24:02 <nhnt11-tb> Testing 01:24:04 <-- nhnt11-tb has quit (Client exited) 01:24:49 --> nhnt11-tb has joined #instantbird 01:25:43 <nhnt11-tb> Another one 01:26:04 <-- nhnt11-tb has left #instantbird () 01:26:24 <nhnt11> seems fine 01:26:33 --> nhnt11-tb has joined #instantbird 01:26:51 <nhnt11-tb> Let's see if pending stuff gets indexed on launch 01:26:51 <-- nhnt11-tb has quit (Client exited) 01:27:02 --> nhnt11-tb has joined #instantbird 01:28:52 <nhnt11-tb> Fail :( 01:29:25 <-- nhnt11-tb has quit (Client exited) 01:29:55 <-- aleth has quit (Quit: :tiuQ) 01:31:25 --> nhnt11-tb has joined #instantbird 01:31:34 <-- nhnt11-tb has quit (A TLS packet with unexpected length was received.) 01:31:59 --> nhnt11-tb has joined #instantbird 01:32:02 <-- nhnt11-tb has quit (Client exited) 01:33:21 --> nhnt11-tb has joined #instantbird 01:33:55 <-- mpmc has quit (Connection closed) 01:33:57 --> mpmc has joined #instantbird 01:33:58 <nhnt11-tb> This is weird 01:34:02 <nhnt11-tb> Apparently the file has been indexed 01:36:01 <nhnt11-tb> (but when I search for "pending" I get no hits) 01:37:01 <-- nhnt11-tb has quit (Client exited) 01:37:13 --> nhnt11-tb has joined #instantbird 01:38:39 <-- nhnt11-tb has quit (Client exited) 01:38:48 --> nhnt11-tb has joined #instantbird 01:39:21 <-- nhnt11-tb has quit (Client exited) 01:40:44 --> nhnt11-tb has joined #instantbird 01:40:51 <-- nhnt11-tb has quit (Client exited) 01:40:59 --> nhnt11-tb has joined #instantbird 01:41:13 <-- nhnt11-tb has quit (Client exited) 01:41:19 <nhnt11> oh wait, it's working 01:41:22 <nhnt11> weird :S 01:46:32 * nhnt11 is done with gloda for tonight 01:46:35 <nhnt11> Breakfast! 01:52:20 --> kapy has joined #instantbird 02:17:00 <-- Mook_as has quit (Client exited) 02:25:41 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 02:37:48 * Widders is now known as Widdershins 02:48:11 <-- Rym has quit (Ping timeout: 121 seconds) 02:53:14 --> sawrubh has joined #instantbird 02:54:13 <-- kapy has quit (Connection closed) 02:54:56 --> kapy has joined #instantbird 02:59:05 <-- kapy has quit (Ping timeout: 121 seconds) 03:06:26 --> kapy has joined #instantbird 03:14:44 --> Rym has joined #instantbird 03:19:11 <-- Rym has quit (Ping timeout: 121 seconds) 03:28:34 <-- kapy has quit (Connection closed) 03:39:40 --> kapy has joined #instantbird 03:41:11 <-- kapy has quit (Connection closed) 03:48:14 <-- nhnt11 has quit (Ping timeout: 121 seconds) 03:59:01 --> harshit has joined #instantbird 04:03:00 --> nhnt11 has joined #instantbird 04:03:00 * ChanServ sets mode +h nhnt11 04:06:55 <-- EionRobb has quit (Quit: Leaving.) 04:09:59 <-- mconley has quit (Connection closed) 04:11:59 <-- harshit has quit (Ping timeout: 121 seconds) 04:15:29 --> Rym has joined #instantbird 04:16:34 --> clokep has joined #instantbird 04:16:34 * ChanServ sets mode +o clokep 04:21:12 <-- Rym has quit (Ping timeout: 121 seconds) 04:26:46 <-- clokep has quit (Ping timeout: 121 seconds) 04:37:11 --> mconley has joined #instantbird 04:41:47 --> kapy has joined #instantbird 04:46:34 <-- kapy has quit (Ping timeout: 121 seconds) 04:47:18 <-- mconley has quit (Connection closed) 04:51:37 --> EionRobb has joined #instantbird 04:54:26 --> harshit has joined #instantbird 05:01:35 <instant-buildbot> build #1310 of linux-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1310 05:12:15 <-- harshit has quit (Quit: Leaving) 05:18:35 <instant-buildbot> build #2541 of macosx-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2541 05:50:21 --> nhnt12 has joined #instantbird 05:50:22 * ChanServ sets mode +h nhnt12 05:50:34 <-- nhnt11 has quit (Ping timeout: 121 seconds) 05:50:34 * nhnt12 is now known as nhnt11 05:55:56 --> kapy has joined #instantbird 05:59:19 <-- kapy has quit (Connection closed) 06:02:43 --> Bollebib has joined #instantbird 06:09:22 --> kapy has joined #instantbird 06:10:21 <-- kapy has quit (Connection closed) 06:18:49 --> Rym has joined #instantbird 06:23:16 <-- Rym has quit (Ping timeout: 121 seconds) 06:25:36 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 06:25:42 --> nhnt11 has joined #instantbird 06:25:42 * ChanServ sets mode +h nhnt11 06:39:14 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 06:45:17 <instant-buildbot> build #221 of linux64-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/221 06:52:12 --> kapy has joined #instantbird 07:02:49 <-- kapy has quit (Connection closed) 07:10:23 * Fallen|away is now known as Fallen 07:17:53 --> kapy has joined #instantbird 07:19:37 --> Rym has joined #instantbird 07:24:02 <-- Rym has quit (Ping timeout: 121 seconds) 07:29:47 <-- mudpit has quit (Ping timeout: 121 seconds) 07:33:14 * Fallen is now known as Fallen|away 07:44:30 <-- gerard-majax has quit (Ping timeout: 121 seconds) 07:46:12 --> mudpit has joined #instantbird 07:55:13 <-- kapy has quit (Connection closed) 07:57:02 --> Defman has joined #instantbird 08:20:21 --> Rym has joined #instantbird 08:24:17 <-- mudpit has quit (Ping timeout: 121 seconds) 08:24:48 <-- Rym has quit (Ping timeout: 121 seconds) 08:28:58 * Fallen|away is now known as Fallen 08:35:50 --> kapy has joined #instantbird 08:38:43 --> Even has joined #instantbird 08:38:43 * ChanServ sets mode +o Even 08:40:16 --> aleth has joined #instantbird 08:40:16 * ChanServ sets mode +o aleth 08:45:53 <-- Even has quit (A TLS packet with unexpected length was received.) 08:45:54 --> Even1 has joined #instantbird 08:45:54 * ChanServ sets mode +o Even1 08:48:23 * Even1 is now known as Even 08:49:16 <-- Even has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 08:49:18 --> Even has joined #instantbird 08:49:19 * ChanServ sets mode +o Even 08:49:32 <-- Even has quit (A TLS packet with unexpected length was received.) 08:49:35 --> Even has joined #instantbird 08:49:35 * ChanServ sets mode +o Even 08:54:56 --> Rym has joined #instantbird 09:29:39 <-- kapy has quit (Connection closed) 09:30:14 --> nhnt12 has joined #instantbird 09:30:15 * ChanServ sets mode +h nhnt12 09:31:17 <-- nhnt11 has quit (Ping timeout: 121 seconds) 09:31:17 * nhnt12 is now known as nhnt11 09:33:22 --> kapy has joined #instantbird 09:35:09 <-- EionRobb has quit (Quit: Leaving.) 09:45:16 <-- kapy has quit (Connection closed) 09:50:25 --> gerard-majax has joined #instantbird 10:06:38 <-- gerard-majax has quit (Ping timeout: 121 seconds) 10:16:53 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 10:25:58 --> BWMerlin has joined #instantbird 10:31:58 <-- aleth has quit (Ping timeout: 121 seconds) 10:32:02 --> aleth has joined #instantbird 10:32:03 * ChanServ sets mode +o aleth 10:33:21 --> nhnt12 has joined #instantbird 10:33:22 * ChanServ sets mode +h nhnt12 10:33:59 <-- nhnt11 has quit (Ping timeout: 121 seconds) 10:34:00 * nhnt12 is now known as nhnt11 10:37:19 <instant-buildbot> build #1629 of win32-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1629 10:45:41 --> kapy has joined #instantbird 10:48:32 --> AlexanderSalas has joined #instantbird 10:50:38 <-- kapy has quit (Ping timeout: 121 seconds) 10:53:03 --> gerard-majax has joined #instantbird 10:53:18 <-- dustinm` has quit (Ping timeout: 121 seconds) 10:56:30 --> kapy has joined #instantbird 10:57:52 <-- kapy has quit (Connection closed) 11:07:06 --> dustinm` has joined #instantbird 11:07:37 --> mudpit has joined #instantbird 11:08:29 <-- aleth has quit (Ping timeout: 121 seconds) 11:14:52 --> kapy has joined #instantbird 11:16:30 --> clokep has joined #instantbird 11:16:31 * ChanServ sets mode +o clokep 11:19:05 <-- kapy has quit (Ping timeout: 121 seconds) 11:20:39 --> flo-retina has joined #instantbird 11:20:39 * ChanServ sets mode +qo flo-retina flo-retina 11:23:43 <-- mudpit has quit (Ping timeout: 121 seconds) 11:35:11 --> aleth has joined #instantbird 11:35:12 * ChanServ sets mode +o aleth 11:49:58 --> panther7 has joined #instantbird 11:50:16 <panther7> hi all 11:51:22 <clokep> Hello. 11:51:27 <panther7> how to fix "purple.ssl.check_certificates = false"... in new nightly builds does not works, and client return "Error: SSL Handshake Failed" 11:52:00 <clokep> It's likely that the certificate is too weak. 11:53:23 <clokep> But I can't think of a way to confirm that... 11:53:37 <clokep> What kind of account is it? (I assume XMPP to a self-signed cert?) 11:54:01 --> mpmc has joined #instantbird 11:54:35 <-- aleth has quit (Ping timeout: 121 seconds) 11:57:58 --> aleth has joined #instantbird 11:57:59 * ChanServ sets mode +o aleth 11:59:59 <-- BWMerlin has quit (Client exited) 12:04:15 <clokep> aleth: I didn't understand the patch you put up. 12:04:22 <clokep> It juts said to group by day...does that mean not grouping by day is broken? 12:04:53 <aleth> you're never going to see all logs for "today" if the logs aren't grouped because "today" doesn't have children in the log tree. 12:05:21 <aleth> It's not broken, but the frontend expects them grouped. 12:06:07 <clokep> Do we ever have a reason *not* to group them then? 12:06:14 <aleth> No 12:06:15 <clokep> (I.e. Should we hvae removed the API) 12:06:27 <aleth> I think it does get removed in one of nhnt11's pending patches 12:06:56 <clokep> Ahhhh. 12:06:58 <clokep> Alright. :) 12:07:05 <clokep> Cool. 12:07:17 <clokep> I assume those two patches should be uplifted everywhere? 12:07:33 <aleth> Yes 12:07:37 <clokep> Fun. ;) 12:07:49 <clokep> Let's get it into trunk first and make sure no one has an exploding profile. :) 12:07:58 <aleth> haha indeed. 12:08:10 * aleth wants to see a try build 12:10:03 <-- MattATobin has quit (Ping timeout: 121 seconds) 12:12:29 <-- clokep has quit (Ping timeout: 121 seconds) 12:40:15 --> Mnyromyr has joined #instantbird 12:46:18 --> kapy has joined #instantbird 12:57:46 <-- kapy has quit (Connection closed) 12:58:07 --> kapy has joined #instantbird 13:00:43 <-- Tonnes has quit (Quit: ChatZilla 0.9.91.1 [Firefox 35.0.1/20150122214805]) 13:00:55 --> clokep_work has joined #instantbird 13:00:55 * ChanServ sets mode +o clokep_work 13:01:41 --> Tonnes has joined #instantbird 13:02:09 <-- kapy has quit (Ping timeout: 121 seconds) 13:09:51 --> kapy has joined #instantbird 13:10:49 * Fallen is now known as Fallen|away 13:25:45 --> flo-retina1 has joined #instantbird 13:25:46 * ChanServ sets mode +qo flo-retina1 flo-retina1 13:25:46 <-- flo-retina has quit (Ping timeout: 121 seconds) 13:25:46 * flo-retina1 is now known as flo-retina 13:32:13 <flo-retina> automatic nick recovery is nice :) 13:41:11 <clokep_work> Just for you! :P 14:17:30 * Fallen|away is now known as Fallen 14:23:46 --> mconley has joined #instantbird 14:28:07 <-- kapy has quit (Connection closed) 14:28:33 --> kapy has joined #instantbird 14:29:46 <-- mconley has quit (Connection closed) 14:32:35 <-- kapy has quit (Ping timeout: 121 seconds) 14:39:58 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.91.1 [SeaMonkey 2.32/20150112202503]) 14:56:46 <-- Rym has quit (Ping timeout: 121 seconds) 15:00:54 --> mconley has joined #instantbird 15:09:16 --> nhnt12 has joined #instantbird 15:09:17 * ChanServ sets mode +h nhnt12 15:10:09 <-- nhnt11 has quit (Ping timeout: 121 seconds) 15:10:09 * nhnt12 is now known as nhnt11 15:11:58 --> kapy has joined #instantbird 15:23:25 --> Rym has joined #instantbird 15:26:49 <clokep_work> aleth: WHat's textsecure? 15:27:50 <-- Rym has quit (Ping timeout: 121 seconds) 15:32:11 <aleth> clokep_work: https://github.com/WhisperSystems/TextSecure 15:32:44 <-- kapy has quit (Connection closed) 15:33:16 --> kapy has joined #instantbird 15:37:18 <-- kapy has quit (Ping timeout: 121 seconds) 15:47:36 <clokep_work> aleth: I was updating https://etherpad.mozilla.org/ib-gsoc-2015 ... 15:47:38 <clokep_work> At the bottom. 15:48:25 <clokep_work> I didn't quite add descriptons to all of them. 15:52:31 <clokep_work> flo-retina might want to look at that too when he's having some coffee. 15:52:36 <clokep_work> And maybe nhnt11. 15:52:53 <flo-retina> clokep_work: my next coffee is likely to be in a few weeks ;) 15:52:58 <clokep_work> mconley: so...that blog post about... CPOW? ... what's a 'large' number to be concerned about. :) 15:53:40 <mconley> clokep_work: a large amount of time listed in about:compartments you mean? Or a large number of "unsafe CPOW usage" warnings? 15:53:52 <clokep_work> mconley: Time in about:compartments 15:54:11 <clokep_work> Which apparently doesn't exist in non-nightly builds... :) 15:54:42 <mconley> clokep_work: a raw number isn't much use because it's cumulative over your session. Folks are working on making the number more meaningful 15:54:52 <mconley> but right now, it's just a way of sniffing out likely suspects for perf problems 15:56:37 <clokep_work> Hmm... 15:56:47 <clokep_work> Cause all the extensions look like they have insane numbers compared to the other numbers there. :) 16:19:23 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:24:10 --> Rym has joined #instantbird 16:28:37 <-- Rym has quit (Ping timeout: 121 seconds) 16:33:47 --> kapy has joined #instantbird 16:37:57 <-- kapy has quit (Connection closed) 16:37:58 --> kapy has joined #instantbird 16:38:42 --> mudpit has joined #instantbird 16:39:04 <Widdershins> CPOW is like an onomatopoeia you'd read in a spiderman comic 16:44:01 --> Tobin has joined #instantbird 16:50:43 <-- Widdershins has quit (Ping timeout: 121 seconds) 16:59:46 * Fallen is now known as Fallen|away 17:01:34 --> harshit has joined #instantbird 17:09:03 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:24:54 --> Rym has joined #instantbird 17:29:23 <-- Rym has quit (Ping timeout: 121 seconds) 17:32:58 --> nhnt12 has joined #instantbird 17:32:58 * ChanServ sets mode +h nhnt12 17:33:27 <-- nhnt11 has quit (Ping timeout: 121 seconds) 17:33:27 * nhnt12 is now known as nhnt11 17:46:55 --> Rym has joined #instantbird 17:49:11 <-- kapy has quit (Quit: ) 17:49:42 * clokep_work watches his review queue disappear. 17:50:50 <clokep_work> aleth: Ah! That was the last patch I had to review. ;) 17:51:27 <aleth> you can always steal it back from flo if you change your mind ;) 17:55:56 * mconley is now known as mconley|livehacking 17:56:02 --> flo-retina has joined #instantbird 17:56:03 * ChanServ sets mode +qo flo-retina flo-retina 17:56:37 <clokep_work> When is the merge anyway? Monday? 17:56:56 --> Mook_as has joined #instantbird 17:56:57 <aleth> sometime this weekend? 17:59:06 <-- Tonnes has quit (Connection closed) 17:59:25 --> gerard-majax has joined #instantbird 17:59:40 <flo-retina> I would assume it's Monday 18:01:23 <aleth> What are the patches with strings that are pending review? 18:01:57 <aleth> The webrtc ones I guess if we want to try to make the TB38 deadline 18:02:14 <aleth> prpl-skype 18:02:24 --> Tonnes has joined #instantbird 18:10:28 --> arlolra has joined #instantbird 18:15:48 <-- gerard-majax has quit (Ping timeout: 121 seconds) 18:21:48 <flo-retina> aleth: is there any chance of prelanding the strings for webrtc? 18:21:55 <flo-retina> do we know how many of them we needed? 18:23:29 <aleth> flo-retina: The best we could do is land the strings from the current patches for TB too 18:27:54 <aleth> but for that they should get r+ for IB first ;) 18:29:42 <clokep_work> aleth: I kind of want to wait to land skype. 18:29:45 <clokep_work> So it's *not* in 38. 18:30:01 <aleth> OK 18:30:42 <aleth> TBH I'm not super convinced video calls can make it into 38 either. The question is whether we want to keep that door open. 18:30:59 <aleth> In terms of flo-retina's review time, the other TB patches are more urgent. 18:41:51 * Fallen|away is now known as Fallen 18:53:43 --> Nazadel has joined #instantbird 18:55:44 --> gerard-majax has joined #instantbird 19:12:48 <-- gerard-majax has quit (Ping timeout: 121 seconds) 19:18:42 <-- aleth has quit (Ping timeout: 121 seconds) 19:24:00 --> aleth has joined #instantbird 19:24:01 * ChanServ sets mode +o aleth 19:33:39 * mconley|livehacking is now known as mconley 19:35:01 <-- mconley has quit (Connection closed) 19:35:20 --> mconley has joined #instantbird 19:35:57 --> EionRobb has joined #instantbird 19:36:14 <nhnt11> clokep_work, aleth: Old unindexed logs will get indexed after that patch lands, yes 19:40:07 <flo-retina> aleth: I'm looking at https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=1131255&attachment=8561638 19:40:38 <flo-retina> what could be reasons for !this.peerConnection in the first hunk? 19:43:32 <aleth> flo-retina: I don't see any valid reason. 19:43:45 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 19:43:59 <aleth> I may be wrong, so I didn't remove the check altogether. 19:44:45 <flo-retina> ok 19:47:21 <-- Defman has quit (Connection closed) 19:47:28 --> Defman has joined #instantbird 19:49:53 <flo-retina> aleth: are we never removing the video-call-error notification? 19:50:01 <flo-retina> shouldn't we remove it when the user is attempting to call again? 19:50:23 <aleth> good idea 19:51:21 <flo-retina> aleth: that patch in bug 1131255 is a bit confusing, it's not really clear why that bundle and notification box refactoring isn't directly in the patch for bug 1018060 19:51:24 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1131255 nor, --, ---, aleth, ASSI, Use ICE connection state to better determine when a video call is successful 19:51:25 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1018060 enh, --, ---, mayanktg, NEW, Video calls via XMPP/Jingle and WebRTC 19:52:19 <aleth> I don't mind how/when we do it, but at some point there has to be a cutoff and we start doing further polishing in followups 19:52:32 <flo-retina> sure 19:52:46 <flo-retina> what I mean is, most of the code changes in that patch are completely unrelated to the bug title 19:53:24 <flo-retina> and while this looks good overall, I think I would have been more likely to discover issues if the patch was more focused 19:55:39 <aleth> I'm not disagreeing at all. It's just what happens when you have a large lump of stuff sitting in your queue. I can split that patch in two if you like. 19:56:11 <flo-retina> nah, don't waste your time 19:56:22 <flo-retina> would be nice to think about it next time :) 19:56:49 <aleth> The issue all along has been a mixing together of cleaning up existing code from gsoc and adding new stuff which becomes necessary as elapsed time breaks what was previously working. 19:57:06 <aleth> That makes patches hard to follow and hard to separate. 19:57:48 <flo-retina> I know the context. I just expressed how reviewing that patch felt; I'm not blaming you at all for it. :) 19:58:39 <aleth> If you prefer we can fold it into the big patch and declare that the cutoff. 19:58:54 <flo-retina> whatever 20:04:38 --> Mnyromyr has joined #instantbird 20:10:19 --> gerard-majax has joined #instantbird 20:14:18 <-- AlexanderSalas has quit (Ping timeout: 121 seconds) 20:15:48 <-- gerard-majax has quit (Ping timeout: 121 seconds) 20:17:48 <-- Rym has quit (Ping timeout: 121 seconds) 20:18:26 --> mudpit1 has joined #instantbird 20:18:29 <-- mudpit has quit (Ping timeout: 121 seconds) 20:18:30 * mudpit1 is now known as mudpit 20:20:15 --> mudpit1 has joined #instantbird 20:22:13 <-- harshit has quit (Quit: Leaving) 20:22:31 <-- mudpit has quit (Ping timeout: 121 seconds) 20:22:31 * mudpit1 is now known as mudpit 20:32:14 --> AlexanderSalas has joined #instantbird 20:46:42 <-- flo-retina has quit (Connection closed) 20:46:45 --> flo-retina has joined #instantbird 20:46:46 * ChanServ sets mode +qo flo-retina flo-retina 20:53:37 <-- mudpit has quit (Ping timeout: 121 seconds) 20:59:49 --> mudpit has joined #instantbird 21:07:19 --> Bollebib has joined #instantbird 21:51:27 <clokep_work> aleth, flo-retina: So...I'm gonna go home now, but if you guys could look at https://etherpad.mozilla.org/ib-gsoc-2015 and finish the last couple descriptions I'd be really happy if I could update the wiki page in a few hours. :) 21:53:38 <-- sawrubh has quit (Quit: Connection closed for inactivity) 22:00:24 <-- clokep_work has quit (Ping timeout: 121 seconds) 22:06:01 <-- arlolra has quit (Client exited) 22:09:19 <flo-retina> who would have thought I still had XUL elements to discover: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/observes ! :) 22:09:43 <aleth> ah, I used that in an add-on 22:12:23 <aleth> that was a long time ago... https://bitbucket.org/aleth/togglist/src/759d0e9f608e53cf169820696102db83de2de1d4/bootstrap.js?at=default#cl-178 22:13:07 <aleth> ...used for a hack. 22:14:44 --> Bollebib1 has joined #instantbird 22:16:17 <Mook_as> Fun XUL element of the day: <bulletinboard>! (It's the old name for <stack>) 22:17:09 <aleth> Does that still work? 22:17:37 <Mook_as> Yep! 22:17:54 --> gerard-majax has joined #instantbird 22:18:20 <-- Bollebib has quit (Ping timeout: 121 seconds) 22:18:35 <flo-retina> that observes tag is magic :) 22:18:57 * flo-retina didn't write any JS to handle hiding the feature when it's pref'ed off! 22:18:58 <-- Defman has quit (Connection closed) 22:19:08 <flo-retina> (there was already an existing broadcaster for it) 22:29:03 <-- gerard-majax has quit (Ping timeout: 121 seconds) 22:32:18 --> Rym has joined #instantbird 22:38:09 --> gerard-majax has joined #instantbird 22:47:09 <-- gerard-majax has quit (Ping timeout: 121 seconds) 22:48:20 <-- AlexanderSalas has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 22:49:07 --> AlexanderSalas has joined #instantbird 22:51:11 <-- Bollebib1 has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 22:52:01 --> DGMurdockIII has joined #instantbird 22:57:57 * Fallen is now known as Fallen|away 23:06:06 --> clokep has joined #instantbird 23:06:06 * ChanServ sets mode +o clokep 23:06:55 --> clokep_work has joined #instantbird 23:06:55 * ChanServ sets mode +o clokep_work 23:08:08 * clokep_work suspects Mook_as is happy about https://hg.mozilla.org/comm-central/rev/3d6e9bd67cd9 23:09:08 <Mook_as> I am! Very! 23:09:13 <Mook_as> Thanks! :D 23:09:22 * aleth hopes you're using a daily ;) 23:09:49 <Mook_as> I am! 23:10:54 <aleth> Hmm, looks like it just missed tomorrow's daily though. On the plus side, the tree is very green 23:13:10 <clokep_work> :) 23:13:16 <clokep_work> I should crash land some things. 23:21:19 <-- clokep_work has quit (Ping timeout: 121 seconds) 23:29:27 <-- mconley has quit (Connection closed) 23:30:20 <-- Rym has quit (Ping timeout: 121 seconds) 23:44:28 <-- EionRobb has quit (Quit: Leaving.) 23:46:11 --> EionRobb has joined #instantbird 23:47:38 --> Rym has joined #instantbird