All times are UTC.
00:00:46 --> myk has joined #instantbird 00:02:44 <-- Nazadel has quit (Quit: Bye) 00:05:16 --> mconley has joined #instantbird 00:17:47 <-- AlexanderSalas has quit (Connection closed) 00:17:53 --> AlexanderSalas has joined #instantbird 00:39:00 <-- Tobin has quit (Connection closed) 01:10:50 --> harshit has joined #instantbird 01:28:17 <-- mpmc has quit (Connection closed) 01:57:20 <-- Mook_as has quit (Client exited) 02:00:02 * Fallen is now known as Fallen|away 02:00:34 <-- AlexanderSalas has quit (Ping timeout: 121 seconds) 02:01:14 * redDragon|away is now known as redDragon 02:10:36 <-- aleth has quit (Ping timeout: 121 seconds) 02:30:05 <-- myk has quit (Ping timeout: 121 seconds) 02:58:16 <-- Mnyromyr has quit (Connection closed) 03:26:34 --> AlexanderSalas has joined #instantbird 03:55:45 <-- Rym has quit (Ping timeout: 121 seconds) 03:56:05 --> Rym has joined #instantbird 04:16:06 <-- harshit has quit (Ping timeout: 121 seconds) 04:30:33 <-- EionRobb has quit (Quit: Leaving.) 04:32:59 --> harshit has joined #instantbird 04:43:08 <-- harshit has quit (Ping timeout: 121 seconds) 04:51:49 <-- mconley has quit (Connection closed) 04:56:46 --> harshit has joined #instantbird 05:02:14 <instant-buildbot> build #1305 of linux-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1305 05:10:09 --> Bollebib has joined #instantbird 05:30:49 <instant-buildbot> build #2536 of macosx-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2536 05:45:05 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 06:03:00 --> myk has joined #instantbird 06:05:43 --> kapy has joined #instantbird 06:06:26 <-- AlexanderSalas has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 06:23:45 <instant-buildbot> build #216 of linux64-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/216 06:36:26 --> EionRobb has joined #instantbird 06:39:20 <-- myk has quit (Ping timeout: 121 seconds) 06:44:23 --> Widdershins has joined #instantbird 07:01:40 --> myk has joined #instantbird 07:21:58 <-- myk has quit (Ping timeout: 121 seconds) 07:38:33 <-- mudpit has quit (Ping timeout: 121 seconds) 07:39:14 --> gerard-majax has joined #instantbird 07:54:58 --> mudpit has joined #instantbird 07:55:13 <-- Tonnes has quit (Connection closed) 07:56:49 --> Tonnes has joined #instantbird 08:12:10 * Fallen|away is now known as Fallen 08:15:24 <Fallen> crashreporter doesn't want to submit instantbird reports... 08:27:24 <-- EionRobb has quit (Connection closed) 08:29:15 --> EionRobb has joined #instantbird 08:33:05 <-- mudpit has quit (Ping timeout: 121 seconds) 08:39:21 <-- gerard-majax has quit (Ping timeout: 121 seconds) 08:50:30 <-- EionRobb has quit (Quit: Leaving.) 08:56:58 --> aleth has joined #instantbird 08:56:58 * ChanServ sets mode +o aleth 09:02:19 --> mpmc has joined #instantbird 09:09:27 --> BWMerlin has joined #instantbird 09:13:22 * Fallen is now known as Fallen|away 09:16:41 <-- aleth has quit (Ping timeout: 121 seconds) 09:19:34 --> spz has joined #instantbird 09:19:37 --> sawrubh has joined #instantbird 09:29:36 * Fallen|away is now known as Fallen 09:57:09 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 09:57:29 --> aleth has joined #instantbird 09:57:29 * ChanServ sets mode +o aleth 10:08:03 * Fallen is now known as Fallen|away 10:09:24 <-- Even has quit (A TLS packet with unexpected length was received.) 10:10:06 --> gerard-majax has joined #instantbird 10:11:31 --> Even has joined #instantbird 10:11:31 * ChanServ sets mode +o Even 10:14:19 <-- gerard-majax has quit (Ping timeout: 121 seconds) 10:18:09 --> gerard-majax has joined #instantbird 10:18:15 <-- aleth has quit (Quit: :tiuQ) 10:18:27 --> aleth has joined #instantbird 10:18:27 * ChanServ sets mode +o aleth 10:20:46 <-- spz has quit (Ping timeout: 121 seconds) 10:26:05 <-- gerard-majax has quit (Ping timeout: 121 seconds) 10:45:45 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died) 10:46:05 --> chrisccoulson_ has joined #instantbird 10:54:29 <-- chrisccoulson_ has quit (Quit: OSError: [Errno 130] Owner died) 10:54:39 --> spz has joined #instantbird 10:54:48 --> chrisccoulson has joined #instantbird 11:08:02 --> gerard-majax has joined #instantbird 11:12:09 --> Bollebib has joined #instantbird 11:13:12 --> mudpit has joined #instantbird 11:14:12 <-- flo-retina has quit (Ping timeout: 121 seconds) 11:20:03 --> clokep has joined #instantbird 11:20:03 * ChanServ sets mode +o clokep 11:23:34 <-- sawrubh has quit (Quit: Connection closed for inactivity) 11:34:32 --> flo-retina has joined #instantbird 11:34:32 * ChanServ sets mode +qo flo-retina flo-retina 11:44:35 <-- aleth has quit (Quit: :tiuQ) 11:54:08 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 11:57:47 --> aleth has joined #instantbird 11:57:47 * ChanServ sets mode +o aleth 12:14:56 <-- BWMerlin has quit (Client exited) 12:33:41 <-- mudpit has quit (Ping timeout: 121 seconds) 12:36:05 * redDragon is now known as redDragon|away 12:45:27 * Fallen|away is now known as Fallen 12:49:47 --> Mnyromyr has joined #instantbird 13:02:59 --> sherief has joined #instantbird 13:04:22 --> clokep_work has joined #instantbird 13:04:22 * ChanServ sets mode +o clokep_work 13:30:41 <-- chrisccoulson has quit (Connection closed) 13:30:43 --> chrisccoulson has joined #instantbird 13:35:20 <clokep_work> aleth: // Every media section contains an a=setup line with a value that's 13:35:20 <clokep_work> // one of: actpass / active / passive. 13:35:20 <clokep_work> let setupAttr = medium.match(/(a=setup)[\S]*/)[0].split(":")[1]; 13:35:27 <clokep_work> Can't that just be a startsWith("a=setup")? 13:35:47 <clokep_work> Or actually.. 13:35:50 <clokep_work> WTF is that line doing? 13:36:06 <clokep_work> Finding matches, getting the first group....and then splitting on ":"? 13:36:14 <clokep_work> Or no...the [0]th match is the whole string. 13:37:40 <aleth> mayanktg's code used a lot of regexes like that... We could use the parseLine helper I added there too 13:40:36 <aleth> hmm, maybe not 13:41:57 <aleth> anyway, you're right it feels obfuscated 13:42:48 <clokep_work> OK. I'll leave a coment on it with some of my thoughts. :) 13:42:54 <clokep_work> Yeah he went a big regex happy. 13:42:56 <clokep_work> *bit* 13:47:36 <instantbot> New Instantbird - Contacts window bug 1132897 filed by meyer.thibault@hotmail.fr. 13:47:37 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1132897 nor, --, ---, nobody, UNCO, avatar picture with Netsoul account 13:48:26 --> mconley has joined #instantbird 13:49:11 <clokep_work> aleth: This is way more readable though, so great job! :) 13:52:00 <flo-retina> a Netsoul bug? :-D 13:52:51 <clokep_work> Haha. 13:53:03 <flo-retina> it's cool that it still works :) 13:53:26 * flo-retina wonders if he can still login 13:54:41 <clokep_work> Wow my head hurts. 13:56:27 --> bernard has joined #instantbird 14:06:57 <flo-retina> why is it possible to have several awesometabs at once again? 14:07:34 * flo-retina just noticed he started using Command+T <first few charts of someone's nick> as a quick way to lookup if someone was available.... and that there were 3 left-over awesometabs due to that 14:08:09 <-- aleth has quit (Ping timeout: 121 seconds) 14:09:30 <clokep_work> flo-retina: Why can you have multiple about:newtabs in Firefox? ;) 14:10:24 <flo-retina> they get automatically closed on Firefox :-] 14:10:48 <clokep_work> No... 14:10:59 <clokep_work> I frequently end up with a few open. 14:11:25 --> aleth has joined #instantbird 14:11:25 * ChanServ sets mode +o aleth 14:28:23 <-- mconley has quit (Connection closed) 14:51:16 <-- bernard has quit (Connection closed) 14:54:57 <flo-retina> the ":-]" was because of https://addons.mozilla.org/firefox/addon/autoclose-tabs/ ;) 14:55:22 <clokep_work> Ahhhh! :) 14:55:28 <clokep_work> Make that compatible w/ IB? :P 14:55:29 --> bernard has joined #instantbird 14:55:31 <-- bernard has quit (Quit: Leaving.) 14:55:33 --> bernard has joined #instantbird 14:55:43 <flo-retina> clokep_work: I've thought about that so many times ;) 14:55:49 <flo-retina> but it's not directly portable 14:55:53 <clokep_work> flo-retina: I'd probably use it... 14:56:04 <flo-retina> because on Ib you are likely to have tabs you care about even though you never touch them 14:56:17 <flo-retina> ie. you would touch them only if they receive messages 14:56:54 <-- aleth has quit (Ping timeout: 121 seconds) 15:02:10 --> mconley has joined #instantbird 15:07:44 <flo-retina> has anybody seen bug 1131858 before? 15:07:47 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1131858 nor, --, ---, nobody, UNCO, undefined twitter certificate state 15:15:22 <clokep_work> No. 15:15:46 <flo-retina> it's strange that it's in 31.* and we have never seen it 15:15:48 <clokep_work> flo-retina: But maybe related to the other Twitter issues we've been having? 15:15:56 <clokep_work> flo-retina: How often do we really open that window :) 15:16:09 <flo-retina> each time it's broken :) 15:16:57 <-- kapy has quit (Connection closed) 15:22:53 <clokep_work> :P 15:23:00 <clokep_work> Each time we get a new computer? ;) 15:23:36 <flo-retina> nope 15:23:45 <flo-retina> time machine will transfer all stuff automatically 15:25:48 --> aleth has joined #instantbird 15:25:48 * ChanServ sets mode +o aleth 15:34:01 * Fallen is now known as Fallen|away 15:38:21 * Fallen|away is now known as Fallen 15:46:18 --> myk has joined #instantbird 16:08:48 --> Defman has joined #instantbird 16:10:37 <-- myk has quit (Ping timeout: 121 seconds) 16:11:01 --> myk has joined #instantbird 16:13:33 <-- bernard has quit (Connection closed) 16:17:33 --> myk1 has joined #instantbird 16:18:57 <-- myk has quit (Ping timeout: 121 seconds) 16:18:57 * myk1 is now known as myk 16:23:46 --> kapy has joined #instantbird 16:26:37 <-- myk has quit (Ping timeout: 121 seconds) 16:26:59 --> myk has joined #instantbird 16:32:57 <-- gerard-majax has quit (Ping timeout: 121 seconds) 16:38:27 --> bernard has joined #instantbird 16:39:09 <-- myk has quit (Ping timeout: 121 seconds) 16:40:51 --> myk has joined #instantbird 16:41:40 --> mpmc has joined #instantbird 16:44:08 <-- bernard has quit (Connection closed) 16:44:54 <-- myk has quit (Ping timeout: 121 seconds) 16:45:40 * Fallen is now known as Fallen|away 16:46:13 --> bernard has joined #instantbird 16:53:14 --> mudpit has joined #instantbird 17:00:02 --> myk has joined #instantbird 17:07:19 <-- aleth has quit (Ping timeout: 121 seconds) 17:07:33 * redDragon|away is now known as redDragon 17:09:44 <-- chrisccoulson has quit (Ping timeout: 121 seconds) 17:30:08 <-- kapy has quit (Quit: ) 17:34:44 <-- bernard has quit (Connection closed) 17:36:04 --> bernard has joined #instantbird 17:36:12 --> bernard1 has joined #instantbird 17:36:20 <-- bernard1 has quit (Quit: Leaving.) 17:36:23 --> bernard1 has joined #instantbird 17:38:49 --> bernard2 has joined #instantbird 17:40:06 <-- bernard has quit (Ping timeout: 121 seconds) 17:41:55 <-- bernard1 has quit (Ping timeout: 121 seconds) 17:45:22 <-- bernard2 has quit (Ping timeout: 121 seconds) 17:47:04 --> gerard-majax has joined #instantbird 17:52:55 <-- sherief has quit (A TLS packet with unexpected length was received.) 17:53:15 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:56:26 * Fallen|away is now known as Fallen 18:01:50 --> Mook_as has joined #instantbird 18:02:04 --> gerard-majax has joined #instantbird 18:17:47 <-- gerard-majax has quit (Ping timeout: 121 seconds) 18:23:31 <instantbot> florian@queze.net changed the Resolution on bug 1132897 from --- to FIXED. 18:23:32 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1132897 nor, --, 1.6, meyer.thibault, RESO FIXED, avatar picture with Netsoul account 18:24:34 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 18:32:28 --> mudpit1 has joined #instantbird 18:32:33 <-- nhnt11 has quit (Ping timeout: 121 seconds) 18:33:24 --> gerard-majax has joined #instantbird 18:35:48 * redDragon is now known as redDragon|away 18:36:21 <-- mudpit has quit (Ping timeout: 121 seconds) 18:36:21 * mudpit1 is now known as mudpit 18:39:19 <-- gerard-majax has quit (Ping timeout: 121 seconds) 18:40:06 --> gerard-majax has joined #instantbird 18:52:50 <-- gerard-majax has quit (Ping timeout: 121 seconds) 18:56:57 --> aleth has joined #instantbird 18:56:57 * ChanServ sets mode +o aleth 19:01:40 --> AlexanderSalas has joined #instantbird 19:03:19 --> Mook_astb has joined #instantbird 19:03:19 * Mook_astb is now known as Mook_a1 19:03:36 <-- aleth has quit (Quit: :tiuQ) 19:05:34 <-- Mook_as has quit (Ping timeout: 121 seconds) 19:05:47 <-- harshit has quit (Quit: Leaving) 19:13:24 --> harshit has joined #instantbird 19:19:48 <-- AlexanderSalas has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 19:19:55 <-- Tonnes has quit (Quit: ChatZilla 0.9.91.1 [Firefox 35.0.1/20150122214805]) 19:22:11 --> manu_jain has joined #instantbird 19:24:07 --> Tonnes has joined #instantbird 19:32:49 --> nhnt11 has joined #instantbird 19:32:49 * ChanServ sets mode +h nhnt11 19:49:39 --> aleth has joined #instantbird 19:49:39 * ChanServ sets mode +o aleth 19:51:07 <-- Widdershins has quit (Ping timeout: 121 seconds) 19:51:52 <manu_jain> how do instantbird linkify URLs in their chatbox? 19:55:18 <aleth> manu_jain: iirc it uses mozITXTToHTMLConv 19:56:14 <manu_jain> aleth: something like this - "http://mxr.mozilla.org/comm-central/source/calendar/lightning/components/lightningTextCalendarConverter.js#34" 19:58:57 <aleth> manu_jain: https://developer.mozilla.org/en-US/docs/MozITXTToHTMLConv 20:00:30 <clokep_work> manu_jain: Just like http://mxr.mozilla.org/comm-central/source/calendar/lightning/components/lightningTextCalendarConverter.js#43 says ;) 20:06:23 <-- harshit has quit (Quit: Leaving) 20:33:16 <-- manu_jain has quit (Connection closed) 20:37:39 --> gerard-majax has joined #instantbird 20:41:54 --> chrisccoulson has joined #instantbird 20:50:14 <-- gerard-majax has quit (Ping timeout: 121 seconds) 21:00:23 <-- spz has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 21:10:03 --> Nazadel has joined #instantbird 21:10:13 --> flo-retina has joined #instantbird 21:10:13 * ChanServ sets mode +qo flo-retina flo-retina 21:10:49 <flo-retina> hmm, do we have anybody willing to mentor bug 955085? 21:10:51 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955085 min, --, ---, nobody, NEW, Typing status not cleared when contact goes offline 21:10:54 * flo-retina looks in aleth's direction ;) 21:12:48 <aleth> I guess that's an XMPP bug? 21:13:23 <aleth> I guess I should mentor it... 21:13:30 <aleth> might not be an XMPP bug after all ;) 21:15:54 <clokep_work> flo-retina: Me or aleth, likely. 21:24:54 <clokep_work> aleth: Why "// TB-only:" that code is in mail, so obviously it's TB-only? 21:25:06 <clokep_work> aleth: Also...What is that trying to check? 21:25:09 <clokep_work> I don't understand it... 21:25:13 <aleth> clokep_work: To help any future mergers and porters 21:25:28 <clokep_work> "this.tab.selected is always false when the chat tab is inactive" I don't understand that phrase. 21:25:35 <clokep_work> What does "chat tab is inactive" mean? 21:25:56 <aleth> clokep_work: it makes sense when you know that this.tab in TB points at an imconv element, which is a listitem, not a tab. 21:26:42 <aleth> chat tab is inactive means it's not selected 21:26:50 <clokep_work> Hm. OK. 21:26:53 <clokep_work> I'll let it go over my head. 22:09:17 <-- Mnyromyr has quit (Ping timeout: 121 seconds) 22:10:27 --> Mnyromyr has joined #instantbird 22:15:25 --> mudpit1 has joined #instantbird 22:18:07 <-- mudpit has quit (Ping timeout: 121 seconds) 22:18:07 * mudpit1 is now known as mudpit 22:26:20 <clokep_work> aleth: Btw I didn't realize you had wrapped that in a try-statement when first reviewing that code so. :) 22:26:28 <clokep_work> Much more OK w/ the assumption-ness. 22:26:49 <aleth> Yes, when I started it was quite hard to debug. 22:27:50 <aleth> Every little thing would break XMPP ;) 22:28:21 <clokep_work> Do we have a top-level try-catch like IRC does? 22:29:03 <aleth> I don't think so. 22:29:13 <aleth> XMPP still needs quite a bit of work... 22:29:14 <clokep_work> Hmm...interesting. 22:29:20 <clokep_work> Yes, but that gives you saner errors. :-D 22:29:32 <aleth> Yup. 22:29:55 <aleth> We should file a followup to try-catch around all the handler calls. 22:32:28 <clokep_work> Yes. 22:37:00 <-- mconley has quit (Connection closed) 22:40:16 <clokep_work> aleth: The change to _targetResource: ""...what's that imply? :) 22:40:31 <clokep_work> Besides that, a solid r+! 22:40:46 <aleth> It's actually no change unless you look at the interdiff. It was a mistake (fb wants "") 22:40:56 <clokep_work> Ahhh. 22:40:58 <clokep_work> Yes interdiff. 22:41:50 <aleth> yay, one down, one to go :-) 22:41:59 <clokep_work> LOL "THIS_IS_SDPARTA" 22:42:07 <aleth> indeed 22:42:46 <aleth> Just in case you were wondering where that came from: https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp#1751 22:43:07 <clokep_work> Haha. :) 22:43:12 <clokep_work> I'm unsure how to review this code... 22:43:22 <clokep_work> (The test) 22:43:32 <clokep_work> Also, are we really sure we want me reviewing XUL? :P 22:44:08 <aleth> It's not a great test, but it's better than nothing I guess. All of XMPP needs tests :-S 22:44:55 <aleth> you can tell that's fairly recent code because it's got auto all over the place ;) 22:50:27 <clokep_work> aleth: Sorry, took away an r+... 22:50:32 <aleth> clokep_work: good catch 22:53:26 <clokep_work> I did something useful as a reviewer, yay! 23:00:12 <instantbot> aleth@instantbird.org changed the Resolution on bug 1131734 from --- to FIXED. 23:00:13 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1131734 min, --, 1.6, aleth, RESO FIXED, Path is not defined in logger.js 23:00:22 <instantbot> aleth@instantbird.org changed the Resolution on bug 1128741 from --- to FIXED. 23:00:24 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1128741 nor, --, 1.6, aleth, RESO FIXED, Improve XMPP stanza and error handling 23:01:41 <clokep_work> :) 23:02:33 <clokep_work> OOps, silly typo: https://hg.mozilla.org/comm-central/rev/a65ca418b17f#l1.27 23:03:15 <aleth> That's that good first bug about copypasting code from IB... 23:03:29 <aleth> Should have caught it though. 23:03:41 <clokep_work> Yeah. 23:03:45 <clokep_work> I'd just leave it honestly. 23:03:50 <clokep_work> Not a big deal. 23:04:28 <aleth> Yup. 23:05:56 <clokep_work> Someone will just think it's a typo. :P 23:06:20 <aleth> ah well, if we ever unfork it it will make life easier :P 23:11:39 <-- Defman has quit (A TLS packet with unexpected length was received.) 23:14:48 <-- clokep_work has quit (Ping timeout: 121 seconds) 23:16:36 --> bernard has joined #instantbird 23:30:45 --> mconley has joined #instantbird 23:33:44 <-- bernard has quit (Quit: Leaving.) 23:58:28 --> Tobin has joined #instantbird