All times are UTC.
00:01:31 <-- mudpit has quit (Ping timeout: 121 seconds) 00:17:55 --> mudpit has joined #instantbird 00:24:03 --> mconley has joined #instantbird 00:26:50 <EionRobb> why don't you guys have a branch in the libpurple source tree to keep track of your patches? 00:26:59 <EionRobb> I mean, at hg.pidgin.im 00:27:16 <clokep> EionRobb: Because it wouldn't really make sense. 00:27:21 <clokep> The repository looks totally different. 00:27:24 <clokep> With many extra files 00:27:28 <clokep> And many changed files 00:27:57 <EionRobb> adium have their purple stuff there and then extra/wrapper code in their own repo 00:28:29 <clokep> The makefiles we use are totally different too though, not sure how we'd handle that. 00:31:36 <EionRobb> I'm trying to remember what adium did with their purple makefiles, since they were quite different too 00:31:58 <EionRobb> I think they just had a .sh build script or something, but that was probably easier for them since they were just targeting one platform 00:32:03 <clokep> I'm not against it...but if it's tons of engineering for not much gain...then I won't be super happy. :( 00:32:26 <clokep_work> aleth: Mousing over works for me...it's just 100% not discoverable. 00:32:29 <EionRobb> right, that's never a good target. something that keeps maintenance for you guys lower would be good 00:33:36 <EionRobb> something that uses ctypes or something to load in the libpurple dll/so/lib out of tree/separately sounds like a lower-maintenance thing though :) 00:34:48 <clokep> Sure, but a lot of engineering to get there. ;) 00:38:32 <clokep> We also have a few weird things that I'm unsure how we could transition...i.e. we replace the gettext stuff. 00:40:23 <EionRobb> replace it how? by redefining the _() function? 00:43:16 <aleth> clokep_work: ah, it's working now. I think the lock icon means "approval required" 00:44:19 <clokep_work> EionRobb: http://pastebin.instantbird.com/1115700 is the current diff btw. 00:45:15 <-- aleth has quit (Quit: :tiuQ) 00:47:35 <EionRobb> some of that would be quite good to have in libpurple 00:48:36 <clokep_work> Maybe. We've upstreamed some stuff, but not everything. 00:48:49 <clokep_work> I've tried to upstream everything that had to do with compiling with MSVC. ;) 00:50:27 <EionRobb> the ui-ops stuff should be upstreamed too, that's cool :) 00:51:24 <clokep_work> Which stuff is this? 00:52:08 <clokep_work> The part that lets you override command handling? 00:53:47 <EionRobb> yeah, that and account ui-ops 00:54:29 <EionRobb> the telepathy-haze guys would probably appreciate the account uiops especially 00:54:49 <EionRobb> the butchering of the logging and debugging is no good though :) 00:55:04 <clokep_work> We've discussed butchering your sockets too. ;) 00:55:15 <clokep_work> We also butcher the prefs system btw. 00:55:34 <clokep_work> So we use the mozilla preferences system intstead of the libpurple XML 00:56:35 <EionRobb> uiops for prefs would be awesome too. the telepathy-haze guys would definitely fly over and give you a hug if you implemented that :) 00:56:59 <clokep> Haha. 00:57:41 <EionRobb> actually, most UI devs would, the adium guys do some hacky stuff to create the xml files for libpurple 01:01:16 <EionRobb> couldn't you avoid a lot of the logging hack-ups by disabling libpurple logging? 01:02:44 <-- clokep_work has quit (Connection closed) 01:02:47 --> clokep_work has joined #instantbird 01:02:47 * ChanServ sets mode +o clokep_work 01:03:55 <clokep> No idea. 01:04:02 <clokep> That was before my time. ;) 01:04:15 <clokep> Although...it *is* enabled. 01:04:19 <clokep> It just goes into the Mozilla logger. 01:04:22 <clokep> So it's in the error console, etc. 01:04:42 <EionRobb> oh, I mean the message logging not debug logging 01:04:58 <clokep> Oh. Idk. Maybe it wasn't possible way back when? 01:05:00 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 01:05:06 --> clokep has joined #instantbird 01:05:06 * ChanServ sets mode +o clokep 01:06:59 <-- clokep_work has quit (Ping timeout: 121 seconds) 01:15:36 --> aleth has joined #instantbird 01:15:36 * ChanServ sets mode +o aleth 01:18:24 --> clokep_work has joined #instantbird 01:18:24 * ChanServ sets mode +o clokep_work 01:30:45 <-- mconley has quit (Connection closed) 01:41:23 <-- aleth has quit (Ping timeout: 121 seconds) 01:47:22 <-- Even has quit (Connection closed) 01:47:23 --> Even1 has joined #instantbird 01:47:23 * ChanServ sets mode +o Even1 02:19:43 --> Widdershins has joined #instantbird 02:21:40 <-- Mook_a1 has quit (Client exited) 02:46:04 --> mconley has joined #instantbird 03:44:25 <-- clokep has quit (Ping timeout: 121 seconds) 03:44:31 <-- clokep_work has quit (Ping timeout: 121 seconds) 04:15:09 <-- EionRobb has quit (Quit: Leaving.) 04:24:22 <instant-buildbot> build #1283 of linux-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1283 04:28:44 <-- mconley has quit (Connection closed) 04:28:49 <-- mudpit has quit (Ping timeout: 121 seconds) 04:30:13 --> mudpit has joined #instantbird 04:31:48 <instant-buildbot> build #2487 of macosx-nightly-default is complete: Failure [4failed shell_5] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2487 04:35:51 <-- arlolra has quit (Client exited) 05:01:32 --> DGMurdockIII has joined #instantbird 05:02:25 --> Bollebib has joined #instantbird 05:38:38 <-- DGMurdockIII has quit (Quit: Leaving) 05:40:52 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 05:57:45 <instant-buildbot> build #179 of linux64-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/179 05:58:15 --> mconley has joined #instantbird 06:02:18 <-- mconley has quit (Connection closed) 06:34:44 --> Defman has joined #instantbird 07:04:54 * redDragon|away is now known as redDragon 07:42:26 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 07:44:19 --> mudpit1 has joined #instantbird 07:44:25 <-- mudpit has quit (Ping timeout: 121 seconds) 07:44:25 * mudpit1 is now known as mudpit 07:56:27 <-- mudpit has quit (Ping timeout: 121 seconds) 08:12:51 --> mudpit has joined #instantbird 08:18:53 <-- mudpit has quit (Ping timeout: 121 seconds) 08:22:51 --> EionRobb has joined #instantbird 08:43:09 --> gerard-majax has joined #instantbird 08:57:44 * Fallen|away is now known as Fallen 09:29:23 --> aleth has joined #instantbird 09:29:23 * ChanServ sets mode +o aleth 09:32:41 * redDragon is now known as redDragon|away 09:39:21 --> mpmc has joined #instantbird 10:00:19 --> BWMerlin has joined #instantbird 10:20:21 <-- aleth has quit (Ping timeout: 121 seconds) 10:26:18 --> aleth has joined #instantbird 10:26:18 * ChanServ sets mode +o aleth 10:31:12 <-- Tonnes has quit (Connection closed) 10:36:53 <-- EionRobb has quit (Quit: Leaving.) 10:38:09 --> flo-retina has joined #instantbird 10:38:09 * ChanServ sets mode +qo flo-retina flo-retina 10:40:02 <flo-retina> who broke our tests? 10:40:11 <flo-retina> TEST-UNEXPECTED-FAIL | chat/components/src/test/test_logger.js | - "Hello, world!" == "Hello, world!Hello, world!" 10:47:56 --> Tonnes has joined #instantbird 10:49:16 <-- aleth has quit (Ping timeout: 121 seconds) 11:14:12 --> Bollebib has joined #instantbird 11:17:19 --> clokep has joined #instantbird 11:17:19 * ChanServ sets mode +o clokep 11:25:15 --> mudpit has joined #instantbird 11:25:30 <clokep> Not me... 11:26:20 <clokep> flo-retina: The last Thunderbird build didn't seem to have problems. :( 11:39:19 <-- mudpit has quit (Ping timeout: 121 seconds) 11:40:57 --> aleth has joined #instantbird 11:40:57 * ChanServ sets mode +o aleth 11:41:38 <-- BWMerlin has quit (Client exited) 11:45:41 <clokep> Did anyone look at all what it ocld be? 11:45:44 <clokep> could 11:54:32 <flo-retina> I would be tempted to suspect arlo's patch... but we checked it in several days ago, right? 11:54:37 <flo-retina> yesterday's build passed 11:58:50 --> mudpit has joined #instantbird 12:00:15 <-- aleth has quit (Ping timeout: 121 seconds) 12:02:42 <clokep> That was my first though ttoo 12:02:55 <-- mudpit has quit (Ping timeout: 121 seconds) 12:06:55 <-- clokep has quit (Ping timeout: 121 seconds) 12:37:45 --> aleth has joined #instantbird 12:37:45 * ChanServ sets mode +o aleth 12:47:31 --> clokep_work has joined #instantbird 12:47:31 * ChanServ sets mode +o clokep_work 12:59:47 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 12:59:48 --> clokep_work has joined #instantbird 12:59:48 * ChanServ sets mode +o clokep_work 13:00:25 <-- gerard-majax has quit (Ping timeout: 121 seconds) 13:16:12 --> nhnt11 has joined #instantbird 13:16:12 * ChanServ sets mode +h nhnt11 13:16:29 <nhnt11> oh no, a logger test failure 13:16:41 * nhnt11 will look at it in a minute 13:16:46 <clokep_work> nhnt11: Thanks! :) 13:42:02 <nhnt11> Hmm, puzzling 13:42:18 <nhnt11> I'll check it out properly once my build finishes.. 13:56:32 <clokep_work> Cool. Hopefully it's something silly... 14:05:18 <nhnt11> hmm 14:05:24 <nhnt11> I seem to have forgotten how to run xpcshell tests :S 14:05:42 <aleth> nhnt11: The bug seems due to better/changed Promise error reporting 14:05:49 <aleth> make xpcshell-tests ;) 14:05:51 <nhnt11> make xpcshell-tests TEST_PATH=foo/bar is throwing http://pastebin.mozilla.org/8173672 14:06:01 <nhnt11> so is make xpcshell-tests 14:06:26 <nhnt11> aleth: Do you have a bug to which I should refer? 14:06:30 <aleth> wfm with a current build 14:06:38 <nhnt11> my build is ~10 minutes old 14:06:40 <aleth> nhnt11: no, it's just that the test failure is due to "ReferenceError: assignment to undeclared variable onPromiseComplete" 14:06:50 <nhnt11> Thanks 14:07:01 <aleth> weird 14:07:55 <aleth> are you running make from the objdir? 14:07:58 <nhnt11> yes 14:08:23 <aleth> just because it mentions 'relpath' 14:08:36 <clokep_work> nhnt11: What exactly are you running? 14:08:49 <nhnt11> clokep_work: |[~/Dev/comm-central/obj-instantbird]$ make xpcshell-tests| 14:09:58 <aleth> Hmm, not sure if that referenceerror warning actually causes the test to fail 14:12:01 <aleth> nhnt11: stupid question, but did you clobber? 14:12:08 <nhnt11> aleth: totally fresh build, yes. 14:12:50 <nhnt11> I'm still poking around to see if I'm doing something wrong 14:14:27 * nhnt11 needs to go down for dinner soon 14:20:17 <clokep_work> I'm not sure then. :( That's almost definitely not what you want anyway 14:20:41 <clokep_work> I was running |make -C obj-x86_64-apple-darwin13.4.0 xpcshell-tests TEST_PATH=chat/protocols/irc| from my srcdir and it ran fine. 14:20:46 <clokep_work> flo-retina might know though... 14:21:24 <flo-retina> I would try something like make -C objdir/chat xpcshell-tests 14:22:03 <aleth> |make xpcshell-tests| from the objdir WFM 14:22:22 <flo-retina> aleth: I thought this may run also tests from the platform 14:22:30 <aleth> no 14:22:40 <flo-retina> although in theory we override a file to prevent that 14:23:09 <aleth> right 14:48:32 --> kapy has joined #instantbird 14:53:07 <-- aleth has quit (Ping timeout: 121 seconds) 15:05:23 --> aleth has joined #instantbird 15:05:23 * ChanServ sets mode +o aleth 15:12:09 <clokep_work> That runs platform tests for me when I did it. :( 15:17:31 <aleth> clokep_work: that's odd, I wonder what's different about your config? 15:19:52 --> mconley has joined #instantbird 15:22:10 <clokep_work> I don't know. 15:22:15 <clokep_work> I didn't like change anything. 15:23:33 <aleth> so it wfm, fails for nhnt11, and runs everything for you? :-S 15:23:42 <aleth> great test. 15:25:05 <flo-retina> :( 15:33:29 --> myk has joined #instantbird 15:33:58 <-- nhnt11 has quit (Ping timeout: 121 seconds) 15:37:32 <-- myk has quit (Ping timeout: 121 seconds) 15:39:59 <clokep_work> Sounds likely. ;) 15:40:10 --> nhnt11 has joined #instantbird 15:40:11 * ChanServ sets mode +h nhnt11 15:47:28 <-- kapy has quit (Connection closed) 15:48:39 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 15:53:34 --> iamjayakumars has joined #instantbird 15:54:31 --> gerard-majax has joined #instantbird 16:01:37 --> kapy has joined #instantbird 16:03:30 <-- clokep_work has quit (Ping timeout: 121 seconds) 16:12:05 --> myk has joined #instantbird 16:14:12 <-- myk has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:14:14 --> myk has joined #instantbird 16:14:33 <-- myk has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:14:37 --> myk has joined #instantbird 16:17:47 <-- iamjayakumars has quit (Connection closed) 16:19:07 <-- nhnt11 has quit (Ping timeout: 121 seconds) 16:20:18 --> iamjayakumars has joined #instantbird 16:36:03 --> clokep_work has joined #instantbird 16:36:03 * ChanServ sets mode +o clokep_work 17:13:41 --> arlolra has joined #instantbird 17:17:51 --> mudpit has joined #instantbird 17:42:18 <-- iamjayakumars has quit (Connection closed) 17:50:55 <-- kapy has quit (Quit: ) 17:53:17 --> Mook_as has joined #instantbird 18:08:32 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 18:09:44 <-- gerard-majax has quit (Ping timeout: 121 seconds) 18:21:06 <-- aleth has quit (Ping timeout: 121 seconds) 18:34:42 --> aleth has joined #instantbird 18:34:43 * ChanServ sets mode +o aleth 18:43:16 --> mudpit1 has joined #instantbird 18:44:30 <-- mudpit has quit (Ping timeout: 121 seconds) 18:44:30 * mudpit1 is now known as mudpit 18:46:48 --> mpmc has joined #instantbird 18:58:34 --> gerard-majax has joined #instantbird 19:00:22 <-- aleth has quit (Ping timeout: 121 seconds) 19:03:35 --> flo-retina has joined #instantbird 19:03:35 * ChanServ sets mode +qo flo-retina flo-retina 19:05:21 <-- gerard-majax has quit (Ping timeout: 121 seconds) 19:17:33 --> aleth has joined #instantbird 19:17:33 * ChanServ sets mode +o aleth 19:29:40 <-- mconley has quit (Quit: NO CARRIER) 20:01:35 --> mudpit1 has joined #instantbird 20:02:38 <-- mudpit has quit (Ping timeout: 121 seconds) 20:02:38 * mudpit1 is now known as mudpit 20:04:57 --> EionRobb has joined #instantbird 20:11:41 --> gerard-majax has joined #instantbird 20:15:47 <-- gerard-majax has quit (Ping timeout: 121 seconds) 20:29:59 <clokep_work> I wonder if bug 1011642 is useful to us? 20:30:01 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1011642 nor, --, ---, Pidgeot18, ASSI, Make Promises usable from external API code 20:31:10 <aleth> Could be, yes 20:31:26 <aleth> If you want to add an API that returns a Promise 20:31:39 <-- myk has quit (Connection closed) 20:31:40 --> myk has joined #instantbird 20:32:24 <aleth> I can't think of any specific ideas though 20:34:06 <EionRobb> promises are always useful 20:35:46 <aleth> clokep_work: it might have been useful for the video stuff but webrtc is all callbacks, so maybe not 20:40:46 <clokep_work> aleth: nhnt11's stuff? 20:42:05 <aleth> maybe... I'll keep an eye out when he gets it ready. Most of the async stuff there is internal to logger.js though 20:43:24 <aleth> And we can already return promises there as jsval 20:43:46 <aleth> So the likely benefit may just be making the type more explicit. 20:44:30 <aleth> The big change with jcranmer's patch is we could use promises in the interfaces which are also implemented by purplexpcom 20:46:49 <-- Defman has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:46:52 --> Defman has joined #instantbird 21:19:41 <-- clokep_work has quit (Ping timeout: 121 seconds) 21:23:28 --> nhnt11 has joined #instantbird 21:23:29 * ChanServ sets mode +h nhnt11 21:54:39 <-- mudpit has quit (Ping timeout: 121 seconds) 22:01:43 * aleth goes to do some checkins 22:04:19 --> clokep has joined #instantbird 22:04:19 * ChanServ sets mode +o clokep 22:05:55 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 22:06:04 --> clokep has joined #instantbird 22:06:04 * ChanServ sets mode +o clokep 22:13:18 --> mudpit has joined #instantbird 22:17:51 <instantbot> aleth@instantbird.org changed the Resolution on bug 1108540 from --- to FIXED. 22:17:53 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1108540 nor, --, 1.6, aleth, RESO FIXED, Avoid triggering fakelags on connection 22:20:30 <aleth> nhnt11: any luck with that test failure? 22:20:53 <nhnt11> aleth: nope :( 22:22:05 <flo-retina> oooh, looks like once these tests are fixed, I'll be able to connect to moznet much faster :) 22:22:57 <clokep> flo-retina: Mery Christmas. 22:23:47 <flo-retina> :) 22:25:42 <clokep> :-D 22:28:31 <-- myk has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 22:29:55 --> myk has joined #instantbird 22:32:10 <instantbot> aleth@instantbird.org changed the Resolution on bug 955539 from --- to WORKSFORME. 22:32:12 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955539 blo, --, ---, nobody, RESO WORKSFORME, Crashes on startup - portable and installed versions 22:49:30 <-- arlolra has quit (Client exited) 22:51:00 <-- nhnt11 has quit (Ping timeout: 121 seconds) 22:51:43 --> nhnt11 has joined #instantbird 22:51:43 * ChanServ sets mode +h nhnt11 23:13:17 <-- nhnt11 has quit (Connection closed) 23:13:30 --> nhnt11 has joined #instantbird 23:13:31 * ChanServ sets mode +h nhnt11 23:29:53 <-- nhnt11 has quit (Ping timeout: 121 seconds) 23:30:03 --> nhnt11 has joined #instantbird 23:30:03 * ChanServ sets mode +h nhnt11 23:33:21 <aleth> nhnt11: I'm out of time for now, maybe you can finish diagnosing what's going on with that closure? 23:37:07 <-- nhnt11 has quit (Connection closed) 23:37:12 --> nhnt11 has joined #instantbird 23:37:13 * ChanServ sets mode +h nhnt11 23:40:21 --> iamjayakumars has joined #instantbird 23:40:26 <-- iamjayakumars has quit (Connection closed) 23:43:16 <-- nhnt11 has quit (Ping timeout: 121 seconds)