All times are UTC.
00:10:45 --> mconley has joined #instantbird 00:12:30 <-- mconley has quit (Input/output error) 01:05:05 --> Rym has joined #instantbird 01:08:15 <-- Mook_as has quit (Quit: Mook_as) 01:13:15 --> mconley has joined #instantbird 01:31:12 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 01:33:54 <-- mconley has quit (Input/output error) 02:04:09 <-- clokep_work has quit (Ping timeout) 02:17:17 <instant-buildbot> build #1490 of win32-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1490 02:18:25 --> mconley has joined #instantbird 02:21:55 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 02:22:00 --> mpmc has joined #instantbird 02:22:11 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 02:50:55 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 03:09:33 <-- mconley has quit (Input/output error) 03:47:14 <instant-buildbot> build #1134 of linux-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1134 04:14:14 --> mconley has joined #instantbird 04:27:20 <-- nhnt11 has quit (Ping timeout) 04:29:32 <instant-buildbot> build #2314 of macosx-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2314 04:33:41 --> gerard-majax_ has joined #instantbird 04:34:52 --> nhnt11 has joined #instantbird 04:53:49 <instant-buildbot> build #29 of linux64-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/29 05:06:03 <-- gerard-majax_ has quit (Ping timeout) 05:14:47 --> mayanktg has joined #instantbird 05:19:32 --> sonny has joined #instantbird 05:23:50 <-- mayanktg has quit (Client exited) 06:08:50 <-- mconley has quit (Input/output error) 06:15:12 <-- EionRobb has quit (Quit: Leaving.) 06:41:34 <-- nhnt11 has quit (Ping timeout) 06:42:49 --> nhnt11 has joined #instantbird 06:56:29 * Fallen|away is now known as Fallen 07:32:47 <-- nhnt11 has quit (Ping timeout) 07:46:05 <flo-retina> aleth: that noFormat flag seems to only be used by the MSN prpl currently: http://pastebin.instantbird.com/851809 07:46:55 --> gerard-majax_ has joined #instantbird 07:50:24 --> nhnt11 has joined #instantbird 08:10:39 --> Bollebib has joined #instantbird 08:11:58 <-- nhnt11 has quit (Ping timeout) 08:17:15 --> aleth has joined #instantbird 08:17:15 * ChanServ sets mode +o aleth 08:26:41 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died) 08:29:26 --> chrisccoulson has joined #instantbird 09:04:06 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 09:23:02 <-- aleth has quit (Ping timeout) 09:23:41 --> aleth has joined #instantbird 09:23:41 * ChanServ sets mode +o aleth 09:28:59 <aleth> Wow, shades of green in the TB tree... 09:44:36 <-- aleth has quit (Ping timeout) 09:46:13 --> mpmc has joined #instantbird 09:47:16 --> aleth has joined #instantbird 09:47:17 * ChanServ sets mode +o aleth 09:57:42 <-- aleth has quit (Ping timeout) 09:58:13 --> aleth has joined #instantbird 09:58:14 * ChanServ sets mode +o aleth 10:03:42 <-- aleth has quit (Ping timeout) 10:06:35 --> aleth has joined #instantbird 10:06:35 * ChanServ sets mode +o aleth 10:19:33 <-- aleth has quit (Ping timeout) 10:19:56 --> aleth has joined #instantbird 10:19:56 * ChanServ sets mode +o aleth 10:32:03 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 10:35:46 --> rosonline has joined #instantbird 10:38:57 --> Armada has joined #instantbird 10:39:18 --> flo-retina has joined #instantbird 10:39:18 * ChanServ sets mode +qo flo-retina flo-retina 10:48:13 --> clokep_work has joined #instantbird 10:48:13 * ChanServ sets mode +o clokep_work 10:48:26 --> clokep has joined #instantbird 10:48:26 * ChanServ sets mode +o clokep 10:48:57 <-- aleth has quit (Ping timeout) 10:50:15 --> aleth has joined #instantbird 10:50:15 * ChanServ sets mode +o aleth 10:52:52 <clokep> flo-retina: ANd noFormat is not implemented in the UI. :) 10:54:05 --> BWMerlin has joined #instantbird 11:00:12 <-- Rym has quit (Quit: WeeChat 0.4.3) 11:03:43 <-- Armada has quit (Connection reset by peer) 11:05:03 <clokep> aleth: Ah, that test is obsolete. Sorry about that. 11:09:06 <-- aleth has quit (Ping timeout) 11:09:22 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 11:09:44 --> Rym has joined #instantbird 11:14:21 --> clokep_work has joined #instantbird 11:14:21 * ChanServ sets mode +o clokep_work 11:14:25 --> aleth has joined #instantbird 11:14:26 * ChanServ sets mode +o aleth 11:26:59 <-- aleth has quit (Ping timeout) 11:27:38 --> aleth has joined #instantbird 11:27:39 * ChanServ sets mode +o aleth 11:28:34 <clokep> aleth: Thanks for all the reviews btw. :) 11:29:28 <flo-retina> aleth++ :) 11:31:20 <-- aleth has quit (Ping timeout) 11:32:21 --> aleth has joined #instantbird 11:32:21 * ChanServ sets mode +o aleth 11:50:19 <-- aleth has quit (Ping timeout) 11:53:53 --> aleth has joined #instantbird 11:53:53 * ChanServ sets mode +o aleth 12:02:10 --> mayanktg has joined #instantbird 12:06:04 <mayanktg> Hi. I answered the review comments of flo-retina in the Entity capabilities patch and some of the video call patch. I'll answer aleth's comments too and update the patch soon. 12:07:00 * flo-retina doesn't have new bugmail 12:07:05 <flo-retina> did you click "submit"/"publish"? 12:07:12 <aleth> mayanktg: great! 12:07:40 <aleth> flo-retina: I think he means he's done with your comments but not mine and so he's not uploaded anything yet 12:08:02 <mayanktg> flo-retina: I didn't update the patch. Your queries were justified and I made the changes you said. 12:08:22 <mayanktg> Yes. 12:08:37 <flo-retina> ah, so you meant "addressed", not "answered" :) 12:10:29 <-- aleth has quit (Ping timeout) 12:10:45 --> aleth has joined #instantbird 12:10:45 * ChanServ sets mode +o aleth 12:23:26 <-- aleth has quit (Ping timeout) 12:25:54 --> nhnt11 has joined #instantbird 12:26:19 <nhnt11> Hello 12:32:55 <flo-retina> nhnt11: hey :) 12:33:12 <flo-retina> nhnt11: how are things going? 12:34:45 <nhnt11> flo-retina: I've been making progress. I've made the code that unsets the unread ruler more generic, and am currently trying to use it to merge two prepended groups. 12:35:06 <nhnt11> The unread ruler is working with prepended messages btw. 12:35:23 --> clokep_w1 has joined #instantbird 12:36:25 <-- clokep_work has quit (Ping timeout) 12:37:51 <flo-retina> I don't think I've seen anything in the bu 12:37:51 <flo-retina> g 12:38:08 <nhnt11> I didn't upload my code from yesterday. 12:38:17 <nhnt11> (I'll do that now if you'd like) 12:38:22 <flo-retina> especially now that aleth (who understands all this magic) is back, attaching WIPs frequently to get feedback may be a good way to move faster (and by faster I also mean with less effort) 12:38:37 <nhnt11> Okay. 12:38:45 <flo-retina> I'm unlikely to look right now 12:38:59 <flo-retina> but attaching daily or every other day is a good practice :) 12:39:06 <nhnt11> Okay. 12:39:15 <-- BWMerlin has quit (Quit: BWMerlin) 12:40:02 <flo-retina> nhnt11: typically I attach to bugzilla what I have at the end of the "working day" before leaving my coworking space. I also use bugzilla as a backup :) 12:40:26 <flo-retina> if I don't add f? or r? flags, feedback on my WIPs is welcome, but not required 12:40:38 <nhnt11> Cool, makes sense. 12:41:42 <flo-retina> having someone in another timezone comment on my code while I'm asleep is always a good surprise the next morning :) 12:42:32 <clokep> A nice surprise! 12:59:10 <-- nhnt11 has quit (Ping timeout) 13:00:24 <-- Rym has quit (Ping timeout) 13:00:28 --> mpmc has joined #instantbird 13:00:30 --> nhnt11 has joined #instantbird 13:04:51 * nhnt11 wonders about |mach build im| 13:05:08 <nhnt11> It's rather inconvenient to do a full |mach build| for small changes :( 13:05:34 <nhnt11> Aha, I've got some form of bubble merging working 13:05:37 <nhnt11> It's a bit buggy though 13:06:56 <flo-retina> nhnt11: can't you make -C objdir/chat && make -C obdir/im ? 13:07:29 <nhnt11> That didn't seem to pick up my changes once, but thinking about it, it was likely my fault .. 13:09:07 <nhnt11> Okay, it's working, never mind. 13:15:34 <-- clokep_w1 has quit (Ping timeout) 13:23:10 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 13:26:49 <-- nhnt11 has quit (Ping timeout) 13:27:15 --> nhnt11 has joined #instantbird 13:27:36 --> nhnt11-testing has joined #instantbird 13:27:38 <nhnt11-testing> Merged bubbles! :) 13:28:44 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 13:30:08 <flo-retina> :) 13:30:27 * nhnt11 hopes aleth will be happy 13:31:07 <nhnt11> It's messy code at the moment but the idea of it all is okay, I think. 13:31:14 * nhnt11 checks how it plays with the unread ruler 13:31:29 --> aleth has joined #instantbird 13:31:29 * ChanServ sets mode +o aleth 13:31:34 * nhnt11 is now known as test1 13:31:38 * test1 is now known as nhnt11 13:31:44 * nhnt11 is now known as test33 13:32:32 * test33 can't nick back to nhnt11 13:32:50 <aleth> nhnt11: I'll look into fixing |mach build im| once all this pseudo-rework stuff seems done 13:33:05 <aleth> Feel free to fix it earlier though ;) 13:33:18 <test33> Unread ruler seems to be working fine at first glance with the bubble merging code 13:33:21 <aleth> Merging bubbles sounds good :) 13:33:35 <test33> But I predict an edge case where there are only unread messages to prepend... 13:33:54 <aleth> Generalizing the unread ruler bubble merging seems the right approach 13:34:48 <test33> Bah, flicker... 13:35:40 * test33 is now known as nhnt11 13:38:54 <aleth> nhnt11: as a workaround for now you can do |mach build chat && mach build im/app| 13:39:23 <nhnt11> aleth: |make -C chat/ && make -C im| seems to work fine, but thanks. 13:39:38 <aleth> nhnt11: sure, that does the same thing 13:40:27 <aleth> I just like not having to switch to the objdir 13:40:30 <nhnt11> I think the next thing I want to do is deduplicate a ton of shared code between displayMessage and prependMessageGroup.. 13:40:55 <nhnt11> Maybe some bug hunting actually 13:40:59 * nhnt11 uploads a new patch 13:41:14 <-- mayanktg has quit (Client exited) 13:41:26 <aleth> Did you have any luck with fixing time bubbles? 13:41:29 --> mayanktg has joined #instantbird 13:41:43 <nhnt11> No, I haven't looked too much at that yet. 13:42:12 <aleth> The same idea as for bubble merging may help with that too (i.e. re-add the previous top message). 13:42:24 <aleth> But there may be a more elegant approach 13:42:30 <nhnt11> Hmm, I'll check it out. 13:42:35 <aleth> Maybe some of the time bubbles code should even move to imThemes. 13:42:56 <aleth> i.e. develop an API that message styles can use. 13:43:14 <nhnt11> Yeah 13:44:16 --> Rym has joined #instantbird 13:45:33 --> mconley has joined #instantbird 13:46:02 * nhnt11 is now known as tnhnt11 13:46:39 * tnhnt11 is now known as nhnt11 13:47:27 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 13:48:54 <nhnt11> Updated patch: https://bugzilla.mozilla.org/attachment.cgi?id=8475901&action=diff 13:53:19 <-- aleth has quit (Ping timeout) 13:53:53 --> aleth has joined #instantbird 13:53:53 * ChanServ sets mode +o aleth 13:58:18 <aleth> nhnt11: JavaScript error: chrome://chat/content/convbrowser.xml, line 725: prevMsg is undefined 13:59:15 <nhnt11> Interesting.... 13:59:28 <nhnt11> That's only possible if prependMessageGroup was called with an empty array :s 14:00:33 <aleth> Works much better though at first try :) 14:02:21 <nhnt11> Indeed it's being called with a 0-length array 14:02:35 <nhnt11> I'll have to figure this out later though, I've got a class 14:02:38 <nhnt11> Bbl 14:02:39 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 14:04:18 <-- mconley has quit (Input/output error) 14:13:45 <-- aleth has quit (Ping timeout) 14:16:19 --> aleth has joined #instantbird 14:16:19 * ChanServ sets mode +o aleth 14:19:26 --> rosonline has joined #instantbird 14:26:07 <aleth> nhnt11: Sometimes on scrolling up an empty progress bar appears http://puu.sh/b0qR0/394492a722.png 14:26:35 <aleth> Note also the weird display error on the screenshot that only appears when hovering the ChanServ bubble. 14:27:54 <aleth> also chrome://chat/content/convbrowser.xml, line 407: reference to undefined property this._pendingMessages[(intermediate value)] 14:29:26 <aleth> And there's a problem with system message collapsing http://puu.sh/b0r4i/9ca918c92f.png 14:42:52 --> mconley has joined #instantbird 14:44:05 <-- aleth has quit (Quit: exit stage left) 14:45:28 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 15:03:18 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 15:27:54 --> nhnt11 has joined #instantbird 15:31:08 * nhnt11 is now known as asdfads 15:31:11 * asdfads is now known as nhnt11 15:31:59 * nhnt11 doesn't see that double "+" button bug 15:33:09 --> nhnt11-testing has joined #instantbird 15:43:14 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 15:45:30 --> iamjayakumars has joined #instantbird 15:45:47 --> arlolra has joined #instantbird 15:46:49 <-- nhnt11 has quit (Ping timeout) 15:49:36 <-- sawrubh has quit (Ping timeout) 15:50:55 --> sawrubh has joined #instantbird 16:00:47 <-- gerard-majax_ has quit (Ping timeout) 16:33:13 --> Mook_as has joined #instantbird 16:45:49 --> mayanktg has joined #instantbird 16:50:41 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:57:35 <-- mayanktg has quit (Ping timeout) 16:58:03 --> mayanktg has joined #instantbird 17:04:26 --> Guido has joined #instantbird 17:20:37 --> gerard-majax_ has joined #instantbird 17:21:29 <-- mayanktg has quit (Ping timeout) 17:21:57 --> mayanktg has joined #instantbird 17:26:30 --> flo-retina has joined #instantbird 17:26:30 * ChanServ sets mode +qo flo-retina flo-retina 17:34:12 <-- gerard-majax_ has quit (Ping timeout) 17:38:47 <-- iamjayakumars has quit (Ping timeout) 17:41:21 --> iamjayakumars has joined #instantbird 17:58:58 <-- sonny has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 18:06:11 <-- iamjayakumars has quit (Client exited) 18:27:33 <-- rosonline has quit (Ping timeout) 18:37:30 <-- Rym has quit (Ping timeout) 18:38:05 --> Rym has joined #instantbird 18:45:34 --> nhnt11 has joined #instantbird 18:47:56 --> aleth has joined #instantbird 18:47:56 * ChanServ sets mode +o aleth 18:49:19 <aleth> nhnt11: http://puu.sh/b0IiB/27323208cf.png ;) 18:49:29 <nhnt11> :O 18:49:33 --> gerard-majax_ has joined #instantbird 18:58:33 <aleth> lol http://puu.sh/b0J6Z/a51fc036df.png 18:58:50 <flo-retina> aleth: making good progress? ;) 18:59:21 <aleth> Just screenshotting the dev instance which has been running in the background... 19:03:31 <nhnt11> :-/ 19:03:39 <nhnt11> I'll lurk on #ubuntu for a while.. 19:03:57 <aleth> Random guess: those are N batches of prepended system messages. 19:04:13 <nhnt11> Hmm 19:05:09 <nhnt11> aleth: great guess. 19:06:49 <aleth> Also an interesting edge case where it's possible to add a lot of messages without visibly seeing much scrolling response 19:07:47 <aleth> localstore.rdf is going away tomorrow, do we care about that? 19:07:51 * aleth suspects nor 19:08:00 <flo-retina> aleth: maybe 19:08:34 <flo-retina> aleth: http://mxr.mozilla.org/comm-central/source/im/content/group.xml#59 19:08:58 <aleth> hrm. 19:11:16 <aleth> At least the required changes don't look too terrible at first glance https://hg.mozilla.org/integration/mozilla-inbound/rev/25c918c5f3e1 19:14:07 <flo-retina> looks like it's cleaner indeed :) 19:23:44 <-- gerard-majax_ has quit (Ping timeout) 19:36:55 <-- Rym has quit (Ping timeout) 19:37:16 --> Rym has joined #instantbird 19:39:04 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died) 19:39:46 <-- mayanktg has quit (Ping timeout) 19:40:13 --> mayanktg has joined #instantbird 19:41:56 <-- mayanktg has quit (Ping timeout) 19:42:25 --> mayanktg has joined #instantbird 19:42:34 --> chrisccoulson has joined #instantbird 19:44:06 <-- mayanktg has quit (Ping timeout) 19:44:28 --> mayanktg has joined #instantbird 19:47:50 <-- mayanktg has quit (Ping timeout) 19:48:21 --> mayanktg has joined #instantbird 19:54:12 <-- mayanktg has quit (Ping timeout) 19:54:41 --> mayanktg has joined #instantbird 19:59:42 <-- mayanktg has quit (Ping timeout) 20:00:08 --> mayanktg has joined #instantbird 20:30:40 <-- aleth has quit (Ping timeout) 20:32:28 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:32:29 <-- Guido has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 20:53:59 --> EionRobb has joined #instantbird 20:57:52 <-- arlolra has quit (Quit: arlolra) 21:19:46 --> mpmc has joined #instantbird 21:26:47 --> Armada has joined #instantbird 21:56:16 <-- mconley has quit (Input/output error) 22:04:49 <-- Rym has quit (Ping timeout) 22:06:55 --> Rym has joined #instantbird 22:08:47 <-- Rym has quit (Ping timeout) 22:31:48 --> mconley has joined #instantbird 22:35:52 --> Rym has joined #instantbird 22:40:40 <-- mconley has quit (Input/output error) 22:55:40 <-- flo-retina has quit (Ping timeout) 22:59:41 * Fallen is now known as Fallen|away 23:05:45 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 23:20:54 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)