#instantbird log on 07 08 2014

All times are UTC.

00:10:34 <-- rosonline has quit (Client exited)
01:15:05 <-- Mook_as has quit (Quit: Mook_as)
01:21:01 --> rosonline has joined #instantbird
01:35:02 <-- mconley has quit (Ping timeout)
01:35:31 --> mconley has joined #instantbird
01:44:23 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
01:58:50 <-- EionRobb has quit (Ping timeout)
01:59:55 --> EionRobb has joined #instantbird
02:03:05 <-- mconley has quit (Input/output error)
02:11:01 --> mconley has joined #instantbird
03:21:38 <-- mconley has quit (Input/output error)
03:43:43 --> mconley has joined #instantbird
03:57:52 --> Mook has joined #instantbird
04:12:51 <-- mconley has quit (Input/output error)
04:16:13 --> qheaden has joined #instantbird
04:23:52 <-- Mook has quit (Quit: Mook)
04:39:48 <-- qheaden has quit (Ping timeout)
05:15:26 <-- Rym has quit (Ping timeout)
05:17:45 --> mayanktg has joined #instantbird
05:32:20 --> qheaden has joined #instantbird
05:47:10 <-- EionRobb has quit (Quit: Leaving.)
06:01:46 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
07:43:53 * Fallen|away is now known as Fallen
08:05:36 --> EionRobb has joined #instantbird
08:10:24 <-- micahg has quit (Ping timeout)
08:11:08 --> micahg has joined #instantbird
08:13:55 --> chrisccoulson has joined #instantbird
08:17:48 --> mayanktg-ph has joined #instantbird
08:52:51 --> jb has joined #instantbird
08:56:51 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:05:10 <-- mayanktg has quit (Ping timeout)
09:05:56 --> mayanktg has joined #instantbird
09:16:24 * Fallen is now known as Fallen|away
09:19:18 --> aleth has joined #instantbird
09:19:18 * ChanServ sets mode +o aleth 
09:21:58 * Fallen|away is now known as Fallen
09:26:50 --> Armada has joined #instantbird
09:37:59 <-- mayanktg has quit (Ping timeout)
09:38:48 <mayanktg-ph> Armada:  
09:39:00 <-- aleth has quit (Ping timeout)
09:39:05 <Armada> mayanktg-ph: yes?
09:39:15 --> aleth has joined #instantbird
09:39:15 * ChanServ sets mode +o aleth 
09:44:03 <-- mayanktg-ph has quit (Ping timeout)
09:44:13 --> mayanktg-ph has joined #instantbird
09:45:10 --> flo-retina has joined #instantbird
09:45:10 * ChanServ sets mode +qo flo-retina flo-retina 
09:45:52 <mayanktg-ph> Amanda: I'm so sorry. I pinged you by mistake.
09:51:33 --> mayanktg has joined #instantbird
09:54:10 <flo-retina> aleth: changing the double quotes to single quotes IS enough to fix the Windows bustage
09:54:10 --> mpmc has joined #instantbird
09:54:28 <flo-retina> (I've just tested this with VNC on the VM)
09:54:31 <aleth> flo-retina: great :) Can you tell me why? ;)
09:54:45 <flo-retina> not really, especially as the double quotes worked with pymake ;)
09:55:07 <flo-retina> aleth: but I know that single and double quotes have different behaviors in the way shells treat variables in them
09:55:16 <aleth> I guess we're not lucky enough for it also to fix the mac bustage ;)
09:55:45 <flo-retina> so it's possible that with single quotes $(topsrcdir) stays topsrcdir and is replaced by make while processing the mozilla/Makefile file rather than processed and then passed around as a full path in the variable
09:56:11 <flo-retina> hmm, actually, I think it's the most rational explanation I'll be able to come up with, so I'll just tell you that this is the reason :-P.
09:56:34 <aleth> :D
09:58:41 <aleth> oh wait, you didn't push this yet? So I guess maybe there is a tiny chance it will fix the mac bustage too ;)
09:58:54 <flo-retina> no :-P
09:59:07 <aleth> mac doesn't run this step?
09:59:16 <flo-retina> aleth: Mac fails way before that
10:00:10 <aleth> I find it really hard to tell where exactly it fails from the log.
10:00:16 <flo-retina> interestingly, running VNC on my macbook and compiling in the remote Windows VM seems to take more local CPU than compiling locally :-D
10:00:38 <flo-retina> aleth: it fails while trying to unify the 32 and 64bit builds to merge them into an universal build.
10:00:47 <flo-retina> aleth: and it fails because the 64bit files seem to be missing.
10:00:55 <flo-retina> (unless the failure has changed since yesterday)
10:01:55 --> BWMerlin has joined #instantbird
10:02:21 <mayanktg> aleth: I was making the changes you gave for the Bug 1018060. I'll update the patch by today.
10:02:23 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1018060 enh, --, ---, mayanktg, NEW, Video calls via XMPP/Jingle and WebRTC
10:03:52 <flo-retina> aleth: https://hg.mozilla.org/comm-central/rev/6358e2178d99
10:04:54 <-- mayanktg has quit (Ping timeout)
10:05:13 --> mayanktg has joined #instantbird
10:05:35 <-- gerard-majax_ has quit (Ping timeout)
10:05:47 <aleth> And more build system changes just landed...
10:06:00 <flo-retina> is there a new bustage?
10:06:14 <aleth> We'll see, I guess.
10:06:44 <aleth> Hopefully not.
10:07:23 <-- mayanktg-ph has quit (Quit: )
10:10:37 * flo-retina wonders if build logs are deterministic enough that diffing the first failing mac log with the last success log would give interesting information
10:12:15 <flo-retina> wait, the issue is obvious
10:12:17 <flo-retina> it's a path issue
10:12:42 <flo-retina> "File missing in /Users/buildbot/buildslave/macosx/obj-instantbird/i386/../x86_64/dist: Instantbird.app/Contents/Info.plist"
10:12:57 <flo-retina> there's clearly no "dist" folder in the "x86_64" folder; it's in mozilla/dist
10:13:08 <aleth> aah! 
10:13:22 <aleth> well spotted.
10:13:24 <flo-retina> now where the wrong path is in the build system, that's another problem
10:13:55 <flo-retina> "--unify /Users/buildbot/buildslave/macosx/obj-instantbird/i386/../x86_64/dist"
10:14:27 <flo-retina> Adding configure options from /Users/buildbot/buildslave/macosx/build/im/config/mozconfigs/macosx/mozconfig
10:14:27 <flo-retina>   --with-unify-dist=../x86_64/dist
10:14:52 <flo-retina> ahah, http://mxr.mozilla.org/comm-central/search?string=with-unify-dist
10:15:09 <flo-retina> I guess we are using mozilla/build/macosx/universal/mozconfig.common instead of the comm-central version
10:15:23 <aleth> Looks like it!
10:15:27 <aleth> flo-retina++
10:16:25 <flo-retina> http://hg.mozilla.org/comm-central/rev/d82d65b26412 It's an old "fix" :-S
10:17:05 <aleth> We include mozconfig.common in those lines I touched yesterday
10:17:24 <aleth> But those don't point at mozilla/build :-/
10:17:34 <flo-retina> yeah, $topsrcdir/build/macosx/universal/mozconfig.common
10:17:53 <flo-retina> so why is topsrcdir pointing to the wrong folder when we are there?
10:18:32 <-- mayanktg has quit (Ping timeout)
10:19:42 <flo-retina> the Tb file includes . $topsrcdir/build/macosx/universal/mozconfig instead
10:20:25 <aleth> Yeah, but that then includes mozconfig.common
10:21:39 <flo-retina> well, I still don't have a clue about what the fix could be, but I feel we made _some_ progress :)
10:22:55 <aleth> I had my mozconfig output $topsrcdir yesterday, and it pointed at cc not cc/mozilla
10:25:42 --> mayanktg has joined #instantbird
10:36:51 <flo-retina> aleth: http://pastebin.instantbird.com/747945
10:37:22 <aleth> flo-retina: So that's indeed the issue.
10:37:37 <flo-retina> The other notable change is, in the working build, the lines --target=i386-apple-darwin12.2.1 and --with-unify-dist appeared first. Now they are at the end.
10:37:45 <aleth> I wonder why it's position changed
10:37:49 <aleth> Right.
10:37:58 <flo-retina> could be the inclusion order of some files?
10:38:20 <aleth> Or does it get set twice? (i.e. both mozconfig.common get processed?)
10:38:33 <flo-retina> that's possible
10:39:25 <flo-retina> the last "good" nightly was apparently on Thu 03 Jul 2014
10:41:31 <aleth> http://mxr.mozilla.org/comm-central/source/build/macosx/universal/mozconfig.common#17
10:42:22 <aleth> sorry, wrong link
10:44:02 --> gerard-majax_ has joined #instantbird
10:44:49 <aleth> flo-retina: Can you trigger a new nightly on the off-chance that bug 1035096 fixed it?
10:44:53 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1035096 nor, --, Thunderbird 33.0, mh+mozilla, RESO FIXED, Avoid much mess by not letting mozilla subconfigure read mozconfig
10:45:07 <flo-retina> has that just landed?
10:45:34 <aleth> yes
10:53:29 <-- EionRobb has quit (Quit: Leaving.)
10:54:03 <aleth> No new build failures, anyway :)
10:54:14 <-- mayanktg has quit (Ping timeout)
10:54:29 --> mayanktg has joined #instantbird
10:54:49 <flo-retina> aleth: I started a new mach nightly
10:54:56 <flo-retina> let's see how the beginning of the log looks :)
10:55:14 <aleth> Right!
10:55:38 * flo-retina wonders if we could make nhnt11's log/session splitting code run on existing logs
10:56:01 <aleth> I don't think he has the time to do that.
10:56:23 <aleth> He's way behind schedule.
10:57:08 <flo-retina> aleth: I didn't mean to ask him to do it
10:57:19 <flo-retina> aleth: I was just wondering if it would be possible to maybe with an add-on re-process existing logs
10:57:44 <flo-retina> btw, I'm very confused about the facebook XMPP gateway behavior
10:57:46 <aleth> Probably
10:57:57 <flo-retina> "mobile" contacts are not shown. Except the one person I care about
10:58:12 <aleth> Better than the other way round I suppose ;)
10:58:14 <flo-retina> it's almost like if it didn't include mobile contacts in the gateway, except people we've talked to in the last few days.
10:58:42 <aleth> Maybe it only adds mobile contacts to the roster once you've talked to them once?
10:58:59 <flo-retina> and I'm pretty sure there's some 'magic' on the facebook side to make that contact different, because on the facebook website the contact is always listed very close to the top of the list (not alphabetically sorted)
10:59:07 <aleth> Or are they implemented as resources?
10:59:11 <flo-retina> aleth: no, all contacts are in the roster (but offline) at the begining
10:59:20 <flo-retina> aleth: no resources at all on facebook XMPP :-/
10:59:42 <flo-retina> s/all contacts/all Facebook Friends/
10:59:44 <-- mayanktg has quit (Ping timeout)
11:00:01 --> mayanktg has joined #instantbird
11:00:05 <flo-retina> bah, that mac build wasn't very successful
11:00:10 * flo-retina started yet another one
11:04:49 <-- mayanktg has quit (Client exited)
11:04:52 --> mayanktg has joined #instantbird
11:09:06 * Fallen is now known as Fallen|away
11:12:10 <aleth> New nightly doesn't look promising.
11:17:00 <-- mayanktg has quit (Ping timeout)
11:17:22 --> mayanktg has joined #instantbird
11:17:37 <flo-retina> aleth: yeah, same problem
11:17:51 <flo-retina> but it was worth trying :)
11:17:56 <aleth> Yup!
11:18:46 <flo-retina> have we looked for c-c changes soon after our last working build?
11:22:23 <-- mayanktg has quit (Ping timeout)
11:22:42 <aleth> Sure (but clearly I must have overlooked /something/)
11:22:46 --> mayanktg has joined #instantbird
11:23:28 <aleth> It's possible there's something hidden here https://bugzilla.mozilla.org/attachment.cgi?id=8449211&action=diff
11:24:36 <aleth> flo-retina: does the buildbot use mach?
11:24:53 <flo-retina> no
11:24:59 <flo-retina>  argv: ['make', '-f', 'client.mk', 'build']
11:26:16 <-- mayanktg has quit (Ping timeout)
11:26:19 --> mayanktg has joined #instantbird
11:27:57 <aleth> Well yeah, but something is generating client.mk
11:28:45 <flo-retina> client.mk is a static file, it's not generated
11:28:48 <aleth> The reason I ask is comments like "use mach environment in place of mozconfig2configure and mozconfig2client-mk, which makes us now have only one mozconfig reader" in bug 762358
11:28:51 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=762358 nor, --, mozilla33, mh+mozilla, RESO FIXED, .mozconfig changes don't cause configure to run
11:29:27 <aleth> flo-retina: ah, of course, sorry.
11:35:36 <aleth> flo-retina: line 7/8 http://pastebin.instantbird.com/747968
11:37:05 <aleth> Those are new in the failing builds
11:57:03 <-- BWMerlin has quit (Quit: BWMerlin)
12:07:10 <-- mayanktg has quit (Ping timeout)
12:14:02 --> mayanktg has joined #instantbird
12:20:15 <flo-retina> aleth: The windows nightly! It's GREEN! \o/
12:20:49 <aleth> excellent! :-)
12:23:03 <flo-retina> aleth: have you noticed that the ":" at the end of the "Adding configure options from" line is gone?
12:23:14 <aleth> Yes
12:23:19 <aleth> Some string change somewhere?
12:23:46 <flo-retina> aleth: that points directly to this changeset: http://hg.mozilla.org/mozilla-central/rev/ce1c57e03b88
12:24:50 <aleth> Yeah, that's the one I pointed at earlier, where I said something might be hidden
12:26:16 <aleth> (because I don't understand all those changes ;) )
12:29:57 * Fallen|away is now known as Fallen
12:44:18 --> mconley has joined #instantbird
12:51:35 --> rosonline has joined #instantbird
12:53:42 <-- rosonline has quit (Connection reset by peer)
12:58:30 <-- mayanktg has quit (Ping timeout)
12:58:46 --> mayanktg has joined #instantbird
13:01:20 <-- mayanktg has quit (Ping timeout)
13:01:43 --> mayanktg has joined #instantbird
13:10:46 --> iamjayakumars has joined #instantbird
13:12:12 <-- mayanktg has quit (Ping timeout)
13:12:30 <-- mconley has quit (Input/output error)
13:12:49 --> mayanktg has joined #instantbird
13:14:24 <-- iamjayakumars has quit (Client exited)
13:15:23 <-- mayanktg has quit (Ping timeout)
13:15:43 --> mayanktg has joined #instantbird
13:19:07 --> Rym has joined #instantbird
13:21:19 <-- aleth has quit (Ping timeout)
13:23:12 --> aleth has joined #instantbird
13:23:12 * ChanServ sets mode +o aleth 
13:30:40 <-- mayanktg has quit (Ping timeout)
13:31:02 --> mayanktg has joined #instantbird
13:31:22 --> iamjayakumars has joined #instantbird
13:32:15 --> rosonline has joined #instantbird
13:47:48 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:54:29 <flo-retina> nhnt11: I think you should have a look at bug 1034975
13:54:33 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1034975 nor, --, ---, dteller, NEW, Crash in mozalloc_abort(char const* const) | NS_DebugBreak | nsDebugImpl::Abort(char const*, int) wi
13:55:00 <flo-retina> especially the "Search Service is not registered as a client of OS.File shutdown although it depends on it. This is a possible cause of AsyncShutdown timeouts." part ;)
14:02:19 <nhnt11> Hmm
14:04:01 * nhnt11 thought he read the documentation for that and made an informed decision
14:04:03 * nhnt11 rereads some stuff
14:05:14 --> mconley has joined #instantbird
14:13:48 <nhnt11> Okay, so I interpreted this - http://dxr.mozilla.org/mozilla-central/source/toolkit/components/osfile/modules/osfile_async_front.jsm#1530 - as "if you have stuff left to do during profile-before-change, do it using an AsyncShutdown blocker"
14:14:16 <nhnt11> er, s/during/at the start of/
14:14:54 <nhnt11> Maybe I should have interpreted it as, "OS.File automatically flushes its queue during profile-before-change, so queue your stuff before this"
14:17:39 <nhnt11> flo-retina: Thanks for pointing me to that
14:17:45 * nhnt11 files a bug and uploads a patch
14:18:29 <nhnt11> Hmm, I think I'll ask Yoric just to be sure though
14:20:43 <-- nhnt11 has quit (Ping timeout)
14:20:46 --> nhnt11 has joined #instantbird
14:23:16 <-- aleth has quit (Ping timeout)
14:24:06 --> aleth has joined #instantbird
14:24:06 * ChanServ sets mode +o aleth 
14:28:03 <aleth> nhnt11: Next time you push patches that touch chat/, make sure you star the oranges on tbpl before you do so. The sheriffs are a bit annoyed at people forgetting to do that.
14:29:53 <nhnt11> aleth: Thanks. Just read #maildev. Hmm.
14:31:07 <nhnt11> aleth: So I'm still confused on what starring an orange really means
14:31:28 <aleth> You click on the orange/red and look at why that step failed.
14:31:43 <aleth> Then you make sure there is a bug associated with each failure by starring.
14:31:54 <aleth> Sometimes there is no bug yet, then you have to file one.
14:32:31 <nhnt11> aleth: I don't see a UI for associating an orange with a bug
14:32:42 <aleth> If you click on a starred orange, you can see the result you want.
14:33:10 <aleth> nhnt11: It appears at the bottom. Click on "add a comment" to star,
14:33:17 <nhnt11> Ah!
14:33:29 <nhnt11> Got it
14:33:51 <nhnt11> Thanks
14:41:50 <nhnt11> aleth: Is it mandatory to star my own pushes, or star oranges before I push, or both? I understand it would be /nice/ to do both, of course. Just curious about the rules
14:42:19 <aleth> It's mainly important to star before.
14:42:54 <nhnt11> Okay
14:43:03 <aleth> The idea being that new failures get noticed.
14:43:16 <aleth> Of course it's assumed you're interested in new failures from your own push anyway ;)
14:43:51 <aleth> Partly it's such an issue on c-c because there are so many "perma-failing" (unfixed) tests
14:44:11 <aleth> This makes the process more of a chore than it should be.
14:44:18 <nhnt11> Yeah..
14:46:01 <instantbot> New Chat Core - General bug 1035844 filed by nhnt11@gmail.com.
14:46:03 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1035844 nor, --, ---, nobody, NEW, logger.js should add its profileBeforeChange blocker on OS.File instead of AsyncShutdown
14:56:14 <-- aleth has quit (Ping timeout)
15:11:04 --> aleth has joined #instantbird
15:11:04 * ChanServ sets mode +o aleth 
15:18:53 <-- Rym has quit (Ping timeout)
15:30:03 --> mayanktg has joined #instantbird
15:36:57 <-- mayanktg has quit (Ping timeout)
15:37:14 --> mayanktg has joined #instantbird
15:38:37 * Fallen is now known as Fallen|away
15:41:30 <-- mayanktg has quit (Ping timeout)
15:41:50 --> mayanktg has joined #instantbird
15:42:57 <-- iamjayakumars has quit (Client exited)
15:49:33 <-- mayanktg has quit (Ping timeout)
15:49:55 --> mayanktg has joined #instantbird
15:57:32 <-- nhnt11 has quit (Ping timeout)
15:58:23 --> nhnt11 has joined #instantbird
16:00:25 <nhnt11> aleth: Do you want me to yield all of them at once?
16:00:30 <nhnt11> Or just not bother with the I/O?
16:01:06 --> iamjayakumars has joined #instantbird
16:04:30 <-- iamjayakumars has quit (Client exited)
16:06:34 <aleth> nhnt11: You just yield the 1001st one as you do already.
16:06:41 <aleth> Isn't that enough?
16:06:42 <nhnt11> Yeah okay.
16:08:48 --> Rym has joined #instantbird
16:12:49 <-- gerard-majax_ has quit (Ping timeout)
16:19:29 <-- mayanktg has quit (Ping timeout)
16:19:49 --> mayanktg has joined #instantbird
16:22:00 <mayanktg> aleth: Hello. Regarding the comment http://log.bezut.info/instantbird/140707/#m254 What was UIConvs here? Were you saying to put a method to read the integer for current buddy in the conversation binding? 
16:22:37 <aleth> An uiConv is what you get when you use this.conv from conversation.xml
16:23:07 <aleth> http://mxr.mozilla.org/comm-central/source/chat/components/src/imConversations.js#18
16:24:21 <aleth> But as a first step, don't worry about that. Just work with conversation.xml
16:24:34 --> arlolra has joined #instantbird
16:25:04 <-- nhnt11 has quit (Ping timeout)
16:25:07 --> nhnt11 has joined #instantbird
16:25:38 <mayanktg> aleth: Thanks. Got it :)
16:25:40 <aleth> this.conv.buddy will give you the buddy for the conversation (if there is one)
16:28:19 <aleth> So you can get the availability integer from there.
16:28:33 <mayanktg> And then...I will use this to get the "availabilityDetail". Yeah exactly :)
16:41:06 --> Mook_as has joined #instantbird
16:46:18 <aleth> mayanktg: this should help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_Operators
16:50:53 <nhnt11> flo-retina: Do you want to look at bug 1025522 again or should I carry forward aleth's r+?
16:50:55 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1025522 nor, --, ---, nhnt11, ASSI, Split log files to prevent them from growing too large
16:51:12 <flo-retina> I'll have another quick look (but I'm in a meeting now)
16:51:18 <nhnt11> okay.
16:52:10 <mayanktg> aleth: Thanks. Giving it a read.
16:52:39 --> iamjayakumars has joined #instantbird
16:55:05 --> gerard-majax_ has joined #instantbird
16:57:42 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
16:58:45 * nhnt11 wonders if you can use negative values for setFoo on a date..
16:59:49 <nhnt11> Ah, it can.
16:59:50 <nhnt11> Nice.
17:00:17 <-- Rym has quit (Ping timeout)
17:02:14 --> Rym has joined #instantbird
17:09:55 * Fallen|away is now known as Fallen
17:13:53 <nhnt11> aleth: http://pastebin.instantbird.com/748059
17:13:58 <nhnt11> Do you approve? :)
17:14:06 <-- iamjayakumars has quit (Quit: )
17:15:10 <-- gerard-majax_ has quit (Ping timeout)
17:16:17 <-- mayanktg has quit (Ping timeout)
17:16:32 --> mayanktg has joined #instantbird
17:18:10 <flo-retina> why are these consts getters? :-S
17:18:17 <aleth> nhnt11: why did you use getters?
17:18:26 <nhnt11> Because they're consts?
17:18:32 <nhnt11> Um
17:18:38 <nhnt11> I guess we shouldn't calculate them every time
17:18:47 <flo-retina> right
17:18:51 * nhnt11 isn't sure why he decided to do that anymroe
17:18:52 <aleth> properties are fine ;)
17:19:10 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:19:53 <nhnt11> Everything else fine? Particularly the comment changes..
17:20:30 <aleth> Yes :)
17:20:54 <aleth> Well, |const kMessageCountLimit = logWriter.kMessageCountLimit;| makes no sense
17:21:09 <nhnt11> aleth: I wanted to avoid accessing it multiple times
17:21:20 * nhnt11 shrugs
17:21:29 <aleth> Yeah, but can you set a constant that way?
17:21:38 <nhnt11> I guess it's no big deal since there are no xpcom wrappers...
17:21:40 <nhnt11> Um, can't you?
17:21:41 <aleth> Just use let.
17:21:45 <nhnt11> Okay
17:22:02 <aleth> It's not a constant if it's set at runtime imho
17:22:02 <nhnt11> (I ran the test and it works, btw)
17:22:09 <nhnt11> Hmm
17:22:19 <aleth> Possibly a matter of taste
17:22:24 <nhnt11> Okay
17:23:12 <aleth> Hmm, I guess you are right, const could also just mean assign-once-only
17:23:29 <aleth> Never mind ;)
17:23:43 <nhnt11> Uh
17:23:47 <nhnt11> So I should leave it as a const?
17:24:02 <nhnt11> I've always treated const as synonymous to "final" fwiw
17:24:09 <aleth> If you prefer, leave it as is.
17:24:24 <nhnt11> Don't really care either way. Already changed it to let, so I'll leave it like htat
17:25:53 <aleth> Let's land it and get back to indexing and scrolling ;)
17:26:56 <nhnt11> yeah :(
17:43:58 --> flo-retina has joined #instantbird
17:43:58 * ChanServ sets mode +qo flo-retina flo-retina 
17:47:56 <-- mayanktg has quit (Ping timeout)
17:48:18 --> mayanktg has joined #instantbird
17:50:52 <-- mayanktg has quit (Ping timeout)
17:51:16 --> mayanktg has joined #instantbird
17:53:51 <-- jb has quit (Ping timeout)
17:56:41 <nhnt11> Great, I missed the fact that fts3 tables ignore column constraints and type information
18:00:14 <nhnt11> flo-retina: I can't find a way to restrict indexing to a single column, so I guess the solution is to have another table/view that maps row ids in the fts3 table to the filename/pathId
18:00:31 <flo-retina> yes
18:00:42 <nhnt11> Also, I'm going to switch to fts4, I don't see a reason not to.
18:03:22 <-- Rym has quit (Ping timeout)
18:03:41 --> Rym has joined #instantbird
18:04:18 <-- mayanktg has quit (Ping timeout)
18:04:35 --> mayanktg has joined #instantbird
18:16:21 <-- aleth has quit (Ping timeout)
18:45:19 <-- mayanktg has quit (Ping timeout)
19:02:08 <nhnt11> Bah, I have a syntax error somewhere that's causing "Error: missing } after function body" at the last line of logger.js :(
19:02:12 * nhnt11 has been searching and searching
19:02:44 <sawrubh> nhnt11: doesn't it show in the error console or when you run ./xpcshell <file in which you suspect>
19:02:54 <nhnt11> Oh, great. The second I say it here, I find it.
19:03:05 <nhnt11> sawrubh: It shows up in the error console as "Error: missing } after function body"
19:03:34 <sawrubh> normally it's a comma missing
19:03:41 <nhnt11> No, it was a missing } like it said
19:03:48 <nhnt11> Just somewhere totally different
19:04:26 <nhnt11> /technically/ all the syntax was right except for the missing brace, so it thought the last line was as good a place as any to close the block
19:10:12 --> mayanktg has joined #instantbird
19:11:57 <nhnt11> Interesting...
19:12:20 <nhnt11> I have a promise that resolves to an Sqlite.jsm connection, and I store the promise in a global variable gDBConn
19:12:33 <nhnt11> Weirdly, the connection instance gets GC'd
19:12:43 <nhnt11> Even though it's the value that gDBConn resolves to.
19:13:03 <nhnt11> I find that really confusing, and am pretty sure I'm interpreting the situation incorrectly.
19:19:41 --> aleth has joined #instantbird
19:19:41 * ChanServ sets mode +o aleth 
19:23:50 <nhnt11> Aha...
19:24:02 <nhnt11> Error in one of my Sqlite statements
19:24:04 <nhnt11> Wow
19:24:53 <aleth> Your promise didn't resolve, it failed?
19:25:09 <nhnt11> I was creating tables if not exists when obtaining the db connection, and one of these had an error. So the gDBConn promise rejected, and the connection never got closed. None of this was reported
19:25:25 <nhnt11> But I got a "warning" error from sqlite.jsm saying that the connection had been force-closed by GC
19:26:00 <aleth> Sounds like it relies on your code to do the error handling...
19:26:17 <nhnt11> I tried all of these statements in an sqlite3 shell... wonder what's wrong
19:26:17 <nhnt11> Yeah
19:26:51 <nhnt11> And even when I dump the error it doesn't give me anything useful, just "Error(s) occurred during statement execution"
19:27:30 <aleth> There isn't some way to get more detailed info? Some Error properties maybe?
19:28:15 <nhnt11> There is, I'm dumping it all now
19:29:51 <nhnt11> I changed a column name and forgot to update one of the references :(
19:31:03 <aleth> Always the little things...
19:33:53 --> nhnt11-testing has joined #instantbird
19:34:11 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:34:57 --> nhnt11-testing has joined #instantbird
19:35:12 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:37:23 <flo-retina> aleth: "You should also make sure that it's not possible to delete the log for an ongoing conversation." why?
19:38:01 <aleth> Because it's likely full of edge cases.
19:38:16 <nhnt11> Is this regarding one of my patches? ^
19:38:39 <aleth> (I'm not against supporting that in principle, but..)
19:38:46 <aleth> nhnt11: no
19:38:49 <nhnt11> OTR?
19:38:59 <aleth> sshagarwal's log deletion patch for TB
19:39:03 <nhnt11> Ah..
19:39:05 <nhnt11> okay
19:39:10 <flo-retina> aleth: I can totally see a use case where the user is unhappy about having logged a specific string (ie. a password that shouldn't have been said) and wants to remove the file
19:39:31 <flo-retina> tbh I'm not too interested in log deletion :-]
19:39:35 <aleth> flo-retina: Yeah... that's true.
19:39:56 <-- Rym has quit (Ping timeout)
19:40:12 <nhnt11> aleth, flo-retina: Fwiw, the right way to do it is to close the log writer, delete the file(s after the splitting patch lands), and open a new one.
19:40:30 <aleth> Yeah
19:40:45 <nhnt11> I don't see any weird edge cases, simply queue any incoming messages on the new log writer (open it immediately after closing the existing one)
19:41:18 <nhnt11> And we can probably just drop any pending messages.
19:41:40 <aleth> Hmm OK, if we drop pending messages, that doesn't sound too bad.
19:42:05 --> Rym has joined #instantbird
19:43:09 <nhnt11> aleth, flo-retina: Looks like that patch is massively bitrotted by async logs.
19:43:25 <aleth> nhnt11: He's aware of that
19:43:29 <flo-retina> I think aleth just left a comment saying that like an hour ago
19:43:40 <flo-retina> 2 hours ago :)
19:44:49 <nhnt11> I was feeling a bit bad about redundant work, but hopefully it's not too much of a pain.. 
19:45:30 <aleth> Also we discussed it a few weeks ago on #maildev ;) Async logs seemed readier-to-land than that patch at that point,
19:46:04 <flo-retina> hopefully your new async stuff is readable enough that updating the patch won't be too bad :)
19:46:05 <nhnt11> If that patch was being worked on while I was working on async logs, maybe we should have collaborated a bit...
19:46:07 * nhnt11 shrugs
19:46:11 <aleth> but the tree being closed etc added some time.
19:46:48 <flo-retina> nhnt11: I think that patch started before you started coding this summer; but it wasn't clear how long it would take
19:47:08 <nhnt11> Alright
19:47:43 <aleth> For a long time, sshagarwal was waiting for feedback on gloda issues (removing logs from the index)
19:48:29 * nhnt11 hopes that won't be too tricky for the logger.js index ;)
19:48:58 <nhnt11> I think I'll wait for the sshagarwal's patch to land before bothering about that :)
19:49:09 * nhnt11 gets back to work
19:54:22 <nhnt11> aleth, flo-retina: Is it okay to use Services.logs.getLogFromFile from within logger.js to get the contents of a log file for indexing? Or should I just read the log and parse it directly, avoiding all the enumerators and so forth?
19:54:28 <sawrubh> huh, so apparently I can't 'hg cp mozilla/browser/components/downloads/ chat/components/' because of 'mozilla' being a nested repo
19:54:31 * nhnt11 is currently just parsing it directly
19:54:50 <nhnt11> sawrubh: Right, you'll need to hg add the file
19:55:02 <nhnt11> after copying it manually
19:55:05 <sawrubh> I was trying to avoid that :/
19:55:11 <sawrubh> that just messes up the patch
19:55:16 <nhnt11> Why?
19:55:23 <nhnt11> Oh!
19:55:30 <sawrubh> I mean makes it unreadable (I'm just copying stuff
19:55:33 <nhnt11> You want to reuse all of that code?
19:55:39 <sawrubh> yeah
19:55:42 * nhnt11 shuts up, ask someone else :P
19:55:59 <aleth> A lot of what you need is in toolkit, thankfully - you can just use that
19:56:13 <sawrubh> the browser front end isnt
19:56:20 <aleth> Right.
19:56:31 <sawrubh> thats what I'm trying to copy and not show up in my patch as the entire file
19:56:58 <aleth> Unfortunately there's no way of doing that.
19:57:02 <sawrubh> Googling tells me nested repos aren't super favs of mercurial
19:57:37 * sawrubh shuts up and does it the ugly way
19:57:48 <aleth> Maybe have one patch where you copy the files, and then another patch in you queue doing modifications
19:58:31 <aleth> Hides the mess ;)
19:58:33 <sawrubh> that could make sense, I think I had that in FileLink but I normally don't like this jumping around between mq's
19:58:48 <sawrubh> but seems the relatively better solution :)
19:58:51 --> clokep_work has joined #instantbird
19:58:51 * ChanServ sets mode +o clokep_work 
19:59:04 <sawrubh> yay, clokep_work's here!
20:00:29 <clokep_work> sawrubh: I am. Give me a minute though.
20:00:33 <clokep_work> (And the world cup game is on.)
20:00:56 <sawrubh> oh shit, it's the semis!
20:02:43 <clokep_work> Germany & Brazil, yeah.
20:07:11 <clokep_work> mayanktg: I'm mostly caught up.
20:07:17 <clokep_work> Oops, that was for sawrubh. :( Sorry.
20:07:30 <mayanktg> clokep_work: np :)
20:08:04 <clokep_work> mayanktg: I was wondering what the status is of the webcam patch? :)
20:10:37 <mayanktg> clokep_work: I talked to Mic two days ago regarding fixing the CSS for windows. He gave me a few changes which I changed, but he said that we need to define a different height for the buttons specially for Windows using ifdefs. He didn't come online after that. :(
20:11:33 <aleth> Maybe he's watching the football ;)
20:11:59 <clokep_work> mayanktg: Is that something I can help you w/?
20:12:55 <mayanktg> clokep_work: Yes sure! Try the user icon patch in windows and try if the buttons are set properly.
20:13:31 <mayanktg> Though you are not a CSS guy I know..but please try if you are free. ;)
20:14:44 --> nhnt11-testing has joined #instantbird
20:15:07 <clokep_work> mayanktg: I was under the imrpession you just needed help adding the ifdefs. :-\
20:15:11 <clokep_work> I don't have access to a Windows machine ATM.
20:16:39 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:20:10 <-- Rym has quit (Ping timeout)
20:22:52 --> Rym has joined #instantbird
20:31:32 --> EionRobb has joined #instantbird
20:34:20 <clokep_work> sawrubh: Did you need something? :-S
20:42:44 <-- aleth has quit (Ping timeout)
20:43:11 --> aleth has joined #instantbird
20:43:11 * ChanServ sets mode +o aleth 
20:44:13 <clokep_work> sawrubh: Please let me know when you're back.
20:49:32 <clokep_work> flo-retina: Is there anything I can currently do about the Linux bustage? :)
20:49:45 <sawrubh> clokep_work: no I don't need something super critically, you could give feedback on the patch if you want and are bored on your vacation
20:49:48 <-- Rym has quit (Ping timeout)
20:50:00 <flo-retina> clokep_work: what about fixing Mac first?
20:50:20 <clokep_work> sawrubh: I wouldn't be online if I was busy. ;) I already left you feedback. If you disagree or do not understand some of my comments; pelase ask me.
20:50:35 <clokep_work> flo-retina: It sounded like you guys were on top of it, but I guess not.
20:51:02 <clokep_work> aleth, flo-retina: Btw switching the quotes might have to do with escaping quotes, i.e. you don't have to escape " inside of a single quoted string.
20:51:04 <flo-retina> clokep_work: we made 'progress' in that we determined where things start going wrong
20:51:11 <flo-retina> we have no idea for what the fix is though
20:51:51 <flo-retina> clokep_work: given the failure we were seeing, I'm pretty sure it wasn't the reason
20:52:04 <clokep_work> Alright. :)
20:52:09 --> Rym has joined #instantbird
20:59:46 <-- mayanktg has quit (Ping timeout)
21:00:14 --> mayanktg has joined #instantbird
21:02:53 <-- mayanktg has quit (Ping timeout)
21:03:42 --> mayanktg has joined #instantbird
21:07:01 --> rosonline has joined #instantbird
21:09:46 <clokep_work> flo-retina: So first step is to update my build and see if I can reproduce the afilure locally?
21:10:28 <aleth> clokep_work: You'll have to make an universal build with the buildbot mozconfigs, so idk if that would work
21:10:40 <flo-retina> clokep_work: and you can just do the configure
21:10:44 <flo-retina> the issue is already visible there
21:11:05 <flo-retina> (doing a full universal build is long, you can skip that :))
21:11:18 <aleth> thankfully!
21:12:58 <aleth> clokep_work: The problem is the --with-unify-dist line change here in this comparison of logs http://pastebin.instantbird.com/747968
21:15:10 <clokep_work> Hm....so where ARE the buildbot configs again? :-D
21:15:26 <flo-retina> clokep_work: you mean the mozconfigs?
21:15:32 <clokep_work> Ah found it. :)
21:15:33 <clokep_work> Yes.
21:18:48 <clokep_work> Bah. I don't have ccache installed...
21:22:51 <flo-retina> does it matter?
21:23:07 <-- Rym has quit (Ping timeout)
21:23:41 <clokep_work> Well I'm running into an error, so yes. ;)
21:25:23 <clokep_work> There we go :)
21:26:05 <clokep_work> aleth: http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2240/steps/compile/logs/stdio looks like it broke well into the actual build? :-S
21:26:44 <aleth> You only notice the problem after the build finishes because the second set of files is missing
21:27:08 <aleth> There's nothing wrong with the actual build part.
21:28:48 --> Rym has joined #instantbird
21:29:53 <clokep_work> :-S OK.
21:31:54 <-- arlolra has quit (Quit: arlolra)
21:39:40 <clokep_work> with-unify-dist seems to be set properly on my machine. . .
21:39:55 <aleth> Are you using mach?
21:40:12 <clokep_work> Yes
21:41:23 <aleth> I was wondering earlier today if that was part of the problem (i.e. the buildbot not using mach)
21:43:34 <-- mconley has quit (Input/output error)
21:50:39 <-- Rym has quit (Ping timeout)
21:52:04 <-- clokep_work has quit (Ping timeout)
21:52:40 <sawrubh> aleth: there?
21:53:53 --> Rym has joined #instantbird
21:57:59 <-- mayanktg has quit (No route to host)
21:58:48 <aleth> sawrubh: hi
22:00:29 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
22:03:29 <sawrubh> aleth: so with the patch I currently have on bug 1024023 (the one about backend implementation) and http://pastebin.instantbird.com/747589 as the writeChunk implementation (in xmpp-file-transfer.jsm) and http://pastebin.instantbird.com/747590 being the 'close' IQ stanza handler what do you think I'm doing wrong?
22:03:32 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1024023 nor, --, ---, saurabhanandiit, ASSI, Add File Transfer Support for JS-XMPP
22:04:17 <sawrubh> (btw this is the issue I was asking yesterday), I still don't get what I'm doing wrong
22:04:37 <aleth> You're doing nothing with the promise returned by write(), so nothing is chained
22:04:45 --> mayanktg has joined #instantbird
22:05:19 <aleth> You have two then()s but they act on the same promise so there's no point.
22:06:28 <sawrubh> so I want to keep the file open and it's reference in this._file so do you think I should assign the promise returned by the write() to this._file
22:06:40 <aleth> That's one way to do it
22:06:48 <nhnt11> sawrubh: make line 10 return 
22:06:54 <nhnt11> return aFile.write(dataToWrite);
22:06:56 <aleth> I suggested using a Task
22:07:00 <nhnt11> is what I think aleth means :)
22:07:11 <-- Even has quit (Ping timeout)
22:07:39 <aleth> sawrubh: nhnt11 is right, if you want to stick with explicit promises
22:08:37 <nhnt11> aleth, sawrubh: I'm wrong
22:08:39 <aleth> You could look at nhnt11's file operation queue if you think you need one
22:08:46 <sawrubh> aiui the returned promise goes to the next chained one
22:08:57 <sawrubh> if I return on L10 then how will it get assigned to this._file
22:08:59 <aleth> sawrubh: It doesn't do this by magic
22:08:59 <nhnt11> Returning there will not work, because write() returns the number of bytes written
22:09:07 <sawrubh> I'll need something like..
22:09:21 <nhnt11> sawrubh: Your problem is that you never wait for the write() to be executed
22:09:31 <aleth> Yeah, that's what I keep saying
22:09:40 <nhnt11> So either you need a Task like aleth said, or you should not be chaining then's
22:09:53 <nhnt11> So what you said about keeping the reference works yeah
22:10:48 <nhnt11> "assign the promise returned by the write() to this._file" <- okay this probably won't work (I don't know what it means)
22:11:03 <nhnt11> Oh, that way.
22:11:16 * nhnt11 votes for a Task ;)
22:11:24 <aleth> Much simpler that way.
22:11:32 <sawrubh> http://pastebin.instantbird.com/748112
22:11:38 <sawrubh> err wait I need to remove the thens
22:12:13 <aleth> no, now your then chain works I think
22:12:46 <nhnt11> Yeah, the chain should work, but note that the then on line 15 would have no access to the file
22:13:06 <nhnt11> (this._file would finally resolve to the number of bytes written and you would lose the reference to the file altogether)
22:13:09 <aleth> It's not the most readable way to do it...
22:13:27 <nhnt11> Losing the reference means you keep the file open btw
22:13:40 <aleth> I think he wants to keep the file open
22:13:47 <nhnt11> aleth: But with no way to close it?
22:14:09 <sawrubh> http://pastebin.instantbird.com/747590 is the closing code
22:14:13 <aleth> Oh, right.
22:14:27 <sawrubh> that happens when I get the right IQ stanza
22:14:40 <nhnt11> sawrubh: By assigning a new promise to this._file on line 8, you're removing the reference to the file itself.
22:15:00 <nhnt11> s/the file itself/the promise that resolves to the file/
22:15:54 <aleth> Didn't I point you at this yesterday already? https://developer.mozilla.org/en-US/docs/JavaScript_OS.File/OS.File_for_the_main_thread#Example.3A_copy_a_file_by_chunks
22:16:00 --> Hadi has joined #instantbird
22:16:02 <aleth> It's pretty much exactly what you need
22:20:11 --> nhnt11-testing has joined #instantbird
22:20:19 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:23:05 <-- aleth has quit (Quit: exit stage left)
22:31:06 <-- mayanktg has quit (Ping timeout)
22:31:27 --> mayanktg has joined #instantbird
22:33:09 <-- mayanktg has quit (Ping timeout)
22:33:35 --> mayanktg has joined #instantbird
22:36:08 <-- mayanktg has quit (Ping timeout)
22:36:30 --> mayanktg has joined #instantbird
22:37:46 --> mconley has joined #instantbird
22:39:04 <-- mayanktg has quit (Ping timeout)
22:39:26 --> mayanktg has joined #instantbird
22:41:09 <-- mayanktg has quit (Ping timeout)
22:41:34 --> mayanktg has joined #instantbird
22:44:15 <-- mconley has quit (Connection reset by peer)
22:44:55 <-- mayanktg has quit (Ping timeout)
22:45:17 --> mayanktg has joined #instantbird
23:02:09 <-- Rym has quit (Ping timeout)
23:02:28 * Fallen is now known as Fallen|away
23:05:06 --> Rym has joined #instantbird
23:13:15 <-- mayanktg has quit (Ping timeout)
23:13:36 --> mayanktg has joined #instantbird
23:19:17 <-- mayanktg has quit (Ping timeout)
23:19:47 <-- rosonline has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
23:28:13 --> mib_k3f81p has joined #instantbird
23:32:14 <-- mib_k3f81p has quit (Quit: http://www.mibbit.com ajax IRC Client)
23:37:13 <-- Hadi has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
23:48:20 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)