#instantbird log on 06 19 2014

All times are UTC.

00:11:13 <-- nhnt11 has quit (Ping timeout)
00:11:47 --> nhnt11 has joined #instantbird
00:21:09 <-- wnayes has quit (Ping timeout)
00:24:33 --> wnayes has joined #instantbird
00:32:40 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
01:12:23 <-- Mook_as has quit (Quit: Mook_as)
01:35:07 <-- yash_ has quit (Ping timeout)
01:35:30 --> yash_ has joined #instantbird
01:42:59 <-- Suiseiseki has quit (Ping timeout)
01:47:57 --> Suiseiseki has joined #instantbird
01:49:28 <-- Rym_ has quit (Ping timeout)
01:50:38 --> Rym_ has joined #instantbird
01:59:16 --> mconley has joined #instantbird
02:10:39 <-- wnayes has quit (Quit: wnayes)
03:04:50 <-- yash_ has quit (Quit: Connection closed for inactivity)
03:05:07 <-- mconley has quit (Input/output error)
03:05:14 <-- Rym_ has quit (Ping timeout)
03:37:03 --> mconley has joined #instantbird
03:46:19 <-- Mook has quit (Quit: Mook)
03:46:33 --> Mook has joined #instantbird
03:49:51 <-- clokep has quit (Ping timeout)
04:06:46 <-- mconley has quit (Input/output error)
04:26:57 --> qheaden has joined #instantbird
04:27:20 <qheaden> Hello all. In the mozconfig, how do you disable Werror on compile?
04:27:52 <qheaden> I'm using ac_add_options --disable-warnings-as-errors, but I still seem to be getting Werror errors when the build tries to compile the purple extension.
04:50:03 --> gerard-majax__ has joined #instantbird
04:53:47 <-- gerard-majax__ has quit (Ping timeout)
05:27:38 <-- Mook has quit (Quit: Mook)
05:30:43 --> mconley has joined #instantbird
05:43:25 <-- EionRobb has quit (Quit: Leaving.)
05:58:51 --> Rym_ has joined #instantbird
06:13:29 * Fallen|away is now known as Fallen
06:15:55 <-- Fallen has quit (Quit: ZNC - http://znc.sourceforge.net)
06:19:14 --> Fallen has joined #instantbird
06:25:45 --> mpmc has joined #instantbird
06:36:15 <-- mconley has quit (Input/output error)
06:58:43 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
06:58:46 --> xangua has joined #instantbird
07:37:23 --> EionRobb has joined #instantbird
07:50:33 --> gerard-majax__ has joined #instantbird
07:58:31 <-- Rym_ has quit (Ping timeout)
08:05:42 --> petunia has joined #instantbird
08:19:48 <-- petunia has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
08:37:31 <flo-retina> qheaden: are you sure it's not a real error?
08:37:50 <flo-retina> qheaden: the QQ plugin fails to compile for me (and probably fails on all 64bit machines)
08:37:55 --> Armada has joined #instantbird
08:38:02 --> mayanktg has joined #instantbird
08:48:11 --> Rym_ has joined #instantbird
09:05:26 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
09:05:41 --> chrisccoulson has joined #instantbird
09:27:17 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:28:24 --> BWMerlin has joined #instantbird
09:39:13 <-- xangua has quit (Quit: Connection closed for inactivity)
09:45:16 --> Mic|web has joined #instantbird
09:52:41 --> flo-retina has joined #instantbird
09:52:41 * ChanServ sets mode +qo flo-retina flo-retina 
09:53:26 <flo-retina> nightlies still not fixed? :(
09:53:42 <flo-retina> nhnt11: ?
09:53:51 <mayanktg> Mic|web: Hello and Good morning! :) I am making changes in the "video call" patches so that it can be ready. I'll post the details in the bug about the flow and other fixes that needs to be done. 
10:15:59 <-- EionRobb has quit (Quit: Leaving.)
10:21:25 --> clokep has joined #instantbird
10:21:25 * ChanServ sets mode +o clokep 
10:34:30 <clokep> Hello.
10:38:57 <flo-retina> clokep: good morning! :)
10:39:57 <-- Rym_ has quit (Ping timeout)
10:41:38 <clokep> Yes, it's morning. Good is as yet to be determined. :P
10:41:53 <flo-retina> it's a morning without nightly :-\
10:41:58 <flo-retina> but the minis are in France!
10:44:50 <clokep> I saw! :)
10:45:01 <clokep> If the nightlys aren't fixed when I get to work I'll do a build.
10:45:20 <flo-retina> heh, you keep refreshing that tracking page too?
10:45:49 <clokep> Yeah, like twice a day.
10:50:35 <-- clokep has quit (Ping timeout)
10:50:35 <-- mayanktg has quit (Ping timeout)
10:50:42 --> clokep has joined #instantbird
10:50:42 * ChanServ sets mode +o clokep 
11:03:27 --> mayanktg has joined #instantbird
11:05:16 <-- clokep has quit (Ping timeout)
11:10:19 --> aleth_web has joined #instantbird
11:19:55 <nhnt11> Hi
11:21:01 <nhnt11> I thought qheaden was fixing it :S
11:21:10 <nhnt11> http://log.bezut.info/instantbird/yesterday/#m399
11:22:02 * nhnt11 tries fixing it now
11:24:31 <aleth_web> nhnt11: You should be able to push to try now.
11:24:41 <flo-retina> aleth_web: have you fixed it?
11:24:59 <nhnt11> Just saw the tree is open, yeah :)
11:25:12 <aleth_web> flo-retina: ryanvm fixed it
11:25:12 <nhnt11> (er, and that people are pushing)
11:25:39 <flo-retina> aleth_web: ah... we are not talking about the same thing :-D
11:25:49 <flo-retina> aleth_web: he didn't fix it in im/, so our nightlies are still busted
11:26:00 <flo-retina> but yes, that's enough for nhnt11 to push to try to ensure he isn't breaking TB
11:26:04 <aleth_web> :-(
11:26:34 <nhnt11> flo-retina: Do we need a bug for the /im fix or can you rs it on IRC?
11:26:50 <flo-retina> nhnt11: you can just land with r=bustage-fix
11:26:55 <nhnt11> hmm, my build seems to be taking some time, please standby ;)
11:26:57 <nhnt11> alright.
11:27:16 <flo-retina> would be nice to mention the number of the bug that broke us in the commit message
11:27:23 <flo-retina> nhnt11: see https://hg.mozilla.org/comm-central/rev/852267c1a357 for an example
11:27:34 <nhnt11> Cool, thanks.
11:29:36 --> Rym_ has joined #instantbird
11:38:32 <nhnt11> :S
11:39:06 <nhnt11> https://pastebin.mozilla.org/5435419
11:40:06 <flo-retina> nhnt11: have you applied/unapplied mayanktg's user icon patch recently without clobbering?
11:40:22 <flo-retina> nhnt11: it seems your build has webrtc half-enabled
11:40:38 <nhnt11> flo-retina: Interestingly I unapplied without clobbering, did a ./mach build, worked fine. Added the bustage fix, did a /mach build, failure!
11:40:44 <nhnt11> I'm confused why it didn't fail the first time
11:41:20 <flo-retina> are you sure you did a full ./mach build at the top level?
11:41:32 <nhnt11> Eerm, I must be blind
11:41:35 <nhnt11> the first build failed too
11:41:40 <flo-retina> ah!
11:42:14 <nhnt11> flo-retina: Can I build over mayank tg's patch?
11:42:27 <nhnt11> (or should I clobber now, and clobber again when I'm looking at that)
11:42:28 * Fallen is now known as Fallen|away
11:42:49 <nhnt11> I think I'll clobber
11:44:39 <flo-retina> "Can I build over mayank tg's patch?" probably. And I hope that patch will land soon :)
11:44:45 <flo-retina> nhnt11: have you pushed to try yet? :)
11:45:11 <nhnt11> flo-retina: No. I'll do that after pushing this packaging fix.
11:45:24 <flo-retina> wouldn't it make sense to push to try before?
11:45:38 <flo-retina> so that the try server builds while you are building locally to test your fix?
11:45:51 <nhnt11> true
11:45:52 <nhnt11> okay
11:46:02 * nhnt11 cancels his build since it's only a minute in anyway
11:54:02 <nhnt11> Uh
11:54:17 <nhnt11> Has the packaging fix not been pulled by try yet :S
11:54:25 <nhnt11> The last try build request has that in its queue
11:54:54 <nhnt11> No, I did an |hg outgoing try| after a checkout, seemed fine.
11:55:18 <-- Rym_ has quit (Ping timeout)
11:59:15 --> clokep_work has joined #instantbird
11:59:16 * ChanServ sets mode +o clokep_work 
11:59:45 --> Rym_ has joined #instantbird
12:01:35 * Fallen|away is now known as Fallen
12:07:02 <nhnt11> Uh, weird
12:07:06 <clokep_work> ?
12:07:08 <nhnt11> It seems I don't have the purple repo
12:08:18 <nhnt11> No, I have it.
12:08:22 <nhnt11> Just didn't have it in my mozconfig
12:09:16 <-- mayanktg has quit (Ping timeout)
12:10:47 <nhnt11> clokep_work: Do I need to clobber after adding purple to my mozconfig?
12:10:55 <nhnt11> simple mach build didn't do the trick apparently
12:11:26 --> mayanktg has joined #instantbird
12:12:20 <nhnt11> clobbering
12:12:21 <nhnt11> brb..
12:14:17 <-- BWMerlin has quit (Quit: BWMerlin)
12:14:58 <clokep_work> nhnt11: mach configure
12:15:06 <clokep_work> nhnt11: Before trying a clobber you should always try just configuring first.
12:15:37 --> yash_ has joined #instantbird
12:19:46 <nhnt11> clokep_work: Okay. It's fine though, I'm running around atm anyway :)
12:20:05 <nhnt11> I thought ./mach build does configure for you
12:20:09 <nhnt11> I've seen it do that a couple of times
12:20:27 <clokep_work> Bah I never clobbered after that reticulating splines issue.
12:20:32 <clokep_work> nhnt11: It seems to "sometimes" do it.
12:20:37 <clokep_work> I haven't figured out when or why.
12:20:43 <clokep_work> If I touch the build system at all, I always manually run it.
12:20:51 <nhnt11> Alright, good to know
12:22:24 <-- Gizmokid2005 has quit (Quit: ZNC - http://znc.sourceforge.net)
12:23:25 --> Gizmokid2005 has joined #instantbird
12:24:38 * Fallen is now known as Fallen|away
12:33:21 <nhnt11> Errors...
12:34:16 <aleth_web> http://xkcd.com/722/
12:35:38 <nhnt11> Haha
12:35:47 <nhnt11> https://pastebin.mozilla.org/5435613
12:35:48 <nhnt11> :(
12:36:02 <nhnt11> I seem to recall there were some problems with qq?
12:36:14 <nhnt11> I did a fresh checkout and pulled purple before the clobber build..
12:36:28 <aleth_web> yeah, don't build qq.
12:37:48 <aleth_web> nhnt11: http://pastebin.instantbird.com/738349
12:37:55 <clokep_work> nhnt11: My build finished, don't bother.
12:38:08 * nhnt11 sighs
12:38:11 <nhnt11> okay
12:38:16 <nhnt11> aleth_web: thanks
12:44:27 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
12:46:53 --> qheaden has joined #instantbird
12:47:05 <qheaden> Hey guys.
12:47:27 * Fallen|away is now known as Fallen
12:47:27 <clokep_work> Hello qheaden.
12:47:32 <clokep_work> I'm about to push your patch.
12:47:57 <qheaden> clokep_work: Okay.
12:48:11 <qheaden> flo-retina: I see your message in the log. Yes, QQ is failing for me.
12:49:33 <qheaden> clokep_work: Sorry I couldn't test the patch. I couldn't get the purple extensions to compile.
12:50:31 <aleth_web> qheaden: apply this http://pastebin.instantbird.com/738349
12:51:03 <qheaden> Okay, thanks.
12:57:16 <-- qheaden has quit (Ping timeout)
12:57:27 * Fallen is now known as Fallen|away
12:57:29 <nhnt11> uh
12:57:34 <nhnt11> https://tbpl.mozilla.org/php/getParsedLog.php?id=42048762&tree=Thunderbird-Try
12:58:54 --> qheaden has joined #instantbird
13:00:44 <flo-retina> nhnt11: let's see if it fails in the same way for other builders
13:01:13 <clokep_work> :-S
13:01:21 <clokep_work> My build just failed building the spellcheck library.
13:01:22 <flo-retina> nhnt11: or we can retrigger it if you want
13:09:19 <-- qheaden has quit (Input/output error)
13:10:12 --> qheaden has joined #instantbird
13:14:41 <-- wsmwk has left #instantbird ()
13:16:54 * Rym_ is now known as Rym
13:17:35 <nhnt11> flo-retina: Would retriggering it help
13:17:35 <nhnt11> ?
13:18:30 <nhnt11> Hmm, more tests failing :(
13:26:00 <flo-retina> nhnt11: this one looks like your test failing though: https://tbpl.mozilla.org/php/getParsedLog.php?id=42049214&tree=Thunderbird-Try&full=1
13:27:18 <nhnt11> Ah... interesting
13:28:04 <-- Rym has quit (Ping timeout)
13:28:53 --> Rym has joined #instantbird
13:29:57 <flo-retina> what's test_logger.js :: test_logging/testMsgs :: line 366 ?
13:30:11 <nhnt11> I'm checking
13:30:15 <nhnt11> Tests are passing locally
13:30:31 <nhnt11> The line is |equal(expectedMessage[prop], message[prop]);|
13:30:44 <nhnt11> (hold on)
13:30:53 <nhnt11> The problem is that the assert is failing
13:31:06 <nhnt11> i.e. the read time is different from the expected time
13:31:08 <nhnt11> which is.. odd.
13:31:31 <nhnt11> I'm going to add messages for some of these asserts
13:41:51 <flo-retina> nhnt11: chat/components/src/test/test_logger.js | 1309244401 == 1309330801
13:43:01 <flo-retina> nhnt11: "Tests are passing locally" I would have asked you to push to try if they weren't ;).
13:44:41 <nhnt11> flo-retina: Yes I saw that already
13:44:59 <nhnt11> Not sure what could be causing it. I'll take a look in a few minutes
13:46:14 <aleth_web> maybe something async is being async...
13:47:26 <flo-retina> aleth_web: how surprising!
13:48:38 <flo-retina> 1309244401 is June 28 2011 at 9am.
13:49:14 <flo-retina> 1309330801 is June 29 2011 also at 9am.
13:49:26 <flo-retina> (I said 9am but it's actually 9:00:01)
13:49:40 <flo-retina> nhnt11: could you have things that don't get logged in the expected order?
13:51:57 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:52:06 <flo-retina> nhnt11: your test failed on both Linux 64 jobs, but not on the other platforms
13:52:14 <flo-retina> nhnt11: I wonder if it's random, or failing specifically there.
13:52:26 <flo-retina> I retriggered both failures
14:00:50 <-- Rym has quit (Ping timeout)
14:01:08 --> Rym has joined #instantbird
14:09:16 <nhnt11> flo-retina: Very interesting.
14:09:21 <nhnt11> I really doubt it's random
14:09:36 <nhnt11> I'm going to look up if there's something I'm missing about JS dates and 64bit platforms
14:09:44 <clokep_work> There should not be.
14:09:46 <nhnt11> I wonder if a win64 build would also fail
14:09:48 <flo-retina> I suspect it's random, but I would like to see if try agrees (hence the retrigger)
14:10:10 <flo-retina> nhnt11: I wouldn't look for an issue with the date
14:10:13 <nhnt11> flo-retina: If it's june 28th and 29th, doesn't seem random to me. Both those dates are used in my tests. (on purpose)
14:10:19 <flo-retina> nhnt11: there's exactly one day of difference between the 2 timestamps
14:10:20 <nhnt11> flo-retina: Yeah I suspect it's something with file I/O
14:10:34 <flo-retina> nhnt11: these dates are definitely not random. It's the test failure that could be random
14:10:36 <nhnt11> (er I suspected dates first, but then realized it can't be a problem there)
14:10:42 <nhnt11> Hmm
14:11:07 <nhnt11> What could have happened is that one log failed to get written
14:11:23 <nhnt11> and in that case the first message would have the timestamp of dummyConv2 instead of dummyConv
14:13:04 * flo-retina wonders if nhnt11 now understands why he insisted on the patch being pushed to try before landing :).
14:13:26 <nhnt11> Yeah :)
14:14:09 <-- mayanktg has quit (Ping timeout)
14:14:12 --> mayanktg has joined #instantbird
14:28:14 --> rosonline has joined #instantbird
14:37:43 --> mconley has joined #instantbird
14:39:34 <-- Even has quit (Ping timeout)
14:49:31 <-- nhnt11 has quit (Ping timeout)
14:53:23 <clokep_work> mayanktg: Do all those patches need to be separate? It would seem to me like some of those fit together well.
14:55:56 <mayanktg> clokep_work: aleth_web told that it would be easier to review if the patches were in smaller parts. That's why I divided  them. Ok I'll merge the patches which are likely similar. :)
14:59:13 <flo-retina> nhnt11: seems to fail consistently on Linux x64 Opt :)
15:00:13 <aleth_web> mayanktg: It's actually better if you combine them. Smaller patches (in separate bugs) are easier and quicker to review and land, but you are working on what is necessarily a fairly big patch.
15:00:34 <aleth_web> mayanktg: Organise them however is most convenient for your (e.g. you might want to keep the UI patches separate, or the tests)
15:01:50 <aleth_web> Have you addressed my previous comments on that bug in your latest patches?
15:02:00 <mayanktg> aleth_web: Yes. And its becoming difficult to keep them into smaller patches. :( Ok. I'll merge them.
15:04:26 --> nhnt11 has joined #instantbird
15:05:28 <mayanktg> aleth_web: I fixed the errors you mentioned in the patches. Wait...I'm addressing them.
15:05:30 <flo-retina> nhnt11: the failures are consistent, on both Linux 64 Opt and debug
15:05:51 <nhnt11> flo-retina: Thanks
15:05:53 <nhnt11> I'm looking at it
15:06:07 <nhnt11> I'm not entirely certain I can debug this without access to a linux machine
15:06:12 <nhnt11> (maybe time to install a VM)
15:06:39 <nhnt11> First I'll look more closely at the log
15:06:49 <flo-retina> there's no guarantee that your local linux 64 build would fail in the same way
15:07:17 <aleth_web> nhnt11: It might help to keep adding more detailed test output/further tests and retrying until you discover what is goig on.
15:07:44 * qheaden finally got his build to work.
15:07:47 <qheaden> aleth_web: Thanks for that patch.
15:08:11 * flo-retina wonders if qheaden is building on linux 64 and would feel like testing something for nhnt11
15:08:13 <nhnt11> aleth_web: Hmm. Maybe a linux64-only try push wouldn't be expensive..
15:08:19 <aleth_web> nhnt11: Right :)
15:08:25 <qheaden> flo-retina: No prob
15:08:33 <qheaden> What do I need to test?
15:08:34 <flo-retina> nhnt11: you'll certainly push to try several times to debug this.
15:08:57 <flo-retina> qheaden: the tests nhnt11 is adding in bug 955292 fail on the try server only on Linux 64
15:09:00 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955292 enh, --, ---, nhnt11, ASSI, Read/write chat logs asynchronously
15:09:04 <nhnt11> qheaden: I'll let you know in a bit if you can help :)
15:09:11 <qheaden> Okay.
15:10:11 <qheaden> brb
15:10:16 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:10:39 --> qheaden has joined #instantbird
15:11:38 * qheaden is happy to finally be able to use office communicator in Ib instead of using Pidgin.
15:11:51 <flo-retina> \o/
15:12:08 <qheaden> I can't wait until Ib nightlies start again.
15:14:06 <flo-retina> wanna fix them?
15:14:28 <flo-retina> the new builders are currently in fedex's hands (https://www.fedex.com/fedextrack/?tracknumbers=770303619810)
15:20:41 <qheaden> Cool stuff. Are they Mac Minis?
15:21:21 <flo-retina> yes, 10 mac minis
15:21:26 <qheaden> Awesome.
15:21:43 <flo-retina> qheaden: they are from http://armenzg.blogspot.de/2014/05/do-you-need-used-mac-mini-for-your.html
15:21:52 * qheaden needs to get a Mac Mini so he can play around with OS X development
15:22:25 <qheaden> flo-retina: Cool. I remember seeing you guys talk about it in the team emails.
15:24:08 <-- nhnt11 has quit (Ping timeout)
15:24:27 --> nhnt11 has joined #instantbird
15:25:44 <flo-retina> apparently some minis have already arrived elsewhere: https://www.haiku-os.org/blog/kallisti5/2014-06-11_haiku_receives_donation_mozilla_foundation
15:26:52 <qheaden> Nice.
15:27:39 <-- mayanktg has quit (Ping timeout)
15:27:54 --> mayanktg has joined #instantbird
15:28:15 <flo-retina> looks like they just drove to the datacenter themselves: https://www.haiku-os.org/files/IMG_20140611_112739552_HDR.jpg
15:28:56 <nhnt11> :)
15:33:34 <aleth_web> mayanktg: If you are combining patches, can you put the new combined patches in the bug soon (instead of the current ones)?
15:35:28 <aleth_web> I would suggest one patch with the tests and one for everything else.
15:37:51 <-- nhnt11 has quit (Ping timeout)
15:38:36 <aleth_web> mayanktg: hg qfold may be useful
15:39:51 <-- yash_ has left #instantbird ()
15:44:11 <-- gerard-majax__ has quit (Ping timeout)
15:45:31 <-- clokep_work has quit (Ping timeout)
16:00:51 --> mayanktg-ph has joined #instantbird
16:02:27 <-- Rym has quit (Ping timeout)
16:09:09 --> arlolra has joined #instantbird
16:10:55 <mayanktg> aleth_web: Thanks. I'll do that.
16:21:34 --> nhnt11 has joined #instantbird
16:37:32 <-- nhnt11 has quit (Ping timeout)
16:40:22 --> nhnt11 has joined #instantbird
16:47:32 --> Mook_as has joined #instantbird
16:53:02 --> Hadi has joined #instantbird
16:56:27 <-- Hadi has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:59:23 --> jb has joined #instantbird
17:13:09 <aleth_web> mayanktg: Is there anything missing/todo in your latest patches that should not be left for followups?
17:14:40 <aleth_web> i.e. what's still on your todo list for that bug?
17:14:43 <mayanktg> Yes. I have to fix how the remotevideo, localvideo gets resized when width of window is changed, CSS should be added to notification bar and "disconnect" button. 
17:16:57 <mayanktg> Also a new call should be established when no conversation has been made before.
17:17:27 <mayanktg> Wait.. I'm sharing you the screenshot of the conversation window during the call...
17:18:50 <aleth_web> "a new call should be established when no conversation has been made before" can be a followup I think.
17:20:34 <mayanktg> aleth_web: http://i.imgur.com/oOsyfTkl.jpg
17:21:56 <mayanktg> I have to stream the video such that...the width of remoteVideo is width of the window and there is also adequate amount of space left for the chat box.
17:22:25 <-- mayanktg-ph has quit (Quit: )
17:22:44 <aleth_web> What's the grey box in the top right corner?
17:23:21 <mayanktg> Its the close button. I didn't add any CSS and icon to it ;)
17:23:34 <aleth_web> I see.
17:23:34 <mayanktg> * disconnect button.
17:24:14 <aleth_web> You probably want a little 2-3px gap between the video and the message area.
17:25:15 <aleth_web> Maybe as a followup, it would be interesting to experiment with media tags to place the video. For example, if the window is wider than it is high, then the split might be better left/right rather than top/bottom.
17:26:12 <aleth_web> Hmm, I'm not sure about the "gap" idea, it might not look any better actually.
17:26:43 <aleth_web> What makes it look a bit wrong at the moment is the gap at the top between the conv-top border and the video.
17:27:34 <mayanktg> aleth_web: Yes You're right regarding the splitting when the width is wider.
17:29:05 <mayanktg> I didn't add any gap between the video and conv-top border. :-/ I'll inspect and fix it. :)
17:39:23 <-- mconley has quit (Input/output error)
17:39:58 --> mconley has joined #instantbird
17:42:43 <-- rosonline has quit (Ping timeout)
17:43:43 --> rosonline has joined #instantbird
17:44:06 <-- mayanktg has quit (Client exited)
17:44:56 --> mpmc has joined #instantbird
17:51:25 --> mayanktg has joined #instantbird
17:54:05 --> Rym has joined #instantbird
17:55:04 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:59:19 * Fallen|away is now known as Fallen
18:00:22 <-- jb has quit (Ping timeout)
18:02:04 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:15:06 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:29:33 <-- rosonline has quit (Ping timeout)
18:30:25 --> rosonline has joined #instantbird
18:31:24 <aleth_web> nhnt11: any progress on that test failure?
18:36:13 <mayanktg> aleth_web: Thanks for the review. I'll fix the changes you've mentioned tonight. :)
18:38:18 <aleth_web> mayanktg: For an example of how to make CSS rules dependent on the presence of an attribute, http://mxr.mozilla.org/comm-central/source/im/themes/conversation.css#145
18:39:48 <mayanktg> aleth_web: Ok. And I also forgot to mention, how to add the notification change (blue color text in the tab) when a notification bar appears?
18:40:34 <nhnt11> aleth_web: getting on it now
18:40:36 <aleth_web> mayanktg: Leave that for a followup, and file it so you don't forget it.
18:40:58 <aleth_web> i.e. file a bug for it.
18:41:13 <mayanktg> Okays. I should file separate bugs for each of the followups right?
18:41:18 <aleth_web> Yes
18:41:40 <mayanktg> ok. :)
18:41:55 <aleth_web> Then you won't have any more huge patches after this one, hopefully ;)
18:45:01 <nhnt11> hmm qheaden is gone
18:45:14 * nhnt11 should have tried to quickly give him a patch that would give me debug info
18:45:40 <nhnt11> I'll just push to try again I guess.
18:46:06 <nhnt11> Hmm actually looking at this log output...
18:46:11 * nhnt11 shuts up till he makes up his mind
18:47:29 <aleth_web> mayanktg: https://developer.mozilla.org/en-US/docs/Web/CSS/calc
18:50:09 <instantbot> New Chat Core - XMPP bug 1027767 filed by mayanktg@gmail.com.
18:50:11 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1027767 nor, --, ---, mayanktg, NEW, Add notification when a video call is requested and user is not on the tab.
18:51:17 <mayanktg> aleth_web: Yup. :) I'm adding more followup bugs now.
18:52:18 --> gerard-majax__ has joined #instantbird
19:00:28 <instantbot> New Chat Core - XMPP bug 1027771 filed by mayanktg@gmail.com.
19:00:29 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1027771 nor, --, ---, mayanktg, NEW, Add fullscreen video call support.
19:03:23 <nhnt11> Uh
19:03:26 <nhnt11> This is interesting
19:03:29 <nhnt11> [test_queueFileOperation : 188] {} == {}
19:03:33 <nhnt11> Seems like it's comparing empty objects
19:04:05 <nhnt11> I'm not sure if it's expected that they're empty object,s but I'm now suspicious that equal(a, b) is not the same as ok(a == b)
19:04:32 <mayanktg> aleth_web: Bug 954004 . There's already a bug filed by clokep to add video/audio support!
19:04:34 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=954004 nor, --, ---, nobody, NEW, Audio/Video Support
19:05:11 <nhnt11> mayanktg: If you've already posted stuff on another bug, mark clokep's as a duplicate
19:05:52 <nhnt11> mayanktg: Or you can use that as a tracking bug since it seems generic
19:06:04 <nhnt11> (and yours specifically mentions XMPP/Jingle)
19:06:08 <nhnt11> aleth_web: ^
19:06:10 * nhnt11 shuts up
19:06:49 * nhnt11 is confused about this linux error
19:09:00 <-- gerard-majax__ has quit (Ping timeout)
19:09:07 <instantbot> New Chat Core - XMPP bug 1027777 filed by mayanktg@gmail.com.
19:09:08 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1027777 nor, --, ---, mayanktg, NEW, Add mute/hold support for audio/video call.
19:10:02 <nhnt11> aleth_web: I'm going to push a modification to try that will give me quite a bit of debug info
19:10:13 <nhnt11> I'll include the modification as a patch right under the try chooser one
19:10:21 <nhnt11> That sound fine? Can I use try for stuff like that?
19:10:32 * nhnt11 is a bit paranoid after sawrubh said it's >$30 per try build
19:11:19 <instantbot> New Chat Core - XMPP bug 1027778 filed by mayanktg@gmail.com.
19:11:20 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1027778 nor, --, ---, mayanktg, NEW, Audio call support in XMPP
19:17:54 <instantbot> New Chat Core - XMPP bug 1027779 filed by mayanktg@gmail.com.
19:17:55 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1027779 nor, --, ---, mayanktg, NEW, Inability to send call request if no messages have been exchanged before.
19:30:55 <instantbot> New Chat Core - XMPP bug 1027788 filed by mayanktg@gmail.com.
19:30:56 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1027788 nor, --, ---, mayanktg, NEW, Better interface of video/audio calls for wider window.
19:31:00 <nhnt11> Bah!
19:31:22 <nhnt11> There's a random "let dirPath = OS.Path" line in queueFileOperation since Patch v11
19:31:35 <nhnt11> (It's not likely causing the test failures, but :( )
19:39:43 <-- Rym has quit (Ping timeout)
19:41:26 <-- rosonline has quit (Ping timeout)
19:41:45 --> Rym has joined #instantbird
19:43:18 --> rosonline has joined #instantbird
19:44:25 <-- Rym has quit (Ping timeout)
19:45:32 --> flo-retina has joined #instantbird
19:45:32 * ChanServ sets mode +qo flo-retina flo-retina 
19:51:33 --> jb has joined #instantbird
20:00:26 <flo-retina> nhnt11: yes, it's fine to use try to get more info about a test failure. That's exactly what it's here for.
20:00:42 <flo-retina> nhnt11: limit the build to only linux :)
20:00:48 <nhnt11> of course :)
20:00:56 <nhnt11> btw, I just found a /massive/ bug
20:01:02 <nhnt11> well, possible bug
20:01:09 <nhnt11> It may be OS dependent ;)
20:01:35 <flo-retina> nhnt11: and I think the $$ amount that was discussed before is for a mozilla central job. See how many jobs are triggerred for each push: https://tbpl.mozilla.org/
20:02:07 <nhnt11> oh wow.
20:02:20 <nhnt11> Hmm, no, possibly /not/ a bug after all
20:02:23 <nhnt11> I misread some output....
20:03:17 <flo-retina> the {} == {} in the log could either be that you are not checking much; or that the toString() function doesn't give useful output for some objects
20:03:48 <nhnt11> flo-retina: According to documentation, equal(foo, bar) is equivalent to ok(foo == bar)
20:04:00 <nhnt11> in which case, I /am/ checking something
20:04:05 <nhnt11> something useful*
20:04:37 <nhnt11> actually the documentation is more specific, it says "The equality assertion tests shallow, coercive equality with ==."
20:04:52 <nhnt11> Maybe it's just printing it that way and toString() doesn't say much for a resolved promise :)
20:05:26 * flo-retina wonders what "arrived at fedex location" means on https://www.fedex.com/fedextrack/?tracknumbers=770303619810
20:06:15 <nhnt11> Maybe their warehouse?
20:07:01 <flo-retina> nhnt11: there was the same line with the same location yesterday at 11:55pm
20:07:01 <nhnt11> It has two entries for that on consecutive days :S
20:07:08 <nhnt11> just saw that, yeah
20:08:59 <nhnt11> Very interesting
20:09:02 <flo-retina> I would like to know if I should stay at home tomorrow
20:09:15 * flo-retina assumes it isn't fedex that's very interesting :-D
20:09:21 <nhnt11> In my test, I yield on the promise for the path of a log, before moving on to writing hte next log
20:09:40 <nhnt11> It seems that's not working properly :S
20:10:50 <nhnt11> I'm not entirely sure why it isn't
20:11:24 <-- jb has quit (Ping timeout)
20:12:59 <nhnt11> I have a hunch...
20:20:57 --> EionRobb has joined #instantbird
20:22:49 <nhnt11> Aaaaah
20:24:37 <nhnt11> I was yielding on the queued promise, which at the time, was only the initialization header
20:24:55 <nhnt11> Because all of the log message promises were queued only after that completed
20:25:13 <nhnt11> the fix is to yield on logWriter._initialized before logging any messages
20:25:40 <nhnt11> rather, after all the logMessage calls
20:25:57 <nhnt11> I don't like this at all
20:26:35 <nhnt11> The _initialized thing should also go in the queue. Or we need to do smoehting like... (wait for pastebin)
20:28:20 <nhnt11> actually, don't wait for pastebin :]
20:28:24 * nhnt11 is rewriting some stuff
20:33:36 <nhnt11> No, never mind, I'm not going to touch logger.js
20:33:43 * nhnt11 thinks about how he can fix this from the code...
20:35:28 <nhnt11> from the test code*
20:43:20 <nhnt11> flo-retina, aleth_web: I have a hunch I've fixed the issue, I'm going to push the fix to try. I'm going to run it on all OSes, I'm surprised any of them passed. The bug means it's uncertain later in the code that the log files have been written completely, but still may not fix the linux issue so I'm going to include a debug patch as well.
20:43:49 <nhnt11> I think I'll upload a patch to the bug right now as well, if more changes need to be done I can always attach another one
20:45:11 <nhnt11> There's a huge chance it /will/ fix the linux bug though, as it could be because the second log file is read before the first one is fully written.
20:57:07 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
21:03:54 --> mpmc has joined #instantbird
21:05:04 --> Rym has joined #instantbird
21:09:00 <flo-retina> ah, that says "Departed FedEx location" now
21:10:40 <nhnt11> flo-retina: FYI, carrying forward the r+ for removing line 60 in the new file: https://bugzilla.mozilla.org/attachment.cgi?id=8441785&action=diff#a/chat/components/src/logger.js_sec2
21:11:21 <flo-retina> nhnt11: let's discuss review flags once you have a fully working fix&test :)
21:11:29 <nhnt11> flo-retina: That's not a fix for the test
21:11:47 <nhnt11> That just removes a useless line that crept up in patch v11
21:11:55 <nhnt11> but fine
21:12:00 <flo-retina> but sure, remove that line :)
21:12:04 <nhnt11> I can wait for the test results :)
21:12:07 <nhnt11> uh
21:12:08 <nhnt11> heh
21:15:16 --> chrisccoulson has joined #instantbird
21:18:58 <-- aleth_web has quit (Quit: Connection closed for inactivity)
21:35:40 <nhnt11> flo-retina: Now that I know more about views and triggers, I need to ask what you meant here: http://log.bezut.info/instantbird/yesterday/#m461
21:36:28 <nhnt11> Did you mean create a view that will automatically give me the text, path and filename without doing two lookups?
21:37:29 <nhnt11> Oh
21:37:42 <nhnt11> Did you mean insert directly into the view, and have a trigger do the two separate inserts?
21:38:19 <flo-retina> yes
21:38:32 <nhnt11> Cool, I think I understood
21:38:34 <nhnt11> INSTEAD OF :)
21:38:35 <flo-retina> it's easy when you do the questions and the answers :)
21:39:07 * nhnt11 has been doing some reading and wanted to make sure he was on the right track
21:39:21 <nhnt11> Thanks for pointing me, btw
21:39:46 * nhnt11 should try and take a few courses next year on databases and other CS stuff
21:39:56 <nhnt11> maybe audit them at least...
21:39:59 <nhnt11> anyway, offtopic
21:40:31 <flo-retina> no problem, we are here for that (pointing you all in the right directions) :)
21:41:35 * EionRobb points at nhnt11
21:42:13 * nhnt11 wonders for whom his direction is the right one :P
21:42:44 <flo-retina> EionRobb: thanks, nhnt11 needed some pointing at :-P.
21:50:19 <-- Rym has quit (Ping timeout)
21:53:27 --> Rym has joined #instantbird
21:55:04 <-- arlolra has quit (Connection reset by peer)
21:55:07 --> arlolra has joined #instantbird
22:02:37 <flo-retina> nhnt11: could you please help mayanktg to fix the Mac theming on bug 975542?
22:02:40 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=975542 enh, --, ---, mayanktg, NEW, Set user icon from image taken with the webcam.
22:02:46 <nhnt11> Ah, right...
22:03:39 <mayanktg> :)
22:03:53 <flo-retina> I gave him a solution to avoid the large margins and avoid the negative margins... but with the newer changes it looks all broken again
22:05:05 <mayanktg> It didn't work for the Mac? The solution you gave me worked correctly in case of Linux. :-o
22:05:34 <flo-retina> mayanktg: my solution worked, thanks :-P.
22:05:39 <flo-retina> mayanktg: but your other changes made a mess
22:06:17 * mayanktg :-|
22:07:37 <flo-retina> mayanktg: http://i.imgur.com/EpCi3it.png http://i.imgur.com/rjUKGM2.png
22:17:35 <mayanktg> flo-retina: Wait..I'll try to look what might be causing the error.
22:19:10 <nhnt11> :S
22:19:10 <nhnt11> https://tbpl.mozilla.org/php/getParsedLog.php?id=42086433&tree=Thunderbird-Try
22:20:05 * nhnt11 really hopes that's not his fault
22:20:14 <flo-retina> doesn't look like it
22:20:16 <nhnt11> Yeah
22:20:20 <nhnt11> Didn't mess with gloda /that/ much
22:20:24 <-- Rym has quit (Ping timeout)
22:20:42 <flo-retina> it's not gloda
22:20:48 <nhnt11> Looks like I'm not going to find out the test_logger issue tonight...
22:20:51 <flo-retina> ask in #maildev? :)
22:21:12 <nhnt11> What do I ask? If it's known bustage?
22:21:20 --> Rym has joined #instantbird
22:21:31 <flo-retina> yes
22:27:24 <nhnt11> mayanktg: Can I build your patch without the flag?
22:27:55 <nhnt11> I mean, is there something trivial I can do to enable the take picture button
22:28:11 <nhnt11> (Even if I can't see a webcam preview)
22:28:24 <mayanktg> nhnt11: Yes. You only need to touch the css part. You can do that without enabling the camera. 
22:28:28 * nhnt11 searches..
22:29:05 <mayanktg> Ahh..You can remove the getUserMediadevices()
22:29:14 <mayanktg> ...
22:30:00 <mayanktg> or better remove the disabled attribute from the take picture button
22:30:05 <nhnt11> Cool.
22:30:42 <nhnt11> mayanktg: I'm going to be afk for a minute, can you please remove the attribute or whatever and send me a diff? :)
22:30:55 <mayanktg> Yep. I was doing that. :)
22:32:32 <flo-retina> mayanktg: what's <hbox id="takePictureButtons"> for?
22:33:45 <mayanktg> They put the capture picture buttons in the hbox
22:33:49 <flo-retina> errr, it's the vbox around it that doesn't seem needed actually
22:34:28 <mayanktg> Its needed..<vbox id="userIconButtonBox"> is used in case of both panel 2-3.
22:34:30 <mayanktg> ...
22:35:07 <flo-retina> what does that mean?
22:35:46 <flo-retina> if you have <vbox><hbox> [some stuff here] </hbox></vbox> there's something strange/wrong. You either want an hbox or a vbox, not both.
22:36:00 <-- Rym has quit (Ping timeout)
22:36:02 <mayanktg> for assigning margins and setting the position..pfff :-S
22:36:50 <mayanktg> Its the usericonButtonBox that's causing the buttons in panel 2-3 to have weird bottom margins
22:36:57 <mayanktg> nhnt11: http://pastebin.instantbird.com/738601
22:37:20 <flo-retina> so if it's causing styling issues, why do you have it? :-S
22:37:25 --> Rym has joined #instantbird
22:38:35 <nhnt11> re
22:38:46 <mayanktg> It wasn't causing style issues in mine. Yesterday I put the button sets into separate boxes to set the margins. But after your fix they weren't needed anymore :-|
22:40:30 <nhnt11> mayanktg: That's the only change? I could have done it myself, heh. Thanks though!
22:41:53 <mayanktg> nhnt11: Wait...
22:42:04 <-- mconley has quit (Input/output error)
22:42:53 <mayanktg> http://pastebin.instantbird.com/738604 remove these too
22:42:59 <flo-retina> mayanktg: "But after your fix they weren't needed anymore" would have been easier to start by saying that ;).
22:43:22 <flo-retina> anyway, your r- is ready.
22:43:38 <flo-retina> and it's at least the second time I look at that patch hoping it's ready to checkin, and find 'surprises' :(
22:46:51 <flo-retina> oh, and you had 3 vbox with the same id
22:46:58 <flo-retina> that should really cause warnings :-/
22:50:16 <mayanktg> flo-retina: I'm sorry. I'm fixing it up. :'( 
22:54:21 <-- Rym has quit (Ping timeout)
22:55:03 --> Rym has joined #instantbird
22:57:50 <nhnt11> mayanktg: What are .panel-arrowcontainer and .panel-arrowcontent?
22:57:55 <nhnt11> I don't see anything with those classes
22:59:25 <mayanktg> nhnt11: It was the fix given by flo-retina to fix the margin issues. It removes the padding from panel.
22:59:45 <flo-retina> nhnt11: use DOM Inspector, and look at the anonymous nodes
23:00:06 <nhnt11> flo-retina: alright, something in the panel element then, thanks
23:00:45 <-- Rym has quit (Ping timeout)
23:00:54 <flo-retina> I showed a screenshot of DOMi, didn't I?
23:01:22 <nhnt11> Yeah. I didn't look at it very closely.
23:01:57 <flo-retina> nhnt11: http://log.bezut.info/instantbird/140617/#m677
23:02:23 <nhnt11> Right, thanks
23:02:27 <flo-retina> the reason I gave that screenshots is so that you all can learn how I figure out these magic CSS rules ;)
23:08:20 <nhnt11> flo-retina: How did you get those highlights in that screenshot?
23:10:06 --> Rym has joined #instantbird
23:13:07 * Fallen is now known as Fallen|away
23:15:54 <nhnt11> Woohoo
23:16:06 <nhnt11> http://puu.sh/9Bigt/28ce85e0de.png
23:16:11 <nhnt11> flo-retina, mayanktg: Looks alright? ^ :)
23:17:16 <mayanktg> Yepp. Are the other panels fixed too? :)
23:17:22 <nhnt11> nearly, one sec...
23:18:53 <nhnt11> mayanktg: Please do not try to set widths in pixels on buttons like this in the future
23:19:01 <nhnt11> (where the buttons need to share the available space)
23:19:07 <flo-retina> nhnt11: is that bug becoming a tshirt contest? ;)
23:19:19 <nhnt11> Instead try using flex="1" on them (not necessarily in this case though)
23:19:20 <flo-retina> nhnt11: that screenshot looks reasonable, yes
23:19:21 <nhnt11> flo-retina: lol
23:19:33 <nhnt11> Actually possibly necessary in this case, nvm
23:19:38 <flo-retina> have you checked that the icons are in the correct state?
23:19:44 <flo-retina> I haven't seen the :active state on any of the buttons
23:19:54 <nhnt11> active isn't working
23:25:02 <mayanktg> nhnt11: Are the left and right buttons of panel 2-3 of equal width after putting flex?
23:25:15 <nhnt11> mayanktg: Weirdly, no.
23:25:34 <nhnt11> investigating that now
23:25:47 <nhnt11> They're not using up the available space either
23:26:36 --> clokep_work has joined #instantbird
23:26:36 * ChanServ sets mode +o clokep_work 
23:27:24 <mayanktg> Ok. Did you remove the vbox around the buttons flo mentioned about in the comment?
23:27:38 <nhnt11> There are no double boxes now, I have removed them.
23:27:50 <mayanktg> Ok.
23:29:24 <nhnt11> Gah, can't find the issue here: http://puu.sh/9Bjos/d5f4e99f12.png
23:29:46 <nhnt11> There's something occupying the space on the right :S
23:30:33 <nhnt11> mayanktg: What's the html:canvas element? id=userIconCanvas
23:30:41 <nhnt11> And what's the stack above it?
23:31:29 <nhnt11> bah, found the issue
23:31:40 <nhnt11> (I think)
23:33:01 <nhnt11> Indeed :)
23:33:15 <nhnt11> http://puu.sh/9BjHh/a798cf033c.png
23:33:21 <nhnt11> I have a theory about the remaining space...
23:33:51 <mayanktg> nhnt11: Thanks :) . What is it? :-o
23:35:38 <nhnt11> Never mind, it doesn't work :(
23:37:59 <mayanktg> Is it because 1px border-right has been set for the left icons in the panel 2-3?
23:38:44 <nhnt11> It's more than 1px
23:38:50 <nhnt11> (the gap i mean)
23:42:53 <nhnt11> mayanktg: What's the html:canvas element? id=userIconCanvas
23:42:59 <nhnt11> And what's the stack above it
23:43:08 <nhnt11> Also, why is the stack above it a stack? It has only one element in it
23:43:28 <nhnt11> I'm going to bed in a minute btw
23:43:45 <mayanktg> The canvas element is the one on which the image is captured.
23:44:29 * nhnt11 is confused
23:44:55 <nhnt11> mayanktg: What about the stack above it?
23:45:00 <nhnt11> Why is that a stack?
23:45:47 <-- arlolra has quit (Quit: arlolra)
23:45:48 <mayanktg> Wait...The video was overlapping over the canvas. That's why I used it. Wait let me check.
23:46:04 <nhnt11> http://puu.sh/9BkHf/5b63f24904.png :)
23:46:10 <nhnt11> Changing that stack to a box did the trick
23:47:29 <mayanktg> Ok..Thank you so much :)
23:48:12 <mayanktg> Why was then stack behaving differently in case of Linux and Mac :S
23:48:18 <nhnt11> mayanktg: I really need to sleep. I'll send you a diff of what I have so far
23:48:29 <nhnt11> It's not "clean"
23:48:39 <mayanktg> Yeah. Sure..You already helped me so much.
23:48:44 <nhnt11> The gist of what I did was set 0 paddings and margins on everything, and add flexes to the buttons
23:48:57 <mayanktg> Ok.
23:49:07 <nhnt11> Please go through the diff and try to figure out the general approach
23:49:13 <nhnt11> from there you should be able to make it "clean"
23:49:28 <nhnt11> (for example, use one selector to set 0 margins and paddings on all of the things that require that)
23:50:20 <nhnt11> http://pastebin.instantbird.com/738637
23:50:22 <nhnt11> mayanktg: ^
23:51:04 <nhnt11> You may need to repeat what I've done with the back/capture buttons for the retake/seticon buttons
23:51:07 <nhnt11> I didn't have access to them
23:51:07 <mayanktg> Yepp.. :)
23:51:24 <nhnt11> I can try to clean it up a bit when I wake up
23:51:39 <nhnt11> All of the max-* min-* stuff is probably unnecessary btw
23:52:00 <nhnt11> This also takes care of retina display stuff (since all the sizes are pretty much dynamic)
23:52:30 <nhnt11> mayanktg: In addition, if you want something to be centered and have a size fooxbar, the way to go about that is not to measure the size of the container and set constant margins
23:52:37 <nhnt11> because the panel size may be different on different OSes
23:52:43 <nhnt11> What you should do is center it dynamically
23:53:23 <nhnt11> What I would do is get rid of paddings and margins completely everywhere except the containers (vboxes, hboxes, stacks, panel, so on)
23:53:38 <nhnt11> And where I want the 160x160 thing, set it to 160x160 and add spacers around it that flex ;)
23:53:38 <mayanktg> Yeah. You're right. I was unaware of how CSS works on Mac. That's why it caused those problems :-/
23:53:49 <nhnt11> CSS works the same way on all platforms.
23:54:38 <nhnt11> mayanktg: If I didn't have to sleep, i would clean it up and make it "properly" center stuff for you
23:54:43 <nhnt11> If you can wait till tomorrow, I'll do it then
23:54:48 <nhnt11> I will likely have some time in the afternoon
23:54:49 <nhnt11> Good night.
23:55:15 <mayanktg> nhnt11: I'll try to do it from here on. Thanks. Goodnight :)