All times are UTC.
00:04:34 --> BWMerlin has joined #instantbird 00:53:26 <-- Rym has quit (Ping timeout) 01:00:00 --> Rym has joined #instantbird 01:22:43 <-- Rym has quit (Ping timeout) 01:23:58 --> Rym has joined #instantbird 01:42:12 <-- Armada has quit (Connection reset by peer) 01:48:13 <-- mconley has quit (Input/output error) 01:53:39 <-- Rym has quit (Ping timeout) 01:53:57 --> Rym has joined #instantbird 02:18:42 --> mconley has joined #instantbird 02:24:53 <-- mconley has quit (Ping timeout) 02:33:40 <-- Rym has quit (Ping timeout) 03:06:31 --> Rym has joined #instantbird 03:28:17 <instant-buildbot> build #2124 of macosx-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2124 03:34:26 --> mconley has joined #instantbird 03:47:21 <-- mconley has quit (Input/output error) 03:52:55 <instant-buildbot> build #1344 of win32-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1344 03:55:21 <-- Rym has quit (Ping timeout) 04:17:52 --> mconley has joined #instantbird 04:18:11 <-- mconley has quit (Connection reset by peer) 04:18:24 --> mconley has joined #instantbird 04:23:54 <-- mconley has quit (Ping timeout) 04:36:05 --> mconley has joined #instantbird 04:48:48 <-- mconley has quit (Input/output error) 04:56:53 --> mconley has joined #instantbird 05:10:43 <-- nhnt11 has quit (Ping timeout) 05:37:43 <-- mconley has quit (Input/output error) 06:03:16 --> nhnt11 has joined #instantbird 06:07:30 <-- nhnt11 has quit (Ping timeout) 06:14:44 --> nhnt11 has joined #instantbird 06:15:09 <-- Fallen|away has quit (Ping timeout) 06:19:19 --> Fallen|away has joined #instantbird 06:27:00 --> mconley has joined #instantbird 06:44:06 --> Mook has joined #instantbird 06:47:05 <-- EionRobb has quit (Ping timeout) 06:50:19 --> EionRobb has joined #instantbird 06:52:00 <-- EionRobb has quit (Ping timeout) 07:00:00 --> EionRobb has joined #instantbird 07:02:17 <-- nhnt11 has quit (Ping timeout) 07:04:19 <-- EionRobb has quit (Ping timeout) 07:07:16 --> EionRobb has joined #instantbird 07:10:23 --> nhnt11 has joined #instantbird 07:23:23 <-- EionRobb has quit (Ping timeout) 07:24:29 --> EionRobb has joined #instantbird 07:41:37 <-- nhnt11 has quit (Ping timeout) 07:43:57 <-- mconley has quit (Input/output error) 07:50:58 --> Rym has joined #instantbird 07:54:53 <-- Mook has quit (Quit: Mook) 08:15:26 --> iamjayakumars has joined #instantbird 08:19:08 <-- iamjayakumars has quit (Ping timeout) 08:42:00 --> iamjayakumars has joined #instantbird 09:04:51 <-- iamjayakumars has quit (Client exited) 09:08:18 --> nhnt11 has joined #instantbird 09:10:00 <-- nhnt11 has quit (Ping timeout) 09:12:18 --> nhnt11 has joined #instantbird 09:14:19 --> mconley has joined #instantbird 09:19:38 <-- mconley has quit (Ping timeout) 09:21:58 --> iamjayakumars has joined #instantbird 09:25:18 <-- iamjayakumars has quit (Client exited) 09:28:58 --> iamjayakumars has joined #instantbird 09:37:50 <-- Rym has quit (Ping timeout) 09:47:41 <-- mayanktg has quit (Ping timeout) 09:48:21 --> mayanktg has joined #instantbird 10:09:41 --> Mic has joined #instantbird 10:09:41 * ChanServ sets mode +o Mic 10:19:07 <-- nhnt11 has quit (Ping timeout) 10:24:38 <-- iamjayakumars has quit (Ping timeout) 10:28:40 --> nhnt11 has joined #instantbird 10:31:24 <-- nhnt11 has quit (Ping timeout) 10:43:04 <Mic> clokep: I tried to add you on the Facebook page yesterday already but it didn't work. I'll look into this later. 10:43:37 <Mic> Has someone advertised the Instantbird Facebook page? I'm seeing a lot new "Likes"... 10:43:40 --> nhnt11 has joined #instantbird 10:49:29 --> flo-retina has joined #instantbird 10:49:29 * ChanServ sets mode +qo flo-retina flo-retina 10:50:08 <flo-retina> the "Re: [Pidgin] BuildingWinPidgin/3.0.0 modified" thread on devel@pidgin is ... hmm.. surprising. It seems they are recommending to make Windows builds on Unix machines as a preferred build environment 10:53:28 <-- EionRobb has quit (Quit: Leaving.) 10:57:05 <mayanktg> Mic: I sent the invites 11:00:43 <-- nhnt11 has quit (Ping timeout) 11:02:38 --> nhnt11 has joined #instantbird 11:08:30 <-- nhnt11 has quit (Ping timeout) 11:08:42 --> nhnt11 has joined #instantbird 11:11:10 <flo-retina> clokep: I read your fileline pad and typed a few things in it 11:13:55 <-- nhnt11 has quit (Ping timeout) 11:40:48 <-- Mic has quit (Ping timeout) 11:53:05 --> nhnt11 has joined #instantbird 11:59:28 <-- nhnt11 has quit (Ping timeout) 12:00:28 --> Rym has joined #instantbird 12:00:36 <-- BWMerlin has quit (Quit: BWMerlin) 12:04:08 --> Mic has joined #instantbird 12:04:08 * ChanServ sets mode +o Mic 12:36:54 --> clokep has joined #instantbird 12:36:54 * ChanServ sets mode +o clokep 12:38:51 --> mpmc has joined #instantbird 12:46:00 <clokep> flo-retina: I found that recommendation very surprising too. (Re the Pidgin thread) 12:47:05 <clokep> flo-retina: "Is the work to add a generic way to add buttons to the conversation area part of the File Transfer, or WebRTC project?" I didn't realize we wanted a way to do that...? 12:57:21 <-- mpmc has quit (Ping timeout) 13:02:26 --> aleth has joined #instantbird 13:02:26 * ChanServ sets mode +o aleth 13:03:09 --> mpmc has joined #instantbird 13:03:34 <flo-retina> clokep: both these projects need a way to add a button in the conversation binding 13:03:54 <flo-retina> adding one or two buttons there is almost the same amount of work 13:06:08 --> nhnt11 has joined #instantbird 13:06:14 <aleth> Whoever needs it first gets to do it? ;) 13:06:35 <flo-retina> I'm tempted to throw it in the webrtc project's direction 13:06:46 <flo-retina> because figuring out the UI is key for that project 13:07:05 <flo-retina> whereas for the filetransfer project, it's "just a detail" among plenty of other stuff 13:07:07 <aleth> And it'll be needed almost immediately. 13:07:17 <aleth> Makes sense. 13:07:56 <flo-retina> I would almost have suggested making it a community bounding project for the webrtc project, if only I could think of another _good_ reason to add a button in the conv UI 13:08:41 <-- nhnt11 has quit (Ping timeout) 13:10:15 * clokep can't get his tests to be added. 13:10:16 --> nhnt11 has joined #instantbird 13:14:09 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 13:16:23 <clokep> Am I missing a place to add the test? http://pastebin.instantbird.com/685224 What do I do to run it? |mozmake -C obj-i686-pc-mingw32/ xpcshell-tests TEST_PATH=chat/modules/| is what I'm running now. 13:17:28 <flo-retina> you may need to ./mozilla/mach build for the xpcshell.ini change to take effect 13:18:24 <clokep> I did a build on the directly, do I need a full rebuild? (o_O) 13:24:05 <flo-retina> well, I would think that you don't need a full rebuild, but that you need a rebuild in some other folders, and that figuring out which ones would take longer than a full no-op build (which takes <1 minute if you are doing this on your macbook) 13:24:56 <clokep> Yeah just started one. 13:28:15 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 13:31:04 <-- nhnt11 has quit (Ping timeout) 13:32:05 <clokep> aleth: So that code didn't work in the constructor, the tests fail. :( 13:32:15 <aleth> clokep: Pastebin? 13:32:26 <aleth> Or is it the one above? 13:32:28 <flo-retina> so at least the tests _run_ \o/ 13:32:30 <clokep> aleth: the one I just pasted... http://pastebin.instantbird.com/685224 13:32:36 <clokep> flo-retina: Yes. :) 13:32:49 <clokep> I need to go o make a presentation for work in a few minutes though. 13:32:55 <aleth> clokep: Drop the ... in front of aArgs in the function definition 13:33:19 <clokep> Ah. 13:33:24 <clokep> Details. ;) 13:33:25 <aleth> In test_constructor, add a .toString() 13:33:36 <clokep> I don't believe that's a correct change. 13:33:37 <aleth> Ditto in test_iterator 13:34:06 <aleth> You can investigate and see what the type of str is? 13:34:30 <aleth> The k._map in line 102 is definitely not wanted. 13:35:38 <clokep> Yes. 13:39:35 <clokep> Most of it passes now. :) 13:39:54 <aleth> :) 13:44:33 --> nhnt11 has joined #instantbird 13:51:23 <clokep> aleth: Unfortunately I think it isn't a bug. :-\ 13:52:03 <aleth> I suspect it isn't as well, but I thought it might at least clear things up ;) 13:52:06 * clokep feels like his test file isn't updating when he runs separate tests. 13:52:25 <clokep> Anyone remember how to print things out in xpcshell? 13:52:31 <clokep> Is it dump? print? echo? something less fun? 13:52:45 <aleth> do_print 13:52:51 <-- Rym has quit (Ping timeout) 13:55:49 <clokep> Thanks. 14:00:20 <-- nhnt11 has quit (Ping timeout) 14:02:00 --> sonny has joined #instantbird 14:04:43 <-- mayanktg has quit (Ping timeout) 14:06:40 --> iamjayakumars has joined #instantbird 14:08:43 <clokep> \o/ 14:10:19 <clokep> flo-retina: Thanks for looking over that plan for sawrubh and I. It seems pretty reasonable overall? 14:10:31 * clokep likes having many eye slook over these things. 14:10:45 <flo-retina> yes :) 14:10:49 <flo-retina> np 14:10:54 <flo-retina> sorry I didn't get to it sooner 14:11:08 <clokep> Not a big deal. :) 14:11:13 <clokep> I think he's still doing tests so... ;) 14:12:07 <-- iamjayakumars has quit (Ping timeout) 14:15:48 --> iamjayakumars has joined #instantbird 14:28:24 <-- sonny has quit (Ping timeout) 14:31:56 --> sonny has joined #instantbird 14:32:30 <clokep> Bah you can't just use do_check_eq on arrays, can you? 14:42:28 --> Rym has joined #instantbird 14:42:49 --> Armada has joined #instantbird 14:46:20 <aleth> clokep: That worked much better than asking on #js! ;) 14:49:08 <clokep> aleth: Ah, a new bug to CC ourselves to! :) 14:49:13 <flo-retina> clokep: I guess you could JSON.stringify both? 14:49:19 <flo-retina> or .toSource() both? 14:50:02 <clokep> Yeah, I'm just checking the two indices separately right now. 14:51:11 <flo-retina> aleth: what was "that"? 14:51:29 <aleth> flo-retina: bug 1002010 14:51:33 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1002010 nor, --, ---, nobody, RESO DUPLICATE, Subclassing Map fails 14:52:19 <flo-retina> thanks 14:52:42 <clokep> aleth: http://pastebin.instantbird.com/685357 is what I ended up with. :) 14:53:53 <aleth> You didn't need the toString? cool! 14:54:09 <aleth> I didn't have a good explanation for it. 14:54:18 <clokep> No it was from other issues. 14:54:23 <clokep> I did have to add the || [] though 14:54:30 <clokep> In case aIt is undefined. 14:55:44 <aleth> Makes sense. Though I'd probably prefer it in the definiton (i.e. NormalizedMap(..., aIterator = []) 14:56:24 <aleth> Wouldn't it be safer to make it fail if no normalizeFunction is passed in? 14:57:25 <aleth> Btw aIt is kind of short, is that because of an 80 char limit somewhere ;) 14:57:56 <clokep> It is. :-D 14:58:09 <clokep> aleth: You're right, putting it there is way cleaner. 14:58:19 <aleth> And you save some characters that way too ;) 14:59:18 <clokep> aleth: So throw if aNormalizeFunc isn't callable? 14:59:19 <aleth> nit: s/aNormalizeFuncName/aNormalizeFunction 14:59:55 <aleth> clokep: Is that possible? I was just thinking of throwing if it's undefined 14:59:57 <clokep> Yes, changed that already! :) 15:01:37 <clokep> aleth: typeof == 'unfciton'? 15:02:19 <aleth> I guess that would work. I thought functions were objects ;) 15:02:51 <aleth> But I wasn't really thinking. 15:04:24 <aleth> typeof(new function) == object. 15:05:17 <clokep> Why "new"? 15:06:02 <aleth> I meant that functions aren't objects, but new x returns an object when x is a function. 15:06:30 <clokep> OK. 15:06:37 <clokep> I'm unsure how that relates to our conversation. :-\ 15:07:00 <aleth> I was just deconfusing myself. typeof == function should work :) 15:07:10 <clokep> Ah! OK. :) 15:24:28 <-- iamjayakumars has quit (Quit: ) 15:52:53 <-- aleth has quit (Ping timeout) 16:02:44 --> aleth has joined #instantbird 16:02:44 * ChanServ sets mode +o aleth 16:10:24 <clokep> aleth: So if I pass a function into NormalizedMap constructor which uses "this" in it, what's the context that "this" gets evaluated in? 16:10:49 <clokep> E.g. If I pass in this.normalizeNick. 16:10:51 <aleth> The normalizedmap instance? 16:10:55 <clokep> Yes. 16:11:10 <clokep> I have an error where it's trying to use "normalize" on the NormalizedMap instance. 16:11:10 <aleth> So you need .bind(this) as usual I guess. 16:11:28 <clokep> Right, I know that's the solution. I'm wondering if it is expected, I guess? 16:11:40 <aleth> I think it's expected. 16:11:56 <aleth> The usual thing when passing functions as arguments... 16:12:19 <clokep> true. 16:12:54 <aleth> You can cheat with nick => this.normalize(nick) of course... 16:13:19 <clokep> That's not really any simpler. ;) 16:13:27 <aleth> No :D 16:13:44 <aleth> Whatever is easier to read... 16:13:59 <clokep> If I was defining the function there it'd make sense to do that though. :) 16:17:09 <clokep> :) Got everything working again, cool. 16:17:20 <aleth> Nice :) 16:32:32 <-- aleth has quit (Ping timeout) 16:36:27 --> aleth has joined #instantbird 16:36:27 * ChanServ sets mode +o aleth 16:48:43 --> jb has joined #instantbird 17:00:17 --> nhnt11 has joined #instantbird 17:02:05 <-- jb has quit (Ping timeout) 17:25:52 --> AlexanderSalas has joined #instantbird 17:28:12 <sawrubh> :) 17:37:21 <clokep> http://clokep.blogspot.com/2014/04/extending-javascript-maps-or-other.html for anyone interested 17:39:03 <aleth> Nice summary. 17:39:13 <clokep> :) 17:39:14 <clokep> Thanks. 17:39:27 <clokep> Thanks for the help btw, I think we came out w/ a solution I'm mostly happy w/. 17:40:01 <aleth> I like that it now doesn't have weird differences in behaviour from Maps. 17:40:14 <clokep> :) I agree. 17:40:34 <aleth> I think it's good, and eventually if/when that bug gets fixed the semi-hacky parts will simply disappear. 17:40:43 <aleth> And none of the consumers need care. 17:42:16 <clokep> That's the hope. :) 17:42:29 <clokep> Also I won't mind using a Map in jsProtoHelper and overriding it for IRC then. 17:42:41 <aleth> Right! 17:43:09 <aleth> That's a good point. 17:49:30 <-- aleth has quit (Ping timeout) 17:50:43 --> aleth has joined #instantbird 17:50:44 * ChanServ sets mode +o aleth 17:51:26 <-- sonny has quit (Ping timeout) 17:52:42 --> sonny has joined #instantbird 17:58:54 --> mconley has joined #instantbird 18:00:26 --> chrisccoulson has joined #instantbird 18:04:59 <-- aleth has quit (Ping timeout) 18:06:35 --> aleth has joined #instantbird 18:06:35 * ChanServ sets mode +o aleth 18:11:04 <-- sonny has quit (Ping timeout) 18:11:14 --> sonny has joined #instantbird 18:14:41 <-- sonny has quit (Ping timeout) 18:15:11 --> sonny has joined #instantbird 18:16:51 <-- sonny has quit (Ping timeout) 18:36:45 <-- aleth has quit (Ping timeout) 18:54:37 --> Mic has joined #instantbird 18:54:37 * ChanServ sets mode +o Mic 19:52:13 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 20:08:48 --> mayanktg has joined #instantbird 20:12:54 --> jb has joined #instantbird 20:28:23 --> EionRobb has joined #instantbird 20:33:35 <-- Rym has quit (Ping timeout) 20:35:18 <-- mayanktg has quit (Ping timeout) 20:35:47 --> mayanktg has joined #instantbird 20:44:19 <-- AlexanderSalas has quit (Ping timeout) 20:47:31 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 21:02:37 <-- jb has quit (Ping timeout) 21:18:18 <-- dew has quit (Ping timeout) 21:19:28 --> dew has joined #instantbird 21:21:09 <-- dew has quit (Ping timeout) 21:22:27 --> dew has joined #instantbird 21:29:04 <clokep> EionRobb: You know the libpurple file transfer API well? Might want to point my GSoC student at you if he has any questions I can't answer there. :) 21:29:31 <EionRobb> sure 21:29:45 <EionRobb> protip: it's not very nice to work with :) 21:30:08 <clokep> That's not my problem. ;) 21:30:11 <EionRobb> lol 21:30:15 <clokep> But yeah we knew that already. 21:30:34 <EionRobb> I helped last years pidgin gsoc student who was working on jingle-ft 21:30:39 <EionRobb> what a nightmare :) 21:31:09 <clokep> Ah, well I guess we'll be on the otherside of the API? Since all we care about is integrating into it from a UI's point of view. 21:32:51 <EionRobb> oh right 21:33:05 <EionRobb> I don't have much to do with UI stuff... so that'll be fun :) 21:33:17 <EionRobb> so... IB's getting file transfer? :P 21:34:12 <clokep> Hopefully! :) sawrubh will be working on adding support for file transer with a fallback to "FileLink" (a Thunderbird feature that uses HTTP type sites, like Dropbox, to transfer files) 21:34:15 --> rcscott has joined #instantbird 21:34:19 <clokep> Since a lot of FT mechanisms just like don't work. 21:34:34 <EionRobb> :) 21:34:45 <EionRobb> wouldn't it be better to do the filelink stuff first though? 21:35:25 <clokep> EionRobb: We are. https://etherpad.mozilla.org/ib-filelink ;) 21:35:42 <EionRobb> ah, good 21:43:41 --> gerard-majax has joined #instantbird 21:44:20 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 21:54:12 --> Rym has joined #instantbird 22:05:25 <-- mconley has quit (Input/output error) 22:06:05 --> mconley has joined #instantbird 22:21:46 --> Mic has joined #instantbird 22:21:46 * ChanServ sets mode +o Mic 22:22:40 --> AlexanderSalas has joined #instantbird 22:29:33 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 22:51:22 --> sonny has joined #instantbird 23:00:37 * mconley is now known as mconley|food 23:09:37 <clokep> aleth: Any chance you can add a colon or something in front of your name on Bugzilla? 23:09:46 <clokep> Be easier to find you when adding reviews. :) 23:19:48 <-- sonny has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 23:29:38 * mconley|food is now known as mconley 23:34:22 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 23:34:38 --> clokep has joined #instantbird 23:34:38 * ChanServ sets mode +o clokep 23:35:10 <-- Armada has quit (Connection reset by peer)