All times are UTC.
00:01:19 <flo-retina> so http://hg.instantbird.org/instantbird/rev/6ae1107d9ab3 is where things get interesting ;) 00:01:51 <clokep_work> I don't even want to look at that... 00:14:52 <flo-retina> and http://hg.instantbird.org/instantbird/rev/a765888e56a9 is moving things the other way around 00:22:28 --> jb has joined #instantbird 00:22:49 <-- jb has quit (Input/output error) 00:23:44 --> jb has joined #instantbird 00:31:01 <clokep_work> (o_O) 00:31:08 <clokep_work> We take things from over there....and move them over there. 00:31:57 <-- mrphs has quit (Z:lined (dronebot)) 00:32:01 --> mrphs has joined #instantbird 00:34:12 <flo-retina> another failed commit message: https://bugzilla.instantbird.org/show_bug.cgi?id=77#c3 00:34:14 <instantbot> Bug 77 min, --, 0.1.3, romain, RESO FIXED, Double-click on Disconnect opens acount properties 00:39:04 <clokep_work> Are you tracking these in the etherpad or something? 00:42:18 <flo-retina> I'm tracking them in instantbot's log ;) 00:43:07 <-- clokep_work has quit (Ping timeout) 00:48:11 <-- jb has quit (Ping timeout) 00:50:52 <flo-retina> I think I'll use a slicemap to get rid of these annoying revisions where we move everything around to/from that mozilla/ directory 00:56:58 <flo-retina> clokep: I've put vague reminders of the stuff I need to look at tomorrow at the end of the pad. 00:57:05 <flo-retina> Going to bed now. 01:21:00 --> clokep has joined #instantbird 01:21:01 * ChanServ sets mode +o clokep 01:40:23 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died) 01:54:49 --> chrisccoulson has joined #instantbird 02:00:43 <-- Mook_as has quit (Quit: Mook_as) 02:59:57 <-- wnayes has quit (Ping timeout) 03:03:31 --> wnayes has joined #instantbird 03:06:52 <-- dew has quit (Ping timeout) 03:06:56 --> dew has joined #instantbird 03:13:43 <-- dew has quit (Ping timeout) 03:14:23 --> dew has joined #instantbird 03:15:36 --> Mook has joined #instantbird 03:21:12 <-- hadi has quit (Client exited) 03:26:13 <-- dew has quit (Ping timeout) 03:26:43 --> dew has joined #instantbird 03:41:11 <-- dew has quit (Ping timeout) 03:41:24 --> dew has joined #instantbird 04:03:30 <-- mrphs has quit (Z:lined (dronebot)) 04:10:41 --> gerard-majax_ has joined #instantbird 04:12:16 <-- dew has quit (Ping timeout) 04:12:21 --> dew has joined #instantbird 04:13:35 --> mrphs has joined #instantbird 04:19:01 --> mconley has joined #instantbird 04:21:10 <clokep> flo-retina: I got both things done. :) 04:21:23 <clokep> Not sure which you want to look at first, but doesn't really matter to me. 04:28:45 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 04:34:39 <-- EionRobb has quit (Quit: Leaving.) 04:56:48 <-- wnayes has quit (Quit: wnayes) 05:06:00 <-- dew has quit (Ping timeout) 05:07:29 --> dew has joined #instantbird 05:17:03 <-- dew has quit (Ping timeout) 05:18:21 <-- gerard-majax_ has quit (Ping timeout) 05:18:24 --> dew has joined #instantbird 05:28:06 <-- dew has quit (Ping timeout) 05:28:10 --> dew has joined #instantbird 05:31:36 <-- mconley has quit (Input/output error) 05:33:30 <-- dew has quit (Ping timeout) 05:33:32 <instant-buildbot> build #1602 of macosx-nightly-default is complete: Failure [4failed shell_3] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/1602 05:34:27 --> dew has joined #instantbird 05:50:36 <-- dew has quit (Ping timeout) 05:50:41 --> dew has joined #instantbird 05:54:42 <-- dew has quit (Connection reset by peer) 05:54:45 --> dew has joined #instantbird 05:58:29 <-- dew has quit (Connection reset by peer) 05:59:01 --> dew has joined #instantbird 06:02:18 <-- dew has quit (Ping timeout) 06:02:32 --> dew has joined #instantbird 06:09:40 --> FireFly_TB has joined #instantbird 06:10:10 <-- FireFly_TB has quit (Quit: FireFly_TB) 06:16:32 <-- dew has quit (Ping timeout) 06:16:51 --> dew has joined #instantbird 06:24:08 <-- dew has quit (Ping timeout) 06:24:39 --> dew has joined #instantbird 06:29:10 <-- dew has quit (Ping timeout) 06:30:18 --> dew has joined #instantbird 06:31:57 <-- dew has quit (Ping timeout) 06:32:00 --> gerard-majax__ has joined #instantbird 06:33:02 --> dew has joined #instantbird 06:34:17 --> EionRobb has joined #instantbird 06:39:13 <-- dew has quit (Ping timeout) 06:39:31 --> dew has joined #instantbird 06:44:04 <-- dew has quit (Ping timeout) 06:44:42 --> dew has joined #instantbird 06:47:26 <-- gerard-majax__ has quit (Ping timeout) 06:53:22 <-- dew has quit (Connection reset by peer) 06:53:26 --> dew has joined #instantbird 06:59:31 <-- dew has quit (Ping timeout) 07:00:18 --> dew has joined #instantbird 07:02:03 <-- dew has quit (Ping timeout) 07:02:27 --> dew has joined #instantbird 07:19:01 <-- dew has quit (Ping timeout) 07:19:13 --> dew has joined #instantbird 07:22:50 <-- Mook has quit (Quit: Mook) 07:47:11 <instant-buildbot> build #1226 of win32-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1226 07:52:27 --> mconley has joined #instantbird 07:59:56 <-- dew has quit (Ping timeout) 08:00:21 --> dew has joined #instantbird 08:10:14 --> BWMerlin has joined #instantbird 08:12:39 --> gerard-majax__ has joined #instantbird 08:23:41 <-- mconley has quit (Ping timeout) 08:31:18 --> mconley has joined #instantbird 08:33:09 <-- mconley has quit (Ping timeout) 08:37:55 <-- dew has quit (Ping timeout) 08:38:22 --> dew has joined #instantbird 08:41:35 --> ivan has joined #instantbird 08:48:44 --> mconley has joined #instantbird 09:03:07 <-- mconley has quit (Ping timeout) 09:19:47 --> mconley has joined #instantbird 09:23:03 <-- mconley has quit (Input/output error) 09:23:47 <-- EionRobb has quit (Quit: Leaving.) 09:24:22 <-- dew has quit (Ping timeout) 09:24:53 --> dew has joined #instantbird 09:36:07 <-- dew has quit (Ping timeout) 09:36:27 --> dew has joined #instantbird 09:50:59 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 10:00:03 <-- dew has quit (Ping timeout) 10:00:28 --> dew has joined #instantbird 10:12:37 --> Mic has joined #instantbird 10:17:40 <-- dew has quit (Ping timeout) 10:18:08 --> dew has joined #instantbird 10:53:47 --> flo-retina has joined #instantbird 10:53:47 * ChanServ sets mode +qo flo-retina flo-retina 11:23:39 --> clokep has joined #instantbird 11:23:39 * ChanServ sets mode +o clokep 11:26:47 <-- dew has quit (Connection reset by peer) 11:27:14 --> dew has joined #instantbird 11:41:57 <clokep> flo-retina: I hope what I did in https://bugzilla.mozilla.org/show_bug.cgi?id=956609 isn't too hard to follow...unfortunately it easiest for me to just copy all the review comments to a text file and comment in there. :( I really should have broken it up again by patch. 11:42:20 <flo-retina> clokep: that's ok :) 11:42:32 <flo-retina> actually, I've only read the bugmail, not looked at the new patches yet 11:42:40 <flo-retina> I figured the chat/ merge was higher priority 11:42:58 <clokep> I hope I didn't mess up and like attach a bug twice. :-\ It's hard to wrangle ~15 patches for abug. 11:43:01 <clokep> Yes, it is. :) 11:47:50 --> hadi has joined #instantbird 11:57:43 <-- clokep has quit (Ping timeout) 12:13:17 <-- dew has quit (Ping timeout) 12:14:14 --> dew has joined #instantbird 12:28:04 <-- BWMerlin has quit (Quit: BWMerlin) 12:32:47 --> mconley has joined #instantbird 12:33:47 --> mconley_ has joined #instantbird 12:33:59 <-- mconley has quit (Connection reset by peer) 12:38:18 <-- mconley_ has quit (Ping timeout) 12:38:42 --> clokep_work has joined #instantbird 12:38:54 <-- GeKo has quit (Z:lined (dronebot)) 12:42:04 <-- dew has quit (Ping timeout) 12:42:28 --> dew has joined #instantbird 12:46:13 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 12:49:11 --> GeKo has joined #instantbird 12:49:54 --> deOmega has joined #instantbird 12:58:25 <clokep_work> Ah, I didn't realize that bug 956579 included the chat/ changes. :) 12:58:29 <clokep_work> That makes more sense. 13:02:45 <clokep_work> flo-retina: Any tips for pushing to try or just read the page? 13:03:02 <-- dew has quit (Ping timeout) 13:03:41 <flo-retina> read the page 13:03:51 --> dew has joined #instantbird 13:09:12 <clokep_work> flo-retina: I want to build all, right? 13:09:58 <flo-retina> you mean all OSes? 13:10:18 <flo-retina> you want a build similar to what will happen once you push to the real c-c 13:12:27 <clokep_work> I meant this try chooser thing, yes. :) 13:12:38 <clokep_work> I think "similar to what will happenw ith a real push" is the defaults. 13:39:06 * clokep_work has to remmber how to push on Windows using SSH. :-\ 13:51:13 <clokep_work> flo-retina: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=0274b635b5cd 14:03:43 <flo-retina> is the -e to receive emails? 14:07:41 <clokep_work> It appeared when I clicked the "email me for everything" option, so I assume so. :-D 14:08:49 <flo-retina> clokep_work: you have still butchered my name: Florian Quèze 14:09:15 <clokep_work> flo-retina: :-\ I'm not going to worry about it for my try push. 14:09:22 <clokep_work> flo-retina: Could it be an issue with encodings on Windows? 14:09:31 <flo-retina> possibly 14:09:46 <flo-retina> it's not important for try, but try is the place to try stuff ;) 14:11:19 <clokep_work> Yup! :) 14:13:32 <flo-retina> you may need to specify -encoding utf-8 or something when you hg import 14:17:41 <clokep_work> OK. I'll either play w/ it or let you push it? 14:20:00 <-- dew has quit (Ping timeout) 14:20:20 --> dew has joined #instantbird 14:32:52 <flo-retina> is the encoding looking OK or broken when you look at the output of "hg out"? 14:32:56 <flo-retina> or of "hg log" 14:33:16 <flo-retina> I guess if it appears OK locally but is broken once push, it will be difficult for you to address 14:35:56 <clokep_work> flo-retina: In hg log I see Florian Qu<C3><A8>ze, but I think that's what I've always seen... 14:36:33 <clokep_work> flo-retina: Ah, no it's usually Florian Qu<E8>ze... 14:36:52 <clokep_work> Both look OK in TortoiseHg. 14:40:25 <-- dew has quit (Ping timeout) 14:41:09 --> dew has joined #instantbird 14:42:11 <clokep_work> 5 failed builds so far in https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=0274b635b5cd :( 14:44:01 <flo-retina> clokep_work: TB looks busted 14:44:17 <flo-retina> https://tbpl.mozilla.org/?tree=Thunderbird-Trunk see the "N" builds (N = Nightly), they have the same errors as your try push 14:48:22 <-- dew has quit (Connection reset by peer) 14:48:26 --> dew has joined #instantbird 14:50:10 <-- dew has quit (Ping timeout) 14:50:17 --> dew has joined #instantbird 14:51:16 <clokep_work> flo-retina: I don't see what you mean by "N" builds. :-\ 14:51:57 <flo-retina> you don't see red 'N' on https://tbpl.mozilla.org/?tree=Thunderbird-Trunk ? 14:52:29 <clokep_work> Oh, yes. 14:52:39 <clokep_work> I didn't realize you mean in the list of builds. Sorry. 14:54:45 * clokep_work was looking next to the job names. :) 15:15:56 <-- dew has quit (Connection reset by peer) 15:16:03 --> dew has joined #instantbird 15:24:53 <-- dew has quit (Ping timeout) 15:24:57 --> dew has joined #instantbird 15:29:13 <-- dew has quit (Ping timeout) 15:29:43 --> dew has joined #instantbird 15:29:53 * clokep_work pokes instantbot 15:29:54 <instantbot> Leave me out of it! 15:33:07 <-- dew has quit (Ping timeout) 15:33:08 * flo-retina is sending BMO spam :( 15:34:52 --> dew has joined #instantbird 15:37:13 <clokep_work> For what? 15:40:36 <flo-retina> clokep_work: BMO being silly 15:40:52 <flo-retina> https://bugzilla.mozilla.org/show_bug.cgi?id=958070 and https://bugzilla.mozilla.org/show_bug.cgi?id=958071 15:41:45 <clokep_work> That's fun. :) 15:45:42 <-- ivan has quit (Ping timeout) 15:47:24 --> ivan has joined #instantbird 16:01:09 <-- GeKo has quit (Ping timeout) 16:01:42 <-- dew has quit (Ping timeout) 16:01:52 --> GeKo has joined #instantbird 16:02:27 --> dew has joined #instantbird 16:10:00 <-- dew has quit (Ping timeout) 16:11:09 --> dew has joined #instantbird 16:36:57 <-- gerard-majax__ has quit (Ping timeout) 16:44:57 --> mconley has joined #instantbird 16:49:33 <-- mconley has quit (Connection reset by peer) 16:51:21 --> mconley has joined #instantbird 16:51:39 <-- dew has quit (Ping timeout) 16:52:21 --> dew has joined #instantbird 16:55:25 <-- mconley has quit (Input/output error) 17:04:08 <-- dew has quit (Ping timeout) 17:04:54 --> dew has joined #instantbird 17:11:44 <-- dew has quit (Ping timeout) 17:12:27 --> dew has joined #instantbird 17:15:34 <clokep_work> So looks like jcranmer is about to fix that bustage is there a way to "retry" my try build? 17:15:36 <clokep_work> Or do I just repush it? 17:16:07 <flo-retina> if you retry it will retry the exact same changeset, which has a busted parent 17:16:18 <flo-retina> you need to hg pull, hg rebase, hg push 17:17:49 <clokep_work> Right. 17:18:14 * clokep_work ownders if he should wait for c-c to go green first or trust jcranmer's fix... 17:21:03 <-- dew has quit (Ping timeout) 17:21:17 --> dew has joined #instantbird 17:21:24 <flo-retina> clokep_work: go ahead and push to try again without waiting. (note: it's an opportunity to try fixing the encoding ;)) 17:21:36 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:22:22 --> dew1 has joined #instantbird 17:23:44 <-- dew has quit (Ping timeout) 17:52:55 --> Mook_as has joined #instantbird 17:53:03 --> jb has joined #instantbird 17:57:40 --> mconley has joined #instantbird 17:59:22 <-- mconley has quit (Ping timeout) 18:00:27 --> mconley has joined #instantbird 18:02:40 <-- mconley has quit (Ping timeout) 18:07:19 --> mconley has joined #instantbird 18:08:15 --> flo-retina has joined #instantbird 18:08:15 * ChanServ sets mode +qo flo-retina flo-retina 18:08:32 <clokep_work> flo-retina: I just it again w/o fixing anything to do w/ the encoding. 18:08:37 <clokep_work> (I was running out the door for lunch...) 18:08:44 <-- GeKo has quit (Ping timeout) 18:13:10 --> GeKo has joined #instantbird 18:23:12 <-- GeKo has quit (Quit: leaving) 18:24:09 --> GeKo has joined #instantbird 18:24:45 <-- mconley has quit (Ping timeout) 18:31:32 --> mconley has joined #instantbird 18:31:38 <-- mconley has quit (Quit: Leaving...) 18:33:37 <nathanr> hey guys, having gone through the process of submitting a message style I gotta wonder if you guys aren't shooting yourself in the foot with the whole process of submitting addons and having to go through the "experimental" phase. 18:34:18 <nathanr> It makes sense once you've grown large enough to have a large dedicated community but going through the submissions of experimental addons right now it seems many devs just seem to submit it and forget about it, leading to those addons never really seeing the light of day 18:34:51 <nathanr> (I am fully aware of the irony of my raising this issue - we are working on improving our addon section significantly though :p) 18:34:54 <clokep_work> nathanr: It's just how the software works. :-\ 18:35:20 <clokep_work> It's not like we ever made a policy about that AFAIK. 18:35:39 <nathanr> clokep_work: can't you configure it to a degree though ? 18:36:00 <clokep_work> You've clearly never looked at Remora. ;) 18:36:02 <flo-retina> nathanr: no 18:36:11 <nathanr> I have not, no :p 18:36:14 <clokep_work> That software is very...not customizable. 18:36:18 <nathanr> ok 18:36:19 <flo-retina> nathanr: anything that involves tweaking that website requires depressing someone ;) 18:36:22 <clokep_work> I believe we changed Firefox to Instantbird w/ sed. ;) 18:36:31 <flo-retina> clokep_work: we did! 18:36:33 <clokep_work> (It was hard coded strings IIRC.) 18:36:39 <nathanr> well I'm fairly sure the solution we're working on will be open source, so you're welcome to look into that once it's ready 18:36:45 <flo-retina> "Mozilla Firefox" was hard coded as the first product in plenty of places 18:37:04 <flo-retina> nathanr: if it works well and is easy to maintain, we may be very interested 18:37:08 <clokep_work> nathanr: That would be pretty awesome. :) I think nightingale has some sort of add-on software too? 18:37:18 <flo-retina> nathanr: remora sucks in countless ways. 18:37:58 <nathanr> mm I can see that 18:38:14 <nathanr> my other critique was that the eperimental addons are very hard to discover 18:38:52 <nathanr> fwiw we are redoing our community with XenForo, and will be using their Resource Manager (with some modifications) for our addons 18:39:29 <nathanr> which looks like this by default - http://xenforo.com/community/resources/ 18:42:17 * clokep_work doesn't want to be involved in THAT migration. ;) 18:42:26 <nathanr> lol 18:42:37 <nathanr> yeah that part you'd have to do yourself :p 18:42:46 <flo-retina> clokep_work: nobody wants to be involved in that 18:42:55 <nathanr> what kind of db does remora use ? 18:43:06 <flo-retina> nathanr: mysql 18:43:18 <flo-retina> good luck to understand anything of the tables it creates though :) 18:43:26 <nathanr> ugh :p 18:43:27 <flo-retina> there are several dozens, possibly 50 :-D 18:43:39 <nathanr> does firefox still use remora ? 18:43:42 <flo-retina> no 18:44:01 <flo-retina> they switched to something else 3+ years ago I think 18:44:28 <clokep_work> zamboni is the newer one. 18:44:36 <nathanr> I'd imagine there's migrations for that one? 18:44:48 <clokep_work> I think a lot of it was done manually... 18:44:50 <flo-retina> nathanr: so I think we do need the review process. We can't let anybody put add-ons that will be found by the add-on manager's integrated search, and installed with a single click 18:45:19 <clokep_work> flo-retina: I see greens! https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=5793ec167fb4 18:45:23 <nathanr> flo-retina: right, but you might be able to shorten the experimental phase by moderating submissions 18:45:42 <flo-retina> nathanr: I definitely agree that the UI sucks 18:46:17 <flo-retina> nathanr: most of my Ib add-ons are experimental because attaching a screenshot (which is difficult for add-ons that have no visible UI) is required to request review. 18:46:21 <nathanr> maybe a simple solution would be to make the experimental addons section more prominent 18:46:32 <flo-retina> and IIRC as an admin I can't force my add-on as public if the author hasn't requested review first... 18:46:51 <flo-retina> nathanr: anything that involves touching the code of remora is not a solution ;) 18:46:59 <nathanr> lol, that bad huh :p 18:47:34 <flo-retina> I won't try to do more than a search & replace of a string visible in the UI 18:48:19 <nathanr> you could always inject a js script that modifies the output in some simple ways 18:48:25 <clokep_work> I had to remove a seamonkey hack at one point, that was a pain. :( 18:48:33 <nathanr> its dirty but.. well it sounds like its already pretty dirty 18:49:10 <flo-retina> clokep_work: I had to fix the JSON.stringify algorithm... 18:49:21 <flo-retina> (implemented in PHP) 18:49:34 <flo-retina> the output wasn't valid, and Mozilla 2+ rejected it 18:49:52 <nathanr> huh 18:50:10 <nathanr> they had their own implementation of json_encode() or the PHP version of json_encode produced invalid output? 18:50:23 <flo-retina> they had their own 18:50:30 <nathanr> odd 18:50:33 <flo-retina> is json_encode something that was added in PHP5 or newer? 18:50:38 <flo-retina> I think remora targets php4 18:50:43 <nathanr> no its been around since 4 IIRC 18:50:54 <nathanr> although it was a bit limited back then 18:51:04 <flo-retina> PHP 5 >= 5.2.0 according to http://fr2.php.net/json_encode 18:51:06 <nathanr> ie. you had no output parameters such as convert ints 18:51:25 <nathanr> hmm really? I really thought it was in 4 18:51:44 <flo-retina> people didn't use JSON at the time PHP4 was the latest version :) 18:51:53 <flo-retina> XML was still the great new thing 18:52:02 <nathanr> yeah I suppose so 18:52:16 <nathanr> ugh you just made me remember SOAP, damn you 18:53:51 <nathanr> hmm seems fading in new messages screws up ib's scroll-to-bottom logic 18:56:53 <flo-retina> :-P 18:57:37 <flo-retina> nathanr: is your fading thing changing the size of the node? 18:58:08 <flo-retina> if you are changing the size of the node, you need to call the auto-scroll code yourself, like bubble does: if (autoScrollEnabled()) 18:58:08 <flo-retina> scrollToElement(p); 19:04:03 <nathanr> flo-retina: no it doesnt, but I'll try that - thanks! 19:04:25 <flo-retina> would still be useful to figure out why that happens 19:04:32 <nathanr> does that take into account that the user might be scrolling up to see a past message? 19:05:01 <flo-retina> yes 19:05:01 <nathanr> well to fade in the text must first be hidden 19:05:10 <flo-retina> that's the if (autoScrollEnabled()) check 19:05:17 <nathanr> my guess is the scrollToElement code is occasionally triggered while the message is hidden 19:05:39 <flo-retina> why aren't you using CSS animations or transitions btw? :) 19:05:40 <nathanr> cause it only happens once every 10 (+/_) messages 19:06:21 <nathanr> I guess for the fadein I could, but I cant for the bg color animations since the colors are set in the style attribute 19:06:28 <nathanr> I could get crafty though 19:07:58 --> FireFly_TB has joined #instantbird 19:09:17 <flo-retina> clokep_work: have you r? the whole new queue, or only the modified patches? 19:09:40 <flo-retina> ah, looks like 2 patches kept their r+ :) 19:10:51 <clokep_work> flo-retina: The patches that weren't touched weren't reuploaded. 19:11:58 <flo-retina> ok 19:13:48 <flo-retina> clokep_work: so, it looks like you are ready to push that chat/ merge bug, right? 19:15:26 <clokep_work> flo-retina: If the encoding stuff can be figured out. :-\ 19:15:36 <flo-retina> does that mean I should push it? 19:16:01 <clokep_work> I don't have time to look at it right now, so if you'd like it pushed now...probably. :) 19:16:11 <flo-retina> I want it pushed tonight 19:16:18 <flo-retina> I don't mind if it's 2 hours from now or now 19:18:25 <clokep_work> flo-retina: I don't see an easy way in Mercurial to force UTF 8 instead of the Windows code page. :-\ 19:19:09 <flo-retina> I think I gave you the command line parameter 19:19:41 <flo-retina> have you tried -encoding utf-8 or --encoding utf-8 ? 19:21:14 * flo-retina was hoping to r+ everything :( 19:22:21 <clokep_work> flo-retina: OK that seems to have worked. 19:22:29 <clokep_work> The flag isn't documented in the help. :-S 19:31:54 <clokep_work> flo-retina: OK I'm rebasing now, so I'll push momentarily. 19:32:08 <flo-retina> rebasing? 19:33:31 --> gerard-majax__ has joined #instantbird 19:34:14 <clokep_work> A couple of commits were pushed. 19:44:57 <flo-retina> clokep_work: you've got your reviews. 3 r-s, the others are + :) 19:48:03 <clokep_work> flo-retina: Thanks so much! 19:48:10 <clokep_work> I think I pushed your name in the proper encoding this time! :) 19:49:16 <flo-retina> looks like it! :) 19:49:17 <flo-retina> thanks 19:49:46 <flo-retina> looks like your try server push was more broken than I thought. All the relevant changesets are together in a single changeset attributed to nhnt11 19:49:55 <flo-retina> but the one on c-c seems good :) 19:50:46 <clokep_work> Yeah, it's because I qimported one and imported the other. 19:51:40 <clokep_work> And someone already pushed after me. :P 19:52:46 --> EionRobb has joined #instantbird 19:53:11 <flo-retina> that's why we will want to close the tree ;) 19:53:28 <clokep_work> That's definitely going to bitrot my patch queue. :-\ 19:53:31 <clokep_work> Well the first commit. :) 19:55:43 --> Mic has joined #instantbird 20:16:13 --> wnayes has joined #instantbird 20:18:02 <-- gerard-majax__ has quit (Ping timeout) 20:19:45 <clokep_work> flo-retina: Thanks. Seems the comments are straight forward. 20:19:53 <clokep_work> I wonder if try would work with another application... 20:20:33 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 20:21:07 <flo-retina> if you find how to change the mozconfig to --enable-application=im, it should build 20:21:32 <flo-retina> it may fail to upload if there's a check for the name of the file 20:27:05 <-- FireFly_TB has quit (Quit: FireFly_TB) 20:27:17 --> FireFly_TB has joined #instantbird 20:32:11 <clokep_work> flo-retina: It looks like there are a few changes in chat/ in c-c that we don't have in ib. 20:32:27 <clokep_work> At least the diff when I copy over ib -> c-c of chat/ is not just makefiles/moz.build as I expected. :( 20:32:59 --> rosonline has joined #instantbird 20:34:26 <-- FireFly_TB has quit (Ping timeout) 20:34:34 <flo-retina> clokep_work: pastebin? 20:35:59 <clokep_work> flo-retina: http://pastebin.instantbird.com/527200 20:36:32 <-- jb has quit (Ping timeout) 20:37:06 <flo-retina> the + lines are ib, and - are tb, right? 20:38:41 <flo-retina> I don't really understand how you got this diff 20:38:51 <flo-retina> there are plenty of makefile stuff in this pastebin 20:39:05 <clokep_work> Why is that surprising to you at all? :-S 20:39:05 <flo-retina> and some files where you seem to be having line ending issues 20:39:42 <flo-retina> in twitter-text.jsm you definitely have encoding issues 20:39:58 <clokep_work> That diff is after doing a cp ../instantbird/chat . while in comm-central. 20:40:05 <clokep_work> And then it's hg diff chat/ 20:40:23 <flo-retina> it would be more interesting to do that after applying the patches from your queue 20:41:22 <clokep_work> I don't understand what that would show, it would essentially just unapply a bunch of them. 20:41:40 <flo-retina> it would hide the stuff we already know about and expect 20:44:31 <clokep_work> I'm not sure I agree. :-\ 20:55:59 * clokep_work wonders if he missed porting a Yahoo changeset. :-\ 21:00:35 --> Mic|web has joined #instantbird 21:03:22 --> jb has joined #instantbird 21:03:42 <-- jb has quit (Input/output error) 21:04:35 --> jb has joined #instantbird 21:10:49 <clokep_work> Well I found 1 changeset that we didn't port from c-c to ib. 21:11:07 <-- deOmega has quit (Quit: So easy...but yet complicated.) 21:12:55 --> FireFly_TB has joined #instantbird 21:13:32 <clokep_work> http://hg.instantbird.org/instantbird/rev/dce9df4b6baa 21:21:11 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/8aac6b75a0af - Geoff Lankow - Bug 749930 - Replace uses of nsILocalFile with nsIFile (compiled code only); r=Fallen,Neil sr=Standard8 21:21:12 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/dce9df4b6baa - Florian Quèze - Fix chat unit test bustage from bug 812995 Support 'blink' value at -moz-text-decoration-line and drop -moz-text-blink - rs=bustage fix for CLOSED TREE 21:22:48 <flo-retina> that nsIFile one surprises me; I remember doing that kind of changes. 21:23:03 <flo-retina> But maybe I've only done it in purple/ for the Tb add-on :-| 21:23:23 <clokep_work> flo-retina: I just uploaded another patch to the port bug #7...do I need approval to push that or? 21:23:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=7 cri, P5, ---, florian, RESO INVALID, libpangocairo nonexistant in RHEL4 21:23:29 <clokep_work> I missed one changeset cause the name confused me. :( 21:23:48 <clokep_work> https://bugzilla.mozilla.org/attachment.cgi?id=8357980&action=edit 21:24:11 <clokep_work> After these....it looks like there's a line ending issue and the encoding issue + build things (expected). 21:24:19 <-- jb has quit (Ping timeout) 21:24:21 <clokep_work> When I do a diff of the two repositories. 21:26:08 <flo-retina> clokep_work: so what I was saying is: if you apply https://bugzilla.mozilla.org/attachment.cgi?id=8357542&action=diff to your ib repository, the diff should be way more readable 21:26:36 <flo-retina> ah, you are using cp and hg diff :( 21:26:55 <flo-retina> why not |diff -ru ib/chat c-c/chat| ? 21:27:00 <clokep_work> That's what I Just did. 21:27:04 <clokep_work> Gives the same result though. 21:27:46 <flo-retina> why do you have build system junk in your diff after doing that? 21:28:10 <clokep_work> Umm...I'm really confused at how I wouldn't. 21:28:13 <clokep_work> I have c-c, I have ib. 21:28:18 <clokep_work> I'm doing a diff of them. 21:28:25 <clokep_work> Are you saying to apply that patch first? 21:28:57 <flo-retina> I'm confused by how what I've said, starting with "if you apply ..." could be interpreted differently :-S 21:29:28 <clokep_work> Because I'm unsure if that was a connected idea or not. 21:29:37 <clokep_work> I can't just apply that patch though. 21:29:49 <clokep_work> Not without copying the source over first. 21:30:06 <flo-retina> why? 21:30:22 <flo-retina> I'm starting to think I'll do the diff myself :-P 21:31:04 <clokep_work> OK. 21:31:06 <clokep_work> Let me be clear. 21:31:11 <clokep_work> IF you start with a clean c-c. 21:31:21 <clokep_work> You can't apply the diff removing a bunch of stuff that isn't there. 21:31:34 <flo-retina> I would apply that patch to Ib. 21:31:36 <flo-retina> not c-c 21:31:43 <clokep_work> Ah. I see. 21:31:52 <clokep_work> That was not clear. 21:32:11 <flo-retina> "if you apply https://bugzilla.mozilla.org/attachment.cgi?id=8357542&action=diff to your ib repository" :-| 21:32:54 --> jb has joined #instantbird 21:34:49 <clokep_work> flo-retina: http://pastebin.instantbird.com/527281 21:35:00 <clokep_work> That has a patch I haven't pushed yet to c-c. 21:35:12 <clokep_work> And the revert chat/'s make stuff applied to ib. 21:37:31 <flo-retina> so there's the tooltip bug. The vkontakte line is because you need to update the makefile patch, then there's some encoding issue in twitter-text, these strange "avoid bustage" lines, and likely line ending issues in test_yahooAccount.js and contacts.properties 21:38:09 <clokep_work> The avoid bustage lines are in c-c, I thought... I think someone added them and we added them in ib too. 21:38:30 <clokep_work> Yeah I wonder what's with the line ending issues, that one is weird to me. 21:38:34 <flo-retina> I've never seen them before today 21:38:41 <flo-retina> so yeah, I'm sure they are in c-c 21:38:46 <flo-retina> but I don't know what their purpose is 21:38:53 <clokep_work> Avoiding bustages! Clearly. :P 21:38:59 <flo-retina> heh :) 21:39:36 <clokep_work> Anyway, i need to go. 21:39:41 <clokep_work> (And won't be back online till late.) 21:41:49 <-- mrphs has quit (Ping timeout) 21:42:08 --> mrphs has joined #instantbird 21:42:45 <clokep_work> Goodnight. :) 21:42:51 <clokep_work> (I'll try to fix up those patches again tonight btw...) 21:42:58 <-- FireFly_TB has quit (Ping timeout) 21:42:58 <clokep_work> ANd maybe figure out what's with those other issues in that pastebin. 21:44:43 <-- clokep_work has quit (Ping timeout) 22:00:10 --> Mic has joined #instantbird 22:00:32 * Mic is now known as Mic2 22:03:01 <-- wnayes has quit (Ping timeout) 22:06:59 --> wnayes has joined #instantbird 22:21:15 <flo-retina> the js shell doesn't seem in the mood of processing my hg export of the ib repo :-S 22:21:55 <flo-retina> ah, no, trivial mistake :) 22:22:47 <-- GeKo has quit (Ping timeout) 22:30:32 <flo-retina> we have 2117 file renames in our current ib repo 22:35:09 --> GeKo has joined #instantbird 22:38:12 <-- jb has quit (Ping timeout) 22:41:53 <flo-retina> after doing some filtering, the interesting moves are http://pastebin.instantbird.com/527352 22:49:05 --> jb has joined #instantbird 22:52:21 --> mconley has joined #instantbird 22:53:27 * flo-retina doesn't understand how hg convert is handling renames 23:01:11 <-- mconley has quit (Ping timeout) 23:02:44 --> mconley has joined #instantbird 23:03:02 <-- mrphs has quit (Z:lined (dronebot)) 23:03:08 --> mrphs has joined #instantbird 23:22:31 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client) 23:25:44 * flo-retina updated hg from 2.3 to 2.8.2, in the hope that results will be better 23:27:14 <flo-retina> same results 23:27:19 --> clokep has joined #instantbird 23:27:19 * ChanServ sets mode +o clokep 23:28:31 <-- mconley has quit (Ping timeout) 23:30:27 <-- jb has quit (Ping timeout) 23:30:46 --> mconley has joined #instantbird 23:31:04 <flo-retina> http://bz.selenic.com/show_bug.cgi?id=2243 "wontfix" :( 23:31:41 <flo-retina> http://bz.selenic.com/show_bug.cgi?id=2243#c3 looks a lot like others have done worse than us at importing bugzillas ;) 23:34:11 --> jb has joined #instantbird 23:35:35 <-- Mic2 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 23:41:24 <-- jb has quit (Ping timeout) 23:42:14 <-- mconley has quit (Ping timeout) 23:42:49 --> mconley has joined #instantbird