#instantbird log on 12 02 2013

All times are UTC.

00:15:13 <-- dew has quit (Ping timeout)
00:15:17 <-- qlum has quit (Quit: Getting the <censored> out.)
00:18:50 --> mconley has joined #instantbird
00:28:50 <-- jb has quit (Ping timeout)
00:57:10 --> dew has joined #instantbird
02:14:53 --> clokep has joined #instantbird
02:14:54 * ChanServ sets mode +o clokep 
03:51:06 <-- mconley has quit (Input/output error)
03:51:26 <-- dew has quit (Ping timeout)
03:51:33 --> dew has joined #instantbird
04:01:38 <-- dew has quit (Ping timeout)
04:02:08 --> dew has joined #instantbird
04:03:33 --> dew1 has joined #instantbird
04:03:59 <-- dew has quit (Ping timeout)
04:14:17 <instant-buildbot> build #1039 of linux-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1039
04:40:41 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
04:41:24 <-- EionRobb has quit (Quit: Leaving.)
05:17:53 <-- gerard-majax__ has quit (Ping timeout)
05:21:18 <-- wnayes has quit (Quit: wnayes)
05:41:58 --> FireFly_TB has joined #instantbird
05:55:45 --> jb has joined #instantbird
06:46:16 <-- jb has quit (Ping timeout)
06:46:53 --> jb has joined #instantbird
06:56:44 <-- FireFly_TB has quit (Ping timeout)
07:07:47 <-- jb has quit (Ping timeout)
07:34:50 --> GeKo has joined #instantbird
07:54:08 <instant-buildbot> build #1176 of win32-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1176
08:00:30 --> flo-retina has joined #instantbird
08:00:30 * ChanServ sets mode +qo flo-retina flo-retina 
08:00:58 --> jb has joined #instantbird
08:14:23 --> FireFly_TB has joined #instantbird
08:21:46 --> gerard-majax__ has joined #instantbird
08:32:16 --> dionisos has joined #instantbird
08:37:43 --> mpmc has joined #instantbird
08:48:51 <-- dionisos has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com)
09:17:56 <-- FireFly_TB has quit (Ping timeout)
09:21:22 <-- sabret00the has quit (Ping timeout)
09:44:43 <instant-buildbot> build #1268 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/1268
10:10:43 --> BWMerlin has joined #instantbird
10:11:54 --> sabret00the has joined #instantbird
10:15:33 --> dionisos has joined #instantbird
10:32:53 --> aleth has joined #instantbird
10:32:53 * ChanServ sets mode +h aleth 
10:33:58 <-- aleth has quit (Quit: Ciao)
10:34:03 --> aleth has joined #instantbird
10:34:03 * ChanServ sets mode +h aleth 
10:53:36 <-- GeKo has quit (Ping timeout)
10:56:16 --> GeKo has joined #instantbird
11:00:21 <-- dionisos has quit (Ping timeout)
11:10:38 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
11:15:16 <-- douglaswth has quit (Ping timeout)
11:15:39 --> douglaswth has joined #instantbird
11:16:28 <-- dew1 has quit (Ping timeout)
11:16:41 --> dew has joined #instantbird
11:18:28 <-- dew has quit (Ping timeout)
11:21:07 <-- GeKo has quit (Quit: leaving)
11:21:12 <-- mpmc has quit (Ping timeout)
11:21:15 --> GeKo has joined #instantbird
11:21:54 --> mpmc has joined #instantbird
11:22:43 --> clokep has joined #instantbird
11:22:43 * ChanServ sets mode +o clokep 
11:42:08 --> flo-retina has joined #instantbird
11:42:08 * ChanServ sets mode +qo flo-retina flo-retina 
11:47:36 <flo-retina> the 13th item in my awesometab is a Bonjour contact marked as away, and I have no logs with him. That's really puzzling, given that the 15th is someone available and with whom I talked a 7 times in the last 3 months.
11:49:09 <clokep> I generally find mine are a bit off (but not ridiculous), but I think that's because it's "missing" the logs from when I'm at work.
11:49:40 <flo-retina> The rest of the list seems relatively reasonable
11:50:18 <aleth> Check again after the stats id patch lands?
11:50:46 <aleth> To diagnose further, you'd have to look at the stats JSON file and see if something jumps out at you.
12:02:30 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
12:04:45 <flo-retina> aleth: that Bonjour guy isn't mentioned anywhere in the stats JSON
12:06:24 <-- BWMerlin has quit (Quit: BWMerlin)
12:06:49 <aleth> Maybe you've discovered an edge case for nhnt11... contacts with no logs
12:07:15 <flo-retina> ah, that may be the cause
12:07:34 <flo-retina> I suspect I have other contacts without logs though (even available contacts ;))
12:24:28 <aleth> Is there anything left blocking the string freeze?
12:45:29 --> clokep has joined #instantbird
12:46:28 * clokep is now known as IRCMonkey16374
12:49:34 * IRCMonkey16374 is now known as clokep___
12:49:50 <clokep___> aleth: As far as I know, no.
13:02:51 --> jb1 has joined #instantbird
13:02:53 <-- jb has quit (Connection reset by peer)
13:06:33 <aleth> clokep___: Did you have any better idea for bug 2254? The only alternative I could think of would be to have a conv.isConnecting flag. 
13:06:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2254 enh, --, ---, aleth, NEW, Open conversations when joinChat is called for better responsiveness
13:06:35 <aleth> We could expose it and add a throbber ;)
13:14:20 <clokep___> aleth: In that current patch parted and left seem to be almost identical. ;)
13:16:15 <aleth> No, left just means we are not in the room, nothing about the reason.
13:16:40 <clokep___> I understand the semantical difference.
13:16:47 <clokep___> But looking at that patch their usage is identical.
13:16:55 <clokep___> I need to look and see what else touches left.
13:17:01 * clokep___ wonders what the "default" value for left is...
13:17:16 <aleth> There's a reason I didn't add parted to the other places that set left ;)
13:17:39 <aleth> The default is true.
13:18:14 <clokep___> Good.
13:19:03 <aleth> I wasn't joking about a "connecting" flag being the alternative.
13:19:14 <clokep___> Where else is left set then?
13:19:22 <aleth> When you get disconnected
13:19:48 <clokep___> OK...
13:20:58 <clokep___> Where does the message from the "automatic reconnection" occur? Is this part of the prpl or something else? :-S
13:21:07 --> FireFly_TB has joined #instantbird
13:21:35 <aleth> I don't think it's part of the prpl
13:22:22 <aleth> http://lxr.instantbird.org/instantbird/source/chat/components/src/imConversations.js#237
13:25:31 <clokep___> Bleh.
13:25:44 <clokep___> I feel like all these messages + the auto-rejoining shouldn't be in the prpl.
13:25:50 <clokep___> That's probably why I don't really love that patch.
13:26:21 <aleth> It's possible that might get cleaned up when moving join/part messages outside the prpl
13:27:56 * flo-retina is looking forward to join/part not being handled by the prpl
13:30:24 <instantbot> clokep@gmail.com granted review for attachment 3103 on bug 2254.
13:30:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2254 enh, --, ---, aleth, NEW, Open conversations when joinChat is called for better responsiveness
13:31:22 <-- FireFly_TB has quit (Quit: FireFly_TB)
13:31:54 <flo-retina> I think the one thing I would like to patch these days is handling correctly swipe up/down in the awesometab
13:32:08 <flo-retina> I tend to do that gesture there quite often, and I'm always surprised it doesn't work
13:32:37 --> FireFly_TB has joined #instantbird
13:32:53 <aleth> It's strange it doesn't work - shouldn't richlistboxes know about that?
13:35:04 <flo-retina> maybe only when they are focused?
13:35:40 <flo-retina> there's definitely a handler: http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/richlistbox.xml#507
13:35:41 <aleth> clokep___: Thanks. I agree totally that the rejoining logic should be moved
13:36:57 <flo-retina> aleth: interestingly, this handler "just works" in the account manager
13:37:00 <-- FireFly_TB has quit (Quit: FireFly_TB)
13:37:35 <flo-retina> doesn't work in the blist, but that's because we have the scrollbar around the 2 lists, rather than just the list of contacts
13:37:39 <aleth> Is that macgestures.js file we have doing something unwanted and is not included there?
13:37:58 --> FireFly_TB has joined #instantbird
13:38:49 <flo-retina> aleth: you are so right here :-S
13:39:00 <flo-retina> we add a capturing listener on the whole window
13:39:13 <flo-retina> and .stopPropagation() unconditionally
13:39:19 <aleth> Rather than on browsers :-/
13:39:37 <flo-retina> aleth: it's ok that it's not just on browsers
13:39:57 <clokep___> flo-retina: Ah, maybe that's why my scroll button thing doesn't work in the contacts list!
13:40:01 <flo-retina> I'm happy to be able to use the gesture when my mouse is somewhere else in the window
13:40:13 <aleth> Oh OK, so that was intentional.
13:40:21 <flo-retina> clokep___: I doubt it (2 finger scrolling works) but maybe
13:41:11 <flo-retina> http://lxr.instantbird.org/instantbird/source/instantbird/content/macgestures.js#166
13:41:34 --> nhnt11 has joined #instantbird
13:41:55 <nhnt11> aleth, flo-retina: Contacts without logs shouldn't be an edge case :/
13:41:58 <nhnt11> I have plenty of such contacts
13:42:07 <flo-retina> nhnt11: I have plenty of them too
13:42:18 <aleth> It was just a random guess ;)
13:42:33 <nhnt11> And they all seem to be happily living at the bottom of my list..
13:43:00 <flo-retina> It's pretty obvious we shouldn't stop the propagation of the event if we haven't handled it, but I don't really understand why we need that stopPropagation at all
13:43:34 <flo-retina> nhnt11: how do you know they are happily living, rather than hiding in fear at the bottom of the list? ;)
13:43:57 <nhnt11> considering I've never talked to them, I suppose I don't really care which one it is :P
13:44:16 <aleth> flo-retina: Yeah, maybe your real problem is contact #15 not being ranked higher ;)
13:44:45 <flo-retina> aleth: I think the real problem is "why is #13 getting attention?"
13:45:32 <flo-retina> note that now that the said contact #13 has changed his status from away to available, he's ranked with the other available contacts I never talked to.
13:45:57 <aleth> Heh, maybe that's a clue...
13:46:17 <flo-retina> I suspect an edge case related to displaying the awesometab immediately after a resweep of the logs. (The new nightly caused it, right? ;))
13:46:27 <nhnt11> interesting
13:46:31 <flo-retina> or maybe while the resweep was still in progress
13:46:33 * nhnt11 still doesn't have a recent nightly
13:46:35 <aleth> No the new nightly would not have triggered a resweep
13:46:41 <aleth> 2210 didn't land yet ;)
13:46:54 <clokep___> flo-retina: Is it possible there has been updates to http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-gestureSupport.js we should port btw?
13:47:27 <aleth> flo-retina: I think we should land bug 2210 before investigating that further, just to be sure that isn't confusing the issue
13:47:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2210 nor, --, ---, aleth, NEW, Stats ids are not set consistently
13:49:02 * nhnt11 cheers for bug 2254 :P
13:49:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2254 enh, --, ---, aleth, NEW, Open conversations when joinChat is called for better responsiveness
13:49:08 <flo-retina> :)
13:49:51 <flo-retina> aleth: it's really difficult to investigate bugs that we can't reproduce (I can't see it any more...)
13:50:05 <flo-retina> I guess what we would really need is a way to have debug logs for the ranking
13:50:45 <aleth> In principle from the stats JSON nhnt11 should be able to tell you what's going on ;)
13:50:58 <flo-retina> aleth: the contact isn't in the JSON file
13:51:05 <aleth> But the others are.
13:51:25 <flo-retina> and?
13:51:34 <aleth> It's relative ranking that counts, right?
13:52:47 <flo-retina> I guess it's the data that was used to calculate the score of each item
13:53:36 <flo-retina> btw, I also noticed that this item moved around quite a bit while scrolling (it moved up and down by 2/3 places everal times before stabilizing itself at the 13th position)
13:54:27 <nhnt11> That sounds.... awkward.
13:54:39 <aleth> This should be the place to look http://lxr.instantbird.org/instantbird/source/instantbird/components/ibConvStatsService.js#333
13:55:29 * clokep___ happily ignores that file and assumes it's magic. :)
13:56:04 <flo-retina> clokep___: seems like the way I handle the yahoo/ folder ;)
13:56:14 <flo-retina> oh btw, I guess I need to look at these JS-Yahoo strings :-S
13:57:32 <flo-retina> another thing I would like to fix is: return to the previous tab when pressing "escape" on the awesome tab
13:58:05 <clokep___> I'd really like to restore the last tab with Ctrl+Shift+T.
13:58:07 <aleth> :)
13:58:10 <clokep___> I keep hoping Mic will fix that. ;)
13:58:13 <aleth> flo-retina: You could fix that for all tabs ;)
13:58:49 <flo-retina> aleth: hmm, I've never noticed the problem with other tabs. Typically because I haven't used a keyboard shortcut to open them.
13:59:17 <aleth> I suppose it wasn't really possible before the awesometab
13:59:20 <flo-retina> aleth: I look at "escape" like a way to undo pressing Command+T if I changed my mind
13:59:39 <flo-retina> aleth: it is possible
14:00:23 <flo-retina> aleth: but it requires selecting the tab I'll close with the Command+Shift+<tab number> keyboard shortcut.
14:01:20 <-- nhnt11 has quit (Ping timeout)
14:01:55 <flo-retina> aleth: I guess a problem would be that the code handles remembering the last time is in http://lxr.instantbird.org/instantbird/source/instantbird/content/macgestures.js#15 so currently Mac-only
14:02:01 <flo-retina> +that
14:02:15 --> nhnt11 has joined #instantbird
14:11:41 <-- nhnt11 has quit (Ping timeout)
14:23:20 --> dionisos has joined #instantbird
14:39:12 --> unghost has joined #instantbird
14:46:40 <-- unghost has quit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
15:04:18 --> dew has joined #instantbird
15:24:12 <-- dionisos has quit (Ping timeout)
15:37:17 --> mconley has joined #instantbird
15:38:05 <-- mconley has quit (Input/output error)
15:49:34 --> mconley has joined #instantbird
16:06:51 <-- jb1 has quit (Ping timeout)
16:32:26 <-- gerard-majax__ has quit (Ping timeout)
16:36:32 --> Huvik has joined #instantbird
16:36:38 <-- Huvik has quit (Quit: Huvik)
16:55:10 <-- FireFly_TB has quit (Ping timeout)
16:57:57 --> dionisos has joined #instantbird
17:04:13 --> gerard-majax__ has joined #instantbird
17:09:35 <-- gerard-majax__ has quit (Quit: Ex-Chat)
17:09:41 --> gerard-majax__ has joined #instantbird
17:13:31 <instantbot> New Core - XMPP bug 2264 filed by aleth@instantbird.org.
17:13:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2264 nor, --, ---, nobody, NEW, Reference to undefined property (intermediate value).qName
17:16:41 <clokep___> aleth: Any context on that? Every time you log in?
17:16:47 <clokep___> When you click on someone's name?
17:16:59 <aleth> No idea. Never noticed it before.
17:17:22 <clokep___> Bah that's a useless error without the stack. :-/
17:17:29 <aleth> Yeah :(
17:17:56 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 3108 on bug 2254.
17:17:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2254 enh, --, ---, aleth, NEW, Open conversations when joinChat is called for better responsiveness
17:18:15 --> jb has joined #instantbird
17:19:48 <clokep___> aleth: // True until successfully joined for the first time. \n  _firstJoin: false,
17:19:52 <clokep___> That seems a little fishy. :-S
17:20:13 <aleth> No, it's set in the constructor.
17:20:31 <aleth> I guess it depends on what you consider the "default" value...
17:20:33 <clokep___> Ah, I see!
17:22:29 <-- gerard-majax__ has quit (Ping timeout)
17:25:04 --> gerard-majax__ has joined #instantbird
17:29:01 <-- gerard-majax__ has quit (Ping timeout)
17:29:42 --> gerard-majax__ has joined #instantbird
17:30:02 <-- mpmc has quit (Ping timeout)
17:30:42 --> mpmc has joined #instantbird
17:34:58 <-- gerard-majax__ has quit (Ping timeout)
17:39:16 --> jb1 has joined #instantbird
17:39:20 <-- jb has quit (Connection reset by peer)
17:40:17 --> Mook_as has joined #instantbird
17:59:20 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
18:02:47 <-- GeKo has quit (Ping timeout)
18:06:52 --> qlum has joined #instantbird
18:23:06 --> wnayes has joined #instantbird
18:24:13 --> FireFly_TB has joined #instantbird
18:25:04 <instantbot> clokep@gmail.com granted review for attachment 3108 on bug 2254.
18:25:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2254 enh, --, ---, aleth, NEW, Open conversations when joinChat is called for better responsiveness
18:25:44 --> GeKo has joined #instantbird
18:26:03 <aleth> Btw I think the main work needed to move rejoining etc out of the prpl is adding chatRoomFields to the other protocols
18:26:11 <aleth> Which may be painful for libpurple, idk
18:27:12 <aleth> Maybe not, if we can do it in prplxpcom
18:27:42 <-- FireFly_TB has quit (Ping timeout)
18:28:41 <-- jb1 has quit (Ping timeout)
18:29:44 <clokep___> It should be able to be done in purplexpcom.
18:30:46 --> flo-retina has joined #instantbird
18:30:46 * ChanServ sets mode +qo flo-retina flo-retina 
18:31:07 <aleth> Idk, we change it when channel keys are added/changed for example
18:32:31 --> FireFly_TB has joined #instantbird
18:32:37 <clokep___> It might not have as good of features.
18:32:40 <clokep___> But I think it can still be done.
18:33:35 <flo-retina> I'm confused by what "adding chatRoomFields to the other protocols" means. Isn't chatRoomFields something we have unfortunately inherited from libpurple?
18:36:04 <aleth> Yes. What I meant is "storing it after use so it is around for reconnections". We only do that for IRC atm\
18:40:30 --> jb has joined #instantbird
18:45:30 <flo-retina> ah, ok
18:51:51 <clokep___> I kind of hate the chat room fields crap.
18:51:55 <clokep___> But I don't know a better way to do it.
18:53:14 <aleth> Yeah... it came free with libpurple :-/
18:55:42 <-- mpmc has quit (Ping timeout)
18:56:42 --> mpmc has joined #instantbird
19:13:45 --> EionRobb has joined #instantbird
19:13:51 <-- jb has quit (Ping timeout)
19:14:21 <-- sabret00the has quit (Ping timeout)
19:14:42 --> gerard-majax__ has joined #instantbird
19:16:48 <flo-retina> it wasn't free!
19:24:20 <-- FireFly_TB has quit (Ping timeout)
19:28:11 --> sabret00the has joined #instantbird
19:33:26 <clokep___> Yeah, we pretty much re-implemented it.
19:46:30 <-- aleth has quit (Quit: Ciao)
20:07:15 --> kkirill has joined #instantbird
20:22:16 --> jb has joined #instantbird
20:30:29 --> igorko has joined #instantbird
20:44:57 --> sygf87w54 has joined #instantbird
20:45:06 <-- sygf87w54 has quit (User has been banned from Mozilla (no spamming here))
20:53:38 --> FireFly_TB has joined #instantbird
20:55:25 <-- FireFly_TB has quit (Ping timeout)
21:00:15 <-- jb has quit (Input/output error)
21:06:09 --> jb has joined #instantbird
21:21:06 <-- clokep___ has quit (Quit: http://www.mibbit.com ajax IRC Client)
21:31:49 <-- jb has quit (Ping timeout)
21:31:50 --> jb1 has joined #instantbird
21:36:53 <-- gerard-majax__ has quit (Ping timeout)
21:55:45 <-- mpmc has quit (Connection reset by peer)
22:04:38 --> clokep has joined #instantbird
22:04:38 * ChanServ sets mode +o clokep 
22:14:48 <-- dionisos has quit (Ping timeout)
22:27:37 * flo-retina doesn't know where we are about 1.5 stuff
22:31:28 <-- jb1 has quit (Ping timeout)
22:33:04 --> jb has joined #instantbird
22:34:10 <flo-retina> make[1]: *** No rule to make target `/Users/florian/buildhg/hg.instantbird.org/chat/protocols/vkontakte/Makefile.in', needed by `protocols/vkontakte/Makefile'.  Stop.
22:34:10 <flo-retina> pfff
22:35:55 <clokep> make clean on chat and make again.
22:35:57 <clokep> That should do it.
22:37:27 <flo-retina> the problem is obviously the file objdir/chat/backend.mk
22:40:24 <-- qlum has quit (Client exited)
22:40:35 * flo-retina gave up on finding the right make incantation to regenerate that damn file, and just edited backend.mk
22:40:39 --> florian has joined #instantbird
22:41:01 * florian is now known as IRCMonkey29230
22:42:42 <instantbot> florian@instantbird.org granted review for attachment 3107 on bug 2081.
22:42:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2081 min, --, ---, aleth, ASSI, Better handling of navigation keys between the filterbox and listbox
22:47:16 <instantbot> florian@instantbird.org granted review for attachment 3105 on bug 2210.
22:47:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2210 nor, --, ---, aleth, NEW, Stats ids are not set consistently
22:49:21 <flo-retina> my contributions to bringing down the 1.5 list has been mostly focused on doing reviews these days.
22:53:22 <-- sabret00the has quit (Quit: Leaving)
22:53:54 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/52161c10ae08 - aleth - Bug 2081 - Better handling of navigation keys between the filterbox and listbox, r=fqueze.
22:53:55 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/c77bcd2c8c3a - aleth - Bug 2210 - Stats ids are not set consistently, r=fqueze.
22:55:03 <clokep> That's better than mine, which have mostly been heckling and closing bugs. :)
22:55:34 <instantbot> clokep@gmail.com set the Resolution field on bug 2210 to FIXED.
22:55:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2210 nor, --, 1.5, aleth, RESO FIXED, Stats ids are not set consistently
22:55:45 <instantbot> clokep@gmail.com set the Resolution field on bug 2081 to FIXED.
22:55:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2081 min, --, 1.5, aleth, RESO FIXED, Better handling of navigation keys between the filterbox and listbox
22:56:21 <-- kkirill has quit (Ping timeout)
23:01:03 <flo-retina> clokep: well, the problem is the whiteboard of 2 bugs seems to indicate I should patch them... and by the time I'm done with reviews (they get priority as I don't want to block people), I'm out of time/energy :(.
23:27:32 <-- jb has quit (Ping timeout)