All times are UTC.
00:26:15 --> jb has joined #instantbird 00:40:37 <-- jb has quit (Ping timeout) 01:13:29 <-- sabret00the has quit (Ping timeout) 01:29:00 <-- EionRobb has quit (Quit: Leaving.) 01:32:17 --> sabret00the has joined #instantbird 02:04:44 <-- wnayes has quit (Ping timeout) 02:08:09 --> wnayes has joined #instantbird 02:09:20 <-- GeekShadow has quit (Ping timeout) 02:09:29 --> GeekShadow has joined #instantbird 02:45:08 --> mconley has joined #instantbird 03:44:42 <-- dew has quit (Ping timeout) 03:45:25 --> dew has joined #instantbird 03:48:23 <-- dew has quit (Client exited) 03:49:26 --> dew has joined #instantbird 03:56:14 <-- dew has quit (Ping timeout) 03:56:43 --> dew has joined #instantbird 03:58:21 <-- mconley has quit (Input/output error) 04:05:24 <-- dew has quit (Ping timeout) 04:09:59 --> dew has joined #instantbird 04:11:38 <-- dew has quit (Ping timeout) 04:11:58 --> dew has joined #instantbird 04:14:55 <instant-buildbot> build #1038 of linux-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1038 04:26:01 <-- dew has quit (Ping timeout) 04:28:22 --> dew has joined #instantbird 04:32:38 <-- dew has quit (Ping timeout) 04:35:54 --> dew has joined #instantbird 04:40:30 <-- dew has quit (Ping timeout) 04:40:44 --> dew has joined #instantbird 04:43:55 --> dew1 has joined #instantbird 04:44:11 <-- dew has quit (Ping timeout) 04:53:11 <-- dew1 has quit (Ping timeout) 04:53:15 --> dew has joined #instantbird 04:54:58 <-- dew has quit (Ping timeout) 05:00:22 <-- clokep has quit (Ping timeout) 05:40:04 <-- wnayes has quit (Quit: wnayes) 06:00:38 --> EionRobb has joined #instantbird 06:41:07 <instant-buildbot> build #1254 of macosx-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/1254 07:34:31 --> dew has joined #instantbird 07:52:08 <instant-buildbot> build #1175 of win32-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1175 08:51:21 --> jb has joined #instantbird 09:42:45 <-- EionRobb has quit (Quit: Leaving.) 10:08:49 <-- jb has quit (Ping timeout) 10:10:16 <-- skeledrew has quit (Ping timeout) 10:14:07 --> qlum has joined #instantbird 10:15:59 --> skeledrew has joined #instantbird 10:33:33 --> mpmc has joined #instantbird 10:38:29 --> jb has joined #instantbird 10:54:56 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 10:55:00 --> flo-retina has joined #instantbird 10:55:01 * ChanServ sets mode +qo flo-retina flo-retina 11:02:40 <-- jb has quit (Ping timeout) 11:20:28 --> jb has joined #instantbird 11:34:23 <-- jb has quit (Ping timeout) 11:40:21 --> jb has joined #instantbird 11:50:50 <-- jb has quit (Ping timeout) 11:55:34 <-- BWMerlin has quit (Quit: BWMerlin) 12:58:41 --> jb has joined #instantbird 12:59:58 --> gerard-majax__ has joined #instantbird 14:01:28 --> clokep has joined #instantbird 14:01:28 * ChanServ sets mode +o clokep 14:03:35 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 14:03:43 --> clokep has joined #instantbird 14:03:43 * ChanServ sets mode +o clokep 14:14:33 <-- jb has quit (Ping timeout) 14:47:06 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 14:47:14 --> clokep has joined #instantbird 14:47:14 * ChanServ sets mode +o clokep 15:04:58 <-- dew has quit (Ping timeout) 15:05:10 --> dew has joined #instantbird 15:24:05 --> FireFly_TB has joined #instantbird 15:50:48 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 16:05:10 --> aleth has joined #instantbird 16:05:11 * ChanServ sets mode +h aleth 16:12:29 <-- FireFly_TB has quit (Ping timeout) 16:16:02 --> FireFly_TB has joined #instantbird 16:22:26 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 3104 on bug 2210. 16:22:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2210 nor, --, ---, aleth, NEW, Stats ids are not set consistently 16:44:07 --> mconley has joined #instantbird 16:55:16 <-- mconley has quit (Input/output error) 16:56:25 <flo-retina> time for a look at the review queue I guess ;) 17:02:27 <instantbot> florian@instantbird.org granted review for attachment 3097 on bug 2258. 17:02:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2258 nor, --, ---, aleth, ASSI, Log sweeping code should close its iterators and handle errors better 17:08:12 <instantbot> florian@instantbird.org denied review for attachment 3100 on bug 2261. 17:08:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2261 min, --, ---, aleth, NEW, Contact list context menu broken over the drop target 17:10:44 <instantbot> florian@instantbird.org granted review for attachment 3101 on bug 1498. 17:10:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1498 nor, --, ---, aleth, ASSI, "this.buddy is undefined" on merging two IRC buddies 17:13:37 --> mconley has joined #instantbird 17:15:21 <flo-retina> aleth: re bug 2262; too bad you couldn't reproduce the first issue any more. It's the one that frequently annoys me :( 17:15:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2262 nor, --, ---, aleth, ASSI, Buddy disappears when detached in the Other Contacts tag 17:16:02 <flo-retina> (and I just verified that on my default profile adding a non hidden tag to "aleth" makes "aleth" appear in that group, but doesn't make "aleth" disappear from the 'Other Contacts' group 17:16:03 <flo-retina> ) 17:19:02 <aleth> If you can reliably reproduce that, maybe you can fix it (or file a bug with detailed STR)? 17:21:39 <flo-retina> I don't see which step to reproduce may be missing 17:21:51 <flo-retina> I'm more interested in ways to _not_ reproduce ;) 17:22:03 <aleth> I can't reproduce it at all. 17:25:07 <instantbot> florian@instantbird.org denied review for attachment 3102 on bug 2262. 17:25:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2262 nor, --, ---, aleth, ASSI, Buddy disappears when detached in the Other Contacts tag 17:25:10 <flo-retina> you are lucky? :) 17:26:55 <flo-retina> would be nice to have nhnt11 have a look at the patch in bug 2210 :-/ 17:26:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2210 nor, --, ---, aleth, NEW, Stats ids are not set consistently 17:27:10 <aleth> Yes :-/ 17:27:40 <aleth> Though I don't think it's risky, it just normalizeNames all the time rather than half the time ;) 17:28:46 <flo-retina> normalized risk? ;) 17:28:56 <aleth> yeah ;) 17:29:11 <flo-retina> I guess I just need to wrap my head around it 17:29:12 <aleth> Main risk is I missed something ;) 17:29:46 <flo-retina> I've never been able to understand what that bug is trying to fix :-[ 17:29:58 <flo-retina> so I hope looking at the patch will clarify it! 17:31:00 <aleth> Basically if you don't reliably generate the same id for the same prplConv then you'll end up with stats entries that are duplicate/incomplete/not found 17:32:17 <aleth> Stuff like conversations with ids based on "Mic" not being found as the contact's normalizedName is "mic"... 17:33:22 <flo-retina> so you mean Mic could never appear high in the stats? 17:33:46 <aleth> Yep. 17:34:24 <flo-retina> are you convinced the getIter stuff there isn't just obfuscation? 17:35:05 <aleth> It's "huh, why doesn't getIter work? How annoying, I'll have to copy paste its code" 17:35:38 <flo-retina> I think the plan is to kill getIter wherever possible 17:35:48 <flo-retina> getAccounts should return an array, not an enumerator 17:35:50 <aleth> Possibly obfuscating in the end result, but what's really annoying is that enumerators are not iterable 17:36:03 <flo-retina> but it's difficult to fix as that breaks stuff in Ib/Tb/add-ons 17:36:11 <flo-retina> so we'll likely need to add another method with a different name 17:36:37 <flo-retina> I would definitely be happy to put a bounty on killing http://lxr.instantbird.org/instantbird/source/instantbird/content/utilities.js ;) 17:36:51 <aleth> Yes :) 17:38:38 <flo-retina> there are only 5 XUL files that include it ;) 17:39:18 <aleth> Do you know why getIter is needed in the first place? i.e. why can't one make simpleEnumerators JS-iterable? 17:40:25 <flo-retina> the if (!name) { dance is for backward compat with existing logs? 17:40:34 <aleth> Yes. 17:40:54 <flo-retina> needs a comment saying it appeared with 1.5 17:42:20 <flo-retina> the account map is used only for the backward compat case. Maybe it would want to be a lazy getter? 17:42:50 <flo-retina> probably not really important; building it shouldn't be slow 17:43:07 <aleth> Is it worth it? It's short and only exists during log sweeping 17:45:17 <flo-retina> no 17:46:14 <flo-retina> aren't the changes in PossibleConvFromContact causing .id to be recomputed plenty of times? 17:50:41 <aleth> No, that id is never used as far as I can tell. The getter is there just in case (it's in the interface) 17:51:37 <aleth> 06:45:27 PM - aleth: Why aren't nsIsimpleEnumerators JS-iterable? 06:49:05 PM - Ms2ger: Nobody wants to touch 15-year old xpcom code? 17:52:13 <flo-retina> I don't think it's 15 year old 17:52:26 <flo-retina> it's xpconnect, and it's been hacked in all sorts of crazy ways several times ;) 17:53:19 <aleth> yeah, I was expecting some answer to do with wrappers ;) 18:00:01 <instantbot> florian@instantbird.org denied review for attachment 3104 on bug 2210. 18:00:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2210 nor, --, ---, aleth, NEW, Stats ids are not set consistently 18:01:42 <instantbot> florian@instantbird.org cancelled review?(florian@instantbird .org) for attachment 3048 on bug 2113. 18:01:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2113 nor, --, 1.5, florian, REOP, Buddy tooltips have incorrect sizes 18:03:16 <-- FireFly_TB has quit (Ping timeout) 18:05:58 <clokep> Killing lots of reviews. ;) 18:08:02 --> FireFly_TB has joined #instantbird 18:14:05 <instantbot> florian@instantbird.org granted feedback for attachment 3059 on bug 2081. 18:14:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2081 min, --, ---, nhnt11, ASSI, Better handling of navigation keys between the filterbox and listbox 18:14:36 <instantbot> aleth@instantbird.org requested review from nhnt11@gmail.com for attachment 3105 on bug 2210. 18:14:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2210 nor, --, ---, aleth, NEW, Stats ids are not set consistently 18:15:05 <flo-retina> clokep: I think I've now removed from my queue everything that was either smallish, or related to 1.5. 18:15:49 <clokep> flo-retina: Nice. :) Making some progress then. 18:16:21 <flo-retina> I'll now be looking for motivation to fix one of the 1 or 2 1.5-bugs where I need to write the patch ;) 18:18:53 * clokep bestows motivation unto you. 18:20:53 * flo-retina wonders if aleth writes InstantBird 18:21:13 <aleth> what? where? 18:21:27 <flo-retina> // normalizedName was added for IB 1.5 18:25:02 <aleth> s/IB/I 18:25:28 <flo-retina> bug 1498 had my oldest pending review request :-) 18:25:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1498 nor, --, ---, aleth, ASSI, "this.buddy is undefined" on merging two IRC buddies 18:25:36 <clokep> You shouldn''t reference Instantbird in chat/ code parts. 18:28:01 <flo-retina> where have we done that? 18:28:54 <flo-retina> clokep: ^^^ 18:29:05 <clokep> flo-retina: I'm asking if you are. 18:29:16 <clokep> I have no idea where that comment you're referencing is. 18:29:17 <flo-retina> clokep: that comment is in the stats service 18:29:22 <clokep> OK. 18:38:16 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 3106 on bug 2262. 18:38:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2262 nor, --, ---, aleth, ASSI, Buddy disappears when detached in the Other Contacts tag 18:43:10 <instantbot> aleth@instantbird.org cancelled review?(benediktp@ymail.com ) for attachment 3059 on bug 2081. 18:43:11 <instantbot> aleth@instantbird.org requested review from benediktp@ymail.com for attachment 3107 on bug 2081. 18:43:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2081 min, --, ---, aleth, ASSI, Better handling of navigation keys between the filterbox and listbox 18:46:32 <flo-retina> aleth: shouldn't we send the "added" notification after setting the tags correctly on the contact? 18:46:34 <instantbot> New Instantbird (UI) bug 2263 filed by aleth@instantbird.org. 18:46:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2263 nor, --, ---, nobody, NEW, Tabbrowser conversations property assumes all tabs have linkedConversations 18:46:41 <flo-retina> this is a real question; I'm not sure. 18:47:04 <aleth> Hmm. I'm not sure either. 18:47:34 <flo-retina> will the "otherContacts" code iterate over all the tags of the contact? 18:47:59 <aleth> contact.addTag sends contact-tag-added 18:48:05 <flo-retina> it will! http://lxr.instantbird.org/instantbird/source/chat/components/src/imContacts.js#291 18:50:12 <aleth> So, it works either way. 18:50:54 <aleth> It seems strange to send contact-added after contact-added somehow? 18:57:56 <flo-retina> you mean after tag added? 18:57:56 <aleth> Uh, that should have been "contact-added after contact-tag-added" 18:58:20 <flo-retina> what's sending tag added? Can/should we skip it? 18:58:43 <aleth> http://lxr.instantbird.org/instantbird/source/chat/components/src/imContacts.js#714 18:58:47 <flo-retina> hmm, which events are used by the buddy list window to show the new contacts? :) 18:59:06 <flo-retina> so it's http://lxr.instantbird.org/instantbird/source/chat/components/src/imContacts.js#461 ? 18:59:20 <flo-retina> this code is all so complicated :( 19:21:09 --> EionRobb has joined #instantbird 19:39:55 --> nhnt11 has joined #instantbird 19:46:03 --> jb has joined #instantbird 19:46:59 <nhnt11> aleth, flo-retina: I took a look at the patch for bug 2210, didn't see anything obviously wrong with it. 19:47:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2210 nor, --, ---, aleth, NEW, Stats ids are not set consistently 19:48:04 <aleth> :) 19:48:21 <nhnt11> Was there anything specifically that you wanted my opinion on? 19:48:42 <aleth> I think flo put his questions in the bug. 19:48:46 <nhnt11> (I did see the bit about changing the id's of PossibleConvFromContacts to a getter) 19:49:44 <aleth> Mainly I just wanted a second pair of eyes (are there any instances which should be changed that I missed) 19:50:37 <nhnt11> I agree that Services.accounts.getAccountByName(aNormalizedName) would be nice, btw 20:01:32 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 20:19:07 <-- jb has quit (Ping timeout) 20:19:32 --> jb has joined #instantbird 20:25:01 <-- jb has quit (Ping timeout) 20:26:47 --> jb has joined #instantbird 20:32:17 <-- jb has quit (Ping timeout) 20:57:25 <-- aleth has quit (Quit: Ciao) 21:18:52 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 21:30:33 --> wnayes has joined #instantbird 21:43:23 --> jb has joined #instantbird 22:04:15 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 22:14:50 <-- dew has quit (Ping timeout) 22:17:54 --> dew has joined #instantbird 22:21:51 <-- dew has quit (Ping timeout) 22:22:26 --> dew has joined #instantbird 22:28:35 <-- dew has quit (Ping timeout) 22:29:07 --> dew has joined #instantbird 22:55:22 <-- jb has quit (Ping timeout) 22:58:36 <-- FireFly_TB has quit (Input/output error) 23:18:38 <instantbot> florian@instantbird.org granted review for attachment 3106 on bug 2262. 23:18:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2262 nor, --, ---, aleth, ASSI, Buddy disappears when detached in the Other Contacts tag 23:22:21 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/7882528028ea - aleth - Bug 2258 - Log sweeping code should close its iterators and handle errors better, r=fqueze. 23:22:23 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/23b989438ddc - aleth - Bug 2262 - Buddy disappears when detached in the Other Contacts tag, r=fqueze. 23:22:24 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/1752ef472615 - aleth - Bug 1498 - 'this.buddy is undefined' error when dropping a buddy on a contact's drop target, r=fqueze. 23:22:25 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/011df1026413 - aleth - Bug 2260 - Fix the getNormalizedName stub in nsContextMenu, r=fqueze. 23:31:17 <instantbot> clokep@gmail.com set the Resolution field on bug 2262 to FIXED. 23:31:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2262 nor, --, 1.5, aleth, RESO FIXED, Buddy disappears when detached in the Other Contacts tag 23:31:58 <instantbot> clokep@gmail.com set the Resolution field on bug 2258 to FIXED. 23:31:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2258 nor, --, 1.5, aleth, RESO FIXED, Log sweeping code should close its iterators and handle errors better 23:33:01 <instantbot> clokep@gmail.com set the Resolution field on bug 1498 to FIXED. 23:33:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1498 nor, --, 1.5, aleth, RESO FIXED, "this.buddy is undefined" on merging two IRC buddies 23:33:41 <instantbot> clokep@gmail.com set the Resolution field on bug 2260 to FIXED. 23:33:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2260 nor, --, 1.5, aleth, RESO FIXED, Fix the getNormalizedName stub in nsContextMenu 23:33:56 --> jb has joined #instantbird 23:38:30 <-- mconley has quit (Input/output error)