All times are UTC.
01:16:41 --> dew1 has joined #instantbird 01:17:40 <-- dew has quit (Ping timeout) 01:19:27 --> gerard-majax_ has joined #instantbird 01:59:17 <-- gerard-majax_ has quit (Ping timeout) 02:12:36 <-- GeekShadow has quit (Ping timeout) 02:12:38 --> GeekShadow has joined #instantbird 02:25:43 --> mconley has joined #instantbird 03:34:06 <-- mconley has quit (Input/output error) 03:34:35 --> gerard-majax_ has joined #instantbird 03:36:30 <-- gerard-majax_ has quit (Ping timeout) 03:45:25 <-- EionRobb has quit (Quit: Leaving.) 03:50:58 --> gerard-majax_ has joined #instantbird 04:02:37 <instant-buildbot> build #1025 of linux-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1025 04:46:53 <-- wnayes has quit (Quit: wnayes) 04:47:47 <-- dew1 has quit (Ping timeout) 04:47:56 --> dew has joined #instantbird 04:49:39 <-- dew has quit (Ping timeout) 04:49:57 --> dew has joined #instantbird 04:53:46 <-- dew has quit (Ping timeout) 04:54:10 --> dew has joined #instantbird 05:09:01 <-- dew has quit (Ping timeout) 05:09:12 --> dew has joined #instantbird 05:17:30 <-- dew has quit (Ping timeout) 05:19:23 --> dew has joined #instantbird 05:24:00 <-- dew has quit (Ping timeout) 05:24:54 --> dew has joined #instantbird 05:40:51 <-- dew has quit (Ping timeout) 05:42:28 --> dew has joined #instantbird 05:46:12 <-- dew has quit (Ping timeout) 05:46:19 --> dew has joined #instantbird 05:48:49 <-- dew has quit (Connection reset by peer) 05:48:52 --> dew1 has joined #instantbird 05:54:31 <-- dew1 has quit (Ping timeout) 05:54:40 <instantbot> New Instantbird (UI) bug 2238 filed by bragonavt@mail.ru. 05:54:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2238 min, --, ---, nobody, UNCO, custom smiles with asterisks in replacing string (e.g. *ROFL*) aren't showing 05:55:23 --> dew has joined #instantbird 05:58:31 <-- gerard-majax_ has quit (Ping timeout) 06:01:54 <-- dew has quit (Ping timeout) 06:02:00 --> dew has joined #instantbird 06:03:47 <-- dew has quit (Ping timeout) 06:03:51 --> dew has joined #instantbird 06:06:22 <-- dew has quit (Client exited) 06:07:57 --> dew has joined #instantbird 06:12:40 <-- dew has quit (Ping timeout) 06:12:53 --> dew has joined #instantbird 06:23:34 <-- dew has quit (Ping timeout) 06:24:54 --> dew has joined #instantbird 06:29:43 <-- dew has quit (Ping timeout) 06:29:56 --> dew has joined #instantbird 06:31:35 <-- dew has quit (Ping timeout) 06:32:26 --> dew has joined #instantbird 06:36:23 <-- dew has quit (Ping timeout) 06:37:38 --> nhnt11 has joined #instantbird 06:43:34 --> dew has joined #instantbird 07:35:53 --> GeKo has joined #instantbird 07:40:22 --> dionisos has joined #instantbird 07:40:30 <instant-buildbot> build #1148 of win32-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1148 07:59:25 --> mpmc has joined #instantbird 08:01:57 <-- dionisos has quit (Ping timeout) 08:04:13 --> dionisos has joined #instantbird 08:05:32 <-- nhnt11 has quit (Ping timeout) 08:47:46 --> chrisccoulson has joined #instantbird 09:25:00 --> jb has joined #instantbird 09:31:59 --> BWMerlin has joined #instantbird 09:45:38 <-- dionisos has quit (Ping timeout) 09:54:15 --> Mic has joined #instantbird 09:54:15 * ChanServ sets mode +h Mic 09:54:31 --> nhnt11 has joined #instantbird 09:59:05 --> aleth has joined #instantbird 09:59:06 * ChanServ sets mode +h aleth 09:59:40 <aleth> "There are no updates available" :( 10:00:12 <aleth> Trying to download by hand gives "You don't have permission to access /instantbird/nightly/latest-trunk/instantbird-1.5a1pre.en-US.linux-i686.tar.bz2 on this server." 10:02:07 <instantbot> aleth@instantbird.org granted review for attachment 3011 on bug 2205. 10:02:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2205 nor, --, ---, benediktp, ASSI, Error from log sweeping with a fresh profile 10:07:45 <-- aleth has quit (Quit: Ciao) 10:08:31 --> aleth has joined #instantbird 10:08:31 * ChanServ sets mode +h aleth 10:27:04 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 10:27:33 --> Mic has joined #instantbird 10:27:34 * ChanServ sets mode +h Mic 10:28:48 <aleth> Mic: Could you get the latest nightly or is it just me/Linux/...? 10:29:40 <Mic> I just updated to the latest using the updater. 10:29:42 * aleth suspects it's just Linux 10:30:03 <aleth> I can also download the Windows update from the ftp server ;) 10:30:37 <aleth> If it's just a permissions issue, it should at least be easy to fix. 11:19:00 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 11:20:14 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 11:20:20 --> nhnt11 has joined #instantbird 11:21:04 <-- jb has quit (Quit: jb) 11:21:10 --> jb has joined #instantbird 11:21:50 --> dionisos has joined #instantbird 11:24:12 <-- GeKo has quit (Ping timeout) 11:24:14 --> jb1 has joined #instantbird 11:25:41 <-- jb has quit (Ping timeout) 11:26:16 --> GeKo has joined #instantbird 11:27:52 <-- dionisos has quit (Ping timeout) 11:29:48 <-- nhnt11 has quit (Ping timeout) 11:31:59 --> flo-retina has joined #instantbird 11:32:00 * ChanServ sets mode +qo flo-retina flo-retina 11:32:27 <aleth> clokep_work: I got this today during startup: "Unhandled IRC message: ":concrete.mozilla.org 477 aleth #ux :You need a registered nick to join that channel." Should we wait with joining channels until identification is complete? 11:32:28 <flo-retina> bah, no new mac nightly :( 11:33:13 <flo-retina> aleth: http://log.bezut.info/instantbird/today#m84 We've never been able to make the Linux buildbot slave upload files with the same permissions as the other 2 slaves in the past 11:34:28 <flo-retina> Windows uploads with 644, Linux with 660 :-S 11:35:17 <aleth> So you need a script to chmod after uploading? :-| 11:35:26 <flo-retina> aleth: you should be able to download them now 11:35:41 <flo-retina> but that's not a real fix, I just changed the permissions of the last few linux nightlies 11:35:58 <flo-retina> aleth: if we really can't figure it out, yes, we'll need to do something like that :-S 11:36:34 <aleth> What command are you using to upload? 11:37:16 <-- aleth has quit (Quit: Ciao) 11:38:02 --> aleth has joined #instantbird 11:38:02 * ChanServ sets mode +h aleth 11:42:47 <aleth> You could use rsync (iirc it allows you to set the mode after transfer) 11:43:35 <aleth> 660 is probably just the default umask on the server 11:46:02 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 11:47:45 <flo-retina> aleth: scp 11:48:22 <flo-retina> aleth: if we were getting the default umask of the server, it should be the same for all OSes, right? 11:48:35 <flo-retina> aleth: I think we are somehow annoyed by the default umask of the linux build slave 11:48:48 <flo-retina> but our attempts to change it in the past haven't been very successful IIRC 11:48:49 <aleth> flo-retina: Not if the program you're using for Windows sets the mode by hand 11:49:03 <flo-retina> aleth: you are assuming we are using a different program for Windows ;) 11:49:09 <aleth> yes ;) 11:49:11 <flo-retina> aleth: it's scp everywhere, with the exact same command line 11:51:20 <aleth> Are you using scp -p ? 11:54:19 <flo-retina> I don't think so 11:54:28 <flo-retina> aleth: you can look at the "distribute" logs on buildbot to see what we use 11:55:43 <aleth> Using scp -p would preserve the permissions of the source. 11:56:20 <aleth> flo-retina: Right, that flag is not set atm. 12:00:00 <flo-retina> aleth: so how do you explain we have different permissions for windows/mac and for linux? 12:00:40 <aleth> flo-retina: I find that very strange ;) 12:00:54 <aleth> Without -p you'd expect the permissions to match. 12:01:22 <flo-retina> aleth: also, the windows .exe file gets +x automatically 12:06:42 <aleth> flo-retina: There's also a line scp -t /www/instantbird/socorro/symbols/... which is odd because afaik scp has no -t parameter 12:07:08 <flo-retina> :-D 12:07:21 <aleth> So I wonder what the intention was there ;) 12:07:57 <flo-retina> aleth: that's a debug message from scp, not a command line 12:08:20 <flo-retina> aleth: we put scp in verbose mode in the hope that it would output some stuff that would help prevent buildbot from timeing out 12:08:45 <flo-retina> that turned out to not be very successful as it outputs a lot of junk at the start of the transfer, and nothing during the actually transfer :( 12:09:50 <flo-retina> oh wait, looks like we didn't do this here 12:09:52 <flo-retina> it's on mozilla-central 12:10:08 <flo-retina> aleth: http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/crashreporter/tools/upload_symbols.sh#34 scp -oLogLevel=DEBUG 12:11:06 <aleth> scp needs an optional ascii progress bar? :P 12:11:22 <flo-retina> it does! 12:11:52 <flo-retina> just printing a '.' for every transferred MB would be super useful 12:12:18 <aleth> I suppose it just does it after each completed file. 12:12:18 <flo-retina> but we have now bumped the timeouts to 7200s, so one would hope that most uploads fit within that timeframe :) 12:12:41 <flo-retina> (it's only for localized RCs that we have upload timeout problems, as we uploades <number of locates> times the usual amount of data) 12:12:53 <flo-retina> aleth: even that would be useful! 12:13:05 <flo-retina> aleth: unfortunately it doesn't if there's no tty :( 12:13:21 <aleth> That's unfortunate :( 12:16:33 <aleth> flo-retina: Have you tried setting SSH_SCP_STATS or SSH_ALL_SCP_STATS ? 12:16:40 <flo-retina> no 12:16:45 <aleth> Or is that also tty only 12:17:06 <flo-retina> if there's a strong likelihood that it would work, that's interesting ;) 12:17:38 * aleth googles 12:17:41 <flo-retina> although I don't expect to upload-timeout again, as I've got 5MBps for the upload 12:17:56 <flo-retina> err, 5Mbps, not MB :( 12:18:11 * flo-retina would like to know what happened to the mac build slave 12:18:12 <aleth> Section 4.1.5.11 in http://docstore.mik.ua/orelly/networking_2ndEd/ssh/ch04_01.htm#ch04-44842.html 12:19:49 <flo-retina> so it says |scp -Q -a| should do 12:21:05 <flo-retina> scp: illegal option -- Q 12:21:07 <aleth> I don't have a -Q (and -q does the opposite of what you want) but maybe... 12:21:48 <aleth> The environment variables I mentioned are SSH options, scp just follows them 12:21:54 <flo-retina> aleth: in http://docstore.mik.ua/orelly/networking_2ndEd/ssh/ch07_05.htm#ch07-80825.html 12:22:04 <flo-retina> look at "Table 7-4" 12:22:25 <flo-retina> in the first line there's a note [112] saying "Also works for OpenSSH's scp client." 12:22:37 <flo-retina> so it looks like all this documentation is not for OpenSSH's scp but for "something else" :-S 12:22:40 <aleth> Ah. 12:23:04 <aleth> Maybe our scp wasn't built with the with-scp-stats flag ;) 12:23:43 <flo-retina> I wonder if this is about a GNU ssh, or something 12:24:37 <flo-retina> aleth: http://docstore.mik.ua/orelly/networking_2ndEd/ssh/ch04_01.htm 12:30:04 <clokep_work> aleth: Interesting. 12:30:16 <clokep_work> Do we know ahead of time that you need to be registered to join a channel? 12:32:01 <aleth> clokep_work: It's channel mode R or r (or both for #ux) but we only get those after joining 12:32:41 <clokep_work> Yeah... 12:32:48 * clokep_work isn't sure right now... 12:33:12 <aleth> Also those modes mean different things on different servers :-S 12:35:01 <aleth> flo-retina: openSSH claims to support a scp progress meter 12:35:22 <-- flo-retina has quit (Ping timeout) 12:36:27 <aleth> http://thr3ads.net/openssh-bugs/2008/04/1165135-Bug-1265-SCP-progress-doesnt-map-to-standard-out-or-standard-error 12:37:55 <aleth> Sorry, I meant to link to the bug, but the link is in there 12:40:25 <-- BWMerlin has quit (Quit: BWMerlin) 12:40:26 <aleth> Looks like it will only show it for ttys though 12:48:05 * clokep_work has a friend interested in fixing bug 440. 12:48:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=440 enh, --, ---, nobody, NEW, MUC option: Hide certain system messages 12:49:06 <clokep_work> Little does he know he'll need to fix bug 1230 first! :P 12:49:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1230 nor, --, ---, nobody, NEW, Join/part messages should be handled by imConversations.js. 12:49:12 * clokep_work is now known as clokep 12:49:17 <aleth> Hopefully not like the screenshot provided ;) https://bugzilla.instantbird.org/attachment.cgi?id=432 12:51:33 <clokep> Wow, yes. That's confusing. 12:57:06 --> gerard-majax_ has joined #instantbird 12:58:52 * clokep is now known as clokep_work 12:58:56 <-- gerard-majax_ has quit (Ping timeout) 13:05:54 --> flo-retina has joined #instantbird 13:05:54 * ChanServ sets mode +qo flo-retina flo-retina 13:06:55 --> dionisos has joined #instantbird 13:09:30 <flo-retina> I'm not exactly sure of what bug 440 is requesting. 13:09:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=440 enh, --, ---, nobody, NEW, MUC option: Hide certain system messages 13:09:40 <flo-retina> clokep_work: do you know what your friends wants exactly? 13:10:01 <flo-retina> hmm, I guess i need to get http://ftp.instantbird.com/instantbird/stats/ fixed on the new server :-S 13:12:40 <clokep_work> flo-retina: He wants to hide joints/parts which is what that bug is asking for. 13:13:31 --> gerard-majax_ has joined #instantbird 13:14:32 * aleth is looking at bug 1454 13:14:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1454 nor, --, ---, clokep, ASSI, normalizedName for JS-IRC is wrong 13:15:16 <aleth> flo-retina: I don't understand why normalizedNames should not include "special characters" given that we already have http://lxr.instantbird.org/instantbird/source/chat/components/src/logger.js#36 13:15:42 <clokep_work> aleth: I agree 100%. 13:15:46 <aleth> Stripping special characters conflicts with the goal of being able to use normalizedNames as unique identifiers 13:16:30 <aleth> I don't see a way to fix these bugs otherwise. Something has to give, and I think it should be the no-special-characters "rule". 13:17:08 <clokep_work> I agree that it is the responsibility of the logger (and the chat backend, not prpls) to handle how special characters are handled. 13:17:40 <aleth> The default normalizedName in jsProtoHelper is crazy. 13:18:01 <aleth> Thankfully currently everything apart from twitter overrides it ;) 13:18:52 <-- gerard-majax_ has quit (Ping timeout) 13:18:58 --> gerard-majax_ has joined #instantbird 13:19:41 <clokep_work> And Twitter is ASCII only. ;) 13:19:44 --> gerard-majax__ has joined #instantbird 13:20:51 <-- gerard-majax_ has quit (Ping timeout) 13:34:57 <-- gerard-majax__ has quit (Ping timeout) 13:45:30 <flo-retina> aleth: I don't think there ever was a 'no special character rule'. We just need to ensure characters commonly found in paths aren't included (ie. '/', '\', ':') and then it's up to the prpl to do whatever it wants 13:46:39 <flo-retina> aleth: "The default normalizedName in jsProtoHelper is crazy." I was never meant to be the best implementation ever. It was just written quickly because JS prpls couldn't rely on libpurple stuff for normalization any more. 13:46:46 <aleth> flo-retina: OK then :) 13:47:15 <aleth> Though I think worrying about /,\,: should be done in logger.js (and in fact already is) 13:47:36 <flo-retina> aleth: it was kindof expected that most prpls that are no longer at the prototype/experiment stage would override the default implementation with something more specific. 13:47:45 <flo-retina> aleth: it wasn't at the time! 13:47:55 <aleth> flo-retina: aha! :D 13:49:19 <aleth> That explains why some older comments on those bugs maybe don't make sense anymore. 13:50:56 <aleth> Right, encodeName() in logger.js was added less than a year ago. 13:51:22 <flo-retina> yeah, I still remember some of the history of the project ;) 13:52:14 <aleth> Thankfully :) 13:53:26 * aleth will try to get those bugs fixed before 1.5 14:06:35 * flo-retina is confused by the state of 1.5 14:06:56 <flo-retina> at the current rate of progress, it looks like a release won't happen before January :( 14:07:14 * flo-retina would prefer it to happen this month (November) :-/ 14:07:58 <flo-retina> maybe we just need to adopt a train model and have releases happen 'automatically' 14:19:24 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 3013 on bug 1983. 14:19:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1983 nor, --, ---, aleth, ASSI, Default normalizedName normalization is too aggressive 14:34:47 --> mconley has joined #instantbird 14:34:58 <-- mconley has quit (Input/output error) 14:39:57 --> mconley has joined #instantbird 14:50:00 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 3014 on bug 1454. 14:50:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1454 nor, --, ---, clokep, ASSI, normalizedName for JS-IRC is wrong 14:50:49 <flo-retina> aleth: shouldn't the default normalize still remove spaces? 14:50:57 <aleth> flo-retina: What for? 14:52:15 <aleth> If we are worried about spaces in filenames we should check for that in logger.js. Or is there another reason? 14:52:20 <flo-retina> not fully sure it makes sense. The example I had in mind was the AIM case 14:52:41 <flo-retina> but maybe that's for an AIM specific get normalizedName implementation :-S 14:53:24 <flo-retina> aleth: if we make the default as simple as .toLowerCase(), I don't really see the point of having this function any more. It could just be inlined... 14:54:17 <aleth> flo-retina: It seems useful to show that the default is to use the same normalization for account/conversation/buddy names. 14:54:54 <flo-retina> it's not necessarily the same for conversations 14:55:00 <flo-retina> I don't think that adds much value 14:55:06 <aleth> This was certainly something which I wasn't sure about the first time I encountered this stuff. 14:55:14 <flo-retina> if it's for the sake of documentation, shouldn't that be comments in the idl files? 14:55:24 <aleth> That's the other bug ;) 14:55:53 <aleth> But it isn't really documentation, it's a default implementation. 14:56:21 <instantbot> clokep@gmail.com denied review for attachment 3013 on bug 1983. 14:56:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1983 tri, --, ---, aleth, ASSI, Default normalizedName normalization is too aggressive 14:56:36 <flo-retina> abstracting a function that does almost nothing is almost obfuscation :P 14:57:28 <aleth> Showing that normalize() need do almost nothing is not obfuscation :P 14:58:24 <instantbot> clokep@gmail.com granted review for attachment 3014 on bug 1454. 14:58:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1454 nor, --, ---, clokep, ASSI, normalizedName for JS-IRC is wrong 15:00:45 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 3014 on bug 1454. 15:00:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1454 tri, --, ---, clokep, ASSI, Add explanatory comments to document normalizedNames 15:02:17 <flo-retina> aleth: moving it away in another function is not showing it "need do almost nothing" 15:03:01 <flo-retina> "changing the current normalization for twitter would mean *nobody* will find their twitter logs anymore." doesn't this also apply for IRC? 15:03:22 <aleth> flo-retina: With the patch in bug 1454, we aren't making any changes to IRC anymore. 15:03:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1454 tri, --, ---, clokep, ASSI, Add explanatory comments to document normalizedNames 15:04:08 <aleth> flo-retina: If you prefer to inline normalize(), that's OK with me. I just thought it might be useful the way it is 15:04:12 <flo-retina> aleth: hmm, ok. Seems I need to look at all the patche of the normalized name equation before commenting more ;) 15:04:39 <flo-retina> aleth: if we really make it do only .toLowerCase, I prefer inlining it, yes ;) 15:10:26 <flo-retina> "Let's not make the history more confusing." ahah :) 15:14:28 * flo-retina wonders why aleth adds r? and [checkin-needed] at the same time 15:15:06 <aleth> Uh, didn't I remove the checkin-needed? I changed my mind and went for r? instead ;) 15:16:14 <flo-retina> aleth: did you mean to also improve http://lxr.instantbird.org/instantbird/source/chat/components/public/prplIConversation.idl#31 ? 15:16:33 <flo-retina> aleth: according the the timestamps of my bugmail, you added checkin-needed after the r? :-P 15:16:58 <flo-retina> according to https://bugzilla.instantbird.org/show_activity.cgi?id=1454 too 15:17:00 <aleth> flo-retina: Yes, but it wasn't intentional. 15:17:05 <flo-retina> ok :) 15:17:27 <-- dionisos has quit (Ping timeout) 15:17:36 <aleth> flo-retina: Looks like we missed that one, thanks 15:24:49 <-- Tonnes has quit (Connection reset by peer) 15:33:45 --> dionisos has joined #instantbird 15:37:36 --> Tonnes has joined #instantbird 15:47:57 <instantbot> aleth@instantbird.org cancelled review?(florian@instantbird .org) for attachment 3014 on bug 1454. 15:47:58 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 3015 on bug 1454. 15:47:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1454 tri, --, ---, clokep, ASSI, Add explanatory comments to document normalizedNames 15:52:00 <instantbot> aleth@instantbird.org cancelled review?(florian@instantbird .org) for attachment 3013 on bug 1983. 15:52:01 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 3016 on bug 1983. 15:52:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1983 tri, --, ---, aleth, ASSI, Default normalizedName normalization is too aggressive 16:03:06 <flo-retina> aleth: do you have 1.6-plans for the completion? :) 16:04:26 <-- jb1 has quit (Ping timeout) 16:05:18 <aleth> I kind of consider moving the current code to a module and adding tests to be blocking new completion features, so I'd have to do that first. I've got a tab open somewhere about XUL editors to see if that would allow us to replace the textbox with something that allows prettier display options, but I haven't read it yet ;) 16:07:01 <aleth> If I have the time, top of my 1.6 list would be "scroll upwards to add context from logs" I think 16:09:50 <aleth> Though there's other things that might be more useful... 16:10:16 <flo-retina> "moving the current code to a module" that's already a large piece. 16:10:24 <flo-retina> are there dependencies we can extract from it? 16:10:44 <aleth> There are lots of dependencies to conversation.xml and the textbox in particular 16:10:46 <flo-retina> eg. Should we remember the list of active participants inside imConversations.js instead of the UI? 16:11:55 <aleth> Hmm, maybe. 16:12:50 <flo-retina> I was wondering if we shouldn't move the 'find the list of completions' stuff to a component (the same as the one I was tinkering with this week-end for example), and the 'tinker with the input box' part to a module 16:13:16 <aleth> Those are not trivial to separate out in the current code. 16:13:30 <flo-retina> having the list of active participants in the convs service could be interesting for the awesometab too (wouldn't we be more likely to start a private conversation with active participants? :)) 16:13:49 <flo-retina> aleth: I know. But I was wondering if separating these 2 parts wouldn't make the whole thing way easier to understand 16:14:51 <aleth> It might. The issue is that I'm afraid to make too many changes before there are tests. 16:15:09 <flo-retina> aleth: the point of this is that these 2 parts could be tested independently ;) 16:15:32 <flo-retina> s/the point of/an interesting thing about/ 16:18:23 <aleth> I'm not sure how much of the logic for nicks would generalize to generic words anyway. 16:19:38 <aleth> Maybe it would, I've not really thought it through. 16:20:26 <aleth> I totally agree that it would be nice to be able to make the separation you are talking about. 16:22:32 <-- dionisos has quit (Ping timeout) 16:24:49 <instantbot> aleth@instantbird.org cancelled review?(florian@instantbird .org) for attachment 3015 on bug 1454. 16:24:50 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 3017 on bug 1454. 16:24:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1454 tri, --, ---, clokep, ASSI, Add explanatory comments to document normalizedNames 17:23:04 --> wnayes has joined #instantbird 17:37:48 --> gerard-majax__ has joined #instantbird 17:37:50 --> jb has joined #instantbird 17:40:16 <-- gerard-majax__ has quit (Ping timeout) 17:50:44 <instantbot> clokep@gmail.com requested review from clokep@gmail.com for attachment 3016 on bug 1983. 17:50:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1983 tri, --, ---, aleth, ASSI, Default normalizedName normalization is too aggressive 17:50:53 --> gerard-majax_ has joined #instantbird 17:55:01 --> Mook_as has joined #instantbird 18:08:36 --> dionisos has joined #instantbird 18:15:51 --> qlum has joined #instantbird 18:25:52 <flo-retina> aleth: re bug 2209. I saw it several times on my debug profile during the week-end. I don't think I had any private message. 18:25:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2209 nor, --, ---, nobody, NEW, Error: (intermediate value).buddy is null at ibConvStatsService.js:479 18:27:03 <-- skeledrew has quit (Ping timeout) 18:28:22 --> skeledrew has joined #instantbird 18:28:39 <flo-retina> aleth: so I would suspect something related to having buddies grouped into countacts. 18:29:56 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 18:53:47 --> mpmc has joined #instantbird 19:23:33 --> igorko has joined #instantbird 19:26:44 <-- dionisos has quit (Ping timeout) 19:46:33 <-- aleth has quit (Input/output error) 19:59:35 --> EionRobb has joined #instantbird 20:00:39 <-- GeKo has quit (Quit: leaving) 20:07:55 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died) 20:09:10 --> chrisccoulson has joined #instantbird 20:48:13 <-- jb has quit (Ping timeout) 20:48:37 --> jb has joined #instantbird 21:06:09 --> flo-retina has joined #instantbird 21:06:09 * ChanServ sets mode +qo flo-retina flo-retina 21:10:29 <-- clokep_work has quit (Input/output error) 21:35:49 --> rosonline has joined #instantbird 22:04:00 --> FireFly_TB has joined #instantbird 22:10:18 <flo-retina> tb chat seems completely broken in my default tb profile :-S 22:14:52 <flo-retina> and the new version of the add-on doesn't seem to work well 22:14:58 <flo-retina> It makes TB very crashy :( 22:15:08 <flo-retina> and I haven't been able to create any account 22:15:25 <flo-retina> (using libpurple based prpls) 22:23:56 --> clokep_work has joined #instantbird 22:35:54 --> dionisos has joined #instantbird 22:37:07 <-- qlum has quit (Quit: Getting the <censored> out.) 22:39:58 <-- jb has quit (Ping timeout) 22:40:51 --> jb has joined #instantbird 22:48:44 <-- FireFly_TB has quit (Ping timeout) 22:50:16 <-- igorko has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 22:51:19 <-- jb has quit (Connection reset by peer) 22:51:19 --> jb1 has joined #instantbird 23:10:24 <-- jb1 has quit (Ping timeout) 23:51:39 <-- dionisos has quit (Ping timeout)