All times are UTC.
00:08:38 <-- myk has quit (Ping timeout) 00:49:46 <-- rosonline has quit (Client exited) 01:09:22 <-- Mook_as has quit (Quit: Mook_as) 01:42:26 * clokep pokes qheaden. 02:15:04 --> myk has joined #instantbird 02:29:40 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 02:47:12 <-- myk has quit (Ping timeout) 03:10:12 <qheaden> Hello. 03:10:35 <qheaden> clokep: I told you I would be on later. It turns out later had to mean near midnight. :P 03:12:06 <-- wnayes has quit (Quit: wnayes) 03:15:16 --> jamesw has joined #instantbird 03:15:25 <-- mconley has quit (Input/output error) 03:28:56 <instant-buildbot> build #967 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/967 03:37:36 <instant-buildbot> build #990 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/990 03:38:42 <-- qheaden has quit (Quit: ZNC - http://znc.in) 03:40:18 --> qheaden has joined #instantbird 04:08:02 <instant-buildbot> build #1069 of win32-nightly-default is complete: Failure [failed compile] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1069 04:12:41 --> mconley has joined #instantbird 04:14:27 <-- skeledrew1 has quit (Ping timeout) 04:15:03 --> skeledrew has joined #instantbird 04:21:39 <-- mconley has quit (Input/output error) 05:01:20 --> gerard-majax_ has joined #instantbird 05:03:31 <-- gerard-majax_ has quit (Ping timeout) 05:19:45 --> gerard-majax_ has joined #instantbird 05:56:32 <-- EionRobb has quit (Quit: Leaving.) 05:56:33 --> gerard-majax__ has joined #instantbird 05:56:46 <-- gerard-majax_ has quit (No route to host) 05:58:21 <-- gerard-majax__ has quit (Ping timeout) 06:10:41 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2863 on bug 2136. 06:10:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2136 min, --, ---, qheaden, ASSI, Yahoo! Mobile status not taken into account 06:14:27 --> gerard-majax__ has joined #instantbird 06:16:07 <-- gerard-majax__ has quit (Ping timeout) 06:23:56 <-- dionisos has quit (Ping timeout) 06:29:03 --> FireFly_TB has joined #instantbird 06:33:46 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 06:36:06 --> gerard-majax__ has joined #instantbird 06:37:50 <-- gerard-majax__ has quit (Ping timeout) 06:43:51 --> gerard-majax__ has joined #instantbird 07:01:56 <-- gerard-majax__ has quit (Ping timeout) 07:02:44 --> gerard-majax__ has joined #instantbird 07:04:25 <-- gerard-majax__ has quit (Ping timeout) 07:17:12 --> gerard-majax__ has joined #instantbird 07:20:42 --> jb has joined #instantbird 07:32:56 <-- FireFly_TB has quit (Ping timeout) 07:36:56 --> FireFly_TB has joined #instantbird 08:13:32 <instantbot> florian@instantbird.org denied review for attachment 2862 on bug 2143. 08:13:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2143 enh, --, ---, nhnt11, NEW, Stats service should maintain statistical data for conversations and use it for sorting. 08:25:54 --> nhnt11 has joined #instantbird 08:26:09 <nhnt11> flo-retina: Thanks for the review. 08:27:58 <-- jb has quit (Ping timeout) 08:33:28 --> jb has joined #instantbird 09:01:22 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 09:03:16 <-- FireFly_TB has quit (Ping timeout) 09:09:40 --> flo-retina has joined #instantbird 09:09:40 * ChanServ sets mode +qo flo-retina flo-retina 09:17:08 --> FireFly_TB has joined #instantbird 09:34:37 <flo-retina> have we filed a bug to update the Mac "+" icons for the non-retina case? (now that nhnt11 has an external screen, he should be able to fix it whenever he's got a few minutes ;)). 10:05:53 --> clokep has joined #instantbird 10:05:53 * ChanServ sets mode +o clokep 10:22:24 --> Mic has joined #instantbird 10:22:25 * ChanServ sets mode +h Mic 10:34:34 <clokep> Hello. 10:45:17 <flo-retina> clokep: Good morning :) 10:49:15 <instantbot> clokep@gmail.com requested review from the wind for attachment 2814 on bug 2102. 10:49:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2102 nor, --, ---, qheaden, ASSI, Support Server Pings 10:52:58 <clokep> flo-retina: We use a lot of hasOwnProperty in the IRC code btw, since a lot of things are keyed off network values. 10:53:38 <clokep> aleth and I have discussed replacing some of them with Maps (i.e. particiapnts and channel lists) 10:53:42 <flo-retina> clokep: yeah. I'm not trying to get rid of them all. Just trying to optimize hot code paths; and I think handling a message received from the server is one of them :) 10:54:03 <flo-retina> are we sure Maps are faster? 10:55:06 <clokep> aleth seems to think they are. 10:55:15 * clokep goes to get ready for work. 10:56:49 <flo-retina> we should probably check that they actually are, before refactoring a bunch of the code ;) 10:58:08 <-- dew has quit (Connection reset by peer) 10:58:50 * clokep thought that aleth checked that. 11:03:23 --> dew has joined #instantbird 11:03:54 <clokep> In http://pastebin.instantbird.com/331456, the Map code runs 25% faster. 11:12:14 <-- clokep has quit (Ping timeout) 11:31:44 <Mic> I had 'benchmarked' maps and objects used as maps before with the same result... was that lost somehow? :( 11:47:42 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 11:59:39 --> dionisos has joined #instantbird 12:10:54 <flo-retina> Mic, clokep: what results do you get for http://jsperf.com/mappoirez ? 12:18:39 --> clokep_ has joined #instantbird 12:30:44 <clokep_> flo-retina: I get Map being slower, but that doesn't match what I ran on my other machine 12:38:08 <instantbot> clokep@gmail.com cancelled review?(aleth@instantbird.o rg) for attachment 2859 on bug 2165. 12:38:09 <instantbot> clokep@gmail.com requested review from aleth@instantbird.o rg for attachment 2864 on bug 2165. 12:38:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2165 nor, --, ---, clokep, ASSI, IRC ping does not properly send a timestamp 12:38:31 <clokep_> It wasn't TOO bad to add support for pinging the server. ;) 13:15:49 --> aleth has joined #instantbird 13:15:49 * ChanServ sets mode +h aleth 13:32:55 <-- FireFly_TB has quit (Quit: FireFly_TB) 13:34:53 <instantbot> aleth@instantbird.org granted review for attachment 2858 on bug 2163. 13:34:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2163 min, --, ---, florian, NEW, Displaying a large conversation log freezes the UI for a while before the first messages get display 13:36:06 <flo-retina> hey aleth! :) 13:36:31 <aleth> hullo :) 13:36:47 <clokep_> aleth has lots of reviews. ;) 13:36:50 * aleth has a lot of review requests considering it's only been two days ;) 13:37:37 --> mconley has joined #instantbird 13:37:40 <flo-retina> if you've got time for another one, I'm looking forward to bug 2160 13:37:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2160 nor, --, ---, nobody, NEW, UI lags while stats service is receiving chat rooms 13:38:12 <aleth> Ah, that's already had a few cycles too :) 13:38:24 <flo-retina> and then bug 2162, but that's less important (and less complicated) 13:38:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2162 nor, --, ---, nhnt11, ASSI, IRC's /list command should use the requestRoomInfo API 13:38:40 <flo-retina> aleth: these 2 are IMHO ready to land, but we wanted you to have another look before landing ;) 13:38:44 <aleth> I'll try to look at least at the ones that are blocking pref'ing on LIST 13:38:52 <flo-retina> these 2 are ;) 13:39:19 <flo-retina> and it looks like our goals are very well aligned; as it's exactly preff'ing on LIST that I had in mind ;) 13:39:26 <aleth> :) 13:40:11 <flo-retina> well, 2162 is a soft blocker; it matters only if people have enabled the server tab 13:40:30 <aleth> i.e. possibly Mook ;) 13:40:37 <flo-retina> he's on Tb. 13:41:49 <flo-retina> already 5 patches in checkin-needed! :) 13:42:26 <aleth> Not much left to do for JS-Yahoo either... 13:43:09 <flo-retina> clokep_: do we have an easy way to know an IRC disconnect is from the GHOST command? 13:43:24 <flo-retina> aleth: well, starting to dogfood with #chatdev ;) 13:43:43 <aleth> Right :) 13:44:06 <aleth> We can now actually get invited and post debug logs ;) 13:44:14 <flo-retina> cool :) 13:44:19 <flo-retina> can windows users do that too? 13:44:27 <flo-retina> ;) 13:44:34 <aleth> idk what the situation with windows nightlies is :-/ 13:44:42 <aleth> Did one randomly succeed? 13:44:45 <flo-retina> sad 13:44:47 <flo-retina> yes 13:45:02 <flo-retina> just one. :-S 13:45:34 <flo-retina> I'm hoping that we can get started on building a new VM tomorrow, to hopefully get it working by the end of the week 13:46:58 <aleth> flo-retina: Why is Object.prototype.hasOwnProperty... more efficient than hasOwnProperty(...) in the case where you changed it? 13:47:57 <clokep_> flo-retina: We were discussing this in #maildev btw. 13:48:17 <clokep_> flo-retina: The short answer is "no". 13:49:32 --> FireFly_TB has joined #instantbird 13:50:21 <flo-retina> clokep_: the ghost command sending both commands at once makes sense I guess 13:50:43 <flo-retina> aleth: because it avoids traversing cross compartment wrappers 13:50:46 * clokep_ wants aleth to look at it. 13:51:48 <flo-retina> at what? 13:51:49 <aleth> flo-retina: Which two compartments? 13:52:02 <flo-retina> aleth: the ircHandlers.jsm one and the imXPCOMUtils.jsm one 13:52:08 <instantbot> clokep@gmail.com set the Resolution field on bug 1949 to WONTFIX. 13:52:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1949 enh, --, ---, nobody, RESO WONTFIX, Implement auto-ghosting 13:52:34 <flo-retina> clokep_: doesn't that bug attempt to address the same issue as providing a list of alternative nicks? 13:52:42 <clokep_> flo-retina: aleth At that Mozilla bug about ghosting. 13:52:52 <clokep_> flo-retina: Which bug? 13:52:52 <flo-retina> ok :) 13:52:59 <flo-retina> the one you wontfixed 13:52:59 * clokep_ thinks we're talking about too many things and being overly vague. :P 13:53:18 <flo-retina> we are being very specific; compared to what I discuss elsewhere ;) 13:53:22 * aleth assumes it was the bug clokep just cc'd him to ;) 13:53:25 <clokep_> flo-retina: I have no idea what it's trying to address, it just says we should do xyz without any reasoning. :P 13:53:35 <clokep_> aleth: Yes. :) 13:55:40 <-- mconley has quit (Quit: Leaving...) 13:56:04 <flo-retina> clokep_: "tell you were ghosted without looking at the text inside of the ERROR response" why would we not look at the ERROR text? 13:56:17 <flo-retina> do you think the "GHOST" word would be localized? :) 13:58:25 * aleth thinks some debug logs of how this looks on various servers would be helpful 13:58:47 <aleth> +1 for the suggestion of adding a /ghost command if we were to support this. 13:59:03 <flo-retina> I was about to ask for debug logs in the bug, then decided querying clokep's universal IRC knowledge base would be faster ;) 13:59:22 * aleth winces at "/msg nickserv ghost take Username password" :P 13:59:50 <clokep_> flo-retina: Because it's freetext, I don't know if all servers put the phrase "GHOST" in there, or if they don't use it for other things. 14:00:03 <-- jb has quit (Connection reset by peer) 14:00:03 --> jb1 has joined #instantbird 14:00:10 * clokep_ types r, press down in Firefox. ;) 14:00:21 <flo-retina> going way for a meeting. 14:01:24 <clokep_> The RFC actually provides very little information about the ERROR command. 14:10:01 <-- FireFly_TB has quit (Quit: FireFly_TB) 14:24:28 <-- jb1 has quit (Ping timeout) 14:27:42 --> FireFly_TB has joined #instantbird 14:28:01 --> jb has joined #instantbird 14:31:34 <qheaden> Hello. 14:35:44 <-- jb has quit (Ping timeout) 14:42:58 --> jb has joined #instantbird 14:54:46 --> wnayes has joined #instantbird 14:55:34 <clokep_> Hello qheaden . 14:55:47 <-- aleth has quit (Quit: Ciao) 14:55:54 --> aleth has joined #instantbird 14:55:55 * ChanServ sets mode +h aleth 14:56:40 <aleth> When you tab in the contact list, does the display name jump up a pixel or so for you when it gets focus? 15:04:20 <qheaden> clokep_: It looks like there are no more conference bugs blocking bug 2135. :) 15:04:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2135 nor, --, ---, qheaden, ASSI, Enable JS Yahoo By Default 15:11:15 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2865 on bug 2153. 15:11:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2153 nor, --, ---, aleth, ASSI, Make UTF-8 conversion warnings less noisy 15:22:16 --> myk has joined #instantbird 15:23:55 <flo-retina> would a ghost command require a password? (can't we use the account's password?) 15:27:01 <-- myk has quit (Ping timeout) 15:28:52 --> mconley has joined #instantbird 15:30:36 <aleth> flo-retina: If we had a ghost command it should only work for the account nick I think (where we have the password) 15:32:01 <flo-retina> did you mean "add"? 15:32:18 <clokep_> aleth: flo-retina It would need to be the NickServ password. 15:32:46 <aleth> clokep_: Argh, right, they may not match :-S 15:32:54 <flo-retina> I think both the nick and password can be optional for a /ghost command 15:34:42 --> JosiahOne has joined #instantbird 15:34:46 <instantbot> aleth@instantbird.org granted review for attachment 2853 on bug 2162. 15:34:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2162 nor, --, ---, nhnt11, ASSI, IRC's /list command should use the requestRoomInfo API 15:35:20 <clokep_> JosiahOne: So there currently is no ghost command at all, we'd be adding one. 15:35:30 <clokep_> What's never clear to me is how we're supposed to know the user wants to change their nick. 15:35:42 <JosiahOne> clokep_: Right. 15:36:53 <clokep_> So I think what you suggested is that we should always do it. 15:37:02 <clokep_> aleth is suggesting we shuld only do it if it's the "main" nick. 15:37:09 <JosiahOne> clokep_: There are arguments for commands though, so why can't we do something like: '/ghost <username> <password> <take>' Where take is just a bool value. 15:37:13 <clokep_> But really what we'd need to see is debug logs of what happens when you get ghosted. 15:37:22 <clokep_> Because simpler is better. :) 15:38:33 <JosiahOne> True, but unexpected results aren't too nice either if the user doesn't want it. 15:39:31 <JosiahOne> For example, say on machine A you have your main nick logged in, and on your laptop you go by the nick 'name_laptop'. Now you want to kick your main nick, since you aren't near machine A. We need a way to do this without changing the current name. 15:39:51 <JosiahOne> s/kick/ghost 15:40:05 <JosiahOne> the name on the laptop (machine b)* 15:40:24 <aleth> clokep_: Do you get an empty page for http://lxr.instantbird.org/instantbird/source/instantbird/themes/messages/bubbles/Footer.html ? 15:41:41 <aleth> Ah, it's not empty, it's just the raw file. 15:44:03 <clokep_> JosiahOne: Yes, so I think that's where aleth's question of "What are you actually trying to do?" comes in. 15:44:11 <clokep_> We were also discussing whether you need to give the password or not. ;) 15:45:30 <JosiahOne> Another option is to add a /ghost and a /take command. /ghost would only ghost, and /take would ghost and swap your name. 15:46:09 <clokep_> aleth: "The code was correct, but I've changed it in the current patch to make it clearer what is going on." Umm...the current patch seems to reset this to the old way. 15:46:23 <clokep_> :-S 15:46:53 <aleth> Yes, since that evidently seems easier to read ;) 15:47:19 <aleth> (The previous patch used dequotedMessage to generate the ircMessage) 15:47:56 <clokep_> aleth: OK. 15:48:04 <clokep_> I think I disagree that not using JSON.stringify makes it clearer btw. 15:48:30 <aleth> The question is, do you want to include both the original raw message and the raw message in the JS object. 15:48:47 <aleth> The only reason for doing so I can see is that there may be a dequoting bug. 15:50:36 <aleth> If you want to keep both, fair enough ;) Imho it just makes the debug log longer... 15:50:56 <aleth> What I think is wrong is never logging the original raw message. 15:51:38 --> nhnt11 has joined #instantbird 15:51:56 <nhnt11> Good evening. I've been very busy today :( 15:52:16 <nhnt11> I have only a few minutes now before I rush to dinner so I figured I'd catch up on the logs and read my bugmail :) 15:53:40 * aleth thinks there are already enough review comments for now in bug 2143 so he will wait for the next cycle on that ;) 15:53:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2143 enh, --, ---, nhnt11, NEW, Stats service should maintain statistical data for conversations and use it for sorting. 15:54:24 <nhnt11> I see that old Ghosting bug I filed has come up again ;) 15:55:31 <JosiahOne> Yup. 15:55:32 <nhnt11> I think my main goal with that bug was that if we didn't get our primary nick (i.e. I got nhnt12) and nhnt11 logged off, it should automatically change my nick back (at the very least). As well as have a manual command to ghost it. 15:55:54 <nhnt11> But I'm not that interested in that bug anymore, it was also partly a way for me to look at more code :P 16:03:11 <nhnt11> Ok, gotta run. Bye! I hope I'll be able to come online later tonight but I'm not counting on it... 16:03:14 <nhnt11> Good night. 16:03:15 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 16:06:21 * aleth hopes nhnt11 has time for a reply in bug 2160 while he is still around... 16:06:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2160 nor, --, ---, nobody, NEW, UI lags while stats service is receiving chat rooms 16:09:47 <-- FireFly_TB has quit (Ping timeout) 16:21:25 <flo-retina> aleth: yes, you don't need to look at bug 2143 now :) 16:21:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2143 enh, --, ---, nhnt11, NEW, Stats service should maintain statistical data for conversations and use it for sorting. 16:22:59 <instantbot> aleth@instantbird.org denied review for attachment 2864 on bug 2165. 16:23:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2165 nor, --, ---, clokep, ASSI, IRC ping does not properly send a timestamp 16:27:41 <flo-retina> aleth: are you sure the LIST results are stored alphabetically by the server? (I had the impression they weren't when I tested on freenode) 16:28:02 <aleth> flo-retina: No, I'm not sure at all. 16:28:22 <aleth> It's just the only reason I could think of for possibly preferring shift(). 16:29:19 <aleth> The patch looks r+ otherwise to me :) 16:29:58 <flo-retina> aleth: I think you can easily verify by typing /list ;) 16:30:17 <aleth> flo-retina: Do I look like I have a server tab ? ;) 16:31:01 <flo-retina> no, but after typing /list, you will look at the debug log :-P 16:31:02 <aleth> Actually, the warnings produced would probably be enough to tell :P 16:35:06 * JosiahOne is now known as JosiahOne|Away 16:36:55 <-- JosiahOne|Away has quit (Ping timeout) 16:46:22 --> Mook_as has joined #instantbird 16:47:12 <instantbot> clokep@gmail.com requested review from aleth@instantbird.o rg for attachment 2866 on bug 2165. 16:47:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2165 nor, --, ---, clokep, ASSI, IRC ping does not properly send a timestamp 16:47:20 <-- gerard-majax__ has quit (Ping timeout) 16:47:29 --> JosiahOne has joined #instantbird 16:50:45 <instantbot> clokep@gmail.com denied review for attachment 2865 on bug 2153. 16:50:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2153 nor, --, ---, aleth, ASSI, Make UTF-8 conversion warnings less noisy 16:50:49 * JosiahOne is now known as JosiahOne|Away 16:52:17 <instantbot> aleth@instantbird.org granted review for attachment 2866 on bug 2165. 16:52:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2165 nor, --, ---, clokep, ASSI, IRC ping does not properly send a timestamp 16:52:28 <-- JosiahOne|Away has quit (Ping timeout) 16:57:57 --> gerard-majax__ has joined #instantbird 16:58:43 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2867 on bug 2153. 16:58:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2153 nor, --, ---, aleth, ASSI, Make UTF-8 conversion warnings less noisy 16:59:45 <-- gerard-majax__ has quit (Ping timeout) 17:03:41 --> nhnt11 has joined #instantbird 17:05:08 <nhnt11> aleth: I seemed to have missed the shift()/pop() comment :( 17:05:12 <nhnt11> Let me upload a new patch 17:05:43 <nhnt11> And the LIST results aren't in any particular order from what I've seen, but I guess that's been discussed 17:07:47 <clokep_> aleth: So the reason I don't like this.WARN("Unhandled IRC message: " + originalRawMessage); is because you tend to lose non-printable characters. 17:09:01 <aleth> clokep_: You mean, in the error console? 17:09:07 <clokep_> Yes 17:09:15 <clokep_> But I guess that doesn't matter much. 17:10:25 <aleth> I was more concerned about the debug logs always containing the raw message, so we always have that 17:11:03 <aleth> available. We could do a this.DEBUG followed by a this.WARN for the unhandled message case if you like 17:12:01 <clokep_> aleth: That seems gross, I don't want them. 17:12:03 <clokep_> that. 17:12:08 <instantbot> nhnt11@gmail.com cancelled review?(aleth@instantbird.o rg) for attachment 2855 on bug 2160. 17:12:09 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2868 on bug 2160. 17:12:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2160 nor, --, ---, nobody, NEW, UI lags while stats service is receiving chat rooms 17:12:11 <aleth> Yeah. 17:12:12 <clokep_> aleth: Sooooooooo....(you're about to hate me). 17:12:24 <clokep_> Should unquoting be done in the ircMessage stuff? 17:12:26 <clokep_> Just asking. 17:12:31 <clokep_> Otherwise I'd say something like this: 17:13:08 <clokep_> http://pastebin.instantbird.com/332011 17:13:48 <aleth> Now that's confusing code... 17:14:02 <clokep_> Really? How so? 17:14:31 <clokep_> 1. I like the change of saying dequotedMessage instead of overwriting aRawMessage. 17:14:52 <aleth> You JSON.stringify an object where you change one value before logging it. 17:15:06 <nhnt11> flo-retina: I'll look at the non-retina + icon next time I have 10 minutes :) 17:15:45 --> gerard-majax__ has joined #instantbird 17:15:54 <aleth> clokep_: I think I'd prefer moving dequoting to the ircMessage 17:16:01 <clokep_> aleth: OK. 17:16:25 * clokep_ was wondering recently if it wouldn't make sense to have an ircMessage object like qheaden's YMSG one. 17:16:33 <clokep_> Except it doesn't really make sense because we always build it in one shot. 17:18:18 <-- deltafalcon has quit (Connection reset by peer) 17:20:30 * clokep_ sighs. 17:20:36 <clokep_> I dislike bugs like this. :P 17:22:29 <aleth> You're not alone... 17:23:39 <clokep_> Sorry if I'm being pedantic, I just want it to be right if we're goign to reorganize all this stuff. :) 17:24:52 <aleth> clokep_: Will moving dequoting to ircMessage break tests in a confusing way? 17:25:09 <aleth> (Since the whole quoting business a mess) 17:26:18 <clokep_> aleth: It'll break tests, yes. 17:26:30 <clokep_> But could simplify how we test it. 17:26:38 <aleth> nhnt11: I think you attached the wrong patch? 17:26:47 <nhnt11> I did? :O 17:27:22 <aleth> clokep_: Not if we have to remember to quote test strings so we can test them. It means parsing and quoting can't be tested separately 17:27:34 <nhnt11> Oh it still has shift. 17:27:35 <nhnt11> That's weird 17:28:30 <-- jamesw has quit (Quit: [A] I wanna see the ground give way...) 17:29:00 <instantbot> nhnt11@gmail.com cancelled review?(aleth@instantbird.o rg) for attachment 2868 on bug 2160. 17:29:01 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2869 on bug 2160. 17:29:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2160 nor, --, ---, nobody, NEW, UI lags while stats service is receiving chat rooms 17:29:22 <aleth> nhnt11: You also never answered my question about why if (!this._addingPendingChats) return; is needed 17:30:38 * nhnt11 seems to be in too much of a hurry while addressing review comments... 17:31:39 <clokep_> It's hard to follow review comments sometimes. :) 17:31:48 <clokep_> I always find it helps to clarify before addressing. 17:32:00 <nhnt11> aleth: Looks like it has no use in this patch, shall I remove it and re-attach? 17:32:27 <nhnt11> clokep_: But forgetting to answer a direct question altogether is just plain negligence on my part... 17:32:47 <aleth> nhnt11: If it's not needed, it should not be there :) 17:33:43 <nhnt11> aleth: I just thought of something else. _removeChatsForAccount should remove stuff from pendingChats too. 17:34:19 <aleth> That's true. An edge case... 17:34:28 <nhnt11> It seems like an edge case but there could be a scenario where we're receiving LIST results but the user disconnects in the meantie 17:34:29 <nhnt11> time* 17:34:30 <nhnt11> yeah 17:35:14 <aleth> You'll also want to reduce this._accountsRequestingRoomInfo in that case 17:35:20 <aleth> Good catch. 17:35:24 <nhnt11> aleth: In this case, after removing these from pendingChats, we can delete addingPendingChats if the list is empty in which case the check will be useful :) 17:35:30 <nhnt11> Yeah. 17:36:04 <nhnt11> Actually I think the check should still be removed, as it will at the very least ensure we fire an update notification. 17:36:14 <nhnt11> s/it will/removing the check will 17:36:15 <qheaden> aleth: Which OS do you run Ib on? 17:36:18 <aleth> Right. 17:36:20 <aleth> qheaden: Linux 17:36:35 <qheaden> aleth: Have you been able to try out conference chat in the latest nightlies? 17:36:43 <aleth> qheaden: I haven't tried 17:37:00 <qheaden> Okay. You should be able to successfully join conferences now. 17:37:01 <aleth> It should work now I guess :) 17:38:35 --> FireFly_TB has joined #instantbird 17:38:58 <instantbot> clokep@gmail.com denied review for attachment 2814 on bug 2102. 17:39:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2102 nor, --, ---, qheaden, ASSI, Support Server Pings 17:39:42 <nhnt11> aleth: I think it makes sense to decrement _accountsRequestingRoomInfo from the else if (aTopic == "account-disconnected") block in observe, btw. 17:40:09 <aleth> Yes 17:40:17 <nhnt11> Hmm, I'll need to check if the account in question was requesting room info first as well. 17:40:35 <nhnt11> Which means I'll likely need a Map instead of an integer for accountsRequestingRoomInfo 17:40:47 <aleth> That sounds safer. 17:41:05 <-- FireFly_TB has quit (Ping timeout) 17:41:12 <instantbot> clokep@gmail.com denied review for attachment 2861 on bug 2166. 17:41:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2166 nor, --, ---, florian, ASSI, JS-IRC spends more time than it needs in hasOwnProperty calls 17:41:17 <nhnt11> aleth: Is it safe to delete a property from an Object without checking if the property is defined? 17:41:24 <aleth> nhnt11: Yes 17:41:28 <nhnt11> Thanks. 17:42:50 <nhnt11> Bah, I'm using a Map anyway so that question was kinda irrelevant.. whatever :P 17:43:37 <aleth> Do you really mean Set when you say Map ;) 17:45:07 <nhnt11> Er, yeah :P I was thinking of an object so I could delete stuff fast, then I translated object to Map without realizing Set is what I need :S 17:48:56 <-- jb has quit (Ping timeout) 17:53:12 <instantbot> nhnt11@gmail.com cancelled review?(aleth@instantbird.o rg) for attachment 2869 on bug 2160. 17:53:13 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2870 on bug 2160. 17:53:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2160 nor, --, ---, nobody, NEW, UI lags while stats service is receiving chat rooms 17:53:27 <-- wnayes has quit (Ping timeout) 17:53:45 <aleth> nhnt11: Have you tested this edge case? 17:54:07 <aleth> "// We send an update notification if this is 0 after adding chat rooms." this comment is now wrong 17:54:18 * nhnt11 sighs. 17:54:28 <nhnt11> I'll fix the comment, give it a quick test and upload a patch 17:54:36 * nhnt11 is in a hurry as usual.. 17:56:40 <aleth> |if (!this._accountsRequestingRoomInfo.size && !this._pendingChats.length || now - this._lastUpdateNotification > 100)| will only send an update notification at the very end 17:57:08 <clokep_> Where are the tests? ;) 17:57:28 --> wnayes has joined #instantbird 17:57:32 <aleth> Something is wrong with boolean operators there 17:58:01 <nhnt11> aleth: That's weird 17:58:16 <nhnt11> Shouldn't && get operator precedence over ||? 17:58:56 <aleth> Whatever, x && y || z is hard to read :P 18:00:32 <nhnt11> aleth: Would you prefer |(x && y) || z| ? 18:01:17 <aleth> Yes. (You're right about it working though I think) 18:01:34 <nhnt11> aleth: It's working, I just tested. 18:01:41 <nhnt11> Anyway, new patch incoming. 18:01:53 <nhnt11> (I've tested the edge case as well and fixed a small bug, thanks ;) ) 18:02:09 <nhnt11> (I was trying to use PossibleChat._accountId which is no longer available) 18:02:17 --> unghost has joined #instantbird 18:02:23 <nhnt11> (So I added a get accountId() in the prototype and am now using that) 18:04:51 * nhnt11 has to go in a minute 18:04:57 <instantbot> nhnt11@gmail.com cancelled review?(aleth@instantbird.o rg) for attachment 2870 on bug 2160. 18:04:58 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2871 on bug 2160. 18:05:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2160 nor, --, ---, nobody, NEW, UI lags while stats service is receiving chat rooms 18:06:10 --> jamesw has joined #instantbird 18:07:10 <aleth> nhnt11: Why is it no longer available? (trying to understand)\ 18:07:37 <nhnt11> aleth: It used to be set in the constructor, but now we're keeping a reference to the RoomInfo object itself. 18:07:49 <aleth> Ah, that was that patch that landed yesterday? 18:08:20 <nhnt11> Yeah 18:09:02 <instantbot> aleth@instantbird.org granted review for attachment 2871 on bug 2160. 18:09:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2160 nor, --, ---, nobody, NEW, UI lags while stats service is receiving chat rooms 18:09:09 <nhnt11> aleth: Thanks! 18:09:34 * nhnt11 goes to study about transformers. 18:09:36 <nhnt11> Good night. 18:09:59 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 18:14:09 <clokep_> qheaden: Did you test bug 2136 at all? 18:14:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2136 min, --, ---, qheaden, ASSI, Yahoo! Mobile status not taken into account 18:15:09 <qheaden> clokep_: No the mobile part, no. I'm not sure how to give a mobile status with Yahoo. 18:15:25 <qheaden> I can verify that the code does work with normal statuses. 18:17:40 <qheaden> clokep_: How were you going to test it? 18:24:16 <instantbot> clokep@gmail.com denied review for attachment 2863 on bug 2136. 18:24:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2136 min, --, ---, qheaden, ASSI, Yahoo! Mobile status not taken into account 18:24:40 <clokep_> qheaden: I have a friend who is always mobile. 18:24:50 <qheaden> clokep_: Okay. 18:25:05 <qheaden> clokep_: Just to be sure, was it clear to you why I had to switch to iteration? 18:25:48 <clokep_> qheaden: I'm not nearly concerned about that as you seem to be. ;) 18:25:59 <clokep_> But yes, it's because some elements don't have the mobile field and others do. 18:26:04 <clokep_> But it's unclear which go with which. 18:26:04 <qheaden> :P 18:26:37 <qheaden> How nice it would be if Yahoo would switch to an XML or JSON protocol. 18:27:29 <clokep_> But then you'd have to rewrite everything. ;) 18:27:58 <qheaden> Nah, that will be your job. ;) 18:31:16 <clokep_> :P 18:48:25 <-- flo-retina has quit (Ping timeout) 19:02:23 --> Mic has joined #instantbird 19:02:24 * ChanServ sets mode +h Mic 19:18:24 --> qlum has joined #instantbird 19:18:40 --> sabret00the has joined #instantbird 19:37:59 <instantbot> aleth@instantbird.org cancelled review?(clokep@gmail.com) for attachment 2867 on bug 2153. 19:38:00 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2872 on bug 2153. 19:38:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2153 nor, --, ---, aleth, ASSI, Make UTF-8 conversion warnings less noisy 19:44:22 <clokep_> Nits only remain! 19:44:36 <instantbot> clokep@gmail.com denied review for attachment 2872 on bug 2153. 19:44:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2153 nor, --, ---, aleth, ASSI, Make UTF-8 conversion warnings less noisy 19:48:59 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2873 on bug 2153. 19:49:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2153 nor, --, ---, aleth, ASSI, Make UTF-8 conversion warnings less noisy 19:52:22 * clokep_ feels like every IRC patch ends up with 5 extra iterations... 19:52:42 <instantbot> clokep@gmail.com granted review for attachment 2873 on bug 2153. 19:52:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2153 nor, --, ---, aleth, ASSI, Make UTF-8 conversion warnings less noisy 19:52:50 <aleth> Yeah... especially ones with no obviously right answer. 19:53:43 <clokep_> I'd like flo-retina to check that one in so he looks at it breifly. 19:54:39 <aleth> Lots of checkins today... 19:55:53 <-- aleth has quit (Quit: Ciao) 20:07:07 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 20:11:22 --> wqhcqtyvekb78 has joined #instantbird 20:11:29 <-- wqhcqtyvekb78 has quit (Excess Flood) 20:11:41 --> wqhcqtyvekb78 has joined #instantbird 20:11:41 <-- wqhcqtyvekb78 has quit (Max SendQ exceeded) 20:11:52 --> wqhcqtyvekb78 has joined #instantbird 20:11:52 <-- wqhcqtyvekb78 has quit (Max SendQ exceeded) 20:12:04 --> wqhcqtyvekb78 has joined #instantbird 20:12:04 <-- wqhcqtyvekb78 has quit (Max SendQ exceeded) 21:07:32 --> EionRobb has joined #instantbird 21:14:34 <-- mconley has quit (Input/output error) 21:20:11 --> swills has joined #instantbird 21:35:58 <-- clokep_ has quit (Quit: http://www.mibbit.com ajax IRC Client) 21:49:31 <-- unghost has quit (Quit: Ð£Ñ Ð¾Ð¶Ñ Ñ Ð¾Ñ Ð²Ð°Ñ (xchat 2.4.5 или ÑÑаÑÑе)) 22:15:53 <-- dew has quit (Ping timeout) 22:24:23 --> dew has joined #instantbird 22:48:26 <-- qlum has quit (Quit: Getting the <censored> out.) 23:02:13 <-- gerard-majax__ has quit (Ping timeout) 23:49:35 --> clokep has joined #instantbird 23:49:35 * ChanServ sets mode +o clokep