#instantbird log on 08 29 2013

All times are UTC.

00:11:36 --> jb has joined #instantbird
00:19:16 <-- jb has quit (Ping timeout)
00:21:04 --> jb has joined #instantbird
00:21:18 <-- jb has quit (Connection reset by peer)
00:25:51 <instant-buildbot> build #460 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/460
00:25:53 --> jb has joined #instantbird
00:33:17 <-- jb has quit (Ping timeout)
00:35:46 <-- rosonline has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com)
00:38:22 * qheaden_away is now known as qheaden
00:47:55 <instant-buildbot> build #449 of win32-onCommit is complete: Failure [failed shell_1]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/449  blamelist: Florian Qu?ze <florian@instantbird.org>, aleth <aleth@instantbird.org>
01:09:50 <-- Mook_as has quit (Quit: Mook_as)
01:43:21 --> dew has joined #instantbird
02:14:07 --> Mook has joined #instantbird
02:34:03 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2801 on bug 2132.
02:34:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2132 nor, --, ---, qheaden, ASSI, Sender name not set in Yahoo conversations
03:12:07 --> clokep has joined #instantbird
03:12:07 * ChanServ sets mode +o clokep 
03:29:25 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
03:40:12 <instant-buildbot> build #964 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/964
03:48:38 <instant-buildbot> build #953 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/953
04:07:03 <-- mconley has quit (Input/output error)
04:21:05 --> FireFly_TB has joined #instantbird
04:22:02 <-- FireFly_TB has quit (Connection reset by peer)
05:07:32 --> mconley has joined #instantbird
05:13:25 <-- mconley has quit (Ping timeout)
05:41:49 <-- EionRobb has quit (Quit: Leaving.)
06:40:11 <instant-buildbot> build #1049 of win32-nightly-default is complete: Failure [failed compile]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1049
06:41:59 --> FireFly_TB has joined #instantbird
07:01:26 <-- Mook has quit (Ping timeout)
07:12:23 --> nhnt11 has joined #instantbird
07:12:49 * nhnt11 hasn't been able to get much done in the last few days... :(
07:19:49 <-- nhnt11 has quit (Input/output error)
08:12:16 <flo-retina> uh, why is that windows nightly still failing :(
08:13:36 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
08:13:39 --> flo-retina has joined #instantbird
08:13:39 * ChanServ sets mode +qo flo-retina flo-retina 
08:14:10 --> gerard-majax has joined #instantbird
08:30:34 <-- FireFly_TB has quit (Ping timeout)
08:32:40 --> nhnt11 has joined #instantbird
08:35:10 --> aleth has joined #instantbird
08:35:10 * ChanServ sets mode +h aleth 
08:36:00 --> qlum has joined #instantbird
08:46:06 <-- aleth has quit (Quit: Ciao)
08:46:11 --> aleth has joined #instantbird
08:46:11 * ChanServ sets mode +h aleth 
08:48:24 --> jb has joined #instantbird
08:56:48 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
08:59:19 <-- nhnt11 has quit (Ping timeout)
09:04:13 --> nhnt11 has joined #instantbird
09:19:51 <-- gerard-majax has quit (Ping timeout)
09:20:30 --> alexis has joined #instantbird
09:20:37 <alexis> heya
09:20:53 <alexis> I'm wondering, on instantbird, when I get links and I try to click on them, nothing happens
09:21:11 <alexis> I need to do "right click" → copy url and then paste it in my browser.
09:21:16 <alexis> Any idea what's hapenning?
09:22:24 <nhnt11> alexis: Are you running a Linux distribution? If so, check this out: https://bbs.archlinux.org/viewtopic.php?pid=907398#p907398
09:23:20 --> flo-retina has joined #instantbird
09:23:20 * ChanServ sets mode +qo flo-retina flo-retina 
09:24:49 <alexis> nhnt11: the protocol handler property is already set to true for http / https
09:25:13 <alexis> ah wait
09:25:29 <alexis> I was looking for the "external"
09:25:46 <alexis> Any reason why these aren't set to true by default with the instantbird distribution?
09:26:38 <nhnt11> It's a bug that crept up a while ago, but I don't know much about it because I don't run Linux. You'll have to ask aleth :)
09:28:31 <alexis> thanks anyway, that solved the issue
09:28:36 <nhnt11> np
09:32:20 <flo-retina> alexis: you mean 'any reason why the preferences to get http/https to be handled externally aren't true so that we don't have to hack with the external protocol service?' ?
09:32:48 <flo-retina> alexis: if so, the reason is that we need to be able to display http content to display the Twitter OAuth dialog when someone connects a Twitter account.
09:33:06 <alexis> flo-retina: that's my question yep
09:33:43 <alexis> flo-retina: isn't there a way to force the display of the twitter OAuth dialog internally?
09:34:00 <alexis> (bypassing this option for this particular usecase)
09:34:07 <flo-retina> alexis: no :(.
09:34:15 <alexis> ah
09:34:29 <alexis> too bad
09:34:35 <flo-retina> alexis: we could display an http page. The problem is that clicking any link on it would open in Firefox, instead of navigating inside the twitter website
09:35:10 <alexis> that may be a better alternative
09:35:24 <alexis> because having links not doing anything is *really* annoying
09:35:53 <alexis> or maybe there is a way to detect a click on a link and provide the user with some help?
09:38:35 <aleth> alexis, flo-retina: I'm pretty sure you're just experiencing bug 1877
09:38:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1877 nor, --, ---, nobody, NEW, Enable gio after Linux buildslave distro is updated
09:39:10 <flo-retina> alexis: " having links not doing anything is *really* annoying" is definitely a bug. It happens only on Linux.
09:39:15 <aleth> Which is a problem on our end that definitely should be fixed.
09:39:39 <flo-retina> yeah, we need a new linux build VM...
09:39:43 <aleth> alexis: It only happens for fairly new distros, which is why more and more people are seeing that problem.
09:40:06 <aleth> (as those get more widespread...)
09:41:37 <aleth> flo-retina: Sorry about the nits I overlooked in the context menu patch :-S
09:41:53 <flo-retina> alexis: "clicking any link on it would open in Firefox, instead of navigating inside the twitter website" & "that may be a better alternative" -> the Twitter login flow requires navigating through pages.
09:42:12 <flo-retina> aleth: do you have nice context menus today? :)
09:42:31 * aleth hopes all the moving code around with months inbetween changes counts as an excuse ;)
09:42:37 <aleth> flo-retina: They do seem to work :)
09:43:05 <flo-retina> aleth: I don't need an excuse. (I could do with a review on bug 2138 though ;))
09:43:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2138 nor, --, 1.5, florian, NEW, A conversation on hold should open itself in a tab when the user is pinged
09:43:34 <aleth> Heh. You'll get one especially as that is an annoying regression :D
09:43:46 <flo-retina> aleth: I think we will likely want to do some polishing of these context menus, but I wanted them in nightlies to try them on real use cases before saying what needs to get done
09:43:54 <aleth> flo-retina: I agree completely
09:44:28 <flo-retina> aleth: something I already dislike is the disappearing "show logs" item; I think we should disable it instead of hiding it; as that's what we do for the contacts context menu in the blist.
09:44:29 <aleth> It's a shame your cursor:context-menu idea didn't work :(
09:45:00 <flo-retina> aleth: it does work. I initially thought about using cursor:default, then discovered context-menu. I asked here how it looks on Windows, and on Windows it acts as default.
09:45:06 <-- GeekShadow has quit (Ping timeout)
09:45:13 <flo-retina> I would need to see how ugly it looks on Linux though (maybe we can ifdef?)
09:45:59 --> dionisos has joined #instantbird
09:46:00 <aleth> flo-retina: I can screenshot it later. The problem is it exists but is not supplied by the native cursor set
09:46:14 <flo-retina> that seems unfortunate :-/
09:46:24 <aleth> Not sure where it's coming from (gecko? gnome fallback?)
09:46:53 <flo-retina> It's also not obvious to me if making the "Add contact" item disappear is the right behavior.
09:47:03 <flo-retina> And it's now strange that it's missing in the tab context menu ;).
09:47:12 <aleth> Disabling Show Logs sounds good to me.
09:47:18 <aleth> Not so sure about Add contact
09:47:48 <aleth> I'd like to add it to the tab context menu (there's a bug open for that) but there is a problem
09:48:30 <aleth> It really neds a solution to bug 1547 for it to work as expected
09:48:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1547 nor, --, ---, nobody, NEW, Check for open conversations when adding a buddy
09:49:10 --> GeekShadow has joined #instantbird
09:56:15 <aleth> Feedback on that bug would be appreciated ;)
09:59:49 <instantbot> aleth@instantbird.org granted review for attachment 2798 on bug 2138.
09:59:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2138 nor, --, 1.5, florian, NEW, A conversation on hold should open itself in a tab when the user is pinged
10:02:41 --> gerard-majax has joined #instantbird
10:04:03 --> clokep has joined #instantbird
10:04:03 * ChanServ sets mode +o clokep 
10:10:48 <flo-retina> aleth: sorry it's been collecting dust for so long :(
10:11:20 <-- jb has quit (Ping timeout)
10:12:00 <flo-retina> aleth: I guess the r- already on the patch wasn't motivating to start looking at the patch ;)
10:12:53 <-- nhnt11 has quit (Ping timeout)
10:14:17 --> nhnt11 has joined #instantbird
10:20:12 <-- dionisos has quit (Ping timeout)
10:26:31 <aleth> flo-retina: I don't really like the patch, the question is if/how one can do better
10:26:56 <aleth> It's been a while, but I remember being stuck.
10:28:17 * flo-retina adds an r- to Mook's collection in https://bugzilla.mozilla.org/show_bug.cgi?id=896216
10:28:34 --> Xvost has joined #instantbird
10:28:53 <clokep> flo-retina: So...you r-ed the Moz23 update...will you put up a new patch with what you had to do for Mac?
10:29:19 <flo-retina> clokep: I hesitated. It was late. I just gave instructions instead :-P.
10:29:48 <clokep> flo-retina: OK. It's kind of sily for me to do it though since I can't test.
10:29:56 <clokep> But I'll try to, when I get time.
10:30:07 <clokep> I guess we're not in a rush since Windows nightlies aren't working...
10:30:27 <flo-retina> well, you can test that it doesn't break anything on your side ;)
10:30:52 <flo-retina> but yes, I'm really annoyed by the Windows nightly situation
10:31:08 <flo-retina> It's got 6GB of ram. Anything else we can do to it? :(
10:32:09 <clokep> Is it still just taking forever to link libxul?
10:32:11 <aleth> It's sad the extra RAM didn't fix it :(
10:32:51 <flo-retina> clokep: still buildbot timeouting after 3600s without output while linking xul.dll, yes
10:34:50 <clokep> :-/
10:34:57 <Xvost> Как изменить сочетание клавиш, чтобы было:
10:34:57 <Xvost> - Enter - переход на новую строку;
10:34:57 <Xvost> - Ctrl+Ентер - отправка сообщения
10:34:57 <Xvost> How do I change the keyboard shortcut to it:
10:34:57 <Xvost> - Enter - a new line;
10:34:57 <Xvost> - Ctrl + Enter - send message
10:35:18 <nhnt11> Xvost: I think there's an addon for that, hold on
10:35:28 <clokep> Xvost: https://addons.instantbird.org/en-US/instantbird/addon/308
10:35:34 <nhnt11> There you go :P
10:37:00 <aleth> Yay add-ons :)
10:39:05 <Xvost> clokep: Thank you!
10:39:13 <clokep> You're welcome.
10:39:25 <instantbot> clokep@gmail.com denied review for attachment 2801 on bug 2132.
10:39:26 <clokep> aleth: Does that make sense ^
10:39:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2132 nor, --, ---, qheaden, ASSI, Sender name not set in Yahoo conversations
10:44:32 <Xvost> С 31 августа Администрация социальной сети ВКонтакте отключает поддержку XMPP, предлагая разработчикам мессенджеров переходить на их API. Стоит ли ожидать поддержки ВКонтакте по новому протоколу.
10:44:32 <Xvost> On August 31 the social network VKontakte Administration disables support XMPP, offering developers messengers to pass on their API. Can we expect support for a new protocol VKontakte
10:45:18 <clokep> Probably not, unless someone creates a patch for it. I've looked at the API (http://vk.com/dev/methods) and it's not insane...but I don't have the time to look at working on it right now.
10:46:15 <clokep> We would certainly help someone work on this though. :)
10:46:34 <aleth> clokep: I don't remember whether an alias in the account prefs is applied by the core or by the prpls
10:49:47 <clokep> aleth: We certainly don't do it for IRC....
10:49:49 <aleth> http://lxr.instantbird.org/instantbird/source/chat/modules/imThemes.jsm#325
10:50:12 <clokep> Any thoughts on the clean vs. dirty username?
10:50:25 <aleth> I don't know what the difference is for yahoo
10:50:35 <clokep> One is stripped of the @yahoo.com
10:50:50 <aleth> That's the one we should use then.
10:51:06 <clokep> That one that is stripped?
10:51:11 <aleth> Yes
10:51:11 <clokep> Other email addresses are NOT stripped though.
10:51:26 <aleth> Yahoo usernames never include the email address
10:51:37 <clokep> I don't know if that's true or not...
10:51:43 <aleth> But I hope qheaden is consistent about that...
10:52:00 <clokep> I think there are other addresses (like rocketmail?, maybe?)
10:52:06 * clokep shrugs.
10:52:11 <clokep> I don't have a strong opinion on that aspect.
10:52:12 <aleth> clokep: The Yahoo web client I was testing with certainly never includes the yahoo.* part
10:52:19 <clokep> OK.
10:52:59 <aleth> I'm not sure what the web client does for non-yahoo domains though.
10:53:04 <flo-retina> aleth: "I don't remember whether an alias in the account prefs is applied by the core or by the prpls" I'm afraid it's applied by libpurple's core, and by each of our JS-prpls who decided this was useful (ie. only JS-XMPP)
10:53:07 <aleth> (If that can even happen)
10:53:16 <flo-retina> and I remember being annoyed when doing that in JS-XMPP
10:53:37 <clokep> :-/ I didn't realize that.
10:53:40 <clokep> That's not good.
10:53:46 <clokep> (That sounds like a bug.)
10:53:52 <flo-retina> http://lxr.instantbird.org/instantbird/source/chat/protocols/xmpp/xmpp.jsm#1340
10:54:26 <aleth> flo-retina: http://lxr.instantbird.org/instantbird/source/chat/modules/imThemes.jsm#325 is not enough?
10:54:51 <flo-retina> aleth: headerFooterReplacements is mostly irrelevant
10:55:09 <flo-retina> aleth: http://lxr.instantbird.org/instantbird/source/chat/modules/imThemes.jsm#411
10:55:19 <aleth> flo-retina: Should have linked to line 419
10:55:32 <aleth> And there you are right, it has to be set on the message.
10:55:55 --> dionisos has joined #instantbird
10:56:18 <flo-retina> aleth: and it looks like the ib-sender class may need to be on senderDisplayName too :S
10:56:55 <aleth> Right :-S
10:57:05 * clokep sighs.
10:57:11 <aleth> Well, really we should remove that duplication.
10:57:16 <flo-retina> aleth: for XMPP we set the alias at http://lxr.instantbird.org/instantbird/source/chat/protocols/xmpp/xmpp.jsm#259
10:57:16 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
10:57:35 <flo-retina> aleth: we should also decide what the expected behavior is :-S
10:57:52 <aleth> clokep, flo-retina: I guess yahoo should just follow XMPP then? :-S
10:58:27 <aleth> How/when the statusInfo.displayName is used is the real question.
10:58:48 <aleth> I think that might not make sense for yahoo.
10:59:07 <aleth> On XMPP we probably have it because the full name with the resource string is so ugly
11:00:32 <flo-retina> aleth: the display name should be used. All the time. It's there to be *displayed*
11:00:43 <flo-retina> aleth: the problem is: what do we do when the display name isn't set?
11:00:55 <flo-retina> we are supposed to display the account's _local alias_
11:01:06 <flo-retina> but should we display that instead of the display name, or only if the display name isn't set?
11:01:12 <flo-retina> it's a mess
11:01:24 <aleth> I'm not sure I agree apart from that it's a mess...
11:01:24 <flo-retina> aleth: I'm as annoyed by aliases as you are by normalized names ;).
11:01:45 <aleth> It would be nice if the alias didn't exist and we just used the display name as the alias.
11:01:58 <flo-retina> the account alias?
11:02:05 <aleth> Yes (advanced options)
11:02:07 <flo-retina> (don't just say "alias", there are plenty of different aliases in this mess)
11:02:28 * nhnt11 uses "Me" as his alias
11:02:52 <aleth> I'm pretty sure there were some messy reasons why it couldn't be simplified though :-/
11:03:46 <flo-retina> aleth: I think we can simplify the code a lot, if we simplify the UX first
11:04:43 <aleth> The display name really /is/ a local alias, which we should also use as default username where that makes sense, when configuring accounts.
11:05:40 <aleth> The problem is when users have two accounts only differentiated by the username: They probably want that username displayed in the conversation then
11:17:41 <instantbot> New Core - General bug 2139 filed by aleth@instantbird.org.
11:17:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2139 nor, --, ---, nobody, NEW, Add ib-sender class to %senderScreenName and %senderDisplayName
11:18:21 <nhnt11> listen
11:18:25 <nhnt11> Wrong window sorry
11:18:42 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 2802 on bug 2139.
11:20:05 --> jb has joined #instantbird
11:27:04 * aleth wonders how the ranking database is coming along
11:28:23 <nhnt11> aleth: I'm doing some code cleanup right now, but unfortunately there hasn't been much progress the last couple days
11:44:35 <-- nhnt11 has quit (Ping timeout)
11:49:23 --> clokep_ has joined #instantbird
11:53:14 <Xvost> clokep: Создайте, пожалуйста, предложение по разработке плагина для подключения ВКонтакте через их API в бакг-трекере или там, где вы подобное публикуете. Сам я не могу этого сделать в виду незнания английского языка.
11:53:14 <Xvost> Please create a proposal to develop a plug-in to connect VKontakte via their API in bakg tracker, or wherever you like publishing. I myself can not do that in mind the lack of knowledge of the English language.
11:55:41 <Xvost> Ещё такой вопрос. Есть ли плагин, который бы показывал всплывающие сообщения в трее:
11:55:42 <Xvost> - о новых сообщения;
11:55:42 <Xvost> - входе/выходе контакта в сеть;
11:55:42 <Xvost> - смене статуса контакта.
11:55:42 <Xvost> Another question. Is there a plugin that would show pop-up messages in the tray:
11:55:42 <Xvost> - For new messages;
11:55:42 <Xvost> - Input / output contact to the network;
11:55:42 <Xvost> - Change the status of the contact.
11:56:25 <clokep_> Xvost: New messages is supported out of the box, check the options.
11:56:37 <clokep_> For status changes there's an extension https://addons.instantbird.org/en-US/instantbird/addon/253
11:57:05 <clokep_> Xvost: Please file a bug on http://bugzilla.instantbird.org for VK, your English seems fine.
11:57:13 <clokep_> I'm not sure what "Input / output contact to the network" means.
11:57:43 <aleth> "x is now online/offline" I guess
11:57:50 <flo-retina> aleth: "The display name really /is/ a local alias" Not really no. It is set locally, but it's sent to the server for protocols where it's possible.
12:00:41 * clokep_ doesn't really understand why we have a display name and a local alias.
12:00:55 <clokep_> But I don't really want to be dragged into this conversation. :)
12:02:04 <flo-retina> clokep_: you definitely don't want to!
12:02:36 <flo-retina> clokep_: short answer though is: the display name is something we wanted. The local alias is something that we inherited from libpurple.
12:04:14 <Xvost> clokep_: At the arrival of new messages pop-up notification in the system tray no. My operating system - Ubuntu.
12:04:14 <Xvost> Thanks for the feedback about my English, but, unfortunately, it's just a translator
12:05:10 <aleth> Xvost: You mean the ubuntu-specific messaging menu. You are right, that's not supported yet.
12:06:36 <-- Xvost has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com)
12:06:40 --> Xvost has joined #instantbird
12:11:21 <clokep_> Xvost: That's fine though. :) Putting a report in the two languages would be fine w/ me.
12:11:27 <clokep_> flo-retina: That seems like a bad reason. ;)
12:11:49 <-- Xvost has left #instantbird ()
12:12:27 <flo-retina> clokep_: that's why I said we could simplify ;)
12:13:54 --> Xvost has joined #instantbird
12:29:02 <clokep_> flo-retina: OK, let's do it. :)
12:29:08 <clokep_> Make qheaden do it? :P
12:40:06 <-- jb has quit (Ping timeout)
13:02:22 <-- qlum has quit (Connection reset by peer)
13:03:05 --> qlum has joined #instantbird
13:12:32 <-- Xvost has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com)
13:47:55 --> mconley has joined #instantbird
13:54:09 <clokep_> Looks like there's a new version of MozillaBuild out...if anyone cares. ;)
13:58:14 <flo-retina> I'm afraid that won't fix the timeouting issue :(
14:03:43 <clokep_> It wasn't in reference to that at all.
14:04:39 --> jb has joined #instantbird
14:04:46 <flo-retina> nah, it's just that I would care if it had any chance of fixing it
14:05:05 --> Xvost has joined #instantbird
14:11:15 <instantbot> New Core - General bug 2140 filed by aleth@instantbird.org.
14:11:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2140 nor, --, ---, nobody, NEW, Nightlies depend on gcc >= 4.5 via libstdc++
14:13:27 <clokep_> flo-retina: So what changed that caused this issue? Rebuilding the hard drive array?
14:20:14 <flo-retina> clokep_: we are currently not on a raid array
14:20:21 <flo-retina> just on a new 3TB SATA disk
14:23:30 <clokep_> Ah, I see.
14:34:10 <flo-retina> clokep_: FYI, I just VNC'ed into the Windows build VM. The xul.dll file is there.
14:34:18 <flo-retina> so we don't fail to create it.
14:34:42 <flo-retina> I removed it and launched the command to recreate it with a 'time' to see if it really takes more than 3600s
14:40:50 --> qheaden_school has joined #instantbird
14:41:12 <qheaden_school> Hi everyone.
14:41:34 <qheaden_school> clokep_: In bug 2132, don't we have to use imAccount to obtain the alias?
14:41:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2132 nor, --, ---, qheaden, ASSI, Sender name not set in Yahoo conversations
14:46:12 <qheaden_school> Okay, going to class.
14:46:17 <-- qheaden_school has quit (Quit: http://www.mibbit.com ajax IRC Client)
14:48:47 * flo-retina wants ranking in his awesometab :-].
14:49:29 <flo-retina> I find it very distracting to see at the top of the list names of people you haven't talked to in months or years, when you are attempting to start _quickly_ a conversation with someone you talk to several times a month.
14:50:01 <aleth> We should land bug 2060 and get nhnt11 to put the next patch up ;)
14:50:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2060 nor, --, ---, nobody, UNCO, Can't view previous days' log entries for certain Jabber account
14:50:12 <aleth> bah bug 2066
14:50:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should suggest chat rooms
14:50:31 * flo-retina wonders waht 2060 is about
14:51:03 <aleth> I don't think we ever found out :-/
14:52:03 <-- Xvost has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com)
14:52:33 <clokep_> qheaden: Apparently we do...we were just discussing how this seems wrong, check the logs.
14:52:57 <aleth> qheaden: In particular look at the links to XMPP
14:53:15 <aleth> (or improve all the things :) )
14:58:26 <clokep_> aleth: , bug 2091, opinions?
14:58:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2091 nor, --, ---, qheaden, ASSI, /join chatroom does not do anything.
14:58:39 <clokep_> (Also, why was there a join command at all? It doesn't seem that one is defined. :-S)
15:03:22 <aleth> clokep_: I'm puzzled by that patch. Where is the current help string coming from? "join <room>:  Join a chat room on the Yahoo network"
15:03:49 <clokep_> aleth: I'm almost positive it's coming from libpurple.
15:04:02 <aleth> I guess it must be...
15:30:20 <flo-retina> linking xul.dll finished. It took 56m8.490s
15:39:34 --> skeledrew1 has joined #instantbird
15:39:51 <clokep_> That's awfully close to 3600s. ;)
15:40:21 <-- skeledrew has quit (Ping timeout)
15:43:18 <flo-retina> clokep_: yes, I'm looking into bumping the timeout to 7200 for the compile step (it's the timeout we have on the distribute step)
15:48:14 <-- skeledrew1 has quit (Ping timeout)
15:50:04 --> skeledrew has joined #instantbird
15:50:44 <-- instant-buildbot has quit (Quit: buildmaster reconfigured: bot disconnecting)
15:50:52 --> instant-buildbot has joined #instantbird
15:50:52 * ChanServ sets mode +v instant-buildbot 
15:51:04 <instant-buildbot> build #1051 of win32-nightly-default is complete: Failure [failed shell]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1051
15:54:24 <clokep_> :-D
15:54:47 <flo-retina> ?
15:55:15 <clokep_> Cleaning failed :P Nothing seems to work.
15:56:25 <flo-retina> nah, it's my bad. I didn't navigate correctly between buildbot's known bugs.
16:26:24 --> Mook_as has joined #instantbird
16:30:00 --> qheaden_school has joined #instantbird
16:30:44 <qheaden_school> Okay. I'm on my break now.
16:35:03 --> nhnt11 has joined #instantbird
16:36:22 <qheaden_school> clokep_: So http://log.bezut.info/instantbird/today/#m177 is basically saying that we need to use imAccount?
16:37:57 <aleth> qheaden_school: http://lxr.instantbird.org/instantbird/source/chat/protocols/xmpp/xmpp.jsm#259
16:38:19 <aleth> Note the alias goes into msg.alias not msg.who
16:40:47 <qheaden_school> Ahh okay.
16:41:08 <qheaden_school> What is the who argument for?
16:41:21 <flo-retina> for the username
16:41:25 <aleth> who always should be set to the username
16:41:30 <aleth> alias is optional
16:41:46 <aleth> (on XMPP we always set it as the usernames are terrible...)
16:42:43 <qheaden_school> aleth: You've got a point on that one. ;)
16:47:29 <qheaden_school> flo-retina: So statusInfo.display name is a better way of getting the alias/
16:47:30 <qheaden_school> ?
16:48:36 <flo-retina> I don't know without looking at the code
16:48:39 <aleth> I think for yahoo I'd just use the cleanUsername as you suggested for who, and an alias if it's set in the advanced options
16:48:42 <flo-retina> r? me if you think I need to look ;).
16:49:23 <aleth> Always using the displayname as the alias if nothing else is set would be something that should be done consistently across protocols
16:49:32 <aleth> (if we decided it was wanted)
16:50:33 <qheaden_school> No, I'm just trying to decide what to put as _alias: this._account.imAccount.alias, or this._account.statusInfo.displayName.
16:51:02 <aleth> this._account.imAccount.alias
16:51:35 <-- jb has quit (Connection reset by peer)
16:51:42 <flo-retina> aleth: and statusInfo.displayName is the account alias isn't set?
16:52:21 <aleth> flo-retina: I think if we did that for yahoo we should do it everywhere. And we should discuss it first
16:52:49 <aleth> (It would be weird to have the displayname rather than the nick show up for IRC for example)
16:53:19 * aleth not sure what the expected behaviour is here
16:54:32 <aleth> The other problem with using the displayName is if you have two accounts with different usernames
16:54:46 <qheaden_school> flo-retina, aleth: These are the changes I want to make http://pastebin.instantbird.com/309913
16:55:25 <aleth> Probably not "acocunt" but looks good otherwise
16:56:10 * qheaden_school is bad with his typing today. :)
16:56:23 <qheaden_school> Okay, I'll upload a new patch in a few.
16:58:31 <qheaden_school> flo-retina: Did you want me to r=? you instead of clokep this time?
16:59:06 * qheaden_school knows clokep_ probably wants a break from reviewing my patches. :P
16:59:48 <flo-retina> if you want. clokep_ is usually faster though ;)
17:00:31 --> jb has joined #instantbird
17:01:24 <clokep_> aleth: "this._account.imAccount.alias" why?
17:01:43 <aleth> clokep_: If we have the option in the advanced account options, it should work ;)
17:01:47 * clokep_ was going to say the opposite w/ the same conviction.
17:02:02 <clokep_> OK.
17:02:05 <aleth> Otherwise remove the option there (I'd be fine with that)
17:02:10 <flo-retina> clokep_: you think I'm faster? :-o
17:02:17 <clokep_> Why does XMPP not use it?
17:02:49 <aleth> XMPP (I believe) /always/ tries to set msg.alias somehow because usernames are so ugly (with the resource etc)
17:03:20 <clokep_> That didn't answer my question. :)
17:03:25 <clokep_> Why does that use display name instead?
17:03:28 <aleth> http://lxr.instantbird.org/instantbird/source/chat/protocols/xmpp/xmpp.jsm#259
17:04:04 <clokep_> OK.
17:04:09 <clokep_> I don't see why we shouldn't do that also.
17:04:19 <-- jb has quit (Ping timeout)
17:04:47 <aleth> I'd say because we can assume that for most users, they will then never see their username in the conversation
17:05:05 <aleth> Maybe that's the expected behaviour, but it would be a change
17:05:27 <qheaden_school> So displayName isn't always in sync with alias?
17:05:37 <aleth> qheaden_school: It's a mess.
17:05:40 <clokep_> aleth: "I'd say because we can assume that for most users, they will then never see their username in the conversation" What?
17:05:44 <qheaden_school> :P
17:05:53 <clokep_> Most users won't see their username in the conversation? How so? :-S
17:05:56 * qheaden_school smells a new bug
17:06:29 <clokep_> aleth: Do you mean "With that change, most users would never see their username in the conversation"?
17:06:55 <aleth> Yes (i.e. as long as they have a displayname set)
17:07:09 <clokep_> OK.
17:07:16 <clokep_> I thought you were talking about currently. ;)
17:07:28 <clokep_> qheaden_school: They're totally different things.
17:07:32 <aleth> No, currently they see nothing at all ;)
17:07:37 <clokep_> I think your current way is OK, attach the patch and r? aleth, please
17:08:30 <qheaden_school> clokep_: Okay. Also, is this alias/displayName stuff one of the abstractions I can make?
17:08:34 <-- gerard-majax has quit (Ping timeout)
17:11:23 <clokep_> qheaden_school: It's kind of an abstraction, yes. But more of a fix. If you'd like to do that, flo-retina would appreciate it. :)
17:11:40 <-- qheaden_school has quit (Quit: http://www.mibbit.com ajax IRC Client)
17:11:45 --> qheaden_school has joined #instantbird
17:11:45 <aleth> qheaden_school: You'd have to discuss it with him first ;)
17:12:18 <aleth> There's different aliases and it's not completely clear how they all should relate to the displayname.
17:12:28 <qheaden_school> :-S
17:12:33 <qheaden_school> Okay.
17:12:44 <aleth> (local vs serverside)
17:13:36 <qheaden_school> I have to go to class now. I'll post a patch when I get home.
17:15:38 <-- qheaden_school has quit (Quit: http://www.mibbit.com ajax IRC Client)
17:17:11 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:20:18 <-- GeekShadow has quit (Quit: leaving)
17:23:28 --> GeekShadow has joined #instantbird
17:34:15 --> jb has joined #instantbird
17:46:29 <-- aleth has quit (Quit: Ciao)
17:52:07 --> gerard-majax has joined #instantbird
17:54:08 --> flo-retina has joined #instantbird
17:54:08 * ChanServ sets mode +qo flo-retina flo-retina 
17:54:34 <flo-retina> hmm, Windows nightlies were taking 4 hours before they started failing.
17:54:57 <flo-retina> I started the current in progress nightlies 2 hours ago, I guess I'll need to wait for another 2-3 hours before knowing the result :-/
17:55:09 <clokep_> :(
17:55:13 * clokep_ is surprised they take that long.
17:58:10 <flo-retina> there's likely some overhead due to the VM
17:58:35 <flo-retina> I wonder if we could get a not-so-expansive PC that I could stack above the mac mini, to have a Windows slave on real hardware
17:58:58 <flo-retina> clokep_: I've done a mozilla-central build again today on my lenovo laptop. Took 92 minutes. That's almost reasonable.
17:59:07 <flo-retina> (and it's not an SSD)
18:01:25 <flo-retina> are there decent (and affordable) PCs of the size of a mac mini?
18:04:42 --> clokep_wp8 has joined #instantbird
18:05:09 * clokep_wp8 always wanted one of http://shop.lenovo.com/us/en/desktops/thinkcentre/m-series-tiny/ ;-)
18:05:23 <-- clokep_wp8 has quit (Connection reset by peer)
18:08:43 <flo-retina> why is hte CPU an i5? :-/
18:12:47 <clokep_> Instead of an i7?
18:12:48 <clokep_> Idk.
18:15:58 <flo-retina> clokep_: yeah, I would like a small machine, but still powerfull
18:16:10 <flo-retina> if it's not faster than a VM running on a fast desktop PC, it's not really useful
18:19:54 <clokep_> Yes, of course.
18:20:00 <clokep_> How weak is this VM?
18:20:16 <nhnt11> 5's aren't necessarily weaker than i7's in all cases afaik...
18:20:31 * nhnt11 shuts up
18:33:07 <-- nhnt11 has quit (Ping timeout)
18:35:08 --> nhnt11 has joined #instantbird
18:51:25 <-- qlum has quit (Ping timeout)
18:54:16 --> qlum has joined #instantbird
18:57:30 <-- jb has quit (Ping timeout)
19:14:39 <flo-retina> clokep_: the host of the VM is a modern i7 with plenty of cores, and plenty of memory. The VM has likely one or two cores, and currently 6GB of ram (used to be 3).
19:19:08 --> jb has joined #instantbird
19:55:59 <instant-buildbot> build #1052 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1052
19:56:32 <nhnt11> :)
20:04:51 --> rosonline has joined #instantbird
20:07:44 <-- qlum has quit (Quit: Getting the <censored> out.)
20:08:28 --> qlum has joined #instantbird
20:15:56 <clokep_> :)
20:18:31 <-- rosonline has quit (Connection reset by peer)
20:21:01 <-- jb has quit (Connection reset by peer)
20:24:09 --> rosonline has joined #instantbird
20:26:55 --> jb has joined #instantbird
20:27:44 <qheaden> Hello.
20:39:13 <instantbot> qheaden@phaseshiftsoftware.com requested review from aleth@instantbird.o rg for attachment 2803 on bug 2132.
20:39:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2132 nor, --, ---, qheaden, ASSI, Sender name not set in Yahoo conversations
20:50:26 <-- jb has quit (Ping timeout)
20:55:06 --> EionRobb has joined #instantbird
21:00:45 --> Xvost has joined #instantbird
21:01:22 <-- Xvost has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com)
21:37:47 <flo-retina> maybe it didn't need the 6GB :)
21:39:53 <flo-retina> pff, the patch from https://bugzilla.mozilla.org/show_bug.cgi?id=910226 doesn't apply cleanly
21:40:08 <flo-retina> that's the guarantee that the next Tb chat/ merge will be painful :(
21:48:17 <flo-retina> in https://bugzilla.instantbird.org/attachment.cgi?id=2802 there shouldn't be a ';' at the end of the "+  "<span class=\"ib-sender\">" + TXTToHTML(aName) + "</span>";" line, right?
21:48:46 <clokep_> I never know what to do with functions that don't have any { } around them.
21:49:20 <EionRobb> why would it matter if you have { } or not, you should always use ; :)
21:51:29 <Mook_as> wouldn't you want the ; there to make sure you don't continue the expression? (not that it matters in this case)
21:51:43 <Mook_as> function foo() expr
21:51:43 <Mook_as> +1
21:52:16 <flo-retina> EionRobb: so you write function() { /* stuff */ }; ?
21:52:47 * clokep_ just thinks it looks weird without the ; in this situation.
21:52:53 <flo-retina> Mook_as: so I don't really understand what you meant
21:53:55 <flo-retina> clokep_: I also think it looks weird, but I suspect that's more because there's no empty line after the function / before a |const stuff = ...|
21:54:18 <Mook_as> I; ;t;h;i;n;k; ;y;o;u; ;m;e;a;n; ;E;i;o;n;R;o;b;b
21:54:38 <flo-retina> Mook_as: you said "function foo() expr" and "+1"
21:58:16 <Mook_as> yeah, that was for the _previous_ line (and then I went afk)
21:58:54 <Mook_as> anyway: since expr + 1 is a valid expression, that gets to be the function definition... as opposed to just expr (and +1 on the next line being, well, positive one)
21:59:56 <flo-retina> ah
22:02:22 <flo-retina> bah, I can't figure out what I would like, so I guess I'll just r+ as is :-S
22:04:24 --> florian has joined #instantbird
22:07:44 <-- florian has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
22:08:07 <flo-retina> arg, the mozStorage patch I r+'ed for Tb breaks stuff :(
22:08:19 --> florian has joined #instantbird
22:13:10 <instantbot> florian@instantbird.org granted review for attachment 2802 on bug 2139.
22:13:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2139 nor, --, ---, aleth, ASSI, Add ib-sender class to %senderScreenName and %senderDisplayName
22:14:16 <-- qlum has quit (Quit: Getting the <censored> out.)
22:16:38 <flo-retina> :(
22:16:46 <flo-retina> already the third thing I fix in that patch :(
22:17:38 <Mook_as> hey, it's not like my ever-bouncing patch ;)
22:17:40 <flo-retina> I guess I need to re-review the whole patch more carefully
22:18:16 <flo-retina> Mook_as: well, it's a bit different. That patch was needed ASAP because it the bug caused crashes during unit tests ;)
22:23:58 <-- rosonline has quit (Client exited)
22:24:41 <-- florian has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
22:25:07 --> florian has joined #instantbird
22:26:38 <-- clokep_ has quit (Quit: http://www.mibbit.com ajax IRC Client)
22:27:28 <flo-retina> aleth: If I add c lokep_ to my contact list from the context menu, the "Add contact" item is no longe visible if I look at the context menu again. But if I add E ven, the "Add contact" item is still here... I suspect a normalization issue ;).
22:35:14 <flo-retina> too bad I don't have any reviewer around :-S.
22:35:41 <flo-retina> This doesn't feel critical enough that I would check it into c-c without any review, but it may still significantly break the next nightly :(
22:38:56 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/f0cdff383d78 - David Rajchenbach-Teller - Bug 910226 - Adding finalizations to imContacts.js, r=flo.
22:38:57 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/0397b21c6c39 - aleth - Bug 2139 - Add ib-sender class to %senderScreenName% and %senderDisplayName%, r=fqueze.
22:38:58 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/4f8f4112202f - Florian Quèze - Follow-up to 'Bug 910226 - Adding finalizations to imContacts.js' to fix bustage, r=bustage-fix.
22:38:59 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/07cc8479483a - Florian Quèze - Bug 2138 - A conversation on hold should open itself in a tab when the user is pinged, r=aleth.
22:47:47 <-- GeekShadow has quit (Ping timeout)
22:48:18 <-- mconley has quit (Input/output error)
22:58:03 --> GeekShadow has joined #instantbird
22:58:51 <instant-buildbot> build #458 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/458
23:00:58 <flo-retina> Good night :)
23:01:11 --> jb has joined #instantbird
23:02:41 <-- dionisos has quit (Ping timeout)
23:16:31 --> clokep has joined #instantbird
23:16:31 * ChanServ sets mode +o clokep 
23:21:03 <instantbot> clokep@gmail.com set the Resolution field on bug 2138 to FIXED.
23:21:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2138 nor, --, 1.5, florian, RESO FIXED, A conversation on hold should open itself in a tab when the user is pinged
23:21:43 <instantbot> clokep@gmail.com set the Resolution field on bug 2139 to FIXED.
23:21:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2139 nor, --, 1.5, aleth, RESO FIXED, Add ib-sender class to %senderScreenName and %senderDisplayName
23:30:57 <-- jb has quit (Quit: jb)
23:34:05 <-- nhnt11 has quit (Ping timeout)
23:48:00 --> mconley has joined #instantbird