All times are UTC.
00:02:59 <instant-buildbot> build #443 of win32-onCommit is complete: Failure [failed compile] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/443 blamelist: Florian Qu?ze <florian@instantbird.org>, Quentin Headen <qheaden@phaseshiftsoftware.com> 00:30:06 <instant-buildbot> build #949 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/949 00:41:50 <-- skeledrew has quit (Ping timeout) 00:55:33 <-- dew has quit (Ping timeout) 00:56:06 --> dew has joined #instantbird 01:04:41 <-- Mook_as has quit (Quit: Mook_as) 02:06:05 --> Mook has joined #instantbird 02:09:08 <-- dionisos has quit (Ping timeout) 03:09:15 <instant-buildbot> build #950 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/950 03:28:56 <-- florian has quit (Connection reset by peer) 03:28:58 --> florian has joined #instantbird 03:43:51 <-- wnayes has quit (Quit: wnayes) 03:52:49 <-- Mook has quit (Quit: Mook) 03:52:52 <-- mconley has quit (Input/output error) 04:05:11 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2752 on bug 2117. 04:05:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2117 nor, --, ---, qheaden, ASSI, /invite should print a system message to show it's done something 05:28:19 <-- EionRobb has quit (Quit: Leaving.) 05:35:17 --> EionRobb has joined #instantbird 05:38:39 --> jb has joined #instantbird 05:45:36 <-- EionRobb has quit (Quit: Leaving.) 05:48:01 <-- jb has quit (Connection reset by peer) 05:50:30 --> jb has joined #instantbird 06:08:46 <instant-buildbot> build #1046 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1046 06:13:18 --> FireFly_TB has joined #instantbird 06:19:41 --> EionRobb has joined #instantbird 06:25:10 --> dionisos has joined #instantbird 06:34:42 <-- jb has quit (Ping timeout) 07:17:00 --> gerard-majax has joined #instantbird 08:09:28 --> jb has joined #instantbird 08:18:08 <-- jb has quit (Ping timeout) 08:23:43 --> jb has joined #instantbird 08:25:59 <-- jb has quit (Ping timeout) 08:54:37 --> jb has joined #instantbird 08:58:04 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 08:59:40 <-- florian has quit (Ping timeout) 09:07:39 <-- jb has quit (Ping timeout) 09:08:15 --> jb has joined #instantbird 09:08:40 --> aleth has joined #instantbird 09:08:40 * ChanServ sets mode +h aleth 09:10:33 <-- jb has quit (Ping timeout) 09:14:56 --> jb has joined #instantbird 09:20:48 <-- jb has quit (Ping timeout) 09:21:53 --> jb has joined #instantbird 09:23:24 --> florian has joined #instantbird 09:24:08 --> flo-retina has joined #instantbird 09:24:08 * ChanServ sets mode +qo flo-retina flo-retina 09:31:33 <-- FireFly_TB has quit (Input/output error) 09:41:53 <-- jb has quit (Ping timeout) 10:02:30 <aleth> flo-retina: Re your memory pastebin, what is "38.52 MB (26.83%) ââ unused-gc-things" ? 10:02:40 <aleth> The other big one is heap-unclassified, of course 10:14:44 --> clokep has joined #instantbird 10:14:44 * ChanServ sets mode +o clokep 10:39:39 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 10:39:46 --> clokep has joined #instantbird 10:39:46 * ChanServ sets mode +o clokep 10:44:31 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2753 on bug 2121. 10:44:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2121 nor, --, ---, aleth, ASSI, The /join command shouldn't send a JOIN command to the server if we are already in the channel 10:46:33 <instantbot> clokep@gmail.com denied review for attachment 2753 on bug 2121. 10:46:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2121 nor, --, ---, aleth, ASSI, The /join command shouldn't send a JOIN command to the server if we are already in the channel 10:46:57 <flo-retina> aleth: I think (not fully sure) unused-gc-things is memory allocated by the GC engine that has been mostly freed (it's not occupied by objects any more), but can't be released to the OS because there are some objects still living in these memory pages. 10:47:49 <flo-retina> aleth: I think https://bugzilla.mozilla.org/show_bug.cgi?id=619558 is intending to fix that. 10:48:27 <clokep> aleth: I think you need to do a if hasConversation && !getConversation.left 10:48:54 <aleth> clokep: Ah, I see what you mean. 10:49:29 --> FireFly_TB has joined #instantbird 10:50:44 <aleth> flo-retina: Here's hoping then... that's a /lot/ of memory. 10:51:36 <aleth> Hmm it's been assigned for a while :-/ 10:52:21 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 10:53:02 <flo-retina> aleth: I think it's a meta bug, and the real work is happening in the dependencies 10:56:24 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2754 on bug 2121. 10:56:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2121 nor, --, ---, aleth, ASSI, The /join command shouldn't send a JOIN command to the server if we are already in the channel 10:56:36 <flo-retina> aleth: anyway, I would still like to know what's taking 3.79MB in imConversations.js, as that really feels like a leak given that all conversations were closed. 10:57:37 <aleth> Right. 11:19:21 <instantbot> aleth@instantbird.org granted review for attachment 2751 on bug 2114. 11:19:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2114 enh, --, ---, florian, ASSI, Chat rooms on hold should stay on hold after a restart 11:21:05 <flo-retina> aleth: is session restore really difficult? 11:22:26 <flo-retina> the whole problem with auto-joining MUCs was that we couldn't serialize properly chat room fields in a way that we are comfortable letting the user edit. 11:22:41 <aleth> flo-retina: I would expect it to be harder than it at first looks. Restoring tab order is also potentially a bit tricky. 11:22:54 <flo-retina> if we get rid of the auto-join field, and just restore the conversations that were there before shutdown on each account; it shouldn't be too bad 11:23:12 <flo-retina> aleth: I was thinking of splitting the problems in several small chunks 11:23:16 <flo-retina> 1. Restore convs on hold. 11:23:17 <aleth> We would need to implement something like the IRC chatRoomFields mechanism for all protocols 11:23:23 <flo-retina> 2. Reopen convs automatically for each account. 11:23:43 <flo-retina> 3. Deal in the front-end with chat tab positions (in which window, were on the screen, etc...) 11:24:13 <flo-retina> aleth: we have the chatroomfields mechanism for all protocols. What's protocol specific is the way to serialize it in something user readable (we have it only for IRC and XMPP right now). 11:24:45 <aleth> flo-retina: The mechanism is there, but the data isn't retained 11:25:23 <aleth> User readabilty doesn't matter for session restore of course. 11:26:32 <aleth> I think you're right that the way to do it would be to do it in chunks. I thought Mic had already done a fair bit of 1&2 and was hoping he would eventually turn his work into a patch... 11:41:47 --> clokep_ has joined #instantbird 11:44:21 <instantbot> clokep@gmail.com denied review for attachment 2754 on bug 2121. 11:44:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2121 nor, --, ---, aleth, ASSI, The /join command shouldn't send a JOIN command to the server if we are already in the channel 11:45:36 <clokep_> flo-retina: http://log.bezut.info/instantbird/today/#m75 doesn't matter for session restore. 11:45:43 <clokep_> Just for auto-joining. 11:46:06 <clokep_> Which aleth seems to have said 4 lines below that. ;) 11:46:55 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2755 on bug 2121. 11:46:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2121 nor, --, ---, aleth, ASSI, The /join command shouldn't send a JOIN command to the server if we are already in the channel 11:52:41 <instantbot> clokep@gmail.com granted review for attachment 2755 on bug 2121. 11:52:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2121 nor, --, ---, aleth, ASSI, The /join command shouldn't send a JOIN command to the server if we are already in the channel 11:53:07 * clokep_ wasn't going to r- that again. ;) 11:53:50 <aleth> It's the kind of little bug that doesn't get fixed because it gets forgotten, so I thought I'd just do it ;) 11:54:00 <clokep_> :) 11:58:23 <clokep_> Well thanks for fixing it. :) 12:00:52 <aleth> Not that it matters to people who don't read debug logs ;) 12:07:26 <flo-retina> clokep_: yes, it doesn't matter. That's why I said "the whole problem with auto-joining MUCs *was* that we couldn't serialize" 12:08:01 <flo-retina> aleth: thanks for fixing it! :) 12:08:09 <flo-retina> I was surprised to see it getting fixed so quickly ;) 12:09:37 <flo-retina> btw, what happens if we attempt to join a password protected channel but with the wrong password? Won't that open a conversation tab with a system message? Can we still attempt to join with another password without closing that tab first? :) 12:09:43 <clokep_> We like to keep the IRC code nice and clean. :P 12:09:52 <clokep_> Yes. 12:09:56 <clokep_> Well, I think so. 12:10:03 <flo-retina> clokep_: yeah, that's why I filed the bug ;) 12:10:05 <clokep_> I don't see why we wouldn't be able to, it should just use that same conv object. 12:10:37 <qheaden> Hello everyone. 12:10:40 <flo-retina> clokep_: I was just wondering what this.hasConversation(channel) would return in this case 12:10:46 <flo-retina> qheaden: good morning :) 12:11:52 <aleth> flo-retina: Channels default to left=true until they are successfully joined. 12:12:13 <clokep_> flo-retina: True. 12:12:28 <clokep_> But "left" would also be true. 12:12:59 <-- FireFly_TB has quit (Ping timeout) 12:13:46 <flo-retina> clokep_, aleth: ok, great then :) 12:17:39 <clokep_> The only thing this could REALLY mess up is if we somehow lose track of if we're in a room or not... 12:17:54 <qheaden> aleth: So it looks like the ack packet in bug 2094 is sent back regardless of invite success. 12:17:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2094 nor, --, ---, qheaden, ASSI, Required key 52 wasn't found. 12:18:21 <aleth> qheaden: Oh well, it did seem like too much to hope for. 12:20:15 <qheaden> clokep_: You mentioned that you wanted me to abstract the icon handling code first before working more on caching. 12:21:30 <-- micahg has quit (Ping timeout) 12:23:00 --> micahg has joined #instantbird 12:23:28 <clokep_> qheaden: I did mention that I'd be more interested in that (so I can finish a Twitter patch :P I'm really just being selfish) 12:23:42 <qheaden> :) 12:23:59 <qheaden> Well, I think it would actually make more sense to implement that first before caching. 12:24:02 <florian> clokep_: what's the twitter patch about? 12:24:11 <instantbot> clokep@gmail.com granted review for attachment 2748 on bug 2094. 12:24:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2094 nor, --, ---, qheaden, ASSI, Required key 52 wasn't found. 12:25:10 <qheaden> clokep_: So what actually needs to be abstracted with buddy icon code? Size handling? We already have the buddyIconFilename property that handles the heavy stuff. 12:25:14 <clokep_> florian: bug 794 12:25:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=794 nor, --, ---, nobody, NEW, Twitter should set the user avatar 12:25:33 <florian> ah 12:25:35 <clokep_> qheaden: That and the reading of the icon, I think. I'm not sure exactly. 12:25:37 <florian> the user's icon :) 12:26:27 <flo-retina> clokep_: abstracting may not be the only thing to do there. It sucks to have each account read the icon file from disk immediately after the notification saying the user's icon changed. 12:27:18 <qheaden> Is there a bug for abstracting icon sizing? I forget. 12:27:54 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 2756 on bug 2009. 12:27:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2009 nor, --, ---, nobody, NEW, Accounts don't automatically reconnect when back online if the "offline" status was set while the co 12:30:43 <clokep_> flo-retina: I'm sure lots of things suck around that... 12:30:43 --> jb has joined #instantbird 12:30:57 <clokep_> qheaden: If we think caching is more important, that's fine. I just wasn't sure exactly where we were with that. :) 12:31:07 <instantbot> aleth@instantbird.org denied review for attachment 2756 on bug 2009. 12:31:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2009 nor, --, ---, nobody, NEW, Accounts don't automatically reconnect when back online if the "offline" status was set while the co 12:33:03 * clokep_ loves self-denying reviews. ;) 12:34:35 <-- jb has quit (Ping timeout) 12:37:21 --> jb has joined #instantbird 12:38:54 <clokep_> The checkin-needed queue has a bunch of stuff in it. :) 12:41:05 <-- EionRobb has quit (Ping timeout) 12:41:55 --> skeledrew has joined #instantbird 12:56:52 --> EionRobb has joined #instantbird 12:58:09 <instantbot> clokep@gmail.com denied review for attachment 2752 on bug 2117. 12:58:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2117 nor, --, ---, qheaden, ASSI, /invite should print a system message to show it's done something 12:59:08 <qheaden> clokep_: I guess you noticed I changed my mind midway of development with that localization comment. ;) 13:00:46 <clokep_> qheaden: Yes. :) 13:01:38 <clokep_> aleth: You have a second to discbuss bug 1994? 13:01:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1994 nor, --, ---, aleth, ASSI, Account reconnects after using the /quit command 13:05:31 <aleth> clokep_: OK 13:07:07 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 2757 on bug 2009. 13:07:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2009 nor, --, ---, nobody, NEW, Accounts don't automatically reconnect when back online if the "offline" status was set while the co 13:08:08 <instantbot> clokep@gmail.com denied review for attachment 2750 on bug 1994. 13:08:08 <clokep_> Bah, I already denied it aleth . 13:08:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1994 nor, --, ---, aleth, ASSI, Account reconnects after using the /quit command 13:08:19 <clokep_> aleth: I mostly denied it as "I don't see WTF this fixes." 13:08:26 <clokep_> And because you touch imAccount, which seems like a no-no. 13:10:33 <aleth> Yeah, the latter has to be the wrong way to do it, come to think of it. 13:12:43 <instantbot> aleth@instantbird.org cancelled review?(florian@instantbird .org) for attachment 2757 on bug 2009. 13:12:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2009 nor, --, ---, aleth, ASSI, Accounts don't automatically reconnect when back online if the "offline" status was set while the co 13:13:44 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 2758 on bug 2009. 13:28:45 * clokep_ throws the Linux question on the mailing list @ aleth. 13:32:20 * aleth guesses "update your distro" is not a helpful reply 13:32:57 <clokep_> Does he need 32-bit libs? 13:33:00 <clokep_> Or something crazy? 13:33:05 <aleth> No, he's on 32 bit 13:33:10 <clokep_> Oh. 13:33:16 * clokep_ goes back into his Windows hole. 13:34:12 <aleth> It's a strange error /if/ http://www.instantbird.com/system-requirements.html is correct 13:35:05 * clokep_ wouldn't be surprised if that's slightly out of date. ;) 14:01:08 --> nhnt11 has joined #instantbird 14:01:10 <-- nhnt11 has quit (Input/output error) 14:01:16 --> nhnt11 has joined #instantbird 14:01:48 --> mconley has joined #instantbird 14:05:20 <qheaden> clokep_: When I call LOG on the account, I don't see a message in the log window. Do I need to increase my log level? If so, how? 14:07:33 <clokep_> qheaden: "log window"? 14:07:34 <clokep_> Yes. 14:07:45 <qheaden> Oops. I mean error console. 14:07:47 <clokep_> Umm...there's a hidden pref, purple.debug.loglevel? 14:08:06 <-- jb has quit (Ping timeout) 14:08:06 <qheaden> Oh okay. 14:08:15 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 14:08:22 --> nhnt11 has joined #instantbird 14:09:55 <clokep_> qheaden: You can also append the ID of the protocol onto that if you want to only set it for a single prpl. 14:10:17 <qheaden> clokep_: What is the highest log level number? 14:10:49 <clokep_> qheaden: Lower shows more. 14:10:57 <qheaden> Ahh okay. 14:11:29 <clokep_> qheaden: See http://lxr.instantbird.org/instantbird/source/chat/components/public/imIAccount.idl#170 14:11:45 <qheaden> Thanks. 14:12:41 * qheaden just notices all of the log messages his prpl makes O_O 14:14:29 <clokep_> Logging is good. :) 14:14:45 <aleth> qheaden: You've never looked at a yahoo debug log? 14:14:49 * aleth is surprised 14:15:10 * clokep_ is concerned 14:15:15 <aleth> Do you do it all with wireshark? ;) 14:15:20 <qheaden> aleth: Pretty much. 14:15:31 <qheaden> Now I see where bug 2089 comes from. 14:15:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2089 nor, --, ---, nobody, NEW, Debug logs are binary only 14:16:10 <aleth> I just assumed you were so well-versed in yahoo you could read the binary the way clokep reads RFC numbers :P 14:17:00 --> jb has joined #instantbird 14:17:01 <clokep_> Hopefully it at least converts it to hex first. :) 14:17:32 <qheaden> lol 14:21:31 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2759 on bug 2117. 14:21:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2117 nor, --, ---, qheaden, ASSI, /invite should print a system message to show it's done something 14:22:44 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 14:27:49 <-- EionRobb has quit (Quit: Leaving.) 14:31:22 <clokep_> :( 14:31:27 <clokep_> qheaden: I think you took me comment totally wrong. 14:31:31 <clokep_> It wasn't clear though. 14:32:17 <clokep_> qheaden: I was wondering if we should set http://lxr.instantbird.org/instantbird/source/chat/components/public/prplIMessage.idl#56 or not 14:33:12 <clokep_> (Not that it's bad to have an actual log message too though. :)) 14:33:33 <-- jb has quit (Ping timeout) 14:33:38 <qheaden> OH, I didn't realize that's what you meant. :P 14:33:56 <qheaden> TBH, I didn't notice the noLog option. 14:34:04 <aleth> clokep_: Was my reply clear? Suggestions welcome. 14:34:27 <clokep_> qheaden: I figured that out. :) 14:34:52 <clokep_> aleth: I'm unsure if I agree w/ moving the code from disconnect to quit. 14:35:00 <qheaden> clokep_: So if we are logging with LOG, it might be best to put noLog on the window message. 14:35:03 <clokep_> But it seems to me that they're essentially the same method. 14:35:10 <-- florian has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 14:35:16 <clokep_> qheaden: noLog on the message means that it doesn't show up when you view logs for that conversation. 14:35:18 <aleth> clokep_: Well, /quit could call disconnect() if we give it a parameter.... 14:35:37 <qheaden> clokep_: Oh okay. In that case, I think we should noLog 14:36:08 <clokep_> aleth: Does that make more sense? 14:36:15 <aleth> clokep_: idk. 14:36:55 <aleth> I don't know what you considered the difference between the two methods 14:37:53 <aleth> The argument for not calling disconnect(aMsg) is that disconnect is in the interface and has no parameter there. 14:39:19 <clokep_> aleth: "quit" is meant to "send the quit message" disconnect is what does other logic. 14:39:19 <clokep_> ' 14:39:30 <clokep_> aleth: It's meant to be the protocol part. 14:39:52 --> jb has joined #instantbird 14:41:22 <aleth> How about removing quit() altogether and just using disconnect. 14:41:33 <-- jb has quit (Ping timeout) 14:41:40 <clokep_> aleth: How many places is it called? 14:41:48 <clokep_> If it's the only consumer maybe that makes sense. 14:41:56 <clokep_> I vaguely feel like we added it for the command for some reason... 14:42:17 <aleth> I have no particular preference on how that is organised, but the moved code not being called on /quit is a bug. 14:42:45 * clokep_ has another proposal. 14:42:49 <clokep_> Remove the quit command. ;) 14:43:20 <clokep_> (Or make it a global command that calls the proper methods, not an IRC command.) 14:43:30 <aleth> I wouldn't mind that, but then we'll get "How do I set the quit message" complaints 14:43:32 <clokep_> Why are you able to quit an IRC account from a command, it seems strange to me. 14:43:33 <instantbot> qheaden@phaseshiftsoftware.com cancelled review?(clokep@gmail.com) for attachment 2759 on bug 2117. 14:43:34 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2760 on bug 2117. 14:43:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2117 nor, --, ---, qheaden, ASSI, /invite should print a system message to show it's done something 14:44:06 <clokep_> Change disconnect to optionally take a message. 14:44:16 --> jb has joined #instantbird 14:45:40 * qheaden needs to stop fixing other bugs, avoiding caching 14:54:18 <instantbot> clokep@gmail.com granted review for attachment 2760 on bug 2117. 14:54:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2117 nor, --, ---, qheaden, ASSI, /invite should print a system message to show it's done something 14:56:05 <qheaden> checkin-needed is growing ever larger. :) 15:01:16 <-- jb has quit (Ping timeout) 15:05:37 <clokep_> aleth: unInit also calls quit directly. 15:07:45 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2761 on bug 1994. 15:07:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1994 nor, --, ---, aleth, ASSI, Account reconnects after using the /quit command 15:11:39 * clokep_ wonders if we should ask nhnt11 why he uses quit. ;) 15:11:51 <aleth> muscle memory? ;) 15:12:18 <flo-retina> clokep_: I think I'm missing some of the context, but why are you all talking about removing the /quit command? 15:14:54 <clokep_> flo-retina: Because how is it useful? 15:15:02 <clokep_> / why is it IRC specific? 15:15:13 <aleth> It's been broken since forever and only nhnt11 noticed? 15:15:13 <flo-retina> because there's no quit messages on other networks? 15:15:27 <flo-retina> aleth: that means we need unit tests :-P 15:16:13 <aleth> flo-retina: unit tests wouldn't have noticed unless they included the account manager. 15:16:54 <aleth> flo-retina: But more seriously, the imAccount.disconnect call in https://bugzilla.instantbird.org/attachment.cgi?id=2750&action=diff isn't great. 15:17:13 <aleth> Personally I could live with it though... 15:17:55 <clokep_> I guess my point is that it doesn't seem like accounts are supposed to disconnect themself? 15:18:49 <flo-retina> aleth: so what's going on there? 15:19:01 <flo-retina> aleth: if the disconnection is intentional, how come there's a disconnection error? 15:19:11 <aleth> flo-retina: https://bugzilla.instantbird.org/show_bug.cgi?id=1994#c4 15:19:15 <instantbot> Bug 1994 nor, --, ---, aleth, ASSI, Account reconnects after using the /quit command 15:21:23 <instantbot> florian@instantbird.org denied review for attachment 2761 on bug 1994. 15:21:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1994 nor, --, ---, aleth, ASSI, Account reconnects after using the /quit command 15:23:01 --> jb has joined #instantbird 15:24:55 <flo-retina> aleth: so account.imAccount.disconnect() seems indeed to be the thing you want to do. It would need a pretty good comment to justify it though ;). 15:25:15 <aleth> flo-retina: You don't like my comment? ;) 15:25:30 <aleth> I suppose it should include the words "status observer"... 15:27:30 <-- gerard-majax has quit (Ping timeout) 15:29:32 <flo-retina> aleth: it should say that prpls shouldn't usually touch .imAccount, but this case is an exception because the /quit command is indeed an action the user made from the UI. 15:29:37 <flo-retina> or something like that 15:30:17 <aleth> flo-retina: OK, that's what I meant by "Tell the imAccount as this is an intentional disconnection.", but I will make it more verbose 15:31:42 <clokep_> aleth: Btw you probably don't need to use getAccount() in that situation. 15:31:51 <clokep_> You're all in xpcom land at that point. 15:31:53 --> jb1 has joined #instantbird 15:31:55 <-- jb has quit (Ping timeout) 15:31:58 <flo-retina> aleth: I guess I want to avoid other prpl authors copying this code thinking just "oh well, this is called imAccount, let's call it" 15:36:10 --> nhnt11 has joined #instantbird 15:36:18 <nhnt11> Hi 15:36:44 * clokep_ pokes nhnt11. 15:37:02 * nhnt11 looks at clokep_ 15:37:27 <nhnt11> clokep_: Maybe you should've poked me while I was oversleeping :P 15:37:38 * clokep_ sets up his poke-alarm. 15:38:18 <aleth> You'd have to add /buzz to IRC first... 15:39:33 <clokep_> I will be willing to add that. 15:39:44 <clokep_> If nhnt11 sets up a Super Soaker on the other side. 15:39:52 <nhnt11> Haha :D 15:39:57 <clokep_> (Preferably Super Soaker 70 since those were the best ones ever.) 15:40:26 * nhnt11 remembers being excited about the one that you could keep pumping for an endless stream 15:41:47 <nhnt11> clokep_, aleth: I don't use the quit command, just that I did it once (don't remember why) and it didn't work 15:41:48 <clokep_> Sorry, I meant the 50: http://www.bing.com/images/search?q=Super+Soaker+50&id=5EFFE6C42240EBBC0647BC6CB7F26D1A870BA48B&FORM=IQFRBA 15:41:51 <clokep_> I also had the 70 though. 15:42:14 <nhnt11> So that bing link didn't load :S 15:42:22 <aleth> oh yeah, I remember those :D 15:43:10 <nhnt11> I mean, this is all I got: http://puu.sh/48XjX.png 15:43:12 <nhnt11> :( 15:43:16 <clokep_> The tank had the same threading as a poland springs bottle IIRC. 15:43:19 * nhnt11 wonders if bing is somehow partially blocked on campus 15:45:59 <nhnt11> clokep_: So you could attach a larger tank? :D 15:47:25 <clokep_> Poland Spring bottles were smaller, but they were free so we used to refill them and hide them and carry them around. 15:47:37 <clokep_> So when you ran out, you wouldn't be caught at the pool refilling. 15:47:43 <clokep_> (Or the hose, etc.) 15:48:07 <nhnt11> Ah :) 16:00:15 <qheaden> Hi nhnt11. 16:00:17 * qheaden was afk 16:00:20 <nhnt11> hi qheaden 16:00:53 <qheaden> flo-retina: Looking at your review of bug 2112 again. So I should move handling of pending requests to jsProtoHelper? 16:00:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2112 enh, --, ---, qheaden, ASSI, Abstract Buddy Request Code Into jsProtoHelper.js 16:01:40 <-- jb1 has quit (Ping timeout) 16:02:44 --> jb has joined #instantbird 16:03:00 <flo-retina> qheaden: yes 16:04:04 --> gerard-majax has joined #instantbird 16:05:29 <nhnt11> flo-retina: Do you want to steal a review? It's a small patch :) bug 2065 16:05:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2065 nor, --, ---, nhnt11, NEW, Double and middle-clicks on the tab bar should open new conversation tab 16:05:38 <nhnt11> aleth: ^ 16:05:51 <-- gerard-majax has quit (Ping timeout) 16:09:10 <qheaden> flo-retina: Where in GenericAccountPrototype should I add a _pendingRequests property? Near the top? 16:09:13 <nhnt11> brb 16:09:15 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 16:09:21 --> nhnt11 has joined #instantbird 16:09:46 --> gerard-majax has joined #instantbird 16:16:13 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2762 on bug 1994. 16:16:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1994 nor, --, ---, aleth, ASSI, Account reconnects after using the /quit command 16:17:58 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 16:18:04 --> nhnt11 has joined #instantbird 16:18:21 <-- gerard-majax has quit (Ping timeout) 16:19:08 <nhnt11> I'm looking at something that's annoying me, but possibly is so trivial it's not a bug. 16:19:29 <aleth> nhnt11: what does the existing e.initEvent("NewTab", true, true); do? 16:20:00 <nhnt11> When there are enough tabs open that the close button is shown only for the focused one, the labels for the other tabs are centered as if the close button isn't there. this causes the whole label to shift to the left when the tab is focused and the close button appears :/ 16:20:10 <flo-retina> aleth: it's an even that add-ons can catch to know a new tab's been opened 16:20:32 <aleth> Oh, so we currently dispatch that and just don't actually do it? 16:20:40 <nhnt11> Yeah 16:20:48 <aleth> nhnt11: Shouldn't that be sent from showNewTab() ? 16:21:00 <nhnt11> Hmm, that makes sense. 16:21:19 <nhnt11> Or even from the constructor of the newtab binding 16:21:29 <aleth> onTabClick needs a comment explaining which button is checked for, similarly the other one 16:21:40 <flo-retina> nhnt11: do you have a proposed fix? 16:21:46 <aleth> Or define constants for "1" and "0" 16:22:13 <nhnt11> flo-retina: For the label problem? Not yet. I need to take a look at the code 16:22:14 <aleth> nhnt11: My point is that it doesn't seem to be sent consistently 16:22:24 <flo-retina> nhnt11: it's not trivial 16:22:31 <aleth> nhnt11: There's also an xxx there that needs addressing one way or another 16:22:40 <nhnt11> flo-retina: Then most likely I don't want to try fixing it :P 16:23:01 <nhnt11> aleth: I didn't really understand that xxx 16:23:10 <flo-retina> nhnt11: well, the code may be trivial; once you have a great idea 16:23:16 <flo-retina> nhnt11: I think Firefox has the same bug though 16:23:46 <nhnt11> aleth: From my testing, the code was getting called only when I double clicked the empty area anyway 16:23:59 <nhnt11> flo-retina: It does. 16:25:20 <instantbot> aleth@instantbird.org denied review for attachment 2715 on bug 2065. 16:25:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2065 nor, --, ---, nhnt11, NEW, Double and middle-clicks on the tab bar should open new conversation tab 16:25:44 <flo-retina> aleth: if you are still touching that disconnect method (https://bugzilla.instantbird.org/attachment.cgi?id=2762), can you fix the indent of the return; on the second line of the method? :-D 16:25:54 <nhnt11> aleth: Thanks. 16:27:33 <flo-retina> aleth: I don't think the "NewTab" event is for empty tabs. I think it's for when a tab was added in the tabbar 16:27:54 <instantbot> aleth@instantbird.org cancelled review?(clokep@gmail.com) for attachment 2762 on bug 1994. 16:27:55 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2763 on bug 1994. 16:27:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1994 nor, --, ---, aleth, ASSI, Account reconnects after using the /quit command 16:28:13 <flo-retina> and the stuff you pasted in the bug as review comments is mixed when a completely unrelated discussion :( 16:28:16 <aleth> flo-retina: In that case we shouldn't be sending the event for the awesometab? 16:29:17 <flo-retina> wait, is this sent only from onTabBarDblClick? 16:29:22 <nhnt11> flo-retina: yes 16:29:25 <nhnt11> As of now. 16:29:26 <aleth> Oh no, I thought I had removed all the unrelated ones, but I missed those at the top:( 16:30:07 <flo-retina> nhnt11: it's not some code you added, right? 16:30:12 <nhnt11> flo-retina: Nope 16:30:12 <flo-retina> sounds like dead code :-S 16:30:28 <aleth> It does look like it shouldn't be there, yes 16:30:42 <nhnt11> Yeah I didn't know exactly what it was for so left it as it was 16:31:12 <nhnt11> Should I just remove it? 16:33:50 <flo-retina> yes 16:33:57 --> Mook_as has joined #instantbird 16:34:22 <nhnt11> cool 16:34:43 <nhnt11> Bah, even if that gets checked in it won't make it to a nightly for a while :( 16:36:13 <aleth> nhnt11: That handler seems unchanged since the initial tabbrowser.xml based on FX 3.5 16:36:39 <nhnt11> :) 16:36:55 <aleth> If you are concerned, check to see what happened to that handler in FX ;) 16:37:07 <nhnt11> I suspect a lot of stuff in tabbrowser.xml has remained unchanged... 16:37:11 <nhnt11> I'm looking at it right now 16:37:21 <nhnt11> firefox's tabbrowser.xml i mean 16:38:29 <nhnt11> It's not there anymore 16:38:39 <nhnt11> at least not in tabbrowser.xml 16:40:11 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 16:40:17 --> nhnt11 has joined #instantbird 16:40:52 <flo-retina> "it won't make it to a nightly for a while :(" why? 16:41:18 <nhnt11> flo-retina: Mac nightlies are broken? 16:41:25 <nhnt11> Or did I miss something and they're back? 16:42:08 <nhnt11> looks like I didn't miss anything from the logs :) 16:42:20 <flo-retina> nhnt11: the mac mini is at my parents' place, and I'll likely go there physically today to kick it 16:42:34 <nhnt11> :) 16:42:55 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 16:47:04 --> unghost has joined #instantbird 16:56:18 --> rosonline has joined #instantbird 17:03:02 <instantbot> aleth@instantbird.org cancelled review?(clokep@gmail.com) for attachment 2763 on bug 1994. 17:03:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1994 nor, --, ---, aleth, ASSI, Account reconnects after using the /quit command 17:05:13 <aleth> That bug is turning out much messier than expected :-S 17:12:38 <clokep_> aleth: It's IRC. :P 17:13:40 <aleth> Ah, I knew there was a reason :D 17:13:59 * aleth hates intermittent bugs that don't always happen 17:20:44 <qheaden> How does a commit message list more than one reviewer? Just a comma delimited list of r=? 17:22:03 <qheaden> Nevermind. I see an example. 17:26:11 <instantbot> qheaden@phaseshiftsoftware.com requested review from florian@instantbird .org for attachment 2764 on bug 2112. 17:26:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2112 enh, --, ---, qheaden, ASSI, Abstract Buddy Request Code Into jsProtoHelper.js 17:27:59 <qheaden> I'll be back later on. 17:28:14 * qheaden has to go to his university to take care of a few things. 17:51:10 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2763 on bug 1994. 17:51:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1994 nor, --, ---, aleth, ASSI, Account reconnects after using the /quit command 17:52:07 <aleth> clokep was right ;) 17:53:23 --> qlum has joined #instantbird 17:53:24 <nhnt11> That IRC is just weird? :P 17:53:30 <aleth> Yup. 17:59:40 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2765 on bug 2065. 17:59:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2065 nor, --, ---, nhnt11, NEW, Double and middle-clicks on the tab bar should open new conversation tab 17:59:59 --> FireFly_TB has joined #instantbird 18:01:13 <nhnt11> aleth: I took the opportunity to add a period at the end of the existing "see hack note" comment, hope thats ok :) 18:01:40 <aleth> Fixing things is always good :) 18:04:35 <instantbot> aleth@instantbird.org denied review for attachment 2765 on bug 2065. 18:04:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2065 nor, --, ---, nhnt11, NEW, Double and middle-clicks on the tab bar should open new conversation tab 18:04:58 * nhnt11 guesses he needs another comment 18:05:15 <nhnt11> ah it's a nit 18:07:42 <nhnt11> aleth: Should I change the parameter name in onTabClick to "aEvent" while I'm at it? It's just "event" right now 18:08:06 <aleth> nhnt11: If you prefer. I think that's the case in a lot of the older code. 18:08:57 <nhnt11> ok 18:11:55 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2766 on bug 2065. 18:11:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2065 nor, --, ---, nhnt11, NEW, Double and middle-clicks on the tab bar should open new conversation tab 18:13:26 <instantbot> aleth@instantbird.org granted review for attachment 2766 on bug 2065. 18:14:24 <clokep_> aleth: Did that patch change from the one before it? 18:14:26 <instantbot> aleth@instantbird.org denied review for attachment 2766 on bug 2065. 18:14:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2065 nor, --, ---, nhnt11, NEW, Double and middle-clicks on the tab bar should open new conversation tab 18:15:00 <aleth> clokep_: Depends which one... I cancelled the review and then put it up again after investigating (no changes required) 18:15:39 * nhnt11 thought he got all the "event"s, bah :( 18:16:03 <clokep_> aleth: That was what I was asking, yes. :) 18:18:02 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2767 on bug 2065. 18:18:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2065 nor, --, ---, nhnt11, NEW, Double and middle-clicks on the tab bar should open new conversation tab 18:18:52 <instantbot> aleth@instantbird.org granted review for attachment 2767 on bug 2065. 18:19:41 <aleth> clokep_: I didn't /add/ that line, I kept it (it is in the existing code). 18:21:04 <aleth> I don't see why it's needed either though. 18:22:10 <aleth> Want me to take it out? 18:26:55 <-- jb has quit (Ping timeout) 18:28:02 <instantbot> aleth@instantbird.org cancelled review?(clokep@gmail.com) for attachment 2763 on bug 1994. 18:28:03 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2768 on bug 1994. 18:28:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1994 nor, --, ---, aleth, ASSI, Account reconnects after using the /quit command 18:29:58 <-- rosonline has quit (Ping timeout) 18:37:32 <-- clokep_ has quit (Quit: http://www.mibbit.com ajax IRC Client) 18:39:56 <instantbot> aleth@instantbird.org set the Resolution field on bug 1593 to FIXED. 18:39:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1593 nor, --, ---, nobody, RESO FIXED, Add information on 64-bit Linux to FAQ 18:41:48 <instantbot> New Websites - www.instantbird.org bug 2122 filed by aleth@instantbird.org. 18:41:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2122 nor, --, ---, nobody, NEW, Update Linux system requirements page 18:42:30 --> rosonline has joined #instantbird 18:47:20 <-- aleth has quit (Quit: Ciao) 18:57:05 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 18:57:10 --> nhnt11 has joined #instantbird 19:02:13 <-- nhnt11 has quit (Ping timeout) 19:03:18 --> nhnt11 has joined #instantbird 19:03:36 <-- mconley has quit (Connection reset by peer) 19:04:00 --> mconley has joined #instantbird 19:11:31 <-- FireFly_TB has quit (Ping timeout) 19:44:53 --> flo-retina has joined #instantbird 19:44:54 * ChanServ sets mode +qo flo-retina flo-retina 19:45:40 <flo-retina> uh, I just got a nickserv tab from freenode :-S 19:49:19 <-- mconley has quit (Connection reset by peer) 19:49:40 --> mconley has joined #instantbird 19:49:55 <flo-retina> debug log: http://pastebin.instantbird.com/302881 (pastebin cut the end, but there's likely enough data to see what was going on around "Error: Registration completed before SASL authentication completed." that I see in my console everyday 20:02:22 --> nhnt12 has joined #instantbird 20:02:28 <-- nhnt11 has quit (Ping timeout) 20:05:15 * nhnt12 is now known as nhnt11 20:05:39 <instant-buildbot> build #446 of macosx-onCommit is complete: Exception [exception] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/446 blamelist: Florian Qu?ze <florian@instantbird.org>, Quentin Headen <qheaden@phaseshiftsoftware.com> 20:10:05 <flo-retina> I'm glad to see the aleth we knew a few years ago is back! :) 3 patches in bug 2009 before one stays with an r? flag long enough that it's possible to actually have a look ;) 20:10:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2009 nor, --, ---, aleth, ASSI, Accounts don't automatically reconnect when back online if the "offline" status was set while the co 20:17:44 <instantbot> florian@instantbird.org denied review for attachment 2758 on bug 2009. 20:17:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2009 nor, --, ---, aleth, ASSI, Accounts don't automatically reconnect when back online if the "offline" status was set while the co 20:26:22 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 20:26:52 --> Suiseiseki has joined #instantbird 20:28:27 <instantbot> florian@instantbird.org denied review for attachment 2764 on bug 2112. 20:28:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2112 enh, --, ---, qheaden, ASSI, Abstract Buddy Request Code Into jsProtoHelper.js 20:28:33 <flo-retina> r- for everybody tonight ;) 20:29:04 <flo-retina> already enough stuff in the checkin needed queue for the next nightly, new patches can wait a day ;) 20:35:59 --> nhnt11 has joined #instantbird 20:42:04 <-- nhnt11 has quit (Input/output error) 20:44:18 --> nhnt11 has joined #instantbird 20:51:30 <-- nhnt11 has quit (Input/output error) 20:53:43 --> nhnt11 has joined #instantbird 20:54:29 <-- nhnt11 has quit (Input/output error) 20:57:08 <flo-retina> a mac nightly is currently being uploaded :) 20:57:38 --> clokep has joined #instantbird 20:57:39 * ChanServ sets mode +o clokep 21:03:20 <flo-retina> clokep: FYI, I'm going through the checkin queue right now 21:03:33 <clokep> flo-retina: Thanks. 21:08:17 <-- flo-retina has quit (Ping timeout) 21:08:55 --> nhnt11 has joined #instantbird 21:10:00 <-- nhnt11 has quit (Input/output error) 21:10:07 --> flo-retina has joined #instantbird 21:10:07 * ChanServ sets mode +qo flo-retina flo-retina 21:13:00 <flo-retina> :( 21:13:22 --> nhnt11 has joined #instantbird 21:14:59 <flo-retina> There was a power outage here. I hoped I could ssh into the mac mini after its restart, and run scp by hand to finish the upload. 21:15:09 <flo-retina> But buildbot was faster than me and rm -rf'ed the objdir :( 21:16:35 <nhnt11> flo-retina: My patch got an r+ ;) 21:16:46 <flo-retina> from me? 21:16:48 <nhnt11> aleth 21:17:21 <flo-retina> yes, there's plenty of stuff in the checkin queue ;) 21:17:28 <nhnt11> ah, it's checkin-needed already 21:17:55 <nhnt11> So we'll have a nightly tomorrow, yay :) 21:18:30 <flo-retina> qheaden: would be nice if your checkin messages indicated that the patch contains Yahoo changes 21:18:40 <flo-retina> it's obvious on bugzilla because we have a yahoo component 21:18:47 <flo-retina> but in a commit message it's not obvious 21:20:36 <flo-retina> qheaden: http://pastebin.instantbird.com/302943 21:30:15 <-- rosonline has quit (Client exited) 21:31:59 <clokep> If it seems too hard to fix, just ignore it and we acn check it in tomorrow. 21:34:08 <flo-retina> clokep: I had already moved on 21:37:49 <flo-retina> clokep: http://pastebin.instantbird.com/302974 on the facebook xmpp developer group. 21:37:57 <-- qlum has quit (Quit: Getting the <censored> out.) 21:37:59 <flo-retina> that could explain the complain of the other 'user' 21:39:41 <-- nhnt11 has quit (Input/output error) 21:39:42 --> nhnt12 has joined #instantbird 21:45:25 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/eb101de44db0 - aleth - Bug 2120 - Spurious "You have rejoined the room" on being invited into a channel, r=clokep. 21:45:26 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/373af5342a33 - Quentin Headen - Bug 2094 - Required key 52 wasn't found, r=clokep. 21:45:27 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/e0942f4cdc06 - Florian Quèze - Bug 2114 - Chat rooms on hold should stay on hold after a restart, r=aleth. 21:45:28 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/df197dc3277d - aleth - Bug 2121 - The /join command shouldn't send a JOIN command to the server if we are already in the channel, r=clokep. 21:45:29 <clokep> flo-retina: Interesting. 21:45:30 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/c1ced2446f94 - Nihanth Subramanya - Bug 2065 - Double and middle-clicks on the tab bar should open new conversation tab, r=fqueze,Mic. 21:46:26 <instantbot> clokep@gmail.com set the Resolution field on bug 2065 to FIXED. 21:46:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2065 nor, --, 1.5, nhnt11, RESO FIXED, Double and middle-clicks on the tab bar should open new conversation tab 21:46:47 <instantbot> clokep@gmail.com set the Resolution field on bug 2121 to FIXED. 21:46:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2121 nor, --, 1.5, aleth, RESO FIXED, The /join command shouldn't send a JOIN command to the server if we are already in the channel 21:47:48 <instantbot> clokep@gmail.com set the Resolution field on bug 2114 to FIXED. 21:47:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2114 enh, --, 1.5, florian, RESO FIXED, Chat rooms on hold should stay on hold after a restart 21:47:51 * nhnt12 finally created a Komodo command to compile and run Ib 21:47:56 * nhnt12 is now known as nhnt11 21:48:19 <instantbot> clokep@gmail.com set the Resolution field on bug 2094 to FIXED. 21:48:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2094 nor, --, 1.5, qheaden, RESO FIXED, Required key 52 wasn't found. 21:48:34 <qheaden> Hello again everyone. 21:48:39 * qheaden reads scrollback 21:49:00 <instantbot> clokep@gmail.com set the Resolution field on bug 2120 to FIXED. 21:49:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2120 min, --, 1.5, aleth, RESO FIXED, Spurious "You have rejoined the room" on being invited into a channel 21:50:08 <qheaden> flo-retina: 2117 failed huh? 21:50:46 * clokep would really like it if qheaden said "bug" before bug numbers. ;) 21:50:49 <clokep> bug 2117 21:50:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2117 nor, --, ---, qheaden, ASSI, /invite should print a system message to show it's done something 21:51:00 <qheaden> :) 21:51:55 * qheaden needs to hg update 21:55:17 <instantbot> florian@instantbird.org requested review from the wind for attachment 2769 on bug 1750. 21:55:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1750 min, --, ---, nobody, NEW, Warning: Use of Mutation Events is deprecated. Use MutationObserver instead. 21:55:41 <flo-retina> I guess anybody can feel free to review 21:55:49 * nhnt11 wonders if he can force force sh to source ~/.bash_profile by default 21:55:57 <flo-retina> not sure if I want to land that asap, or find motivation to fix all the others before 21:57:10 <instantbot> clokep@gmail.com granted review for attachment 2769 on bug 1750. 22:00:39 <flo-retina> thanks 22:00:47 <flo-retina> clokep: we agreed on http://pastebin.instantbird.com/302995 a while ago, haven't we? 22:01:08 <flo-retina> These are very noisy in my error console, and I don't see us doing anything with them without also wanting a debug log. 22:01:38 <clokep> Mostly, yes. 22:01:48 <flo-retina> ok, I'll file a bug and attach then 22:03:39 <instantbot> New Core - IRC bug 2123 filed by florian@instantbird.org. 22:03:40 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 2770 on bug 2123. 22:03:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2123 tri, --, ---, florian, NEW, 'Unhandled CAP/ISUPPORT messages' warnings are too noisy 22:04:19 <instantbot> clokep@gmail.com granted review for attachment 2770 on bug 2123. 22:05:24 <instant-buildbot> build #447 of macosx-onCommit is complete: Exception [exception] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/447 blamelist: Florian Qu?ze <florian@instantbird.org>, Quentin Headen <qheaden@phaseshiftsoftware.com>, Nihanth Subramanya <nhnt11@gmail.com>, aleth <aleth@instantbird.org> 22:05:43 <qheaden> But... I had nothing to do with it! :P 22:05:56 <flo-retina> qheaden: I canceled it 22:06:04 <qheaden> Ah. 22:06:11 <flo-retina> I don't need an onCommit build if there's already a nightly in progress 22:06:45 <nhnt11> flo-retina: What config is the Mac mini running? 22:06:56 <flo-retina> can you be more specific? 22:07:01 <nhnt11> Er I mean hardware 22:07:47 <flo-retina> hmm not sure 22:10:00 <flo-retina> nhnt11: it's a Mac mini server with a quad core i7. It was ordered (new) in October 2012, just after Apple upgraded the minis. 22:10:18 <flo-retina> not sure if they've been upgraded again since that, or if it's still the same as the current high end one. 22:10:33 <nhnt11> nice 22:10:53 <flo-retina> (I can't find the exact specs) 22:11:07 <flo-retina> the mini is here (at my parents' place) but the box is in the mess in my office at home 22:11:40 <flo-retina> anyway, it's a pretty good machine :) 22:12:33 <flo-retina> and that was quite a relief, as iirc the old PowerMac G5 needed almost 6h at the end of its productive life to produce a nightly... 22:12:46 <nhnt11> wow 22:12:48 <Mook_as> if it's on, you can try About this Mac :p 22:12:51 <nhnt11> That must've been hold 22:12:56 <nhnt11> Mook_as, flo-retina: Or $system_profiler SPHardwareDataType 22:13:09 <flo-retina> Mook_as: I can ssh to it, but it has no screen/keyboard/moue 22:13:11 <nhnt11> (If it doesn't have a monitor) 22:13:14 <nhnt11> Yeah 22:14:26 <flo-retina> nhnt11: http://pastebin.instantbird.com/302996 22:14:32 <flo-retina> doesn't say what hard drives we have 22:15:02 <flo-retina> there are 2 disks of 1TB. 22:16:10 <nhnt11> Cool 22:16:23 <nhnt11> flo-retina: You can do $system_profiler SPStorageDataType, btw :) 22:16:29 <flo-retina> so it looks like http://store.apple.com/us/configure/MD389LL/A with the 8GB of RAM option 22:16:52 <nhnt11> Cool. 22:16:55 * nhnt11 was just curious 22:17:33 <flo-retina> that's good enough, isn't it? ;) 22:17:40 <nhnt11> More than :) 22:18:08 <flo-retina> we could probably ask it to do more stuff 22:19:19 --> florian has joined #instantbird 22:22:07 <flo-retina> clokep: Warning: Unused mode parameters: 2:2 <-- is this known? 22:22:19 <clokep> flo-retina: I don't think so. 22:22:24 <flo-retina> I think I got this in my console when joining #test on freenode 22:23:28 <flo-retina> the message was 22:23:29 <flo-retina> : 22:23:30 <flo-retina> :pratchett.freenode.net 324 testib #test +Pmnstzj 2:2 22:25:10 <-- florian has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 22:25:52 --> florian has joined #instantbird 22:27:41 <-- unghost has quit (Input/output error) 22:28:49 <flo-retina> qheaden: do you have an updated patch? 22:29:26 <qheaden> flo-retina: I'm about to post one. 22:29:31 <flo-retina> cool 22:29:38 <qheaden> flo-retina: Do I need to ask review? 22:29:51 <flo-retina> probably not 22:29:55 <qheaden> Okay. 22:29:59 <flo-retina> unless you made changes 22:32:32 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 22:33:20 <qheaden> flo-retina: Okay, I posted the patch for bug 2117. 22:33:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2117 nor, --, ---, qheaden, ASSI, /invite should print a system message to show it's done something 22:33:46 <qheaden> I had it sitting on top of other patches in my queue, hence the failure to apply. 22:34:59 --> nhnt11 has joined #instantbird 22:35:05 * qheaden needs to remember to use hg qpush --move 22:37:08 <-- nhnt11 has quit (Input/output error) 22:37:21 <qheaden> flo-retina: For bug 2112, if I am going to create _pendingBuddyRequests in the _init method, do I need to keep a null definition in the prototype? 22:37:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2112 enh, --, ---, qheaden, ASSI, Abstract Buddy Request Code Into jsProtoHelper.js 22:37:48 <-- florian has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 22:37:48 <clokep> qheaden: I prefer it there. 22:38:09 <qheaden> Yeah, I do too. Just wondering. ;) 22:39:35 --> nhnt11 has joined #instantbird 22:40:05 * flo-retina is killing warnings tonight 22:40:09 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 2772 on bug 1676. 22:40:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1676 tri, --, ---, aleth, ASSI, 'function does not always return a value' warnings from moz14 22:41:09 <instant-buildbot> build #948 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/948 22:41:20 <instantbot> clokep@gmail.com granted review for attachment 2772 on bug 1676. 22:41:28 <flo-retina> \o/ 22:43:27 <clokep> Any last minute ones before I go to the pub? 22:43:28 * qheaden wonders if Ib should have an emoticon for \o/ 22:43:32 <-- nhnt11 has quit (Input/output error) 22:43:53 <flo-retina> clokep: I think I'm done fixing those I can kill trivially 22:44:00 <clokep> flo-retina: Thanks. :) 22:44:01 <flo-retina> I would really like to get rid of the XMPP one 22:44:06 <flo-retina> but that will require a bit more testing 22:44:36 <clokep> flo-retina: Btw did you see I'm running into Error: Error decoding: nonce="X7fGRJ+VUCRRUuIyyQR55dcHfNBSPTbXc5cdBphpn10=" 22:44:40 <clokep> for XMPP on jabber.org? 22:44:45 <flo-retina> the XMPP one = Warning: received presence stanza for unknown buddy <my JID>@gmail.com/<some resource> 22:45:08 <flo-retina> clokep: were there steps to reproduce? 22:46:19 <qheaden> flo-retina: Should the grant, deny, and cancel methods of the buddy request remove the request from _pendingBuddyRequests? I would think so. 22:46:37 <flo-retina> yes 22:47:15 <flo-retina> is "Conference invite sent to %S" correct grammar? 22:48:07 <flo-retina> "/invite <user1>[,<user2>,...] [<invite message>]: invite a user into a conference chat." seems wrong 22:49:01 <flo-retina> it invites one *or more* users, and not to *a* conference chat, but to the current one, right? 22:49:45 <qheaden> flo-retina: Oh yeah. I actually wrote that invite help message before I added support for inviting more than one user at a time. I'll have to change it. 22:50:06 --> nhnt11 has joined #instantbird 22:51:56 * nhnt11 updates his nightly 22:52:15 <nhnt11> Wow, that was fast. I didn't expect incremental updates to work.. 22:52:16 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 22:52:25 --> nhnt11 has joined #instantbird 22:52:35 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 22:52:39 --> flo-retina has joined #instantbird 22:52:39 * ChanServ sets mode +qo flo-retina flo-retina 22:53:04 <flo-retina> nhnt11: yeah, 29kB 22:53:06 * flo-retina updated too ::) 22:54:25 * nhnt11 just spent half an hour trying to make his ENV variable set globally on login, only to discover sh /still/ doesn't read his bash profile in Komodo :'( 22:55:08 <flo-retina> qheaden: would "Invitation sent to: %S" instead of "Conference invite sent to %S" look nicer? 22:55:57 * nhnt11 likes "%S was invited to a conference" 22:56:33 <nhnt11> That would likely be suckish for inviting multiple people though :P 22:56:41 <flo-retina> nhnt11: %S is a coma separated list of user names 22:56:53 <nhnt11> I realized. 22:56:56 <flo-retina> hmm, I'm not sure if there are actually comas 22:57:29 <nhnt11> Garh, the default shell Komodo uses is hard coded :-/ 22:57:47 <flo-retina> nhnt11: poke Mook ;) 22:57:59 <qheaden> flo-retina: "Conference invite sent to %S" would be the best for both single and multiple users. 22:57:59 <nhnt11> I should probably do that on #komodo :P 22:58:38 <flo-retina> qheaden: is "invite" a correct term as a noun? 22:59:19 <qheaden> flo-retina: Yes. I think so. 22:59:53 <flo-retina> http://www.thefreedictionary.com/invite says "an informal word for invitation" 23:00:30 <qheaden> flo-retina: "Conference invitation sent to %S"? 23:00:38 <qheaden> But then, it should be invitations for multiple users. 23:00:55 <nhnt11> qheaden: Same goes for invite? 23:01:00 <flo-retina> well, it would need to be invites for multiple users ;) 23:01:07 <qheaden> Yeah. 23:01:25 <qheaden> "You've invited %S to the conference"? 23:01:40 <qheaden> "Invited %S to the conference" 23:01:53 <flo-retina> You've -> You have ? 23:02:21 <flo-retina> maybe... It would suck a bit that there won't be a "and" between the last 2 names 23:02:31 <qheaden> I think you should drop "You have". The user already knows what they did. The feedback confirms what Instantbird is doing. 23:03:30 <flo-retina> qheaden: I think you have is consistent with our other messages like "You have left the room", and shows that it was an action from the user, rather than something that happened from the network 23:03:54 <qheaden> OK. 23:04:09 <flo-retina> "The user already knows what they did." well, if the user knows what he did, he doesn't need any feedback :-P 23:04:36 <qheaden> Silly flo-retina, users never read! :P 23:04:55 <flo-retina> you've got a point there :-D 23:05:22 <flo-retina> although never reading slightly defeats the point of an IM client ;) 23:06:16 <qheaden> :P 23:08:33 <qheaden> flo-retina: How do you like these changes to replyToBuddyRequest? http://pastebin.instantbird.com/303037 23:09:07 * flo-retina wonders where bug 2104 is on nhnt11's todo list 23:09:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2104 nor, --, ---, nobody, NEW, Filenames for buddy icons are not null-checked in the new conversation tab. 23:09:51 <nhnt11> flo-retina: I've been avoiding that because of C++ :P 23:09:52 * instantbot frowns at nhnt11 23:10:02 <flo-retina> nhnt11: then you should have said it! 23:10:09 <flo-retina> it's ONE line in the .cpp file 23:10:18 <nhnt11> I don't mind doing it, I might learn something 23:10:24 <flo-retina> qheaden: isn't this exactly what I asked? 23:10:27 <nhnt11> I'll take a look now :) 23:10:41 <qheaden> flo-retina: It is. I just wanted to make sure I understood your comments correctly 23:10:47 <flo-retina> qheaden: ok :) 23:11:01 * qheaden is trying to avoid another r-. ;) 23:11:10 <flo-retina> nhnt11: is a patch likely to appear in the next few minutes? 23:12:01 <flo-retina> qheaden: well, there's no guarantee that the next time is r+, as I couldn't focus on what the code was actually attempting to do, as it was obviously broken. 23:12:29 <qheaden> No prob. At least it shouldn't be for code style problems. :) 23:12:36 <nhnt11> flo-retina: I'm guessing I have to change aBuddyIconFilename.SetIsVoid(true) to aBuddyIconFilename = ""? 23:12:37 <flo-retina> yeah :) 23:13:01 <flo-retina> nhnt11: can you stop guessing, and start reading my review comments? :-P 23:13:35 <nhnt11> :O 23:13:38 <nhnt11> i thought I read that 23:13:49 <nhnt11> Sorry :] 23:13:56 <nhnt11> You basically gave me the fix :S 23:14:01 <flo-retina> yes 23:14:13 <flo-retina> that's why I was a little disappointed that it wasn't fixed yet ;) 23:14:27 * nhnt11 is happy he figured it out himself though 23:14:34 <nhnt11> well... somewhat 23:14:38 <flo-retina> heh :) 23:14:45 <flo-retina> = "" would have worked ;) 23:15:03 <flo-retina> just a tiny bit less efficient 23:15:10 <flo-retina> but we have some = "" in the code in other places 23:16:44 <nhnt11> flo-retina: Would "set it to an empty string." be an ok comment? 23:16:59 <flo-retina> no, it's useless 23:17:01 <nhnt11> or just | set it to "" | 23:17:14 <flo-retina> the comment is longer than the code itself 23:17:16 <nhnt11> There's already a comment saying set it to NULL... 23:18:01 <flo-retina> drop the comment 23:18:21 <nhnt11> ok 23:18:30 <flo-retina> I think the comment was because it's not immediately obvious that "void" means "null", or even that a string object can have null as a value 23:18:39 <instantbot> qheaden@phaseshiftsoftware.com requested review from florian@instantbird .org for attachment 2773 on bug 2112. 23:18:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2112 enh, --, ---, qheaden, ASSI, Abstract Buddy Request Code Into jsProtoHelper.js 23:18:51 <flo-retina> or if you want a comment, make it say "// No icon." 23:18:59 <flo-retina> that's a useful comment 23:19:41 <nhnt11> flo-retina: I already submitted it :S 23:19:41 <instantbot> nhnt11@gmail.com requested review from florian@instantbird .org for attachment 2774 on bug 2104. 23:19:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2104 nor, --, ---, nobody, NEW, Filenames for buddy icons are not null-checked in the new conversation tab. 23:20:06 * nhnt11 doesn't think it's confusing anyway 23:20:26 <flo-retina> nhnt11: weren't there || "" in a few places that needed to be removed now that they are pointless? 23:21:07 <flo-retina> nhnt11: btw, your commit messages would look nicer with a . at the end :-] 23:21:24 <flo-retina> (I probably don't fix them all the time, but I think we fixed some :)) 23:21:29 <nhnt11> After the r=fqueze? Ok 23:21:33 <flo-retina> yes 23:21:53 <flo-retina> thanks :) 23:21:55 <nhnt11> I can get a new patch out with the || "" stuff removed in a few minutes 23:22:10 <flo-retina> ok 23:22:19 <flo-retina> I don't remember how many we have added 23:22:52 <flo-retina> hmm, I don't see any 23:22:53 * nhnt11 can't find any 23:23:06 <flo-retina> I guess that's why it was broken ;) 23:23:27 <nhnt11> yeah :) 23:24:37 <flo-retina> alright, let's try the patch as is then :) 23:26:29 * flo-retina still isn't sure what to do with that yahoo patch 23:27:38 <qheaden> flo-retina: Which patch? For bug 2117? 23:27:42 <instantbot> florian@instantbird.org granted review for attachment 2774 on bug 2104. 23:27:43 <flo-retina> yeah 23:27:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2117 nor, --, ---, qheaden, ASSI, /invite should print a system message to show it's done something 23:27:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2104 nor, --, ---, nobody, NEW, Filenames for buddy icons are not null-checked in the new conversation tab. 23:27:52 <flo-retina> it's not totally clear the result of the string bikeshedding 23:28:23 <flo-retina> I dislike the string, but I also dislike a few other strings in that file, so it will likely need a string review before we consider releasing it 23:28:56 <qheaden> flo-retina: Yes, that's fine. 23:29:04 <flo-retina> that=? 23:30:27 <qheaden> flo-retina: So I remember, just r- it and mention that the strings need to be changed. 23:34:41 <instantbot> florian@instantbird.org denied review for attachment 2771 on bug 2117. 23:34:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2117 nor, --, ---, qheaden, ASSI, /invite should print a system message to show it's done something 23:35:32 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/626019dffd27 - Florian Quèze - Bug 1676 - 'function does not always return a value' warnings - fix macgestures.js, r=clokep. 23:35:33 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/9000222919c5 - Nihanth Subramanya - Bug 2104 - purplexpcom: file names for missing buddy icons should be empty, not null, r=fqueze. 23:35:34 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/457a34b0e89c - Florian Quèze - Bug 2123 - 'Unhandled CAP/ISUPPORT messages' warnings are too noisy, r=clokep. 23:35:35 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/423b93df54f8 - Florian Quèze - Bug 1750 - Warning: Use of Mutation Events is deprecated. Use MutationObserver instead - fix message themes, r=clokep. 23:41:24 * flo-retina is looking at bug 2112 and not sure if it's "r+" or "let's look after a night of sleep" 23:41:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2112 enh, --, ---, qheaden, ASSI, Abstract Buddy Request Code Into jsProtoHelper.js 23:41:37 <flo-retina> there's nothing obviously wrong at least :) 23:41:43 <qheaden> \o/ 23:42:09 <qheaden> Review it in your comfortable chair. It might bring along an r+. :) 23:42:42 * qheaden didn't realize it was past 1:00 A.M. in France. 23:42:58 <nhnt11> qheaden: almost 2am actually 23:43:07 <qheaden> Yeah. 23:43:25 <qheaden> I no longer feel alone staying up to 1, 2, or even 3 in the morning coding. :) 23:43:27 <flo-retina> nhnt11: yeah, although it would be difficult for me to complain to you that it's late here ;) 23:43:58 <nhnt11> flo-retina: I sleep in the evenings nowadays, it's the only way I can have enough time at a stretch to get work done and then go attend all of my classes 23:44:20 <flo-retina> qheaden: I spent all the (work)day in meetings and that was frustrating, so I need to look at some code to feel slightly better about having done something productive today ;). 23:44:33 <qheaden> :) 23:46:04 * qheaden wonders if the Yahoo prpl icon should be made purple. 23:46:22 * nhnt11 gets to work writing an "ibutils.sh" script with arguments to build tier_app, clobber, run a debug build, etc 23:46:40 <nhnt11> Bah, I should've done this a long time ago instead of dirty aliases 23:46:46 <-- clokep has quit (Ping timeout) 23:53:45 * qheaden wishes Firefox's mach build script would be ported for use with Instantbird. 23:55:15 <instant-buildbot> build #448 of macosx-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/448 23:55:28 <instantbot> florian@instantbird.org denied review for attachment 2773 on bug 2112. 23:55:30 <flo-retina> qheaden: what do you mean? 23:55:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2112 enh, --, ---, qheaden, ASSI, Abstract Buddy Request Code Into jsProtoHelper.js 23:55:38 <flo-retina> why does it need porting? 23:56:15 <qheaden> I think I actually meant the wrong thing. I was thinking about smartmake, made by Josh Matthews. It automatically builds the correct objdirs based on change source files. 23:56:58 <flo-retina> qheaden: is |make ib| too slow for you? 23:57:30 <qheaden> Its not too bad. Could be better on Windows though. 23:57:38 * qheaden waits for Windows jokes. 23:57:56 <qheaden> I'm going to reinstall my Linux partition tonight. 23:58:32 <instant-buildbot> build #456 of linux-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/456 23:59:31 <-- mconley has quit (Input/output error) 23:59:57 <flo-retina> qheaden: ah, on windows it will be painful if it goes into the instantbird/installer directory :(