All times are UTC.
00:00:30 --> florian has joined #instantbird 00:01:04 <-- florian has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:01:26 --> florian has joined #instantbird 00:01:57 <-- florian has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:02:26 --> florian has joined #instantbird 00:02:39 <florian> success \o/ 00:03:35 <nhnt11> This is for the magic copy bug? 00:05:48 <flo-retina> no 00:05:56 <flo-retina> I already have a patch there and I don't have any other idea 00:06:04 <flo-retina> (as my other idea didn't work) 00:06:15 * nhnt11 was wondering if flo had worked up some magic :P 00:07:53 <flo-retina> you'll see the patch soon, I'm filing the bug right now ;) 00:09:03 <flo-retina> nhnt11: I almost put you as a reviewer 00:09:05 <instantbot> New Instantbird (UI) bug 2114 filed by florian@instantbird.org. 00:09:06 <instantbot> florian@instantbird.org requested review from aleth@instantbird.o rg for attachment 2731 on bug 2114. 00:09:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2114 enh, --, ---, florian, ASSI, Chat rooms on hold should stay on hold after a restart 00:09:38 <flo-retina> as I know you know your way around conversation tabs stuff. But I'm not sure how much you've played with imWindows.jsm, and conversations on hold. 00:10:29 <nhnt11> I'll take a look anyway ;) 00:12:12 * flo-retina has wanted that feature for months 00:15:23 <nhnt11> flo-retina: The indent is wrong on line 172 :P 00:15:38 <nhnt11> But looks good, I want to try it :D 00:16:09 <-- Suiseiseki has quit (Ping timeout) 00:16:18 <flo-retina> nhnt11: it's not 00:16:30 * nhnt11 had a feeling it wasn't wrong 00:16:42 <nhnt11> Oh, brackets 00:16:57 <nhnt11> I read the nested ones wrong, sorry 00:17:36 --> mconley has joined #instantbird 00:17:47 <flo-retina> it's a little confusing 00:17:53 <flo-retina> I almost added another set of () 00:17:56 <flo-retina> but it doesn't really help 00:18:10 <flo-retina> another solution is to put the first 2 lines of the test in a separate function 00:18:14 <flo-retina> (as they are duplicated) 00:18:36 <nhnt11> Yeah.. 00:20:26 --> Suiseiseki has joined #instantbird 00:20:52 <-- Suiseiseki has quit (Client exited) 00:21:47 <Mook> this is _shouldShowConversation? 00:22:05 <flo-retina> yeah 00:22:23 <Mook> ... just have multiple return statements in sequence? 00:22:24 <flo-retina> the same 2 lines exist in registerConversation 00:23:23 * nhnt11 realizes he's written quite a bit of code for GSoC 00:23:24 <Mook> hmm, true. but registerConversation can also just early-return (though it's not as nice there, since the goal of that function isn't to return things) 00:25:33 --> Suiseiseki has joined #instantbird 00:26:40 <flo-retina> nhnt11, Mook: if I remove the duplication it looks like http://pastebin.instantbird.com/295979 00:27:23 <Mook> yep, looks better 00:27:24 <nhnt11> flo-retina: Do you have any suggestions for alternate naming of "kChannelsPerBatch"? It's the constant that holds the maximum number of channels per callback call 00:27:45 <flo-retina> why is there a maximum? 00:27:52 <Mook> I'd probably still split _shouldShowConversation just because I don't like multi-line conditionals, especially with your no-brace style. 00:28:40 <nhnt11> flo-retina: Er, the protocol returns that many channels per batch, but the last batch may have less than the others. 00:28:46 <flo-retina> heh, Mook dislikes my style :) 00:29:14 <flo-retina> nhnt11: my question is: why do we need that constant at all? 00:29:29 <flo-retina> nhnt11: do you prefer the version in the pastebin? 00:29:45 <nhnt11> flo-retina: The number is used in more than one place in the account implementation, so I made it a constant. 00:29:51 <-- mconley has quit (Input/output error) 00:29:53 <nhnt11> It's not a strict constant, just something the account sets for itself 00:29:57 <nhnt11> flo-retina: Yeah it's better 00:30:12 <nhnt11> I don't like the return statement though, it looks like a staircase :P 00:31:23 <nhnt11> (I mean the one on line 30) 00:31:51 <flo-retina> I don't see an obvious way to improve it 00:32:04 <nhnt11> flo-retina: Btw, line 27 should be removed right? 00:32:17 <flo-retina> oh yes 00:32:17 <nhnt11> Sure, nor do I :P 00:33:32 <-- florian has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:35:08 --> florian has joined #instantbird 00:35:15 <-- florian has quit (Quit: florian) 00:35:48 --> florian has joined #instantbird 00:37:34 <instantbot> florian@instantbird.org cancelled review?(aleth@instantbird.o rg) for attachment 2731 on bug 2114. 00:37:35 <instantbot> florian@instantbird.org requested review from aleth@instantbird.o rg for attachment 2732 on bug 2114. 00:37:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2114 enh, --, ---, florian, ASSI, Chat rooms on hold should stay on hold after a restart 00:38:39 * flo-retina wonders if Mook has ideas for bug 790 00:38:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=790 nor, --, ---, nobody, REOP, Some messages lost during magic copy 00:39:30 <Mook> r+ my patch so I can magic copy back on and I'll look :p 00:39:47 <flo-retina> which patch is this? 00:40:00 <Mook> I don't remember, I think I still have a thunderbird patch r? you? 00:40:14 <flo-retina> you do, but it seems completely unrelated 00:40:23 <flo-retina> it was simplifying some JS in a message theme IIRC 00:40:33 <Mook> I think that was blocking my checkin of the patch for magic copy? 00:40:40 <Mook> since that was your review comment... :) 00:41:49 <flo-retina> nah, your bug about magic copy is blocked on us syncing chat/ with Tb 00:41:58 <Mook> ah. possible! 00:42:01 <flo-retina> as your bug is already fixed in Instantbird 00:44:02 * Mook tries to remember where magic copy lives 00:44:10 <flo-retina> imThemes.jsm 00:44:53 <Mook> serializeSelection? yeah, okay 00:45:47 <flo-retina> Mook: it's not clear what https://bugzilla.mozilla.org/show_bug.cgi?id=760762 is blocked on 00:46:21 <flo-retina> my last comment looks like and r- comment (but with trivial changes to make) and "I would like aleth to have a look", but there's no r?aleth on the attachment :-S 00:46:27 <Mook> hrm. me neither 00:46:36 <Mook> err, not clear to me either. 00:47:38 <Mook> but, yes, all of your comments are addressed by the "make it use CSS more" bug, basically 00:47:44 <flo-retina> and the review on https://bugzilla.mozilla.org/show_bug.cgi?id=896216 is overdue (sorry) 00:47:45 <Mook> since P_list will no longer exist... 00:48:00 <flo-retina> ah 00:48:16 <flo-retina> but the patch in that bug applies above the patch in the unread ruler bug 00:48:38 <Mook> yeah 00:48:59 <Mook> I mean, either way they'll conflict all over each other :) 00:49:28 <flo-retina> alright, I'll try to make that CSSify everything patch one of the next 2-3 patches I review. 00:50:18 <flo-retina> Good night 00:50:28 <Mook> good night 00:50:50 <nhnt11> Good night 00:52:07 * nhnt11 will be back after a reboot 00:53:53 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:54:22 --> dew1 has joined #instantbird 00:55:00 <-- dew has quit (Ping timeout) 01:07:01 --> mconley has joined #instantbird 01:12:51 <-- mconley has quit (Input/output error) 01:15:18 --> nhnt11 has joined #instantbird 01:22:43 --> nakp has joined #instantbird 01:45:27 <-- nhnt11 has quit (Input/output error) 01:45:41 --> nhnt11 has joined #instantbird 02:38:48 --> skeledrew has joined #instantbird 02:53:58 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 02:56:40 <-- rosonline has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 02:57:06 --> nhnt11 has joined #instantbird 03:05:12 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 03:07:53 --> FireFly_TB has joined #instantbird 03:10:13 <instant-buildbot> build #944 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/944 03:15:33 --> mconley has joined #instantbird 03:22:46 <-- wnayes has quit (Quit: wnayes) 04:00:44 <instant-buildbot> build #945 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/945 04:14:17 <-- mconley has quit (Input/output error) 04:54:18 <-- skeledrew has quit (Ping timeout) 04:58:09 --> skeledrew has joined #instantbird 05:06:51 --> mconley has joined #instantbird 06:12:03 <instant-buildbot> build #1041 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1041 06:23:54 <-- nakp has quit (Quit: Saliendo) 06:25:56 <-- FireFly_TB has quit (Ping timeout) 06:29:59 --> FireFly_TB has joined #instantbird 06:30:10 --> EionRobb has joined #instantbird 06:35:17 <-- mconley has quit (Connection reset by peer) 06:35:45 --> mconley has joined #instantbird 07:01:28 <-- Mook has quit (Ping timeout) 07:05:00 --> Mook has joined #instantbird 07:05:50 <-- Mook has quit (Quit: Mook) 07:29:20 <-- mconley has quit (Input/output error) 07:53:43 --> iLobster has joined #instantbird 07:54:05 <iLobster> Greetings 07:54:11 <flo-retina> hello 07:56:15 <iLobster> I see there is one little problem in windows nightly. Floating window that show info of buddy is circumcised. I'll try to post screenshot now. 07:58:35 <iLobster> Something like this: https://dl.dropboxusercontent.com/u/15684099/cut.png 08:01:35 <flo-retina> Is this a recent regression? 08:02:11 <flo-retina> We fixed something related to the height of tooltips (on Mac at least) 30 hours ago. 08:02:12 <iLobster> I've noticed it for 2nd day (today and yesterday). 08:03:11 <iLobster> And what is strange - i have one buddy which floating window show normal - but it's only one such buddy. 08:05:01 <flo-retina> Is that the very first tooltip you display on each window that looks correct? 08:05:17 <iLobster> Yes - first one in list 08:05:36 <flo-retina> ok, that makes sense 08:05:54 <flo-retina> can you attach your screenshot to bug 2113? 08:05:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2113 nor, --, 1.5, florian, RESO FIXED, Buddy tooltips have incorrect sizes 08:06:02 <flo-retina> (and thanks for reporting the issue btw! :)) 08:06:38 <iLobster> But for exampe if i turn on offline buddies - first in list become another buddy - and his floating window is cut. 08:07:05 <flo-retina> I would expect the correct tooltip to be the first one that is displayed. Not the first buddy in the list. 08:07:29 <iLobster> May be, i'll check now 08:07:32 <-- iLobster has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 08:08:13 --> iLobster has joined #instantbird 08:09:26 <iLobster> Well, no. Right now i restarted IB and move mose on another buddy first. His window was full but only for first time. On second "mouse over" it was cut. 08:10:22 <flo-retina> yeah, first tooltip displayed is correct 08:11:00 <iLobster> But there is one buddy in my list which one's window display always correct. 08:13:52 <iLobster> Hmm. Now i checking list of channel participiants - all floating windows displays correct except my... =) 08:19:49 <iLobster> This patch from Bug 2113 is already in today's nightly? 08:19:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2113 nor, --, 1.5, florian, RESO FIXED, Buddy tooltips have incorrect sizes 08:20:05 <flo-retina> it was already in yesterday 08:20:31 <flo-retina> but it was a hack for a problem that we noticed only on Mac 08:20:43 <iLobster> I'll try to backup current profile and do fresh install 08:20:47 <flo-retina> so if we don't understand what's going on exactly, we can just add an ifdef XP_MACOSX around it 08:21:19 <-- iLobster has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 08:28:41 --> iLobster has joined #instantbird 08:28:59 <iLobster> Fresh install do not fixed it. 08:29:48 --> mconley has joined #instantbird 08:30:14 <flo-retina> not surprising. It started happening to you just when we changed something to code setting the size of the tooltips, so it really seems related to our change ;) 08:30:24 --> qlum has joined #instantbird 08:34:54 <-- mconley has quit (Ping timeout) 08:35:50 <iLobster> Time for screenshot session 08:35:56 <-- iLobster has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 08:50:45 --> iLobster has joined #instantbird 08:53:24 <iLobster> I attached screenshot to bug 2113's comment. I hope what I was trying to say is understandable =) 09:00:51 <flo-retina> iLobster: thank you very much! 09:01:03 <flo-retina> Screenshot 3 is the most surprising to me ;) 09:02:37 <instantbot> florian@instantbird.org cleared the Resolution 'FIXED' from bug 2113. 09:02:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2113 nor, --, 1.5, florian, REOP, Buddy tooltips have incorrect sizes 09:04:27 --> mconley has joined #instantbird 09:10:11 <-- florian has quit (Ping timeout) 09:10:16 <-- flo-retina has quit (Ping timeout) 09:10:23 <-- mconley has quit (Ping timeout) 09:11:03 --> florian has joined #instantbird 09:11:42 --> flo-retina has joined #instantbird 09:11:42 * ChanServ sets mode +qo flo-retina flo-retina 09:12:55 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 09:13:00 --> flo-retina has joined #instantbird 09:13:00 * ChanServ sets mode +qo flo-retina flo-retina 10:05:56 --> sabret00the has joined #instantbird 10:36:41 <-- EionRobb has quit (Quit: Leaving.) 10:41:15 <-- qlum has quit (Ping timeout) 10:41:37 --> qlum has joined #instantbird 11:02:04 --> jb has joined #instantbird 11:15:15 <-- jb has quit (Ping timeout) 11:45:38 --> jb has joined #instantbird 12:18:07 <-- jb has quit (Ping timeout) 12:32:02 --> gerard-majax__ has joined #instantbird 12:54:55 <-- Tonnes has quit (Quit: ChatZilla 0.9.90.1 [Firefox 23.0/20130730113002]) 13:08:28 --> aleth has joined #instantbird 13:08:28 * ChanServ sets mode +h aleth 13:22:55 --> Tonnes has joined #instantbird 13:23:09 --> Mnyromyr has joined #instantbird 13:30:05 --> nhnt11 has joined #instantbird 13:41:45 <-- nhnt11 has quit (Ping timeout) 13:42:38 --> nhnt11 has joined #instantbird 13:44:05 --> mconley has joined #instantbird 13:53:22 <-- mconley has quit (Input/output error) 13:57:13 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 13:57:28 --> nhnt11 has joined #instantbird 13:59:00 <nhnt11> Uh, why isn't the retina newtab ("+") icon displaying in the latest nightly? 13:59:32 <nhnt11> I didn't see it in the previous ones, so I don't know when it actually broke 14:00:04 <nhnt11> oh wow 14:00:06 <nhnt11> weird. 14:00:28 <nhnt11> so when I have enough tabs open to push the newtab button all the way to the edge, it's nice and crisp again 14:00:56 <nhnt11> It seems to have something to do with scaled resolutions 14:01:12 <nhnt11> everything looks fine at "best for retina display" (1440x900@2x) 14:01:23 <nhnt11> By @2x I mean HiDPI 14:01:42 <nhnt11> At 1920x1200 though it looks blurry unless it's pushed to the edge. weird. 14:03:07 * nhnt11 decides not to worry about it since it's fine at default resolution 14:07:38 --> mconley has joined #instantbird 14:10:42 <-- mconley has quit (Input/output error) 14:16:02 <-- nhnt11 has quit (Ping timeout) 14:16:27 * dew1 is now known as dew 14:21:58 --> nhnt11 has joined #instantbird 14:23:01 --> jb has joined #instantbird 14:41:10 --> mconley has joined #instantbird 14:47:06 <-- mconley has quit (Ping timeout) 14:50:15 <nhnt11> aleth: I thought about the reconnection stuff and moved the stuff in LISTEND to a separate function, which is also called in gotDisconnected() 14:51:03 <nhnt11> This has the side effect of needing kChannelsPerBatch in both irc.js and ircBase.jsm. Should I define the constant in both files, or define it in the ircAccount prototype and use this.kChannelsPerBatch (I've done the latter for now)? 14:52:18 <aleth> If that separate function is on the account, kChannelsPerBatch should be too 14:52:34 <nhnt11> alright then 14:53:28 <aleth> Btw I don't think resending LIST on reconnection is a good idea, as we might have been disconnected due to LIST flood... we'll have to gather some more feedback about that first ;) 14:55:14 <nhnt11> sounds good. 14:56:13 <nhnt11> I don't understand why a server would disconnect a client that sends a LIST request though. Why not just respond with an error saying "No. I'm not giving you any info."? 14:56:25 <nhnt11> I shouldn't really be asking that here though 14:56:27 <nhnt11> or anywhere, probably 14:56:27 * aleth sighs 14:56:36 <aleth> That would be reasonable, wouldn't it? ;) 14:57:21 <aleth> Afaik the disconnection (I've never seen one so far) happens inadvertently because the number of messages sent at once is interpreted as flooding 14:57:53 <nhnt11> I consider that very weird since it's the server that's doing the flooding :P 14:57:59 <aleth> Yeah... 14:58:16 <nhnt11> But yeah debates on IRC are probably not the most productive thing to be doing right now :P 14:58:23 <nhnt11> s/on/about 14:58:27 <aleth> Maybe it's all historical anecdotes and no longer a problem :P Here's hoping 14:58:47 <aleth> I'd say lets land this and find out. 14:58:53 <nhnt11> alright then 14:59:06 <nhnt11> I've already addressed the rest of your comments 14:59:16 <aleth> But I'm sure you can find plenty of whingeing about IRC in the logs :D 14:59:35 <nhnt11> :P 15:03:21 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 15:05:16 --> nhnt11 has joined #instantbird 15:06:43 <-- FireFly_TB has quit (Ping timeout) 15:10:42 --> FireFly_TB has joined #instantbird 15:11:52 <nhnt11> aleth: I've named the function that does the LISTEND stuff _listEnd. Is that ok? 15:12:17 <nhnt11> How about onListEnd? Or listTerminated or something 15:12:56 <nhnt11> http://pastebin.instantbird.com/296746 15:16:40 <aleth> It doesn't quite fit if you call it on gotDisconnected. How about returnFinalRoomInfo or finishRoomInfo or sendLastRoomInfo or something like that? 15:17:28 <nhnt11> Hmm 15:18:04 <aleth> If you are putting it under requestRoomInfo that is 15:18:18 <aleth> One is called to start the process, one on completion 15:18:28 <nhnt11> Makes sense 15:18:34 <nhnt11> I think I like "sendLastRoomInfo" the best. 15:19:02 <aleth> or sendRemainingRoomInfo 15:19:09 <nhnt11> Yeah I thought of that 15:19:14 <nhnt11> how about sendPendingRoomInfo? 15:19:18 <nhnt11> No that's not good 15:20:13 <nhnt11> aleth: I use "remainingChannels" and "remainingChannelCount" in the function, so how about sendRemainingChannels? 15:20:49 <aleth> I think I prefer roomInfo there as that's what's used in requestRoomInfo 15:20:55 <nhnt11> right 15:22:09 <nhnt11> http://pastebin.instantbird.com/296747 15:22:16 <nhnt11> Is that comment ok? 15:24:52 <aleth> You don't have to say what calls it 15:25:20 <aleth> Something like "Pass roomInfo for any remaining channels to callbacks and tidy up" 15:25:38 <nhnt11> ok 15:28:09 <nhnt11> aleth: I don't think it's needed to tell callbacks whether they received /all/ rooms or if there was a problem 15:28:27 <nhnt11> I've added a boolean to indicate whether the batch being returned is the final one though 15:28:30 <aleth> If it's not needed right now, leave it out 15:29:03 <aleth> The boolean indicating the final batch does seem like good practice though ;) 15:30:02 <-- jb has quit (Ping timeout) 15:30:16 <aleth> What I wanted you to check was the sequencing between sendRemainingRoomInfo and the account-disconnected notification handling in the awesometab 15:30:39 <aleth> So things get done in the right order\ 15:30:56 <nhnt11> aleth: I don't think that matters too much 15:31:11 <nhnt11> the only thing that's done in the account-disconnected handling is to remove it from the queue 15:31:15 <nhnt11> if it was already there. 15:31:28 <aleth> It doesn't remove existing entries for that account? 15:31:39 <nhnt11> Oh yeah it does 15:31:43 <aleth> ... 15:31:46 * nhnt11 seems to be forgetting his own code 15:33:38 <nhnt11> aleth: The order is fine 15:33:54 <nhnt11> reportDisconnected is called after _sendRemainingRoomInfo 15:33:54 <aleth> OK 15:35:20 <instantbot> nhnt11@gmail.com cancelled review?(clokep@gmail.com) for attachment 2727 on bug 2066. 15:35:21 <instantbot> nhnt11@gmail.com requested review from clokep@gmail.com for attachment 2733 on bug 2066. 15:35:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should suggest chat rooms 15:37:12 <instantbot> nhnt11@gmail.com requested review from florian@instantbird .org for attachment 2734 on bug 2066. 15:37:31 <-- iLobster has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 15:37:40 <nhnt11> I'm heading for dinner 15:37:42 <nhnt11> bbl 15:38:31 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 15:42:39 <instantbot> aleth@instantbird.org denied review for attachment 2733 on bug 2066. 15:42:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should suggest chat rooms 15:59:56 <flo-retina> aleth: the tooltip bug was quite visible, so if you never noticed, I think it's safe to assume it didn't exist on Linux ;) 16:00:36 <aleth> OK... FWIW I don't like the new width anyway, it's too narrow ;) 16:02:08 --> wnayes has joined #instantbird 16:02:17 <flo-retina> aleth: I think nhnt11 also finds it too narrow. 16:02:27 <flo-retina> It would be nice to know what the previous width was 16:02:35 <aleth> It seemed dynamically set afaik 16:02:41 <flo-retina> it still is 16:02:50 <flo-retina> the width that we set is the minimum 16:03:08 <flo-retina> but again, the behavior seems to be stupidly different across OSes, so it's possible we aren't seeing the same thing at all 16:03:13 <aleth> well... https://i.minus.com/jCfu56ey6fCCa.png 16:03:41 <flo-retina> yeah, there's nothing there that can't wrap to 200px width 16:03:55 <aleth> And so it looks terrible. 16:04:12 <flo-retina> actually, the width is more like 250px on your screenshot 16:04:27 <aleth> I guess you're right and there must have been a default value before, just a better one 16:04:58 <flo-retina> s/better/larger/ ;) 16:10:32 * flo-retina wonders if there's an ETA for the review of bug 2114 :-] 16:10:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2114 enh, --, ---, florian, ASSI, Chat rooms on hold should stay on hold after a restart 16:10:54 <aleth> I'd like to get to that later today 16:11:15 <aleth> Especially as it's a much wanted feature :) 16:13:15 <flo-retina> ah, if you want it too, I'm not worried for the time the review will wait :-D 16:13:32 <instantbot> aleth@instantbird.org denied review for attachment 2734 on bug 2066. 16:13:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should suggest chat rooms 16:13:52 <flo-retina> but yeah, it's the kind of stuff that after coding... you want to use :-] 16:14:43 <aleth> It also obsoletes an add-on that is currently slightly broken ;) 16:15:06 <aleth> Which seems better to me than fixing the add-on... 16:15:31 <aleth> Well, it's not a perfect replacement I guess. 16:15:44 <aleth> But it goes a long way. 16:17:46 <flo-retina> is that hide auto-joins? 16:17:52 <aleth> Yes 16:17:57 <flo-retina> I didn't know it was broken 16:18:06 <aleth> For password-protected channels 16:18:11 <flo-retina> ah 16:18:26 <flo-retina> /invite seems broken for those too 16:18:44 <flo-retina> (and I initially typed that without space before /invite, and it just disappeared... no error message :S) 16:18:55 <aleth> That sounds like a bug... 16:19:12 <aleth> ...probably two bugs :P 16:19:49 <flo-retina> there's not even an error in the error console :-S 16:20:26 <-- florian has quit (Ping timeout) 16:20:52 <aleth> I suppose you invited seems, broken, for, those, and too, and they didn't respond ;) 16:21:31 <flo-retina> aleth: re bug 2066 and the timer, isn't it nice to drop the references to all the cached room infos after an hour if the user doesn't touch the awesometab at all? 16:21:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should suggest chat rooms 16:21:49 <flo-retina> aleth: seems likely 16:21:57 <flo-retina> aleth: would have been fun to have the 5 of the appearing here ;) 16:22:22 <aleth> flo-retina: That would be reasonable, but it's not what the timer does 16:23:22 <flo-retina> hmm 16:23:27 <flo-retina> iirc the code I read on pastebin did that :-S 16:25:01 --> florian has joined #instantbird 16:25:17 <-- flo-retina has quit (Input/output error) 16:25:58 --> flo-retina has joined #instantbird 16:25:58 * ChanServ sets mode +qo flo-retina flo-retina 16:28:38 <flo-retina> we had an IRC discussion about this timer (not sure if it was yesterday or the day before). 16:29:05 <flo-retina> I wonder if the attached patch is really the latest one 16:43:04 --> gp has joined #instantbird 16:43:15 <-- florian has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 16:47:52 --> florian has joined #instantbird 16:49:47 <-- florian has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 16:49:54 --> rosonline has joined #instantbird 16:53:47 <-- FireFly_TB has quit (Ping timeout) 16:58:02 --> florian has joined #instantbird 16:58:56 <-- florian has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 16:59:46 --> florian has joined #instantbird 16:59:54 <gp> Hello, are instantbird extensions supposed to work with thunderbird chat? I might be interested in developing an Off the Record messaging extension for thunderbird chat and I'd like to find out how to hook this functionality in thunderbird (I have some experience with OTR but no experience with thunderbird/instantbird development). 17:01:37 <florian> gp: hello :). Instantbird extensions don't usually work "out of the box" in Thunderbird, but for addons that don't touch the UI, usually the changes required to port an Instantbird add-on to Thunderbird is just listing Thunderbird in the install manifest. 17:02:22 --> jb has joined #instantbird 17:06:45 <gp> florian: There will be a UI to show to the user the stored public keys/ask the user to verify a public key etc, but I guess can figure out how to code that from other thunderbird extensions. I'll have a look at message transformating extensions for instantbird to see how it's done. Apart from that, is there any online documentation somewhere maybe? 17:10:04 <flo-retina> there's some documentation on https://wiki.instantbird.org/Main_Page 17:12:08 <flo-retina> https://hg.instantbird.org/addons/file/546b657cdcbe/rot13/bootstrap.js was intended to be an example of how someone could integrate an encryption addon. But I'm afraid it uses the same code pattern that an add-on that broke with the update to mozilla 22 :(. 17:15:31 <-- florian has quit (Input/output error) 17:16:42 --> florian has joined #instantbird 17:17:10 <-- florian has quit (Input/output error) 17:18:12 <gp> flo-retina: thanks for the code. If I understand correctly, bootstrap.js only uses im* components; is mozilla 22 supposed to change those? I'd expect im* components to be managed by thunderbird. 17:19:14 <flo-retina> all the im* stuff is shared between Instantbird and Thunderbird 17:19:25 <flo-retina> (and more generally, all the code that is in the chat/ folder in our source trees) 17:20:37 --> florian has joined #instantbird 17:20:51 <gp> ok, that's nice 17:21:42 <-- florian has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 17:29:35 --> florian has joined #instantbird 17:30:09 <flo-retina> aleth: that tooltip stuff confuses me :( 17:30:37 <flo-retina> after removing the sizeTo line, I get the same behavior as when I had it with 0 on both values. I can't seem to get back the behavior I had before the patch :S. 17:30:43 <flo-retina> And I do have -purgecaches on my command line. 17:31:23 <aleth> Hmm. Maybe an attribute persists somewhere? 17:34:10 <aleth> Quick way to check - does a new profile have the same behaviour? 17:37:47 <-- florian has quit (Input/output error) 17:41:07 --> flo-dbg has joined #instantbird 17:51:06 --> nhnt11 has joined #instantbird 17:51:17 <nhnt11> Hi 17:51:21 * nhnt11 is back after finishing up a lab report 17:51:36 <nhnt11> aleth: I agree on the width being too narrow yeah 17:51:50 <nhnt11> But I don't think that us setting it to 200px is exactly the problem 17:52:01 <nhnt11> It should increase on its own shouldn't it 17:52:03 <nhnt11> when required. 17:52:08 <aleth> It does. 17:52:19 <aleth> (read the scrollback) 17:52:21 <aleth> ;) 17:53:00 <nhnt11> Reading 17:54:07 <nhnt11> flo-retina: The attached patch is the latest one 17:54:17 <nhnt11> I moved the dropping references part to addObservers 17:54:30 <nhnt11> because of a thought flow I had which I can't quite remember now 17:54:41 <nhnt11> Right now putting it in the timer makes more sense 18:00:48 <nhnt11> aleth: your comment about removing the timer seems obvious now that we have isRoomInfoStale, thanks 18:01:30 <flo-dbg> aleth: a new profile shows the initial bug again. But I'm still confused ;). 18:06:26 <instantbot> aleth@instantbird.org denied review for attachment 2732 on bug 2114. 18:06:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2114 enh, --, ---, florian, ASSI, Chat rooms on hold should stay on hold after a restart 18:24:37 <-- nhnt11 has quit (Input/output error) 18:29:08 --> nhnt11 has joined #instantbird 18:49:16 <nhnt11> new patch coming up 18:52:07 <instantbot> nhnt11@gmail.com cancelled review?(florian@instantbird .org) for attachment 2734 on bug 2066. 18:52:08 <instantbot> nhnt11@gmail.com requested review from florian@instantbird .org for attachment 2735 on bug 2066. 18:52:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should suggest chat rooms 18:53:09 <instantbot> nhnt11@gmail.com cancelled review?(clokep@gmail.com) for attachment 2733 on bug 2066. 18:53:10 <instantbot> nhnt11@gmail.com requested review from clokep@gmail.com for attachment 2736 on bug 2066. 18:57:23 <instantbot> aleth@instantbird.org granted review for attachment 2736 on bug 2066. 18:57:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should suggest chat rooms 19:06:06 <flo-retina> nhnt11: it looks like the default tooltip width was small before the patch 19:06:37 <flo-retina> it seems it just resized more eagerly 19:06:47 <-- flo-dbg has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 19:11:29 <instantbot> aleth@instantbird.org granted review for attachment 2735 on bug 2066. 19:11:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should suggest chat rooms 19:11:42 <nhnt11> \o/ 19:11:43 <nhnt11> Thanks aleth 19:17:25 <-- wnayes has quit (Ping timeout) 19:21:53 --> wnayes has joined #instantbird 19:24:40 <-- nhnt11 has quit (Input/output error) 19:25:10 --> nhnt11 has joined #instantbird 19:28:36 --> florian has joined #instantbird 19:28:52 <-- florian has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 19:34:31 --> florian has joined #instantbird 19:37:25 * flo-retina has tried to make the changes aleth requested, and is confused by the behavior he's now observing :( 19:38:25 <-- florian has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 19:40:02 <aleth> flo-retina: I was also wondering if there needs to be something which cleans up the pref over time, so it doesn't accumulate a list of channels which were joined as a one-off, closed automatically on shutdown, but are not autojoined 19:40:22 <flo-retina> hmm 19:40:37 <flo-retina> aleth: I guess what we really want is channels joined through the UI to be focused ;) 19:40:49 <aleth> Basically this is an artifact of the missing session restore 19:41:00 <aleth> flo-retina: nhnt11 is going to fix that for us after gsoc ;) 19:41:07 * flo-retina hopes the inconsistent behavior he was seeing was just JS-IRC being confused 19:41:30 --> florian has joined #instantbird 19:42:19 <flo-retina> aleth: when the join chat dialog doesn't close, there's an exception somewhere, right? 19:43:12 <aleth> I'm not sure. There should be... 19:43:42 <flo-retina> there's nothing in the error console, nothing on the terminal 19:43:44 <flo-retina> (of course) 19:44:10 <aleth> Debug log? 19:45:30 <flo-retina> nothing interesting in it 19:45:34 <flo-retina> the channel was joined normally 19:46:15 <aleth> Strange that the dialog didn't close then 19:46:21 <-- florian has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 19:46:55 --> florian has joined #instantbird 19:47:33 <flo-retina> I added a try catch in joinchat.js 19:48:03 <flo-retina> that prints: [Exception... "'TypeError: this._account is undefined' when calling method: [prplIConversation::account]" nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)" location: "JS frame :: .../components/imConversations.js :: ConversationsService.prototype.getConversationByNameAndAccount :: line 448" data: no] 19:48:37 <aleth> Is that where the attempt to focus goes wrong? 19:50:03 <flo-retina> my guess is that JS-IRC doesn't delete the conversation object from one of its datastructures when I part the channel (click "close conversation" on the tab's context menu actually), and then returns it immediately when i join again. But it returns the old object 19:50:06 <flo-retina> or something along those lines 19:50:29 <-- florian has quit (Input/output error) 19:50:37 <aleth> Do you have STR for this? 19:50:48 --> florian has joined #instantbird 19:51:50 <flo-retina> aleth: yes. Connect a moznet account with #instantbird and #chatdev in auto-join. Click "close conversation" on #chatdev's tab. Press Command+J to open the Join Chat dialog, attempt to join #chatdev again. 19:52:58 <flo-retina> oh wait, the account's joinChat method doesn't return anything 19:53:29 <flo-retina> it's joinchat.js that calls let conv = Services.conversations.getConversationByNameAndAccount(name, account, true); 19:54:48 <aleth> Hmm 19:54:53 <aleth> Sounds like a latency problem 19:55:08 <flo-retina> hmm, could be that my code throws an exception in imWindows.jsm when closing a tab 19:55:19 * flo-retina hates hidden exceptions/errors :( 19:55:34 <-- qlum has quit (Quit: Getting the <censored> out.) 19:56:01 <-- florian has quit (Input/output error) 19:56:20 * aleth thought he would get around to finishing the participant context menus today :-/ 19:56:21 --> florian has joined #instantbird 19:56:50 <flo-retina> aleth: and I thought I would fix the default min width in 5 minutes, then address your comments in another 5 minutes ;) 19:57:19 <aleth> so it goes... ;) 19:57:31 --> mconley has joined #instantbird 19:57:36 <aleth> good night! 19:57:39 <-- aleth has quit (Quit: Ciao) 20:05:57 <-- jb has quit (Connection reset by peer) 20:06:03 --> jb has joined #instantbird 20:07:57 <flo-retina> oh well, maybe I'll understand this mess tomorrow... 20:07:59 <flo-retina> Good night 20:08:00 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 20:09:45 <-- florian has quit (Ping timeout) 20:12:08 <-- mconley has quit (Input/output error) 20:18:33 --> unghost has joined #instantbird 20:27:43 <-- jb has quit (Ping timeout) 20:32:14 --> jb has joined #instantbird 20:33:18 --> EionRobb has joined #instantbird 20:33:53 <-- jb has quit (Ping timeout) 20:34:23 --> jb has joined #instantbird 20:42:37 --> mconley has joined #instantbird 20:48:33 <-- mconley has quit (Ping timeout) 20:51:37 <-- jb has quit (Ping timeout) 20:54:07 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 20:54:30 <-- gerard-majax__ has quit (Ping timeout) 21:23:31 --> mconley has joined #instantbird 21:41:54 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105]) 21:43:47 <-- unghost has quit (Ping timeout) 21:46:27 --> florian has joined #instantbird 21:55:47 <-- florian has quit (Ping timeout) 22:10:13 --> florian has joined #instantbird 22:27:53 <-- florian has quit (Ping timeout) 22:47:50 <-- gp has quit (Quit: gp) 22:59:01 --> skeledrew1 has joined #instantbird 22:59:19 <-- skeledrew has quit (Ping timeout) 23:04:29 <-- mconley has quit (Input/output error) 23:20:24 <-- Suiseiseki has quit (Ping timeout) 23:21:56 --> Suiseiseki has joined #instantbird 23:36:43 --> mconley has joined #instantbird