All times are UTC.
00:53:00 --> jb has joined #instantbird 00:54:09 --> dew1 has joined #instantbird 00:54:51 <-- dew has quit (Ping timeout) 01:08:24 <-- Mook_as has quit (Quit: Mook_as) 01:15:07 <-- jb has quit (Ping timeout) 02:07:33 --> jb has joined #instantbird 02:17:27 <instant-buildbot> build #1039 of win32-nightly-default is complete: Failure [failed compile] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1039 02:32:12 <-- jb has quit (Ping timeout) 02:37:20 --> Mook has joined #instantbird 02:38:25 --> jb has joined #instantbird 02:50:28 <-- jb has quit (Ping timeout) 02:54:04 --> jb has joined #instantbird 03:08:05 <instant-buildbot> build #942 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/942 03:34:51 <-- jb has quit (Ping timeout) 03:37:28 --> jb has joined #instantbird 03:53:05 <-- jb has quit (Ping timeout) 03:54:42 --> jb has joined #instantbird 04:28:31 --> mconley has joined #instantbird 04:38:49 <-- mconley has quit (Input/output error) 04:41:19 <-- jb has quit (Ping timeout) 04:58:50 <instant-buildbot> build #943 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/943 05:48:00 <-- EionRobb has quit (Quit: Leaving.) 06:12:59 --> EionRobb has joined #instantbird 06:27:22 <-- Mook has quit (Quit: Mook) 08:01:10 <-- wnayes has quit (Ping timeout) 08:05:31 --> wnayes has joined #instantbird 08:51:30 --> aleth has joined #instantbird 08:51:30 * ChanServ sets mode +h aleth 09:24:33 <-- gerv has left #instantbird () 09:25:09 <-- aleth has quit (Quit: Ciao) 09:25:39 --> aleth has joined #instantbird 09:25:39 * ChanServ sets mode +h aleth 09:32:57 <-- aleth has quit (Quit: Ciao) 09:33:44 --> aleth has joined #instantbird 09:33:44 * ChanServ sets mode +h aleth 09:42:55 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 09:43:08 --> flo-retina has joined #instantbird 09:43:08 * ChanServ sets mode +qo flo-retina flo-retina 09:45:45 --> dionisos has joined #instantbird 09:54:24 <-- dionisos has quit (Ping timeout) 10:05:40 --> dionisos has joined #instantbird 10:15:38 <-- dionisos has quit (Ping timeout) 10:23:45 <instantbot> aleth@instantbird.org granted review for attachment 2712 on bug 2078. 10:23:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2078 nor, --, 1.5, nhnt11, REOP, Home/End in newtab filterbox don't work as expected 10:28:55 --> dionisos has joined #instantbird 10:31:27 <-- dionisos has quit (Ping timeout) 10:41:19 --> dionisos has joined #instantbird 10:42:58 <-- dionisos has quit (Ping timeout) 10:46:40 <instantbot> florian@instantbird.org denied review for attachment 2719 on bug 2105. 10:46:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2105 min, --, ---, qheaden, ASSI, Tags Service Should Provide a Default Contact Group 10:47:14 --> dionisos has joined #instantbird 10:50:10 <-- dionisos has quit (Ping timeout) 11:04:48 --> dionisos has joined #instantbird 11:07:16 <instantbot> florian@instantbird.org cancelled review?(florian@instantbird .org) for attachment 2658 on bug 2076. 11:07:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2076 nor, --, ---, nhnt11, ASSI, Offline contacts no longer appear with reduced opacity 11:10:11 <-- dionisos has quit (Ping timeout) 11:15:35 <instantbot> aleth@instantbird.org denied review for attachment 2690 on bug 2091. 11:15:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2091 nor, --, ---, qheaden, ASSI, /join chatroom does not do anything. 11:18:05 --> dionisos has joined #instantbird 11:20:41 <-- dionisos has quit (Ping timeout) 11:46:34 --> nhnt11 has joined #instantbird 11:46:57 <nhnt11> Hi aleth :) 11:47:06 <aleth> Hi :) 11:48:10 <aleth> How's it going? 11:48:32 <aleth> Do you need any more feedback on bug 2066? We should land that asap so we have all the different listitem types in place for nightly testing and finetuning. 11:48:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should suggest chat rooms 11:51:01 <nhnt11> I should finish that up yeah 11:51:27 <nhnt11> Haven't looked at it in a couple days, wanted a change :P 11:51:35 <aleth> Not surprising ;) 11:52:01 <aleth> Then again, just wait for the naming bikeshedding on your database stuff :P 11:52:10 <nhnt11> -_-' 11:52:29 <nhnt11> There's actually not too much naming there so far! :) 11:58:48 <-- EionRobb has quit (Quit: Leaving.) 11:59:32 <nhnt11> I'm going to grab something to eat, bbl. 12:48:49 * flo-retina wonders if there's anything currently in his review queue that's blocking nhnt11 12:53:26 <nhnt11> flo-retina: Nothing blocking, no :) 12:53:32 <flo-retina> cool :) 12:54:03 <nhnt11> flo-retina: Though if you have a minute to look at bug 2066, I'd appreciate any feedback you have on the API 12:54:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should suggest chat rooms 13:10:42 <aleth> Maybe update the patch first, it's hard to tell what your current state is there. 13:11:42 <nhnt11> Fair enough 13:15:56 <aleth> nhnt11: btw have you seen https://developer.mozilla.org/en-US/docs/Creating_JavaScript_callbacks_in_components 13:16:15 <aleth> In particular the function attribute 13:17:07 <nhnt11> aleth: Yes, I think flo pointed me to that earlier :) 13:17:25 <aleth> It should clarify the current API :) 13:31:58 --> jb has joined #instantbird 13:32:37 --> mconley has joined #instantbird 13:37:10 <-- jb has quit (Ping timeout) 13:49:02 --> jb has joined #instantbird 13:52:21 <-- jb has quit (Quit: jb) 13:53:11 --> jb has joined #instantbird 13:58:29 <instantbot> florian@instantbird.org denied review for attachment 2681 on bug 2066. 13:58:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should suggest chat rooms 14:00:48 <nhnt11> flo-retina: removeRoomInfoCallback isn't needed unless a consumer wants to remove the callback before it gets removed by the prplAccount (which is when all available rooms have been received) 14:01:01 <nhnt11> I don't see a way to avoid having it altogether 14:01:26 <flo-retina> what goes wrong if you don't have it? 14:02:35 <nhnt11> If an addon is disabled/uninstalled for example 14:03:00 <nhnt11> It would need a way to remove the callback. 14:03:21 <nhnt11> I'm not happy with the api. I'm going to take a good amount of time tonight and rethink some of it and make it simpler. 14:04:51 <aleth> How about a try/catch around calling the callback? Would that be enough? 14:04:59 <aleth> Hopefully reading the link I posted above will clarify some things ;) 14:09:28 <flo-retina> aleth: why would the callback throw in that case? 14:10:18 <flo-retina> aleth: (we may still need a try catch to protect the core code from breaking if a callback is poorly implemented in an add-on, but that's not directly related to needing removeRoomInfoCallback) 14:11:11 <aleth> flo-retina: If nothing goes wrong, there is no problem. If it does, we'll get decent error reporting and won't break the whole IRC message handling sequence. 14:11:15 <flo-retina> "16:02:36 - nhnt11: If an addon is disabled/uninstalled for example It would need a way to remove the callback." I don't think I agree with this. I think it could get away with just ensuring the callback returns early if the add-on is disabled. 14:11:39 <aleth> flo-retina: Basically I agree with you and was suggesting a way to do it ;) 14:11:54 <flo-retina> aleth: for me the reason to remove callbacks is to avoid leaks, not to avoid throwing. Callbacks shouldn't throw (or they are broken). 14:12:25 <nhnt11> flo-retina: So now you gave me another reason to want removeRoomInfoCallback :P 14:12:33 <flo-retina> ? 14:12:34 <aleth> flo-retina: The problem with "callbacks shouldn't throw" is that you get nothing useful in the error console for them if they do. 14:12:50 <nhnt11> To avoid leaks 14:12:56 <flo-retina> aleth: I'm not saying we don't need a try catch (we likely do). Just that it's unrelated. 14:13:15 <flo-retina> nhnt11: I thought that was the initial reason for wanting it :-S. 14:13:33 <aleth> flo-retina: It's unrelated apart from that it makes the code more tolerant to bad callback implementations in add-ons 14:13:33 <nhnt11> Er... :] 14:13:43 <aleth> nhnt11: What other reason do you have for it? 14:13:47 <nhnt11> I figured addons that were removed shouldn't keep their callbacks in memory 14:13:48 <flo-retina> nhnt11: I don't mind if we leak the callback until the account is done receiving the list of accounts (ie. a leak of _one_ JS object for a few seconds). 14:13:54 <nhnt11> but I never associated it with the word "leak" :P 14:14:07 <nhnt11> It could be longer than a few seconds 14:14:11 <nhnt11> e.g. freenode 14:14:26 <aleth> Not significantly longer though ;) 14:14:41 <flo-retina> nhnt11: just waiting for the garbage collector and cycle collector to run will take a few seconds ;) 14:14:54 <nhnt11> Right 14:15:02 <aleth> nhnt11: Btw I forgot to mention you should clear the list of callbacks on IRC disconnects 14:15:12 <nhnt11> I seem to be confusing myself with this whole thing -_-' 14:15:16 <flo-retina> nhnt11: my point really is that we shouldn't add APIs for corner cases that have never happened. 14:15:39 <flo-retina> aleth: and on errors while processing LIST results, right? 14:15:50 <flo-retina> (even if the error doesn't cause the account to be disconnected) 14:15:54 * nhnt11 is unable to resize his blist window 14:16:22 <aleth> flo-retina: Yes, if we can think of some ;) 14:16:50 <aleth> (i.e. they would have to prevent LIST_END from being received) 14:17:08 <flo-retina> aleth: hmm, yeah 14:48:14 <-- nhnt11 has quit (Ping timeout) 15:03:29 * qheaden_away is now known as qheaden 15:03:35 <qheaden> Hello everyone. 15:06:38 <qheaden> flo-retina: That comment you recommended for defaultTag was fine, but after looking at the name of the attribute, it would seem that any comment would be pretty redundant. 15:06:49 <qheaden> "defaultTag" seems pretty self-explanitory. 15:12:21 --> nhnt11 has joined #instantbird 15:17:58 <nhnt11> Hmm, my facebook account is saying "not authorized" all of a sudden 15:18:13 <nhnt11> I haven't changed any passwords and Facebook is loading fine in Firefox 15:22:00 <aleth> qheaden: you might like this http://fitzgeraldnick.com/weblog/50/ 15:22:39 <nhnt11> aleth ++ 15:23:07 * nhnt11 was writing some Java code the other day while helping a friend and found himself using JS syntax shortcuts -_-' 15:23:58 <qheaden> aleth: Interesting! :) 15:39:24 <instantbot> qheaden@phaseshiftsoftware.com requested review from florian@instantbird .org for attachment 2721 on bug 2105. 15:39:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2105 min, --, ---, qheaden, ASSI, Tags Service Should Provide a Default Contact Group 15:46:23 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 16:03:31 <qheaden> flo-retina: HTML tags in messages are supposed to automatically be parsed right? Like a font tag changing the formatting of the message. 16:15:35 --> nhnt11 has joined #instantbird 16:22:35 <-- flo-retina has quit (Ping timeout) 16:32:38 <instantbot> New Core - Yahoo! Messenger bug 2111 filed by qheaden@phaseshiftsoftware.com. 16:32:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2111 nor, --, ---, nobody, NEW, Yahoo Web Client Causes Endless Typing Notification 16:33:05 --> Mook_as has joined #instantbird 16:45:02 <-- jb has quit (Ping timeout) 16:56:45 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2722 on bug 2095. 16:56:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2095 nor, --, ---, qheaden, ASSI, MUC participants don't leave the MUC when they go offline 16:58:06 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 16:59:49 --> nhnt11 has joined #instantbird 17:06:43 --> jb has joined #instantbird 17:19:29 <-- jb has quit (Ping timeout) 17:23:39 <nhnt11> qheaden: Are you still seeing the buddy icon problem consistently? 17:23:53 <nhnt11> I can't seem to reproduce it. 17:24:27 <nhnt11> Most of my Facebook friends' buddy icons don't show up, regardless of open conversations, and those that do disappear when a conv is open. 17:24:52 <nhnt11> And the icons in awesometab are consistent with the ones in the conv header so I'm sticking with my theory that awesometab isn't responsible 17:27:21 <qheaden> nhnt11: Yes, I can consistently reproduce it. 17:27:30 <qheaden> FWIW, I have GTalk buddies and Yahoo buddies. 17:27:36 <nhnt11> I have gtalk buddies too 17:27:49 <nhnt11> They're working fine 17:28:00 <qheaden> Weird. 17:28:10 --> jb has joined #instantbird 17:49:19 --> flo-retina has joined #instantbird 17:49:19 * ChanServ sets mode +qo flo-retina flo-retina 17:55:04 <-- flo-retina has quit (Ping timeout) 17:59:46 --> flo-retina has joined #instantbird 17:59:46 * ChanServ sets mode +qo flo-retina flo-retina 18:01:26 <-- flo-retina has quit (Ping timeout) 18:01:40 --> flo-retina has joined #instantbird 18:01:40 * ChanServ sets mode +qo flo-retina flo-retina 18:03:22 <-- jb has quit (Connection reset by peer) 18:05:40 <flo-retina> qheaden: I don't understand your plan in comment 1 of bug 2109. 18:05:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2109 enh, --, ---, nobody, NEW, jsProtoHelper Should Provide Automatic Buddy Icon Caching 18:06:16 <flo-retina> are you proposing a way to avoid duplicating icons on the disk if a contact uses the same icon and yahoo and gtalk but one protocol uses md5 and the other uses sha1 as the hashing mechanism? 18:06:36 <flo-retina> s/icon and/icon for/ 18:07:07 <qheaden> flo-retina: No. There will be one icon cache per protocol. 18:07:17 <flo-retina> qheaden: and HTML in messages is supposed to work; not sure exactly what the question was. 18:07:25 <flo-retina> qheaden: ah. Why? 18:08:01 <qheaden> flo-retina: I suppose one cache can be used, but there would have to be a single way to determine if the cache needs to be updated. 18:08:04 <flo-retina> wait, per protocol or per account? 18:08:20 <qheaden> Well, probably per account. 18:09:13 <qheaden> Should we perhaps hash image data to determine uniqueness? That's my issue right now. 18:09:36 <qheaden> How are we to determine the cached image is "dirty", and needs an update? 18:09:44 <flo-retina> qheaden: well, my first problem was that I didn't know what you were trying to do exactly 18:09:54 <qheaden> Oh okay. 18:10:12 <flo-retina> qheaden: because there are different ways to approach this 18:10:29 <flo-retina> either you can just "do something that will pretend to work" (it's a bit what JS-XMPP currently does) 18:10:29 <qheaden> Currently, both JS-XMPP and my JS-Yahoo uses caching. I'm just trying to move support into jsProtoHelper. 18:10:41 <flo-retina> or really do the work 18:11:27 --> jb has joined #instantbird 18:11:29 <qheaden> It would be nice if we could bypass all of the different schemes that protocols use to determine image uniqueness, and determine it client-side. 18:12:13 <qheaden> Since icons are normally small, perhaps we can hash the image file. 18:12:21 <-- flo-retina has quit (Ping timeout) 18:12:53 --> flo-retina has joined #instantbird 18:12:53 * ChanServ sets mode +qo flo-retina flo-retina 18:13:20 <flo-retina> so I guess what I'm saying is that you can make this either quite simple (if you just want to have things that look on the screen like they are not more broken with JS-Yahoo than they were with libpurple-Yahoo), or quite complicated if you really want to fix the issue. 18:14:05 <flo-retina> crap, my sucky internet connection had eaten half of what I said :( 18:15:26 <flo-retina> 20:10:41 - flo-retina: or really do the work 18:15:26 <flo-retina> 20:10:52 - flo-retina: really doing the work means getting rid of libpurple's icon cache 18:15:26 <flo-retina> 20:11:00 - flo-retina: and merge everything into a single cache for all accounts 18:15:26 <flo-retina> 20:11:28 - flo-retina: I also think somehow we should keep old icons, and when displaying a log of a conversation we should be able to show the icon the contact had _at the time_ next to his messages. 18:15:26 <flo-retina> 20:11:57 - flo-retina: so to do that we would kinda need a database, maybe similar to what Firefox does with favicons 18:15:27 <flo-retina> 20:12:21 - flo-retina: or maybe just dump everything into a single file, and manage ourselves the position of each icon within it. 18:16:32 <qheaden> flo-retina: Well, I don't want to get too caught up in the complicated side of this. It can be a small project in itself. 18:16:36 <flo-retina> qheaden: libpurple's got some code to handle caching http://lxr.instantbird.org/instantbird/source/purple/libpurple/buddyicon.c 18:16:41 <qheaden> So perhaps I can add simple caching for now. 18:17:19 <qheaden> flo-retina: So what do you suggest I go about doing? Leave everything for now or what? 18:17:46 <flo-retina> not sure :) 18:18:08 <flo-retina> I guess, propose something that you like and fits your purpose, and see if reviewers are happy :) 18:19:54 <-- jb has quit (Ping timeout) 18:21:19 <qheaden> flo-retina: Well, I'll do more designing before I start writing code. I don't want to waste time writing code that needs to be demolished later. ;) 18:21:33 <qheaden> flo-retina: What other improvements would you like to see made to jsProtoHelper? 18:21:54 <nhnt11> flo-retina: Btw, the reason I need a chat attribute in addition to a source attribute is because UI conversations may or may not be chats 18:22:00 <flo-retina> I guess you mean "that are related to stuff used by yahoo" ;) 18:22:05 <nhnt11> er, existing* conversations 18:22:26 <flo-retina> nhnt11: do you mean you can have source=chat and chat=false at the same time? 18:22:40 <nhnt11> No, but it can have source!=chat and chat=true at the same time 18:23:41 * qheaden is going to work on abstracting buddy requests 18:24:20 <instantbot> florian@instantbird.org denied review for attachment 2721 on bug 2105. 18:24:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2105 min, --, ---, qheaden, ASSI, Tags Service Should Provide a Default Contact Group 18:24:32 <flo-retina> qheaden: ok :). 18:24:56 <flo-retina> qheaden: really, any time you think that you are copy/pasting stuff from another prpl, it's a sign that it needs abstraction :) 18:25:15 <qheaden> :) 18:26:19 --> jb has joined #instantbird 18:27:17 <-- mconley has quit (Connection reset by peer) 18:27:36 --> mconley has joined #instantbird 18:27:53 <qheaden> flo-retina: How should this be indented? http://pastebin.instantbird.com/294263 18:29:36 <flo-retina> qheaden: http://pastebin.instantbird.com/294264 18:30:20 <flo-retina> I wish we could write "tag ||= Services.tags.defaultTag;" on the previous line, but I don't think we have a ||= operator 18:30:29 <qheaden> flo-retina: I'll use the last one. It is the only one that doesn't pass 80 characters. 18:30:45 --> Mnyromyr has joined #instantbird 18:30:51 <flo-retina> ah, I thought it was still above 80 chars :) 18:35:25 <instantbot> qheaden@phaseshiftsoftware.com requested review from florian@instantbird .org for attachment 2723 on bug 2105. 18:35:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2105 min, --, ---, qheaden, ASSI, Tags Service Should Provide a Default Contact Group 18:41:39 <-- aleth has quit (Quit: Ciao) 18:52:28 <-- jb has quit (Ping timeout) 18:57:56 <nhnt11> flo-retina: Btw I used requestRoomInfo to make it consistent with requestBuddyInfo above it. I'll change it if you'd like. 18:58:34 <nhnt11> also I'm going ahead and removing removeRoomInfoCallback, since you're fine with leaking till it's removed in LISTEND 18:58:54 <instantbot> New Core - Yahoo! Messenger bug 2112 filed by qheaden@phaseshiftsoftware.com. 18:58:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2112 enh, --, ---, nobody, NEW, Abstract Buddy Request Code Into jsProtoHelper.js 18:59:29 <nhnt11> Also I included the RoomInfo constructor in jsProtoHelper assuming it will be of use to account implementations in the future. I'll remove it if you think it won't. 19:06:12 * nhnt11 can't believe he left a Cu.reportError in a submitted patch. 19:09:11 <nhnt11> flo-retina: Instantbird won't be fetching room lists every hour unless an observer is added. 19:09:51 <nhnt11> Though I do see a potential bug there, it's not too bad, I think. 19:11:16 <qheaden> nhnt11: I've had countless Cu.reportError near-misses since the coding period started. :P 19:11:33 <nhnt11> :P 19:12:35 <nhnt11> On second thought, I don't see any problems that could arise from the timer, so I'm leaving it as it is. 19:13:04 <nhnt11> It may add an account id that is no longer connected, but there is a check for that so nothing will happen anyway 19:16:34 <qheaden> I'll be back a little later on. 19:17:00 * qheaden is now known as qheaden_away 19:21:24 <-- nhnt11 has quit (Ping timeout) 19:35:41 --> nhnt11 has joined #instantbird 20:36:57 <flo-retina> nhnt11: "21:06:12 * nhnt11 can't believe he left a Cu.reportError in a submitted patch [â¦]" my solution to never do that is to never indent lines that I don't intend to keep in final patches. That way even if I forget to remove them, it's totally obvious they weren't meant to be there if someone looks at the code 20:37:19 <flo-retina> nhnt11: isn't an observer added the first time someone opens the awesometab? 20:37:38 <nhnt11> The awesometab /is/ the observer 20:37:55 <nhnt11> Whenever new awesometabs are added, the room lists are refreshed if needed 20:38:01 <flo-retina> nhnt11: so once the awesometab is closed, there's no observer any more 20:38:10 <nhnt11> i.e. if a new account connected, or 1 hour has passed 20:38:11 <nhnt11> yes 20:38:18 <flo-retina> oh wait, I read setTimeout as if it was setInterval 20:39:04 <nhnt11> ah 20:39:40 <flo-retina> so why do you refresh once after one hour, and not every hour? 20:40:37 * flo-retina pokes dew1 20:41:54 <nhnt11> flo-retina: It needn't be refreshed after an hour 20:42:10 <nhnt11> It's added to a queue after an hour, and the next time an observer is added, the accounts in the queue are requested 20:42:15 <flo-retina> I guess I'm very confused about what that code is attempting to do, and will need to read it again :-S 20:42:17 <nhnt11> Does that make sense? 20:45:29 <flo-retina> uh, I'm afraid I still have a nit in qheaden's patch :-S 20:45:49 <flo-retina> the list of files in chat/locales/jar.mn seems to be sorted alphabetically :-/ 20:51:37 * qheaden_away is now known as qheaden 20:51:40 <qheaden> I'm back. 20:55:40 <flo-retina> :) 20:55:45 <instantbot> florian@instantbird.org granted review for attachment 2723 on bug 2105. 20:55:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2105 min, --, ---, qheaden, ASSI, Tags Service Should Provide a Default Contact Group 20:56:24 <qheaden> \o\ \o/ /o/ 21:01:22 <instantbot> qheaden@phaseshiftsoftware.com requested review from florian@instantbird .org for attachment 2724 on bug 2105. 21:01:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2105 min, --, ---, qheaden, ASSI, Tags Service Should Provide a Default Contact Group 21:03:14 <instantbot> florian@instantbird.org granted review for attachment 2724 on bug 2105. 21:05:10 <qheaden> flo-retina: Are there any utility classes that help parse HTML tags? 21:05:28 <flo-retina> like an HTML parser? 21:05:44 <qheaden> Yeah. I'm just trying to extract font tags and their attributes. 21:06:13 <flo-retina> want do you want to do? Get rid of the font tag completely, or just change the size value? 21:06:29 <qheaden> flo-retina: Change the size value to what HTML recognizes. 21:06:44 <qheaden> Did you see my comment on why the big-letter issue happens? 21:06:46 <flo-retina> is that what libpurple does? 21:06:57 <flo-retina> yeah, I saw that it's pt values when it shouldn't 21:07:06 <qheaden> Yes, libpurple does some conversion. 21:07:19 <flo-retina> but I was wondering if you just wanted to drop the default value, rather than replacing it with something valid 21:07:47 <flo-retina> if you want to change the value, I think I would just use a regexp 21:07:51 <qheaden> You mean remove the size value completely? 21:08:01 <flo-retina> if you want to drop it, you likely need to remove the </font> too, which would be more complicated 21:08:25 <qheaden> Yeah. 21:08:33 <qheaden> I think using regexp to change the size value is the best method. 21:10:59 <flo-retina> nhnt11: ok, so what made me assume I was seeing a setInterval is "// We force-refresh the chat room list every hour." 21:11:11 <nhnt11> Yeah that's bad I guess 21:11:17 <nhnt11> I'll write a better comment for the next patch 21:13:37 <flo-retina> hmm, can I be more annoying? :-P 21:14:11 <flo-retina> if you open the awesometab, chat room lists will be requested, and the result stored in the stats service as PossibleConversation objects. 21:14:47 <flo-retina> if you open the awesometab again 2 hours later, the first thing that will happen is we drop references to all the previous PossibleConversation objects for possible chats, and start requesting them again. Is this right or am I mis-reading something again? 21:17:00 <nhnt11> No 21:17:08 <qheaden> flo-retina must be sitting in his new chair. He is sharp on reviewing today. :P 21:17:21 <flo-retina> qheaden: no, I'm just on PTO. 21:17:25 <nhnt11> Oh yeah 21:17:31 <nhnt11> that does happen. 21:17:40 <nhnt11> That's not what I intended... 21:17:42 <qheaden> :P 21:17:43 * nhnt11 scratches his head 21:17:50 <flo-retina> nhnt11: I bought another 3 chairs since the one I showed Wednesday evening :-D. 21:18:12 <flo-retina> that was for qheaden :( 21:18:31 <qheaden> IKEA loves you! :P 21:19:56 <flo-retina> qheaden: all second hand. For 12.54, 5 and 5 euros respectively :-D. 21:20:10 <qheaden> Wow! That's a deal. 21:20:10 --> qlum has joined #instantbird 21:20:11 <-- qlum has quit (Quit: qlum) 21:20:29 * nhnt11 is confused what to do 21:20:43 <nhnt11> removing all chat rooms before requesting was a way to ensure removal of rooms that no longer exist 21:21:36 <nhnt11> kind of an edge case though 21:21:37 <flo-retina> qheaden: the last 2 were on a flea market. I had to cross the whole flea market with the car to put them in the trunk, and the AMI was quite an attraction in the crowd :-D. 21:22:02 <qheaden> flo-retina: The AMI fit them? 21:22:07 <flo-retina> nhnt11: does the new awesometab get cached data before it's dropped on the floor? 21:22:23 <nhnt11> no :( 21:22:44 <flo-retina> nhnt11: then you should drop the data when it expires (ie in the one hour timer) rather than when we fetch the new one 21:22:59 <nhnt11> Hmm, makes sense 21:26:13 <nhnt11> flo-retina: Hw 21:26:14 <nhnt11> sorry 21:26:18 <nhnt11> How's this comment? http://pastebin.instantbird.com/294487 21:26:54 <qheaden> flo-retina: This seems like a pretty crude fix for bug 2110, but it works well. http://pastebin.instantbird.com/294488 21:26:58 <flo-retina> much better :) 21:26:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2110 maj, --, ---, nobody, NEW, Formatted Incoming Messages Always Shown With Large Letters 21:27:57 <flo-retina> qheaden: I think you want to use a function as the second parameter of the .replace call 21:28:08 <flo-retina> to parse the value you are replacing, and generate a new sensible value based on it 21:28:16 <qheaden> Then again, it would mess up if someone sends a message with size="3" in it. 21:28:29 <qheaden> Rather, size="<digit>" 21:28:41 <flo-retina> yeah 21:28:54 <flo-retina> you need to add <font as part of the regexp 21:28:58 <qheaden> Yeah. 21:33:41 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105]) 21:34:45 <-- skeledrew has quit (Ping timeout) 21:51:12 <-- mconley has quit (Input/output error) 21:59:17 <-- flo-retina has quit (Ping timeout) 22:00:45 --> jb has joined #instantbird 22:00:45 --> flo-retina has joined #instantbird 22:00:45 * ChanServ sets mode +qo flo-retina flo-retina 22:01:01 --> EionRobb has joined #instantbird 22:21:19 --> mconley has joined #instantbird 22:38:18 <flo-retina> reviewing patches that are long and mostly correct is pretty boring :-S 22:41:22 <nhnt11> flo-retina: To which one are you referring? :) 22:41:40 <flo-retina> nhnt11: I'm looking at aleth's patch in bug 451 22:41:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=451 nor, --, ---, aleth, NEW, Participants Need Context Menu 22:42:33 <nhnt11> Oh nice, that will be nice once it lands 22:52:45 <-- wnayes has quit (Ping timeout) 22:54:47 --> wnayes has joined #instantbird 23:10:18 <-- nhnt11 has quit (Ping timeout) 23:11:49 <-- jb has quit (Ping timeout) 23:15:21 <-- mconley has quit (Quit: Leaving...) 23:15:36 --> nhnt11 has joined #instantbird 23:19:50 --> jb has joined #instantbird 23:25:05 * qheaden is now known as qheaden_away 23:28:40 <instantbot> florian@instantbird.org denied review for attachment 2543 on bug 451. 23:28:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=451 nor, --, ---, aleth, NEW, Participants Need Context Menu 23:32:18 <flo-retina> (almost r+) 23:32:26 <nhnt11> :)