#instantbird log on 07 25 2013

All times are UTC.

00:10:33 <-- jb has quit (Ping timeout)
00:12:08 <-- rosonline has quit (Client exited)
00:36:19 --> mconley has joined #instantbird
00:45:23 <-- wnayes has quit (Ping timeout)
00:48:55 --> wnayes has joined #instantbird
00:58:03 <instant-buildbot> build #428 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/428
01:02:38 <-- Mook_as has quit (Quit: Mook_as)
01:04:52 <-- skeledrew has quit (Ping timeout)
01:09:23 --> skeledrew has joined #instantbird
01:20:16 --> jb has joined #instantbird
01:27:09 * clokep isn't going ot hav etime to look voer things tonight.
01:27:11 <clokep> Sorry. :(
01:44:02 <-- jb has quit (Connection reset by peer)
01:44:08 --> jb has joined #instantbird
01:57:05 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
02:31:57 <-- jb has quit (Quit: jb)
02:37:11 --> jb has joined #instantbird
02:41:09 <-- wnayes has quit (Quit: wnayes)
02:46:05 <-- jb has quit (Ping timeout)
03:05:30 <instant-buildbot> build #920 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/920
03:07:02 <-- mconley has quit (Input/output error)
03:15:33 --> mconley has joined #instantbird
03:25:28 <-- mconley has quit (Input/output error)
03:25:48 --> nhnt11 has joined #instantbird
03:28:30 <nhnt11> clokep: I only meant that the first part of that sentence to have meant that you suggested looking at the error handling. Sorry for the terrible way I said it.
04:14:06 <-- nhnt11 has quit (Ping timeout)
04:14:30 --> nhnt11 has joined #instantbird
04:19:30 <-- nhnt11 has quit (Ping timeout)
04:19:55 --> nhnt11 has joined #instantbird
04:23:15 <-- nhnt11 has quit (Ping timeout)
04:23:44 --> nhnt11 has joined #instantbird
04:27:04 <-- nhnt11 has quit (Ping timeout)
04:27:28 --> nhnt11 has joined #instantbird
04:31:14 <-- nhnt11 has quit (Ping timeout)
04:31:41 --> nhnt11 has joined #instantbird
04:35:35 <-- nhnt11 has quit (Ping timeout)
04:35:59 --> nhnt11 has joined #instantbird
04:36:41 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
04:48:05 <instant-buildbot> build #920 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/920
05:22:50 --> FireFly_TB has joined #instantbird
05:44:00 <-- EionRobb has quit (Quit: Leaving.)
05:52:13 <instant-buildbot> build #1016 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1016
06:20:00 --> nhnt11 has joined #instantbird
06:30:06 <-- nhnt11 has quit (Ping timeout)
06:30:29 --> nhnt11 has joined #instantbird
06:33:49 <-- nhnt11 has quit (Ping timeout)
06:34:14 --> nhnt11 has joined #instantbird
06:38:24 <-- nhnt11 has quit (Ping timeout)
06:38:47 --> nhnt11 has joined #instantbird
06:44:37 <-- nhnt11 has quit (Ping timeout)
06:45:00 --> nhnt11 has joined #instantbird
06:45:30 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
06:51:40 <-- nhnt11 has quit (Ping timeout)
06:52:03 --> nhnt11 has joined #instantbird
07:20:30 <-- nhnt11 has quit (Ping timeout)
07:20:33 --> nhnt11 has joined #instantbird
07:24:10 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
07:36:33 <-- FireFly_TB has quit (Quit: FireFly_TB)
07:38:22 --> chrisccoulson has joined #instantbird
07:44:54 --> FireFly_TB has joined #instantbird
07:56:29 <-- FireFly_TB has quit (Quit: FireFly_TB)
08:10:53 --> FireFly_TB has joined #instantbird
08:25:22 --> mpmc has joined #instantbird
08:29:33 <-- FireFly_TB has quit (Ping timeout)
08:55:24 <-- gerard-majax has quit (Ping timeout)
09:01:42 <-- dew has quit (Ping timeout)
09:46:57 --> gerard-majax has joined #instantbird
10:05:23 --> clokep has joined #instantbird
10:05:23 * ChanServ sets mode +o clokep 
10:19:37 --> novabyte has joined #instantbird
10:24:03 <clokep> Quiet in her today. ;)
10:27:42 <clokep> here...
10:40:50 <instantbot> clokep@gmail.com denied feedback for attachment 2636 on bug 2066.
10:40:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should display chat rooms
10:54:03 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
11:07:48 --> aleth has joined #instantbird
11:07:48 * ChanServ sets mode +h aleth 
11:20:34 --> Mic has joined #instantbird
11:20:35 * ChanServ sets mode +h Mic 
11:41:22 --> clokep_ has joined #instantbird
11:54:59 <instantbot> aleth@instantbird.org denied feedback for attachment 2636 on bug 2066.
11:55:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should display chat rooms
11:59:13 <aleth> I see clokep_ can do checkins now :)
12:01:56 <instantbot> clokep@gmail.com denied review for attachment 2632 on bug 1982.
12:01:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1982 nor, --, ---, qheaden, ASSI, Create Yahoo! Messenger Protocol Plug-In
12:02:04 <clokep_> aleth: I can, but we keep r-ing everyhting. :P
12:02:59 <aleth> I see clokep_ could do checkins now ;)
12:03:09 <clokep_> :-D
12:03:19 * aleth has hopes for bug 2055 though...
12:03:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2055 enh, --, ---, nhnt11, ASSI, New conversation tab needs to display open conversations and those on hold.
12:05:52 <clokep_> Yes.
12:05:58 <clokep_> aleth: What do you think about those IRC changes for LIST?
12:07:08 <clokep_> Oh, you commented. :)
12:07:16 * clokep_ thinks we're on the same page. ;)
12:07:46 * aleth thinks so too.
12:15:18 <clokep_> :)
12:19:32 --> atuljangra has joined #instantbird
12:32:08 <Mic> Could we maybe make the tab tooltips explain the colors of highlighted tabs?
12:32:26 <clokep_> Could we make the tab colors not suck? :)
12:32:32 <Mic> e.g. with something like "Number of unread messages: [red]123[/red]"
12:32:32 <aleth> I think I should just finish that patch to fix the colours :D
12:32:50 <Mic> "Messages directed at you: [blue]4[/blue]"
12:33:08 <Mic> Maybe even with the styling from the convs on hold unread counters?
12:33:09 <aleth> But I'm not against adding something like that to the tooltip
12:38:47 <Mic> Such long labels might not play nicely with the other items on the tooltip though :S
12:39:50 <Mic> atuljangra: how's it going?
12:40:02 <clokep_> I don't really think putting a "key" like that is a good idea, personally.
12:40:10 <clokep_> Do you think people are confused by the colors?
12:40:15 <clokep_> What's your reasoning for wanting to add this?
12:40:23 <clokep_> If the colors don't obviously show something we shouldn't be using them.
12:40:51 <aleth> Couldn't we simply add the unread counter complete with styling to the tooltip, without explanation?
12:40:57 <aleth> (as in the blist)
12:41:11 <Mic> How do you expect a color to convey a message like "Unread messages directed at you"?
12:41:26 <aleth> I don't think the keys are needed either
12:44:11 <clokep_> Mic: To me if you use a "brighter" color it means "more important", vs. a slight change in the color of the tab. I think it's the kind of thing you get after using it once or twice.
12:44:19 <clokep_> I'm not saying you should immediately get it.
12:44:33 <clokep_> But if it's something you can't get after using the program for 20 seconds, there's an issue.
12:45:12 --> jb has joined #instantbird
12:47:24 <Mic> I think (any) color for unread messages is easy to understand because when switching to a tab with such a color it is obvious that there are new messages. I'm not sure about the color of directed messages though.
12:48:13 <Mic> Maybe if we'd scroll to a directed message when switching to a tab with the directed-message highlighting, the color and it's cause would be obviously be linked.
12:48:20 <aleth> For the tab colour patch, I was thinking of using a similar colour for unread and ping, with ping being brighter in some way.
12:49:02 * clokep_ would really prefer if ping matched unread in a private conversation.
12:49:14 <aleth> That's already in the patch ;)
12:49:18 <Mic> That's a good idea too.
12:49:32 <Mic> So we have a color for signal and one for noise? :P
12:49:38 <Mic> Noise should be grey then :P
12:50:42 <aleth> "if we'd scroll to a directed message when switching to a tab with the directed-message highlighting, the color and it's cause would be obviously be linked." That might be worth trying
12:51:27 <aleth> "Noise should be grey then" or animated static? :D
13:00:04 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client)
13:01:04 * aleth wonders what the media tag is actually for in nhnt11's patch
13:01:43 <Mic> Something I had in mind for a while now: panels with arrows up and down shown in a corner of the conversation to jump between sections and directed messages.
13:02:00 <Mic> If someone wants to turn this idea into an add-on, please do so.
13:02:12 <clokep_> Mic: Maybe double arrows above/below the scroll bar?
13:02:38 <Mic> clokep_: please not, I always hated scrollbars with more than one button at each end ;)
13:03:46 <clokep_> :P Do you ever even use them?
13:03:53 * clokep_ doesn't know the last time he used a scrollbar...
13:04:07 <Mic> I do if I need to scroll a far way quickly.
13:04:21 <Mic> That is the scrollbar. I use the buttons rarely.
13:04:52 <Mic> I've experimented with canvas to show indicators next to the scrollbar but that wasn't really successful since I didn't extract the y-position of the messages from the conversation.
13:06:08 <Mic> It's possible, by the way, to get the number, position and height of scrollbar buttons.
13:07:26 <-- mpmc has quit (Connection reset by peer)
13:09:04 <clokep_> :-D
13:09:16 * clokep_ wonders if atuljangra has made any progress today...
13:13:05 <-- jb has quit (Quit: jb)
13:18:27 <-- novabyte has quit (Ping timeout)
13:18:29 --> novabyte has joined #instantbird
13:22:20 --> atuljangra has joined #instantbird
13:23:09 * Mic hates that some protocols don't show buddy icons for offline people :(
13:23:52 <atuljangra> Mic: I'm not working much today. My parents are here to visit me.(as I described in the mail a couple of days earlier) In the night, I'll be working on the remaining fallback mechanism. 
13:31:55 <clokep_> Mic: Yes, some of them don't cache.
13:31:59 <clokep_> Which one is it in particular?
13:32:10 <Mic> ICQ/Aim
13:32:47 <clokep_> Maybe if I finish my oscar code I can add that. :P
13:33:13 <Mic> Can't we solve that for all prpls at once?
13:33:21 <clokep_> I don't know.
13:33:35 <clokep_> I think some prpls save stuff to files, others keep it in memory?
13:33:46 <clokep_> (Seems like libpurple should handle that, to me.)
13:36:34 <Mic> Can't we load the image and cache it from imContacts when the prpl sends a notification that the icon has changed?
13:37:09 <Mic> Sorry, from imContacts doesn't make sense at all.
13:37:38 <Mic> I mean if we could cache it instead of forwarding the buddyIconFilename getter to the preferredBuddy here: http://lxr.instantbird.org/instantbird/source/chat/components/src/imContacts.js#787
13:37:52 <Mic> And update the image when the prpl tells us that something has changed?
13:38:05 --> mconley has joined #instantbird
13:39:15 --> mconley_ has joined #instantbird
13:39:52 <clokep_> Possibly...
13:40:25 <-- mconley has quit (Ping timeout)
13:52:31 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
13:58:36 --> chrisccoulson has joined #instantbird
14:02:07 <clokep_> I thought we had a bug like this before: https://bugzilla.mozilla.org/show_bug.cgi?id=897961 but I can't find it...
14:02:38 --> mconley has joined #instantbird
14:03:11 <-- mconley_ has quit (Ping timeout)
14:06:32 <aleth> bug 1413
14:06:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1413 nor, --, ---, nobody, NEW, angle bracket-delimited URL linkified with closing bracket included in link and semi-colon appended 
14:07:40 <clokep_> aleth: Ah, you're awesome. :)
14:28:24 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client)
14:39:47 <-- novabyte has quit (Quit: bye bye)
14:41:15 --> atuljangra has joined #instantbird
14:47:34 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2637 on bug 2044.
14:47:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2044 nor, --, ---, nobody, NEW, New tab item styling not optimal on Linux
14:50:18 <clokep_> Ping me if that's uploaded. ;)
14:55:11 <aleth> Done
14:56:31 <aleth> NB that doesn't resolve that bug, but it's the changes that don't just affect the newtab. nhnt11 can fix the rest ;)
14:59:21 <clokep_> aleth: Honestly those mostly look the same. :( Should I kick this review to Mic?
14:59:42 <aleth> If you prefer
15:00:13 <aleth> Ah, on the screenshot before the change, no item is hovered. The hovered item background is currently -moz-dialog (gray)
15:00:26 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client)
15:02:39 <clokep_> aleth: Wait, so that just removes a section and them combines ifdefs?
15:03:27 <aleth> clokep_: Yes (and turns on that OSX alternating row rule for Linux too, not sure why it's not wanted on Windows)
15:04:41 <Mic> aleth: you almost never see that on Windows. And I never liked it when I still had Linux and a Gnome desktop ;)
15:04:50 <-- gerard-majax has quit (Ping timeout)
15:04:52 <instantbot> clokep@gmail.com granted review for attachment 2637 on bug 2044.
15:04:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2044 nor, --, ---, nobody, NEW, New tab styling not optimal on Linux
15:04:57 --> atuljangra has joined #instantbird
15:05:24 <aleth> Mic: I was hesitating about it actually... maybe if it turns out I dislike it in nightlies I'll revert that change in a followup ;)
15:05:56 <aleth> It does improve readability.
15:06:23 <aleth> clokep_ has something to check in now ;)
15:07:09 <Mic> Congratulations for that, clokep :)
15:07:31 <Mic> How did you solve your access rights problems in the end?
15:07:41 <clokep_> aleth: I'm not checking that in until Florian is back.
15:07:50 <clokep_> Mic: We decided Mercurial fixed their https issues.
15:08:24 <clokep_> (UI stuff still goes through Florian.)
15:08:50 <aleth> clokep_: FYI http://log.bezut.info/instantbird/130716/#m344, but fair enough
15:09:34 <clokep_> aleth: Does the download manager now use alternating rows on Linux? ;)
15:09:57 <aleth> clokep_: It's got it's very own non-native styling ;)
15:10:02 <aleth> s/it's/its
15:10:23 <clokep_> Hahah, OK.
15:11:58 <aleth> but yeah, I'd just like to try it in nightlies for a bit, precisely to get feedback.
15:12:10 <clokep_> Right.
15:12:17 * clokep_ is just curious why it isn't that way to start with.
15:12:28 <clokep_> Well if I have other things to push I'll take a look...
15:28:01 <Mic> bye
15:28:03 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
15:30:20 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client)
15:42:07 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2640 on bug 2044.
15:42:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2044 nor, --, ---, nobody, NEW, New tab styling not optimal on Linux
15:44:18 <instantbot> aleth@instantbird.org cancelled review?(clokep@gmail.com) for attachment 2640 on bug 2044.
15:44:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2044 nor, --, ---, nobody, NEW, New tab styling not optimal on Linux
15:46:10 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2640 on bug 2044.
15:52:25 --> nhnt11 has joined #instantbird
15:54:48 <nhnt11> clokep_: That code really wasn't ready for review :P
15:54:55 <clokep_> I can tell.
15:54:59 <clokep_> And I r+ed it. ;)
15:55:03 <aleth> My code?
15:55:08 <clokep_> Oh.
15:55:10 <clokep_> Hah.
15:55:11 <clokep_> Wrong person. :)
15:55:31 <clokep_> nhnt11: Which code is this? I gave my feedback on it and some other review comments.
15:55:37 <clokep_> I'm not really sure what you're referring to.
15:55:53 <aleth> clokep_: I don't think anyone remembered the purpose of that CSS rule, certainly flo didn't mention it when I asked ;)
15:55:59 <nhnt11> never mind sorry
15:56:15 <clokep_> nhnt11: f? and r? aren't that different to me. ;)
15:56:20 <nhnt11> i seem to have read feedback denied as review denied on my phone
15:56:22 <clokep_> I was only looking over like 4 files so I gave nits too.
15:56:24 <nhnt11> ok :P
15:56:55 <aleth> nhnt11: Which reminds me that once your MUC patch lands, you should ask jamie for f? on a11y issues of the newtab.
15:57:18 <aleth> nhnt11: Feedback is feedback no matter whether r or f ;)
16:01:11 <clokep_> Is that service patch going to be ready to land today?
16:03:16 <aleth> Depends on what Mic says
16:03:22 <nhnt11> aleth: http://log.bezut.info/instantbird/130725/#m129 for hidpi icons
16:03:37 <aleth> nhnt11: aha! good to know, thanks
16:04:07 * nhnt11 is eating, excuse his typos if any
16:36:06 <nhnt11> aleth: What do you think about changing the MUC icon next to the "Join chat" string to a throbber after clicking, until the chat is actually joined?
16:37:44 <aleth> nhnt11: That would also work, though throbbers are much more annoying imho
16:38:00 <aleth> Btw how do you know when to close the newtab?
16:38:08 <aleth> Do you listen for conversation-loaded?
16:38:55 <nhnt11> aleth: The only way I can think of is to listen for new-ui-conversation and check if it's the chat we want
16:39:21 <aleth> ah, that's better than conversation-loaded
16:40:54 <nhnt11> I suggest the throbber because we dont know how long it'll take to open the chat
16:41:33 * nhnt11 doesn't like this and wants to work on the api change.. but it'll be too time consuming most likely
16:41:39 <aleth> Does it usually take that long?
16:42:02 <nhnt11> No but it might. There's also the question of error handling...
16:43:06 <aleth> You can look at improving the API around opening new conversations later after this lands.
16:43:27 <aleth> Error handling is an issue whether the API is changed or not...
16:43:50 <nhnt11> If the API is changed, it may be easier.. that's all I'm saying.
16:44:25 <aleth> It's possible, but I wouldn't count on it
16:44:47 <aleth> I don't think we currently handle those errors at all outside the error console?
16:45:01 <nhnt11> No, we don't
16:45:01 <aleth> (e.g. if the join chat fails?)
16:45:30 <aleth> So whatever is done, it's a separate bug. And it doesn't seem to happen very often as noone has filed it afaik ;)
16:45:52 <aleth> So let's say "edge case" and optimize the look and feel for when it works first.
16:46:02 --> Mook_as has joined #instantbird
16:46:04 <nhnt11> Fair enough! :)
16:47:10 <aleth> I'm more concerned with the UI freezing for a second, if that still happens.
16:49:56 <nhnt11> That doesn't happen on a normal build
16:49:58 <nhnt11> only on debug
16:50:03 <aleth> OK
16:50:04 <nhnt11> And that happens even without any of my changes
16:50:09 <aleth> Debug builds don't count.
16:50:46 <aleth> The fact that it happens without your changes would only have made it harder to fix ;)
16:51:37 <aleth> So I'm glad that's not an issue.
16:53:40 * aleth just had to use join chat. Really can't wait for MUC support to land :D
16:55:46 <aleth> nhnt11: One day when we have profiler support it would be interesting to find out what exactly is costing performance there though.
16:57:00 <nhnt11> Oh yeah, I wanted to reply to one of you and clokep_'s feedback comments. The reason I moved the parsing from RPL_LIST to RPL_LISTEND was because I was seeing if that helped for performance.
16:57:06 <nhnt11> I need to move it back to RPL_LIST.
16:57:41 <aleth> I remembered after I commented that you had said that was going to change to something batched anyway.
16:57:58 <nhnt11> I have no quantitative evidence of this, but it /did/ seem to speed it up a bit
16:58:08 <nhnt11> Yeah I want to do that tonight.
16:59:51 --> gerard-majax has joined #instantbird
17:25:35 <clokep_> nhnt11: "aleth: The only way I can think of is to listen for new-ui-conversation and check if it's the chat we want" Are you really able to do that? How do you know it's the same one?
17:26:12 <nhnt11> clokep_: Check aSubject.isChat and aSubject.name versus the display name of the PossibleChat we're opening, I suppose
17:26:29 <nhnt11> It's not foolproof
17:26:39 <nhnt11> Partly why I don't like it.
17:26:49 <clokep_> nhnt11: That's a hack.
17:26:49 <nhnt11> We would need to check the account as well
17:28:29 <-- nhnt11 has quit (Ping timeout)
17:29:23 --> nhnt11 has joined #instantbird
17:29:53 <nhnt11> 22:57:33 - nhnt11: I can't think of any other way without changing the API as of now.
17:29:53 <nhnt11> 22:57:49 - nhnt11: I'll keep thinking for alternatives..
17:32:44 <-- gerard-majax has quit (Ping timeout)
17:36:33 <nhnt11> Is goDoCommand not OS-independent? 
17:36:55 <nhnt11> Mic: That patch worked perfectly for me.
17:37:21 <nhnt11> Aha, it's probably because of menus.xul being included in the conversation window on Mac.
17:37:25 * nhnt11 facepalms
17:40:33 --> gerard-majax has joined #instantbird
17:42:25 <aleth> clokep_, nhnt11: "The only way I can think of is to listen for new-ui-conversation and check if it's the chat we want" Are you really able to do that? How do you know it's the same one?" I assumed you would add an aData parameter or something?
17:43:11 <nhnt11> aleth: What? You want me to modify the notification itself?
17:43:33 <aleth> It sounds less hackish.
17:44:02 <nhnt11> I don't understand what you want me to add to the notification
17:44:18 <nhnt11> what data *
17:45:13 <aleth> http://lxr.instantbird.org/instantbird/source/chat/components/src/imConversations.js#34 and https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIObserverService#notifyObservers%28%29
17:45:42 * clokep_ doesn't understand what we're trying to solve.
17:45:55 <nhnt11> aleth: I understand where you want me to add it, I don't understand /what/ you want me to add
17:45:57 <aleth> The problem with that is that it can only be a string, so you'd have to think about what that would be as an id
17:46:06 <clokep_> This sounds like a case that we shouldn't worry too much about, and that you should try to get working on the statistics we're going to be tracking...
17:46:37 <aleth> nhnt11: I meant replacing null in the current call with a string identifying the conversation.
17:47:38 <nhnt11> Right, but what string would this be? We already have the imConversation from aSubject, from which we can get the prplConversation, and any other data we need.
17:47:43 <aleth> clokep_: I agree. This could easily be left for a followup
17:48:14 <nhnt11> Ok then. For now I'll just make it call joinChat and close the awesometab.
17:48:29 * clokep_ likes that idea for now. :)
17:48:53 <aleth> nhnt11: You're right, it's not obvious how to do it.
17:49:58 <aleth> Also if you are thinking of looking at the whole API later anyway, it's not worth addressing now.
17:50:01 --> gerard-majax_ has joined #instantbird
17:50:14 <nhnt11> Okay then.
17:50:46 <-- gerard-majax has quit (Ping timeout)
17:52:22 <nhnt11> aleth: Sorry about the Linux theming by the way. I'm hesitant to fix things I can't test.
17:53:11 <nhnt11> I should set up build environments on Windows and a Linux VM..
17:53:23 <aleth> nhnt11: That's OK, don't worry about it for now.
17:53:44 <aleth> Though the + button overflow styling would be nice at some point ;)
18:00:28 <-- gerard-majax_ has quit (No route to host)
18:00:33 --> gerard-majax__ has joined #instantbird
18:01:13 --> mpmc has joined #instantbird
18:02:23 <-- gerard-majax__ has quit (Ping timeout)
18:03:13 --> gerard-majax__ has joined #instantbird
18:06:04 <clokep_> nhnt11: Did the Windows fixes make it into a patch btw?
18:06:49 <nhnt11> clokep_: Not yet. I'll try to have one for you to r+ (hopefully +) soon.
18:14:41 * qheaden_away is now known as qheaden
18:14:47 <qheaden> Hello everyone.
18:15:26 <qheaden> clokep_: I did read your comments on BIO.
18:18:36 <clokep_> qheaden: OK. Did you read the message I sent you this morning. ;)
18:18:48 <qheaden> clokep_: Yeah. :)
18:19:17 <clokep_> Does it make sense? ;)
18:20:00 <qheaden> clokep_: You are speaking about the message on mobile status right?
18:20:33 <clokep_> Yes, sir!
18:20:37 <clokep_> Yeah, don't worry abou tit righ tnow.
18:20:42 <clokep_> I added it to your EtherPAd.
18:20:45 <qheaden> clokep_: Yes, it makes sense.
18:20:49 <qheaden> OK.
18:21:52 <qheaden> clokep_: My guess is that it shouldn't be to hard to implement. I just have to download YMSG on my Android so I can set the mobile status.
18:22:46 <clokep_> :) Cool.
18:23:01 <clokep_> So that changing status method still confuses the hell out of me.
18:23:09 <clokep_> Maybe aleth should look at it and see if I'm just being dumb.
18:23:21 <qheaden> Let me see if I can explain it here in IRC.
18:23:59 <qheaden> Normally, key 10 holds the status of the user, but if the user wants to use a custom status message, key 10 is set to 99, and that lets the server know you are using a custom message.
18:24:11 <qheaden> The custom message is held in key 19.
18:24:40 <clokep_> OK.
18:24:54 <qheaden> And since key 10 is now being used as a flag for "custom message mode", you must use key 47 to let the server know whether your are away or available, because key 10 can no longer do it.
18:25:22 <qheaden> From what I see, key 47 can only be available or away, 0 or 1.
18:25:33 <qheaden> I think it has to do with legacy support.
18:25:51 <qheaden> Kind like how UTF-8 sets the last bit on a character if it is outside of the ASCII range.
18:26:15 <qheaden> clokep_: Does that make a little more sense?
18:28:12 <clokep_> qheaden: Yes, that makes more sense.
18:28:23 <clokep_> I guess what doesn't make any sense in your code is that you're awlays setting key 47.
18:30:10 <qheaden> clokep_: I guess my comment does need to clarify that. It seems that key 47 is always set, but it comes into use when key 10 is set to "99".
18:30:21 * qheaden wishes he could see Yahoo!'s server-side code.
18:30:45 <clokep_> qheaden: I see. So it just isn't really useful in the other case?
18:30:57 <qheaden> clokep_: No.
18:31:24 <qheaden> clokep_: Wireshark shows that the official client sends key 47 all of the time.
18:31:48 <qheaden> Maybe the server always expects that key instead of checking for it.
18:31:57 * qheaden needs to donate his hasKey method to Yahoo.
18:33:31 <clokep_> :)
18:33:32 <clokep_> OK.
18:33:41 <clokep_> That makes more sense. Please make sure the comment matches the implementation.
18:34:08 <qheaden> Okay.
18:35:40 --> Mic has joined #instantbird
18:35:40 * ChanServ sets mode +h Mic 
18:36:19 <clokep_> Mic: AVATAR
18:36:23 <clokep_> :P
18:36:45 <clokep_> qheaden: I think the rest of the comments are pretty easy to do today though.
18:36:55 <qheaden> clokep_: I think so too.
18:37:16 <Mic> Are you doing that to annoy me so I disable my extension? ;)
18:37:42 <clokep_> Mic: Just to make fun. :)
18:38:56 <Mic> Maybe I could use some of atul's XMPP file transfer code (file reading?) and put it into the skeleton of your DCC module?
18:39:48 <Mic> If the AVATAR extension doesn't need to rely on a webhosted image anymore, it would be way more usable :)
18:40:04 <clokep_> True. :)
18:40:16 <clokep_> You don't need any of the FT stuff AVATAR anyway, you just need to start implementing DCC.
18:40:19 <clokep_> Which should be pretty easy.
18:41:24 <Mic> You even pointed me to a DCC module which was only lacking the implementation iirc ;)
18:41:46 <qheaden> clokep_: Are these comments clearer? http://pastebin.instantbird.com/259670
18:42:34 <Mic> Unfortunately I can't find it at the moment - maybe it's in an older changeset in your bitbucket repository.
18:42:42 <clokep_> I think i tis, yes.
18:42:55 <clokep_> I had only done the message parsing, IIRC.
18:43:56 <clokep_> qheaden: Looks fine, yes.
18:46:18 <-- aleth has quit (Quit: Ciao)
18:49:46 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
18:49:49 --> nhnt11 has joined #instantbird
18:50:13 --> Mnyromyr has joined #instantbird
18:53:00 --> unghost has joined #instantbird
19:01:38 <Mic> The antenna of the phone on the mobile icon is on the wrong side :(
19:02:18 <Mic> I'm pretty sure that it would look better if it were on the right hand side...
19:03:07 <clokep_> Isn't it usually on that side though? ;)
19:07:52 <qheaden> clokep_: When I write warnings when a packet handler isn't found, I get a few warnings during login because the Yahoo server sends legacy packets that new clients don't need to support.
19:08:03 <qheaden> Can I write empty stub handlers for those packets to prevent the warnings?
19:08:10 <clokep_> qheaden: Yes. That's what we do for IRC.
19:08:15 <qheaden> Okay.
19:08:21 <clokep_> And just put a comment saying how we don't care about it or something.
19:08:27 <Mic> No idea, I don't know any phones with visible antennas anymore ;)
19:08:46 <qheaden> clokep_: Should I collect all of the stubs at the end of YahooPacketHandler?
19:09:01 <clokep_> qheaden: How are the others organized? Numerically?
19:09:33 <clokep_> Mic: http://en.wikipedia.org/wiki/File:Two_Cell_Phones_2.png agrees with you.
19:09:37 <qheaden> clokep_: Yes. follow that?
19:09:45 <clokep_> (Also maybe we should update that picture so young people know what it refers to? :P)
19:09:48 <clokep_> qheaden: Yes please. :)
19:10:20 <qheaden> Even flip phones have invisible antennas today.
19:15:43 <qheaden> Do we support new mail notifications?
19:16:11 <clokep_> No.
19:16:16 <clokep_> Not yet.
19:16:23 <clokep_> Someone wanted to add it at some point...
19:17:51 <qheaden> Okay. I'll stub the new mail packet handler with a comment about it.
19:18:17 <clokep_> Put a TODO comment in it or something.
19:18:27 <qheaden> Okay.
19:23:22 * qheaden just noticed we don't handle server pings.
19:24:07 <clokep_> That can be a follow up.
19:24:20 <clokep_> See why I wanted you to add the warning? :-D
19:28:04 <qheaden> :)
19:28:13 <qheaden> We can add the ping now. It is only a few lines of code.
19:28:48 <clokep_> If you want. Just tell me you add it so I can review it. ;)
19:28:57 <clokep_> (That's why it's bad to start adding code after reviews btw. :P)
19:29:25 <qheaden> clokep_: You know what, nevermind. I'm looking at libpurple's implementation, and there is more to it than I thought.
19:29:39 <qheaden> You can't send a ping more than once an hour, or you will get booted. 
19:30:19 <clokep_> Once an HOUR? What?
19:30:22 <clokep_> That seems...useless.
19:30:30 <nhnt11> That's weird
19:30:37 <qheaden> Yeah. http://lxr.instantbird.org/instantbird/source/purple/libpurple/protocols/yahoo/libymsg.c#4932
19:31:00 <qheaden> The protocol gets stranger the more you delve into it.
19:32:17 <clokep_> qheaden: Luckily that should be pretty easy w/ our ping timeout code.
19:33:07 <qheaden> clokep_: Okay. I'll just make a note of it in the bug.
19:33:17 <qheaden> I'm focusing on your feedback points right now.
19:39:16 <qheaden> clokep_: Was there any response to your mentioning my plug-in in the meeting notes?
19:39:27 <clokep_> qheaden: I wasn't in the meeting.
19:39:47 <qheaden> Oh, you did say that. I forgot.
19:44:29 <clokep_> Has anyone ever stayed "Unavailable" after you get back from being Idle?
19:44:41 <clokep_> JosiahOne is telling me that's happening to him.
19:45:31 <qheaden> In my plug-in or Ib in general?
19:45:51 <clokep_> Nothing to do with Yahoo.
19:46:17 <qheaden> That's never happened to me. Sounds like its missing input events or something.
19:46:19 <nhnt11> clokep_: If I was available before, it switches back to available when I get back.
19:46:46 <Mic> clokep_: didn't Mook_as have that problem once?
19:47:04 <clokep_> Maybe.
19:47:16 <clokep_> I remember someone complaining abou tit, I can't remember if we "fixed" it or...
19:47:22 <clokep_> (I know the idle service wasn't working at one point)
19:48:11 <qheaden> clokep_: Should I add an XXX comment about name and conference normalization?
19:49:11 <clokep_> qheaden: No.
19:50:11 <qheaden> OK
19:50:47 --> nhnt12 has joined #instantbird
19:51:08 <-- nhnt11 has quit (NickServ (GHOST command used by nhnt12))
19:51:14 * nhnt12 is now known as nhnt11
19:51:27 <qheaden> clokep_: Okay, I just pushed the changes to BitBucket. If you have no further comments, I'll post a patch on BIO.
19:53:42 <clokep_> qheaden: I don't have any comments.
19:53:48 <qheaden> yay! :)
19:55:33 <clokep_> I'll look over it another time tonight before pushing anything.
19:55:41 <clokep_> qheaden: You should probably start filing follow up bugs?
19:56:30 <nhnt11> clokep_, Mic: What do you think is a good amount of channels to return in each batch? I think about a 100 or so is good.
19:56:36 <qheaden> clokep_: I guess. Do you think I should wait until this patch lands though? Either you or Florian might want me to add something to this bug first.
19:56:52 <clokep_> nhnt11: I would have said like 10. ;)
19:56:57 <nhnt11> :o
19:57:04 <nhnt11> It's not that slow.
19:57:25 <clokep_> qheaden: No, we won't be adding any more features to it. Florian is on vacation and won't be reviewing it.
19:57:33 <qheaden> Okay.
19:57:51 <nhnt11> The ~650 channels that moznet returns take about 1 second right now.
19:58:41 <clokep_> How long does Freenode take?
19:58:47 <nhnt11> A very very long time :P
19:58:51 <clokep_> Btw there are some servers which you aren't supposed to call LIST on...
19:59:02 <clokep_> There's a way to tell that from the ISUPPORT parameters, which most servers support.
19:59:04 <nhnt11> On my debug build it froze so bad that I just force closed it
19:59:16 <nhnt11> I see.
19:59:19 <Mic> I've read that some servers disconnect your on LIST...
19:59:23 <Mic> *you
19:59:45 <clokep_> I just said that! :p
20:00:02 * clokep_ wonders if Mic or aleth want to look at qheaden's code or if an r+ from me is enough.
20:00:21 * qheaden starts to sweat again.
20:00:34 <Mic> I'll finish looking at nhnt11's tonight and hopefully it's ready to land then :)
20:00:36 <nhnt11> clokep_: Btw, I kinda like the callback interface, but I'm fine with switching to an observer model/wait for flo's opinion. Your call.
20:00:43 <nhnt11> Mic: :)
20:01:09 <clokep_> nhnt11: I don't particularly care, I just found it confusing that that's the only placed we'd use that. ;)
20:01:13 <Mic> I might look at qheaden's code after that.
20:01:49 <nhnt11> Ok then, I'll keep it :)
20:01:55 <Mic> nhnt11: how long are you around tonight?
20:02:10 <nhnt11> Mic: Probably the whole night, I slept through the day.
20:02:21 <clokep_> nhnt11: FWIW I probably wouldn't land that code w/o Florian looking at it first anyway. :)
20:02:38 <nhnt11> Ok. It won't be too difficult to switch to an observer model anyway.
20:03:11 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2643 on bug 1982.
20:03:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1982 nor, --, ---, qheaden, ASSI, Create Yahoo! Messenger Protocol Plug-In
20:04:54 <clokep_> qheaden: Cool.
20:05:04 <clokep_> So I'd suggest you start looking at the other features that we talked about.
20:05:10 <clokep_> And I can take a look at that at my leisure and land it.
20:05:41 <qheaden> Alright!
20:06:19 <nhnt11> clokep_: Would it be alright to set a timeout at LISTEND to refresh the cached channels?
20:10:23 <Mic> nhnt11: what about storing the time on that you've received them and only refresh when they're requested and it's too long since then already?
20:11:12 <Mic> What timeout did you have in mind?
20:11:34 <nhnt11> I was thinking somewhere around 2-5 minutes
20:11:35 <clokep_> nhnt11: No, use Mic's suggestion.
20:11:41 <nhnt11> Probably more like 5
20:11:42 <nhnt11> yeah
20:12:02 <nhnt11> Mic's suggestion makes a lot more sense when the stats service requests it when it receives an empty filter request
20:12:10 <nhnt11> Er, I mean when getFilteredConvs is called with ""
20:14:50 <clokep_> LIST Is a lot of load on servers, we want to be nice.
20:16:08 <nhnt11> clokep_: So is 5 minutes too fast, or is it fine?
20:16:11 <clokep_> qheaden: So what's the first thing on https://etherpad.mozilla.org/ELTNA6O44F you're going to look at now?
20:16:35 <clokep_> nhnt11: Seems kind of reasonable...I'm not sure how often that information goes stale. :)
20:16:49 <clokep_> nhnt11: You'd also want to be "smart" about it and add information from MUCs that you join if they're not in the list, etc.
20:17:26 <nhnt11> Does LIST return only registered channels?
20:17:47 <Mic> There are hidden channels, yes.
20:18:20 <clokep_> nhnt11: You probably also need to have ERR_TOOMANYMATCHES ERR_NOSUCHSERVER act similar to RPL_LISTEND
20:19:50 <nhnt11> Looks like TOOMANYMATCHES isn't handled currently?
20:20:06 --> rosonline has joined #instantbird
20:22:18 <clokep_> It's possible neither is.
20:22:46 <nhnt11> NOSUCHSERVER has a handler that just returns false.
20:23:02 <clokep_> That means it isn't handled.
20:23:11 <clokep_> The return value is whether it was handled or not.
20:23:43 <nhnt11> Ah, ok, I meant that TOOMANYMATCHES isn't implemented at all then
20:24:42 <clokep_> Hah, it's referred to twice in the RFC, but with no code for it. :) Fun.
20:24:44 <clokep_> Good luck w/ that one.
20:25:03 <-- mpmc has quit (Connection reset by peer)
20:25:27 <clokep_> nhnt11: Mic Should we split the LIST stuff into a separate patch btw? Such that the other stuff can continue going on if aleth and I don't like the implementation?
20:25:32 <clokep_> As long as it's good enough to test w/ for now?
20:25:45 * clokep_ doesn't want to block nhnt11 on IRC's idiotic design.
20:25:48 <nhnt11> I'm fine with it.
20:28:28 <Mic> A separate patch for the IRC changes sound good.
20:28:44 <qheaden> clokep_: I'm very interested in working on buddy info.
20:28:46 <Mic> I might even be able to evade a review then? :P
20:29:00 <nhnt11> Ok then, I'm going to split the patch without futher ado.
20:29:04 <nhnt11> further*
20:30:12 <clokep_> qheaden: I think that's a good next thing to work on!
20:30:16 --> EionRobb has joined #instantbird
20:30:20 * nhnt11 's gsoc project seems to branch out a lot :P
20:30:49 <clokep_> It seems to touch a lot, yes.
20:31:18 <nhnt11> Good fun :)
20:31:37 <clokep_> Just means you get to learn more. ;)
20:32:02 <nhnt11> :)
20:34:20 <qheaden> I'll be back in a bit.
20:34:28 * qheaden is now known as qheaden_away
20:41:28 --> FireFly_TB has joined #instantbird
21:08:50 <-- mconley has quit (Input/output error)
21:36:23 * qheaden_away is now known as qheaden
21:36:25 <qheaden> Back
21:39:34 <-- unghost has quit (Ping timeout)
21:44:41 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
22:07:40 <-- FireFly_TB has quit (Ping timeout)
22:08:31 <Mic> clokep_, nhnt11: what do you think about this: http://pastebin.instantbird.com/259897
22:08:57 <Mic> That would remove the getter and replace it with the string on first use.
22:09:19 <nhnt11> Mic: Nice, thanks! :)
22:09:33 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
22:10:16 --> chrisccoulson has joined #instantbird
22:15:03 --> Mnyromyr has joined #instantbird
22:15:30 <instantbot> benediktp@ymail.com granted review for attachment 2631 on bug 2055.
22:15:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2055 enh, --, ---, nhnt11, ASSI, New conversation tab needs to display open conversations and those on hold.
22:16:16 <nhnt11> Mic: Thanks. I'll get a new patch up in a minute.
22:25:31 --> clokep has joined #instantbird
22:25:31 * ChanServ sets mode +o clokep 
22:27:29 * qheaden is now known as qheaden_away
22:31:20 <clokep> :)
22:32:27 <nhnt11> Mic: Should I r? you again or just set [checkin-needed]?
22:33:00 <Mic> I can r+ it again if you like.
22:33:17 <nhnt11> ok
22:33:17 <Mic> I only expected to be in bed when the new patch would arrive ;)
22:33:39 <instantbot> nhnt11@gmail.com requested review from benediktp@ymail.com  for attachment 2644 on bug 2055.
22:33:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2055 enh, --, ---, nhnt11, ASSI, New conversation tab needs to display open conversations and those on hold.
22:33:54 <clokep> nhnt11, Mic: So that's ready for check-in?
22:33:59 <nhnt11> clokep: Yep
22:34:01 * clokep doesn't want flo to come kill him. ;)
22:34:34 <clokep> Is anything else ready to be checked-in?
22:35:44 * nhnt11 doesn't know
22:36:13 <Mic> https://bugzilla.instantbird.org/buglist.cgi?quicksearch=sw%3Acheckin-needed&list_id=5054
22:41:58 * clokep doesn't know if bug 2044 is actually ready or not. :-/
22:42:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2044 nor, --, ---, nobody, NEW, New tab styling not optimal on Linux
22:43:35 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
22:45:47 <clokep> nhnt11: So what is that patch changing? ;)
22:46:04 <nhnt11> Just the lazy getter that Mi c pastebin'd
22:46:28 <clokep> nhnt11: ...The patch as a whole. ;)
22:46:34 * clokep wants to briefly test it before pushing.
22:46:44 <clokep> Like are there particular things to look for?
22:46:50 <nhnt11> clokep: It shows existing conversations in awesometab
22:46:59 <nhnt11> Including existing tabs and convs on hold
22:47:09 <nhnt11> Both chats and IMs
22:47:17 <clokep> Cool. :)
22:48:19 <nhnt11> clokep: In the process it moves all the data management to a service, which loads the contacts at startup and maintains them.
22:49:14 <-- gerard-majax__ has quit (Ping timeout)
22:49:28 <clokep> nhnt11: Got it, OK. :)
22:50:43 --> wnayes has joined #instantbird
22:52:30 <nhnt11> Thought I'd include that (important) bit while I was summarizing ;)
22:53:04 <clokep> nhnt11: Build failed.
22:53:15 <nhnt11> say whaaat
22:53:18 * nhnt11 checks
22:53:23 <clokep> nhnt11: jar.mn.
22:53:27 <clokep> Did you forget to ad one of those files?
22:53:38 <nhnt11> Er, afaik no.
22:53:44 --> gerard-majax__ has joined #instantbird
22:54:05 <nhnt11> clokep: Builds fine for me
22:54:25 --> nhnt11-testing has joined #instantbird
22:56:15 <-- nhnt11-testing has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
22:58:13 <nhnt11> clokep: What's the error?
22:58:14 <clokep> nhnt11: This line: +	skin/classic/aero/instantbird/actionicon-tab.png
22:58:19 <clokep> I think is causing the issue.
22:58:21 <clokep> That doesn't exist
22:58:44 <nhnt11> Ah let me take a look
22:59:34 <clokep> That's my guess. :-/
22:59:44 <clokep> Is there supposed to be an aero version of that?
23:00:11 <nhnt11> No.
23:00:49 <nhnt11> clokep: Ah I found the problem
23:01:03 <nhnt11> new patch in a minute
23:01:39 <nhnt11> clokep: If you don't want to wait for a new patch, add this after actionicon-tab.png: (actionicon-tab-win.png)
23:01:45 <-- gerard-majax__ has quit (Ping timeout)
23:02:26 <clokep> nhnt11: Is there a pattern to the spacing in that pattern? :P
23:02:39 <clokep> s/that pattern/that file/
23:02:47 <nhnt11> I couldn't find one :P
23:02:51 <nhnt11> It's a bit random-ish
23:03:06 <nhnt11> Except where it's aligned, those parts are fine :)
23:03:46 * clokep just waits for a new patch.
23:04:40 <instantbot> nhnt11@gmail.com cancelled review?(benediktp@ymail.com ) for attachment 2644 on bug 2055.
23:04:41 <instantbot> nhnt11@gmail.com requested review from benediktp@ymail.com  for attachment 2645 on bug 2055.
23:04:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2055 enh, --, ---, nhnt11, ASSI, New conversation tab needs to display open conversations and those on hold.
23:05:24 --> gerard-majax__ has joined #instantbird
23:11:36 <clokep> qheaden_away: ping
23:12:12 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
23:13:01 * qheaden_away is now known as qheaden
23:13:04 <qheaden> clokep: Hey
23:13:51 <clokep> qheaden: So I can't get Yahoo to work when building it.
23:14:03 <clokep> I get "no prpl-yahoo"
23:14:31 <qheaden> clokep: Hmm.
23:14:36 <clokep> qheaden: Oh wait.
23:14:42 <clokep> Looks like my profile is fubared.
23:14:59 <qheaden> Oh.
23:15:45 <clokep> Hmm....let me try a clean one.
23:17:38 <clokep> qheaden: Unable to find yahoo-session.jsm.
23:18:03 <qheaden> :-S
23:18:35 <qheaden> clokep: Is the physical file there?
23:19:03 <clokep> qheaden: Define "there".
23:19:37 <qheaden> clokep: First off, are you applying my uploaded patch to your tree, or a clean tree, or are you using my BitBucket repo?
23:20:06 <clokep> qheaden: I'm applying your patch.
23:20:29 <qheaden> clokep: Does it add yahoo-session.jsm to the source tree?
23:21:08 <clokep> Yes.
23:21:17 <clokep> And it's in the obj-dir too. :-S
23:22:18 <qheaden> clokep: You are getting that as a runtime error right?
23:22:27 <-- EionRobb has quit (Connection reset by peer)
23:22:42 --> EionRobb has joined #instantbird
23:22:48 <clokep> Yes.
23:22:55 * clokep is unsure if his tree is messed up or not...
23:23:45 <qheaden> clokep: Sounds like a clobber is in order. Not sure if you tried that though.
23:24:03 <clokep> qheaden: On Windows? That takes an hour. :P
23:24:06 * clokep goes to make dinner.
23:24:08 <qheaden> :P
23:24:23 <qheaden> Maybe build tier_app?
23:24:29 <clokep> I did that.
23:24:32 <clokep> I'm going to do a clobber.
23:26:58 <qheaden> Okay. I'll be back on in about 2 hours.
23:27:05 * qheaden is now known as qheaden_away
23:58:33 <-- wnayes has quit (Ping timeout)