All times are UTC.
00:35:21 <-- mpmc has quit (Connection reset by peer) 00:48:42 <-- wnayes has quit (Ping timeout) 00:51:55 --> wnayes has joined #instantbird 00:54:32 --> clokep has joined #instantbird 00:54:33 * ChanServ sets mode +o clokep 01:40:52 <-- dew has quit (Connection reset by peer) 01:48:04 <-- clokep has quit (Connection reset by peer) 02:12:24 --> dew has joined #instantbird 02:14:08 <-- dew has quit (Ping timeout) 02:14:26 --> dew has joined #instantbird 02:16:09 <-- dew has quit (Ping timeout) 02:16:28 --> dew has joined #instantbird 02:22:19 <-- skeledrew has quit (Ping timeout) 02:32:38 --> skeledrew has joined #instantbird 02:33:00 <-- wnayes has quit (Quit: wnayes) 02:33:36 <-- skeledrew has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 02:48:21 <-- dew has quit (Ping timeout) 02:48:39 --> dew has joined #instantbird 02:58:01 <-- mconley has quit (Input/output error) 03:04:05 <instant-buildbot> build #910 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/910 03:15:07 --> skeledrew has joined #instantbird 03:27:34 <instant-buildbot> build #902 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/902 03:31:08 <-- dew has quit (Ping timeout) 03:31:12 --> dew has joined #instantbird 05:01:38 <-- atuljangra has quit (Ping timeout) 05:11:53 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 05:36:36 <-- EionRobb has quit (Quit: Leaving.) 05:51:44 <instant-buildbot> build #1006 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1006 05:51:44 <-- instant-buildbot has quit (Quit: buildmaster reconfigured: bot disconnecting) 06:30:30 <-- chrisccoulson has quit (Ping timeout) 06:32:05 --> chrisccoulson has joined #instantbird 07:11:02 <instantbot> New Instantbird (UI) bug 2052 filed by florian@instantbird.org. 07:11:03 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 2596 on bug 2052. 07:11:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2052 enh, --, ---, florian, NEW, Add a way to pref off JS prpls. 07:12:16 --> Mic has joined #instantbird 07:12:16 * ChanServ sets mode +h Mic 07:13:39 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 07:14:48 --> Mic has joined #instantbird 07:14:48 * ChanServ sets mode +h Mic 07:17:00 <Mic> Good morning 07:18:42 --> EionRobb has joined #instantbird 07:22:17 <-- EionRobb has quit (Ping timeout) 07:24:54 --> EionRobb has joined #instantbird 07:36:23 <instantbot> New Instantbird (UI) bug 2053 filed by benediktp@ymail.com. 07:36:24 <instantbot> benediktp@ymail.com requested review from clokep@gmail.com for attachment 2597 on bug 2053. 07:36:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2053 enh, --, ---, benediktp, ASSI, Add data to 'conversation-loaded' notification to let observers know that the conversation was moved 07:40:23 <Mic> aleth, douglaswth: you both had problems with restartless add-ons and conversations moved from one window to another. 07:40:41 <Mic> This patch might help. 07:52:41 --> flo-retina has joined #instantbird 07:52:41 * ChanServ sets mode +qo flo-retina flo-retina 07:55:44 <-- EionRobb has quit (Connection reset by peer) 07:56:06 --> EionRobb has joined #instantbird 08:00:30 --> josefec has joined #instantbird 08:00:46 --> mpmc has joined #instantbird 08:01:11 <-- josefec has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 08:01:39 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 08:01:44 --> mpmc has joined #instantbird 08:06:52 --> jb has joined #instantbird 08:06:58 <-- jb has quit (Input/output error) 08:17:32 <Mic> I wish I knew how to convert that into a tiny, icon sized image without everything getting blurred. 08:17:33 <Mic> http://minus.com/l33z9wak4NVQb 08:17:54 <Mic> I'm using Inkscape by the way, so if anyone has some hints, I'd love to hear them. 08:18:25 <Mic> I wouldn't like to have to create the images pixel by pixel. 08:18:37 <Mic> How do you like the look of that by the way @flo-retina. 08:18:48 <Mic> Is it the kind of icon that Margaret (?) had in mind? 08:24:14 <-- EionRobb has quit (Ping timeout) 08:25:39 <flo-retina> Mic: who's Margaret? 08:25:54 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 08:27:23 <flo-retina> Mic: where do you intend this icon to be displayed? (I think I miss some of the context here :-S) 08:29:56 --> Mic has joined #instantbird 08:29:56 * ChanServ sets mode +h Mic 08:30:21 --> EionRobb has joined #instantbird 08:30:29 <Mic> Yes, the image description is not very discoverable. 08:30:49 <Mic> It says "First attempt at a new "Start conversation"-icon for Instantbird." though ;) 08:31:55 <Mic> I thought you talked to someone from Mozillas UX people about Instantbird (that's why I had Margaret Leibovic's name in mind?) who told you that she didn't like the look of the start conversation bubble on the contact list? 08:32:05 <Mic> Maybe I'm completely misremembering that. 08:33:11 <Mic> Instantbird completely refused to show new messages in the conversation before the latest restart :S 08:33:49 <Mic> I had to put the conversation on hold and restore it to see them. I wonder what this problem is... 08:42:00 --> aleth has joined #instantbird 08:42:01 * ChanServ sets mode +h aleth 08:42:20 <Mic> Ah, no. It was Boriss apparently. 08:42:33 <Mic> http://log.bezut.info/instantbird/130620/#m1031 08:45:30 <-- flo-retina has quit (Ping timeout) 08:54:53 <-- mpmc has quit (Connection reset by peer) 09:12:06 <Mic> Here's an example (unpolished) how it would look: http://minus.com/lglI6Y8Fwz0vP 09:13:05 <Mic> The colors are that of the Firefox toolbar icons, the shape is like the bubble that currently is there (a bit taller though, iirc). 09:14:18 <aleth> Isn't that just a very dark version of what we have at the moment? I think I prefer the lighter one :-S 09:20:28 <Mic> -just 09:21:12 <aleth> Are the FX toolbar icons really blue-grey on Windows? 09:22:40 <aleth> Actually I'm not sure there's any blue in your grey, might just be me 09:23:41 <Mic> http://minus.com/l4ktKxZrPU7iv 09:23:56 <Mic> It's a little bit blueish I'd say 09:24:09 <aleth> They are much closer to black on Linux. 09:24:44 <aleth> FWIW Inkscape has a useful Icon Preview sidebar 09:24:52 <aleth> (re your question earlier) 09:26:08 <Mic> I didn't know that, thanks :) 09:26:27 <aleth> Also it helps to align everything with a grid 09:26:34 <aleth> (in the SVG) 09:37:44 <-- EionRobb has quit (Ping timeout) 09:42:17 --> EionRobb has joined #instantbird 09:54:38 --> jb has joined #instantbird 10:03:49 <-- Optimizer has quit (Ping timeout) 10:04:10 --> Tonnes has joined #instantbird 10:04:28 --> Optimizer has joined #instantbird 10:17:54 --> clokep has joined #instantbird 10:17:54 * ChanServ sets mode +o clokep 10:21:43 <clokep> aleth: You're probably in a better position to review bug 2053. 10:21:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2053 enh, --, ---, benediktp, ASSI, Add data to 'conversation-loaded' notification to let observers know that the conversation was moved 10:22:02 <aleth> clokep: I was going to steal the review and then commented instead ;) 10:22:30 <clokep> Please steal it. :) 10:23:54 <Mic> I wanted to ask aleth anyways because you're going to be away starting tomorrow, don't you? 10:24:15 <Mic> It has to be a string by the way. 10:24:25 <clokep> My travel plans changed, I'll be here. 10:24:43 <Mic> https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIObserverService#notifyObservers%28%29 10:25:06 <aleth> Mic: thanks! 10:25:13 <Mic> OK. 10:25:30 <Mic> I need to go. 10:25:33 <aleth> I'm kind of surprised it's got to be a string... 10:25:45 <Mic> It's going to be late today in case that nhnt11 is looking for me. 10:26:37 <instantbot> aleth@instantbird.org granted review for attachment 2597 on bug 2053. 10:26:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2053 enh, --, ---, benediktp, ASSI, Add data to 'conversation-loaded' notification to let observers know that the conversation was moved 10:29:06 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 10:40:08 <instantbot> clokep@gmail.com granted review for attachment 2596 on bug 2052. 10:40:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2052 enh, --, ---, florian, NEW, Add a way to pref off JS prpls. 10:41:39 <instantbot> clokep@gmail.com set the Resolution field on bug 2016 to DUPLICATE of bug 2052. 10:41:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2016 enh, --, ---, nobody, RESO DUPLICATE, Allow switching between a JS and libpurple prpl via a pref 10:42:21 <aleth> :) 10:44:14 <-- jb has quit (Quit: jb) 10:46:00 --> jb has joined #instantbird 10:47:42 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 10:58:44 <-- EionRobb has quit (Quit: Leaving.) 10:59:24 --> novabyte has joined #instantbird 11:17:35 <-- jb has quit (Ping timeout) 11:45:03 --> jb has joined #instantbird 11:45:28 <-- Optimizer has quit (Ping timeout) 11:46:05 --> flo-retina has joined #instantbird 11:46:05 * ChanServ sets mode +qo flo-retina flo-retina 11:46:31 --> Optimizer has joined #instantbird 11:46:45 <flo-retina> clokep: sorry for not remembering you had bug 2016 on file :-/. 11:46:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2016 enh, --, ---, nobody, RESO DUPLICATE, Allow switching between a JS and libpurple prpl via a pref 11:47:27 <-- Optimizer has quit (Connection reset by peer) 11:48:12 <flo-retina> Mic: I think Margaret works in the Firefox (front-end) team, not UX. 11:51:40 <flo-retina> Mic: IIRC the main comment Boriss had about this button was that if it's a button it should be visible when hovering it (so we would need to have an icon with more relief or something when the button is hovered) 11:52:40 <aleth> i.e. "make it look more like a button"? 11:53:10 --> Optimizer has joined #instantbird 11:53:46 <aleth> (ah, I guess that's what you mean with " if it's a button it should be visible when hovering it" as it's already (only) visible on hover) 11:54:53 <-- Optimizer has quit (Ping timeout) 11:55:39 <flo-retina> aleth: the button is visible on hovering the contact, but the button's icon should change when hovering the icon itself 11:56:14 <aleth> That sounds like a good idea. 11:57:30 --> clokep has joined #instantbird 12:05:21 --> atuljangra has joined #instantbird 12:08:52 <clokep> atuljangra: Please do not email any of us privately, please email the entire team so whoever is around can respond quickly. 12:09:06 <clokep> (I.e. I was commuting to work while emailing you, but aleth and Florian were here.) 12:09:42 <atuljangra> clokep: Sure :-) 12:11:34 <clokep> atuljangra: Please read my email and let us know if it is clear. 12:11:52 <clokep> flo-retina: Don't worry about the dup, not a big deal. :) 12:12:26 <atuljangra> Yes, it is clear. I read it. So I should include in it instantbird/. It seems you are flo-retina want this to be in instantbird/ 12:13:51 --> Optimizer has joined #instantbird 12:14:11 <flo-retina> atuljangra: the files shared with Thunderbird should go in chat/. The UI you add to make use of FileLink in Instantbird should be in instantbird/. 12:14:38 <atuljangra> flo-retina: Fair enough :) 12:17:06 <aleth> Does that mean we'll have a Preferences panel in /chat? (I've never looked at how FileLink is configured in TB, but I assume that's how it's done?) 12:17:39 <flo-retina> atuljangra: no. That part of the code will very likely be forked. (It's UI, isn't it?;)) 12:18:15 <aleth> It's UI, but atuljangra should still grab the code from TB ;) 12:18:49 <atuljangra> flo-retina: Was that an instance of tab completion failure? ;) 12:19:35 <aleth> I think so. You pinged him last, so... 12:19:50 <qheaden> Hello everyone. 12:20:07 <-- jb has quit (Quit: jb) 12:21:48 --> jb has joined #instantbird 12:22:12 <qheaden> clokep: Looks like some progress was made with preffing off prpls. :) 12:22:58 <clokep> qheaden: Yes, Florian wrote a patch this morning. 12:23:08 <qheaden> Awesome. 12:23:29 <qheaden> clokep: Any idea when it will be checked into the tree? 12:24:03 <clokep> qheaden: How would I know that? ;) 12:24:06 <clokep> Hopefully tonight. 12:24:11 <qheaden> :P 12:24:15 <qheaden> That would be good. 12:24:54 <qheaden> clokep: BTW, I didn't get a chance to look at encoding like I planned this weekend. I want to get that all sorted today. 12:25:20 <clokep> qheaden: OK. flo-retina might have some ideas about what's "ToUnicode" vs "FromUnicode" :) 12:25:30 <qheaden> clokep: Okay. 12:29:40 <clokep> qheaden: Is that the last thing to get Yahoo! JAPAN working? 12:30:05 <qheaden> clokep: Yeah. It works, but the Japanese characters get garbled. 12:30:18 <qheaden> Latin characters are fine though. 12:30:45 <qheaden> Other than that, everything works for YJP. 12:31:37 <aleth> qheaden: Where is the corresponding code in your bitbucket? 12:32:04 <-- jb has quit (Ping timeout) 12:32:20 <qheaden> aleth: You mean the code for Yahoo! JAPAN support? 12:32:23 --> jb has joined #instantbird 12:32:41 <aleth> qheaden: Yes, or where you do the encoding/decoding 12:32:57 <aleth> I guess that's not JAPAN specific 12:33:05 <qheaden> aleth: I haven't pushed any encoding/decoding stuff to BitBucket yet. 12:33:10 <qheaden> I'm still experimenting. 12:33:19 <aleth> Ah OK, that's why I didn't find it then ;) 12:34:07 <clokep> Well let us know if you have questions. 12:34:12 <atuljangra> I'll be back in an hour. Going to get some lunch. 12:34:33 <aleth> qheaden: You've seen https://developer.mozilla.org/en-US/docs/Web/JavaScript/Base64_encoding_and_decoding#The_.22Unicode_Problem.22 ? 12:34:59 <qheaden> aleth: No I haven't. Thanks. :) 12:34:59 <aleth> (not sure if it's relevant to how you are doing things of course) 12:35:52 <-- atuljangra has quit (Ping timeout) 12:36:01 <clokep> That's entirely unrelated, I think. :-/ 12:36:05 <qheaden> I gather from this that the strings are UTF-16 by default? 12:40:22 <clokep> qheaden: Yes. 12:41:37 <aleth> clokep: I mentioned it because we ran into the btoa issue with IRC once afaik 12:41:52 * clokep stumbles upon https://developer.mozilla.org/en-US/docs/Code_snippets/StringView 12:42:02 <clokep> aleth: IRC does nothing with btoa IIRC. 12:42:17 <aleth> clokep: http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/ircSASL.jsm#36 12:43:16 <aleth> admittedly nothing to do with message encoding etc 12:43:23 <clokep> That has nothing to do with encoding, yes. 12:43:31 <-- flo-retina has quit (Ping timeout) 12:43:31 <-- jb has quit (Ping timeout) 12:43:50 <aleth> I didn't remember until I checked in what context it had come up. 12:44:11 <clokep> That StringView thing could actually be pretty useful, qheaden might want to look at it. 12:44:22 <qheaden> clokep: Yeah, I was taking a look at it. 12:47:32 <clokep> If it is useful, we can probably include it wholesale. 12:47:37 <clokep> I'd need to look more closely though. 13:09:46 <qheaden> In libpurple code, strings aren't encoding when using a Yahoo Japan account. http://lxr.instantbird.org/instantbird/source/purple/libpurple/protocols/yahoo/util.c#136 13:09:53 * qheaden wonders what the default encoding is. 13:15:51 --> jb has joined #instantbird 13:18:02 <-- jb has quit (Quit: jb) 13:20:58 --> flo-retina has joined #instantbird 13:20:58 * ChanServ sets mode +qo flo-retina flo-retina 13:30:33 <qheaden> I finally have some working code, and a theory on why it works. But I will have to return in a bit. 13:30:39 * qheaden goes to eat breakfast. 13:30:44 --> mconley has joined #instantbird 13:31:47 --> mpmc has joined #instantbird 13:36:19 <clokep> I'd like to see the code once you have it. :) 13:36:40 <clokep> After you finish your cheerios or whatever. :P 13:38:26 --> jb has joined #instantbird 13:43:20 <-- flo-retina has quit (Ping timeout) 14:03:52 --> flo-retina has joined #instantbird 14:03:52 * ChanServ sets mode +qo flo-retina flo-retina 14:17:35 <qheaden> clokep: Here is the patch http://pastebin.instantbird.com/246664 14:19:08 <qheaden> Here is my theory on why it works. Pidgin is in C++, and is using UTF-8 messages (to be compatible with C++ ASCII). The Ib prpl is in JS, thus it is using UTF-16 encoding. Although the local charset is set to UTF-8 for both, when sending a message, the prpl has to use ConvertFromUnicode() to convert from UTF-16 to UTF-8 so that C++ Pidgin can read it. 14:19:09 <instantbot> c++ is evil 14:20:03 <qheaden> With this code I was able to successfully send and receive messages with Japanese characters. 14:23:03 <flo-retina> qheaden: I think your explanation would be clearer if it didn't mention Pidgin ;) 14:23:15 <flo-retina> and Pidgin is in C, not C++. 14:23:41 <qheaden> flo-retina: That's right, C not C++. :P 14:24:01 <aleth> qheaden: Are you saying the yahoo protocol uses UTF-8? 14:24:08 <qheaden> aleth: Yes it does. 14:24:51 <aleth> Like flo said, I guess that's all the explanation you need :) 14:26:00 <qheaden> My problem was that I didn't realize JS uses UTF-16. 14:26:16 <qheaden> On top of that, I have little encoding experience. ;) 14:26:42 <flo-retina> it seems now you have ;) 14:26:45 <aleth> Encoding is not a fun experience ;) 14:28:10 * qheaden updates his resume. 14:28:28 <flo-retina> :) 14:28:40 <aleth> You might want to add some explanatory comments to the code in the pastebin (it seems convertTo/FromUnicode (not shown) actually convert between different UTFs then?) 14:29:28 <qheaden> aleth: You specify the local charset using the charset property on it. It converts between UTF-16 and that charset. 14:29:45 <qheaden> I happen to have the charset as UTF-8. So it can covnert between UTFs. 14:30:58 <aleth> Right, what I mean is it might be worth saying that that's what's happening in a comment. 14:31:47 <qheaden> clokep: So you know, that patch also works for any encoding you specify in the encoding option of the prpl. 14:34:26 <aleth> Oh, so you can't say that in a comment because it's actually configurable? :P I didn't realize 14:37:04 <qheaden> aleth: :) 14:37:25 <qheaden> aleth: I still should explain what is going on with the UTF-16 though. 14:44:03 <flo-retina> qheaden: is this inspired from our IRC code, or did you just rediscover most of it yourself? 14:44:47 <qheaden> flo-retina: Pretty much discovered it myself. But I did find out about the unicode converter from the IRC code. 14:45:53 <-- aleth has quit (Quit: Ciao) 14:45:57 --> aleth has joined #instantbird 14:45:57 * ChanServ sets mode +h aleth 14:47:42 <flo-retina> I don't see any ConvertFromUnicode call in the irc code, which is surprising :-S 14:48:10 <flo-retina> I wonder if our current irc code is broken for UTF8 characters that take more than 2 bytes :-S 14:48:15 <qheaden> Let me test this. 14:48:33 <qheaden> ããã«ã¡ã¯ä¸ç 14:48:51 <qheaden> That's hello world in Japanese. Does it look fine? 14:48:58 <flo-retina> it looks fine in Instantbird 14:49:10 * qheaden wonders how it looks in other chat clients. 14:49:21 <flo-retina> but Instantbird to Instantbird isn't a good check, because if we can't decode as UTF8 we fallback to not using the converter ;) 14:49:32 <flo-retina> instantbot didn't like it: http://log.bezut.info/instantbird/130715#m262 14:49:35 <instantbot> flo-retina: Sorry, I've no idea what 'didn't like it: http://log.bezut.info/instantbird/130715#m262' might be. 14:49:38 <flo-retina> but I suspect it has issues with UTF8 14:49:42 <qheaden> Yeah. 14:50:34 <qheaden> I'm going to have to leave in a few minutes. I should be back this afternoon. 14:52:24 <qheaden> *will be back 14:56:09 * qheaden is now known as qheaden_away 15:02:02 <-- jb has quit (Ping timeout) 15:05:58 --> jb has joined #instantbird 15:10:36 <-- jb has quit (Ping timeout) 15:14:38 <-- aleth has quit (Quit: Ciao) 15:31:18 <clokep> qheaden_away: flo-retina The Japanese looked OK on mibbit. 15:31:33 <clokep> What does the IRC code use instead of convertfromunicode? 15:31:42 <flo-retina> clokep: nothing :-S 15:32:10 <flo-retina> how many bytes do these Japaneese characters take? 15:32:15 <clokep> Umm...really? 15:33:43 <clokep> http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#660 and http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#1371 which uses http://lxr.instantbird.org/instantbird/source/chat/modules/socket.jsm#244 15:38:43 <flo-retina> hmm 15:38:49 <flo-retina> what confused me was that http://lxr.instantbird.org/instantbird/search?string=convertfromunicode returns no result 15:45:48 <clokep> Right. :-/ 15:46:05 <clokep> I guess because we do it as part of the socket stuf. 15:47:07 --> jb has joined #instantbird 15:47:11 <clokep> qheaden_away: Couple of comments, when you read the "local_charset" pref, you're going to want to || that with "UTF-8" in case someone clears out the pref entirely. 15:48:00 <flo-retina> clokep: yeah, we somehow use a stream instead 15:48:00 <clokep> Also we might want to throw an error if we can't properly encode the message in that catch statement? 15:48:30 <clokep> flo-retina: Is that OK or would you rather we move this code up into jsProtoHelper somehow and have all the protos share it? 15:48:42 <flo-retina> "that" = ? 15:51:15 <clokep> flo-retina: "that" = "what we're doing now" 15:51:49 <flo-retina> the stream thing? It's likely even better 15:52:39 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 15:52:50 <clokep> OK :) 15:56:56 <clokep> qheaden_away: I added those same comments BitBucket. 16:26:34 * mconley is now known as mconley|lunch 16:39:29 <clokep> qheaden_away: Ping me when you're back 16:42:15 --> FireFly_TB has joined #instantbird 16:49:48 <-- dew has quit (Ping timeout) 16:51:06 <-- jb has quit (Ping timeout) 16:59:18 --> mpmc has joined #instantbird 17:02:16 <mpmc> Lol, How long has the + button on the conversation windows been around? I've only just noticed it and it's pretty useful! 17:02:56 <clokep> mpmc: About 4 days. 17:03:07 <mpmc> I like it! 17:03:08 <-- novabyte has quit (Input/output error) 17:03:08 <clokep> One of our GSoC student is working on it. 17:03:15 <clokep> Great! :) 17:03:19 <clokep> Please file bugs if you see any. ;) 17:03:30 <mpmc> will do. 17:03:37 --> jb has joined #instantbird 17:04:04 <clokep> He's not here right now, but nhnt11 is the one working on it. 17:06:04 <flo-retina> well, the button has actually been around since ~august 2009, but it didn't do anything and was hidden ;). 17:06:17 <mpmc> Haha :) 17:07:00 <flo-retina> our nhnt11 is working on turning it into something useful, or even compelling! :) 17:07:45 --> Mook_as has joined #instantbird 17:09:46 <mpmc> Also whats with the facebook bug, I send a message to one of my friends and I get a message underneath it <Name of someone else> is now offline, when they go offline. 17:10:59 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 17:11:15 <clokep> Why is that a bug? 17:11:18 <clokep> :-S 17:11:26 <clokep> It's telling you they're offline? 17:13:31 <mpmc> See what I mean? http://derp.co.uk/9feb4 17:14:53 <clokep> My guess is that it's because Facebook sucks, you send a message, it decides to tell you they're offline, then they come right back online because they are actually online. ;) 17:14:57 <clokep> Do they get the message? 17:15:37 <mpmc> Yes, but it's a different person's name who is actually still online :p 17:16:27 <clokep> I've never seen this. 17:16:47 <-- jb has quit (Ping timeout) 17:16:56 <clokep> Are there errors in the console? 17:17:03 <clokep> Otherwise we'd probably need to see the XML. 17:17:52 <mpmc> Timestamp: 15/07/2013 18:02:47 Error: DEPRECATION WARNING: Search service falling back to deprecated synchronous initializer. 17:18:55 <clokep> That doesn't sound scary. :) 17:19:02 --> jb has joined #instantbird 17:19:47 <mpmc> Theres a load more. 17:21:47 <clokep> Do any deal with your Facebook account? 17:23:43 <mpmc> Not that I can see no :p 17:28:04 <mpmc> I've been getting it for some time, I have quite a few errors, I can go through them all if needed but nothing is flying out at me. 17:29:05 <clokep> Florian might know more about this than me. 17:29:09 <clokep> He seems to have stepped out. 17:29:15 <mpmc> The only other thing I can see is this.. Timestamp: 15/07/2013 17:59:34 Error: Notification: (null) (Unable to add user) Source File: http://hg.instantbird.org/instantbird/raw-file/976c27b24268/purple/libpurple/notify.c Line: 99 Source Code: 17:29:15 <mpmc> notify: purple_notify_message 17:29:40 <clokep> Facebook doesn't use libpurple. 17:29:49 <mpmc> I know :p 17:30:06 <clokep> Then why'd you post that error? 17:30:41 <mpmc> Because it's the only one that was worth posting and you never know :p 17:30:51 <clokep> It'd be something in xmpp(-*).js(m) 17:31:50 <mpmc> All the rest are Mutation events and bad selection errors. 17:42:56 <-- jb has quit (Ping timeout) 17:45:15 <clokep> :-( 17:45:54 <mpmc> I guess those are bad? :p 17:55:03 <clokep> Mutation events one doesn't matter (yet). 17:55:09 <clokep> I have no idea what "bad selection errors" means. 17:55:13 <clokep> Aren't they warnings anyway, not errors? 17:55:16 <clokep> Warning != error. 17:56:48 <mpmc> Yes you are correct :p 17:57:23 <mpmc> Timestamp: 15/07/2013 18:01:13 Warning: Selector expected. Ruleset ignored due to bad selector. Source File: chrome://instantbird/skin/newtab.css Line: 65 Source Code: %else :) 17:59:28 <clokep> Ah, that sounds like something you should file a bug on. :) 17:59:42 <clokep> Sounds like nhnt11 has a bug in a CSS file. 18:00:16 <Mook_as> somebody forgot to preprocess a file? 18:00:34 <clokep> Yes, that looks possible too. 18:00:38 <clokep> mpmc: Are you on Windows? 18:00:49 <mpmc> clokep: Indeed I am Sir. 18:00:56 <Mook_as> (the preprocessor uses % in css files because # is used for id selectors) 18:02:41 <mpmc> clokep: Am I the only one in here on Windows or something? :p 18:02:48 <instantbot> clokep@gmail.com cleared the Resolution 'FIXED' from bug 2043. 18:02:51 <clokep> mpmc: I just reopened bug 2043 18:02:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2043 nor, --, 1.5, nhnt11, REOP, Icon sizes are totally wrong on Windows Aero in awesometab 18:02:55 <clokep> mpmc: No, I use Windows. 18:03:06 <clokep> I don't look at my error console all the time though, I have a ton of errors usually. 18:03:17 * clokep 's profile is a mess. 18:19:26 <-- Optimizer has quit (Ping timeout) 18:28:36 --> atuljangra has joined #instantbird 18:30:25 --> Optimizer has joined #instantbird 18:37:25 * mconley|lunch is now known as mconley 18:38:08 --> nhnt11 has joined #instantbird 18:38:18 <nhnt11> hi! 18:38:20 * nhnt11 is home 18:38:41 <atuljangra> hey :-) 18:39:15 --> Mnyromyr has joined #instantbird 18:39:35 <nhnt11> preprocessing :( 18:40:01 <clokep> nhnt11: Let's get that fixed tonight? :) 18:41:42 <nhnt11> clokep: That's the plan :) 18:41:53 * nhnt11 is eating 18:43:27 <clokep> Who said you could eat?! 18:43:59 <nhnt11> :P 18:53:13 <clokep> nhnt11: Are you going w/ knowing where you're heading? Do you have a TODO list or anything around? 18:53:27 <clokep> atuljangra: How're you getting along? Any progress? 18:54:03 <nhnt11> clokep: Er, no. Not up to date. I'll write a todo list for the week soon. 18:54:11 * clokep thinks it would be pretty neat if we had the updated about window. :( 18:54:43 <atuljangra> Fine Thanks. Experimenting with cloudfile for sometime now. I need to know something about cloudfile before starting to implement something. 18:55:13 <nhnt11> I plan to get all the work done for making accounts return lists of chat rooms, and possibly have IRC channels in the awesometab by the end of the week (not sure if this will work out to be too much or too little work yet, though) 18:55:24 <clokep> atuljangra: Yeah, you were able to build it OK in Instantbird? And you're able to see the interfaces and such? 18:55:44 <clokep> nhnt11: I think someone suggested possibly just starting with open MUCs/MUCs on hold btw? 18:55:48 <clokep> Not sure if you had seen that suggestion. 18:55:55 <clokep> (Or if it was in a private chat I had w/ someone.) 18:56:13 <atuljangra> Yes I build it. I've not tried seeing the interface. I'm planning to do all such thing tonight. 18:56:27 <nhnt11> clokep: That sounds good. MUCs on hold should be pretty easy I think. 19:01:36 <clokep> atuljangra: What do you mean by "Experimenting with cloudfile for sometime now" then? :-S 19:03:44 <atuljangra> I mean, reading the code and then seeing how is ui called from backend. I'll do all those things tonight only. Just need sometime before that. :) 19:05:10 <clokep> Oh OK. :) 19:08:58 <mpmc> Ahh nothing like a hot lolly on a cold day.. 19:09:13 <mpmc> Er, switch hot/cold around :p 19:13:33 --> unghost has joined #instantbird 19:13:45 * nhnt11 is tired 19:14:02 <nhnt11> I'll get in those patches and then bed.. should be up bright and early tomorrow :) 19:15:52 <clokep> nhnt11: Can you do a status update post too? 19:15:58 <clokep> That describes what's to be done this week, etc. 19:15:58 <nhnt11> Ah yes. 19:16:01 <nhnt11> Will do. 19:16:08 * clokep feels like we haven't caught up with you in a few days. 19:16:33 <nhnt11> Yeah, I've not had internet access. It was... frustrating 19:16:45 <nhnt11> I think it's been 2 days, btw. 19:17:02 <clokep> http://xkcd.com/1070/ 19:17:26 <nhnt11> :D 19:19:00 <-- Optimizer has quit (Ping timeout) 19:36:56 <instantbot> nhnt11@gmail.com requested review from florian@instantbird .org for attachment 2599 on bug 2047. 19:36:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2047 min, --, ---, nhnt11, ASSI, Escape key should close awesometab 19:37:58 <instantbot> nhnt11@gmail.com requested review from clokep@gmail.com for attachment 2600 on bug 2043. 19:38:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2043 nor, --, 1.5, nhnt11, REOP, Icon sizes are totally wrong on Windows Aero in awesometab 19:39:20 <instantbot> nhnt11@gmail.com cancelled review?(florian@instantbird .org) for attachment 2583 on bug 2041. 19:39:21 <instantbot> nhnt11@gmail.com requested review from florian@instantbird .org for attachment 2601 on bug 2041. 19:39:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2041 nor, --, ---, nhnt11, ASSI, "Enter" always opens conversation with first contact in the filtered list 19:40:01 <instantbot> clokep@gmail.com granted review for attachment 2600 on bug 2043. 19:40:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2043 nor, --, 1.5, nhnt11, REOP, Icon sizes are totally wrong on Windows Aero in awesometab 19:40:18 --> Optimizer has joined #instantbird 19:41:01 <nhnt11> I'll setup the Instantbird dev environment on my Windows VM tomorrow so that I can test this stuff 19:41:13 <nhnt11> And possibly an ubuntu VM.. 19:41:26 <clokep> OK. :) 19:41:34 <clokep> Do that in the background while doing other things? :P 19:41:43 <nhnt11> Yes :D 19:44:39 * qheaden_away is now known as qheaden 19:44:43 <qheaden> clokep: I'm back now. 19:46:07 <clokep> qheaden: OK. 19:46:12 <clokep> I have no idea what I was going to ask you. :) 19:46:20 <qheaden> :P 19:46:35 <qheaden> clokep: I saw your messages to me in the log. 19:47:14 <clokep> qheaden: I think I was just going to ask what's left before doing a formal review before landing? 19:48:14 <-- atuljangra has quit (Ping timeout) 19:48:56 <qheaden> clokep: Feature-wise, I think we are clear for a landing. I probably want to do a little more user testing before landing it though. Maybe just a few minutes of messing with it in every way. 19:50:07 <nhnt11> Okay, I just did a blog post 19:51:02 <nhnt11> I must sleep now. See you all tomorrow morning. Btw, I may have an errand to run around lunchtime. 19:51:05 <nhnt11> Bye 19:51:08 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 19:52:53 --> atuljangra has joined #instantbird 19:54:54 <clokep> qheaden: Sounds like a plan. 19:54:59 <clokep> When you're ready put a patch in the bug and r? me. 19:55:41 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 19:56:27 <qheaden> clokep: Just testing conference chatting on Yahoo! JAPAN, with Japanese characters, and it works well. 19:56:59 <qheaden> clokep: Oh, and before I land, I also have to implement some of the feedback you have given me on previous patches. 19:57:14 <qheaden> So I should be ready to post a patch in a day or two. 20:05:01 --> flo-retina has joined #instantbird 20:05:02 * ChanServ sets mode +qo flo-retina flo-retina 20:06:56 <clokep> qheaden: Oh, OK. 20:07:20 <clokep> Well I think our focus at the moment should be getting that ready (kind of do a feature freeze and try to land the working bits). 20:08:24 <-- FireFly_TB has quit (Ping timeout) 20:10:08 <flo-retina> http://log.bezut.info/instantbird/130715#m394 I think that someone was me. 20:12:13 <clokep> qheaden: Ah! I remember what I was going to tell you now. :) 20:12:23 <qheaden> :) 20:12:25 <clokep> You need to add more logging, most likely, on cases where there should be warnings or errors thrown. 20:12:34 <clokep> But I don't know that for sure until I do a full review. 20:13:10 <qheaden> clokep: Sounds good. 20:14:00 <qheaden> clokep: About the duplicated code in sendMsg, did you want me to place the encoding stuff into a function on YahooAccount? 20:14:40 <flo-retina> the wifi at the hotel isn't great :( 20:15:04 <clokep> qheaden: I want it to not be duplicated. ;) 20:15:15 <clokep> How you do that is up to you. 20:15:16 <qheaden> :) 20:15:31 <clokep> (Well until you choose a way I don't like. :-D) 20:16:15 <clokep> I also added URI Handler to the etherpad btw. 20:18:30 <qheaden> clokep: How's this look? http://pastebin.instantbird.com/246953 20:20:20 <clokep> qheaden: Include the string too. 20:20:25 <clokep> (In the error message.) 20:21:40 <qheaden> clokep: Okay. 20:21:59 <clokep> Besides that, it looks reasonable, yes. 20:22:22 <instantbot> florian@instantbird.org granted review for attachment 2599 on bug 2047. 20:22:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2047 min, --, ---, nhnt11, ASSI, Escape key should close awesometab 20:24:33 * flo-retina just r+'ed without comments tonight 20:24:42 <flo-retina> I wonder if that means I'm exhausted and don't see anything 20:24:44 <instantbot> florian@instantbird.org granted review for attachment 2601 on bug 2041. 20:24:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2041 nor, --, ---, nhnt11, ASSI, "Enter" always opens conversation with first contact in the filtered list 20:24:55 <flo-retina> if it's the case, sounds like a great time to make me review poor patches :-D 20:25:23 --> rosonline has joined #instantbird 20:25:58 <clokep> bug 1587? :P 20:26:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1587 min, --, 1.5, clokep, REOP, Re-sync build scripts with comm-central 20:26:19 * clokep is pretty sure those just need rs on them anyway. 20:27:13 <clokep> We probably want those on a day when that's the only thing pushed though. 20:27:38 <flo-retina> hmm, possibly yes 20:27:48 <flo-retina> and maybe on a day when I'm super bored ;) 20:28:26 <flo-retina> right now I'm just trying to get stuff that's either trivial, or unblocking our students out of the way 20:30:13 * flo-retina wonders if bug 2053 is really checkin-needed or if Mic/aleth want to do something more based on the comments I left 20:30:16 <clokep> In that case, the binary socket one would be nice (if you didn't grab it already). 20:30:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2053 enh, --, ---, benediktp, ASSI, Add data to 'conversation-loaded' notification to let observers know that the conversation was moved 20:30:28 <flo-retina> clokep: it's the next one I'm going to look at 20:30:49 <flo-retina> although if you may run away soon, I'd be happy to do the JS-XMPP preff'ing off stuff first 20:30:57 <flo-retina> I just need another trivial patch in there 20:31:21 * clokep wonders how well you know my schedule. ;) 20:31:30 <clokep> I'm working a bit late so I'll be here for at least another 0.5 hours. 20:32:03 <flo-retina> clokep: I wasn't sure as there's no _ in your nick ;) 20:32:12 <flo-retina> so I almost assumed you were at home 20:32:18 <-- atuljangra has quit (Ping timeout) 20:33:39 * clokep is now known as c_l_o_k_e_p_ 20:33:43 <c_l_o_k_e_p_> ;) 20:33:47 <c_l_o_k_e_p_> I just wanted to auth today. 20:34:34 <flo-retina> :) 20:35:11 * qheaden likes the style of c_l_o_k_e_p_ :) 20:36:36 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 2602 on bug 1589. 20:36:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1589 enh, --, ---, nobody, NEW, Replace libpurple XMPP with JS-XMPP 20:36:46 <qheaden> c_l_o_k_e_p_: Be prepared for lots of small patches. :) 20:36:48 <flo-retina> this patch touches one line of each of instantbird, chat, purple. That's not common :-D 20:37:57 * flo-retina wonders how many seconds it's gonna take clokep to review that trivial patch 20:40:31 <-- flo-retina has quit (Input/output error) 20:42:18 --> flo-retina has joined #instantbird 20:42:18 * ChanServ sets mode +qo flo-retina flo-retina 20:43:50 <flo-retina> c_l_o_k_e_p_: I have only one nit on the binary socket stuff, the "function copyBytes([...]" line should be wrapped. 20:44:00 <flo-retina> I can do it locally before the checkin if you want 20:48:42 <-- Optimizer has quit (Ping timeout) 20:48:49 --> Optimizer has joined #instantbird 20:48:50 --> EionRobb has joined #instantbird 20:55:39 * qheaden realizes he implemented most of the past feedback given by c_l_o_k_e_p_ 20:56:07 <c_l_o_k_e_p_> flo-retina: Please do. 20:56:55 <instantbot> clokep@gmail.com granted review for attachment 2602 on bug 1589. 20:56:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1589 enh, --, ---, nobody, NEW, Replace libpurple XMPP with JS-XMPP 20:57:31 <c_l_o_k_e_p_> flo-retina: I assume you tested that. ;) 20:57:41 <flo-retina> I tested this morning in the train 20:57:45 <flo-retina> I haven't tested again tonight 20:58:02 <flo-retina> I ran make xpcshell-tests on your binary socket patch though :m) 21:05:05 <c_l_o_k_e_p_> Does it pass? ;) 21:06:20 <flo-retina> yes 21:08:39 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/d04931876b00 - Nihanth Subramanya - Bug 2047 - Escape key should close awesometab, r=fqueze 21:08:41 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/0a39e989c23b - Nihanth Subramanya - Bug 2043 - Icon sizes are totally wrong on Windows Aero in awesometab - follow-up to preprocess the aero newtab.css file, r=clokep. 21:08:42 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/6ac1e104befc - Florian Quèze - Bug 1589 - Replace libpurple XMPP with JS-XMPP - enabled JS-XMPP pref'ed off, r=clokep. 21:08:43 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/c9d9c5809c78 - Patrick Cloke - Bug 1981 - Make socket.jsm more binary friendly, r=Mic. 21:08:44 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/05a193794048 - Florian Quèze - Bug 2052 - Add a way to pref off JS prpls, r=clokep. 21:08:45 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/53ca275913c9 - Nihanth Subramanya - Bug 2041 - "Enter" always opens conversation with first contact in the filtered list, r=fqueze 21:08:57 <qheaden> flo-retina, c_l_o_k_e_p_: Soooo..... are you guys happen with the progress us students are making? 21:09:04 <qheaden> *happy 21:09:10 <-- mconley has quit (Input/output error) 21:09:33 --> jb has joined #instantbird 21:09:38 <flo-retina> qheaden: the answer isn't necessarily the same for all students. 21:09:59 <qheaden> :P 21:10:11 <-- jb has quit (Input/output error) 21:10:28 --> Mic has joined #instantbird 21:10:28 * ChanServ sets mode +h Mic 21:10:28 <flo-retina> qheaden: if your mentor isn't happy, it's his job to tell you (in private) 21:10:39 <flo-retina> hey Mic :) 21:10:51 <qheaden> Yeah. :) 21:10:54 <Mic> Hi 21:11:37 --> jb has joined #instantbird 21:13:41 <flo-retina> Mic: I'm curious to know how you feel about my comments in bug 2053 21:13:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2053 enh, --, ---, benediktp, ASSI, Add data to 'conversation-loaded' notification to let observers know that the conversation was moved 21:14:19 <Mic> I've not caught up with the logs, much less read my bugmail yet. Give me a few minutes and I'll let you know ;) 21:15:12 <flo-retina> You look at the logs before the bugmail? :-o 21:15:57 <qheaden> c_l_o_k_e_p_: What merge tool do you use on Windows? WinMerge? 21:16:19 <Mic> To be honest it's Facebook and my normal email account that I check first :P 21:19:38 <flo-retina> I also look at the regular "inbox" before the bugmail folder. 21:19:54 <flo-retina> but facebook :-o 21:21:23 --> mpmc has joined #instantbird 21:21:34 <-- unghost has quit (Quit: Ð£Ñ Ð¾Ð¶Ñ Ñ Ð¾Ñ Ð²Ð°Ñ (xchat 2.4.5 или ÑÑаÑÑе)) 21:27:03 <flo-retina> Good night 21:27:05 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 21:27:16 <instantbot> clokep@gmail.com set the Resolution field on bug 2047 to FIXED. 21:27:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2047 min, --, 1.5, nhnt11, RESO FIXED, Escape key should close awesometab 21:27:37 <instantbot> clokep@gmail.com set the Resolution field on bug 2043 to FIXED. 21:27:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2043 nor, --, 1.5, nhnt11, RESO FIXED, Icon sizes are totally wrong on Windows Aero in awesometab 21:27:52 <c_l_o_k_e_p_> qheaden: Komodo . ;) 21:28:11 * qheaden didn't know Komodo had a merge tool. 21:28:50 <instantbot> clokep@gmail.com set the Resolution field on bug 1981 to FIXED. 21:28:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1981 nor, --, 1.5, clokep, RESO FIXED, Make socket.jsm more binary friendly 21:29:51 <instantbot> clokep@gmail.com set the Resolution field on bug 2052 to FIXED. 21:29:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2052 enh, --, 1.5, florian, RESO FIXED, Add a way to pref off JS prpls. 21:30:21 <instantbot> clokep@gmail.com set the Resolution field on bug 2041 to FIXED. 21:30:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2041 nor, --, 1.5, nhnt11, RESO FIXED, "Enter" always opens conversation with first contact in the filtered list 21:30:25 <c_l_o_k_e_p_> qheaden: It doesn't. :P 21:31:02 <qheaden> c_l_o_k_e_p_: You're a manual merger huh? 21:31:51 <c_l_o_k_e_p_> qheaden: Usually. 21:32:07 <c_l_o_k_e_p_> qheaden: On Windows I'll sometimes use the Mergetool that comes with TortoiseHg. 21:32:11 <c_l_o_k_e_p_> (TortoiseMerge?) 21:32:58 * c_l_o_k_e_p_ thinks he closed all the proper bugs. 21:36:43 <-- c_l_o_k_e_p_ has quit (Quit: http://www.mibbit.com ajax IRC Client) 21:41:15 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105]) 21:42:12 * qheaden goes to rebuild Ib. 21:44:47 --> atuljangra has joined #instantbird 21:49:44 <Mic> The array buffer utils and switch for JS/libpurple protocols landed :) 21:50:05 <Mic> That's nice for you Yahoo! work, isn't it, qheaden? :) 21:50:09 <Mic> *your 21:50:18 <Mic> Hi atuljangra 21:50:33 <atuljangra> Hey :-) 21:51:52 <qheaden> Mic: Yep. Can't wait to land it. :) 22:03:29 <atuljangra> Mic: Where, acc to you, should the filelink code reside? 22:05:08 <Mic> atuljangra: I've no opinion on that. Have neither flo nor clokep recommended something already? 22:07:06 <atuljangra> Yes, they have asked me to keep it in instantbird/ but I needed a specific place where it should be eventually. Situation is, we are in ui and we know that ft has failed, so now I want to try filelink, and it will be called from ui(conversation.xml), but where should the filelink code actually reside? 22:09:16 <Mic> Didn't they say that the filelink code should be in chat/ and the UI for it in instantbird/ or something like that? 22:10:27 <Mic> http://log.bezut.info/instantbird/130715#m158 22:10:44 <atuljangra> Yes. Main emphasis was that the ib-specific code should be in instantbird/ and common code should be in chat. 22:11:29 <atuljangra> So filelink code is in chat/ but the code that will be calling the filelink code, should be in instantbird/ imho 22:11:30 <Mic> As far as I can tell that does mean that all the FileLink backend code that you copy will be in chat/ 22:11:37 <Mic> Exactly. 22:14:08 <Mic> Good night! 22:14:17 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 22:14:29 <atuljangra> So, I wanted to know the place for the code that will be calling filelink code. Like, currently, I've got a file dropped on conversation, and I want to send it using filelink. So the function which takes a file and configures providers and then sends a link to a file needs a location. 22:14:36 <atuljangra> Good Night :) 22:15:09 * atuljangra needs to change his work timings back to daytime :/ 22:15:25 <-- jb has quit (Ping timeout) 22:17:21 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died) 22:17:43 --> chrisccoulson_ has joined #instantbird 22:24:30 --> clokep has joined #instantbird 22:24:30 * ChanServ sets mode +o clokep 22:27:52 <clokep> atuljangra: I'm pretty sure the last we discussed we said it should be in chat/ :( 22:28:42 <atuljangra> clokep: But there was this thing about ib specific code being in instantbird/ and the code that I'm asking about is ib specific. 22:29:23 <clokep> OK, so what's your question? 22:29:24 <atuljangra> keeping in chat/ would be most easy for me at this point of time, as I am familiar with the code there. 22:29:29 <clokep> Is it UI code? Is it a component? 22:29:35 <clokep> No, it shld be in instantbird/ 22:29:52 <clokep> I don't know how it matters if you're more familiar. 22:30:07 <atuljangra> So, I wanted to know the place for the code that will be calling filelink code. Like, currently, I've got a file dropped on conversation, and I want to send it using filelink. So the function which takes a file and configures providers and then sends a link to a file needs a location. 22:30:25 <clokep> You didn't answer my question. 22:30:30 <clokep> Is it UI code? Is it a component? 22:30:34 <clokep> Is it a module? 22:30:41 <clokep> From those three questions you should easily be able to figure out where it goes 22:31:01 <atuljangra> It is not the ui code. 22:31:08 <atuljangra> It is a component imho. 22:31:13 <atuljangra> And it is not a module. 22:31:27 * clokep is confused how you don't already know what it is if you wrote it. :-S 22:32:54 * atuljangra is confused about clokep's confusion :s 22:33:05 <atuljangra> Anyway, I think it should be in module, 22:33:11 <clokep> Stop. 22:33:17 <atuljangra> with a new interface. 22:33:18 <clokep> Didn't you just say you didn't think it is a module? 22:33:22 <clokep> Modules don't have interfaces. 22:33:24 <atuljangra> sorry 22:33:29 <atuljangra> I mean component 22:33:35 <clokep> Did you already write the code? It works? 22:33:41 <atuljangra> Sorry. 22:33:58 <atuljangra> No, I haven't written filelink code yet. 22:34:02 <clokep> 1. Please do not apologize. 2. I have no idea what you're writing. 22:34:08 <clokep> s/writing/apologizing for/ 22:34:27 <clokep> OK, so you have the drag and drop code, right? 22:34:33 <clokep> Thta's inside of the conversation element. 22:34:45 <clokep> Correct? 22:35:07 <atuljangra> I was apologizing for writing modules in place of component. :) 22:35:09 <atuljangra> Yes. 22:36:12 <clokep> For a initial first working example I don't think we care so much where the code goes. 22:36:26 <clokep> It could go in a component, but I don't know what that component would do. 22:36:30 <clokep> Or it could go in the conversaiton. 22:36:34 <clokep> Or you could separate it into a module. 22:37:38 <atuljangra> Okay. So I can make it like sendFile(aFile), it can go in conversation. This can provide a fair working example. 22:38:20 <clokep> If I understand you properly, yes. 22:38:59 <atuljangra> Ok. Thanks :-) 22:40:48 <clokep> That's clear what we want then? 22:42:33 <atuljangra> Yes. When I drop a file to the conversation, we want the file to be uploaded to a provider and a link for the same to be sent in the conversation. 22:43:04 <atuljangra> I'm not clear about the provider though, for the first working example, can I use a dummy provider? 22:43:40 <clokep> Why can't you use a real provider? 22:43:53 --> wnayes has joined #instantbird 22:44:09 <clokep> Is it any harder? 22:44:23 <clokep> (it shouldn't be, all that code was written be the one, the only, the great, mconley) 22:44:46 <atuljangra> I mean, instead of getting the provider from the ui code from the user, I can just use my own provider. 22:45:14 <atuljangra> mconley+++++ :D 22:45:36 <clokep> "I can just use my own provider"? I don't understand, we don't want you to create a provider, that's outside the scope of the project. 22:45:45 <clokep> (Maybe I shold ask, "What ar eyou calling a provider?" 22:46:33 <atuljangra> UbuntuOne? 22:47:32 <atuljangra> I'm saying, instead of getting the details from the user(about provider and auth credentials), I can use my credentials in the code and test it. 22:47:39 <atuljangra> I hope that makes more sense :S 22:48:29 <clokep> Florian already said you don't need configuration UI. 22:48:35 <clokep> And it would be OK to get it from about:config. 22:48:48 <atuljangra> Okay. :) 22:49:24 <atuljangra> Just wondering, it is possible to get a typing state in irc too, right? 22:52:10 <clokep> There's no real protocol for it. 22:52:14 <clokep> Certainly not for MUCs. 22:52:44 <clokep> bug 1590 22:52:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1590 enh, --, ---, nobody, NEW, Typing notifications for IRC 22:53:17 <atuljangra> Okay, we can *fake* one specifically for ib though. 22:53:47 <EionRobb> using dcc? 22:58:35 <atuljangra> EionRobb: yes. 22:59:10 <clokep> atuljangra: I don't know what that means? 22:59:16 <clokep> And I would not use DCC for this. 22:59:21 * clokep isn't sure why atuljangra said yest to that. 22:59:33 <atuljangra> Or maybe all different im clients can agree on one protocol ;) 22:59:37 <EionRobb> ha 23:00:12 <atuljangra> Maybe I misunderstood dcc, but we can send a stanza for typing state, and if the client understands that stanza, then our work is done imho. 23:00:27 <atuljangra> But domain is real less for this implementation. 23:00:41 <EionRobb> mibbit does typing notifications? 23:01:14 <atuljangra> EionRobb: yes it does. 23:01:19 <EionRobb> also: http://pastebin.com/Vb8HQTTL 23:01:23 <clokep> atuljangra: "stanza" is meaningless in DCC. 23:01:32 <clokep> EionRobb: Yes, it does, but only on it's network. 23:01:46 <clokep> EionRobb: Cool, where'd you find that? 23:02:02 <EionRobb> le google 23:02:07 <atuljangra> EionRobb: nice :D haha :P 23:02:19 <atuljangra> clokep: okay. :) 23:02:37 <EionRobb> the flood protection thing is a good point 23:02:59 <clokep> EionRobb: I googled and could never find that... 23:03:06 <clokep> Did you just pastebin it or was that where you found it? 23:03:08 <EionRobb> oh, and bitlbee has typing notifications 23:03:18 <atuljangra> clokep: I guess we should link this pastebin to the bug, just for reference. 23:03:33 <clokep> Bah why do I get lots of hits now? 23:03:33 <EionRobb> no, the pastebin was the 8th result for "irc typing notifications" 23:03:39 <Mook_as> that requires IRC servers to actually implement the protocol, right? (does anybody do it?) 23:03:47 <clokep> Mook_as: It depends how it's done... 23:03:58 <clokep> Mook_as: Ah, that one does, yes... 23:04:20 <EionRobb> how does bitlbee do it? 23:04:40 <EionRobb> CTCP TYPING 23:05:27 <clokep> That was my thoughts. ;) 23:06:51 <EionRobb> http://code.bitlbee.org/lh/bitlbee/view/head:/irc_im.c#L270 :) 23:07:18 <clokep> Ah you found it before I could. 23:20:58 <clokep> Bitlbee's loks reasonable. 23:31:35 --> EionRobb1 has joined #instantbird 23:31:38 <-- EionRobb has quit (Ping timeout) 23:43:44 <-- EionRobb1 has quit (Quit: Leaving.) 23:54:21 <-- mpmc has quit (Connection reset by peer)