#instantbird log on 07 03 2013

All times are UTC.

00:16:22 --> Kaishi has joined #instantbird
00:27:58 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
00:28:52 <-- wnayes has quit (Ping timeout)
00:32:26 <-- Optimizer has quit (Ping timeout)
00:32:27 --> wnayes has joined #instantbird
00:33:32 --> Optimizer has joined #instantbird
00:55:07 --> chrisccoulson has joined #instantbird
00:55:21 <instant-buildbot> build #418 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/418
00:57:31 <-- Mook_as has quit (Quit: Mook_as)
02:01:49 <-- SCIF has quit (Ping timeout)
02:23:57 --> SCIF has joined #instantbird
02:28:49 <-- SCIF has quit (Connection reset by peer)
02:28:50 <-- wnayes has quit (Ping timeout)
02:29:47 --> SCIF has joined #instantbird
02:32:22 --> wnayes has joined #instantbird
02:33:46 <-- wnayes has quit (Quit: wnayes)
02:36:49 * clokep wonders if EionRobb actually compiles his plug-ins on Amiga. ;)
02:37:01 <EionRobb> wow, someone reads my emails? :D
02:37:24 <EionRobb> I think arm... or maybe macports is about as crazy as I've gotten
02:37:25 <clokep> The Pidgin mailing list is always good for laughs. ;)
02:37:28 <EionRobb> :D
02:37:55 <clokep> Especially when people complain about how it's hard to compile things for Windows and then totally ignore us when we reply and say Instantbird does it and they should check out our Makefiles. :P
02:38:10 <clokep> Um...for Windows with MSVC that is.
02:38:16 <EionRobb> ah
02:38:29 <EionRobb> I have no problems compiling plugins for windows :P
02:40:16 <clokep> :)
02:40:37 <clokep> You should add Win32 and Win64 to that list? And Win ARM? :P
02:41:07 <EionRobb> lol
02:41:13 <EionRobb> pidgin isn't win64 yet :P
02:42:56 <clokep> That's a shame.
02:42:58 <clokep> Anyway, goodnight.
02:43:00 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
03:01:39 <instant-buildbot> build #898 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/898
03:08:29 <-- EionRobb has quit (Ping timeout)
03:09:29 --> EionRobb has joined #instantbird
03:10:29 --> nhnt11 has joined #instantbird
03:10:51 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
03:10:55 --> nhnt11 has joined #instantbird
03:10:56 <-- nhnt11 has quit (Input/output error)
03:10:59 <-- Optimizer has quit (Connection reset by peer)
03:12:04 <-- SCIF has quit (Connection reset by peer)
03:14:40 --> SCIF has joined #instantbird
03:17:45 <-- Kaishi has quit (Ping timeout)
03:23:00 --> Kaishi has joined #instantbird
03:28:19 <-- SCIF has quit (Connection reset by peer)
03:28:36 --> SCIF has joined #instantbird
03:34:04 <instant-buildbot> build #890 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/890
03:43:21 <-- SCIF has quit (Connection reset by peer)
03:44:18 --> SCIF has joined #instantbird
03:46:52 <-- SCIF has quit (Client exited)
03:46:54 --> SCIF has joined #instantbird
03:57:31 --> nhnt11 has joined #instantbird
04:04:33 <-- SCIF has quit (Connection reset by peer)
04:04:50 --> SCIF has joined #instantbird
04:09:33 <-- SCIF has quit (Connection reset by peer)
04:10:41 --> SCIF has joined #instantbird
04:10:53 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
04:32:51 <-- SCIF has quit (Connection reset by peer)
04:36:07 --> SCIF has joined #instantbird
04:38:25 --> Optimizer has joined #instantbird
04:40:46 <-- SCIF has quit (Connection reset by peer)
04:41:18 --> SCIF has joined #instantbird
04:45:58 <-- SCIF has quit (Connection reset by peer)
04:46:17 --> SCIF has joined #instantbird
04:49:49 --> mpmc has joined #instantbird
04:50:52 <-- SCIF has quit (Connection reset by peer)
04:50:55 --> SCIF has joined #instantbird
04:58:14 <-- SCIF has quit (Ping timeout)
04:58:56 --> SCIF has joined #instantbird
05:21:10 <-- EionRobb has quit (Quit: Leaving.)
05:23:10 --> EionRobb has joined #instantbird
05:43:35 <-- SCIF has quit (Connection reset by peer)
05:43:37 --> SCIF has joined #instantbird
05:50:01 <instant-buildbot> build #993 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/993
05:52:33 <-- SCIF has quit (Connection reset by peer)
05:52:37 --> SCIF has joined #instantbird
06:01:39 <-- SCIF has quit (Connection reset by peer)
06:03:44 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
06:03:51 --> SCIF has joined #instantbird
06:13:10 <-- EionRobb has quit (Quit: Leaving.)
06:17:30 <-- SCIF has quit (Connection reset by peer)
06:18:19 --> SCIF has joined #instantbird
06:19:39 --> jb has joined #instantbird
06:20:22 <-- jb has quit (Input/output error)
06:22:54 <-- SCIF has quit (Connection reset by peer)
06:23:11 --> SCIF has joined #instantbird
06:27:47 <-- SCIF has quit (Connection reset by peer)
06:27:50 --> SCIF has joined #instantbird
06:37:49 <-- SCIF has quit (Connection reset by peer)
06:37:58 --> SCIF1 has joined #instantbird
06:39:46 --> jb has joined #instantbird
06:51:29 <-- SCIF1 has quit (Connection reset by peer)
06:52:26 <-- jb has quit (Quit: jb)
06:53:32 --> jb has joined #instantbird
06:54:26 <-- jb has quit (Quit: jb)
06:55:00 --> SCIF has joined #instantbird
06:55:21 --> jb has joined #instantbird
06:58:42 <-- SCIF has quit (Quit: Good bye)
07:09:41 <-- jb has quit (Ping timeout)
07:14:40 --> Even has joined #instantbird
07:14:40 * ChanServ sets mode +o Even 
07:21:39 --> jb has joined #instantbird
07:37:50 <-- jb has quit (Ping timeout)
08:06:17 --> skeledrew1 has joined #instantbird
08:06:32 <-- skeledrew has quit (Connection reset by peer)
08:11:36 --> novabyte has joined #instantbird
08:14:09 --> novabyte1 has joined #instantbird
08:14:10 <-- novabyte has quit (Connection reset by peer)
08:15:57 <-- novabyte1 has quit (Ping timeout)
08:16:45 --> novabyte has joined #instantbird
08:19:21 --> skeledrew has joined #instantbird
08:19:55 <-- skeledrew1 has quit (Ping timeout)
08:20:46 <-- novabyte has quit (Ping timeout)
08:21:25 --> jb has joined #instantbird
08:24:34 --> Mic has joined #instantbird
08:24:34 * ChanServ sets mode +h Mic 
08:25:23 --> novabyte has joined #instantbird
08:25:25 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
08:26:14 --> Mic has joined #instantbird
08:26:14 * ChanServ sets mode +h Mic 
08:27:16 <-- novabyte has quit (Ping timeout)
08:33:14 <-- flo-retina has quit (Ping timeout)
08:33:56 --> flo-retina has joined #instantbird
08:33:56 * ChanServ sets mode +qo flo-retina flo-retina 
08:36:43 --> chrisccoulson has joined #instantbird
08:49:24 <-- jb has quit (Ping timeout)
08:51:24 --> EionRobb has joined #instantbird
08:57:13 --> jb has joined #instantbird
09:09:26 --> atuljangra has joined #instantbird
09:12:30 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
09:15:27 --> aleth has joined #instantbird
09:15:27 * ChanServ sets mode +h aleth 
09:50:14 --> flo-retina has joined #instantbird
09:50:14 * ChanServ sets mode +qo flo-retina flo-retina 
10:02:17 <atuljangra> flo-retina: I was using asyncFetch to read data from a file( and then encode it ). But when file is large, then I need to split it up into chunks, encode it, and then send it over the stream. How do I do this type of reading asynchronously? 
10:02:41 <atuljangra> I prefer asynchronous reading because of performance.
10:05:11 --> clokep has joined #instantbird
10:05:11 * ChanServ sets mode +o clokep 
10:08:38 <atuljangra> Or do you want me to limit the size of the file? I can send 65535 bytes without splitting into chunks.
10:11:14 <atuljangra> Hello clokep :D Good morning!
10:12:58 --> dionisos has joined #instantbird
10:16:50 <-- gerard-majax_ has quit (Ping timeout)
10:16:51 <flo-retina> atuljangra: maybe NetUtil's implementation can give you inspiration? http://mxr.mozilla.org/mozilla-central/source/netwerk/base/src/NetUtil.jsm#141
10:17:40 * atuljangra looks
10:17:50 <flo-retina> hmm, or maybe we should look at OS.File
10:19:22 <flo-retina> atuljangra: https://developer.mozilla.org/en-US/docs/JavaScript_OS.File/OS.File_for_the_main_thread#OS.File.read%28%29 may be easier
10:20:11 <atuljangra> okay. Earlier I was sending the whole file in one stream, which works fine. But now I'll have to break the file in smaller chunks. 
10:21:02 <flo-retina> you mean you sent it in one stanza, right?
10:21:49 <atuljangra> Yes.
10:22:58 <atuljangra> Also, do we use atob() /btoa() for encoding in IB? 
10:23:23 <flo-retina> do they do what you need?
10:24:16 <atuljangra> I basically need to read 4KB data from the file, encode it using base-64 encoding and then send it in stanzas, so yes I guess they should work fine.
10:26:39 * atuljangra will go for lunch, will be back in 30 mins :)
10:27:06 <atuljangra> changing my status to "lunch" as aleth suggested ;)
10:27:16 <Mic> ;)
10:27:44 <aleth> Hopefully moznet's interserver communications will pick it up this time ;)
10:28:11 <Mic> You can only set a status message when being away, on IRC, can't you?
10:28:33 <aleth> Mic: Yes, it's an "away message"
10:39:22 <Mic> bye!
10:39:44 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
10:40:43 <clokep> atuljangra: I'm making comments, they mostly apply everywhere.
10:49:01 <clokep> As in any nits should be fixed everywhere, you can ignore them until stuff works though.
10:50:40 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
10:55:46 <-- aleth has quit (Quit: Ciao)
10:55:53 --> aleth has joined #instantbird
10:55:53 * ChanServ sets mode +h aleth 
11:01:10 <atuljangra> clokep Some things are not fixed yet. Like sessionID. Will keep all those points in mind :-)
11:11:59 <-- Optimizer has quit (Ping timeout)
11:15:12 <-- jb has quit (Connection reset by peer)
11:15:15 --> jb has joined #instantbird
11:21:31 --> Optimizer has joined #instantbird
11:24:10 <-- jb has quit (Ping timeout)
11:35:28 --> gerard-majax_ has joined #instantbird
11:40:08 <-- mpmc has quit (Connection reset by peer)
11:42:58 --> jb has joined #instantbird
11:44:22 <-- EionRobb has quit (Quit: Leaving.)
11:46:21 <-- dionisos has quit (Ping timeout)
11:48:26 <flo-retina> I just tried a bit to understand why my debug build leaks 1 nsStringBuffer at shutdown if I connect my florian@moznet account. Here is a log of an error that happened on shutdown: http://pastebin.instantbird.com/237459
11:48:44 <flo-retina> other accounts (including a freenode account) don't cause shutdown leaks
11:49:32 <flo-retina> so I wonder if the issue could be related to our handling of nickserv's message (florian is a registered nick, but the account on my debug profile doesn't have the password)
11:50:13 <flo-retina> the pastebined log is if I quit Instantbird after connecting the account, but before the nickserv conversation pops up.
11:50:51 <flo-retina> the leak also happens if I quit after the window popped up
11:53:43 --> clokep_ has joined #instantbird
12:07:29 <clokep_> Hello. :)
12:15:06 --> mpmc has joined #instantbird
12:15:34 --> Mic has joined #instantbird
12:15:51 * Mic is now known as Mic2
12:20:59 <-- Even has quit (Input/output error)
12:22:02 --> dionisos has joined #instantbird
12:24:41 <-- dionisos has quit (Ping timeout)
12:31:59 --> dionisos has joined #instantbird
12:34:08 <atuljangra> Hello clokep_ :-) Thanks for the comments. Will keep that in mind. I'll address them in my next changeset.
12:37:05 <clokep_> OK.
12:37:11 <clokep_> I didn't finish going through it, ran out of time.
12:45:12 <-- Mic2 has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
12:51:45 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
12:55:57 <atuljangra> No problem :)
13:20:43 <-- Optimizer has quit (Ping timeout)
13:21:57 --> Optimizer has joined #instantbird
13:22:47 <-- Optimizer has quit (Connection reset by peer)
13:24:43 --> Optimizer has joined #instantbird
13:25:04 <flo-retina> has anybody looked at the WIP I sent for the Gtalk/Hangout typing issue?
13:26:24 <-- Optimizer has quit (Ping timeout)
13:30:06 * clokep_ hasn't.
13:31:03 <-- dionisos has quit (Ping timeout)
13:31:23 --> Optimizer has joined #instantbird
13:31:48 * flo-retina has just been annoyed by it, and updated the WIP
13:31:54 <flo-retina> what's the bug number again? :)
13:33:06 <flo-retina> 2000 :)
13:33:26 <flo-retina> ah, no 1979
13:34:42 <clokep_> Updated by the issue or the WIP? :P
13:37:12 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 2549 on bug 1979.
13:37:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1979 nor, --, ---, florian, NEW, "Typing" indicator is never cleared.
13:41:36 --> mpmc has joined #instantbird
13:43:54 <clokep_> :P
13:43:59 <clokep_> I'm trying to review it tomorrow.
13:46:56 <flo-retina> clokep_: atuljangra can steal the review if he wants ;)
13:48:13 <atuljangra> Okay :P
13:48:44 <flo-retina> I don't remember if atuljangra was one of the students annoyed by this bug
13:49:46 <atuljangra> I am one of them, but I guess there was someone else also who was facing the issue.
13:50:46 * aleth added some review comments on bug 2015
13:50:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2015 enh, --, ---, nhnt11, NEW, Display buddy list in a tab.
13:52:25 <clokep_> About b ug 2015...We really need to review that ASAP and not worry about the nits and get it checked in or continually track the progress nhnt11 is going to make.
13:52:40 <flo-retina> atuljangra: right, so maybe you want to review the code, and convince that other someone (I think it was qheaden and maybe event nhnt11 too!) to test the patch locally ;)
13:53:26 <aleth> clokep_: I was just going to say we should either get this ready today or tomorrow or I am not sure it is worth reviewing this separately from the service he is creating
13:53:42 <atuljangra> flo-retina: Cool :D I'll do it.
13:54:20 <flo-retina> clokep_: I'm not sure what your point is here.
13:54:47 <flo-retina> clokep_: I agree that we should get it checked in asap, but I looked quickly yesterday, and that was enough to decide I would need time to write a long review comment.
13:54:55 <aleth> clokep_: I don't think it's a good idea to land if it's not ready (that includes nits)
13:55:56 <clokep_> I'm not saying we should just land it.
13:56:01 <aleth> It's different to leave subfeatures to followups.
13:56:04 <clokep_> I'm saying that we need fast review cycles. ;)
13:56:11 * qheaden_away is now known as qheaden
13:56:15 <clokep_> Again, I'm not saying we shouldn't handle the nits.
13:56:16 <qheaden> Hello everyone.
13:56:26 <clokep_> I'm just saying that we don't want to block nhnt11.
13:57:12 * clokep_ has a meeting.
13:57:19 * aleth wonders if flo's comments were going to be similar to the ones he just made
13:57:42 <flo-retina> clokep_: I kept pushing for the patch to be as small as possible so that we can review and land quickly. I certainly don't want to encourage him to increase the size of the patch before we review it ;)
14:05:22 <-- Kaishi has quit (Quit: Kaishi)
14:11:18 <clokep_> small patches are good. :)
14:12:56 <qheaden> clokep_: What did you mean by your comment here -https://bitbucket.org/qheaden/instantbird-gsoc-2013/commits/cf22b0157081ccd3ff9b18d261351e04abc67f26
14:13:01 <qheaden> Oops https://bitbucket.org/qheaden/instantbird-gsoc-2013/commits/cf22b0157081ccd3ff9b18d261351e04abc67f26
14:14:12 <flo-retina> aleth: "lookup is faster" (for Maps). Really?
14:14:38 <aleth> flo-retina: I believe the keys are hashed and kept sorted, so lookup uses binary search.
14:15:02 <flo-retina> my understanding is that it's a hash table both for regular objects and for maps
14:15:07 <aleth> Whether it is actually faster, one would have to profile
14:15:17 <flo-retina> (if the key count is large enough to make a hash table valuable)
14:15:34 <clokep_> qheaden: Why is the key of that called "int"?
14:15:35 <flo-retina> I also disagree with "the API is more legible"
14:15:37 <clokep_> Is that correct?
14:15:37 <aleth> Really? That's good to know
14:15:51 <flo-retina> aleth: I'm not fully sure.
14:16:05 <clokep_> I think it's much nicer than using hasOwnProperty everywhere..
14:16:25 <flo-retina> aleth: the object API really sucks if we need to rely on hasOwnProperties. But in this specific case we know we have only integers as keys.
14:17:12 <aleth> flo-retina: OK, so in this specific case it doesn't do much, he can just drop hasOwnProperty ;)
14:17:27 <flo-retina> does he have hasOwnProperty in his code?
14:17:35 <aleth> Yes
14:17:39 <flo-retina> bah :(
14:17:58 <qheaden> clokep_: Oh okay. I used jsTest as a model, which made me incorrectly think that the label is supposed to tell the data type of the option. I'll change it.
14:19:29 * atuljangra is hungry.
14:19:45 <atuljangra> I'm going to eat something. Will be back in 30 mins :D
14:19:55 <atuljangra> Anyone needs anything from the supermarket? ;)
14:20:14 <qheaden> Bring me some coffee. :)
14:20:21 <flo-retina> bring me a few croissants
14:20:45 <qheaden> I have an overage of those in my house flo-retina. I'll send you some. :)
14:20:58 <atuljangra> Heh Okay :D
14:21:01 <atuljangra> Bbye :)
14:21:03 <-- atuljangra has quit (Quit: He didn't quit, he'll be back!)
14:21:15 --> atuljangra has joined #instantbird
14:21:20 <-- atuljangra has quit (Quit: atuljangra)
14:21:54 <flo-retina> aleth: I just read your comments. No, none of the comments I wanted to make are part of your review comments :).
14:21:57 <qheaden> When I go away from the IRC, would you guys prefer it if I changed my nick to qheaden_away, or just set my status to away?
14:22:18 <flo-retina> aleth: yours required a more in depth reading of the patch. I just scrolled through.
14:22:30 <aleth> flo-retina: Seems I have not saved you any time then :D
14:22:39 <flo-retina> qheaden: just set your status to away
14:22:58 <flo-retina> aleth: you definitely have. I would likely have had the same comments if I had actually read the patch.
14:23:22 <aleth> There's a bunch of things I didn't mention which I thought would be better addressed when we review his new Service. 
14:23:24 <qheaden> flo-retina: Okay, I'll do that for now on.
14:26:05 <aleth> qheaden: seeing as our IRC implementation supports status ;)
14:26:20 --> nhnt11_phone has joined #instantbird
14:26:24 <nhnt11_phone> Hi
14:26:50 <nhnt11_phone> Um, I can't be online today. I'll work on sunday to make up for it.
14:27:07 <qheaden> :)
14:27:25 <qheaden> Hey nhnt11_phone.
14:27:55 <clokep_> qheaden: The label is the name of the preference.
14:28:15 <qheaden> clokep_: Okay. I just changed it to pagerPort.
14:28:39 <qheaden> clokep_: BTW, that commit didn't make use of the options because it was a left-over commit from the night before. I'm working on implementing it now.
14:29:05 <clokep_> qheaden: Does that match the preference name in libpurple? It must match EXACTLY.
14:29:13 <nhnt11_phone> Also, about the Map stuff, I was thinking about how best to implement Mic's suggestion about keeping data about individual awesometabs in the SS, and probably use a map there (I see the possibility of mapping awesometabs to their data structures)
14:29:18 <nhnt11_phone> Hi qheaden :)
14:29:44 <nhnt11_phone> probably will use*
14:30:04 <nhnt11_phone> imContactsById is no longer used, ive removed it from the service iirc
14:30:30 <aleth> Why would you keep data about individual awesometabs in the service?
14:30:50 <qheaden> clokep_: Okay, the label in libpurple is Pager port. I'll change the localized label to that.
14:31:07 <nhnt11_phone> aleth: So that the service can update the filteredContacts lists dynamically, and awesometabs dont need to do any work.
14:31:20 <nhnt11_phone> (Other than redisplay the items)
14:31:44 <aleth> nhnt11_phone: Can't the service just tell the tabs the data is stale and they need to refresh?
14:32:05 <aleth> I guess it all depends on how you implement it
14:32:21 <aleth> I would have thought it would be better to keep instance-specific state in the panel.
14:32:44 <clokep_> qheaden: No, no, you misunderstand. You need the ID to match exactly, the localized name doesn't need to (but probably should).
14:33:06 <nhnt11_phone> That's what it's doing now, but right now the awesome tabs need to re-fetch their filtered lists. The idea is to update these from the Service and only have to refresh DOM elements from awesometabs
14:33:27 <nhnt11_phone> Im open to suggestions though (this idea was one, thought I'd try it out)
14:33:49 <qheaden> Ok. Let me see if I can find the ID.
14:34:13 <clokep_> qheaden: http://lxr.instantbird.org/instantbird/source/purple/libpurple/protocols/yahoo/libyahoo.c#311
14:34:32 <clokep_> That gives the string and the ID.
14:34:39 <qheaden> clokep_: It's "port"
14:37:09 <qheaden> clokep_: I'm going to add all options to the prpl, but I will implement them over time.
14:37:50 <nhnt11_phone> By the way, flo-retina, I ran a package build and it says the Cc["@instantbird.org/conv-stats-service;1"] is undefined.
14:38:11 <nhnt11_phone> Do I need to add something to packaging scripts for the new component? 
14:39:52 <nhnt11_phone> Also, I'll be happy to test out your hangouts patch before bed tonight though I guess someone would already have done so by then.
14:40:38 <nhnt11_phone> I must go now, I'll keep an eye on bugmail and glance at the logs now and then, and pop in if I want to say something.
14:40:40 <nhnt11_phone> Bye! 
14:41:45 <-- nhnt11_phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
14:44:53 <clokep_> qheaden: That makes sense, just keep track of which are implemented (they're all listed separately on the 'pad)
15:00:24 <flo-retina> nhnt11_phone: yes, you need to add stuff in package-manifest.in
15:04:53 --> dionisos has joined #instantbird
15:11:50 <-- dionisos has quit (Ping timeout)
15:14:54 <-- GeekShadow has quit (Ping timeout)
15:15:35 <-- aleth has quit (Quit: Ciao)
15:18:05 <-- clokep_ has quit (Quit: http://www.mibbit.com ajax IRC Client)
15:18:32 --> GeekShadow has joined #instantbird
15:22:37 --> clokep_ has joined #instantbird
15:26:14 --> nhnt11 has joined #instantbird
15:26:46 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
15:31:36 <qheaden> clokep_: Looking good: http://imgur.com/SrVtfhz
15:42:08 <flo-retina> qheaden: what's that screenshot showing?
15:43:05 <qheaden> Its showing that the options list between my plugin and the current libpurple one is the same.
15:43:18 <flo-retina> that looks like a bug ;)
15:43:46 <flo-retina> if the libpurple options don't make any sense from a user point of view, we likely don't want to copy them
15:44:08 <flo-retina> the last one about proxy seems especially wrong for example ;).
15:44:48 <qheaden> :P
15:45:11 <qheaden> Okay, we will refine them as I implement usage of the options.
16:09:18 <flo-retina> nhnt11: http://log.bezut.info/instantbird/130703#m310 well, I guess it depends if anybody's got a reliable way to reproduce the issue.
16:28:15 <qheaden> Does the Ib UI currently support chat room invites?
16:33:13 <flo-retina> I think we just open the change automatically when invited, without showing an invite message
16:36:43 <qheaden> I know it does that when invited (my plug-in does that too), but does the UI support inviting people to a conference you create?
16:37:18 <qheaden> Like being able to select buddies and click "Initiate Conference" or something similar.
16:38:17 --> atuljangra has joined #instantbird
16:38:39 <clokep_> qheaden: No, IRC uses a command.
16:39:01 <clokep_> qheaden: Umm...we need some way to do it, but I don't think we have prpl specfic context menus yet?
16:39:18 <qheaden> Okay.
16:44:31 <flo-retina> clokep_: I suspect we don't want them either
16:44:40 --> Mook_as has joined #instantbird
16:45:30 <qheaden> clokep_: Is the .left property on the conference supposed to update the UI or write a message in the chat window when set to true?
16:46:21 <clokep_> flo-retina: Really? :(
16:46:29 <clokep_> It'd be nice to be able to find people to chat rooms...
16:46:38 <clokep_> qheaden: I forget if it does it automatically.
16:46:43 <clokep_> You might have to send out a notification.
16:46:50 <clokep_> This should probably be added to jsProtoHElper.
16:46:55 <clokep_> See what IRC does.
16:46:59 <qheaden> Okay.
16:47:02 <flo-retina> clokep_: how does that relate to a context menu?
16:48:33 <clokep_> flo-retina: Do you have another proposed way to do it?
16:48:39 <flo-retina> do what?
16:49:05 <clokep_> flo-retina: Invite people to a chat room? Isn't that what we were just discussing? :(
16:49:28 <flo-retina> a context menu isn't a discoverable way to do it ('normal' people don't notice context menus).
16:49:39 <flo-retina> so you would likely want a "+" button at the top or bottom of the participant list
16:50:06 <flo-retina> dragging a contact to the conversation or participant list could also work
16:50:42 <qheaden> They both could work. Although I think that the "+" button would be more noticeable and natural to common users.
16:50:56 <flo-retina> clokep_: a reason to not want this as a prpl-customized context menu is that we would then have no way to ensure the label is the same for all protocols offering the feature
16:52:28 <clokep_> flo-retina: That would work too.
16:52:35 <flo-retina> (and I really don't see how a context menu item could be enough to initiate such an action; it would also require an API similar to Pidgin's "request" API, that I certainly don't want ;))
16:52:55 <clokep_> Why would it require one similar to the request API.
16:53:04 <clokep_> Why can't it just be like the one we have for messages already?
16:53:11 <flo-retina> clokep_: you would need to enter the name of the contact to invite somewhere.
16:53:23 <clokep_> flo-retina: You'd right clikc ON THE CONTACT.
16:54:01 <flo-retina> ah. So you would need to specify the conversation you want to invite the contact to then
16:54:35 <clokep_> Who needs more than one conversation? ;)
16:54:51 <flo-retina> clokep_: people who need more than one contact in their chat room? :)
16:55:06 <flo-retina> clokep_: because really, who needs more than one contact in there at once? ;)
16:55:09 <qheaden> Remember too that people not in your buddy list can be invited.
16:56:12 <flo-retina> right, so you need to type the name of the person ;)
16:56:18 <flo-retina> I actually had the IRC case in mind :-P.
16:56:34 <flo-retina> We would need it for MSN too, but it's going away so we don't care :-P
16:57:15 <qheaden> Going away? It's gone? Unless you are talking about the plug-in. :)
16:57:28 <qheaden> *It's gone
16:57:41 <clokep_> qheaden: You can still connect to MSN.
16:57:50 <qheaden> Really?
16:57:51 <flo-retina> qheaden: only the client side software is gone
16:58:14 <qheaden> Hmm, ok.
16:58:52 <clokep_> AIM supports chats too.
16:58:55 <clokep_> MUCs
16:59:29 <flo-retina> clokep_: isn't that with something like a MUC tree?
16:59:46 <flo-retina> I remember libpurple has a complicated API for the Join Chat dialog for some of the prpl
17:03:05 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client)
17:04:04 --> atuljangra has joined #instantbird
17:07:45 * atuljangra back to work
17:12:27 --> nhnt11_phone has joined #instantbird
17:12:36 <qheaden> I'll be back in a bit.
17:13:02 <nhnt11_phone> flo-retina: Not using richlistitem means not using richlistbox.css :(
17:13:15 <flo-retina> hmm
17:13:26 <flo-retina> what are we taking from there?
17:13:37 <flo-retina> nhnt11_phone: the other solution is to add a class to the richlist items
17:13:51 <nhnt11_phone> Right. That would be a separate bug though..
17:14:08 <flo-retina> I meant in your code
17:14:27 <nhnt11_phone> All the margins, paddings, borders ,etc are taken from it
17:14:37 <flo-retina> so that your -moz-binding rule is attached to .yourclass rather than richlistitem
17:14:37 <nhnt11_phone> Ah
17:14:40 <nhnt11_phone> Right
17:14:42 <nhnt11_phone> Yeah got it
17:14:52 <nhnt11_phone> Cool, that works.
17:15:06 <nhnt11_phone> Ill be online soon btw
17:15:54 <nhnt11_phone> Btw, isnt status.css used in the blist? 
17:16:10 <nhnt11_phone> If I change it, I'll be breaking stuff there, I think.
17:16:23 <flo-retina> you won't break it by adding rules
17:16:46 <flo-retina> the goal of status.css is to be the only place that uses these status icons with a css rule for each status
17:16:52 <nhnt11_phone> Hmm. I shouldn't comment right now, need to look at the file
17:16:54 <flo-retina> if there are different sizes of icons, it's ok to have different rules...
17:17:25 <nhnt11_phone> Okay
17:28:17 --> nhnt11 has joined #instantbird
17:28:20 <nhnt11> Hi
17:28:38 <-- nhnt11_phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
17:28:42 <flo-retina> nhnt11: hello :)
17:29:28 * nhnt11 needs to switch to 3g
17:29:49 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:29:53 --> nhnt11 has joined #instantbird
17:30:16 <nhnt11> flo-retina: So do we want to land the patch as it is now, or with the new service?
17:30:28 <flo-retina> nhnt11: we want to land a reviewed patch ;)
17:30:35 <nhnt11> :D
17:30:51 <nhnt11> I meant with/without the service.
17:30:54 <flo-retina> without
17:30:58 <nhnt11> Right.
17:33:17 <nhnt11> flo-retina: "newconvtab.xml" seems good?
17:33:48 <flo-retina> I would go with only "newtab.xml" for the file name, but if you really want the conv in there, ok
17:34:31 <nhnt11> I don't really want conv :) newtab.xml it is.
17:35:07 <nhnt11> I'm renaming awesomebar to filterbox, unless you have a better suggestion.
17:35:22 <nhnt11> ("searchbox"?)
17:35:37 <flo-retina> I didn't even notice you had something called awesomebar :-D
17:35:41 <flo-retina> yeah, filterbox
17:36:07 <nhnt11> (I didn't intend to keep that :P )
17:38:35 <-- gerard-majax_ has quit (Ping timeout)
17:39:05 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:39:21 <nhnt11> flo-retina: status.css assigns <status>.png to the "statusIcon" class, I'm going to add a rule to assign <status>-16.png to "statusIcon16". Is the class name fine?
17:48:24 --> bugweiser has joined #instantbird
17:49:51 <bugweiser> i am using instantbird do i need to make changes in folder i downloaded to contribute 
17:50:08 <bugweiser> from which i ran instantbird
17:53:28 <bugweiser> clokep_ please reply
17:55:21 <qheaden> Back
17:55:35 <qheaden> bugweiser: Yes, to contribute, you must make changes in the source folder you downloaded.
17:56:12 <qheaden> bugweiser: Did you download just the release version of Instantbird, or did you checkout the entire source code?
17:56:52 <bugweiser> from which we make it work like for using containing exec files
17:57:11 <bugweiser> there is no source folder
17:57:43 <nhnt11> bugweiser: You may want to look at this: v
17:57:46 <nhnt11> https://wiki.instantbird.org/Instantbird:Compiling *
17:57:57 <bugweiser> ok
17:58:22 <qheaden> bugweiser: Yes, that page is helpful. To contribute to the project, you must first download and compile the Instantbird source code.
17:59:24 <bugweiser> ok so there is difference between which i downloaded bcoz they have different links
18:00:07 <-- atuljangra has quit (Ping timeout)
18:01:06 <-- bugweiser has quit (Quit: http://www.mibbit.com ajax IRC Client)
18:02:59 --> Mnyromyr has joined #instantbird
18:03:16 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
18:04:22 <-- jb has quit (Ping timeout)
18:08:13 <qheaden> If a conversation is in the "left" state (left == true), does that prevent sendMsg from being called?
18:13:28 --> flo-retina has joined #instantbird
18:13:28 * ChanServ sets mode +qo flo-retina flo-retina 
18:14:51 <-- nhnt11 has quit (Ping timeout)
18:15:07 --> nhnt11 has joined #instantbird
18:15:46 <flo-retina> nhnt11: seems ok (for the class name)
18:18:25 * nhnt11 has newtab working after a lot of refractoring.
18:18:33 --> atuljangra has joined #instantbird
18:18:41 <clokep_> qheaden: No.
18:18:55 <clokep_> qheaden: You can actually send message to IRC channels if you've left. ;)
18:19:47 <qheaden> :P Okay.
18:20:18 <qheaden>  clokep_: Would you agree that when a Yahoo conversation is "left", messages shouldn't be sent by sendMsg?
18:20:28 <qheaden> After all, it means that the conference is closed by the owner.
18:20:44 * qheaden has to check if people can chat on a conference without the owner around.
18:24:14 <nhnt11> flo-retina: The conversation binding uses "statusTypeIcon", I'm going to use that too
18:24:44 <nhnt11> That way we can get rid of the rules in conversation.css and include status.css there as well in a future bug.
18:24:49 <nhnt11> Sounds alright?
18:25:25 --> gerard-majax_ has joined #instantbird
18:25:32 <nhnt11> Might be a bit confusing though .. :S
18:26:05 * nhnt11 can't decide and waits for fl_o's opinion.
18:26:12 <flo-retina> yeah
18:26:28 <flo-retina> except you can include status.css in conversation.css immediately
18:26:44 <flo-retina> or just include it from theme/instantbird.css, so that it applies to both the conversation binding and your tag
18:26:47 <flo-retina> *tab
18:27:11 <clokep_> qheaden: Yes, I'd agree with that...assuming tha you cannot continue w/o an owner.
18:27:22 <flo-retina> nhnt11: that's basically what I was asking wnayes to do ;)
18:27:32 <nhnt11> In the same bug?
18:27:34 <nhnt11> Okay then.
18:27:52 <qheaden> clokep_: If you cannot continue without an owner, I will prevent sendMsg from sending a message, and write a system message saying that the conference is closed.
18:29:04 <flo-retina> nhnt11: yes, same bug.
18:29:38 <nhnt11> flo-retina: So statusTypeIcon is fine? I find it confusing.
18:30:49 <clokep_> qheaden: Seems good.
18:30:57 <flo-retina> nhnt11: yes
18:31:34 <flo-retina> nhnt11: I agree that it's probably not the best name, but keeping the name that's already in use for the exact same thing is easier ;)
18:32:10 <-- nhnt11 has quit (Ping timeout)
18:33:33 --> nhnt11 has joined #instantbird
18:33:44 <nhnt11> Okay.
18:37:12 --> qlum has joined #instantbird
18:37:56 <qheaden> So it looks like conferences can continue without the original founder.
18:38:24 <-- flo-retina has quit (Ping timeout)
18:38:51 --> flo-retina has joined #instantbird
18:38:51 * ChanServ sets mode +qo flo-retina flo-retina 
18:39:26 <nhnt11> flo-retina: What's the best way to have constants (kSomeConstant) in XBL? I'm using readonly properties right now.
18:40:27 <flo-retina> if you use it only in one method, const kStuff = 42; at the beginning of the method
18:40:33 <flo-retina> otherwise, I would use a field
18:40:55 <nhnt11> Okay.
18:42:04 --> dionisos has joined #instantbird
18:45:02 <nhnt11> flo-retina: Right now, if nothing is selected and the user presses enter, a conversation is started with the first item in the list. aleth says to do this only if there's only one item. Do you agree?
18:45:33 <nhnt11> I like the current behavior because I can type and immediately press enter.
18:45:47 <flo-retina> keep it as is
18:45:49 <nhnt11> One alternative is to automatically select the first item when the user changes the search string.
18:46:10 <flo-retina> I was going to say that it would be nice to have the item selected if it's going to be the one we use
18:46:17 <nhnt11> Cool.
18:46:30 <flo-retina> but then I don't know how the down arrow key should work
18:46:36 <flo-retina> should it select the second element then?
18:46:42 <nhnt11> Yeah, I guess so.
18:46:47 <nhnt11> I'm tempted to keep it as it is for now
18:46:47 <flo-retina> anyway, I'll need to try this before having a *real* opinion
18:46:55 <flo-retina> but I think this is stuff we can polish in follow ups
18:47:13 <flo-retina> so keep it as is for now and we'll see what we think after using it for a few days
18:47:15 <nhnt11> My goal for tonight before bed was to address the review comments and get a new patch uploaded, I don't want to mess with UX decisions :(
18:47:18 <nhnt11> Right, cool.
18:47:44 * nhnt11 wants to test the hangouts patch too.
18:50:59 <flo-retina> :)
18:51:20 <nhnt11> Oh wow
18:51:27 <nhnt11> I think I just messed something up, somehow
18:51:42 <nhnt11> I just did a tier_app build, and the colours are... vivid.
18:51:54 * nhnt11 wonders how on earth that could have happened :S
18:52:06 <nhnt11> And the infinite scroll is somehow broken
18:53:23 <nhnt11> :S
18:53:40 <-- flo-retina has quit (Ping timeout)
18:53:53 --> flo-retina has joined #instantbird
18:53:53 * ChanServ sets mode +qo flo-retina flo-retina 
18:54:20 <nhnt11> It was all working perfectly, then I changed some code in startConversations and everything is borked.
18:55:26 <nhnt11> Ran a tier_app again, and lo and behold, it's back to normal. In the previous build, the OpenGL LayerManager initialization messages didn't appear.
18:55:32 <nhnt11> That would explain the colors.
18:57:32 <-- dionisos has quit (Ping timeout)
19:01:38 <-- flo-retina has quit (Input/output error)
19:01:45 * nhnt11 turned his status indicator dots super-bright by disabling layers acceleration
19:02:34 --> flo-retina has joined #instantbird
19:02:35 * ChanServ sets mode +qo flo-retina flo-retina 
19:04:19 <nhnt11> flo-retina: So I'm sticking with hasOwnProperty for now.
19:04:26 <flo-retina> why?
19:04:54 <nhnt11> flo-retina: You want me to change to using a Map?
19:04:58 <flo-retina> no
19:05:00 <nhnt11> I should change it to for..in though.
19:05:03 --> Mic has joined #instantbird
19:05:04 * ChanServ sets mode +h Mic 
19:05:33 <flo-retina> nhnt11: but I would like |foo.hasOwnProperty(bar)| to be changed to |bar in foo|
19:05:51 <nhnt11> Just did that.
19:05:56 * flo-retina blames BenB for the font of "to be changed to" :(
19:06:30 <nhnt11> Bah, the | code | rarely ever works.
19:06:35 <nhnt11> |code| ?
19:06:39 <nhnt11> Meh.
19:07:01 <nhnt11> brb
19:07:02 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
19:07:09 --> nhnt11 has joined #instantbird
19:07:14 <clokep_> It doesn't work much, yes. :(
19:07:36 --> mib_hbqw0r has joined #instantbird
19:08:50 <-- nhnt11 has quit (Ping timeout)
19:08:50 --> nhnt12 has joined #instantbird
19:09:10 * nhnt12 is now known as nhnt11
19:09:15 <mib_hbqw0r> hi after downloading do we need to hg clone
19:09:24 <mib_hbqw0r> downloading source
19:09:49 <flo-retina> mib_hbqw0r: what are you trying to do? :)
19:10:38 <clokep_> What are you downloading if you're not cloning? :)
19:11:00 --> DGMurdockIII has joined #instantbird
19:12:22 <mib_hbqw0r> following instruction to build it so that i can contribute
19:12:58 <clokep_> mib_hbqw0r: Can you be more specific? Instructions from where?
19:13:14 * clokep_ isn't sure if there are old ones around, etc.
19:13:48 * nhnt11 can't figure out why ibConvStatsService is still being added to the .app package though he switched to his other branch.
19:14:38 <flo-retina> DGMurdockIII: Hello :). How come you are using chatzilla to join a channel called "instantbird"? :-P
19:15:12 <flo-retina> nhnt11: stuff that was in .app before is still in .app now
19:15:25 <nhnt11> flo-retina: I manually deleted that stuff and did another tier_app.
19:15:28 <-- Nirgali has quit (Ping timeout)
19:16:02 <mib_hbqw0r> https://wiki.instantbird.org/Instantbird:Compiling
19:16:15 <mib_hbqw0r> header Get the Source
19:16:26 <nhnt11> mib_hbqw0r: Are you bugweiser?
19:16:49 <mib_hbqw0r> how do i clone mercurial repository
19:16:54 <clokep_> mib_hbqw0r: I'd suggest cloning it in Mercurial, not downloading the zipped up source.
19:16:57 <mib_hbqw0r> yes
19:17:09 <nhnt11> Okay :)
19:17:30 <nhnt11> mib_hbqw0r: You need to have Mercurial installed, then do $hg clone from the command line.
19:17:41 <clokep_> mib_hbqw0r: What OS are you on, first of all.
19:17:51 <mib_hbqw0r> ubntu
19:17:57 <mib_hbqw0r> 12.10
19:18:14 <clokep_> OK, did you see the link about for https://developer.mozilla.org/En/Developer_Guide/Build_Instructions#Build_prerequisites?
19:18:21 <clokep_> You need to get the prereqs installed first.
19:18:30 <clokep_> And then it's hg clone https://hg.instantbird.org/instantbird
19:19:14 <mib_hbqw0r> i am done with preq
19:19:27 <clokep_> Did you clone the source then or no?
19:20:00 <clokep_> qheaden: It's weird that we define _participants in the proto but not the other fields. :(
19:20:54 <qheaden> clokep_: Yeah. BTW, how is a participant removed from the room? I'm calling delete on the buddy object, but it isn't being removed from the list.
19:20:59 <mib_hbqw0r> only two things i did are preq and downloading source from zip
19:21:46 <clokep_> mib_hbqw0r: Right, so it would probably make sense to clone the source using the command Ig ave above instaed of downloading the zip.
19:22:01 <clokep_> qheaden: http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#355
19:22:55 <qheaden> clokep_: That looks like something that needs to be moved into jsProtoHelper. But we can do that later.
19:24:27 <mib_hbqw0r> clone takes much time right?
19:24:30 <clokep_> Sure thing. :)
19:24:48 <clokep_> mib_hbqw0r: Cloning the Mozilla source takes a long time, cloning ours should not take too long.
19:25:00 <clokep_> (You have to clone the Mozilla source after cloning Instantbird.)
19:25:19 <clokep_> qheaden: Maybe...I'd really appreciate if you could spend a ~week at some point looking to improve jsProtoHelper.
19:25:57 <qheaden> clokep_: Perhaps after I finish implementing all of the chat stuff, I'll try to abstract some common code into jsProtoHelper. How does that sound?
19:26:28 <mib_hbqw0r> clokep_  i was unable to build firefox after instantbird do i need to do that
19:27:52 <nhnt11> flo-retina: I just did a full diff of my working branch vs. default, and don't see any reason why ibConvStatsService stuff is making its way into objdir/mozilla/dist/Instantbird.app
19:28:29 <clokep_> qheaden: Excellent. :)
19:28:34 <clokep_> mib_hbqw0r: No, you don't need to do that.
19:28:43 <mib_hbqw0r> clokep_ cloning is finished . wha u said about mozilla source
19:28:55 <clokep_> mib_hbqw0r: You need to run python client.py checkout
19:28:58 <clokep_> I think it's on the wiki page.
19:29:59 <mib_hbqw0r> clokep_ but you will not find anything mozilla source  there
19:29:59 <flo-retina> nhnt11: find objdir/ -name 'ibConvStatsService*'
19:30:38 <nhnt11> flo-retina: No output
19:30:47 <clokep_> mib_hbqw0r: What?
19:31:32 --> jb has joined #instantbird
19:31:58 <clokep_> mib_hbqw0r: You don't have to build the Mozilla source code separate, it's all done in one step through our makefiles.
19:32:11 <mib_hbqw0r> ok
19:34:32 <qheaden> mib_hbqw0r: First, hg clone the repository to your local computer. Make sure that you have all of the dependencies in place. If you were able to compile firefox in the past, you will be able to compile Instantbird.
19:35:16 <qheaden> mib_hbqw0r: You don't have to compile Firefox to compile Instantbird, as they are two separate projects. But since they have the same dependencies, being able to build Firefox implies being able to build Instantbird.
19:35:36 <nhnt11> flo-retina: Fixed it, never mind.
19:35:51 <nhnt11> Oh wait
19:35:55 <flo-retina> what was it?
19:37:13 --> Nirgali has joined #instantbird
19:37:58 * clokep_ is annoyed that Mibbit doesn't tell him the # of people in the room.
19:38:22 <nhnt11> Bah, maybe I should just do a clean build.
19:39:45 <nhnt11> I just completely deleted objdir/instantbird/* and rebuilt, and it's still saying "Could not read /path/to/ibConvStatsService.manifest"
19:39:59 --> Kaishi has joined #instantbird
19:40:29 <flo-retina> nhnt11: maybe touch the makefile?
19:42:24 <-- nhnt11 has quit (Ping timeout)
19:44:37 --> nhnt11 has joined #instantbird
19:45:15 <nhnt11> Obliterating instantbird/ and makefiles from objdir and doing make -f client.mk build now.
19:45:16 <nhnt11> Hopefully won't take too long.. :(
19:46:46 <-- Optimizer has quit (Quit: bbye :))
19:48:39 <flo-retina> I hope you didn't remove the makefiles from objdir/mozilla/
19:49:03 <flo-retina> (if you did you are likely going for a full build)
19:49:29 <nhnt11> flo-retina: Haven't touched mozilla
19:50:01 <nhnt11> This isn't getting over anytime soon, I'm going to upload a patch
19:50:05 <nhnt11> (And go to bed)
19:50:58 --> Optimizer has joined #instantbird
19:54:13 <nhnt11> flo-retina, Mic: Who should I specify as r= in the diff?
19:54:18 <nhnt11> Both of you? only flo? 
19:54:29 <-- flo-retina has quit (Ping timeout)
19:54:42 --> flo-retina has joined #instantbird
19:54:42 * ChanServ sets mode +qo flo-retina flo-retina 
19:55:16 <clokep_> nhnt11: Both.
19:55:30 * nhnt11 wonders about aleth too.
19:56:26 <-- flo-retina has quit (Ping timeout)
19:56:28 --> flo-retina has joined #instantbird
19:56:28 * ChanServ sets mode +qo flo-retina flo-retina 
19:57:10 <Mic> nhnt11: a new version of the patch in 2015 is coming?
19:57:17 <nhnt11> Mic: Yep.
19:57:22 <instantbot> nhnt11@gmail.com cancelled review?(benediktp@ymail.com ) for attachment 2547 on bug 2015.
19:57:23 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2550 on bug 2015.
19:57:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2015 enh, --, ---, nhnt11, NEW, Display buddy list in a tab.
19:58:02 <-- mib_hbqw0r has quit (Quit: http://www.mibbit.com ajax IRC Client)
19:58:09 <nhnt11> Mic: By the way, that interdiff utility you linked a while back is really useful, thanks!
19:58:29 <Mic> Cool, great that you like it. I'm using it too from time to time.
19:59:35 <nhnt11> Aaaah no, I renamed the files and did hg rm/hd add instead of just using hg mv.
19:59:42 * nhnt11 sighs.
20:00:55 <nhnt11> Mic: Were you in the middle of reviewing the previous patch? :(
20:01:03 * nhnt11 should have waited
20:01:08 <Mic> No, it's fine!
20:01:17 <nhnt11> Okay.
20:01:23 <Mic> I was just about to start. Sorry for blocking you with my reviews :(
20:01:42 <-- Nirgali has quit (Ping timeout)
20:01:42 <nhnt11> Not a problem
20:01:44 * Mic thinks we could spin off the status icon changes into a separate bug?
20:01:45 <flo-retina> Mic: mine aren't really faster ;)
20:02:01 * nhnt11 suggested that too.
20:02:07 <flo-retina> aren't they already included in the new patch?
20:02:10 <nhnt11> flo-retina: They are.
20:02:19 * clokep_ apparently has super fast reviews. :P
20:02:25 <flo-retina> Mic: I don't see the point of adding duplicated code to file a bug to remove it.
20:03:00 <flo-retina> clokep_: well, nhnt11 did put a few trivial patches in my queue that I could review in a reasonable amount of time, so that improves my average response time ;)
20:03:20 <clokep_> Just take a median. :)
20:03:20 <nhnt11> Oh no, I seem to have removed a newline between two methods in menus.js :'(
20:03:51 <Mic> flo-retina: there are rules being moved from conversation.css to status.css, nothing more.
20:04:20 <flo-retina> Mic: and instantbird.css now includes status.css
20:04:26 <Mic> Exactly.
20:04:45 <flo-retina> Mic: or do you mean we should do these changes in another bug, so that they can land _now_?
20:04:51 <Mic> Yes.
20:04:59 <flo-retina> ok
20:05:07 <nhnt11> Oh no :(
20:05:10 <flo-retina> I thought you meant it should be a follow up, which I didn't want
20:05:27 <flo-retina> nhnt11: :-P
20:05:44 <flo-retina> Mic: ok with me either way then
20:05:54 * nhnt11 looks at Mic hopefully
20:09:14 --> nhnt11_phone has joined #instantbird
20:10:21 <-- nhnt11 has quit (Ping timeout)
20:10:58 --> nhnt11 has joined #instantbird
20:11:12 <Mic> nhnt11: I think it would better to move the rules in a different bug (since the changes are self-contained) but I'd also create the patch for it if you like :)
20:11:35 <nhnt11> 01:40:02 - nhnt11: I need to sleep
20:11:35 <nhnt11> 01:40:23 - nhnt11: I'll be around for maybe ~10 minutes
20:11:43 <nhnt11> Mic: That's nice of you, thanks! :)
20:12:25 <nhnt11> So I'll re-diff excluding conversation.css status.css and instantbird.css..
20:14:15 <Mic> OK
20:15:31 <-- jb has quit (Ping timeout)
20:17:32 <nhnt11_phone> My laptop just powered off. :o
20:17:36 <-- nhnt11 has quit (Ping timeout)
20:17:50 <nhnt11_phone> It was plugged in and had been plugged in for a couple hours..
20:19:01 <nhnt11_phone> Rebooting.
20:19:50 --> Nirgali has joined #instantbird
20:22:42 --> nhnt11 has joined #instantbird
20:23:14 <instantbot> New Instantbird (UI) bug 2031 filed by benediktp@ymail.com.
20:23:20 <qheaden> clokep_: OK, I'm at a standstill now. I want to add creation of conferences, but there is no UI support for inviting users.
20:23:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2031 min, --, ---, nobody, NEW, Move rules for 16px status icons from conversation.css to status.css
20:23:38 <clokep_> qheaden: Can't you just create it and other people could join it?
20:23:44 <clokep_> Do they have to be invited?
20:24:03 <clokep_> qheaden: My inclination is to move on and work on another aspect for now though.
20:25:01 <qheaden> clokep_: I have to look more into conference creation. I'm not sure whether or not conferences have some sort of private setting or not. It would seem logical that they do.
20:25:29 <nhnt11> So.. I was about to pastebin a diff between the new newtab.xml and the old awesometab.xml for easier reviewing.
20:25:52 <clokep_> qheaden: You can use a command for now.
20:26:17 <nhnt11> Mic, flo-retina: http://pastebin.instantbird.com/237660
20:26:21 <nhnt11> aleth ^
20:28:03 <qheaden> clokep_: The official client doesn't have any options to join a conference. I think conferences are invite-only.
20:28:14 <clokep_> qheaden: OK.
20:28:16 <qheaden> This makes sense because they don't seem to have a privacy setting, so logically they would be private by default.
20:28:19 --> jb has joined #instantbird
20:28:55 <qheaden> So unless the ability to invite people is implemented, creating a conference is useless. So I will use a command like you said.
20:29:26 <clokep_> qheaden: Command works for now, sure. :)
20:30:12 <nhnt11> Oh noooo. My Instantbird workspace disk image is corrupte
20:30:14 <nhnt11> :'(
20:33:45 <-- flo-retina has quit (Ping timeout)
20:35:07 --> flo-retina has joined #instantbird
20:35:07 * ChanServ sets mode +qo flo-retina flo-retina 
20:35:16 <-- clokep_ has quit (Quit: http://www.mibbit.com ajax IRC Client)
20:37:11 <flo-retina> nhnt11: "So.. I was about to pastebin a diff between the new newtab.xml and the old awesometab.xml for easier reviewing." an attachment on the bug seems a better idea ;)
20:37:49 <nhnt11> Okay
20:41:06 <instantbot> nhnt11@gmail.com cancelled review?(aleth@instantbird.o rg) for attachment 2550 on bug 2015.
20:41:07 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2551 on bug 2015.
20:41:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2015 enh, --, ---, nhnt11, NEW, Display buddy list in a tab.
20:41:57 <-- jb has quit (Ping timeout)
20:43:22 * nhnt11 goes to bed.
20:43:24 <nhnt11> Good night.
20:43:43 <Mic> nhnt11: good night!
20:44:05 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
20:44:23 <-- nhnt11_phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
20:45:28 --> EionRobb has joined #instantbird
20:45:33 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.90 [Firefox 23.0/20130625125232])
20:45:39 --> jb has joined #instantbird
20:48:10 <-- jb has quit (Ping timeout)
20:53:02 <qheaden> Well, I must go now.
20:53:09 <qheaden> Thanks for all of the help.
20:54:35 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
20:57:36 <qheaden> Bye all.
20:58:37 <Mic> Bye!
20:58:48 <qheaden> Well, I have to change my nick since I want to be away on IRC, but available on other protocols. Oh well.
20:58:52 * qheaden is now known as qheaden_away
21:03:54 * flo-retina wonders if Mic is planning on fixing bug 2031 nowish
21:03:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2031 min, --, ---, nobody, NEW, Move rules for 16px status icons from conversation.css to status.css
21:04:11 <Mic> yes
21:04:29 <instantbot> benediktp@ymail.com granted review for attachment 2553 on bug 2031.
21:08:57 --> DGMurdockIII has joined #instantbird
21:18:03 <-- Nirgali has quit (Ping timeout)
21:18:49 --> Nirgali has joined #instantbird
21:24:50 --> jb has joined #instantbird
21:32:40 <-- Nirgali has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
21:39:49 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/dc24265eadf4 - Nihanth Subramanya - Bug 2031 - Move rules for 16px status icons from conversation.css to status.css, r=Mic
21:40:19 <instantbot> florian@instantbird.org set the Resolution field on bug 2031 to FIXED.
21:40:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2031 min, --, 1.5, nhnt11, RESO FIXED, Move rules for 16px status icons from conversation.css to status.css
21:54:11 <-- qlum has quit (Quit: Getting the <censored> out.)
21:55:43 <instant-buildbot> build #413 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/413
21:59:27 <-- jb has quit (Ping timeout)
22:07:34 <Mic> Good night
22:10:59 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
22:24:04 <-- flo-retina has quit (Ping timeout)
22:24:22 --> flo-retina has joined #instantbird
22:24:22 * ChanServ sets mode +qo flo-retina flo-retina 
22:42:46 --> Nirgali has joined #instantbird
23:14:31 --> dionisos has joined #instantbird
23:15:02 <-- atuljangra has quit (Ping timeout)
23:45:36 <-- Nirgali has quit (Connection reset by peer)
23:47:11 --> Nirgali has joined #instantbird
23:53:19 <instant-buildbot> build #432 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/432
23:54:28 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.90 [Firefox 23.0/20130625125232])