All times are UTC.
00:00:58 <instant-buildbot> build #421 of linux-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/421 00:05:11 <qheaden> clokep: I'm a bit confused on how to more cleanly define _packetHandlers. I don't think JS will allow this - http://pastebin.instantbird.com/226315 00:05:30 <clokep> qheaden: OK. 00:05:37 <qheaden> Yet, I don't want to use literals since we already have an enum for that. 00:05:47 <clokep> So do it with the [ ] notation then. 00:05:50 <clokep> It's just not as nice. :p 00:05:58 <qheaden> Sure isn't. :( 00:07:30 <qheaden> clokep: Or how about I just create the object right under the enum using the same literals. It will be easy to look at the enum right above to see what the service numbers are linked to. 00:07:54 <clokep> qheaden: Sounds reasonable. :) 00:08:17 <qheaden> Okay. I really want to avoid that [] notation. Especially since there will be many more handlers. 00:10:08 <-- wnayes has quit (Ping timeout) 00:12:40 <clokep> :) 00:13:36 --> wnayes has joined #instantbird 00:15:31 <qheaden> clokep: Should I place the packet handler functions as static methods in the YahooSession definition? Or just reference them using YahooSession.prototype (if that is even possible)? 00:17:41 <clokep> I'm not sure what you mean by "static methods". 00:19:02 <qheaden> Currently, the packet handlers are placed in the prototype of YahooSession. Can we access them using YahooSession.prototype? I know prototype is normally used for instance-based stuff. 00:19:35 <clokep> qheaden: Why can't you just access them as YahooSession.foo? 00:20:06 <clokep> qheaden: Can you type out an example? Sorry. 00:20:08 * clokep will be back soon. 00:21:25 <qheaden> clokep: I'm trying to define the packet handler list as a constant outside of the constructor. Can you access methods defined in YahooSession.prototype using just YahooSession.foo? 00:22:03 <clokep> qheaden: Yes, of course. 00:22:11 <clokep> It's just the prototype, every instance of it gets those properties. 00:22:35 * qheaden is showing his JavaScript inexperience. :) 00:26:40 <clokep> There's no such thing as a "static method" in JS. 00:30:40 <Mook_as> there is "random crap attached to the constructor that won't show up on the prototype change of instances", though? :D 00:31:54 <qheaden> This is a snippet of my code (dots indicate unrelated code). http://pastebin.instantbird.com/226332 00:32:10 <qheaden> I am now getting errors saying that the methods referenced in kPacketHandlers are undefined. 00:34:26 <Mook_as> needs to be 0xc6: YahooSession.prototype._handleStatusUpdatePacket 00:34:31 <Mook_as> also, needs to come after the prototype assignment 00:36:09 <clokep> qheaden: Oh. That's what you're trying to do. :-S 00:36:21 <qheaden> Mook_as: Thanks. 00:36:26 <clokep> In that case, yes you have to use .prototype. 00:36:46 * clokep doesn't particularly like that though. 00:36:58 <qheaden> clokep: Yeah. Doesn't look like it is going to work out as nicely as I thought if I have to move packetHandlers after YahooSession.prototype. 00:37:05 <clokep> Why can't those functions just be in kPacketHandlers? 00:37:26 <qheaden> clokep: Yeah, I can do that. 00:37:26 * Mook_as looks for the file in the hg repo 00:38:15 <qheaden> Mook_as: Are you looking for the file containing my code snippet? 00:38:25 <Mook_as> yeah, found it (wrong branch) 00:38:36 <qheaden> Mook_as: I didn't push yet. 00:38:50 <Mook_as> yeah, I just needed more context 00:38:54 <qheaden> Oh okay. 00:39:14 <Mook_as> it does look like just putting it in kPacketHandlers is sane (since the method is only referenced in YahooSession constructor, right?) 00:39:34 <Mook_as> oh, not anymore, right 00:40:07 <qheaden> The methods are referenced in YahooSession._onBinaryDataReceived. 00:40:19 <qheaden> It uses the service number of the packet as a lookup for the function. 00:41:05 * Mook_as would probably do YahooSession.prototype._packetHandlers = {}; YahooSession.prototype._packetHandlers[kPacketType.StatusUpdate] = function handleStatusUpdate(aPacket) {...} 00:41:12 <Mook_as> or something along those lines 00:42:18 <Mook_as> of course, I'm not writing this patch, nor am I reviewing it, so you might want to ignore what I think ;) 00:42:43 <qheaden> That looks like a good way of doing it. 00:43:03 <clokep> I disagree. 00:43:10 <clokep> I think it's cleaener to not be part of YahooSession. 00:43:14 <clokep> It's going to be a huge list of handlers. 00:43:17 <clokep> It's going to make the file massive. 00:44:02 <qheaden> clokep: Hmm. Think we need to split it into its own module? 00:44:03 <Mook_as> Ah, true. 00:45:58 <clokep> Not yet, but eventually....probably. 00:46:42 <qheaden> Well, we might as well do it now, because there are going to be a ton of handlers when this project is complete. 00:54:50 <dew> clokep, I feel like I'm never going to get to this :( 00:57:17 <-- Mook_as has quit (Quit: Mook_as) 01:02:28 <clokep> dew: Please let us know if you have questions, even if they're really silly. :) 01:05:50 <instant-buildbot> build #408 of win32-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/408 01:06:09 <dew> I'm just having problems getting started. It's more of a time/motivation issue 01:10:18 <clokep> dew: That I can't help you with. 01:10:35 <-- dew has quit (Ping timeout) 01:10:48 <qheaden> dew: Are you a GSoC student? 01:11:54 <qheaden> Oops. Didn't notice he left. :P 01:12:21 <clokep> qheaden: No, just a cool guy. 01:12:43 <qheaden> Oh okay. :) 01:15:53 --> dew has joined #instantbird 01:16:38 <qheaden> clokep: Well, I had a long day. I'm going to cut it right here and start again tomorrow. 01:17:10 <qheaden> Thanks for all of the help, advice, and feedback. :) 01:17:20 <-- FireFly_TB has quit (Ping timeout) 01:17:43 <clokep> qheaden: Slacker! :P 01:17:51 <clokep> Great job so far. :) Keep up the good work! 01:18:16 <qheaden> clokep: Yeah, i am a slacker. Yesterday started the coding period, and I haven't gotten much done. :P 01:18:49 <qheaden> I'm amazed at how much process nhnt11 and myself has made during the bonding period. :P 01:19:03 <clokep> Yup! :) 01:19:18 <clokep> Once you get some basic conversation support we'll have to figure out a way to start landing it! :) 01:19:46 <qheaden> Definitely. I estimate we should have conversation support by the end of this week, or early next week. 01:20:18 <clokep> I'd be happy w/ private conversations being supported by mid ot late next week, yes. :) 01:20:39 * qheaden is not looking forward to implementing group chat. :-S 01:21:24 <clokep> :) 01:21:29 <clokep> I expect it to take 1 - 2 weeks. 01:21:36 <clokep> And we'll have to do buddy icons, etc. 01:22:09 <qheaden> So after buddies, conversations (private and group), what features are left to implement? 01:22:12 * atuljangra was stuck with his own work in the community bonding period. Will try to catch up now. :S atuljangra hides in shame :( 01:22:33 <qheaden> atuljangra: You'll probably end up passing us by. :) 01:23:01 <atuljangra> qheaden: not sure of that :s, will try my best though. 01:23:01 <clokep> atuljangra: You've made some pretty good progress so far! :) Any luck looking at the backend today? 01:23:21 <clokep> qheaden: Well things like buddy icons, ensuring we're getting profiles, etc. 01:23:26 <clokep> File transfer. 01:23:30 <atuljangra> clokep: yes, I wanted to decide on the API for xep-0047. 01:23:46 <qheaden> clokep: Sounds good. 01:23:58 <qheaden> Well, I must go. Have a good day or night. 01:23:59 <clokep> qheaden: Probably some other ones. :) We'll need to see what libpurple supports. ;) 01:24:02 <clokep> Goodnight! 01:24:06 <clokep> atuljangra: Feel free to discuss if you want. 01:24:13 * qheaden is now known as qheaden_away 01:24:55 <atuljangra> clokep: Will do it after some sleep, it's 7 a.m. here, and I haven't slept yet :-/ 01:26:26 <clokep> :) 01:26:33 <clokep> You kids are all crazy. 01:27:02 <atuljangra> :s Plus I've my driving test today at 11 a.m. 01:27:05 <atuljangra> Wish me luck :) 01:27:18 <clokep> Good luck! :) 01:27:23 <atuljangra> :) 01:32:00 <-- skeledrew has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 01:33:01 * atuljangra is now known as atul_away 01:37:27 --> skeledrew has joined #instantbird 01:42:02 <-- atul_away has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 01:42:05 --> atul_away has joined #instantbird 01:42:08 <-- atul_away has quit (Quit: atul_away) 02:02:51 --> Mook has joined #instantbird 02:10:19 <-- wnayes has quit (Ping timeout) 02:13:45 --> wnayes has joined #instantbird 02:18:05 --> mconley has joined #instantbird 03:06:24 <-- chrisccoulson has quit (concrete.mozilla.org gravel.mozilla.org) 03:06:24 <-- EionRobb has quit (concrete.mozilla.org gravel.mozilla.org) 03:06:24 <-- Optimizer has quit (concrete.mozilla.org gravel.mozilla.org) 03:06:24 <-- Tonnes has quit (concrete.mozilla.org gravel.mozilla.org) 03:06:24 <-- dionisos has quit (concrete.mozilla.org gravel.mozilla.org) 03:06:24 <-- MMN-o has quit (concrete.mozilla.org gravel.mozilla.org) 03:06:24 <-- Even has quit (concrete.mozilla.org gravel.mozilla.org) 03:06:25 --> MMN-o has joined #instantbird 03:06:26 --> dionisos has joined #instantbird 03:06:30 --> Even has joined #instantbird 03:06:30 * ChanServ sets mode +o Even 03:06:34 --> EionRobb has joined #instantbird 03:06:36 --> Optimizer has joined #instantbird 03:06:41 --> chrisccoulson has joined #instantbird 03:07:17 --> Tonnes has joined #instantbird 03:10:44 <-- wnayes has quit (Quit: wnayes) 03:15:19 <instant-buildbot> build #884 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/884 03:18:02 <clokep> Woo, nightly builds are back! 03:21:04 <-- Optimizer has quit (Ping timeout) 03:24:38 --> Optimizer has joined #instantbird 03:30:51 <instant-buildbot> build #876 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/876 03:48:49 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 03:48:51 <-- mconley has quit (Input/output error) 03:55:39 --> mconley has joined #instantbird 04:01:31 <-- mconley has quit (Input/output error) 04:46:32 <-- Nirgali has quit (Ping timeout) 05:08:59 <-- dionisos has quit (Ping timeout) 05:43:41 --> jb has joined #instantbird 06:00:31 --> nhnt11_phone has joined #instantbird 06:01:21 <nhnt11_phone> I wont be available till tonight :( 06:01:45 * nhnt11_phone hasn't slept and is sitting at an IMAX watching man of steel 06:02:32 <nhnt11_phone> I'll probably sleep after getting home but i hope to get some work done after that :) 06:02:44 <-- nhnt11_phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com )) 06:05:11 <-- EionRobb has quit (Ping timeout) 06:09:41 <instant-buildbot> build #979 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/979 06:11:13 <-- jb has quit (Ping timeout) 06:15:29 --> wuwei has joined #instantbird 07:01:09 <-- Mook has quit (Ping timeout) 07:04:50 --> Mook has joined #instantbird 07:12:51 --> Nirgali has joined #instantbird 07:25:45 --> gerard-majax has joined #instantbird 07:36:14 --> EionRobb has joined #instantbird 07:42:40 <-- Nirgali has quit (Ping timeout) 07:47:01 <-- Mook has quit (Quit: Mook) 08:00:25 --> aleth has joined #instantbird 08:01:25 * aleth is now known as IRCMonkey56134 08:03:39 --> novabyte has joined #instantbird 08:05:39 <instantbot> aleth@instantbird.org granted review for attachment 2492 on bug 1554. 08:05:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1554 nor, --, 1.5, aleth, RESO FIXED, IRC should notify the user when messages couldn't be sent 08:17:01 --> nhnt11_phone has joined #instantbird 08:24:21 <-- nhnt11_phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com )) 08:34:28 <-- IRCMonkey56134 has quit (Quit: Ciao) 08:34:36 --> aleth has joined #instantbird 08:35:36 * aleth is now known as IRCMonkey8746 08:36:43 * IRCMonkey8746 is now known as aleth 08:42:25 <aleth> Wow, tons of gsoc progress :) 08:53:12 --> flo-retina has joined #instantbird 08:54:29 <-- aleth has quit (Quit: Ciao) 08:54:36 --> aleth has joined #instantbird 08:56:15 --> jb has joined #instantbird 08:57:04 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 08:57:55 <-- jb has quit (Ping timeout) 08:58:33 <-- aleth has quit (Quit: Ciao) 08:58:37 --> aleth has joined #instantbird 08:58:37 * ChanServ sets mode +h aleth 08:58:44 --> flo-retina has joined #instantbird 08:59:39 * flo-retina would like to know why he isn't identified and nickserv yells at him 09:00:14 * aleth would like to know too :( 09:01:23 <EionRobb> did you and nickserv have a falling out? 09:01:27 <EionRobb> did you stop returning her calls? 09:01:35 <-- aleth has quit (Quit: Ciao) 09:01:46 --> aleth has joined #instantbird 09:03:12 <EionRobb> did you hesitate just that fraction of a second too long when she asked if you've been connecting to other irc servers? 09:05:37 <flo-retina> aleth: ah, you have the same problem? 09:05:42 <aleth> flo-retina: Yes 09:06:14 <flo-retina> alright, maybe it's just the network that's broken then 09:07:06 <instantbot> aleth@instantbird.org granted feedback for attachment 2489 on bug 426. 09:07:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 09:07:45 <flo-retina> "flo has already covered all the things I wanted to say (and more)" cheater :-P 09:07:47 <flo-retina> :) 09:08:27 <aleth> Well, it wasn't my first look at that patch either ;) 09:08:39 <aleth> But thanks :D 09:08:49 <flo-retina> np :-P 09:10:00 <aleth> The debug log doesn't look like there is anything broken on our end for auth, and I can't see how the IRC patch that landed the other day would affect it anyway 09:10:30 --> Mic has joined #instantbird 09:10:59 * Mic is now known as Mic2 09:11:02 * Mic2 is now known as Mic 09:11:57 <flo-retina> aleth: when I disconnected and reconnected to see if it would fix the issue, it failed with this log: http://pastebin.instantbird.com/226694 09:12:11 <flo-retina> Is there any reason why we are sending stuff before 'onStartRequest'? 09:12:38 <flo-retina> or is onStartRequest fired only once we have actually sent or received something in the socket? 09:13:05 <aleth> Hmm, I don't know offhand 09:13:31 <Mic> Same problem here. 09:14:29 --> jb has joined #instantbird 09:18:59 <Mic> nhnt11: sorry, that I haven't reviewed the patch in bug 426 yet, I was very busy the last few days. Thanks flo for doing that... 09:19:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 09:19:55 <flo-retina> Mic: would be nice if you could have a look today to indicate if you have more comments or if nhnt11 should go ahead and update the patch 09:20:47 <flo-retina> (although I'll likely still have some comments on the next iteration, but I expect them to be minimal :)) 09:22:04 <flo-retina> would be nice if we could land that and bug 2002 this week :) 09:22:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2002 enh, --, ---, nhnt11, NEW, Add an /about command to open the about:* pages 09:33:44 <-- EionRobb has quit (Quit: Leaving.) 09:54:38 <-- jb has quit (Ping timeout) 09:58:24 <-- gerard-majax has quit (Ping timeout) 10:04:11 --> mpmc has joined #instantbird 10:04:19 --> clokep has joined #instantbird 10:04:19 * ChanServ sets mode +o clokep 10:12:32 <Mic> flo-retina: how strict do we have to be with the line length limit in bindings? I think the line breaks don't make the code more readable in e.g. http://pastebin.instantbird.com/226748 10:13:49 --> jb has joined #instantbird 10:13:51 <Mic> Imo the JS code in bindings suffers from the fact that it has like 15 characters of indentation by default... 10:14:53 <-- Optimizer has quit (Ping timeout) 10:15:32 --> Optimizer has joined #instantbird 10:17:21 <-- Optimizer has quit (Ping timeout) 10:17:42 --> Optimizer has joined #instantbird 10:18:14 * clokep agrees. 10:24:48 <clokep> aleth: FYI My comment on BitBucket was "can this function return multiple tags" 10:24:53 <clokep> I.e. can a buddy be created with multiple tags. 10:25:01 <clokep> I know they can definitely /have/ multiple tags. 10:26:04 <-- jb has quit (Ping timeout) 10:27:48 --> gerard-majax has joined #instantbird 10:28:05 <aleth> clokep: Ah OK... was just a drive-by comment ;) 10:29:16 <clokep> OK. :) 10:30:15 <flo-retina> Mic: I don't care strongly either way. If we removed line breaks, we would likely want to shorten some variable names though. 10:33:29 <flo-retina> clokep: I miss the context about "can this function return multiple tags", but I may have some answers 10:34:56 <-- Optimizer has quit (Ping timeout) 10:36:28 <clokep> OK. :) 10:42:57 <Mic> nhnt11: I have a few (not many) comments on the patch, I'll be back ~ 7pm UTC and post them then (I need to go to work now). 10:43:09 <Mic> bye! 10:43:32 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 10:45:05 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 10:45:12 --> clokep has joined #instantbird 10:45:12 * ChanServ sets mode +o clokep 10:45:37 --> Optimizer has joined #instantbird 10:45:39 <flo-retina> ah, clokep is +o :-) 10:45:49 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 10:46:03 <clokep> flo-retina: I have a feeling services were screwed up for a bit. 10:47:27 <-- Optimizer has quit (Ping timeout) 10:47:28 --> flo-retina has joined #instantbird 10:47:46 --> Optimizer has joined #instantbird 10:47:53 <flo-retina> bah, disconnecting and then reconnecting results in http://pastebin.instantbird.com/226768 a few times, then http://pastebin.instantbird.com/226769, and finally it reconnects just fine. 10:47:55 <flo-retina> nickserv is still unhappy though 10:48:12 * clokep wonders if you're on gravel and I'm on conrete. 10:48:18 <flo-retina> clokep: seems likely 10:48:52 <flo-retina> I saw something yesterday about IT people moving gravel from the amsterdam mozilla data center to AWS, and that not working as expected 10:50:03 <clokep> Seems reasonable. 10:50:16 <-- Optimizer has quit (Input/output error) 10:50:20 <clokep> Concrete has been having a lot of netsplits too. Phoenix has been having issues? 10:50:21 --> Optimizer has joined #instantbird 10:50:44 <clokep> FYI I'll be offline tonight -- having a few friends over. 10:50:52 <flo-retina> don't you automatically see a netsplit on concrete if gravel goes down? 10:51:20 <clokep> Netsplits are when both are online but the pipe between them breaks. 10:51:56 <flo-retina> hmm 10:52:10 <clokep> But I've seen concrete2.mozilla.org come up. ;) 10:52:51 <-- Optimizer has quit (Input/output error) 10:53:55 --> Optimizer has joined #instantbird 10:56:25 <-- Optimizer has quit (Input/output error) 10:56:29 --> Optimizer has joined #instantbird 10:58:27 <-- novabyte has quit (Quit: bye bye) 11:02:31 <-- clokep has quit (Ping timeout) 11:20:31 <-- aleth has left #instantbird () 11:20:35 --> aleth has joined #instantbird 11:20:36 * ChanServ sets mode +h aleth 11:29:03 --> novabyte has joined #instantbird 11:45:15 * qheaden_away is now known as qheaden 11:46:11 <qheaden> Hello everyone! 11:54:06 --> clokep_work has joined #instantbird 11:54:55 <clokep_work> flo-retina: Nickserv didn't work for me this time. :-S 11:55:32 * clokep_work is on gravel this time. 11:57:39 <-- mpmc has quit (Connection reset by peer) 12:02:56 --> dionisos has joined #instantbird 12:04:26 <clokep_work> Hmm...gravel must not have SASL set up? 12:05:04 * clokep_work would love to see what's in his "204 messages omitted" 12:20:55 --> jb has joined #instantbird 12:25:27 <clokep_work> qheaden: So what's today's plan again? 12:26:09 <qheaden> clokep_work: Well, I plan on implementing the feedback you have given me over the last two patches. 12:26:39 <qheaden> I also want to start work on being able to accept buddy requests from other people. 12:26:52 <qheaden> I'm still on the fence as to how I should setup these packet handlers. 12:31:54 <clokep_work> OK. 12:32:00 <clokep_work> Let me know if you want to discuss something. 12:33:40 <qheaden> OK. 12:34:32 --> mpmc has joined #instantbird 12:34:36 <clokep_work> qheaden: Don't get too caught up in organizing the handlers, we can always reorganize them later. :) (It'll be annoying, but should only take an hour or so.) 12:35:17 <instantbot> aleth@instantbird.org granted feedback for attachment 2490 on bug 631. 12:35:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=631 enh, --, ---, nobody, NEW, Filtering buddy list 12:35:55 <qheaden> clokep_work: Here's what I was thinking. What about I create a YahooPacketHandler object in yahoo-session.jsm, and use an instance of that object to handle incoming packets? 12:36:11 <qheaden> Of course it will have a reference to the session object itself. 12:37:03 <clokep_work> qheaden: Why do you need an instance of it? 12:38:03 <qheaden> clokep_work: Well, I guess it can be non-instance. We can still use call() on it to change "this" right/ 12:38:04 <qheaden> ? 12:38:12 <clokep_work> qheaden: I'd suggest doing YahooPacketHandler[foo].call(this, blah) or something like that. 12:38:19 <clokep_work> qheaden: Yes, exactly. 12:38:30 <qheaden> Okay great. I'll go with that design. It's cleaner. 12:38:47 <qheaden> You have to excuse me. I keep forgetting the flexibility of JS compared to C++. :P 12:39:19 <clokep_work> There's no reason to apologize. :) 12:39:30 <clokep_work> Just don't be insulted if I think some of the things you say are crazy. :P 12:40:09 <qheaden> :P 12:44:55 --> atuljangra has joined #instantbird 12:45:08 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client) 12:48:45 <qheaden> clokep_work: Should the handler functions within YahooPacketHandler be named or anonymous? 12:49:10 <qheaden> The packet service numbers will tell you what kind of packet is being handled. 12:50:31 <clokep_work> qheaden: anon is fine. 12:50:43 <qheaden> OK. 12:59:23 <qheaden> clokep_work: What do you think of this - http://pastebin.instantbird.com/226856 13:00:16 <clokep_work> qheaden: Looks OK, what is keyValuePairs? 13:00:45 <qheaden> clokep_work: That comes from the packet. 13:01:05 <qheaden> Some packets require me to manually iterate over the key values instead of just grabbing them with getValue/getValues. 13:01:17 <qheaden> Its the way Yahoo! organizes some things. 13:02:16 * clokep_work isn't sure he understands. 13:02:20 <clokep_work> But the organization is fine, yes. 13:02:51 <clokep_work> I have a meeting. 13:03:40 <qheaden> clokep_work: Just so you know, packet 0xc6 is the friends/groups list. They place multiple friends under different groups, but you have to iterate over the key values so you know when one group ends and another begins. 13:03:53 <qheaden> Guess I'll add a comment on that. :) 13:04:27 <clokep_work> qheaden: I'm wondering if we can decompose the packet in a smarter way. 13:04:59 <clokep_work> E.g. can we make a map of all keys that contain an array of values? 13:05:33 <qheaden> clokep_work: I did something similar to that for packet 0xf0. 13:06:11 <qheaden> Bug because the groups can have different numbers of friends, iteration is required; even to just split things up. 13:13:38 <clokep_work> Why? 13:14:59 <aleth> qheaden: It's unfortunate in the 0xf0 handler that you get the data in the form of three separate arrays 13:15:58 <aleth> Is that just how the protocol is structured? 13:17:01 <qheaden> aleth: I did it that way to prevent iteration. 13:17:13 * qheaden needs to post a paste of the key/value structure. 13:24:23 <qheaden> aleth, clokep_work: Here is a list (0xc6) packet from Yahoo! I replaced my real friend usernames with friend_*_username. http://pastebin.instantbird.com/226877 13:24:45 <qheaden> To the left of the colon is a key, and the right is the value. 13:27:55 <aleth> qheaden: Btw don't use for...in to iterate over an array when order is important 13:28:20 <qheaden> aleth: Just use a normal for loop? 13:28:36 <aleth> qheaden: Yes 13:28:48 --> rosonline has joined #instantbird 13:29:00 <aleth> (Or iterate over the values if that's more convenient, with for...of) 13:29:24 <aleth> qheaden: See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...in 13:30:19 <qheaden> OK. Thanks. 13:30:28 <aleth> If the repeated keys in the packet consistently arrive in groups that belong together, can't they be parsed together? 13:31:29 <aleth> i.e. rather than getting "all the 7's" etc and then in a second step piecing the buddy data back together, do it in one 13:33:53 <qheaden> I guess so. 13:34:47 <clokep_work> Maybe I'm misunderstand the way the packet is set up though. 13:35:00 <qheaden> But how will the correct group be determined without any iteration? There is no 1-to-1 connection between group keys and the username keys. 13:35:41 <qheaden> The only way to determine the group is the know which group value came before the username value. 13:35:41 * clokep_work thinks he doesn't understand how the packet is done. 13:35:46 <clokep_work> ANd that pastebin is gobbly gook to me. :) 13:36:02 <qheaden> Yeah. Yahoo! just has weird packets. 13:36:06 <qheaden> libpurple uses iteration also. 13:36:09 <clokep_work> qheaden: Is a packet something like: "Group Name", "user 1", "user 2", "Group 2", "user 3", "user 4" 13:36:16 <qheaden> clokep_work: Yup. 13:36:36 <clokep_work> I misunderstood, I thought it was "group 1", "user 1", "group 1" , "user 1", group 2', "user 3", group 2, user 4 13:36:55 <qheaden> Oh how I wish it was that way. :( 13:37:10 * clokep_work has something against switch statements though... 13:37:14 <-- jb has quit (Ping timeout) 13:37:14 <aleth> qheaden: But doesn't that imply you should parse the thing not by key/value, but in blocks? 13:37:28 <-- clokep_work has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 13:37:31 <aleth> (And then within each block each key only appears once and you do key/value) 13:38:21 <qheaden> aleth: In each block, a key can appear more than once. For example, in one group block, key 7 appears for each username. 13:39:25 <aleth> But if I understand correctly, the package looks something like (for all groups) (for all buddies in the group) (data for that buddy) 13:40:55 <qheaden> Yes, you can say that. 13:41:38 <aleth> Wouldn't it make sense to parse it that way then? 13:42:27 <aleth> So you don't get three separate arrays (eg) that you then have to reassemble into buddies. 13:42:53 <aleth> But I don't know the structure of your surrounding code, so take it with a grain of salt ;) 13:43:48 <qheaden> aleth: Although we aren't following libpurple, but making our own implementation, here is how libpurple handles it. http://lxr.instantbird.org/instantbird/source/purple/libpurple/protocols/yahoo/libymsg.c#494 13:45:06 --> jb has joined #instantbird 13:47:23 --> clokep_work has joined #instantbird 13:47:25 <qheaden> I'll continue to investigate some possible ways of splitting things up in groups (I'm not a fan of the interation + switch code myself). But I will work on that a little later. 13:48:35 <clokep_work> qheaden: I think the way you're doing it OK is right now. You get a full list of blocks and then parse them one by one. 13:48:43 --> mconley_ has joined #instantbird 13:49:20 <qheaden> Okay. Later on, once buddy support is complete, I'll see if I can possibly split things up by grouping keys. 13:49:47 * mconley_ is now known as mconley 13:51:39 <aleth> My worry with something like the code in 0xf0 is that the code assumes that the three arrays buddyNames, buddyStatuses, statusMessages have the same length. That's probably always the case but... 13:55:00 <clokep_work> aleth: You just need to cehck for that afterward and throw errors. 13:59:57 <aleth> clokep_work: Or maybe make getValues in these cases not return arrays, but instead yield return values as long as there are more? 14:00:46 <aleth> Then you could just do (while (more return values) handleasinglebuddy) 14:05:53 <clokep_work> That's reasonable. 14:05:59 <clokep_work> As is is good now. 14:06:02 <clokep_work> As is is OK! 14:06:10 <aleth> Sure, it works :) 14:06:30 <aleth> Idk how widespread this pattern is / if it's worth spending time on that kind of polish 14:10:24 --> Nirgali has joined #instantbird 14:10:38 <qheaden> Next year's GSoC project: Send a student to Yahoo! and convince them to change their protocol or use open standards. :P 14:11:00 <aleth> Solve the problem at the source :P 14:11:41 <qheaden> Plan B: Give ownership of Yahoo! to clokep_work and flo-retina. 14:12:05 * aleth worries about instantbidr 14:12:30 <qheaden> aleth: Yahoo Bird Messenger. :P 14:15:19 <clokep_work> Let's just keep moving along for now. 14:25:35 * qheaden wonders where nhnt11 is. 14:26:13 <-- jb has quit (Ping timeout) 14:28:50 <-- aleth has quit (Quit: Ciao) 14:33:44 --> qlum has joined #instantbird 14:37:28 * flo-retina wonders what qheaden wants him to own :-S 14:42:32 <qheaden> So when using a for...in or for...each loop, let should come before the variable name? 14:47:13 <clokep_work> qheaden: Yes. 14:47:22 <clokep_work> You have to define the variable, just like in C++. 14:47:29 <qheaden> ok 14:48:30 <flo-retina> aleth: that trick in https://msujaws.wordpress.com/2013/06/11/animating-and-transitioning-displaynone-elements/ is awesome. Makes me want to rewrite some of the blist transitions we have to drop half the code :-] 14:48:46 <clokep_work> qheaden: You can store the account name other place.s 14:48:52 <clokep_work> You just shouldn't store the password. 14:49:26 <qheaden> clokep_work: I thought it would be cleaner to manage the username from one location, since the protocol requires stripping @yahoo.com. 14:51:59 <clokep_work> qheaden: OK, just wasn't sure if that was in response to my comment. 14:53:22 <-- mpmc has quit (Connection reset by peer) 14:59:59 <-- rosonline has quit (Client exited) 15:09:19 <qheaden> clokep_work: What are some issues a map fixes versus an object + hasOwnProperty()? 15:10:25 <clokep_work> qheaden: hasOwnProperty is a security risk if you use carefully crafted names. 15:10:54 <qheaden> Oh okay. 15:11:12 <clokep_work> qheaden: I.e. if you're buddies name is __proto__ it can screw things up. 15:12:04 --> jb has joined #instantbird 15:14:18 <clokep_work> qheaden: Let me know if that doesn't make sense . 15:14:41 <qheaden> clokep_work: Oh no, it makes perfect sense. 15:14:51 <flo-retina> clokep_work: but we still use Object.prototype.hasOwnProperty, don't we? ;) 15:14:53 <qheaden> Maps are iterable with for..each..in right? 15:15:14 <-- jb has quit (Quit: jb) 15:15:25 <clokep_work> flo-retina: Yes, we do. 15:15:32 <clokep_work> flo-retina: Well. I don't think qheaden's code did. 15:15:48 <clokep_work> qheaden: Maybe? Look at MDC's documentation. 15:16:08 --> jb has joined #instantbird 15:25:04 * qheaden isn't seeing how to iterate over a map. 15:26:11 <clokep_work> It's iterable. 15:26:21 <clokep_work> According to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map 15:27:18 <qheaden> I saw that, but I'm testing it out in ScratchPad on Firefox, and the for...in and for...each...in loops don't seem to be working. 15:27:21 <clokep_work> qheaden: http://pastebin.instantbird.com/226976 15:27:27 <clokep_work> qheaden: for of 15:27:41 <qheaden> Ahh okay. 15:27:49 * qheaden is confused by the array of for loops. 15:28:35 <clokep_work> for in gives you the keys, for each in gives you the values, but is deprecated. 15:28:39 <clokep_work> for of iterates anything that is iterable. 15:28:44 <clokep_work> for in only works on objects, IIRC> 15:28:53 <clokep_work> There's an MDN article somewhere about this. 15:29:48 <qheaden> OK, thanks. But if for each in is deprecated, should I be using it in my code? 15:31:34 <clokep_work> It's fine. We use it all over the place already. 15:31:37 <clokep_work> There's no plans to take it out. 15:31:52 <qheaden> OK. 15:33:52 <-- jb has quit (Ping timeout) 15:46:22 --> jb has joined #instantbird 15:53:51 <-- jb has quit (Ping timeout) 16:00:21 * qheaden is now known as qheaden_away 16:13:55 * qheaden_away is now known as qheaden 16:34:01 <qheaden> clokep_work: Is this the correct way to iterate over a map? http://pastebin.instantbird.com/226997 16:34:24 <qheaden> This code doesn't seem to be working. It is saying that there is no method setStatus. 16:35:51 --> atuljangra has joined #instantbird 16:38:07 <atuljangra> Good Evening :-) 16:38:25 <qheaden> Hi atuljangra. :) 16:39:45 <clokep_work> qheaden: When you run into things like this, the first thing you should do is print out what buddy is. 16:40:05 <atuljangra> weird. XMPP works on TCP ports. There are at max. 65k TCP ports possible. So, hypothetically, if I've only one server then I can allow only 65k users. :-/ 16:40:05 <clokep_work> buddy[0] is the key, buddy[1] is the buddy, in this case. 16:40:16 <qheaden> clokep_work: When I print it, I get key,object. Of course with the correct names. 16:40:24 <qheaden> Ahh okay. 16:40:30 <atuljangra> Hi qheaden :-) 16:41:42 --> Mook_as has joined #instantbird 16:43:34 <atuljangra> clokep_work: We can discuss the API whenever you want. Pretty much ready to implement. 16:45:08 <clokep_work> flo-retina: Ping 16:47:01 <atuljangra> clokep_work: What are your views about this: XMPP works on TCP ports. There are at max. 65k TCP ports possible. So, hypothetically, if I've only one server then I can allow only 65k users. 16:47:29 <flo-retina> I'm vaguely around (trolling a bit on the current talkilla development process ;)) 16:48:46 <clokep_work> atuljangra: I don't know what that has to do with this conversation. :( 16:50:27 <atuljangra> clokep_work: no no, nothing to do. Just asking. 16:50:39 <clokep_work> That seems reasonable, sure. 16:51:25 <qheaden> What utilities are provided for handling friend requests? 16:51:43 <clokep_work> One of the interfaces should handle it. 16:51:47 <clokep_work> Did you look through them? 16:52:31 <qheaden> I'm looking through them now trying to find something. 16:52:32 <atuljangra> clokep_work: so does, every organization, that runs on some xmpp api, has to have one server per 65L users? Is it feasible for a normal start-up or some small company? 16:52:50 * atuljangra wonders if it's okay to have such discussions here :s 16:53:40 --> jb has joined #instantbird 16:54:57 <clokep_work> atuljangra: I have no idea. 16:55:19 <atuljangra> clokep_work: okay :) 16:56:36 <clokep_work> I don't pretend to understand how networking works. 16:56:52 <clokep_work> atuljangra: I think we should discuss the interface you hope to add. What are your thoughts on it? 16:57:36 <qheaden> clokep_work: I guess this is the method to use: http://lxr.instantbird.org/instantbird/source/chat/protocols/xmpp/xmpp.jsm#855 16:58:35 <atuljangra> clokep_work: Basically whenever user wants to send a file, we need to create and IBB connection, and then there will be interactions between the two contacts and then we'll send the file and close the connection. 16:59:03 <clokep_work> qheaden: Looks like it, it's possible this should be abstracted to jsProtoHelper btw. 16:59:29 <qheaden> Yeah. 16:59:33 <clokep_work> atuljangra: OK, that's how it acts from an XMPP point of view, but what do we need to add to our interfaces? (Does that quesiton make sense or do I need to explain?) 16:59:59 <atuljangra> clokep_work: an explanation is always nice ;) 17:01:59 <clokep_work> atuljangra: The UI has to interact with the prpl backend code somehow, this is done via a bunch of "interfaces" which are defined in the idl files qheaden keeps looking at. 17:02:12 <clokep_work> We need to add something to this such that we can start, accept, stop, etc. file transfers. 17:02:41 <atuljangra> Oh okay. So what would you suggest for the same? 17:03:05 <clokep_work> That was my question for you. :) 17:03:48 <atuljangra> heh okay. 17:05:29 <atuljangra> So, we can have some function to start, accept, stop, restart, 17:05:38 <atuljangra> reject 17:06:01 <atuljangra> we can have these functions in idl files, and backend-ish stuff can be implemented separetely. 17:06:25 <clokep_work> atuljangra: My guess is that you want an interface which is a file transfer, that can then have things to stop, resume, etc. And you'll want someway to start them via the account or the buddy or something. 17:07:41 <atuljangra> Okay, so we should have a separate interface called filetransfer, which is initiated/started via the xmpp account? 17:07:58 <clokep_work> I don't know for sure. 17:08:06 * clokep_work was hoping flo-retina would chime in... 17:08:53 <atuljangra> clokep_work: Can you point at some example where I can see more about this, so that we can have a rigid interface? 17:09:42 <clokep_work> atuljangra: http://lxr.instantbird.org/instantbird/source/chat/components/public/imIAccount.idl 17:09:49 <clokep_work> Everything in /public is an interface. 17:10:00 <atuljangra> Yes, same as TB :) 17:11:43 <atuljangra> So should I be creating a new imFilelink.idl, which contains interfaces for stopping, resuming, re-starting? 17:12:05 <atuljangra> And Accept and start should be different, as these are initiatos. 17:12:18 <atuljangra> s/initiatos/initiators. 17:13:00 <qheaden> clokep_work: Will my prpl need to be explicitly interfaced with atuljangra's code when I start adding file transfer support? 17:13:09 <qheaden> It will things happen automatically. 17:14:42 <flo-retina> clokep_work, atuljangra: I was somehow hoping that some existing interfaces from the mozilla platform could be reused (and maybe extended) 17:16:15 <-- gerard-majax has quit (Ping timeout) 17:16:48 <atuljangra> flo-retina: hmm, seems good. Lemme see when we can do. 17:23:08 <clokep_work> qheaden: For native Yahoo support, of course. 17:24:13 * atuljangra wonders if flo-retina have anything specific in mind, related to the interface. 17:24:29 <clokep_work> flo-retina: Really? For starting a file xfer? That would surprise me. 17:37:55 <qheaden> So it looks like you can chat with people on Yahoo without adding them to your contacts. 17:38:09 <atuljangra> ^Weird. 17:45:02 <clokep_work> qheaden: Yes, you can. 17:45:15 <clokep_work> ALmost all protocols allow that. 17:45:18 --> FireFly_TB has joined #instantbird 17:46:29 <qheaden> From what I see, a buddy authorization request is sent whenever a person wants to chat, or whenever a person adds you as a contact. If a person just wants to chat, should Ib automatically add that person to your contact list if you accept? 17:46:38 <qheaden> It doesn't seem to make sense to do that. 17:47:18 <clokep_work> qheaden: "From what I see' where? 17:47:26 <clokep_work> We shouldn't be requesting that if the person just wants to chat. 17:47:48 <qheaden> clokep_work: I see it from Wireshark. 17:48:01 <qheaden> Actually, scratch what I just said. 17:48:10 <qheaden> I did a friend request, not a random chat. Sorry. :P 17:48:30 * qheaden is getting confused dealing with multiple accounts. 17:48:37 <-- mconley has quit (Connection reset by peer) 17:48:50 <clokep_work> qheaden: No problem. :) 17:48:57 --> mconley has joined #instantbird 17:58:36 --> gerard-majax has joined #instantbird 18:01:52 <-- flo-retina has quit (Ping timeout) 18:07:18 <-- mconley has quit (Connection reset by peer) 18:07:33 --> mconley has joined #instantbird 18:08:07 <-- FireFly_TB has quit (Input/output error) 18:23:41 <qheaden> What should be the default tag when a buddy is added after granting a friend request? "Friends"? 18:24:13 <qheaden> The packets don't seem to give any group information with requests. I guess they leave that up to the client. 18:27:33 * qheaden got buddy requests working. 18:30:04 <clokep_work> qheaden: Use whatever libpurple uses, I guess? 18:30:15 <qheaden> ok 18:47:16 * atuljangra is still searching for a way to extend some existing interfaces for File transfer :s 18:50:31 <clokep_work> atuljangra: Where have you looked? 18:50:44 <clokep_work> I really don't know what you'd be able to expand. 18:51:41 <atuljangra> clokep_work: just looking at all the interfaces IB has. no success till now. I should look at some Mozilla interfaces too. 18:52:08 <atuljangra> clokep_work: Can TB implementation for file transfer be of any help here? Just curious. 18:52:48 <clokep_work> atuljangra: None of the IB interfaces would do what you want. florian suggested looking at the Mozilla ones. 18:52:57 <clokep_work> atuljangra: It could potentially. 18:53:05 <clokep_work> I've never really looked at their FileLink stuff. 18:53:58 <atuljangra> clokep_work: yes, so now I'm looking at the interfaces of filelink in TB. 18:54:24 <clokep_work> Link? 18:54:40 <atuljangra> just a sec 18:56:57 <-- novabyte has quit (Quit: bye bye) 18:57:11 <atuljangra> http://mxr.mozilla.org/comm-central/source/mail/components/cloudfile/ specifically: http://mxr.mozilla.org/comm-central/source/mail/components/cloudfile/nsIMsgCloudFileProvider.idl 18:57:12 <clokep_work> It looks like you could take some inspiration from http://mxr.mozilla.org/comm-central/source/mail/components/cloudfile/nsIMsgCloudFileProvider.idl but I don't think it's usable. 18:58:01 <atuljangra> Hmm, I guess creating a new one is the only option here, until flo-retina comes up with another way to do this. 19:00:51 <clokep_work> Yeah. 19:01:10 <clokep_work> I would take a whack at a filetransfer idl like that, we can then talk about how that would get called. 19:01:25 <atuljangra> ok :) 19:02:34 <-- jb has quit (Ping timeout) 19:04:54 --> mpmc has joined #instantbird 19:09:51 --> unghost has joined #instantbird 19:13:46 <-- Optimizer has quit (Ping timeout) 19:17:27 <atuljangra> clokep_work: but still, where should I put send and accept? 19:19:12 --> Mic has joined #instantbird 19:19:54 <clokep_work> atuljangra: I'm not sure what you're asking. 19:21:04 <atuljangra> clokep_work: While defining interfaces, we cannot have "start" and "accept" as a part of filelink interface. They should be interfaced somewhere else, like buddy, or account. So where should it be? 19:21:42 <clokep_work> atuljangra: I don't know, I think i asked you that earlier. 19:21:51 <clokep_work> The three places that seem reasonable are: buddy, account and conversation. 19:22:19 <clokep_work> Starting it from an account or a conversation would mean it would need to have the name or something to send it to. 19:22:42 <atuljangra> clokep_work: Yes, I just wanted to discuss. I guess I would go with account for now. 19:22:59 <clokep_work> atuljangra: So...I think probably the account? Kind of like http://lxr.instantbird.org/instantbird/source/chat/components/public/imIAccount.idl#69 ? 19:23:39 <atuljangra> clokep_work: Yes, I was thinking the same, that should do. 19:24:48 --> Optimizer has joined #instantbird 19:26:32 <clokep_work> :) 19:28:05 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client) 19:29:51 --> atuljangra has joined #instantbird 19:30:20 * clokep_work wonders if Mic will have time to finish that review tonight :) 19:31:50 <-- Optimizer has quit (Connection reset by peer) 19:34:07 <Mic> clokep_work: that's why I'm here 'early' tonight :) 19:39:04 <Mic> qheaden, clokep_work: what's the thing with "since the protocol requires stripping @yahoo.com" if I may ask? 19:39:05 <clokep_work> Ah-ha! Then don't let me interrupt you. 19:39:20 <clokep_work> Mic: You don't log into Yahoo with foo@yahoo.com, you use just foo. 19:39:41 <qheaden> clokep_work: Yahoo pager servers will give a login error if @yahoo.com is included in the username. 19:39:41 <Mic> So that applies only for accounts using "@yahoo.com"? 19:39:46 <qheaden> Mic: Yes. 19:40:17 <Mic> Stupid. 19:40:24 * clokep_work agrees. 19:40:26 <qheaden> :D 19:41:01 <clokep_work> We should design our own protocol! 19:41:03 <clokep_work> Oh wait... 19:41:45 <Mic> haha, "n+1 competing standards" then, I'd say :P 19:41:46 <qheaden> I'd be funny if someone were to make a Yahoo to XMPP converter server. 19:42:48 <clokep_work> I'm almost positive it exists. 19:43:01 <clokep_work> qheaden: http://www.bing.com/search?q=yahoo+xmpp+transport&pc=MOZI&form=MOZSBR 19:43:44 <qheaden> Wow! :P 19:55:21 <-- Nirgali has quit (Ping timeout) 20:12:37 <Mic> I wonder if we should make calls to separate methods instead of implementing the functionality in the oncommand handlers of the commands @ http://pastebin.instantbird.com/227124 20:13:12 <Mic> It's looking messy at the moment and it's not going to look that much better either :S 20:14:02 <qheaden> Well I have to go now. 20:14:38 <qheaden> clokep_work: I'll continue working on buddy requests. 20:16:27 <atuljangra> !seen aleth 20:16:28 <instantbot> aleth was last seen 6 hours, 4 minutes and 22 seconds ago, saying '* aleth worries about instantbidr' in #instantbird. 20:16:37 <-- atuljangra has quit (Quit: Need some break from Moz-awesomeness! :-)) 20:17:24 --> atuljangra has joined #instantbird 20:17:32 <-- atuljangra has quit (Client exited) 20:20:09 --> atuljangra has joined #instantbird 20:22:18 * qheaden is now known as qheaden_away 20:31:15 <-- clokep_work has quit (Ping timeout) 21:00:55 <instantbot> benediktp@ymail.com denied review for attachment 2489 on bug 426. 21:00:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 21:01:52 --> EionRobb has joined #instantbird 21:05:08 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 21:05:26 --> Mic has joined #instantbird 21:05:26 * ChanServ sets mode +h Mic 21:08:51 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 21:09:33 --> Mic has joined #instantbird 21:09:33 * ChanServ sets mode +h Mic 21:18:59 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 21:19:08 --> Mic has joined #instantbird 21:19:09 * ChanServ sets mode +h Mic 21:19:12 * atuljangra got prpl-irc: Unhandled CTCP message: AVATAR 21:20:15 <Mic> wtf? 21:20:29 <atuljangra> don't know. 21:20:41 <Mic> I know that that is but why is it showing here? 21:21:13 * Mic wrote an add-on that requests buddy icon over IRC but I've never seen such a message until now. 21:21:19 <Mic> *icons 21:21:37 <atuljangra> no no, it isn't showing here, I posted it. I thought of this as a possible bug. 21:21:50 <Mic> Ah, just pastebin it the next time. 21:22:00 <atuljangra> yes :-) 21:23:05 <Mic> Bug 1768 21:23:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1768 enh, --, ---, nobody, NEW, Add user icon support on IRC 21:23:21 <atuljangra> Thanks :) 21:26:19 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 21:26:32 --> Mic has joined #instantbird 21:26:32 * ChanServ sets mode +h Mic 21:28:57 <-- atuljangra has quit (Quit: Need some break from Moz-awesomeness! :-)) 21:29:26 --> atuljangra has joined #instantbird 21:30:11 * Mic did some hacking on nhnt11's code. That's what I currently looks like for me: https://wiki.instantbird.org/images/9/9c/GSoC-BuddyListTabRestyle3.png 21:31:18 <atuljangra> NICE :-) 21:32:42 --> flo-retina has joined #instantbird 21:32:42 * ChanServ sets mode +qo flo-retina flo-retina 21:34:04 <flo-retina> I think I've just found the steps to reproduce for my "accounts don't automatically reconnect when I arrive in the hotel" bug :) 21:34:12 <instantbot> New Core - General bug 2009 filed by florian@instantbird.org. 21:34:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2009 nor, --, ---, nobody, NEW, Accounts don't automatically reconnect when back online if the "offline" status was set while the co 21:36:42 * atuljangra thinks Bug 2013 should be something big. 21:38:46 --> atulalt has joined #instantbird 21:39:24 <-- atulalt has quit (Quit: Need some break from Moz-awesomeness! :-)) 21:39:37 --> atulalt has joined #instantbird 21:39:47 <-- atulalt has quit (Quit: Need some break from Moz-awesomeness! :-)) 21:40:07 <flo-retina> Mic: how did it look before you touched the css? 21:40:12 <flo-retina> was it looking bad on Windows? 21:40:59 --> atulalt has joined #instantbird 21:41:02 <Mic> No, not bad. 21:41:07 <-- atulalt has quit (Quit: Need some break from Moz-awesomeness! :-)) 21:41:21 <flo-retina> atuljangra: shouldn't it be something that we can resolve this year? 21:41:39 <Mic> "Update copyright year to 2013" ? :à 21:41:40 <Mic> :P 21:41:50 <flo-retina> Mic: 2014 ;) 21:42:48 <atuljangra> yes, something like that. I meant that "2013" should be significant. 21:42:49 <atuljangra> :) 21:43:00 <Mic> I don't have a screenshot of what it looked like before. 21:53:01 <-- flo-retina has quit (Ping timeout) 21:54:34 --> Nirgali has joined #instantbird 21:57:47 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 21:58:05 --> Mic has joined #instantbird 21:58:05 * ChanServ sets mode +h Mic 21:58:06 --> flo-retina has joined #instantbird 21:58:06 * ChanServ sets mode +qo flo-retina flo-retina 22:01:28 <Mic> flo-retina: like this: https://wiki.instantbird.org/images/1/1e/GSoC-BuddyListTab.png 22:02:19 <flo-retina> are you the person here who uses a custom font? 22:02:26 <flo-retina> I can never remember if it's you or aleth 22:03:19 <Mic> Default font should be Arial, 12pt for me. 22:03:39 <Mic> I think that's the default value on Windows. 22:04:03 <flo-retina> the text on both your screenshots is really difficult to read for me 22:04:47 <flo-retina> (to the point that it's hard to focus on anything else) 22:05:33 <flo-retina> well, I also see a lot the status icon and status messages that aren't aligned (they are baseline-aligned everywhere else) 22:06:29 <atuljangra> I'm doing this.LOG in irc.js, but I can't see anything in the error console :-/ 22:09:16 <flo-retina> atuljangra: have you tweaked the loglevel in about:config? 22:09:53 <atuljangra> yes. 22:10:22 <atuljangra> purple.debug.loglevel;3 22:10:52 <-- unghost has quit (Quit: Ð£Ñ Ð¾Ð¶Ñ Ñ Ð¾Ñ Ð²Ð°Ñ (xchat 2.4.5 или ÑÑаÑÑе)) 22:11:19 <-- micahg has quit (Ping timeout) 22:13:55 <atuljangra> flo-retina: does that change anything? 22:18:38 <flo-retina> atuljangra: http://lxr.instantbird.org/instantbird/source/chat/chat-prefs.js#76 22:19:29 <atuljangra> ah, figured that out. Now working :-) 22:19:46 * atuljangra deleted his profile recently, thus such errors. 22:19:49 <flo-retina> hmm, my '#talkilla' tab has the "left" icon, but I see new messages in there. How did Instantbird guessed I didn't really want to follow what was going on there at this time? :) 22:20:01 <flo-retina> atuljangra: :) 22:20:05 <atuljangra> :) 22:21:08 <flo-retina> Mic: I think together we have sent nhnt11 a lot of reading material ;) 22:21:14 --> micahg has joined #instantbird 22:21:48 <flo-retina> Mic: I wasn't sure if your questions were directed to nhnt11 or me, so I replied to most of them 22:22:04 <Mic> OK, thanks for your feedback! 22:23:56 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 22:38:48 --> Kaishi has joined #instantbird 22:41:00 <Mic> Good night 22:42:41 <flo-retina> Mic: good night :) 22:43:18 --> wnayes has joined #instantbird 22:44:50 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 23:36:20 <-- mconley has quit (Input/output error) 23:58:05 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)