All times are UTC.
00:06:09 <-- clokep_work has quit (NickServ (GHOST command used by clokep)) 00:06:12 --> clokep_work has joined #instantbird 00:06:12 * ChanServ sets mode +o clokep_work 00:21:10 <-- Mook_as has quit (Quit: Mook_as) 00:45:47 --> nhnt12 has joined #instantbird 00:46:07 <-- nhnt11 has quit (NickServ (GHOST command used by nhnt12)) 00:46:10 * nhnt12 is now known as nhnt11 00:50:31 --> wuwei`lab has joined #instantbird 01:05:31 <instantbot> clokep@gmail.com granted feedback for attachment 2475 on bug 1982. 01:05:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1982 nor, --, ---, qheaden, ASSI, Create Yahoo! Messenger Protocol Plug-In 01:07:33 <-- wnayes has quit (Ping timeout) 01:07:54 <clokep> nhnt11: I'm going to need to skip that review, no feedback I give will be useful. :-/ 01:08:03 <nhnt11> clokep: Sure. 01:10:37 <instantbot> clokep@gmail.com requested feedback from florian@instantbi rd.org for attachment 2463 on bug 1981. 01:10:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1981 nor, --, ---, nobody, NEW, Make socket.jsm more binary friendly 01:10:52 --> wnayes has joined #instantbird 01:11:16 * nhnt11 enjoys reading code reviews, even if they don't concern him. 01:16:02 --> rosonline has joined #instantbird 01:17:40 <-- DGMurdockIII has quit (Client exited) 01:34:34 <nhnt11> The addGenericTab method that was working before isn't working now for some reason. Content not being displayed and this time I added the required lines to jar.mn. Sigh. 01:51:35 <nhnt11> Yay, it's working again 01:57:09 * nhnt11 is able to add a non-conversation tab, switch to it, switch away from it, and close it, without a single error in the error console. :D 01:57:41 <nhnt11> Now for cleanup.... 01:58:46 <nhnt11> All the close other tabs, open in new window, etc. stuff works too. 02:00:51 <nhnt11> Oops I spoke too soon, open in new window doesn't work. 02:10:36 <clokep> Getting there though! :) 02:11:37 <nhnt11> clokep: I think I nearly have the open in new window working too. 02:14:28 <nhnt11> I have a feeling tabPanel.xml is going to be useful in the future even if it gets scrapped. 02:14:49 <nhnt11> (If nothing, it will serve as a list of all methods that need to be checked for) 02:45:31 <-- wnayes has quit (Quit: wnayes) 03:02:07 <clokep> nhnt11: You should put your addons on AIO. 03:02:14 <nhnt11> clokep: I will. 03:02:25 <clokep> Storing binary files in repos is...ugly. :) 03:02:40 <nhnt11> Haha 03:03:09 <nhnt11> I actually keep the packages for myself and didn't feel like assigning a separate folder for them. 03:03:26 <nhnt11> (I definitely didn't intend to distribute them through the repo!) 03:04:09 <clokep> You could add *.xpi to the hgignore file. 03:04:45 <nhnt11> I suppose. 03:04:56 <nhnt11> I don't see any reason not to just leave them there though. 03:05:17 <nhnt11> (other than it being ugly :P ) 03:05:39 <instant-buildbot> build #876 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/876 03:06:34 <nhnt11> YAY 03:06:50 <nhnt11> Open in new window successfully exports the tab to a new window :) 03:07:02 <clokep> Cool. 03:11:53 --> deltafalcon has joined #instantbird 03:23:42 <nhnt11> clokep: Do you think it's appropriate to always focus a newly added tab? 03:24:02 <nhnt11> Ah, not for private messages etc. 03:24:03 <clokep> nhnt11: We don't do that now, I don't think. 03:24:09 <nhnt11> Never mind. 03:24:17 <clokep> :) 03:29:14 <instant-buildbot> build #868 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/868 03:37:30 <nhnt11> I'm getting a NodeNotFound error. How do I check for that? Would if | (element of parent.childNodes) | work? 03:37:43 <nhnt11> | if (element of parent.childNodes) | * 03:41:09 <nhnt11> Never mind, the problem was an altogether different one. 03:51:25 <-- Suiseiseki has quit (Ping timeout) 03:54:34 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 03:57:03 <-- wuwei`lab has quit (Ping timeout) 04:19:19 --> Mook has joined #instantbird 04:19:34 <-- Nirgali has quit (Ping timeout) 04:21:46 --> Suiseiseki has joined #instantbird 04:56:44 --> Nirgali has joined #instantbird 05:05:37 <nhnt11> I've just updated my blog. I pushed the code to my repo under a new branch and uploaded a demonstration video of the new tab stuff to YouTube (yeah I was bored) - links in the blog post. Now, bed! See you all later... 05:05:41 <-- nhnt11 has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 05:08:09 <-- EionRobb has quit (Ping timeout) 05:11:19 <-- Suiseiseki has quit (Ping timeout) 05:19:30 --> deltafalcon1 has joined #instantbird 05:20:47 <-- deltafalcon has quit (Ping timeout) 05:22:12 <-- rosonline has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 05:22:30 --> Suiseiseki has joined #instantbird 05:32:42 <-- Optimizer has quit (Ping timeout) 05:36:19 --> Optimizer has joined #instantbird 05:48:17 <-- Mook has quit (Quit: Mook) 05:52:00 <-- Nirgali has quit (Ping timeout) 05:52:17 <instant-buildbot> build #971 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/971 06:20:24 --> nhnt11 has joined #instantbird 06:22:48 --> atuljangra has joined #instantbird 06:29:30 <-- nhnt11 has quit (Ping timeout) 06:33:05 --> nhnt11 has joined #instantbird 06:39:40 <-- Optimizer has quit (Ping timeout) 06:42:27 <-- nhnt11 has quit (Ping timeout) 06:43:03 --> Optimizer has joined #instantbird 06:46:06 --> nhnt11 has joined #instantbird 06:49:54 <-- nhnt11 has quit (Ping timeout) 06:53:44 --> nhnt11 has joined #instantbird 06:58:12 --> jb has joined #instantbird 07:00:21 <-- nhnt11 has quit (Ping timeout) 07:03:58 --> nhnt11 has joined #instantbird 07:09:00 --> DGMurdockIII has joined #instantbird 07:09:21 <-- nhnt11 has quit (Ping timeout) 07:13:16 --> nhnt11 has joined #instantbird 07:17:01 <-- nhnt11 has quit (Ping timeout) 07:18:09 <-- micahg has quit (Ping timeout) 07:20:57 --> nhnt11 has joined #instantbird 07:24:44 <-- nhnt11 has quit (Ping timeout) 07:28:40 --> nhnt11 has joined #instantbird 07:31:32 --> gerard-majax has joined #instantbird 07:34:56 --> micahg has joined #instantbird 07:35:02 <-- nhnt11 has quit (Ping timeout) 07:36:36 --> nhnt11 has joined #instantbird 07:39:06 <-- nhnt11 has quit (Input/output error) 07:39:11 --> nhnt11 has joined #instantbird 07:40:41 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.90 [Firefox 21.0/20130511120803]) 07:42:55 <-- nhnt11 has quit (Ping timeout) 07:43:56 --> nhnt11 has joined #instantbird 07:46:26 <-- nhnt11 has quit (Input/output error) 07:46:30 --> nhnt11 has joined #instantbird 07:50:15 <-- nhnt11 has quit (Ping timeout) 07:53:59 --> nhnt11 has joined #instantbird 07:55:45 <-- nhnt11 has quit (Ping timeout) 07:56:03 --> nhnt11 has joined #instantbird 07:59:41 <-- micahg has quit (Ping timeout) 07:59:50 <-- nhnt11 has quit (Ping timeout) 07:59:58 --> novabyte has joined #instantbird 08:00:27 <-- Tonnes has quit (Connection reset by peer) 08:01:32 --> micahg has joined #instantbird 08:02:18 --> Tonnes has joined #instantbird 08:03:35 --> nhnt11 has joined #instantbird 08:06:05 <-- nhnt11 has quit (Input/output error) 08:06:08 --> nhnt11 has joined #instantbird 08:09:53 <-- nhnt11 has quit (Ping timeout) 08:13:42 --> nhnt11 has joined #instantbird 08:13:54 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client) 08:15:49 <-- gerard-majax has quit (Ping timeout) 08:18:14 <-- nhnt11 has quit (Ping timeout) 08:19:52 --> nhnt11 has joined #instantbird 08:31:10 <-- clokep_work has quit (Ping timeout) 08:34:31 --> clokep_work has joined #instantbird 08:34:32 * ChanServ sets mode +o clokep_work 08:43:08 <-- Tonnes has quit (Input/output error) 08:46:26 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 08:49:27 --> gerard-majax has joined #instantbird 08:54:08 --> Tonnes has joined #instantbird 09:19:33 --> Mic has joined #instantbird 09:19:33 * ChanServ sets mode +h Mic 09:29:04 --> flo-retina has joined #instantbird 09:29:06 * ChanServ sets mode +qo flo-retina flo-retina 09:48:44 <instantbot> florian@instantbird.org granted feedback for attachment 2463 on bug 1981. 09:48:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1981 nor, --, ---, nobody, NEW, Make socket.jsm more binary friendly 09:50:12 <-- nhnt11 has quit (Ping timeout) 09:50:54 <Mic> I haven't commented yet @http://log.bezut.info/instantbird/130605#m365 09:53:47 --> nhnt11 has joined #instantbird 09:56:14 <flo-retina> Mic: good morning :) 09:56:28 <flo-retina> (yes, I still have 4 minutes to say that :-P) 09:58:49 <Mic> Good morning to you! ( 2 minutes left for me;)) 10:04:41 --> clokep has joined #instantbird 10:04:41 * ChanServ sets mode +o clokep 10:05:24 <clokep> Good morning! 10:05:27 * clokep has 6 hours. 10:08:27 <flo-retina> :) 10:13:01 <Mic> What kind of feedback is expected from me on the patch in bug 426 now? 10:13:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Make it easier to add tabs with arbitrary content to the "conversation window" 10:14:08 <Mic> http://log.bezut.info/instantbird/130605/#m395 suggests that it might face larger changes in the end. 10:16:11 <flo-retina> Mic: I think the feedback expected from you is to tell nhnt11 how you feel about the current patch 10:18:31 <Mic> I liked the idea of conversation.xml extending the new tabpanel binding better than the first approach (where you had a few more new bindings), but I see the point that it might be nice to keep it free of tab-stuff to allow re-using it in a one window layout. (I don't think it actually blocks that but it's unneeded code in this case). 10:21:33 <clokep> flo-retina: Does that mean I can just r? bug 1981? :P 10:21:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1981 nor, --, ---, nobody, NEW, Make socket.jsm more binary friendly 10:25:05 <flo-retina> clokep: if you have no further planned changes, yeah 10:30:13 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 10:31:10 --> Mic has joined #instantbird 10:31:11 * ChanServ sets mode +h Mic 10:36:36 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 2463 on bug 1981. 10:36:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1981 nor, --, ---, nobody, NEW, Make socket.jsm more binary friendly 11:04:48 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 11:05:16 <Mic> nhnt11: I'm away for lunch now, I hope I can finish part two of the review after it. 11:06:06 <Mic> I posted what I had already, btw. 11:09:45 --> mpmc has joined #instantbird 11:37:16 <Mic> nhnt11: you intent to use tabpanel.xml like an abstract class, don't you? 11:38:35 <Mic> (I know that the term doesn't fit exactly to this) 11:43:09 <Mic> I've put a comment regarding this on the bug, too. 11:43:11 <Mic> gtg 11:43:55 <-- mpmc has quit (Connection reset by peer) 11:43:59 <Mic> flo-retina: if you can think of a good/better way to design all this, I'd be happy to hear about it ;) 11:44:28 <-- Mic has quit (Connection reset by peer) 11:48:40 --> qlum has joined #instantbird 11:57:57 <flo-retina> Mic: I was wondering if we could use DOM events to dispatch changes between a tab and its content. That would remove the issue of methods that may not exist in some implementations. If there's no listener for an event, it doesn't matter, the event can still be dispatched. 12:00:36 * clokep_work ponders if conversation.xml no longer depends on being a tab if it should go into chat/. 12:01:13 <flo-retina> clokep_work: that would be ideal. But may be more work than nhnt11 really wants to do for this refactoring 12:01:27 <flo-retina> clokep_work: and that would make UI changes more painful, as we would need to check Tb all the time 12:02:14 <clokep_work> flo-retina: Of course. :) Just a thought! 12:23:49 <-- Optimizer has quit (Ping timeout) 12:27:41 --> Optimizer has joined #instantbird 12:34:55 <flo-retina> I really miss Hide Auto-Joins :-/ 12:35:09 <flo-retina> is there something doing the same thing that could easily be integrated by default? 12:37:44 <flo-retina> "easily" here is not about the difficulty of the code changes, but more about how we could have some non-confusing UX for it 12:40:42 <clokep_work> I think the way to do it is to get sesion restore working... 12:40:51 <clokep_work> I.e. I almost always want the same chats "on hold". 12:41:19 <flo-retina> clokep_work: right, I would like all chats on hold, except those that weren't on hold last time 12:41:34 <flo-retina> hmm 12:42:02 <flo-retina> so the feature could be to just remember which conversations were on hold, and "start them on hold" at the next reconnection 12:42:41 <clokep_work> I think so, that's what I want. 12:42:59 <flo-retina> we should probably ensure that /join <channel name of a conv on hold> actually reopens it 12:43:29 <flo-retina> just in case people don't discover that they are actually in these channels, and assume channels displayed in the contacts window are like channels added to Pidgin's buddy list (ie just a shortcut to join it) 12:43:54 <flo-retina> my Error Console is full of: 12:43:55 <flo-retina> Error: TypeError: parent.getAttribute is not a function Source File: resource://gre/modules/WindowDraggingUtils.jsm Line: 39 12:46:27 <flo-retina> also lots of "This message doesn't seem to be UTF-8 encoded: ..." from JS-IRC. 12:47:19 <flo-retina> maybe http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#657 should just be LOG instead of WARN 12:48:00 <clokep_work> Maybe. :-/ What would cause that? 12:48:04 <clokep_work> If someone is sending messages in a random encoding? 12:48:14 <flo-retina> clokep_work: people using a NON-UTF8 encoding for French messages ;) 12:58:20 <clokep_work> They should stop that. :p 13:00:40 <flo-retina> clokep_work: the point of this warning is to let Instantbird users who open their Error Console know that <nick> has mis configured his IRC client. 13:01:11 <flo-retina> in most clients that's obvious, because the accentuated appear as garbage. But Instantbird detects and fixes that... so it's invisible. 13:01:23 <flo-retina> +characters 13:02:40 <-- Optimizer has quit (Ping timeout) 13:03:24 <clokep_work> :) 13:03:31 <-- jb has quit (Ping timeout) 13:03:40 <clokep_work> You know I have fairly week opinions on our UTF8 support. :-[ 13:03:53 <flo-retina> but I don't really see telling people that their encoding sucks as a useful activity 13:04:22 <flo-retina> so the warnings are probably just noise that could be hidden 13:05:23 <clokep_work> That sounds reasonable to me. I'd be OK w/ that change. 13:06:18 <flo-retina> ok, I'll patch that next time I'm in a "cleanup the noise in my error console" mood :-D 13:06:23 --> Optimizer has joined #instantbird 13:06:48 <-- Kaishi has quit (Quit: Kaishi) 13:19:22 * qheaden_away is now known as qheaden 13:19:39 <qheaden> Hello all! 13:19:53 <flo-retina> qheaden: good morning :) 13:20:15 <qheaden> flo-retina: Good morning. Well, I guess it's morning where you are. :P 13:20:48 <flo-retina> qheaden: it's 3:20pm 13:21:19 <qheaden> flo-retina: Good afternoon then. :) 13:22:48 --> jb has joined #instantbird 13:23:22 <qheaden> clokep_work: I looked at the feedback you gave my patch. I will be working on that today. 13:27:03 <-- nhnt11 has quit (Ping timeout) 13:29:40 <clokep_work> qheaden: Let me know if it doesn't make sense. 13:30:01 <qheaden> clokep_work: So far, it all makes sense to me. :) 13:30:38 --> nhnt11 has joined #instantbird 13:31:07 <qheaden> clokep_work: Oh, and to give you a heads up, I'm going to have to leave about 2:30 today. I'll be back on later tonight (around 10:30 or 11:00) to continue development. 13:36:14 <clokep_work> qheaden: You don't need to give me exact times when you'll be here. As long as you keep making progress, it's fine. :) 13:38:16 <qheaden> clokep_work: :) 13:42:02 --> mconley has joined #instantbird 13:59:49 <nhnt11> Mic: "nhnt11: you intent to use tabpanel.xml like an abstract class, don't you?" Actually yeah. 14:00:01 <nhnt11> flo-retina: The DOM event idea sounds good. 14:08:10 <-- jb has quit (Ping timeout) 14:13:42 --> mpmc has joined #instantbird 14:43:59 --> jb has joined #instantbird 14:44:58 <-- jb has quit (Input/output error) 14:48:12 --> jb has joined #instantbird 14:50:55 <-- jb has quit (Ping timeout) 14:52:17 <qheaden> clokep_work: In your feedback, you mentioned that the replacements I made in the base64 response don't need to be regular expressions. But when I don't use regex, it only replaces the first occurrence. 14:54:16 <clokep_work> qheaden: Specify the global flag. 14:54:36 <clokep_work> Although that's apparently non-standard. 14:54:58 <clokep_work> qheaden: I guess leave it then. :) 14:56:54 <qheaden> Okay. :) 14:58:47 <qheaden> clokep_work: Also, about the pager server port being a constant; I notice that it is actually a preference in the current Yahoo implementation. 14:58:54 <qheaden> So I'll make it a preference. 15:01:21 <clokep_work> qheaden: I mention that at the bottom of my review. 15:02:37 <clokep_work> (Well more of that all the options have to match.) 15:02:52 <clokep_work> Note that ew don't need to provide all the options, necessarily, but the same ones should be read from preferences... 15:03:05 <qheaden> Okay 15:03:07 <clokep_work> So if someone flipped an option with the libpurple prpl, it'll still behave properly when using JS. 15:14:50 <qheaden> What is the preferred way of writing multiline comments? 15:14:57 <clokep_work> qheaden: Btw I figured I'd be a bit harsh on nits now so they become innate and we don't have to go through a ton of them at the end of the year. 15:15:07 <qheaden> Mozilla's coding guidelines say to use Javadoc. 15:15:20 <clokep_work> qheaden: It depends on the use. If it's like a long explanation of a class, we use /* */ comments, if it's a couple of lines we'll use // 15:15:29 <clokep_work> Just make it readable. 15:15:36 <clokep_work> I don't think we use Javadoc anywhere. 15:15:39 <qheaden> clokep_work: Oh no problem! I believe in fixing nits right away. 15:15:54 <flo-retina> we aren't too pedantic on the comment style, as long as what you are doing is consistent on the whole file. 15:22:49 <clokep_work> qheaden: No problem, was just reading the commit. 15:26:56 --> Nirgali has joined #instantbird 15:30:37 <qheaden> clokep_work: Does Account have a built-in callback method to know when a connection is complete (i.e. after reportConnected is called)? 15:31:25 <clokep_work> qheaden: reportConnected is how the prpl tells the UI it has connected. 15:31:54 <clokep_work> (I.e. No, that wouldn't make sense.) 15:32:00 <qheaden> Okay. 15:34:01 <-- Tonnes has quit (Quit: ChatZilla 0.9.90 [Firefox 21.0/20130511120803]) 15:34:18 --> mconley_ has joined #instantbird 15:34:52 <-- mconley has quit (Ping timeout) 15:38:24 --> jb has joined #instantbird 15:44:08 <qheaden> Be back in a bit. 15:44:14 * qheaden is now known as qheaden_away 15:53:52 <-- deltafalcon1 has quit (Connection reset by peer) 16:09:11 <-- clokep_work has quit (Ping timeout) 16:10:09 --> clokep_work has joined #instantbird 16:10:10 * ChanServ sets mode +o clokep_work 16:16:44 * qheaden_away is now known as qheaden 16:16:52 <qheaden> Back. 16:17:31 <flo-retina> qheaden: don't you think your nick change was enough for us to know you are back? ;) 16:17:57 <qheaden> flo-retina: Some folks disable nick change notifications. :) 16:18:13 <flo-retina> Instantbird doesn't support that 16:18:24 <flo-retina> (on purpose) 16:18:28 <clokep_work> qheaden: And if they disable it, do you think they want to know? :P 16:18:34 <qheaden> :P 16:18:38 <flo-retina> clokep_work: heh :) 16:21:00 <-- instant-buildbot has quit (Ping timeout) 16:21:12 <qheaden> clokep_work: Would it be wrong to let YahooLoginHelper access private members of YahooSession? Doing so would be like a C++ friend class. 16:21:13 * instantbot mumbles something about c++ being evil 16:21:16 <flo-retina> :-S 16:21:27 <qheaden> instantbot: Quiet now! 16:21:30 <instantbot> qheaden: Sorry, I've no idea what 'Quiet now' might be. 16:33:28 --> Mook_as has joined #instantbird 16:38:23 <qheaden> How can error messages be displayed to the user? 16:38:49 <-- gerard-majax has quit (Ping timeout) 16:41:52 <flo-retina> which error? 16:42:17 <clokep_work> qheaden: I'm not sure I really understand why there's a separation between YahooSession (which I also have a feeling should be called YahooSocket) and YahooLoginHelper. 16:43:35 <qheaden> clokep_work: They should be integrated. I just created the YahooLoginHelper to keep YahooSession (YahooSocket) from becoming cluttered with login logic. 16:45:01 <qheaden> flo-retina: Any error, such as a login error. I would like to display a message I create to the user explaining why the login failed. 16:46:34 <clokep_work> qheaden: Check the gotDisconnected method of the IRC code. 16:47:09 <flo-retina> qheaden: errors that cause the account to fail to get disconnected or to fail to connect are displayed in the accounts window 16:47:16 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 16:47:35 <qheaden> clokep_work, flo-retina: Thanks. 16:48:25 <flo-retina> random errors either go to the Error Console (if they could be useful to give to a developer when reporting a bug), or to /dev/null 16:52:51 <-- jb has quit (Ping timeout) 16:54:30 <clokep_work> You probably want to think about logging and such too. 16:54:43 <clokep_work> That needs to be added before you go much further qheaden. 16:54:59 --> jb has joined #instantbird 16:55:06 <qheaden> Yeah. 16:57:02 <-- Nirgali has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 16:57:41 <-- jb has quit (Connection reset by peer) 16:57:43 --> jb has joined #instantbird 16:57:51 --> Nirgali has joined #instantbird 17:07:06 --> EgorMatirov has joined #instantbird 17:07:43 <clokep_work> Hello EgorMatirov. 17:08:12 <-- novabyte has quit (Quit: bye bye) 17:10:39 <-- EgorMatirov has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 17:12:03 <qheaden> clokep_work: Okay, I was able to completely get rid of passing in callbacks to login functions. 17:12:29 <qheaden> Instead, the login helper calls onLoginComplete, or onLoginError which is defined on the YahooSession object. 17:12:44 <clokep_work> qheaden: Cool. 17:13:51 <qheaden> clokep_work: Also, thinking more about it, YahooSession would seem like the best name. Although it is a socket, it does a whole lot more than a normal socket, and it is designed to manage things. 17:14:19 <nhnt11> qheaden: YahooSessionSocket? ;) 17:14:24 <nhnt11> (kidding, sorry) 17:14:51 <qheaden> nhnt11: let sock = new YahooSocketThatDoesAWholeLotMore(); 17:15:05 <nhnt11> :P 17:18:17 <clokep_work> qheaden: Right. You could separate it into a sesion that includes a socket. The session would make the XHR calls. 17:19:06 <qheaden> clokep_work: Okay, that makes sense. I'll do it that way. 17:19:29 <qheaden> clokep_work: Also, where can I find some information on localized strings? 17:19:46 <qheaden> I'm writing some error messages, but they need to be localizable (if that's a word). :) 17:22:13 <nhnt11> Is BIO down? 17:22:40 <nhnt11> isup.me says it's up. Hmm. 17:24:09 <qheaden> nhnt11: I can't access it either. 17:25:17 <clokep_work> flo-retina: Do you know good l10n docs? 17:25:17 <flo-retina> nhnt11, qheaden: the server has issues, yes 17:25:51 <flo-retina> as shown by http://log.bezut.info/instantbird/130606#m282 17:26:26 <nhnt11> Ah didn't see that 17:28:22 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 17:33:27 <clokep_work> qheaden: So I can point you to places in the IRC code that are localized... 17:33:35 <clokep_work> I'm sure MDN has documentation too. 17:33:46 <clokep_work> Depends if you want to read code or docs. ;) 17:53:43 <qheaden> clokep_work: I'll take code. :) 17:56:52 <clokep_work> qheaden: Definition: http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/ircUtils.jsm#12 17:57:19 <clokep_work> qheaden: Simple usage: http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#699 17:57:35 <clokep_work> qheaden: Complicated usage: http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#888 17:57:49 <clokep_work> qheaden: Strings: http://lxr.instantbird.org/instantbird/source/chat/locales/en-US/irc.properties 17:58:39 <qheaden> clokep_work: Thanks. 17:59:18 <clokep_work> No problem. :) 18:19:36 --> Mic has joined #instantbird 18:19:36 * ChanServ sets mode +h Mic 18:20:42 <nhnt11> Hi Mic 18:20:51 <Mic> Hi 18:21:08 <Mic> I haven't even started with catching up on the logs by the way. 18:21:24 <nhnt11> I don't think I've said anything in the logs :) 18:28:10 --> Tonnes has joined #instantbird 18:30:26 <qheaden> Okay, I have to go now. Thanks for all of the help. 18:30:50 * qheaden is now known as qheaden_away 18:30:50 <nhnt11> bye qheaden 18:38:02 <-- micahg has quit (Quit: Ex-Chat) 18:38:13 --> micahg has joined #instantbird 18:54:20 --> unghost has joined #instantbird 19:12:22 --> jb1 has joined #instantbird 19:12:29 <-- jb has quit (Connection reset by peer) 19:12:43 * mconley_ is now known as mconley 19:15:28 --> DGMurdockIII has joined #instantbird 19:15:35 <-- DGMurdockIII has quit (Client exited) 19:19:04 --> DGMurdockIII has joined #instantbird 19:20:10 <-- Nirgali has quit (Ping timeout) 19:23:39 --> Nirgali has joined #instantbird 20:06:43 --> flo-retina has joined #instantbird 20:06:43 * ChanServ sets mode +qo flo-retina flo-retina 20:07:13 --> jb has joined #instantbird 20:07:13 <-- jb1 has quit (Connection reset by peer) 20:22:49 --> mpmc has joined #instantbird 20:25:41 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 20:27:34 <-- jb has quit (Ping timeout) 20:38:39 <Mic> help ba 20:38:55 * Mook_as doesn't see a ba here 20:39:06 <Mic> :] 20:39:18 <Mic> That was supposed to be "/help ba" 20:41:37 <Mic> help ve 20:41:44 <Mook_as> help slash 20:42:10 <Mic> Obviously I'm too dumb to type ;) 20:42:42 <nhnt11> :P 20:43:01 <nhnt11> Ugh. I'm stuck. 20:43:50 <nhnt11> Can't get rid of the TypeError for mCurrentBrowser when a generic tab is "Open in a new window"'d 20:44:38 <nhnt11> The zoom manager tries to access the markupDocumentViewer property which returns mCurrentBrowser.markupDocumentViewer 20:48:01 <Mic> What were you trying to do to fix this? 20:50:45 <nhnt11> I tried simply adding type checks 20:51:05 <nhnt11> But the zoom manager is a global file and I don't think I should modify anything there. 20:51:20 <nhnt11> I'm going to try and make the tabPanel return a documentMarkupViewer 20:51:47 <nhnt11> markupDocumentViewer* 20:53:10 <Mic> bbl 20:53:41 <Mic> You know: "it's not a star, it's a space station" ;) 20:54:36 <nhnt11> :P 20:56:08 <nhnt11> Is it reasonable to force all tabPanels to have a browser? 20:56:19 <nhnt11> Probably not. 20:56:21 --> jb has joined #instantbird 20:58:35 <flo-retina> nhnt11: do you have a link to that zoom code? 20:58:44 <nhnt11> flo-retina: Just a sec. 21:00:08 <nhnt11> flo-retina: Can the LXR be used for global files? 21:00:36 <nhnt11> mozilla/toolkit/content/viewZoomOverlay.js, line 63 21:00:39 <nhnt11> Ah let me pastebin it 21:00:58 <nhnt11> http://pastebin.instantbird.com/215339 21:06:26 <nhnt11> I'm trying a fix through convZoom.js 21:06:49 <flo-retina> nhnt11: http://mxr.mozilla.org/mozilla-central/source/toolkit/content/viewZoomOverlay.js 21:08:47 <flo-retina> nhnt11: hacking convZoom.js seems right 21:08:50 <nhnt11> flo-retina: That error is actually harmless. I don't suppose we could just ignore it? :P 21:08:58 <flo-retina> you likely want it to return early if getBrowser() is null 21:09:07 <nhnt11> flo-retina: getBrowser() isn't null 21:09:16 <flo-retina> it should if there's no displayed browser 21:09:23 <nhnt11> getBrowser is the tabbrowser. The problem is that tabbrowser's mCurrentBrowser is null 21:09:34 <nhnt11> mCurrentBrowser is the conversation browser. 21:09:49 <flo-retina> or have you ignored all of Mic's recommendations for making getBrowser() return the convbrowser instead of the tabbrowser? :) 21:10:14 <nhnt11> I haven't 21:10:28 <nhnt11> I wanted to ensure I had working code before cleaning it up 21:22:06 <-- jb has quit (Ping timeout) 21:28:42 <nhnt11> Okay it all works 21:29:02 <nhnt11> (From what I think is thorough testing) 21:29:15 --> EionRobb has joined #instantbird 21:29:18 <nhnt11> Mic: Would you like to try this code and see if you encounter any errors? 21:29:48 <nhnt11> (And anyone else willing to give it a go) 21:30:07 <Mic> Where is it? In the awesometab-experimental branch? 21:30:29 <nhnt11> Yes. I just pushed it. 21:30:55 <nhnt11> Mic: The code isn't check-in friendly, my main goal was to eliminate all the errors. 21:31:05 <Mic> OK 21:31:21 <nhnt11> I found that I was trying too hard to keep it clean and wasn't making much progress, so I decided to work at the errors and then clean it up afterwards. 21:32:54 <nhnt11> Mic: Also you can use my TabTest addon to add tabs if you like, syntax is /newtab <binding name> 21:33:28 <nhnt11> (Well I should say *your* addon, but I've updated it to work with the latest tabbrowser code) 21:35:04 --> FireFly_TB has joined #instantbird 21:41:23 <nhnt11> Mic: How did you add the extensions UI as a tab? I can't remember. 21:43:39 <Mic> Add a browser with the source pointing at the extension manager in the tabpanel. That's it. 21:44:11 <Mic> Like this: http://lxr.instantbird.org/instantbird/source/instantbird/content/extensions.xul#38 21:44:14 <nhnt11> Yeah I couldn't figure out the source string :P 21:45:00 <nhnt11> I tried chrome://instantbird/content/extensions.xul but it said invalid string :S 21:46:42 <flo-retina> btw, it could be useful to have an add-on adding an /open <url> command that opens in a tab 21:46:58 <flo-retina> opening about:memory in a tab would be really nice for example ;) 21:47:19 <nhnt11> flo-retina: I can think of loads of useful things to do with tabs :P 21:47:41 <flo-retina> hmm, or maybe restrict to about: 21:47:49 <nhnt11> (logs, urls, possibly pictures/video, pastebin, etc) 21:47:52 <Mic> Absolutely, these windows always have a bad size for me (they're so tall that the titlebar moves out of the top edge of the screen). 21:47:54 <flo-retina> and make it /about memory, /about addons, /about, etc... 21:48:30 <Mic> /about buildconfig ;) 21:48:42 <flo-retina> how often do you use this one? 21:48:52 * flo-retina wonders if about:supports does anything useful in Instatnbird 21:49:12 <Mic> clokep wanted to make it do. 21:49:36 <flo-retina> Mic: ah, about:crashes is quite useful too! 21:50:00 <Mic> I think I tried about:buildconfig ... once? To see if it works ;) 21:50:21 <Mic> Bug 527 21:50:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=527 nor, --, ---, nobody, NEW, Customize about:support with Instantbird/libpurple specific information 21:51:11 <flo-retina> Mic: you know I've read and forgotten half the bugs we have in BIO ;) 21:52:30 <flo-retina> This "parent.getAttribute is not a function" error cluttering my Error Console is starting to annoy me 21:52:41 <nhnt11> Mic: Did you get a chance to try the new code? I need to go soon. 21:52:42 <flo-retina> too bad I don't even now what the steps to reproduce are :-/ 21:55:12 <Mic> No, not yet, but I'll try it tonight. 22:08:04 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 22:09:48 <-- nhnt11 has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 22:09:58 --> nhnt11 has joined #instantbird 22:10:11 <nhnt11> I have to go 22:10:15 <nhnt11> Good night :) 22:10:16 <-- nhnt11 has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 22:11:51 --> Kaishi has joined #instantbird 22:14:55 <-- mconley has quit (Input/output error) 22:16:13 --> Mic has joined #instantbird 22:16:13 * ChanServ sets mode +h Mic 22:23:00 <-- Kaishi has quit (Quit: Kaishi) 22:28:36 <Mic> Good night 22:28:41 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 22:39:05 --> wnayes has joined #instantbird 23:26:04 <flo-retina> Good night :) 23:32:48 --> mconley has joined #instantbird 23:35:06 <-- qlum has quit (Client exited) 23:35:14 <-- mconley has quit (Ping timeout) 23:35:51 --> mconley has joined #instantbird