#instantbird log on 06 20 2012

All times are UTC.

00:07:34 <-- myk has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
00:11:35 <-- Tomek has quit (Quit: Instantbird 1.1)
00:22:45 --> wnayes has joined #instantbird
00:23:35 <instantbot> wnayes@gmail.com cancelled review?(wnayes@gmail.com) for attachment 1632 on bug 1438.
00:23:36 <instantbot> wnayes@gmail.com requested review from florian@instantbird .org for attachment 1637 on bug 1438.
00:23:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1438 enh, --, ---, florian, NEW, Typing the beginning of a protocol name listed in the top protocols should select it
00:30:32 <-- wnayes has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
00:31:57 --> DGMurdockIII has joined #instantbird
00:33:24 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.88.2 [Firefox 14.0/20120612164001])
00:34:06 --> wnayes has joined #instantbird
00:36:24 <instant-buildbot> build #279 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/279
00:37:38 <instantbot> New Core - General bug 1529 filed by clokep@gmail.com.
00:37:39 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1638 on bug 1529.
00:37:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1529 nor, --, ---, clokep, ASSI, Fix xpcshell tests on Windows after Mozilla 13 update
00:37:57 <clokep> Mook_as: If you have a second to look at that, it would be nice. :)
00:38:00 <clokep> Seem if it's somewhat not insane.
00:38:04 * clokep doesn't know Python. :P
00:38:52 <clokep> Ah, apaparently Facebook is going to support vcards?
00:40:08 --> DGMurdockIII has joined #instantbird
00:40:45 <Mook_as> that seems.... odd
00:40:59 <Mook_as> os.path.abspath("/c/foo/bar") gives you r"C:\foo\bar" ?
00:41:07 <Mook_as> instead of r"C:\c\foo\bar" ?
00:41:41 <Mook_as> (also, it probably wants to be using startsWith instead?)
00:41:49 * Mook_as is assuming test["here"] is a str
00:42:39 <clokep> Uhh...so I lied, the path to start with (testsRootDir is c:/Users/clokep/instantbird/objdir-debug/mozilla/_tests/xpcshell
00:42:41 <clokep> My bad. :)
00:42:54 <clokep> Copied the wrong line from the terminal.
00:43:45 <Mook_as> yeah, that should work, then
00:46:19 <-- Mook_as has quit (Quit: Mook_as)
00:49:20 <-- aleth has quit (Input/output error)
00:49:41 --> mmkmou has joined #instantbird
00:53:15 <instantbot> clokep@gmail.com granted review for attachment 1635 on bug 1518.
00:53:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1518 min, --, ---, aletheia2, ASSI, Don't display the topic system message again if it hasn't changed
00:53:55 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1639 on bug 1518.
00:54:15 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1639 on bug 1518.
00:56:57 <instantbot> clokep@gmail.com granted review for attachment 1631 on bug 1520.
00:56:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1520 min, --, ---, aletheia2, ASSI, Make autojoin and "Join Chat" handle excess whitespace better
01:03:10 <instantbot> clokep@gmail.com granted review for attachment 1633 on bug 385.
01:03:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=385 enh, --, ---, aletheia2, ASSI, Rejoin IRC channels after reconnect
01:10:36 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1640 on bug 1296.
01:10:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1296 enh, --, ---, clokep, ASSI, Unhandled IRC whois response messages 307 671 317
01:26:09 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.88.2 [Firefox 14.0/20120612164001])
01:27:02 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
01:32:42 <instant-buildbot> build #248 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/248
01:33:39 <-- wnayes has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
02:08:30 <-- mmkmou has quit (Ping timeout)
02:16:20 <instant-buildbot> build #537 of linux-nightly-default is complete: Failure [failed hg_1]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/537
02:48:17 <instant-buildbot> build #268 of win32-onCommit is complete: Failure [failed shell_1]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/268  blamelist: Florian Qu?ze <florian@instantbird.org>
03:20:58 --> Mook has joined #instantbird
03:44:55 <-- EionRobb has quit (Quit: Leaving.)
04:41:15 * jwir3|away is now known as jwir3|zzz
05:08:58 --> DGMurdockIII has joined #instantbird
05:09:12 <DGMurdockIII> Timestamp: 6/19/2012 4:48:38 PM
05:09:14 <DGMurdockIII> Warning: Unknown property '-moz-column-fill'.  Declaration dropped.
05:09:16 <DGMurdockIII> Source File: resource://gre-resources/ua.css
05:09:18 <DGMurdockIII> Line: 166
05:10:02 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.88.2 [Firefox 14.0/20120612164001])
05:15:04 <instant-buildbot> build #628 of win32-nightly-default is complete: Failure [failed shell_3]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/628
05:47:21 --> pvagner has joined #instantbird
05:51:59 --> jb has joined #instantbird
06:03:24 --> TestFliege has joined #instantbird
06:22:03 <instant-buildbot> build #524 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/524
06:31:33 <-- TestFliege has quit (Quit: TestFliege)
06:31:49 --> TestFliege has joined #instantbird
06:32:08 <-- TestFliege has quit (Input/output error)
06:32:19 --> FireFly_TB has joined #instantbird
06:48:58 <-- Kaishi has quit (Ping timeout)
06:56:42 <-- Mook has quit (Quit: ChatZilla 0.9.87-rdmsoft [XULRunner 6.0/20110811165603])
07:46:28 --> Optimizer has joined #instantbird
07:50:39 <-- meh has quit (Ping timeout)
08:01:38 --> FeuerFliege has joined #instantbird
08:11:41 --> aleth has joined #instantbird
08:11:41 * ChanServ sets mode +h aleth 
08:17:08 --> sonny has joined #instantbird
08:21:04 <instantbot> aletheia2@fastmail.fm granted review for attachment 1639 on bug 1518.
08:21:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1518 min, --, ---, aletheia2, ASSI, Don't display the topic system message again if it hasn't changed
08:30:52 <instantbot> aletheia2@fastmail.fm granted review for attachment 1640 on bug 1296.
08:30:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1296 enh, --, ---, clokep, ASSI, Unhandled IRC whois response messages 307 671 317
08:32:22 <-- Optimizer has quit (Ping timeout)
08:36:03 --> Optimizer has joined #instantbird
08:44:25 <-- Optimizer has quit (Ping timeout)
08:45:09 --> Optimizer has joined #instantbird
08:45:14 <-- FireFly_TB has quit (Input/output error)
08:45:18 <-- FeuerFliege has quit (Connection reset by peer)
08:47:24 --> Even1 has joined #instantbird
08:49:15 --> Bollebib has joined #instantbird
08:54:14 --> mmkmou has joined #instantbird
08:56:50 --> Lalae has joined #instantbird
08:57:33 <-- Lalae has left #instantbird ()
09:13:55 --> Lalae has joined #instantbird
09:16:18 --> flo has joined #instantbird
09:16:18 * ChanServ sets mode +qo flo flo 
09:16:34 --> gerard-majax has joined #instantbird
09:21:29 <-- jb has quit (Ping timeout)
09:23:58 <-- Lalae has left #instantbird ()
09:50:58 --> jb has joined #instantbird
10:10:22 --> clokep has joined #instantbird
10:10:22 * ChanServ sets mode +o clokep 
10:10:47 <flo> clokep: hello :)
10:12:03 * clokep wonders if flo has it set it up to tell him when I sign in...
10:12:33 <clokep> Good morning. :)
10:13:14 <flo> I just had #instantbird open on the secondary monitor ;)
10:13:29 * flo is adding an r- to all the patches that were attached last night :-P
10:13:38 <flo> this way I won't need to check-in anything today :-P
10:14:38 <clokep> Haha.
10:14:53 <clokep> Actually I think one of the check-in needed patches has some bad whitespace changes.
10:14:59 <clokep> I just remembered when I woke up.
10:15:03 <clokep> One of aleth's....
10:17:50 <clokep> flo: Bug 1529, did you see my second comment saying they're both c:/, neither is /c/?
10:17:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1529 nor, --, ---, clokep, ASSI, Fix xpcshell tests on Windows after Mozilla 13 update
10:18:31 <flo> clokep: I assumed all your comments contained copy/paste mistakes
10:18:45 <aleth> clokep: Yes, 385 I think
10:18:47 <flo> as the double \ were strange ;)
10:19:42 <clokep> flo: That's not a mistake.
10:19:59 <clokep> It's a Python string, so \ is escaped.
10:21:07 <flo> clokep: you need to escape it if you want to put it in the code, but I don't think it's really escaped inside the buffer
10:21:32 <clokep> :shrugs: That's what it shows when I print it. ;)
10:22:06 <instantbot> aletheia2@fastmail.fm granted review for attachment 1641 on bug 385.
10:22:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=385 enh, --, ---, aletheia2, ASSI, Rejoin IRC channels after reconnect
10:26:02 <clokep> flo: So you would prefer something like http://pastebin.instantbird.com/46471
10:27:09 <flo> clokep: yes, I would r+ that
10:27:50 <aleth> Oh, you found the Windows problem :)
10:28:02 <clokep> Kind of.
10:28:15 <flo> aleth: more hacked around it than found, but that will do for now
10:28:30 * clokep notes that diffs of diffs can be confusing. :-S
10:29:56 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 1638 on bug 1529.
10:29:57 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1642 on bug 1529.
10:29:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1529 nor, --, ---, clokep, ASSI, Fix xpcshell tests on Windows after Mozilla 13 update
10:31:06 <instantbot> florian@instantbird.org denied review for attachment 1633 on bug 385.
10:31:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=385 enh, --, ---, aletheia2, ASSI, Rejoin IRC channels after reconnect
10:31:11 <flo> bah, you all mid-aired me with whitespace comments :-S
10:31:39 <clokep> Btw those changes are part of https://bugzilla.mozilla.org/show_bug.cgi?id=729098
10:32:36 <flo> "those changes"?
10:32:53 <flo> clokep: I already pushed https://hg.instantbird.org/instantbird/rev/484417069bea and it didn't help
10:32:56 <clokep> That I'm patching that bug.
10:33:03 <aleth> flo: "a lot of the logic you added seems like it would work for any js prpl with mucs, so some of it may want to live in jsProtoHelper instead of irc files" <-- that was the idea ;)
10:33:24 <clokep> flo: I'm talking about http://hg.mozilla.org/mozilla-central/rev/8ee446a837d5#l4.74
10:33:50 <flo> clokep: yeah, I looked there before, but it didn't give me the solution
10:34:04 <flo> did you have time to compare with Tb yesterday?
10:34:28 <clokep> No, my tests weren't running there for a different reason (couldn't find a python module?)
10:35:13 <flo> mozinfo ?
10:35:17 <clokep> Yes.
10:35:29 <flo> there was a fix for that somewhere
10:35:54 <flo> https://bugzilla.mozilla.org/show_bug.cgi?id=752252 I think
10:38:05 <clokep> Ah, so I just have a bad revision? I think I updated...
10:38:29 <flo> maybe
10:38:49 <flo> but I hope the problem will magically disappear at some point after we upgrade correctly the build system
10:39:23 --> meh has joined #instantbird
10:39:25 <clokep> Yes, that was my hope too. :)
10:42:06 <clokep> flo: Good comments on bug 385. :( My review of that seems to be fairly awful.
10:42:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=385 enh, --, ---, aletheia2, ASSI, Rejoin IRC channels after reconnect
10:44:01 <instantbot> florian@instantbird.org granted review for attachment 1642 on bug 1529.
10:44:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1529 nor, --, ---, clokep, ASSI, Fix xpcshell tests on Windows after Mozilla 13 update
10:46:14 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/bea3cbfefb28 - Patrick Cloke - Bug 1486 - Update to Mozilla 13, fix Windows xpcshell tests paths.
10:46:48 <flo> arg, I shouldn't have done that :(
10:47:14 <flo> https://hg.instantbird.org/instantbird/file/8594a79edd45/tools/patches/apply-patches.sh#l4
10:47:21 <flo> we apply *.patch and you named it .diff :(
10:49:16 <clokep> Arg. :( Sorry.
10:49:28 <flo> my fault; crappy review ;)
10:50:01 <clokep> Yeah, I wasn't really sure how to test it since running python client.py checkout with stuff in your mq doesn't really work...I guess I should have run the script to apply the patches manually to test it.
10:51:37 <instantbot> florian@instantbird.org set the Resolution field on bug 1529 to FIXED.
10:51:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1529 blo, --, 1.2, clokep, RESO FIXED, Fix xpcshell tests on Windows after Mozilla 13 update
10:52:15 <flo> "running python client.py checkout with stuff in your mq doesn't really work" why??
10:54:08 <clokep> If there are any incoming changesets, they get applied in a weird way.
10:54:23 <clokep> You end up diverging / branching.
10:54:30 <clokep> So you have to qpop everything and qpush back to where you were.
10:54:44 <clokep> And yesterday I had it delete a bunch of files added from my mq.
10:55:26 <flo> in bug 1518, why is twitter.js messing with the topicSetter?
10:55:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1518 min, --, ---, aletheia2, ASSI, Don't display the topic system message again if it hasn't changed
10:55:31 <flo> isn't it always null for twitter?
10:56:15 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/e95d5a75cbd2 - Florian Quèze - Rename the patch just added by bea3cbfefb28 so that it has a .patch extension and apply-patches.sh applies it.
10:56:27 <flo> clokep: I still don't understand. If I want to test the mozilla update, client.py touching the instantbird repository is unacceptable, but we have the --skip-instantbird option for that, and I don't see how mq differs from that
10:56:46 <flo> also, if you are messing with patches, you may want to unapply all existing patches, with --clean
10:57:06 <flo> when I work on updating the patches after a mozilla update, I use python client.py checkout --skip-instantbird --clean
10:57:11 <aleth> flo: http://lxr.instantbird.org/instantbird/source/chat/protocols/twitter/twitter.js#680
10:57:32 <clokep> flo: I didn't know about those flags.
10:57:48 <flo> ok :)
10:57:58 <flo> I hope you will remember they exist next time you need them :)
10:58:37 <flo> aleth: hmm? 
10:58:57 <aleth> flo: I'm no twitter expert, so I don't know if it can ever change (I doubt it), but it's not null.
10:59:55 <clokep> Me too. :)
11:00:12 <clokep> In twitter, the topic setter is always yourself.
11:00:45 <flo> why can't the jsProtoHelper setTopic implementation take another aQuiet boolean parameter to return before the system message stuff?
11:01:13 <-- Even has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
11:01:14 <aleth> Sure... so you want me to clean up the setTopic calls in twitter.js so it doesn't bother to supply a topicSetter parameter?
11:02:22 <flo> no, I changed my mind :)
11:03:03 <aleth> I don't think an extra parameter would be the way to go for that feature...
11:03:09 <flo> why?
11:04:03 <aleth> I'm not sure I understand what you want to do with it. If it's a general parameter to turn off system messages, it should check a flag somewhere, nor a parameter.
11:04:22 <aleth> s/nor/not
11:05:02 <flo> s/general/
11:05:34 <flo> A flag on the conversation may be better, but isn't it a bit overkill if we have only one use case?
11:06:08 <aleth> What's the use case? I'm a bit puzzled if it was meant to be obvious
11:06:20 <aleth> Doing without the twitter override?
11:06:38 <flo> not duplicating code from jsProtoHelper to twitter.js
11:07:12 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
11:07:24 <aleth> OK. I thought you were somehow referring to the discussion yesterday about optionally hiding various system messages
11:10:54 <instantbot> florian@instantbird.org denied review for attachment 1639 on bug 1518.
11:10:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1518 min, --, ---, aletheia2, ASSI, Don't display the topic system message again if it hasn't changed
11:12:25 <instantbot> florian@instantbird.org denied review for attachment 1637 on bug 1438.
11:12:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1438 enh, --, ---, florian, NEW, Typing the beginning of a protocol name listed in the top protocols should select it
11:12:43 <flo> ok, I think I've now r-'ed all the patches that were submitted this night ;)
11:13:13 <flo> those that had a review request from me at least :)
11:27:23 <flo> Even restarted the buildbot slaves and I requested another windows nightly. We should have one in a few hours :)
11:27:55 <-- jb has quit (Ping timeout)
11:31:09 <aleth> Under what circumstances is close() called on a conversation, but not unInit() ?
11:42:12 --> Tomek has joined #instantbird
11:48:05 --> clokep_work has joined #instantbird
11:48:05 * ChanServ sets mode +o clokep_work 
11:54:18 <clokep_work> aleth: http://lxr.instantbird.org/instantbird/source/chat/components/public/prplIConversation.idl#49
11:55:17 <clokep_work> They're used for different reasons, the close command is from the UI (e.g. close in IRC parts the room, the unInit just cleans up stuff).
12:12:07 <flo> I don't think it will be called by purpleCoreService though ;)
12:12:50 --> jb has joined #instantbird
12:13:17 <flo> aleth: I think close() is when the user leaves the conversation (so part for IRC channels) and unInit is when the UI doesn't need the conversation any more (so the tab of an already closed conversation is closed for example)
12:15:29 <aleth> flo: Right, it seems close() triggers unInit() after parting.
12:17:47 <clokep_work> Sounds correct. :)
12:19:04 * clokep_work figures we should do a blog post again soon...
12:20:34 <flo> clokep_work: it won't appear on planet though :(
12:21:09 <aleth> What, did we get delisted? 
12:21:38 <clokep_work> aleth: They separated "Projects" to a separate planet.
12:22:02 <flo> aleth: they decided we were noise, because all the meeting notes are noisy
12:22:05 <aleth> Hmm.
12:24:18 --> adev has joined #instantbird
12:24:39 <-- adev has left #instantbird ()
12:27:14 --> adev has joined #instantbird
12:27:19 <-- adev has left #instantbird ()
12:27:56 --> Kaishi has joined #instantbird
12:28:13 <-- Suiseiseki has quit (Ping timeout)
12:28:19 <aleth> clokep_work: Is it intentional that IRC 'ERROR's show as normal messages in the console?
12:30:37 <aleth> Hmm, it's actually not an IRC ERROR...
12:32:07 <clokep_work> aleth: We get disconnected if we get an ERROR response (and I think we report an unexpected disconnect in the conosle, yes.)
12:36:23 --> FireFly_TB has joined #instantbird
12:36:58 <aleth> clokep_work: I meant the ERROR macro in the code
12:37:19 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1643 on bug 385.
12:37:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=385 enh, --, ---, aletheia2, ASSI, Rejoin IRC channels after reconnect
12:37:40 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1643 on bug 385.
12:40:01 <instantbot> clokep@gmail.com denied review for attachment 1640 on bug 1296.
12:40:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1296 enh, --, ---, clokep, ASSI, Unhandled IRC whois response messages 307 671 317
12:40:10 <clokep_work> I can deny my own reviews, right? ;)
12:40:37 <clokep_work> aleth: Ah, they should show as errors, yes.
12:41:03 <aleth> clokep_work: Did you agree with my suggestion then? ;)
12:42:45 <aleth> Trading aMessage.params[1] for aNick seems a good idea too.
12:43:20 <clokep_work> Yes, I had wondered that too, but was afraid I'd get a "code duplication!" comment if I did that. :)
12:44:56 <aleth> Not really, because most setWhoIs calls have aMessage.params[] as other arguments anyway...
12:45:29 <aleth> Heh, I thought including "Cu" was a hint at something under construction ;)
12:46:03 <aleth> s/Cu/Ci
12:46:27 <clokep_work> Nah, just me being lazy. :)
12:46:39 <flo> http://dutherenverseauborddelatable.wordpress.com/2012/06/19/fun-with-windows-paths/ is quite entertaining :)
12:47:31 <aleth> "/" is a filename, oh joy :P
12:51:16 <aleth> I wonder what happens when Linux mounts a drive with a file of that name...
12:51:30 <aleth> Hopefully it is handled OK
12:54:04 <flo> FireFly_TB who worked on escaping windows paths for logs may enjoy that blog post too ;)
12:56:30 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1644 on bug 1518.
12:56:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1518 min, --, ---, aletheia2, ASSI, Don't display the topic system message again if it hasn't changed
12:57:47 --> adev has joined #instantbird
12:57:54 <-- adev has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
12:59:14 <aleth> I often see "ERROR :Closing Link" messages when using "/offline". But those are not instances where the QUIT message then is not sent correctly, as I first hoped.
13:00:38 <flo> I think it's the forth time that the auto-scroll fails for me this week
13:01:02 <flo> by "fail" I mean that the message that's 'scrolled' into view isn''t the last one, for no apparent reason
13:01:23 <instantbot> clokep@gmail.com denied review for attachment 1643 on bug 385.
13:01:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=385 enh, --, ---, aletheia2, ASSI, Rejoin IRC channels after reconnect
13:01:43 <aleth> flo: I've noticed that too
13:01:53 <aleth> Some moz13 effect?
13:01:57 <clokep_work> aleth: You see "ERROR: Closing Link" as what...?
13:01:58 <flo> file a 1.2-blocking bug?
13:02:08 <flo> aleth: I'm afraid it is, yes :(
13:03:13 <aleth> as messages in the console (when loglevel is low enough)
13:03:56 <clokep_work> aleth: As a message from the server? What's the issue then?
13:04:39 <aleth> clokep_work: Maybe none whatsoever, I just don't understand why its an ERROR in that case
13:05:15 <aleth> Maybe one should ask the server coder ;)
13:06:34 <clokep_work> aleth: ERROR is what is used to tell the client the server is closing the link.
13:06:43 <clokep_work> It's just a command, it doesn't mean there's actually an ERROR.
13:06:49 <clokep_work> Why it's called ERROR, I have no idea.
13:06:55 <clokep_work> But it's /not/ an error (necessarily).
13:07:57 <aleth> OK :)
13:08:26 <aleth> If there is an error, maybe it reads ERROR: ACTUALLY AN ERROR
13:08:51 <flo> aleth: we don't have any feedback for unsuccessful joins?
13:09:28 <aleth> flo: Not unambiguously, I think. (There is an error response, but it also happens in other instances)
13:09:52 <aleth> Though maybe that doesn't matter and I can remove the entry in that case anyway.
13:10:07 <flo> clokep_work: "An error means something horrible went wrong" If something horrible went wrong, isn't that an happy event? :)
13:10:30 <clokep_work> flo: Touche. ;) "Horribly went wrong" sounds like what I wanted....
13:10:53 <-- jb has quit (Ping timeout)
13:10:58 <flo> I saw "went horribly wrong" several times
13:11:08 --> jb has joined #instantbird
13:11:13 <clokep_work> My point is that it's unexpected, but we're still able to handle it so...warn, not error. :-D
13:11:38 <flo> clokep_work: I got your point, I just smiled at the phrasing :)
13:12:13 <clokep_work> :)
13:13:43 * clokep_work likes https://bugzilla.instantbird.org/attachment.cgi?id=1644&action=diff
13:15:10 <flo> seems I'll r+ this one
13:15:35 <flo> I don't want to push anything with a regression potential until we have at least one moz13 Windows nightly
13:17:00 <flo> the build seems to be uploading
13:17:03 <flo> the tests passed
13:17:04 <flo> :)
13:21:53 <instant-buildbot> build #629 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/629
13:22:53 <flo> \o/
13:29:12 <-- mmkmou has quit (Ping timeout)
13:37:18 <-- Tomek has quit (Quit: Instantbird 1.1)
13:42:43 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1643 on bug 385.
13:42:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=385 enh, --, ---, aletheia2, ASSI, Rejoin IRC channels after reconnect
13:50:34 <-- Kaishi has quit (Quit: Kaishi)
14:08:20 --> mmkmou has joined #instantbird
14:09:53 <-- pvagner has quit (Ping timeout)
14:32:50 <-- Optimizer has quit (Ping timeout)
14:33:57 --> Tomek has joined #instantbird
14:34:55 --> pvagner has joined #instantbird
14:35:52 <-- pvagner has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
14:36:38 --> Optimizer has joined #instantbird
14:44:53 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1645 on bug 385.
14:44:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=385 enh, --, ---, aletheia2, ASSI, Rejoin IRC channels after reconnect
14:47:03 --> Suiseiseki has joined #instantbird
15:02:29 <-- jb has quit (Ping timeout)
15:20:15 <clokep_work> :) Glad it worked (and that we have a nightly finally!)
15:20:20 --> jb has joined #instantbird
15:21:57 <flo> now we need people to test it and file bugs ;)
15:23:49 <clokep_work> I will later today. :)
15:23:52 <clokep_work> Hopefully no bugs!
15:24:41 <flo> well, auto-scroll seems broken ;)
15:24:50 <flo> but subtly so.
15:26:03 <aleth> I haven't detected a pattern to it yet
15:26:30 <flo> I only notice it when it's to late to remember what I did
15:26:40 <flo> *too
15:28:57 --> igorko has joined #instantbird
15:32:30 <-- FireFly_TB has quit (Ping timeout)
15:32:43 <-- Tomek has quit (Quit: Instantbird 1.1)
15:33:53 * clokep_work is wondering if the IRC messages should have a target field so they match with what the RFC says...
15:35:59 --> FireFly_TB has joined #instantbird
15:37:43 <-- FireFly_TB has quit (Ping timeout)
15:43:47 --> FireFly_TB has joined #instantbird
15:45:09 <instantbot> New Instantbird (UI) bug 1530 filed by aletheia2@fastmail.fm.
15:45:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1530 nor, --, ---, nobody, NEW, Autoscroll subtly broken after moz13 update
15:46:03 <flo> hmm
15:46:22 <clokep_work> I dislike all these regressions we've been having with our Mozilla upgrades. :(
15:46:44 <flo> aleth: I can't reproduce with these steps
15:47:08 <flo> and I'm sure I've never put on hold #instantbird yesterday
15:47:28 <aleth> Maybe you need to scroll almost, but not quite to the end of the conversation to see the effect?
15:47:37 <flo> + putting on hold destroys the conversation and convbrowser bindings, so auto-scroll is completely reset when we reopen :)
15:47:45 <flo> hmm
15:47:53 <flo> yes
15:47:59 <flo> it could be
15:48:24 <flo> aleth: looks like this is broken: http://lxr.instantbird.org/instantbird/source/chat/content/convbrowser.xml#223
15:48:24 <aleth> I'm not sure of the cause, but it seems to be fairly consistent behaviour for me
15:48:40 <flo> it used to reenable auto-scroll if you are near the bottom (near = within 10px)
15:48:48 <flo> now auto-scroll is disabled if I'm not exactly at the bottom
15:48:49 <aleth> Hmm, I wonder what changed
15:49:17 <flo> one of the body.scrollHeight, body.scrollTop, body.clientHeight properties must have changed
15:49:38 <aleth> Yes... but it's surprising
15:51:48 <aleth> Failing that, some change in one of the attributes those values are calculated from
15:53:43 <flo> or should we call this._updateAutoScrollEnabled before insertHTMLForMessage in displayMessage?
15:56:41 <-- igorko has quit (Ping timeout)
16:00:31 --> jb1 has joined #instantbird
16:01:06 <-- jb has quit (Ping timeout)
16:07:42 <aleth> But we already call it just after.
16:08:26 --> Tomek has joined #instantbird
16:08:42 <flo> what if something forced the layout to be computed faster than before, so that the scrollbar has already moved by the height of the message we have just inserted?
16:09:11 * jwir3|zzz is now known as jwir3
16:09:14 <flo> typically some of the JS magic code in Time Bubbles that will calculate the margin
16:09:28 --> Knoetsch has joined #instantbird
16:09:30 <clokep_work> Or maybe the JS engine is just faster. ;)
16:10:01 <flo> I remember we used to see the message appear with the standard margin briefly before its margin was fixed by the JS code
16:10:15 <flo> maybe the DOM Mutation events are fired faster/earlier
16:10:19 <aleth> Hmm.
16:10:25 <flo> (they have reimplemented DOM mutation stuff recently)
16:10:34 <aleth> It would be cleaner if it was called before anyway, right?
16:10:47 <aleth> No magic 10 pixels
16:10:51 <flo> cleaner no, safer probably
16:11:06 <flo> the code is more readable with all the things related to auto-scroll in a single place
16:11:17 <aleth> Sure, it would make the code messier.
16:11:24 <flo> aleth: the "magic 10 pixels" is what we are trying to make work again
16:11:38 <aleth> And I'm not sure of what this refers to "// avoid ireflow bugs"
16:11:55 <flo> it's only the user's messiness that we fix with it, ie the user scrolled down but not fully
16:11:58 <aleth> flo: Yes, but you are saying the problem is that 10 < (height of added message)
16:12:07 <flo> aleth: it refers to pain ;)
16:12:23 <aleth> Would the pain return if it was moved? ;)
16:12:35 <flo> aleth: no. I'm saying 10 was computed before the new message was added in the layout.
16:12:39 <aleth> i.e. can't call that before adding the element
16:13:15 <flo> well, actually the getBoundingClientRect call forces the layout :-S
16:13:38 <aleth> OK, we mean the same thing now I think
16:16:33 <flo> so maybe it's http://lxr.instantbird.org/instantbird/source/chat/content/convbrowser.xml#586 that reenables the auto-scroll after scrolling down
16:21:03 <aleth> Am testing this http://pastebin.instantbird.com/46510
16:21:32 <aleth> Don't think it will work though.
16:22:02 <flo> and I'm sure I would r- as you forgot the ! before aNoAutoScroll
16:22:30 <flo> even if it works, it may not be the best solution, as it may be hiding another bug
16:22:51 <aleth> Right
16:22:57 <aleth> Anyway, running it now for a bit
16:25:47 <-- SM0TVI has quit (Quit: I view things as they are, without regard to place or person; my country is the world, and my religion is to do good. -- Thomas Paine (*1737 †1809))
16:26:17 --> SM0TVI has joined #instantbird
16:27:33 <-- SM0TVI has quit (Quit: I view things as they are, without regard to place or person; my country is the world, and my religion is to do good. -- Thomas Paine (*1737 †1809))
16:30:47 <-- Even1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
16:30:52 --> Even has joined #instantbird
16:30:52 * ChanServ sets mode +o Even 
16:32:34 <clokep_work> Has anyone tried the Windows nightly yet?
16:33:39 --> Mook_as has joined #instantbird
16:33:43 <flo> nobody complained about it at least ;)
16:33:54 --> SM0TVI has joined #instantbird
16:38:05 <clokep_work> Hah!
16:41:41 <aleth> So it looks like my pastebin does fix the problem. The dumps I added show that it's body.scrollHeight that changes by the height of the new message. So maybe there was a race condition there all along and now the new height is calculated faster
16:42:45 <flo> I think that code never worked
16:43:02 <flo> but it shouldn't have been necessary
16:43:20 <flo> would be nice if you could add dumps in http://lxr.instantbird.org/instantbird/source/chat/content/convbrowser.xml#564 too
16:44:03 <aleth> To look for...?
16:44:12 <aleth> I'm seeing the mismatch without any need to scroll by hand.
16:44:35 <flo> for why we aren't calling this._updateAutoScrollEnabled immediately after scrolling down
16:45:07 <aleth> No idea...
16:45:37 <-- Even has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
16:45:37 <flo> the point of adding dumps in there is to get an idea ;)
16:45:44 <aleth> Been a while since I looked at that code.
16:45:46 --> Even has joined #instantbird
16:45:46 * ChanServ sets mode +o Even 
16:45:48 <flo> I suspect some scroll events may no longer be fired
16:46:09 <aleth> So some of it is a workaround? Who wrote it? 
16:46:16 --> myk has joined #instantbird
16:46:26 <flo> what's a workaround around what?
16:46:39 <aleth> I don't know :P
16:47:53 <aleth> I'm not sure I understand all of why that code is there
16:52:20 <aleth> I'll take a look at it later
16:54:16 <-- Even has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
16:58:42 <clokep_work> You know...I think wnayes has been getting up later and later each week. Must be nice to be in college still. :P
16:59:30 <flo> it's already the afternoon, right?
17:00:51 <clokep_work> It's noon for him, yes.
17:06:21 <-- gerard-majax has quit (Ping timeout)
17:10:18 --> Kaishi has joined #instantbird
17:25:07 <-- jb1 has quit (Ping timeout)
17:26:30 * jwir3 is now known as jwir3|lunch
17:27:15 <clokep_work> Bah now that I have an Apple Developer account I'm on a spam list.
17:27:32 <flo> ahah
17:27:45 <flo> vmware is good for that too ;)
17:28:48 --> jb has joined #instantbird
17:32:24 <instantbot> wnayes@gmail.com requested review from florian@instantbird .org for attachment 1646 on bug 1438.
17:32:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1438 enh, --, ---, florian, NEW, Typing the beginning of a protocol name listed in the top protocols should select it
17:32:59 <-- jb has quit (Ping timeout)
17:33:18 <flo> clokep_work: can you estimate the wake-up time by the time of reading review comments on bugzilla and attaching a new patch? ;)
17:35:48 <flo> I'm stuck on idle even though the idleService patch is already included in my nightly :(
17:35:56 --> wnayes has joined #instantbird
17:36:00 <flo> if anybody else can confirm, please reopen that bug :(
17:36:15 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
17:39:27 --> gerard-majax has joined #instantbird
17:44:56 <clokep_work> flo: Haha, maybe. :)
17:46:30 <wnayes> clokep_work: I can't argue much with your observation, I've been meaning to set that alarm... :)
17:49:09 <wnayes> It's easier to catch more people online earlier, but I'm usually more efficient later in the day :)
17:49:28 <clokep_work> wnayes: Understandable. :) I was just teasing anyway.
17:49:50 <clokep_work> But yeah, since flo is in Europe and I get to work by 7:30 EST...best bet is to catch us earlier. :-D
17:50:02 <clokep_work> But doesn't seem like you've needd too much help yet, so. :)
17:54:46 <wnayes> My biggest concern seems to be making sure I don't neglect asking for advice when things "work" but maybe not in a production-level manner. :)
17:57:58 --> DGMurdockIII has joined #instantbird
18:04:17 --> Even has joined #instantbird
18:04:17 * ChanServ sets mode +o Even 
18:07:30 <wnayes> I've been meaning to ask how the Windows Credentials module should be organized: http://hg.instantbird.org/users/wnayes/file/91c223707911/chat/modules/winCredentialStore.jsm
18:08:15 --> Lalae has joined #instantbird
18:10:23 <wnayes> Right now I have what (hopefully) are the Winapi methods in js-ctypes, but I was thinking that they could be organized in a object which the importers could access (or maybe access through some abstractions/other objects)
18:11:55 <wnayes> Maybe an easier question is how to best have an enum in JavaScript (Line 16)
18:14:11 --> Mic has joined #instantbird
18:14:12 * ChanServ sets mode +h Mic 
18:14:13 <-- Lalae has left #instantbird ()
18:14:24 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
18:14:34 --> Mic has joined #instantbird
18:14:34 * ChanServ sets mode +h Mic 
18:15:41 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
18:15:50 --> Mic has joined #instantbird
18:15:51 * ChanServ sets mode +h Mic 
18:20:16 <Mic> The only reasonable thing to do .. http://hg.instantbird.org/users/wnayes/file/91c223707911/chat/modules/winCredentialStore.jsm#l33
18:20:47 <Mic> You'll go crazy if there's a function with more than one parameter otherwise ;)
18:23:09 <-- Kaishi has quit (Quit: Kaishi)
18:23:11 <wnayes> Mic: So declare each value separately and keep a comment saying what enum they're from?
18:23:54 <Mook_as> I'd start by using |const| ;) (I think I prefer the namespaced way, but that part's more flexible)
18:26:13 <-- myk has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
18:26:35 --> myk has joined #instantbird
18:28:51 <-- Suiseiseki has quit (Ping timeout)
18:36:57 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
18:37:46 <-- FireFly_TB has quit (Ping timeout)
18:40:05 <Mic> Mook_as: is it possible to substitute the enum with (one or the other type of) integer in the function definition?
18:40:33 <Mic> *declaration ? (Ah, I never know;)
18:42:08 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
18:42:19 --> aleth has joined #instantbird
18:42:20 * ChanServ sets mode +h aleth 
18:43:27 <Mook_as> Mic: what do you mean?
18:43:42 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1647 on bug 1530.
18:43:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1530 nor, --, ---, nobody, NEW, Autoscroll subtly broken after moz13 update
18:43:51 <Mook_as> also, bah, tab-complete doesn't case-normalize when the input matches a nick
18:43:56 <aleth> ^^ I may have missed something about the thinking behind that code of course...
18:44:27 --> FireFly_TB has joined #instantbird
18:45:19 <aleth> (that code = the updateScroll logic)
18:48:48 <Mic> Mook_as: I thought that it is not possible to have enums with js-ctypes (and wanted to suggest how to work around?). I might be completely wrong, though ;)
18:49:54 <Mook_as> oh, you still need to pass in numbers, yes. but no reason to not scope the JS names with which you refer to them
18:50:32 --> Mnyromyr has joined #instantbird
18:53:31 <Mic> I meant like this: http://pastebin.instantbird.com/46517
18:55:14 <Mook_as> yeah, I see no reason that shouldn't work...
18:57:55 <wnayes> That example makes sense - that would correctly define the type in the declare() calls.
18:59:26 --> Suiseiseki has joined #instantbird
19:03:49 <Mic> Have you used these functions already?
19:04:30 <wnayes> Not yet, hopefully by the end of today :)
19:05:25 <Mic> I'm interested to know how you call functions like http://hg.instantbird.org/users/wnayes/file/91c223707911/chat/modules/winCredentialStore.jsm#l110
19:09:55 * wnayes is too, that will likely be the most important one :D
19:12:06 <Mic> (i.e. how you do that with the array and so on)
19:14:21 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
19:22:11 <-- FireFly_TB has quit (Ping timeout)
19:25:52 --> FireFly_TB has joined #instantbird
19:28:40 * jwir3|lunch is now known as jwir3
19:28:41 <-- FireFly_TB has quit (Ping timeout)
19:30:23 <myk> hmm, i'm stuck on unavailable again, even though i have today's build
19:31:21 <-- myk has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
19:31:28 --> myk has joined #instantbird
19:32:47 --> FireFly_TB has joined #instantbird
19:35:08 <-- sonny has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
19:39:16 <-- FireFly_TB has quit (Ping timeout)
19:42:45 --> FireFly_TB has joined #instantbird
19:45:42 <instantbot> aletheia2@fastmail.fm cancelled review?(clokep@gmail.com) for attachment 1645 on bug 385.
19:45:43 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 1648 on bug 385.
19:45:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=385 enh, --, ---, aletheia2, ASSI, Rejoin IRC channels after reconnect
19:58:14 <aleth> Seems we can use for...of loops now since gecko13
20:13:43 --> flo has joined #instantbird
20:13:43 * ChanServ sets mode +qo flo flo 
20:15:05 <flo> myk: it happened to me too :(
20:16:25 <instantbot> florian@instantbird.org cleared the Resolution 'FIXED' from bug 1210.
20:16:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1210 nor, --, 1.2, florian, REOP, Status stuck on away/unavailable
20:23:18 <flo> given https://bugzilla.instantbird.org/buglist.cgi?quicksearch=sw%3A1.2&list_id=2044 what seems a likely release date for 1.2?
20:26:56 <aleth> Hmm, the list seems to have grown again...
20:29:15 --> sonny has joined #instantbird
20:30:01 <clokep_work> Are for ... of loops any more useful then for each ... in loops?
20:30:09 <clokep_work> wnayes: I can look at that stuff in a bit (going hom enow)
20:30:12 <-- sonny has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
20:31:03 <flo> aleth: yeah...
20:32:09 <aleth> clokep_work: You can break out of them for example
20:32:10 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
20:32:10 <flo> given how many bugs remain and that we haven't started the string freeze nor prepared anything for the update of the website... I would say a release can't be before at least 2 weeks; but in 2 weeks that gives us the week when clokep, Even and me are offline. So not a great release target ;)
20:33:03 <flo> and after that, we are in the middle of the summer, and won't get any attention for whatever we release (everybody on vacations, ... :-/)
20:33:18 <-- Optimizer has quit (Ping timeout)
20:33:55 <aleth> clokep: ah, sorry, was thinking of .forEach()
20:35:40 <aleth> I suppose you are not supposed to use for each... in on arrays...
20:35:56 <flo> ?
20:36:11 <aleth> flo: Is there much of a choice if we want to release before TB15?
20:36:49 --> Optimizer has joined #instantbird
20:36:59 <flo> aleth: Tb 15 is at the end of August
20:37:24 <aleth> But isn't August even worse for releasing than July?
20:37:26 <flo> so if we want to release before that and can't release in June, it will have to be either in July or August, ie in the middle of the summer
20:37:36 <flo> aleth: yeah...
20:37:46 <aleth> yeah, not much June left :(
20:43:31 <aleth> clokep: So I'm not sure of the difference either.
20:46:56 <aleth> Maybe it's that for...of works for all iterable objects (including iterators/generators)?
20:56:24 --> EionRobb has joined #instantbird
20:59:00 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
21:05:47 <instantbot> aletheia2@fastmail.fm denied review for attachment 1647 on bug 1530.
21:05:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1530 nor, --, ---, nobody, NEW, Autoscroll subtly broken after moz13 update
21:09:39 --> Kaishi has joined #instantbird
21:15:13 <flo> r- are even better when I don't have to put them myself :)
21:17:08 <aleth> Hate the fact that the problem now only occurs occasionally though :( Some combination of circumstances...
21:22:03 <-- myk has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
21:22:09 --> myk has joined #instantbird
21:24:26 --> clokep has joined #instantbird
21:24:26 * ChanServ sets mode +o clokep 
21:24:29 <-- Optimizer has quit (Ping timeout)
21:25:47 <wnayes> clokep: If you decide to take a look at the winCredentialStore.jsm, I just pushed a newer version.
21:28:10 --> Optimizer has joined #instantbird
21:28:20 <clokep> wnayes: My concern right now is mostly about melting. It's ridiculously hot out.
21:28:28 <clokep> But thanks. ;)
21:31:58 * clokep goes to update
21:32:24 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
21:32:40 --> clokep has joined #instantbird
21:32:40 * ChanServ sets mode +o clokep 
21:33:13 <flo> clokep: happy moz13 regression hunting ;)
21:33:24 <clokep> flo: Failed to update. :P
21:33:33 <flo> bah :(
21:34:56 <clokep> And the download is going super slow. :(
21:35:33 <aleth> Must be thermal noise on the line ;)
21:39:59 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
21:40:24 --> clokep has joined #instantbird
21:40:24 * ChanServ sets mode +o clokep 
21:40:40 <clokep> :)
21:40:46 <clokep> Yay square Show Nick.
21:41:04 <aleth> Ready For Windows Metro (TM)
21:42:33 <clokep> wnayes: Looks like you're having a lot of fun with ctypes...
21:43:13 <clokep> How do you make that Windows only?
21:43:22 <clokep> (Note that I haven't looked at the commit, just the single file...)
21:44:09 <wnayes> I'm guessing only Windows importers will attempt to use it?
21:44:13 <clokep> I'm not a big fan of auto-initing and then having to have someone call the shutdown method, that doesn't seem very friendly to having multiple consumers.
21:44:37 <clokep> wnayes: I wonder if we should add an error check if a non-Windows system attempts to call it?
21:45:03 <clokep> And please please please make a prettier API on top of that. :-D
21:46:28 <wnayes> I'm not sure if the complete Credentials function set would be wanted, or just the functions that end up being used. That might make it a lot less intimidating in appearance. :)
21:47:05 <clokep> Well...if you've already added them all, no reason not to keep them. But if you don't need some of them, don't add them.
21:49:23 <wnayes> I wasn't sure exactly what to put them all in either (var, const, function, prototype or not, etc.). There aren't many examples out there of js-ctypes (in modules at least)
21:49:37 <clokep> Yes, there isn't. :(
21:49:55 <clokep> OK, so...take everything I say with a grain of salt as I have no idea what API you're looking at...
21:50:33 <clokep> But it would probably make sense to have a nicer API on top where you call JavaScript functions with JavaScript types that get converted to whatever needs to be done for windows, does it's thing and then returns back JavaScript stuff.
21:51:01 <flo> clokep: "I wonder if we should add an error check if a non-Windows system attempts to call it?" wouldn't the jsm file only be packaged ifdef XP_WIN in the Makefile?
21:51:03 <clokep> So you might want the ctypes stuff to be  const in the file, and then export a function/object which contains an API.
21:51:12 <clokep> flo: That works too. :)
21:51:18 <clokep> (Unless we care about wine. :P)
21:51:33 * clokep waits for Mook_as to make a joke about drinking wine...
21:52:04 <flo> I don't care about wine, only about Apple juice ;).
21:52:23 <clokep> :P
21:52:34 <wnayes> clokep: I wasn't sure if a const could have all those advapi32.declare() calls, init(), etc. (those don't seem like constant things to me :))
21:52:39 * Mook_as is too lazy to think of the right joke
21:53:08 <clokep> wnayes: The value you're assigning should be constant though.
21:54:39 <clokep> OK, so I think pretty much everything I have partial patches for will wait until 1.3...that begs the question, what can I do to get the 1.2 release closer?
21:55:09 <clokep> (I know I have a review for you aleth.)
21:57:26 <flo> clokep: any thoughts about the likely release date?
21:58:13 <clokep> flo: July 17th?
21:58:45 <flo> that will be my mother's birthday
21:58:59 <-- Knoetsch has quit (Ping timeout)
21:59:03 <flo> not sure if it's an issue or not :-D
21:59:20 <clokep> Did you already get her a present? :P
22:00:05 <flo> it's sad that it's in almost a month
22:00:22 <aleth> It could be less if we get to string freeze sooner I suppose
22:00:28 <flo> but the earliest we could do seems the 13th, and it's not even really realistic
22:00:48 <flo> aleth: string freeze today?
22:00:48 <clokep> Pretty much my thought is we announce a string freeze the end of June. Even you and I go away for a week, then have a week to catch up on backlog.
22:01:16 * clokep wonders if he has to test bug 385 again...
22:01:17 <aleth> flo: still got some patches with string changes in the review queue
22:01:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=385 enh, --, ---, aletheia2, ASSI, Rejoin IRC channels after reconnect
22:01:22 <flo> is bug 1271 the only 1.2-* that needs strings?
22:01:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1271 enh, --, ---, nobody, NEW, Missing keyboard shortcuts for "Put conversation on hold" and "Show logs"
22:01:48 <flo> aleth: you will still have some in a month though ;
22:01:49 <flo> )
22:02:17 <flo> clokep: should we worry that localizers may be in vacations too?
22:02:18 <aleth> No, I wasn't thinking of doing anything outside the 1.2-wanted list for a while
22:02:35 <clokep> flo: Then we string freeze now and give them a few weeks.
22:03:01 <flo> should we also prepare the website in advance?
22:03:34 <clokep> Probably. :)
22:03:40 <clokep> What needs to be done?
22:03:44 <clokep> Release notes. :(
22:04:14 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.88.2 [Firefox 14.0/20120612164001])
22:04:26 <aleth> bug 1518 and 385 are the only bugs in the review queue with string changes
22:04:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1518 min, --, ---, aletheia2, ASSI, Don't display the topic system message again if it hasn't changed
22:04:43 <aleth> there's also one in checkin-needed afaik
22:04:43 <instantbot> clokep@gmail.com granted review for attachment 1648 on bug 385.
22:04:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=385 enh, --, ---, aletheia2, ASSI, Rejoin IRC channels after reconnect
22:06:14 <instantbot> New Instantbird (UI) bug 1531 filed by bugi@media.fjmail.de.
22:06:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1531 min, --, ---, nobody, NEW, [de] l10n: Google Mail -> GMail
22:08:54 <-- FireFly_TB has quit (Quit: FireFly_TB)
22:18:31 <-- Optimizer has quit (Ping timeout)
22:22:08 --> Optimizer has joined #instantbird
22:24:41 --> mmkmou has joined #instantbird
22:25:34 <-- wnayes has quit (Ping timeout)
22:27:06 <flo> clokep: if you are really looking for an 1.2-* bug you can fix, maybe bug 1338?
22:27:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1338 nor, --, ---, nobody, NEW, Connect button is disabled after an account spends more than half a second in the disconnecting stat
22:28:40 <clokep> Maybe. Is that an issue w/ the account manager?
22:28:48 <flo> yes
22:28:58 <clokep> Hmm...
22:29:10 <flo> it's a race condition with the timer disabling the connect/disconnect button to avoid double clicks there
22:29:28 <flo> and JS-IRC taking more than half a second to go from disconnecting to disconnected
22:29:57 <clokep> What's the fix?
22:30:59 <flo> heh
22:31:21 --> FireFly_TB has joined #instantbird
22:31:42 <flo> the expected behavior is we should disable the "disconnect" button for half a second, and then have the "connect" button that appears and isn't disabled
22:32:07 <flo> the current behavior is, if an account takes more than half a second to go from disconnecting to disconnected, the "connected" button is disabled
22:32:10 <clokep> Ah, I see.
22:32:51 <clokep> I've definitely seen that w/ IRC, yes. :)
22:33:26 <flo> the short term fix is, find what's wrong in M orian's code
22:33:36 <flo> the longer term fix is to cleanup so that we have only one button instead of two
22:33:53 <flo> but I can't take that better fix for Tb15, as it requires moving strings from a .dtd to a .properties
22:36:42 <clokep> Right.
22:38:07 <flo> uh, the en-US repository sends changesets to the l10n builder :-/
22:47:38 <clokep> This code is super confusing. :-S
22:49:39 <flo> http://hg.instantbird.org/l10n/locales-status.html \o/
22:50:42 <aleth> :)
22:51:16 <flo> the topProtocol.prpl-*.description strings are annoying :-/
22:53:47 <-- Tomek has quit (Ping timeout)
22:55:43 --> Tomek has joined #instantbird
22:56:57 <flo> FireFly_TB: http://hg.instantbird.org/l10n/locales-status.html should work again :)
22:57:21 <clokep> flo: So this means we can finally make the pt-BR locale? :P
22:57:42 <flo> clokep: yes and no
22:58:37 <flo> the next step in fixing our l10n infrastructure is figuring out why http://buildbot-l10n.instantbird.org/waterfall has stopped producing language packs (or even doing anything) a few months ago
22:59:02 <flo> the latest job was on Sat 10 Mar 2012
23:02:48 <clokep> Ah. Right.
23:02:52 <flo> clokep: oh, and I also need to fix the script for creating a new l10n repository
23:03:17 <flo> and I'm also wondering if we shouldn't hg convert automatically the translations of chat/ from Thunderbird
23:04:04 <flo> I'm not sure there's a large benefit compared to just giving the url of the folder in the hg repository
23:04:52 <clokep> I don't know.
23:05:08 <clokep> You have the whole issue where they're on trunk and we release off of trunk.
23:05:42 <flo> if it was identical, I would just use the chat/ localizations from mozilla like we do for toolkit
23:05:53 <flo> I was suggesting pointing the translators at them, like we do for Pidgin strings
23:06:00 <clokep> I think that makes sense.
23:06:31 <-- Optimizer has quit (Ping timeout)
23:10:24 <instantbot> florian@instantbird.org granted review for attachment 1646 on bug 1438.
23:10:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1438 enh, --, ---, florian, NEW, Typing the beginning of a protocol name listed in the top protocols should select it
23:16:47 <-- mmkmou has quit (Ping timeout)
23:18:39 <clokep> So...http://pastebin.instantbird.com/46548 seems to fix bug 1338.
23:18:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1338 nor, --, ---, nobody, NEW, Connect button is disabled after an account spends more than half a second in the disconnecting stat
23:18:53 <clokep> But is kind of brute forcey.
23:19:36 <clokep> And the context menu might not fully work.
23:21:41 --> mmkmou has joined #instantbird
23:24:31 <flo> you are putting the "disabled" attribute on the opposite button?
23:27:36 <flo> clokep: what about always disabling and renabling both buttons at once in restoreButtonTimer?
23:28:49 <Mook_as> fwiw, there's a counter-bug that causes the button to un-disable if you toggle the "connect on startup" option. please don't fix that yet, I need it to reconnect ;)
23:29:37 <flo> Mook_as: my workaround was just to selected another account and then reselect it
23:29:47 <flo> Mook_as: or if there's only one account, close and reopen the window
23:32:39 <flo> clokep, aleth: thanks for the trailing white space in https://bugzilla.instantbird.org/attachment.cgi?id=1607
23:33:32 <aleth> :$ sorry!
23:35:53 <flo> aleth: https://bugzilla.instantbird.org/attachment.cgi?id=1631 are you relying on the UI doing the trim() or is it checked in another place later?
23:36:49 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
23:38:03 <aleth> If the UI doesn't check it, two things can happen: 1) it's pure whitespace and joinChat prints an ERROR and ignores the call 2) it's got leading/trailing whitespace and the JOIN may fail
23:39:13 <aleth> No, sorry, it's always 2)
23:39:36 <aleth> So it's not checked.
23:41:03 <aleth> Imho it's not ideal to duplicate such checks in joinChat for every protocol
23:41:21 <aleth> Currently we actually produce errors in the console, eg. when trying to join "  "
23:42:14 <flo> hmm... ok
23:42:42 <flo> (meaning, I don't want to argue about it, so I'll just check it in)
23:44:02 <aleth> I don't mind adding such checks in joinChat too (followup?), but then you'd probably want a comment somewhere in jsProto... to make sure that's actually done for all JS protocols?
23:45:03 <flo> I'll just do my best to forget it before tomorrow, so that I don't have to add the check in Tb's join chat dialog too ;)
23:45:39 <aleth> aha ;)
23:45:57 * aleth thinks he has a working patch for the autoscroll regression
23:47:22 <flo> aleth: "If absent, the MUC will not be reconnected automatically after disconnections." is this true?
23:47:52 <flo> I think "may not" is more likely than "will not", as it would only fail if the channel requires a password, right?
23:48:26 <flo> err, scratch that
23:51:37 <-- FireFly_TB has quit (Ping timeout)
23:54:15 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1649 on bug 1530.
23:54:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1530 nor, --, ---, aletheia2, ASSI, Autoscroll subtly broken after moz13 update
23:54:28 <flo> aleth: shouldn't the ircChannel constructor clean up aAccount._chatRoomFieldsList after setting this._chatRoomFields?
23:55:53 <aleth> It's done by line 213 in ircBase.
23:58:40 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1649 on bug 1530.
23:58:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1530 nor, --, ---, aletheia2, ASSI, Autoscroll subtly broken after moz13 update