All times are UTC.
00:05:11 <-- Bollebib has quit (Quit: Instantbird 1.1) 00:07:29 <instant-buildbot> build #271 of linux-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/271 00:21:10 <-- clokep has quit (Input/output error) 00:30:47 --> clokep has joined #instantbird 00:30:47 * ChanServ sets mode +o clokep 00:31:47 <-- devfil has quit (Client exited) 01:27:03 --> Nakp has joined #instantbird 01:27:07 <Nakp> sup sup sup 01:28:17 <meh> 1,0ï¼äºº5â 1,0â¿â¿5 â1,0人＼ 01:28:37 <Nakp> lol 01:28:49 <Nakp> anyone knows how to change the sound theme? 01:28:57 <Nakp> its not an option.. but its a must for me.. 01:29:43 <clokep> Nakp: You can replace it with an extension. 01:29:53 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 01:29:53 <Nakp> is there finally one? D: 01:29:58 <Nakp> fuck 01:29:59 --> clokep has joined #instantbird 01:29:59 * ChanServ sets mode +o clokep 01:30:01 <Nakp> lol 01:30:04 <Nakp> is there finally one? D: 01:30:20 <clokep> Finally one what? 01:30:24 --> wnayes has joined #instantbird 01:30:25 <Nakp> extension? 01:30:32 <clokep> What? 01:30:48 <instant-buildbot> build #240 of macosx-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/240 01:31:03 <Nakp> you just said i could replace sounds using an extension 01:31:29 <clokep> Yes, you should be able to override the path to the sounds in an extension. 01:31:55 <Nakp> so you mean.. i should make an extension? 01:32:04 <Nakp> i dont even know which the paths are 01:33:39 <Nakp> i know its based on pidgin, so i could use somehow a pidgin sound theme, i think 01:33:48 <Nakp> but i cant even find the sound files 01:34:54 <Nakp> sound themes are in the wish list 01:35:47 <Nakp> but the wiki has nothing about sound files 01:35:56 <Nakp> Even? 01:36:03 <clokep> Please don't ping random people. 01:36:07 <clokep> It's rude. 01:36:13 <Nakp> hes not random 01:36:17 <Nakp> is he? x_X 01:36:19 <Nakp> are you? 01:36:31 <clokep> And yes, I was saying an extension could be made that included other sound files and overrode the internal sounds. 01:36:36 <Nakp> you both have voice so i think you might be developers or somehow involved in the project 01:36:46 <Nakp> sorry.. op 01:36:56 <clokep> All the paths are at http://lxr.instantbird.org/instantbird/source/instantbird/modules/ibSounds.jsm#13 01:37:21 <clokep> Yes, we are. Eve n runs our servers. 01:37:39 <clokep> You wouldn't directly be able to use a Pidgin sound theme, no. 01:37:44 <clokep> It would need to be repackaged. 01:38:24 <Nakp> even just replacing original files would work for me 01:38:48 <Nakp> i dont really care about developing an extension as my smiley theme was never reviewed by devs 01:39:21 <Nakp> it might be for personal use only... so... replacing files is just fine 01:43:17 <clokep> Did you put it up for review? 01:43:39 <clokep> You can replace the files if you want, btu they'll be overwritten each time you update Instantbird. 01:43:52 <clokep> They're located in the omni.ja file inside the Instantbird installation diretory. 01:45:08 <Nakp> i placed it just today, i just remembered i used instantbird as a year ago that option didnt exist 01:45:20 <Nakp> https://hg.instantbird.org/addons/file/26129a5def76/noblistsounds/overlay.mn 01:45:21 <Nakp> that file 01:45:51 <Nakp> im just checking an addon example so i can make something similar 01:46:10 <Nakp> alike 01:46:25 <clokep> Yes, that's exactly how you would do it. Obviously you'd replace empty.wav with whatever you'd like. :) 01:47:30 <Nakp> ok.. but that folder only has that file and a makefile 01:47:52 <Nakp> ah.. and skin folder with the sounds to be used 01:48:23 <Nakp> are those all files i need? 01:54:40 <clokep> Well, oncfe you run make (a few times possible?) you'll end up with an install.rdf and an xpi file. 01:55:23 <Nakp> actually im using windows.. 01:56:15 <Nakp> but... i can use my old files :P 01:56:28 <Nakp> its instal.rdf, chrome.manifest and chrome folder 01:56:41 <Nakp> but.. i dont know where to place the override instructions 01:57:55 <instant-buildbot> build #259 of win32-onCommit is complete: Failure [failed compile] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/259 blamelist: aleth <aletheia2@fastmail.fm>, Florian Qu?ze <florian@instantbird.org>, Patrick Cloke <clokep@gmail.com> 02:00:30 <clokep> What do you mean "place the override instructions"? 02:00:50 <clokep> You mean the lines from overlay.mn? 02:00:52 <Nakp> override chrome://instantbird-sounds/skin/login.wav chrome://addon/skin/login.wav 02:00:54 <Nakp> yup 02:01:00 <clokep> They should be in the manifest file that's there. 02:02:53 <clokep> chrome.manifest. 02:02:57 <clokep> Had to look up the name. :) 02:03:35 <Nakp> ok my old manifest had 02:03:36 <Nakp> skin goldfaces classic/1.0 chrome/skin/ 02:03:45 <Nakp> because it was a smileys addon 02:03:55 <Nakp> i should just place the override lines? 02:04:03 <clokep> Yup. 02:04:08 <clokep> You'll need one for each file you're overriding. 02:05:03 <Nakp> ok ok.. no problem 02:05:11 <Nakp> ill make it, then i tell you 02:05:14 <clokep> Idk if files besides wavs work btw, so I would stick with wavs. :) 02:06:23 <Nakp> thats what im doing atm.. 02:07:16 <clokep> Btw if you have questions about getting an add-on reviewed or whatever, you want to talk to "Mic", who's not here right now. 02:07:19 <clokep> But he's usually around. 02:08:03 <clokep> The site is confusing, I know we've had people /think/ they've requested a review when they haven't really before. :-/ 02:08:28 <Nakp> i never did... there was not such option about a year ago 02:08:36 <Nakp> i had to request it here 02:08:49 <clokep> What do you mean "not such option", it's always been there. 02:08:55 <clokep> Well, it's not a "review" as such. 02:09:06 <clokep> it's to make it not be an "experimental" add-on. 02:09:27 <clokep> We don't officially review add-ons, they're not part of the core code. 02:09:45 <clokep> But of course we'll review stuff if you request it. 02:10:20 <Nakp> well.. i just saw i could request my addon to go public 02:10:30 <clokep> Yup! :) 02:10:32 <Nakp> there was not such option at the website by the time i made it 02:10:42 <Nakp> i had to wait for someone to review it 02:10:58 <Nakp> and i requested here to review it so could go public 02:11:02 <Nakp> that never happened xD 02:14:11 <clokep> Yes there was. We never change that website. 02:15:16 <clokep> I vaguely recall that, but I think Mic wanted you to request to make it public (he can't just go in and mark something as public, there has to be a request first). 02:29:18 <Nakp> oh.. well i never saw that option before and its pretty obvios for me now 02:29:26 <Nakp> heres a question :P 02:30:11 <Nakp> whats the url scheme? :/ 02:30:18 <Nakp> chrome://instantbird-sounds/skin/alert.wav chrome://marimba-sounds/skin/alert.wav 02:30:44 <Nakp> lets say my addon is called marimba sounds and the id is marimba-sounds@instantbird.org 02:31:50 <clokep> OK. 02:32:33 <clokep> You need to define the path to marimba-sounds then. 02:33:12 <Nakp> yeah.. thats the path.. i just want to know if its correct 02:33:20 <Nakp> because.. its not working for me u_U 02:33:26 <clokep> You have to define the path 02:33:32 <clokep> It's not generated automatically. 02:33:44 <Nakp> override chrome://instantbird-sounds/skin/alert.wav chrome://marimba-sounds/skin/alert.wav 02:33:46 <Nakp> thats the line 02:33:56 <clokep> Yes, 02:34:04 <clokep> Give me a second. I'm trying to find an example. :P 02:34:42 <Nakp> ok ok 02:34:56 <clokep> You need a line to define what that actually means, like: 02:34:56 <clokep> skin marimba-sounds classic/1.0 <path from the root of your extension> 02:35:01 <clokep> So something like: 02:35:09 <clokep> skin marimba-sounds classic/1.0 skin/ 02:35:12 <clokep> I think should work. 02:35:24 <clokep> I have to go though. Good luck. :) 02:35:40 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 02:44:24 <Nakp> i made it :D 03:04:10 <Nakp> ill upload it :P see ya all 03:04:13 <-- Nakp has quit (Quit: Saliendo) 03:16:48 <-- wnayes has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 03:41:31 <instant-buildbot> build #524 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/524 04:19:24 --> FeuerFliege has joined #instantbird 04:27:55 --> DGMurdockIII has joined #instantbird 04:42:36 <-- FeuerFliege has quit (Connection reset by peer) 04:42:55 --> Nakp has joined #instantbird 04:43:10 <-- Nakp has quit (Quit: Saliendo) 05:06:33 <instant-buildbot> build #616 of win32-nightly-default is complete: Failure [failed compile] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/616 05:31:51 --> TestFliege has joined #instantbird 05:32:42 <-- TestFliege has quit (Quit: TestFliege) 05:32:56 --> FireFly_TB has joined #instantbird 05:34:01 --> FeuerFliege has joined #instantbird 05:52:07 <-- FireFly_TB has quit (Quit: FireFly_TB) 06:02:29 <instant-buildbot> build #513 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/513 06:12:28 <-- EionRobb has quit (Quit: Leaving.) 06:18:37 <-- Even has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 06:18:48 --> Even has joined #instantbird 06:18:49 * ChanServ sets mode +o Even 06:22:51 --> FireFly_TB has joined #instantbird 06:30:09 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.88.2 [Firefox 14.0/20120605113340]) 06:42:02 <-- meh has quit (Quit: I don't want to live on this planet anymore.) 07:11:16 --> gerard-majax has joined #instantbird 07:31:08 --> Optimizer has joined #instantbird 07:33:05 <-- Mook has quit (Quit: ChatZilla 0.9.87-rdmsoft [XULRunner 6.0/20110811165603]) 07:39:21 --> jb has joined #instantbird 08:02:16 --> jb1 has joined #instantbird 08:02:56 <-- jb has quit (Ping timeout) 08:04:57 --> chrisccoulson has joined #instantbird 08:07:53 --> jb has joined #instantbird 08:16:28 --> Mic has joined #instantbird 08:16:28 * ChanServ sets mode +h Mic 08:32:01 <Mic> Good morning 08:32:29 --> sonny has joined #instantbird 08:40:16 <-- skeledrew has quit (Ping timeout) 08:43:17 <-- chrisccoulson has quit (Quit: Ex-Chat) 08:45:24 <-- aleth has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 08:45:38 --> aleth has joined #instantbird 08:45:38 * ChanServ sets mode +h aleth 08:45:55 --> chrisccoulson has joined #instantbird 08:49:34 <-- jb has quit (Quit: jb) 08:50:32 --> jb has joined #instantbird 08:52:51 --> Optimizer1 has joined #instantbird 08:52:57 <-- Optimizer has quit (Ping timeout) 08:54:06 --> mmkmou has joined #instantbird 08:55:29 --> flo has joined #instantbird 08:55:30 * ChanServ sets mode +qo flo flo 08:55:49 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 08:56:05 --> flo has joined #instantbird 08:56:05 * ChanServ sets mode +qo flo flo 09:05:04 <Mic> flo: you might already know but the Windows nightly build failed compiling. 09:05:28 <flo> Mic: I was pondering sending a patch to Pidgin for that, or just checking in the fix and moving on :) 09:05:30 <Mic> (the oncommit build too iirc) 09:06:32 <flo> so yes, I already know :) 09:12:33 <flo> some new warnings in my terminal (for the debug build where I connected MSN): WARNING: Failed to cancelWatch: socket not found: file /Users/florian/buildhg/hg.instantbird.org/purple/purplexpcom/src/purpleSockets.cpp, line 378 09:12:34 <flo> (3 times) 09:12:49 <flo> there's an MSN and an AIM account connected 09:23:26 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/6417d64517d7 - Patrick Cloke - Bug 1491 - MPL 2.0 for random (mostly build system related) purple/ files, r=fqueze. 09:23:27 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/392231064149 - Florian Quèze - Bug 1337 - Update libpurple to 2.10.4 - Follow-up to fix Windows build bustage. 09:25:45 <-- jb1 has quit (Ping timeout) 09:25:54 <-- jb has quit (Ping timeout) 09:28:32 --> pvagner has joined #instantbird 09:43:34 <-- Optimizer1 has quit (Ping timeout) 09:43:38 --> Optimizer has joined #instantbird 09:44:04 <-- Optimizer has quit (Input/output error) 09:44:57 --> Optimizer has joined #instantbird 10:05:46 --> jb has joined #instantbird 10:13:40 --> jb1 has joined #instantbird 10:14:47 <-- jb has quit (Ping timeout) 10:17:38 --> clokep has joined #instantbird 10:17:38 * ChanServ sets mode +o clokep 10:20:18 <clokep> Yes, we should probably upstream that, as annoying as it may be. :P 10:21:36 <instantbot> clokep@gmail.com set the Resolution field on bug 1491 to FIXED. 10:21:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1491 tri, --, 1.2, clokep, RESO FIXED, MPL 2.0 for random purple/ files 10:23:09 <flo> I gave the link to my changeset in the pidgin xmpp room 10:23:40 <flo> in the future for such trivial fixes, I may want to "just check it in" once I get commit access 10:27:36 <clokep> I see. :) 10:45:59 --> Even1 has joined #instantbird 10:46:03 <-- Even1 has quit (Quit: Even1) 10:46:09 --> Even1 has joined #instantbird 10:51:40 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 10:57:25 <-- jb1 has quit (Ping timeout) 10:59:26 <-- Mic has quit (Input/output error) 10:59:32 --> Mic has joined #instantbird 10:59:32 * ChanServ sets mode +h Mic 11:04:37 <Mic> instantbot doesn't announce new bugs any longer? 11:04:41 <instantbot> Mic: Sorry, I've no idea what 'doesn't announce new bugs any longer' might be. 11:05:00 <Mic> instantbot: maybe that's the problem ;) 11:05:03 <instantbot> Mic: Sorry, I've no idea what 'maybe that's the problem ;)' might be. 11:06:58 <flo> Mic: it's possible it only announces them for "Core" and "Instantbird (UI)" 11:07:38 <Mic> OK, thanks. 11:07:56 <Mic> bye 11:07:59 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 11:09:53 <-- Optimizer has quit (Ping timeout) 11:19:46 --> Optimizer has joined #instantbird 11:42:18 --> clokep_work has joined #instantbird 11:42:18 * ChanServ sets mode +o clokep_work 11:43:16 <clokep_work> Have we updated any other add-ons (like bug 1503)? 11:43:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1503 enh, --, ---, nobody, NEW, Update Show Nick on AIO 11:44:55 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client) 11:48:44 <-- SM0TVI has quit (Ping timeout) 11:50:22 --> clokep_work has joined #instantbird 11:50:22 * ChanServ sets mode +o clokep_work 11:50:52 --> SM0TVI has joined #instantbird 11:55:05 <clokep_work> I think Status Reminder, Do Not Disturb, Show Nick and Hide Auto-Joins all need to be updated. 12:14:53 --> EionRobb has joined #instantbird 12:16:36 <-- EionRobb has quit (Ping timeout) 12:28:48 --> jb has joined #instantbird 12:30:30 <-- Even1 has quit (Ping timeout) 12:33:56 --> Even1 has joined #instantbird 12:34:26 <-- Kaishi has quit (Quit: Kaishi) 12:34:30 --> Kaishi has joined #instantbird 12:44:27 --> meh has joined #instantbird 12:53:10 --> Tomek has joined #instantbird 12:56:21 <-- Even1 has quit (Ping timeout) 12:56:39 <-- Optimizer has quit (Ping timeout) 12:57:44 --> Lalae has joined #instantbird 12:59:41 --> Even1 has joined #instantbird 13:01:55 --> Optimizer has joined #instantbird 13:04:28 <-- Kaishi has quit (Quit: Kaishi) 13:07:23 <-- Lalae has left #instantbird () 13:38:39 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 13:56:12 <-- Tomek has quit (Quit: Instantbird 1.1) 13:56:26 --> Tomek has joined #instantbird 13:59:28 <-- FireFly_TB has quit (Quit: FireFly_TB) 13:59:48 --> TestFliege has joined #instantbird 13:59:53 <-- TestFliege has quit (Quit: TestFliege) 14:02:11 --> jb1 has joined #instantbird 14:02:54 <-- jb has quit (Ping timeout) 14:03:29 <-- pvagner has quit (Ping timeout) 14:09:44 <-- Tomek has quit (Client exited) 14:14:45 --> Tomek has joined #instantbird 14:23:56 <-- sonny has quit (Ping timeout) 14:27:21 --> sonny has joined #instantbird 14:35:20 <clokep_work> Looks like wnayes is making good progress on the Pidgin importer! 14:37:11 <-- meh has quit (Ping timeout) 14:40:00 <clokep_work> Mic: Do you know what's up with the email we got about the dictionary listing of AIO? :) 14:42:05 <-- Optimizer has quit (Ping timeout) 14:43:17 --> mmkmou has joined #instantbird 14:44:09 --> Optimizer has joined #instantbird 14:44:38 <-- Optimizer has quit (Input/output error) 14:45:16 --> Optimizer has joined #instantbird 15:19:49 <-- gerard-majax has quit (Ping timeout) 15:45:33 --> jb has joined #instantbird 15:45:51 <-- jb1 has quit (Ping timeout) 15:46:19 <flo> clokep_work: apparently this http://lxr.instantbird.org/instantbird/source/chat/chat-prefs.js#90 is annoying to some Tb developers. I'm wondering if it's better to move the ifdef debug loglevel = 2 to instantbird/app/profile/all-instantbird.js or to put a loglevel -> 3 in mail/components/im/all-im.js. Any opinion? 15:46:30 <-- Optimizer has quit (Ping timeout) 15:46:41 <-- Tomek has quit (Quit: Instantbird 1.1) 15:47:27 <clokep_work> flo: I'd rather overwrite it in all-im.js. 15:48:47 <flo> (just do be sure) so you think showing all low level exchanged messages in the terminal for debug builds is a good default for chat/ in general and not only ib? 15:50:05 <clokep_work> I think so, do you disagree? 15:50:23 --> Optimizer has joined #instantbird 15:50:24 <clokep_work> Well maybe not. 15:50:28 <flo> overwriting it in all-im.js is only a one line change, and a single commit 15:50:37 <clokep_work> I'd really like to move all that out of the error console. :-/ 15:50:38 <flo> the other way sounds cleaner, but significantly more work ;) 15:50:55 <flo> I'm more talking about the terminal than the error console :) 15:51:41 <clokep_work> Oh. Mook was complaining abou tthat the other day too... 15:51:44 <clokep_work> Do we also log them to the terminal? 15:52:28 <aleth> Terminal output is much more useful than the error console 15:52:57 <aleth> (for logs rather than error messages) 15:53:39 --> wnayes has joined #instantbird 15:54:00 --> Tomek has joined #instantbird 15:54:34 <flo> clokep_work: yes we do. The error console is useless to see what's going on at shutdown 15:55:02 <flo> + the error console requires too much clicking, is difficult to copy paste, etc... 15:55:22 <flo> it's just good enough for reporting a bug from a nightly or release, not to really debug something 15:55:39 <-- Optimizer has quit (Ping timeout) 15:55:49 * clokep_work usually uses the error console... 15:55:57 <flo> aleth: it's too bad that some errors only go to the error console and not the terminal :( 15:56:27 <flo> clokep_work: the only interesting point of the error console is: we can click source code links to see immediately what the blamed code is :) 15:56:50 <clokep_work> flo: I generally find there's too muhc garbage in the console to make it useful. 15:57:15 <clokep_work> I'm OK w/ ifdefing it either way, but I think it makes sense to default to "on" if you're compiling chat/. 15:57:24 <clokep_work> But maybe that's my opinion because I usually want to see those messages. :-D 15:57:37 <flo> I also usually want to see these messages 15:57:53 <flo> (otherwise I wouldn't have added that ifdef debug in the first place ;)) 15:59:08 --> Optimizer has joined #instantbird 16:01:31 --> FireFly_TB has joined #instantbird 16:02:23 --> meh has joined #instantbird 16:03:29 <-- Optimizer has quit (Ping timeout) 16:03:59 <clokep_work> :) 16:04:21 <clokep_work> I wouldn't really think it would annoy people running debug builds unless they're doing things in chat/ though? 16:06:29 <flo> yeah, I'm not really sure why they would run a debug build with configured chat accounts 16:07:26 --> Optimizer has joined #instantbird 16:08:11 <clokep_work> Maybe we can ask? :) 16:09:29 <flo> I'll just overwrite it in all-im.js 16:09:33 <flo> I have that patch already :-D 16:10:12 <clokep_work> OK. :) 16:12:38 <flo> boo, Firefox crashed while I was filing a bug 16:15:06 <-- Optimizer has quit (Ping timeout) 16:16:29 <-- jb has quit (Ping timeout) 16:18:42 --> Optimizer has joined #instantbird 16:22:29 --> NmN has joined #instantbird 16:22:43 <-- NmN has quit (Quit: Instantbird 1.1) 16:25:50 <-- Optimizer has quit (Ping timeout) 16:26:57 * clokep_work was just wondering if flo would post a screenshot there...;) 16:27:12 <flo> heh 16:27:20 <clokep_work> Looks nice. :) 16:27:27 <flo> it was difficult to screenshot as I wanted the tooltip and cursor too ;) 16:27:56 <clokep_work> Only XMPP though? 16:28:13 <flo> yeah 16:28:14 <clokep_work> I guess prplIAccountBuddies aren't really associated with the addressbook, right? 16:28:23 <flo> facebook chat usernames are meaningless :( 16:28:44 <flo> for irc it's complicated without the network in the "IRC" field of the address book card (so I haven't even put an IRC field there) 16:28:46 --> myk has joined #instantbird 16:28:57 <clokep_work> Yeah, that's what I assumed... 16:29:07 --> Optimizer has joined #instantbird 16:29:18 <clokep_work> Right, Facebook chat names aren't useful unless you could read Facebook messages, I guess. 16:29:24 <flo> presence is meaningless for twitter 16:29:41 <clokep_work> But XMPP includes GTalk, right? 16:30:04 <flo> how is that a problem? 16:30:16 <clokep_work> Where did I say it was a problem? :P 16:30:29 <flo> tomorrow :-P 16:30:39 <clokep_work> It should include GTalk. :) 16:32:58 <flo> I use whatever (without even checking the prpl) has a contact.preferredBuddy.normalizedName matching (in this order) : the email address; the email's ab card's Gtalk field; the email's ab card's Jabber Id field. 16:33:15 <clokep_work> Ah, cool. :) 16:33:28 <flo> that's the least crappy algorithm I could find :) 16:34:02 <clokep_work> Makes sense to me. :-D 16:34:23 <clokep_work> Ah, lunch time. :) 16:34:28 <flo> without associating nsIAbCard <--> prplIAccountBuddy, it's impossible to get it right; and we decided a long while ago that we wouldn't be doing that, so... :) 16:34:31 <-- Optimizer has quit (Ping timeout) 16:34:32 <flo> at least it will pretend to work 16:34:44 <clokep_work> Ah, how come? 16:34:57 <flo> Facebook for example ;) 16:35:14 <flo> If I'm talking to someone on Facebook and exchanging emails, it would be "right" to detect it 16:35:17 <flo> but we won't 16:35:45 <clokep_work> Wait, so...why wouldn't you associate the two together then, if it would make it "right"? 16:35:53 * clokep_work is confused. :-S 16:35:58 <flo> it would be different kinds of wrong 16:36:16 <flo> in the ab we want to be able to store info that we know, even without having an account for that protocol 16:36:19 --> Optimizer has joined #instantbird 16:36:30 <flo> and adding some chat info there shouldn't send authorization requests 16:36:54 <flo> and keeping the information of which account buddy to use to contact someone also wouldn't fit well there 16:41:12 <-- Optimizer has quit (Ping timeout) 16:45:21 --> Optimizer has joined #instantbird 16:48:30 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 16:53:06 --> Mook_astb has joined #instantbird 17:05:26 <-- Optimizer has quit (Ping timeout) 17:06:40 <-- harisund has quit (Ping timeout) 17:06:41 --> harisund has joined #instantbird 17:06:50 <-- Mook_astb has quit (Quit: Mook_astb) 17:07:09 --> Mook_astb has joined #instantbird 17:09:33 --> Optimizer has joined #instantbird 17:24:06 <clokep_work> flo: OK, that makes sense. :) 17:36:02 <-- Optimizer has quit (Ping timeout) 17:39:24 <-- Tomek has quit (Client exited) 17:39:26 --> Optimizer has joined #instantbird 17:41:43 * Mook_astb is now known as Mook_as 17:42:17 <clokep_work> Mook_as: Do you want me to make you an extension to send a NICK signal on log in? It'll take me all of ten minutes. :) 17:42:38 <Mook_as> clokep_work: yes please, but it needs to support nickserv passwords ;) 17:42:43 <clokep_work> I'm hoping to look at renaming accounts "soon" though (probably after 1.2). 17:44:20 <Mook_as> I started looking _very_ briefly yesterday and got distracted by the difficulty involved in getting a repl-friendly unwrapped instance of the irc connection :p 17:47:35 <clokep_work> What is repl? 17:47:48 <Mook_as> read-eval-print loop? a shell? 17:48:04 <clokep_work> Ah... 17:48:19 <clokep_work> Well you just want the account object and call sendRawMessage on it though. 17:48:24 <Mook_as> silly XPCNativeWrapper.unwrap() doesn't work the way I want it to :p 17:48:31 <clokep_work> The extension you'll need is essentially https://bitbucket.org/clokep/irc-extras/src/6f778f17172a/example/bootstrap.js 17:48:44 <Mook_as> yeah, that was more about poking live objects to figure out what it's doing so I can write code without restarting :p 17:49:39 <clokep_work> You'd also want to this.sendMessage("NICK", "Mook_as"); before the IDENTIFY call. 17:49:56 <Mook_as> yes, yes I do :) 17:50:10 <clokep_work> You'd also probably want to move the IDENTIFY send into a response of the NICK message... 17:50:19 <clokep_work> I'll play with it tonight. 17:50:37 <Mook_as> https://bitbucket.org/clokep/irc-extras/src/6f778f17172a/example/bootstrap.js#cl-18 is confusing given https://bitbucket.org/clokep/irc-extras/src/6f778f17172a/example/bootstrap.js#cl-13 :p 17:51:02 <clokep_work> How so? :-S 17:51:23 <Mook_as> this.name isn't this.name! (i.e. different |this| ) 17:51:25 <clokep_work> It should probably be named "Autoidentify Example" or something. 17:51:29 <clokep_work> Ah... 17:51:49 <clokep_work> Well, yes. I like to .call() things. ;) 17:52:28 <clokep_work> Mook_as: http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/ircHandlers.jsm#13 maybe? :p 17:52:37 <Mook_as> I'd probably modify it at some point to get the nick off a pref of some sort, instead. but that's for after-work :) 17:53:09 <clokep_work> I should probably document this stuff at some point. 17:53:33 <Mook_as> but yes, that helps immensely. I'll probably be able to get something once I get the free time to write it XD 17:54:23 <clokep_work> I find it super easy to add onto what the protocol supports...but I also designed the whole thing, so that doesn't mean much. :) 17:55:07 <clokep_work> I'll add a comment saying to checkout ircHandlers.jsm though for the fields. :) 17:58:07 --> Mic has joined #instantbird 17:58:07 * ChanServ sets mode +h Mic 17:59:44 <clokep_work> Hello. :) 18:00:55 <Mic> Hi 18:03:13 --> gerard-majax has joined #instantbird 18:03:24 <Mic> Interesting look: http://i.imgur.com/krmlB.png ;) 18:05:04 <Mic> Maybe the account binding cleanup will also help against the focus issues when navigating the list with the keyboard? 18:05:55 <clokep_work> Someone needs to do it though. :P 18:12:02 --> Tomek has joined #instantbird 18:14:33 <Mic> clokep_work: which email was that that you talked about at http://log.bezut.info/instantbird/today#m263? 18:15:26 <Mic> A search for "dictionar" and 2012 only returned hits from bugmail. 18:15:35 <Mic> Maybe another one that got lost in my spam folder? 18:17:28 <clokep_work> Mic: http://groups.google.com/group/instantbird-contact/browse_frm/thread/819f15bee925946e 18:19:06 <clokep_work> There's a lot of spam in there. :( 18:21:00 <Mic> No, I've definitely seen this email before. My email search doesn't find it though :/ 18:22:00 <clokep_work> You generally have more knowledge about 1. AIO, 2. Dictionaries than me, so I figured I'd ask if you know anything. :) 18:24:27 <Mic> I can't remember seeing a maximum size for extensions mentioned somewhere on AIO but obviously there's a limit. 18:25:12 <clokep_work> Yeah, I couldn't find it in the source, but it might just be the max size PHP allows for uploads. 18:25:37 <clokep_work> Which is apparently a setting in php.ini. 18:26:21 <Mic> It didn't occur to me to look at the source ;) 18:26:28 <Mic> http://log.bezut.info/instantbird/120529/#m113 18:26:53 <Mic> I think that was in response to reading his email. 18:28:58 <clokep_work> Perhaps. 18:29:10 <clokep_work> The other issue (of not all directories being listed) seems bad too. :( 18:31:07 <Mic> :o 18:32:00 <Mic> The list is indeed incomplete. How come? :( 18:32:44 <Mic> This is a bit better: https://addons.instantbird.org/en-US/instantbird/browse/type:3/cat:9 18:32:53 <clokep_work> Yeah... 18:35:25 <clokep_work> http://hg.instantbird.org/websites/remora/file/ced2afed6de3/site/app/views/addons/dictionaries.thtml seems to be that view. 18:35:29 <clokep_work> (Not sure if you know PHP...) 18:35:40 <clokep_work> I happened to have learned to program in it pretty much. ;) 18:35:44 <clokep_work> wnayes: Great progress so far. :) 18:37:17 <wnayes> clokep_work: Thanks :) Looks like mIRC importing is working now as well. 18:38:55 <instantbot> New Websites - addons.instantbird.org (Remora) bug 1504 filed by benediktp@ymail.com. 18:38:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1504 nor, --, ---, raynaudquentin, NEW, List of dictionaries incomplete (most dictionaries not listed) 18:39:45 <Mic> I programmed a lot in PHP like .. 10 years ago? 18:39:49 <-- sonny has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 18:40:11 <Mic> Uh, most likely that's even longer already. 18:41:07 <Mic> I guess today's PHP won't have much in common with the old one anymore (but Remora could even date back to this time?;) 18:45:20 <instantbot> raynaudquentin@gmail.com set the Resolution field on bug 1504 to WONTFIX. 18:45:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1504 nor, --, ---, raynaudquentin, RESO WONTFIX, List of dictionaries incomplete (most dictionaries not listed) 18:47:54 <Even> Mic: I hope I was clear enough about your bug. 18:48:24 <Even> This is really not perfect but patching AIO for this will really create a bad interest/work ratio. 18:48:26 <clokep_work> wnayes: Good. :) By the way, it might be good to do some tests / include some test files somewhere... 18:49:31 <clokep_work> Mic: So can you set that field then? :) 18:49:31 <Mic> Even: where can I find this target locale field? 18:49:49 <Even> You have to go to edit addon 18:49:58 <Even> properties 18:50:04 <Even> and it is in "admin settings" 18:50:15 <Even> in the same spot were you can set the addon as trusted 18:51:28 <Even> You HAVE TO set Target Locale & if there is more than one dic / langpack for the same target locale better to set also the "Additional Locale Info" field 18:53:03 <wnayes> clokep_work: I was just going to look into how xpcshell tests work. 18:53:26 <aleth> wnayes: if you find a good reference for that, I would be interested in it too 18:53:35 * aleth should learn how to write tests... 18:54:00 <Mic> I know "Edit add-on -> properties" only from my own "Developer tools" pages for my own add-ons. I can't find it in the Editor tools for reviewing other people's add-ons. 18:54:08 <clokep_work> I have a good reference aleth and wnayes . 18:54:10 <clokep_work> Give me a few minutes. 18:55:27 <Even> When reviewing an addon you should have an "dit item" button on the page 18:55:35 <Even> *"edit item" 18:55:37 <Even> sry 18:55:49 <clokep_work> aleth: wnayes https://developer.mozilla.org/en/Writing_xpcshell-based_unit_tests and https://developer.mozilla.org/en/Xpcshell 18:56:01 <clokep_work> https://developer.mozilla.org/en/Running_automated_tests too 18:56:16 <Even> More generally, https://addons.instantbird.org/en-US/developers/edit/<addon_id> should work well 18:56:29 <clokep_work> wnayes: I'll try to look over your patch at some point too (I assume it hasn't changed too drastically). 18:56:53 <Mic> I tried this already and I'm getting "Access denied - You are not authorized to view this page." 18:57:00 <Even> Ok. 18:57:05 <Even> Then there is a permission issue. 18:57:08 <Even> I hate this. 18:57:22 <clokep_work> :( Sorry Even. 18:57:23 <Mic> Maybe it's admins-only, yes 18:57:33 <aleth> clokep_work: thanks! 18:57:43 <Even> Yeah... 18:57:53 <Even> Mic is in the Editors group so he should be able to... Edit. 18:57:54 <clokep_work> And we have a few examples for the IRC code, but they might not be the best examples ever. :-D 18:57:58 <Even> Pfff. 18:58:09 <wnayes> clokep_work: Thanks for the links! Aside from what flo mentioned on the patch, things aren't too different. 18:58:09 <Mic> Let's agree that the software sucks? ;) 18:58:42 <Mic> And thanks for making this clear. I'll be off for a while now. 18:58:57 <clokep_work> Mic: Any chance you could respond to that email sometime soon? :) 18:58:59 <Even> Mic: yeah it does 19:00:38 <Mic> clokep_work: yes, I'll do when I come back. Even answer should to answer his mail. 19:00:46 <clokep_work> Thanks! 19:00:48 <Mic> Eve n's 19:01:27 <Mic> pah, "Eve n's answer should help to answer his email" that's what I meant to say ;) 19:02:29 <clokep_work> :) 19:02:32 <clokep_work> I understood! 19:03:45 <clokep_work> wnayes: One thing I remember...I'd prefer a link to the real reference page for all the stuff, not just pidgin.im (although it might be useful too). 19:05:40 <wnayes> clokep_work: I haven't really found any references for accounts.xml (pidgin) or mirc.ini so far... basically just changing settings and learning where things are put. 19:05:50 <aleth> You could always link to the IB wiki if that's a more convenient place to list things 19:06:09 <aleth> Oh, I see. No docs exist... 19:06:10 <clokep_work> Please do not do that. 19:06:21 <clokep_work> If no doc exists, that's fine. I thought there was one for Pidgin though! 19:06:25 <clokep_work> Let me see if I can find it for you. 19:06:42 <clokep_work> wnayes: I highly doubt mirc has one...that guy just does random stuff without documenting anything. :( 19:07:08 <aleth> I remember you having fun with his color encoding "scheme" :-/ 19:07:49 <clokep_work> aleth: Yes, I just foudn out some of my code doesn't work for that too. ;) 19:08:01 <clokep_work> wnayes: http://developer.pidgin.im/wiki/ConfigurationFiles was what I was thinking of (and maybe that link should be included?) 19:10:09 <wnayes> clokep_work: Looks like a good overview, I'll add that. 19:11:59 <clokep_work> Thanks! 19:13:12 <clokep_work> http://www.mirc-support.de/help/mircini/ might be helpful, but isn't official. 19:13:47 <wnayes> Not sure what to really write tests for so far, file parsing tests would make sense but I'm not sure if I would need to basically duplicate code in the tests (or export things from the importer.js files?) 19:14:22 <-- SM0TVI has quit (Quit: I view things as they are, without regard to place or person; my country is the world, and my religion is to do good. -- Thomas Paine (*1737 â 1809)) 19:14:54 <clokep_work> wnayes: I think what you would want is "given this file, use the importer and check that it finds the proper accoutns" 19:15:01 <clokep_work> So you'd hard code the "correct" values. 19:17:56 <wnayes> Might need the tests to act as observers then, but then there's the issue of the importers already knowing where to look for files. 19:18:20 <clokep_work> We'll figure it out. :) 19:20:42 <aleth> Maybe always test the whole import wizard, but with a changing simulated set of files? 19:21:18 --> SM0TVI has joined #instantbird 19:28:10 <-- mmkmou has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 19:29:46 <wnayes> I think tests per importer is doable, but there might need to be some changes in how files are found (not sure how to "fake" files on the system) 19:31:14 <wnayes> Having an observe() method in the tests should be doable, so the tests can receive ExistingAccounts and test their settings. 19:33:28 <-- Mic has quit (Ping timeout) 19:41:04 <clokep_work> wnayes: Btw EionRobb also has a Facebook account plugin which is fairly popular, I believe, so I wonder if we should import that to Facebook too. 19:41:16 <clokep_work> (But that doesn't need to be done now! Just throw it on your todo list) 19:42:06 --> Mic has joined #instantbird 19:42:06 * ChanServ sets mode +h Mic 19:42:42 <wnayes> I remember using that :) I'll have to see how it works (if it has accounts with prpl-facebook ids there might not be any changes needed) 19:44:23 <-- gerard-majax has quit (Ping timeout) 19:44:54 <clokep_work> http://code.google.com/p/pidgin-facebookchat/source/browse/trunk/libfacebook.h#25 http://code.google.com/p/pidgin-facebookchat/source/browse/trunk/libfacebookxmpp.c#45 and http://code.google.com/p/pidgin-facebookchat/source/browse/trunk/libfbxmpp.c#38 it looks like 19:45:09 <clokep_work> Guess he has lots of different versions. ;) 19:48:07 <-- FireFly_TB has quit (Quit: FireFly_TB) 19:49:04 --> flo has joined #instantbird 19:49:04 * ChanServ sets mode +qo flo flo 19:53:25 <flo> I think I've just been in the situation that typically caused the "account connection attempts don't timeout" bug, and everything worked fine 19:54:10 <clokep_work> :) 19:56:59 <-- chrisccoulson has quit (Ping timeout) 19:58:15 <-- FeuerFliege has quit (Connection reset by peer) 19:58:36 <Mic> I answered the email btw. 19:58:44 --> EionRobb has joined #instantbird 20:01:12 <Mic> hmm, it's not appearing in the thread but separately 20:01:20 <clokep_work> Mic: Looks fine for me. 20:01:45 <Mic> OK, bbl 20:04:20 --> FireFly_TB has joined #instantbird 20:04:33 <-- Optimizer has quit (Ping timeout) 20:07:48 --> Optimizer has joined #instantbird 20:08:31 --> skeledrew has joined #instantbird 20:13:23 --> jb has joined #instantbird 20:15:18 --> chrisccoulson has joined #instantbird 20:16:58 --> DGMurdockIII has joined #instantbird 20:24:36 <-- Optimizer has quit (Ping timeout) 20:27:09 <-- jb has quit (Ping timeout) 20:28:57 <clokep_work> flo: So should chat/ stuff be documented on MDC btw? 20:29:15 <flo> possibly 20:29:44 <-- FireFly_TB has quit (Quit: FireFly_TB) 20:34:15 <clokep_work> I'm wondering if some of the stuff about extending the IRC implementation should be there. 20:34:20 <clokep_work> But I think I'll do a blog post first. ; 20:35:14 <Mook_as> hmm, double-click-backlog to insert nick seems odd for me. mostly because I try to double-click-to-select instead :p 20:35:47 <clokep_work> Mook_as: There's a pref for it. 20:35:50 * clokep_work has it disabled. 20:37:17 <clokep_work> Don't ask me what the pref is though. ;) 20:37:18 <Mook_as> thanks; I guess it's messenger.conversations.doubleClickToReply 20:37:40 <clokep_work> Yes. :) 20:37:46 <clokep_work> Just found it: http://lxr.instantbird.org/instantbird/source/instantbird/app/profile/all-instantbird.js#41 20:37:47 * Mook_as wonders why he still gets stuff copied on select with clipboard.autocopy=false 20:38:16 <Mook_as> oh, that's messenger.conversations.selections.magicCopyEnabled :\ 20:38:55 <clokep_work> Is it? 20:39:01 <-- EionRobb has quit (Quit: Leaving.) 20:39:06 <clokep_work> Magic copy fixes formatting, I don't think it has to do with auto-copying on select. 20:39:14 <Mook_as> well, it seems to stop the silly copying on select 20:39:44 <clokep_work> Weird. That sounds like a bug (flo?) 20:39:58 * clokep_work doesn't think he's ever even looked at the magic copy code... 20:40:03 <Mook_as> see http://mxr.mozilla.org/comm-central/source/chat/content/convbrowser.xml#619 20:40:37 <Mook_as> and http://mxr.mozilla.org/comm-central/source/chat/content/convbrowser.xml#678 never checks the clipboard.autocopy pref 20:41:01 <clokep_work> So it sounds like a bug? :P 20:41:08 <Mook_as> yeah. 20:41:32 <clokep_work> You going to file it or do I need to? :P 20:41:43 <Mook_as> I'll try to remember when I get home :) 20:42:08 <Mook_as> if you want to file so I don't forget / etc., that's cool too 20:42:50 <clokep_work> Or I could use memoserv. ;) 20:43:21 <Mook_as> oh, I've already used memoserv to send a message to myself 20:43:27 <Mook_as> that doesn't mean I'll remember anyway :p 20:43:54 <clokep_work> I wonder if the majority of memoservs sent are to themselves. ;) 20:44:15 <Mook_as> (I'll also need to file a bug on getting tooltips for smilies like cz does) 20:44:26 <clokep_work> Tooltips for smilies? 20:44:29 <Mic> Oh, messenger.conversations.doubleClickToReply defaults to true? Interesting ... 20:44:35 <Mook_as> try figuring out what this says: ^^^^^^^^ 20:44:53 <clokep_work> Well Mibbit doesn't recognize that as a smile, so that's easy. ;) 20:45:00 <clokep_work> But we need to make the smile algorithm a bit smarter. 20:45:03 <Mic> I'd expected the opposite (maybe because I never liked it;) 20:45:16 <DGMurdockIII> yeah that would be nice 20:45:21 <clokep_work> It's on my list... 20:45:26 <Mook_as> yeah, especially when it doesn't check word boundaries 20:45:40 <Mic> ^^:):-) 20:45:55 <clokep_work> Well the issue is that you want it to match what mic just said. 20:46:15 <DGMurdockIII> this is a long shot i love to see second life im support 20:46:27 <Mook_as> yes. so I guess you need look{ahead|behind} for ^|\W / \W|$ 20:46:31 <Mic> Mook_as: I've got tooltips on smilies here btw (or maybe I didn't read carefully enough what you said) 20:46:55 <Mook_as> hmm, I don't; perhaps it's a tbird-specific bug 20:46:59 --> igorko has joined #instantbird 20:47:21 <clokep_work> Ah, probably. 20:47:27 <Mic> I'm using IB indeed. 20:49:05 <Mic> Good night 20:49:14 <-- Mic has quit (Connection reset by peer) 20:52:06 <-- igorko has quit (Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org) 20:52:31 <flo> Mook_as: tb doesn't have tooltips in conversations 20:52:45 <flo> Mook_as: but emoticons do set the title= attribute 20:53:37 <Mook_as> flo: yeah, so sounds like I'd consider the first part a bug :) 20:53:57 <flo> Mook_as: and detecting emoticons really correctly is hard 20:54:09 <flo> in what Mic said there's no word boundary 20:54:11 <Mook_as> I'm not claiming it isn't! just that isn't perfect yet ;) 20:54:15 <clokep_work> We do have a bug open on it though. 20:54:25 <clokep_work> I think the first step is to make some tests. 20:54:32 <clokep_work> With expected output. 20:54:34 <flo> what we need is either word boundary OR end/begin of line, OR another emoticon 20:54:51 <flo> I don't think a regexp can handle the "OR another emoticon" part 20:55:13 <flo> because you need to have detected the second emoticon before detecting the first one, which is required for detecting the second one ;) 20:55:57 <clokep_work> You might be able to do ((?::\)|...|^^)+) or something lik ethat. 20:56:04 <Mook_as> boo, JS RE doesn't have lookbehind 20:56:16 <clokep_work> Nope. 20:56:29 <clokep_work> Reverse the string and use lookahead? :P 20:56:45 <flo> "22:40:38 - Mook_as: and http://mxr.mozilla.org/comm-central/source/chat/content/convbrowser.xml#678 never checks the clipboard.autocopy pref" that doesn't seem like a bug 20:57:11 <Mook_as> flo: why not? I can't get the rest of magicCopy without copy-on-select? 20:57:21 * clokep_work goes to play Frisbee. 20:57:25 <flo> the code checks nsIClipboard.supportsSelectionClipboard() before adding the selection listener 20:57:44 <-- clokep_work has quit (Quit: Frisbee!) 20:57:56 <flo> Mook_as: no, you just can't turn of copy on select without closing the conversaiton bindings and reopening them 20:58:04 <flo> just put all the conversations on hold, and reopen them 20:58:22 <Mook_as> http://mxr.mozilla.org/comm-central/source/mozilla/widget/gtk2/nsClipboard.cpp#467 doesn't seem to do anything about the pref 20:58:40 <flo> hmm 20:59:25 <Mook_as> the selection stuff seems to conditionally add the listener. http://mxr.mozilla.org/comm-central/source/mozilla/layout/generic/nsSelection.cpp#497 20:59:33 <flo> well, ok 20:59:35 <Mook_as> though that code looks odd 20:59:51 <flo> I'm almost sure the code didn't look like this at the time I wrote magic copy 21:00:30 <Mook_as> I wouldn't be surprised 21:00:34 <flo> ok then, if you want to fix it, go ahead 21:01:11 <Mook_as> yes, I'll file once I get home. as long as I remember :) (and if I don't, I guess it's not painful enough ;) ) 21:01:14 <flo> how is the autocopy feature annoying btw? :) 21:01:26 <flo> I said "fix", not "file" ;) 21:01:31 <Mook_as> :p 21:01:32 <flo> nobody else is interested :-P 21:01:52 <Mook_as> it's annoying because of the lack of last-read-marker and my workaround of selecting text to mark :) 21:02:20 <flo> pfff 21:18:32 --> EionRobb has joined #instantbird 21:27:34 * aleth wonders if clokep or flo have time to review the remaining unread ruler patches 21:32:02 <flo> 1375 and 1450? 21:32:16 <aleth> Yup. 21:32:52 <aleth> Especially the one with the time constant as it might need tweaking depending on feedback... 21:33:01 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.88.2 [Firefox 14.0/20120605113340]) 21:36:04 <flo> prev && prev.id && prev.id == "unread-ruler" -> why the prev.id null check? 21:36:44 <flo> can the id property of a DOM node not exist if there's no id attribute? (I would have expected it to be an empty string) 21:36:44 <aleth> So there is no warning if the property doesn't exist. 21:37:30 <flo> or if you are checking that you are actually on a DOM element, rather than on a text node, or comment node, that's an ugly way to test it ;) 21:38:02 <aleth> I'm really just interested in checking if it's the unread ruler, in a way that doesn't cause warnings. 21:38:32 <aleth> There would be other ways to do that, but I thought that seemed easiest? 21:39:54 <flo> target.className.substring(0, 6) == "bubble" is so ugly in the context that I guess a little additional ugliness won't change things much 21:40:42 <aleth> Yes, there seem to be a couple of things in the JS code for bubbles which are not so pretty. 21:41:52 <flo> I can't make any sense of "Set the unread ruler margins so they are constant after margin collapse." 21:41:59 <aleth> target.classList.contains would be better for example... 21:43:13 <aleth> Do you mean you don't understand what the code is doing, or that the comment should be better? 21:44:02 <flo> aleth: I don't understand what the code is doing, and the comment helps me as much as no comment would. 21:44:07 <aleth> :( 21:44:22 <aleth> Margins of neighbouring DOM elements are collapsed. 21:44:52 <flo> O_o 21:44:55 <aleth> The code sets the margin of the unread ruler so that, taking account of this fact, the margin between it and the following bubble ultimately is always the same (constant) 21:45:45 <aleth> https://developer.mozilla.org/en/CSS/margin_collapsing 21:46:48 <aleth> The point of this is that, when the unread ruler is removed, the margin between the bubbles is what it should be without the need for any further intervention, as the margin on the bubble was never changed. 21:48:47 <flo> I've never heard of that. Does it apply to XUL too? 21:49:30 <aleth> I don't know. It's a CSS standard thing though. 21:49:42 <-- myk has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 21:49:50 <aleth> So I would think it probably does. 21:49:50 --> myk has joined #instantbird 21:51:52 <flo> prev.style.marginTop = "11px"; is constant? Why is it set from script rather than in the CSS file? 21:53:39 <aleth> Only because it seemed better to set both margins from JS so they are both in the same part of the code. It could be moved of course. 21:54:34 <aleth> It's clearer that way how it relates to the bottom margin, so if that were to change the changes would be in the same file 21:54:44 <aleth> Does it have a large performance cost? 21:55:19 <flo> so that 11px is the 10px of rulerMarginBottom + 1px of border? 21:55:25 <aleth> Yes 21:56:51 <aleth> Sounds like you might want some more comments in that code ;) 21:56:55 --> Kaishi has joined #instantbird 21:57:01 <flo> would it make sense to write it as (kRulerMarginBottom + 1) + "px" ? 21:57:28 <aleth> isn't that more costly? 21:58:14 <flo> how many unread rulers do you indent to display per second? 21:58:28 <aleth> Point taken. 21:58:53 <flo> confused developers are costly 21:59:02 <flo> because they add bugs, and then we need to look again ;) 21:59:26 <aleth> I wonder who wrote the time bubbles code and added no comments whatsoever ;) 21:59:59 <flo> it was just an add-on experiment at the time :-[ 22:00:39 <-- flo has quit (Input/output error) 22:00:42 --> flo has joined #instantbird 22:00:42 * ChanServ sets mode +qo flo flo 22:01:02 <aleth> not that it wasn't fairly clear from the code what was going on :) 22:01:05 <flo> and what's the 2 magic constant? 22:01:08 * Mook_as suspects if you need to think about margin collapsing the code should be restructured 22:01:41 <Mook_as> since I haven't actually seen the ruler: is that constant relative to the top of the preceding message, or the bottom of the screen, or.. ? 22:01:47 <aleth> It's copied from the CSS (standard bubble spacing) 22:02:22 <flo> Mook_as: nah, the code is perfect 22:02:28 <aleth> Mook_as: It's actually useful in this instance as it means you can get away with not modifying any element other than the ruler 22:02:37 <flo> Mook_as: we are just polishing the perfection so that it shines even more ;) 22:03:10 <Mook_as> heh, whenever I hear "polish" the next word I think of is always "turd" :p (this is independent of the code, and not an insult) 22:03:21 <flo> aleth: which line is that standard bubble spacing? :-S 22:03:44 <aleth> I can't remember... it's been a while 22:03:49 * aleth goes look 22:07:49 <aleth> http://lxr.instantbird.org/instantbird/source/instantbird/themes/messages/bubbles/main.css#18 I believe (3px - 1px as there is no shadow on the ruler) 22:08:39 <aleth> and yes, I should have added a comment at the time :$ 22:10:15 <flo> 3px is the shadow 22:10:23 <flo> where does the -1 come from? 22:11:04 <aleth> The margin is 3px. The -1 is the inverse of the +1 difference between top and bottom ruler margins 22:11:25 <aleth> You need it because otherwise the ruler doesn't look centered, due to the shadow on one side and not the other 22:12:39 <aleth> Ultimately the answer to "why 2px" is "it looks right" of course. But that's the logic. 22:14:05 <aleth> It's implicit in your time bubbles code too I think. 22:15:48 <flo> ah, now it's my fault :-D 22:16:06 <aleth> Noooo I'm just saying you took account of the same thing :D 22:16:19 <flo> aleth: the time bubble code was designed so that no "magic" constant appear in the middle of the code, so that everything in the appearance can be tweaked independently of the algorithm 22:16:57 <flo> because I expected theme authors may want to tweak the margins, but the algorithm is too complicated to touch 22:17:51 <flo> (assuming some theme authors would have wanted to fork the time bubbles theme) 22:18:07 <aleth> I'm surprised nobody has actually. 22:18:35 <aleth> Looking at your code, I suspect I could replace the magic two with "shadow - 1" 22:19:28 <flo> if that's what it actually is, and you can come up with a comment that makes sense to explain the offset 22:19:57 <flo> I'm not sure if your real constant is 11 or 10 though 22:19:57 <aleth> I suspect that's the same thing, but I'm not 100% sure why you called it "shadow" 22:20:11 <aleth> I took the CSS margin value and went from there. 22:20:12 <flo> as the 10 seems to be marginTop (11) with the same -1 applied 22:20:16 <aleth> Yes! 22:21:17 <aleth> if you prefer thinking of it that way round 22:21:21 <flo> aleth: the shadow constant is the height of the shadow after each bubble; the strict minimum space that we need to keep between 2 bubbles, even when the time interval says they should be touching 22:21:52 <aleth> Ok, then it's the same thing I think. I wouldn't have called that "shadow" 22:22:06 <flo> how would you call it? 22:22:19 <aleth> minimum spacing or similar 22:22:34 <flo> no, it's the shadow 22:22:53 <flo> it needs to match a value in the css for the shadow css attribute 22:23:18 <aleth> Yes, I see that. But I wasn't going to subtract 3 pixels as visually that's far too much. 22:23:26 <flo> and that's why I'm confused by "why is this relevant for the ruler?", as afaik it doesn't have a shadow, so the minimum space should be 1px or even 0. 22:23:46 <aleth> That's what I was trying to explain above :-/ 22:24:08 <flo> so it's possible that 2 is completely unrelated to the shadow constant 22:24:11 <-- Tomek has quit (Client exited) 22:24:12 <flo> but then I'm not exactly sure of what it is 22:24:33 <aleth> I think it is no coincidence your shadow constant also matches the margin-bottom of the bubble. 22:24:40 <aleth> That's the connection. 22:25:30 <flo> the "shadow" const is the minimum acceptable margin bottom for a bubble with a shadow 22:26:09 <aleth> Yes. So the minimum acceptable margin for the ruler is also that, minus one to take account of the fact that there is no shadow on the ruler. 22:26:47 <flo> hmm, no? :) 22:27:14 <flo> 'margin = shadow' means 'no spacing at all, the elements visually touch each other' 22:28:33 <aleth> Now I am confused. 22:29:20 <flo> 'shadow' is how many pixels we have between the bubbles of 2 messages that appeared at the same second 22:30:01 <aleth> Yes 22:30:41 --> Tomek has joined #instantbird 22:30:59 <aleth> So why does 2 = shadow-1 not make sense to you? 22:31:35 <flo> hmm, oh, are you cancelling "p.style.marginTop = -shadow + "px""? 22:32:08 <aleth> Is it possible your code takes account of margin collapse but you weren't aware of it when you wrote it? 22:32:42 <aleth> flo: that's one way of putting it I think 22:33:14 <flo> I misunderstood the comment about being only for "rulerMarginBottom -= margin" rather than the whole block :( 22:33:36 <aleth> (But I think rather than link the constant 2 for the ruler with the time bubble constants, I'd prefer a comment on how the 2 follows from the margin, as that's what I did and it seems a faster way to arrive at the result.) 22:33:59 <aleth> flo: Right, sorry, that comment should be moved then. 22:35:39 <flo> if that 2 magic constant needs to be changed at the same time if the shadow is ever changed, then they should be linked to each other 22:36:10 <aleth> But you can't change the shadow constant without also having to change that margin value in the CSS, so it ends up the same thing 22:36:18 <flo> (someone testing modifications of a theme will never think of the case of an unread ruler appearing after 5 minutes, so not doing so is a guarantee that it will be broken eventually ;) 22:36:48 <aleth> Yeah... 22:36:58 <flo> aleth: except touching the css is the straight forward thing for someone who started looking to change the spacing of the theme ;) 22:37:53 <aleth> Ideally the JS would read its constants from the CSS... but that would be something of a rewrite... 22:38:35 <flo> so if you could add one meaningful constant next to shadow and timebeforetextdisplay, and then make everything depend on that set of constants, it would be nice 22:38:52 <aleth> OK. 22:39:37 <flo> aleth: and after the comment about margin collapse, add a second line "// See https://developer.mozilla.org/en/CSS/margin_collapsing" :) 22:40:32 <aleth> np... being fairly new to CSS, I just assumed this was an 'everybody knows' fact ;) 22:41:57 <flo> maybe it's just a case of "flo should go learn CSS again instead of making silly review comments" ;) 22:42:27 * aleth suspects flo has better things to do 22:43:49 <flo> better than silly review comments or better than learning css? :) 22:44:40 <aleth> the latter ;) 22:45:12 <aleth> A lot of CSS documentation requires wading through reams of workarounds for differences between browsers... not fun 22:46:06 <aleth> (outside of MDN of course) 22:48:38 <-- chrisccoulson has quit (Ping timeout) 22:51:54 --> chrisccoulson has joined #instantbird 22:52:04 * Mook_as wonders if the ruler is ever some place not near the time bubble 22:52:48 <aleth> No, it's only ever inserted together with the following bubble 22:54:34 <Mook_as> okay. (was just curious if having it always there, just sometimes opacity 0, would help). 22:54:39 <Mook_as> that probably involves too much rewriting though 22:54:55 <Mook_as> also, I should probably shut up until I see it in action :p 22:55:08 <flo> Mook_as: that wouldn't help :-P 22:55:22 <Mook_as> okay, I should shut up about it now :p 23:10:38 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1495 on bug 1375. 23:10:39 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1588 on bug 1375. 23:10:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1375 min, --, ---, aletheia2, ASSI, Followup: Unread ruler CSS and Bubbles margin improvements 23:12:42 <aleth> flo: Please modify the comments if you feel they are still unclear 23:18:35 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1588 on bug 1375. 23:18:36 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1589 on bug 1375. 23:18:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1375 min, --, ---, aletheia2, ASSI, Followup: Unread ruler CSS and Bubbles margin improvements 23:22:37 <instantbot> florian@instantbird.org granted review for attachment 1589 on bug 1375. 23:22:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1375 min, --, ---, aletheia2, ASSI, Followup: Unread ruler CSS and Bubbles margin improvements 23:27:10 <-- Tomek has quit (Client exited) 23:29:14 --> Tomek has joined #instantbird 23:32:51 <flo> Good night 23:32:53 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 23:34:13 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/b8d8b6e60aef - aleth - Bug 1375 - Improve the margins around the unread ruler for the Bubbles theme, r=fqueze. 23:51:39 <instant-buildbot> build #272 of linux-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/272 23:52:50 --> DGMurdockIII has joined #instantbird