All times are UTC.
00:00:53 <aleth> Makes sense. 00:01:06 <instant-buildbot> build #249 of linux-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/249 00:01:12 <clokep> Plus keeping them linked would be more work and I'm lazy. ;) 00:01:38 <aleth> So JS doesn't have a .parent kind of thing? 00:02:11 <clokep> What do you mean by "parent"? 00:02:16 <clokep> It has prototype and _-proto__ 00:02:21 <aleth> (that would link to the conversation the participants are in) 00:02:38 <clokep> Nah I just changed around the constructor to do it. :) 00:02:58 <aleth> alrighty 00:05:21 <aleth> seems I am getting tired ;) good night! 00:05:26 * clokep feels like the mode command just didn't work. :-S 00:05:45 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 00:25:21 <instantbot> clokep@gmail.com cancelled review?(aletheia2@fastmail. fm) for attachment 1432 on bug 318. 00:25:22 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1433 on bug 318. 00:25:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=318 enh, --, ---, clokep, ASSI, Check if topic on IRC channels is editable and make UI respond accordingly 00:37:10 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1434 on bug 1418. 00:37:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1418 nor, --, ---, clokep, ASSI, No/incorrect error message when joining a channel fails 00:53:46 <-- Tonnes has quit (Ping timeout) 00:59:07 --> Tonnes has joined #instantbird 01:00:26 <-- EionRobb has quit (Ping timeout) 01:01:28 <-- Tonnes has quit (Ping timeout) 01:01:57 --> Tonnes has joined #instantbird 01:04:02 <-- mmkmou has quit (Quit: Instantbird -- http://www.instantbird.com) 01:05:42 --> EionRobb has joined #instantbird 01:12:06 <-- wesj has quit (Quit: Instantbird -- http://www.instantbird.com) 01:31:14 <instant-buildbot> build #217 of macosx-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/217 01:55:13 <-- clokep has quit (Quit: Instantbird -- http://www.instantbird.com) 02:27:38 <instant-buildbot> build #576 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/576 02:36:43 --> NmN has joined #instantbird 02:47:35 --> skeledre1 has joined #instantbird 02:49:16 <-- skeledre1 has quit (Ping timeout) 03:11:39 --> skeledre1 has joined #instantbird 03:19:08 --> Kaishi has joined #instantbird 03:23:51 <instant-buildbot> build #485 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/485 03:34:50 <-- EionRobb has quit (Quit: Leaving.) 03:35:41 --> EionRobb has joined #instantbird 03:49:18 * bear-afk is now known as bear 04:13:30 * bear is now known as bear-afk 04:27:41 --> micahg has joined #instantbird 04:28:57 <-- micahg has quit (Connection reset by peer) 04:30:56 --> micahg has joined #instantbird 04:40:54 <instant-buildbot> build #238 of win32-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/238 04:56:32 <-- Kaishi has quit (Input/output error) 05:03:34 <-- skeledre1 has quit (Ping timeout) 05:34:30 --> skeledre1 has joined #instantbird 05:57:11 <-- EionRobb has quit (Quit: Leaving.) 06:03:16 <instant-buildbot> build #472 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/472 06:28:44 --> chrisccoulson has joined #instantbird 06:56:15 --> jb has joined #instantbird 07:08:59 <-- jb has quit (Ping timeout) 07:14:07 <-- NmN has quit (Connection reset by peer) 07:14:37 --> NmN has joined #instantbird 07:50:35 --> Mic has joined #instantbird 07:50:35 * ChanServ sets mode +h Mic 07:51:02 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 07:51:15 --> Mic has joined #instantbird 07:51:15 * ChanServ sets mode +h Mic 08:04:56 --> Tomek has joined #instantbird 08:06:45 <Mic> Hi 08:07:54 --> gerard-majax has joined #instantbird 08:14:56 --> jb has joined #instantbird 08:15:51 --> Even2 has joined #instantbird 08:15:57 <-- Even2 has quit (Quit: Even2) 08:16:08 --> Even2 has joined #instantbird 08:17:27 --> aleth has joined #instantbird 08:17:28 * ChanServ sets mode +h aleth 08:18:27 <-- aleth has quit (Quit: Instantbird -- http://www.instantbird.com) 08:18:37 --> aleth has joined #instantbird 08:18:37 * ChanServ sets mode +h aleth 08:30:57 <-- skeledre1 has quit (Ping timeout) 08:34:05 <Mic> aleth: you had something to do with the special casing of Twitter in some places recently, didn't you? (I'm looking at the loogger currently) 08:34:26 <aleth> Mic: I encountered it, yes 08:34:26 <Mic> *logger 08:34:59 <Mic> Shouldn't we better put a comment on these (maybe with bug number and 'remove when this is fixed' or so?) 08:36:39 <aleth> I think you'd have to ask clokep and flo what the plan is for those exceptions. The issue I think is that existing installs (1.1, 1.0) won't find existing twitter logs without the exception, so it will be hard to remove it unless someone writes migration code. 08:37:14 <aleth> But I agree there should be a comment 08:37:32 <Mic> That's what I meant. Telling why it's there and a bug about migrating the old profiles 08:37:50 <Mic> I'll file the bug and see if I find all the Twitter special cases. 08:38:51 <aleth> I'm not sure what the original bug was called that made this special case necessary 08:40:45 <Mic> Ah, grep to the rescue :) since lxr sucked again :( 08:57:33 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 08:57:51 --> Mic has joined #instantbird 08:57:52 * ChanServ sets mode +h Mic 09:01:19 --> jb1 has joined #instantbird 09:01:45 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 09:02:39 --> Mic has joined #instantbird 09:02:39 * ChanServ sets mode +h Mic 09:18:06 <instantbot> aletheia2@fastmail.fm granted review for attachment 1434 on bug 1418. 09:18:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1418 nor, --, ---, clokep, ASSI, No/incorrect error message when joining a channel fails 09:23:58 --> meh has joined #instantbird 09:30:56 --> flo has joined #instantbird 09:30:56 * ChanServ sets mode +qo flo flo 09:36:07 <flo> hello :) 09:36:32 <instantbot> aletheia2@fastmail.fm denied review for attachment 1433 on bug 318. 09:36:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=318 enh, --, ---, clokep, ASSI, Check if topic on IRC channels is editable and make UI respond accordingly 09:37:41 <Mic> HI flo 09:37:42 <Mic> *Hi 09:37:48 <aleth> hi :) 09:38:01 <flo> I just read bug 1308 and bug 1309 again. It seems 1309 is a consequence of the other, so nothing actionable? And 1308 is "JS-IRC sends incorrect chat-buddy-add notifications" and is actionable? 09:38:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1308 nor, --, ---, nobody, NEW, Errors on joining channel: "Adding a chat buddy twice" 09:38:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1309 nor, --, ---, nobody, NEW, Error: Removing or updating a nick that is not in the room 09:38:17 <aleth> 1308 is actionable and difficult. 09:38:51 <aleth> But yes. 09:39:15 <flo> why is it difficult? Shouldn't JS-IRC channels just keep track of which nicks were added, instead of sending the whole list? That doesn't seem difficult to implement 09:39:28 <flo> except if there are strange complications that force some large refactoring of course :) 09:39:41 <aleth> The latter seems very likely ;) 09:39:59 <aleth> But it's a while since I looked at it, so I don't remember the details. 09:40:23 <flo> the step to reproduce is joining a channel with a long nicklist? 09:40:30 <aleth> Yes. 09:40:50 <aleth> It doesn't always happen, but #developers is enough. 09:40:59 <flo> I think it depends on the speed of your machine 09:41:08 <aleth> And on the server, etc... 09:41:16 <flo> yeah, the speed of the server too :) 09:41:24 <flo> and maybe of the internet connection 09:53:47 <Mic> Phase of the moon? scnr. 09:54:11 * Mic has messages appearing twice (from the log and from the conv again). bah :( 10:03:59 --> clokep has joined #instantbird 10:03:59 * ChanServ sets mode +o clokep 10:11:15 --> BYK has joined #instantbird 10:15:42 <-- clokep has quit (Ping timeout) 10:16:26 <aleth> clokep: I suspect the auto-join case works because there is a lot of stuff transmitted from the server to the server tab between sending join and receiving JOIN, i.e. a delay. 10:18:18 --> clokep has joined #instantbird 10:18:18 * ChanServ sets mode +o clokep 10:18:53 <aleth> clokep: I suspect the auto-join case works because there is a lot of stuff transmitted from the server to the server tab between sending join and receiving JOIN, i.e. a delay. 10:19:10 <clokep> aleth: What? 10:19:15 <clokep> Why would it not work? 10:19:26 <aleth> (that was re bug 318) 10:19:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=318 enh, --, ---, clokep, ASSI, Check if topic on IRC channels is editable and make UI respond accordingly 10:20:05 <clokep> Right but I still have no context... 10:20:20 <clokep> (Mine you I woke up 10 minutes ago. ;) Be gentle.) 10:20:37 <flo> :) 10:21:09 <aleth> I'll let you catch up with your mail first then ;) 10:21:09 --> EionRobb has joined #instantbird 10:21:48 <clokep> flo: The issue with bug 1308 is that IRC assumes that the conversation is ready to receive notifications immediately. 10:21:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1308 nor, --, ---, nobody, NEW, "Adding a chat buddy twice" errors (JS-IRC sending bad chat-buddy-add notifications) 10:22:00 <clokep> Wait. 10:22:04 <clokep> No...that's not the issue. 10:22:44 <clokep> The issue is that some of the chat buddies are picked up by the conversation during it's initialization and others when we send the notification, the IRC code assumes none are picked up during the initialization. 10:23:08 <flo> isn't it what I said? 10:23:17 <flo> s/it/this/ 10:23:29 <flo> (in my comment in the bug) 10:23:57 --> jc has joined #instantbird 10:25:26 * clokep is reading his email now. 10:26:08 <-- EionRobb has quit (Quit: Leaving.) 10:28:20 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1430 on bug 1415. 10:28:21 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1435 on bug 1415. 10:28:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1415 nor, --, ---, aletheia2, ASSI, Unread ruler should also appear after last context message 10:30:01 <instantbot> clokep@gmail.com granted review for attachment 1436 on bug 1418. 10:30:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1418 nor, --, ---, clokep, ASSI, No/incorrect error message when joining a channel fails 10:38:33 * clokep is confused by your comment on bug 318... 10:38:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=318 enh, --, ---, clokep, ASSI, Check if topic on IRC channels is editable and make UI respond accordingly 10:39:58 <aleth> If I /join a new channel in the latest nightly, a new tab opens in which I am the only participant, and starred as the op. With your patch applied, the star is missing. 10:40:46 <clokep> Yes I'm confused at how it could happen. :-D 10:41:01 <aleth> You are not alone in that :D 10:41:49 <clokep> Luckily I can reproduce. ;) 10:42:05 <aleth> That's something :) 10:42:06 <aleth> It may be the chat-buddy notification doesn't arrive because the conv isn't ready, that would be worth checking. 10:42:35 <aleth> or something along those lines... 10:43:52 <clokep> Thta follows a slightly different code path since the mode is set via the prefix in that case btw. 10:44:17 <aleth> I thought that was the case in both 10:44:26 <clokep> Well both the auto-join and manual join, yes. 10:44:34 <clokep> I meant from most of the other situations the patch deals w./. 10:44:39 <aleth> Right. 10:48:19 * clokep shrugs I need to look later. 10:48:39 <aleth> I was quite disappointed to spot that after everything else worked so well... 10:53:54 <clokep> Me too. :P 10:56:14 <flo> I really dislike that code style: for each (let [,testValue] in Iterator(testValues)) { 10:56:48 <clokep> Instead of testValues.forEach(function testValue) ...)? 10:57:16 <clokep> I also greatly dislike it (and would be tempted to r- it in chat/ code btw). 10:57:21 <flo> instead of for each (let testValue in testValues) { 10:57:46 <clokep> Ah yes, well in that case...that's ridicuous. 10:58:03 <flo> the only explanation (excuse?) for it in Tb code is that the pattern with Iterator works even if someone in an add-on has messed up the Array prototype 10:59:32 <clokep> Not good enough! 10:59:51 <flo> clokep: lxr shows two results in instantbird/content/extensions.js http://lxr.instantbird.org/instantbird/search?string=iterator and I think you were the author for that changeset :-P 11:00:00 <flo> but I agree, r- in chat for that :-P 11:00:33 <clokep> flo: But those were copied from Mozilla code... 11:00:56 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 11:01:07 <flo> clokep: I know, I was just kidding :) 11:02:08 <clokep> Time to go. :) 11:02:12 <-- clokep has quit (Quit: Instantbird -- http://www.instantbird.com) 11:04:28 --> Mic has joined #instantbird 11:04:28 * ChanServ sets mode +h Mic 11:04:38 <-- Mic has quit (Connection reset by peer) 11:04:46 --> Mic has joined #instantbird 11:04:46 * ChanServ sets mode +h Mic 11:10:02 <flo> ok, I've found which function I need to modify to fix the bug that was annoying me yesterday afternoon :) 11:10:11 <flo> too bad that function is 240 lines long though :-/ 11:20:52 <instantbot> benediktp@ymail.com cancelled feedback?(florian@instantbi rd.org) for attachment 1411 on bug 958. 11:20:53 <instantbot> benediktp@ymail.com requested feedback from the wind for attachment 1437 on bug 958. 11:20:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=958 enh, --, ---, benediktp, ASSI, Show last messages (history) in new chat windows 11:21:35 <-- Tomek has quit (Quit: Instantbird 1.1) 11:25:51 --> mmkmou has joined #instantbird 11:26:07 <aleth> Mic: You've probably ruled this out, but are you getting duplicate messages by accessing the latest log, which is that of the current conversation? 11:31:22 <-- micahg has quit (Quit: Ex-Chat) 11:35:36 <Mic> When opening a conversation without writing a message, there will be no new log yet, so I can't skip the first log in every case. Maybe I should check if the first message of the first log and the first message in the messages array have the same timestamp or something like that. 11:36:42 <aleth> Or make the logger know if there is a "current log" open? 11:37:54 --> clokep_work has joined #instantbird 11:42:31 --> skeledre1 has joined #instantbird 11:47:12 <clokep_work> Mic: Overall I think it looks pretty good. :) 11:47:21 <clokep_work> You need to add some spaces after if and while statements btw. ;) 11:47:37 <clokep_work> I think the API makes sense and I /think/ you modified the IDL properly. 11:48:55 <Mic> I thought I paid attention to the spaces :( 11:49:15 <clokep_work> I saw a lot were if(blah blah) 11:50:28 <Mic> Ah, OK. I thought you meant between ")" and "{", will fix that, thanks 11:50:34 <Mic> *I will 11:53:46 <clokep_work> Not a big deal, just figured I'd tell you now before you keep writing more code. :) 12:07:10 <aleth> I'm quite impressed by how little extra code seems needed :) 12:19:36 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client) 12:23:01 <-- skeledre1 has quit (Ping timeout) 12:23:59 --> clokep_work has joined #instantbird 12:23:59 * ChanServ sets mode +o clokep_work 12:28:14 <flo> Mic: what would you think of adding an optional boolean parameter to getLogsForConversation to ignore (or include? Not sure which behavior should be the default) the log of the ongoing conversation? 12:36:10 <flo> that would force us to duplicate the code of _enumerateLogs in getLogsForConversation to filter the logs, but that seems acceptable 12:39:51 --> skeledre1 has joined #instantbird 12:43:25 <Mic> Sounds OK, yes. 12:46:34 <flo> uh, bug 1108 :( 12:46:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1108 min, --, ---, nobody, NEW, Names of folder and files are not checked against forbidden names. 12:48:48 * clokep_work wonders if there is an API for getting a "safe" folder name. 12:49:50 --> FeuerFliege has joined #instantbird 12:50:48 <flo> ###!!! ASSERTION: unknown error, but don't alert user.: 'errorID != UNKNOWN_ERROR' 12:50:49 <flo> interesting... :-S 12:53:01 <-- skeledre1 has quit (Ping timeout) 12:54:28 <-- jb has quit (Quit: jb) 12:54:43 <aleth> where is that code from? 12:55:02 --> jb has joined #instantbird 12:55:17 <FeuerFliege> hi 12:55:36 <flo> aleth: not sure, it was printed by my Thunderbird debug build 12:55:39 <flo> FeuerFliege: hi :) 12:55:59 * clokep_work assumes it's not from chat/ code. :) 12:56:31 <Mic> Hi FeuerFliege, have I maybe pinged you with bugmail? ;) 12:56:47 <FeuerFliege> Mic: Youâll never know ^^ 12:58:11 --> skeledre1 has joined #instantbird 13:13:32 <-- jc has quit (Quit: jc) 13:13:54 <clokep_work> flo: So I was thinking more about the simplified account wizard, would maybe adding a checkbox on the show all networks page that says "Always show this page" make sense? 13:14:04 <clokep_work> It's pretty much aleth's idea but less magical. 13:15:14 --> jc has joined #instantbird 13:16:01 <FeuerFliege> With the 1.2 release getting close, I wonder when the l10n changes will be merged/pushed to en-US. 13:17:13 <flo> clokep_work: hmm... possibly. Is it really worth it? 13:18:47 <clokep_work> flo: wnayes' concern was when setting up many accounts in a row (i.e. lots of IRC accounts) that aren't on the first page. 13:20:25 <flo> does this use case actually happen? 13:20:53 <clokep_work> I'm sure it could. 13:21:07 <clokep_work> It is also kind of a one time thing though. 13:21:53 <aleth> Another suggestion: What I suggested yesterday, but without the pref being persisted across sessions. So if you add more than one non-top-list account in the same session, you are ok. 13:22:38 <clokep_work> I'm afraid that suggestion is going to come across as looking buggy. :-/ 13:23:10 <aleth> If it's a good one, you wouldn't notice... 13:23:13 <flo> I'm afraid we are spending time optimizing something that isn't frequent enough to be relevant :-/ 13:23:41 <Mic> Skip the protocols selection step (I'm only half-serious here): "Your username looks like an ICQ number, is that correct? [Yes] |Change Network|" ;) 13:24:00 <clokep_work> I wish we could do that...but you can't for many protocols. 13:24:17 <Mic> That's why I had to say "half-serious" :( 13:24:54 <clokep_work> Yes, I know. :) I agree it'd be more ideal though... 13:25:02 <clokep_work> In some ways... 13:25:13 <clokep_work> flo: I also wonder if this more specific case be a follow up. 13:25:20 <clokep_work> (If someone /really/ wants it.) 13:27:46 <flo> for the case of people working on debugging the application and setting up lots of account while testing/debugging, I think my suggestion of pressing enter to just skip the short list would be enough 13:32:23 * clokep_work would like to not block wnayes based on a decision like this. 13:33:01 <flo> which decision is not obvious? 13:33:09 <flo> optimizing rare cases is for follow-ups 13:38:42 <clokep_work> That is not obvious to him, nor have we ever said that. 13:39:04 <flo> clokep_work: I thought *you* were trying to decide something 13:39:55 <clokep_work> Just saying we shouldn't block him. :) 13:42:38 --> Tomek has joined #instantbird 13:43:33 <Mic> Would be "skipping the welcome screen if it's not the first account getting set up" also be in the scope of this bug? 13:43:36 * bear-afk is now known as bear 13:44:13 <clokep_work> I think removing the welcome screen is wanted? 13:44:39 <flo> yes 13:45:02 <clokep_work> Whether it's part of this bug or not...well probably. 13:45:04 <Mic> Completely? So not even before setting up the first account? I can imagine it could be OK to have it in this case. 13:45:22 <Mic> The summary could mean a lot of things.. 13:45:22 <flo> clokep_work: maybe not in that bug 13:45:35 <flo> I think we want to replace it with the import wizard actually ;) 13:46:18 <clokep_work> :) 13:47:40 <clokep_work> We can leave it as part of that bug then... 13:52:54 <-- Mic has quit (Input/output error) 13:53:27 <aleth> ^^ still got that quit bug :( 13:56:01 <clokep_work> Shhh. ;) 13:56:05 <clokep_work> I wish I knew when that occurred. :( 13:56:20 <aleth> I'm sure it's just his quit message ;) 13:56:23 <flo> aleth: if that makes you feel better... I still have my gloda bug too ;) 13:57:16 <-- mmkmou has quit (Ping timeout) 14:01:09 --> mmkmou has joined #instantbird 14:02:25 <-- FeuerFliege has quit (Ping timeout) 14:04:06 <-- jc has quit (Quit: jc) 14:04:27 --> jc has joined #instantbird 14:23:30 <-- skeledre1 has quit (Ping timeout) 14:56:41 <-- jc has quit (Quit: jc) 14:59:25 --> jc has joined #instantbird 14:59:26 --> jb2 has joined #instantbird 14:59:49 <-- jb has quit (Ping timeout) 15:00:05 <-- jb1 has quit (Ping timeout) 15:02:35 --> FeuerFliege has joined #instantbird 15:11:40 <-- meh has quit (Quit: I don't want to live on this planet anymore.) 15:37:48 * bear is now known as bear-afk 15:44:09 <-- gerard-majax has quit (Ping timeout) 15:47:08 <flo> I'll try to find something less painful to do for the last few hours before the week-end :) 15:48:34 --> wnayes has joined #instantbird 15:58:32 <flo> I wonder if http://bholley.wordpress.com/2012/05/04/at-long-last-compartment-per-global/ will make about:memory more useful for us 16:03:26 --> wesj has joined #instantbird 16:05:28 --> myk has joined #instantbird 16:07:04 <flo> a fast way to check if a string starts with a constant: https://bugzilla.mozilla.org/show_bug.cgi?id=713813#c4 16:08:35 <aleth> neat :) 16:09:42 --> igorko has joined #instantbird 16:10:24 <clokep_work> Ah, that should be nice. :) 16:26:42 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1438 on bug 1353. 16:26:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1353 nor, --, ---, aletheia2, ASSI, No user feedback when sending a message in a conversation of an offline account 16:27:14 <aleth> Hopefully the new patch for bug 1415 is more comprehensible now ;) 16:27:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1415 nor, --, ---, aletheia2, ASSI, Unread ruler should also appear after last context message 16:30:56 <flo> so now my approval-comm-aurora requests are granted in less than a minute :) 16:32:00 <aleth> They like your code :) 16:33:38 <flo> aleth: do you really want to prevent the commands from being sent when offline? 16:33:59 <flo> aleth: that would be in my way everyday. I disconnect with /offline, and reconnect with /back 16:34:14 <aleth> I couldn't think of a use case, but that's a good one. 16:35:08 <flo> I guess only /away /back /busy /dnd and /help could make sense though 16:35:19 <flo> and I don't see a way to know which ones make sense 16:35:45 <aleth> Still it seems better to move it back down then. 16:35:57 <flo> right, it won't be a regression at least :) 16:36:43 <flo> by the way, all the commands I listed as making sense are the global ones 16:36:59 <flo> maybe we could add a check around http://lxr.instantbird.org/instantbird/source/chat/components/src/imCommands.js#216 ? 16:39:09 <aleth> To only list the account commands when connected? 16:40:01 <aleth> |if (aConversation && aConversation.account.connected) {| 16:40:15 <aleth> That would make sense I guess. 16:41:50 <flo> not sure if I would request an account variable to avoid calling the account getter twice or if I don't care :) 16:43:54 <-- jc has quit (Quit: jc) 16:43:54 <-- jb2 has quit (Quit: Instantbird 1.1) 16:45:48 <-- NmN has quit (Quit: Instantbird 1.1) 16:47:42 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1438 on bug 1353. 16:47:43 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1439 on bug 1353. 16:47:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1353 nor, --, ---, aletheia2, ASSI, No user feedback when sending a message in a conversation of an offline account 16:48:28 <aleth> gah, that won't do. 16:49:36 <aleth> never follow blindly... 16:49:38 <aleth> ;) 16:50:41 <-- myk has quit (Ping timeout) 16:51:06 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1439 on bug 1353. 16:51:07 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1440 on bug 1353. 16:51:08 <flo> account before testing that aConversation is non-null? 16:51:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1353 nor, --, ---, aletheia2, ASSI, No user feedback when sending a message in a conversation of an offline account 16:51:21 <aleth> Yeah, exactly. 16:51:46 <aleth> That deduplication can be left to the interpreter. 16:53:56 <-- mmkmou has quit (Ping timeout) 16:54:18 --> myk has joined #instantbird 16:56:51 <flo> aleth: what do you mean with "That deduplication can be left to the interpreter."? 16:57:27 <flo> the getter is a function that's executed, there's no guarantee that when calling it twice in a row it will return the same value, so there can't be an automatic optimization here 16:57:48 --> mmkmou has joined #instantbird 16:57:58 <-- BYK has quit (Client exited) 16:58:22 <-- mmkmou has quit (Quit: Instantbird -- http://www.instantbird.com) 16:59:21 --> Mic has joined #instantbird 16:59:21 * ChanServ sets mode +h Mic 17:00:19 <flo> aleth: |bundle.formatStringFromName("userOffline", [], 0)| are you serious? :) 17:00:48 <aleth> Ah, good point 17:00:53 <flo> do you want to make a difference between the user's status has been set to offline and the network is offline? 17:01:09 <aleth> flo: It throws an error if you don't attach the [], 0 :P 17:01:49 <flo> without parameter it's GetStringFromName instead of formatStringFromName 17:01:56 <aleth> Oh, OK. 17:02:16 * aleth wonders why those aren't the same function... 17:02:16 --> mmkmou has joined #instantbird 17:02:19 <flo> and that API sucks, that's why we created the _ helper (mostly for) JS protocols 17:02:28 <aleth> That explains it :) 17:02:57 <flo> aleth: the *G*et vs *f*ormat is really annoying too 17:03:14 <aleth> Yes :-/ 17:03:17 <aleth> flo: Do we trust that difference is recognized properly? 17:03:27 <aleth> (offline as user choice vs network down) 17:03:45 <flo> aleth: network down is Services.io.offline 17:04:08 <flo> the offline status (as you got it) is either because of user's choice or because the network is offline 17:04:33 <aleth> Aha! So as long as one checks them in the right order, it is OK. 17:05:00 <aleth> I'll add that. 17:08:04 <-- wnayes has quit (Ping timeout) 17:11:10 <Mic> aleth: random nit: I think it would be good to rename "setUnreadFlag" to "shouldSetUnreadFlag" as it sounds less ambiguous imo. 17:11:57 <flo> Mic++ 17:12:21 <flo> (and it's quite difficult to write that with the tab completion, as backspace removes "ic" in addition to the ": " :)) 17:13:22 <Mic> Maybe write an extension that adds "++" as suffix that you can "tab to"? ;) 17:13:57 <aleth> Complete++ :) 17:14:17 <flo> aleth: what's the goal of displaying the unknown command message only when online? 17:14:36 <aleth> When offline, you want to be told that you are offline, right? 17:14:49 <aleth> It's not that the command has disappeared from the protocol. 17:15:25 <flo> if I typed /baack I'm not sure ^^ 17:15:37 <aleth> And if the command was wrong, I still suspect its the more pertinent info. 17:15:45 <flo> for a command that exists only when the account is online I agree thought. 17:15:53 <flo> and again, it's bikeshedding on edge cases :-/ 17:16:10 <aleth> I think this one you can argue both ways, yes :-/ 17:16:16 <flo> ok, I guess I don't mind which messagei displayed in that case 17:16:27 <flo> *message is 17:16:39 <aleth> I was worried about the case where a command appears in /help but then the user gets "unknown command" 17:16:48 <aleth> So I think I'll keep it. 17:18:13 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1440 on bug 1353. 17:18:14 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1441 on bug 1353. 17:18:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1353 nor, --, ---, aletheia2, ASSI, No user feedback when sending a message in a conversation of an offline account 17:18:32 <aleth> Just wanted to get rid of that blocker... 17:19:24 <-- sonny has quit (Ping timeout) 17:20:47 <flo> isn't the change in imCommands changing the help message too? 17:21:04 <-- flo has quit (Quit: Instantbird -- http://www.instantbird.com) 17:21:08 <aleth> No. 17:21:55 * bear-afk is now known as bear 17:22:02 <aleth> Nor is that necessary I think. 17:29:26 --> meh has joined #instantbird 17:39:57 --> FeuerFli1 has joined #instantbird 17:40:06 <-- FeuerFliege has quit (Ping timeout) 17:42:38 * clokep_work wonders if he's supposed to read over that patch too. :P 17:44:00 --> DGMurdockIII has joined #instantbird 17:44:08 <-- igorko has quit (Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org) 18:04:14 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client) 18:07:52 --> clokep_work has joined #instantbird 18:07:52 * ChanServ sets mode +o clokep_work 18:19:00 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client) 18:32:59 <-- Mic has quit (Ping timeout) 18:33:40 <-- FeuerFli1 has quit (Ping timeout) 18:36:27 --> BYK has joined #instantbird 18:43:35 --> gerard-majax has joined #instantbird 18:44:51 --> Mic has joined #instantbird 18:44:51 * ChanServ sets mode +h Mic 18:45:06 <-- Mic has quit (Connection reset by peer) 18:45:28 <-- chrisccoulson has quit (Quit: Ex-Chat) 18:51:30 --> Mic has joined #instantbird 18:51:30 * ChanServ sets mode +h Mic 18:51:49 --> sonny has joined #instantbird 19:03:06 * jwir3 is now known as jwir3|brb 19:04:21 --> micahg has joined #instantbird 19:06:21 --> FeuerFli1 has joined #instantbird 19:10:57 --> flo has joined #instantbird 19:10:57 * ChanServ sets mode +qo flo flo 19:11:28 <flo> I'm glad I don't have these duplicated XMPP MUCs any more :) 19:11:42 <flo> I still need to fix NickServ Killer to also kill the ChanServ tab :) 19:18:29 <-- sonny has quit (Client exited) 19:20:55 * jwir3|brb is now known as jwir3 19:28:52 <-- micahg has quit (Ping timeout) 19:30:43 <-- Mic has quit (Quit: Input/output error ^^) 19:31:01 --> Mic has joined #instantbird 19:31:01 * ChanServ sets mode +h Mic 19:31:07 <-- Mic has quit (Connection reset by peer) 19:31:16 --> Mic has joined #instantbird 19:31:16 * ChanServ sets mode +h Mic 19:32:04 <Mic> I had like five Windows-"Instantbird stopped working"-crashes without crashreporter today :( 19:34:21 --> igorko has joined #instantbird 19:35:58 --> clokep has joined #instantbird 19:35:58 * ChanServ sets mode +o clokep 19:37:44 <flo> clokep: you can look at that patch (well, any patch really) if you want ;) 19:38:34 <clokep> flo: Yeah...I'm wondering what's up with my patch right now though, so I think I'll look at that one. ;) 19:39:21 <flo> I think I've got 2 or 3 patches I need to look at this evening 19:39:39 <flo> when was your target date for the 1.2 release again? 19:40:49 <clokep> In a few weeks from now. I forget the exact date. :( 19:41:06 <flo> seems like we aren't going to make it if we don't even remember when it is ;) 19:41:35 <clokep> June 24th? Does that sound right? June 14th? 19:42:04 <flo> releasing in the summer again? 19:42:24 <flo> that would be based on moz13? 19:43:29 <clokep> I think we decided to stick with Moz 11. 19:43:39 <clokep> Maybe it was May 24th. :( 19:43:54 <flo> I think it was may 24 and moz12 19:44:08 <flo> I'm sure I've never agreed to release based on an outdated and unsupported mozilla ;) 19:44:40 <Mic> Is Bug 1350 only a simple string change (with future updates) or should the version number automatically be inserted there? 19:44:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1350 nor, --, ---, nobody, NEW, Put back the version number in the default IRC quit message 19:45:08 <clokep> I'd prefer it's gotten automatically. 19:46:46 <flo> hmm, we could insert it with the preprocessor 19:47:27 <flo> see http://lxr.instantbird.org/instantbird/source/instantbird/app/profile/all-instantbird.js#7 and http://lxr.instantbird.org/instantbird/source/instantbird/app/profile/all-instantbird.js#291 19:48:08 <flo> I think I'll even try it right now :) 19:48:15 --> micahg has joined #instantbird 19:48:25 <-- micahg has quit (Client exited) 19:48:50 <-- FeuerFli1 has quit (Ping timeout) 19:50:07 <Mic> Fine with me ;) 19:50:18 --> micahg has joined #instantbird 19:51:15 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 1442 on bug 1350. 19:51:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1350 nor, --, ---, florian, NEW, Put back the version number in the default IRC quit message 19:51:37 <flo> it seems almost too easy to be true, is there anything I could have missed? 19:54:05 <-- mmkmou has quit (Ping timeout) 19:54:27 <instantbot> clokep@gmail.com granted review for attachment 1442 on bug 1350. 19:54:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1350 nor, --, ---, florian, NEW, Put back the version number in the default IRC quit message 19:54:39 <clokep> Seemed to work fine. :) 19:54:52 <flo> it's shorten that sw:1.2 list :) 19:54:57 <clokep> Haha. 19:56:48 <flo> I'm annoyed by bug 1123. I dislike the patch (but don't see good reasons to reject it either) and I don't think it deserved the 1.2-wanted whiteboard annotation as it's definitely not a regression, but on the other hand I almost promised that I would clean up the review queue before the 1.2 release 19:56:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1123 nor, --, ---, aletheia2, ASSI, Tooltips of IRC contacts don't show whois information 19:57:03 <flo> so I guess I'll check it in and do my best to forget it as quickly as possible :-D 19:57:58 --> mmkmou has joined #instantbird 19:58:12 <clokep> flo: I really dislike that patch too. 19:58:34 <flo> is it a good enough reason to r-? 19:58:52 <aleth> Nobody likes that patch... I guess you'll have to redesign the tooltips as you planned for 1.3 :D 19:59:20 <flo> I don't think I will 19:59:39 <flo> it's a relatively easy task, I'll let someone else play with it 19:59:41 <clokep> Is it a good enough reason? Not really, but I wouldn't be against it either. 19:59:51 <Mic> Wasn't "redesign the tooltips" mostly about layout/visual changes? 20:00:01 <flo> Mic: yes. 20:00:08 <flo> I also wanted to remove some pointless messages 20:00:23 <flo> which I've already done for XMPP with JS-XMPP 20:00:28 <Mic> The pointless messages would be removed at protocol level though, iirc 20:00:47 <flo> by the way, the JS-XMPP tooltips are probably the only improvement compared to libpurple-XMPP right now 20:00:53 <flo> and we still have regressions :( 20:00:55 <aleth> I don't mind if you r- it or r+ that one. It's minimal, anything more elaborate would have to redo much more of the surrounding code. 20:01:21 <aleth> (and I'm not volunteering) 20:01:33 --> FeuerFli1 has joined #instantbird 20:01:35 <flo> aleth: I think I'll r+ to forget it. 20:01:46 <flo> (may not be a good bet if it causes regressions :-D) 20:03:56 <aleth> (or if the larger tooltips annoy you every time you see them :D) 20:04:50 <aleth> I guess they might be useful in the contact list. 20:06:44 <flo> aleth: http://pastebin.instantbird.com/36879 this is what I'm about to commit 20:07:36 <flo> I fixed the indent of the requestBuddyInfo method to look similar to the method before and after it, and reverted the var->let change in the second hunk (I don't see a valid reason to change just one when there are other var in the method) 20:08:08 <aleth> Right, thanks. 20:08:47 <aleth> That must be one of the files with 2n+1 indentation :-/ sorry for not catching that 20:10:40 <instantbot> florian@instantbird.org granted review for attachment 1364 on bug 1123. 20:10:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1123 nor, --, ---, aletheia2, ASSI, Tooltips of IRC contacts don't show whois information 20:10:52 <clokep> aleth: I found the issue w/ my patch. 20:11:01 <aleth> clokep: yay :) 20:11:07 <flo> aleth: indentation in our XBL files isn't consistent, but I try to at least not make it worse 20:12:18 <flo> what's the plan for bug 1021? 20:12:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1021 maj, --, ---, clokep, ASSI, Replace unsupported libpurple QQ with libqq-pidgin 20:12:54 <clokep> flo: Update the strings, mark that as resolved and at some point take care of the crappy captcha API. 20:13:02 <clokep> We got a report (recently on the blog) that QQ works. 20:13:20 <flo> I didn't really believe it though :) 20:13:30 * bear is now known as bear-afk 20:14:31 <flo> nobody has taken care of https://code.google.com/p/libqq-pidgin/issues/detail?id=219 ? :( 20:14:34 <flo> is that project still active? 20:15:36 <aleth> https://code.google.com/p/libqq-pidgin/source/list 20:16:31 <flo> :( 20:16:58 <clokep> Bah. :( 20:18:06 <-- FeuerFli1 has quit (Ping timeout) 20:20:04 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1443 on bug 318. 20:20:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=318 enh, --, ---, clokep, ASSI, Check if topic on IRC channels is editable and make UI respond accordingly 20:20:59 <aleth> Is it just me or does the interdiff on bugzilla not work? 20:21:07 <clokep> It never has. 20:21:41 <flo> my attempts to get Even to fix it never really worked either 20:22:47 <flo> I don't remember well if there was a real issue with interdiff crashing/not working well on FreeBSD, or if it was mostly laziness ;) 20:22:49 <clokep> aleth: That major change is in get topicSettable() 20:23:14 <aleth> aha! 20:23:41 <flo> I hope I may be able to improve the l10n situation and work on the libpurple upgrade Sunday. 20:23:56 <aleth> I'm glad it wasn't anything more difficult to fix 20:25:14 <clokep> Yeah it wasn't too bad, just needed to get a stack of whree it was being created. :) 20:25:30 <aleth> :) 20:33:44 <flo> http://i.imgur.com/9XNE6.png which time format seems better? 20:34:18 <instantbot> aletheia2@fastmail.fm granted review for attachment 1443 on bug 318. 20:34:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=318 enh, --, ---, clokep, ASSI, Check if topic on IRC channels is editable and make UI respond accordingly 20:34:53 <clokep> flo: i don't think you'd need the day of the week. 20:36:47 <flo> Ok... 20:37:06 <flo> I don't think I agree, but I guess it's another patch I'm willing to check-in and forget 20:37:15 <Mic> Isn't the day of the week useful? 20:37:38 <flo> Mic: it is, but your patch drops it (at least on Mac) 20:38:00 <Mic> Really? That sucks :( 20:38:24 <flo> but clokep thinks it isn't, so the next time I'll miss it I'll blame him instead of you :-P 20:38:48 <Mic> (I guess I'd rather remember the day of the week than the actual date when trying to think when I talked to someone) 20:38:51 <clokep> flo: I think it's useful if the logs are recent, otherwise (if it's old logs) then it doesn't matter. 20:39:07 <flo> Mic: there's an example of usage of that API here: http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/mozapps/downloads/DownloadUtils.jsm#334 20:39:28 <flo> you need a +1 for the month, and you don't need the date.getSeconds call as you request that they aren't displayed 20:39:42 <flo> I think I'm going to commit your patch after making these 2 changes 20:40:03 <flo> even though I'll miss the day of the week, it's probably better than an en-US string for all locales. 20:40:36 <Mic> I think I looked at this (there's no docs elsewhere iirc). I must have missed the details for the month :( 20:40:53 <flo> Mic: I missed it too the last time I used that crappy API 20:41:48 <flo> Mic: I think there's some documentation in the idl file, but it's boring to read the description of what each parameter expects, so we (lazy developers) quickly assume that it's what the date object provides, because that would be logical :) 20:41:51 <Mic> Start counting with 0 is absolutely OK for stuff like array indices, but for the number of the month, it sucks 20:42:13 <flo> Mic: well, then it's the Date object that you dislike 20:42:16 <flo> but that doesn't change the result :) 20:44:54 <Mic> ah, one thing: do you think we might need the date and time in the app-locale elsewhere? -> should I have put that into a module for re-use? 20:46:26 <flo> if the function was more interesting, yes 20:46:29 <flo> currently, no 20:46:50 <Mic> OK. 20:47:11 <flo> I think we will want a follow-up to improve it to show the time for today, "yesterday" + time for yesterday, the day of the week for the last 7 days, and the date otherwise 20:47:44 <flo> there's some example code at http://mxr.mozilla.org/comm-central/source/mailnews/base/util/templateUtils.js#49 and http://mxr.mozilla.org/comm-central/source/mozilla/mobile/xul/chrome/content/downloads.js#344 20:47:56 <flo> unfortunately both use .toLocaleFormat :( 20:49:01 --> Mautematico has joined #instantbird 20:50:25 <flo> Mic: is it ok with your formatted this way: http://pastebin.instantbird.com/36920 ? 20:50:52 <Mic> Yes 20:50:59 <flo> it saves 4 lines 20:51:03 <flo> + there are the 2 changes I mentioned before 20:51:11 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.88.2 [Firefox 13.0/20120501201020]) 20:51:17 <flo> ok, I'm taking that version then 20:51:54 <-- Mautematico has quit (Ping timeout) 20:57:02 <instantbot> florian@instantbird.org granted review for attachment 1356 on bug 1135. 20:57:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1135 min, --, ---, benediktp, ASSI, Log date is not translated 21:02:38 --> Mautematico has joined #instantbird 21:03:41 <Mic> Thanks for the review! 21:05:09 <flo> Mic: np, sorry for the long delay 21:05:20 <flo> clokep: what's mode +q and mode +n on IRC nicks? 21:06:57 <clokep> +q is "Only U:liners can kick this user" 21:07:04 <clokep> +n is op I think. 21:07:13 <clokep> Wait, no...that's o, duh. 21:08:28 <aleth> no messages from non-participants I think. 21:09:02 <clokep> Actually, I think it's founder flo. 21:09:26 <aleth> ah, sorry, you were asking about usermodes, not channelmodes 21:09:28 <flo> clokep: that's what I thought too 21:09:47 <flo> that's why I was surprised when seeing "get founder() this._modes.indexOf("n") != -1," in your patch (in the unmodified context) 21:10:29 <clokep> Why are you surprised by that? 21:11:49 <flo> because I've never seen an "n" mode 21:13:09 <clokep> Ah. I've seen it before, but I don't think Unreal really uses it? 21:13:46 <flo> http://www.vulnscan.org/UnrealIRCd/unreal32docs.html#userchannelmodes 21:14:33 <flo> it seems q is owner, a is administrator 21:16:29 --> BYK1 has joined #instantbird 21:16:55 --> jb has joined #instantbird 21:18:05 <-- BYK has quit (Ping timeout) 21:19:08 <flo> clokep: how difficult would it be to avoid the pointless "chat-update-topic" notifications? 21:19:45 <flo> it seems at the 3 places where you send that notification what you really wanted to do is call a method on the conversation to check if topicSettable has changed, and fire a notification if it has changed 21:20:39 <clokep> Yeah, that's really what I want to do. 21:21:41 <flo> was there a reason for not doing it? :) 21:28:28 <-- mmkmou has quit (Quit: Instantbird -- http://www.instantbird.com) 21:30:18 <-- meh has quit (Quit: I don't want to live on this planet anymore.) 21:30:48 --> skeledre1 has joined #instantbird 21:31:52 <-- BYK1 has quit (Quit: Instantbird -- http://www.instantbird.com) 21:40:42 * jwir3 is now known as jwir3|away 21:41:54 <clokep> flo: i didn't see a way it was possible? 21:42:01 <clokep> Or I was just lazy. :) 21:42:07 <Mic> flo: did you have a particular idea how to avoid the ongoing conversation from within |getLogsForConversation| ? 21:42:18 <Mic> The only idea I had so far was to extend the |ConversationLog| to include the name of the file in question, get the |ConversationLog| of the ongoing conversation using |getLogForConversation| and filter the |directoryEntries| accordingly. 21:42:54 <flo> Mic: http://lxr.instantbird.org/instantbird/source/chat/components/src/logger.js#221 21:43:09 <flo> so check for aConversation.id in gConversationLogs :) 21:43:37 <flo> you don't think you want to call getLogForConversation because it could create a log if one doesn't exist yet 21:43:41 <flo> *I don't think 21:45:10 <Mic> OK, thanks. This will defininitely help, I think. 21:45:59 <flo> hmm, maybe LogConversation should be extended, as you suggested. Should it implement imILog? 21:46:41 <flo> s/LogConversation/ConversationLog/ sorry 21:47:19 <flo> clokep: "i didn't see a way it was possible?" I wonder if I can pretend to believe that or not 21:47:22 <Mic> We have both, yes .. 21:51:08 <flo> clokep: what about: the first time the topicSettable getter is called, store the result and then return that cached result instead of recomputing. Add a method that checks if recomputing gives the same value as what was cached; if the value changed, change what's cached, and fire the notification. 21:54:39 <clokep> Hmm...yeah something like that could work. 21:55:39 <flo> am I likely to convince you to try? :) 21:57:37 <flo> Mic: do you want review comments on the current attachment, or is the feedback already received enough to keep you busy? I have identified a few details I would point out if an actual review was requested 21:58:03 <clokep> flo: I can try But I'm going out soon, so tomorrow. 21:59:08 <Mic> The feedback will keep me busy but you can comment anyways if you like. 21:59:11 <flo> that's ok :) 21:59:55 --> meh has joined #instantbird 22:02:41 <-- clokep has quit (Ping timeout) 22:05:59 <-- igorko has quit (Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org) 22:08:50 <instantbot> florian@instantbird.org granted feedback for attachment 1437 on bug 958. 22:08:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=958 enh, --, ---, benediktp, ASSI, Show last messages (history) in new chat windows 22:09:44 <-- jb has quit (Ping timeout) 22:12:44 --> Kaishi has joined #instantbird 22:15:06 <flo> aleth: "Your computer is offline." the wording for that message seems wrong :-/ 22:15:11 --> igorko has joined #instantbird 22:15:54 <flo> technically it's necko that's offline. It could be because the user checked the "start offline" checkbox of the profile manager 22:17:17 <flo> aleth: and would any user understand the difference between "Your computer is offline." and "You are currently offline."? 22:18:58 <aleth> Yeah... that's why I asked whether there should be a second sentence with a suggested action. 22:19:33 <aleth> "Your network connection is offline" and "Your status is currently set to offline", is that better? 22:19:39 <flo> we already have a "Your account is disconnected." system message 22:19:58 <aleth> Yes. 22:20:56 <flo> what about these 3: "Your account is disconnected." "Your account is disconnected because there's no network connection." "Your account is disconnected because your status is "Offline""? 22:21:35 <aleth> It's helpful to include the account name I think. 22:21:54 <aleth> But yes, those sound better. 22:24:13 <flo> but the 2 existing messages at http://lxr.instantbird.org/instantbird/source/chat/locales/en-US/conversations.properties#22 don't 22:24:27 <flo> (include the account name) 22:25:32 <aleth> One could change those, but actually I don't think it's necessarily bad to provide more information if the user tries to send a message despite that warning. 22:26:29 <aleth> What do you think? 22:27:56 <aleth> The use case I was thinking of was when the user assumes the account has reconnected but it actually hasn't. 22:28:09 <flo> I think somewhere between "I agree" and "I don't care" ;) 22:28:18 <aleth> :D 22:29:11 <flo> so yeah, my comments on that patch are that the strings need to be improved 22:29:26 <flo> and that line |let status = Status.toAttribute(Services.core.globalUserStatus.statusType);| doesn't seem exactly right 22:30:17 <aleth> No? I copied it from elsewhere in the code where status==offline was checked for 22:30:18 <flo> first because you use it only once, and not all the time, so it could be inlined (even though the line would become a bit long, but probably acceptable) 22:30:45 <flo> and also because I'm wondering if Services.core.globalUserStatus is really what you want 22:30:47 <aleth> Yes, I used the let because of the length of the line...\ 22:31:26 <flo> oh, and you really don't need the toAttribute 22:31:46 <flo> compare with Ci.imIStatusInfo.STATUS_OFFLINE 22:31:58 <aleth> Right. 22:32:11 <aleth> No need to turn it into a string. 22:32:42 <flo> I'm wondering if you want account.statusInfo instead of Services.core.globalUserStatus 22:32:59 <Mic> good night 22:33:02 <-- Mic has quit (Quit: Input/output error ^^) 22:33:11 <flo> :-D 22:36:07 <aleth> I don't know what the difference is :-/ 22:36:11 <flo> I guess the only case where this would make a difference is: 1. The global status is offline. 2. The account has a non-offline account-specific status. 3. The status is disconnected 22:37:24 <flo> aleth: by default account.statusInfo points to Services.core.globalUserStatus. But add-ons can change that if anybody ever becomes interested in having a different status for some accounts. 22:37:53 <flo> (such an add-on doesn't exist though, because people requesting that feature seem more interested in complaining than actually writing code :-P) 22:39:49 <flo> if you have never noticed this API: http://lxr.instantbird.org/instantbird/source/chat/components/public/imIAccount.idl#291 22:39:58 <aleth> Thanks! 22:40:24 <aleth> I guess that's what would enable account-specific invisible etc... 22:40:53 <aleth> So I suppose account.statusInfo is the correct one to use. 22:41:44 <flo> it's tricky to write a correct message though, because "your status" (the global status) isn't necessarily the same thing as "your account's status" 22:41:59 <flo> but anyway, let's stop wasting time with details nobody will notice :) 22:42:16 <flo> account.statusInfo seems shorted to type, so that makes a good reason to use it :-D 22:42:27 <aleth> I'll go with that :D 22:42:52 <aleth> Oh, I forgot 22:43:07 <flo> aleth: "I guess that's what would enable account-specific invisible etc..." I designed this so that more than the status can be modified for some accounts. Accounts can have a specific contact icon, display name, etc... 22:43:54 <flo> The use case I had in mind when I added this was a person exposing different identities (ie personal and professional) through the various accounts 22:43:54 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1435 on bug 1415. 22:43:55 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1444 on bug 1415. 22:44:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1415 nor, --, ---, aletheia2, ASSI, Unread ruler should also appear after last context message 22:44:38 <aleth> flo: That makes sense. Definitely an add-on that would be used by some. 22:45:18 <flo> I wanted to offer a real solution to the poorly phrased request from people in that situation 22:45:41 <aleth> Usually the people that want contacts sorted by account? 22:46:03 <flo> people who want to be able to set a different status for some account 22:46:21 <flo> typically when working you want to appear busy for friends and available for coworkers, and the opposite when at home 22:47:26 --> FeuerFli1 has joined #instantbird 22:49:15 <-- FeuerFli1 has quit (Ping timeout) 22:51:31 <instantbot> florian@instantbird.org granted review for attachment 1444 on bug 1415. 22:51:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1415 nor, --, ---, aletheia2, ASSI, Unread ruler should also appear after last context message 22:52:34 <flo> I think this r+ means both "This is way less confusing" and "I'm too tired to argue any more about this." I really hope it's more of the former though :) 22:52:54 <aleth> I hope so too... 22:53:02 * jwir3|away is now known as jwir3 22:53:29 <aleth> It isn't really about arguing after all but about making the code more comprehensible and cleaner for whoever modifies it next... 22:53:50 <flo> yeah :) 22:54:14 <flo> thanks for taking care of that too :) 22:54:20 <aleth> I was quite pleased with how much more streamlined it became after separating out the booleans though ;) 22:55:54 <flo> there may still be some possible additional improvement for that around the isChat and containsNick usage 22:55:58 <flo> but it's not obvious :-S 22:56:28 <aleth> and some this.tab's could possibly be saved, but I wasn't sure why some of them had been added in the past so I left them in 22:56:49 <-- igorko has quit (Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org) 22:57:08 <flo> aleth: it may be very very old code 22:57:26 <flo> at some point the goal was to make the conversation binding reusable even without a tab 22:57:45 <flo> (for add-ons) 22:57:59 <flo> I don't think anybody has tried to do that recently, so that's probably broken in various ways 22:58:08 <aleth> sounds ambitious 22:58:28 <flo> it just requires not using this.tab ;) 23:00:04 <flo> in my recent experiences (with Tb for instance), that feature hasn't been really useful, as even without having conversation tabs, the code still wants to have an element where the "unread" and "attention" attributes are magically set 23:02:08 <aleth> That would be the most obvious recent dependency 23:02:33 <aleth> Of course you could just set this.tab to point at some dummy element if you really wanted to... 23:02:36 <flo> wow, r+ in bug 743235! 23:02:48 <aleth> which one is that? 23:02:57 <flo> unified email/IM search 23:03:39 <aleth> That sounds like a big one :) 23:03:59 <aleth> Comparing account.statusInfo to Components.interfaces.imIStatusInfo.STATUS_OFFLINE doesn't work, what am I missing? 23:04:34 <flo> account.statusInfo.statusType ;) 23:04:42 <aleth> ah :) thanks! 23:07:29 <flo> I'm wondering if I'm going to have an r+able version of that patch before going to bed (soon) 23:08:11 <aleth> There you go: 23:08:13 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1441 on bug 1353. 23:08:14 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1445 on bug 1353. 23:08:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1353 nor, --, ---, aletheia2, ASSI, No user feedback when sending a message in a conversation of an offline account 23:11:01 <-- Tomek has quit (Quit: Instantbird 1.1) 23:11:04 <flo> any reason for inserting the protocol and account names in only one of the 3 messages? 23:11:10 <flo> (it's a real question, not a request for a change) 23:11:37 <aleth> Because if the network or the status is offline, you don't need the account name to fix the problem. 23:11:52 <aleth> (modulo account-specific special cases that don't exist yet) 23:12:08 <flo> ok, sounds reasonable 23:12:36 <aleth> I first inserted them, then took them out again as the message got really long for no real benefit. 23:12:58 <-- Mautematico has quit (Ping timeout) 23:13:56 <flo> I have only 2 nits: 1. var account -> let account (there are lots of let in that method already 2. I don't see why there are { } in the userOffline case 23:14:31 <flo> and maybe userOffline -> statusOffline 23:14:35 <aleth> I thought we always put {} if part of the if clause stretched over more than one line 23:15:17 <flo> "always", no. But it's right that we sometimes did. So if you want to keep them, I'm not against it. 23:15:40 <aleth> Should I fix those nits or are you going to do it? 23:16:09 <flo> what do you prefer? 23:16:18 <aleth> I don't mind, I have the file open anyway 23:16:26 <flo> if you attach a new patch, please fix the path (otherwise I would have to edit the file anyway) 23:16:33 <-- meh has quit (Quit: I don't want to live on this planet anymore.) 23:16:42 <aleth> OK 23:16:49 <flo> ok, I'm lazy :) 23:16:57 <flo> you can keep the {} if you want, I don't really mind 23:17:17 <aleth> Nor do I... 23:17:38 <flo> !8ball should we keep these {}? 23:17:39 <instantbot> flo: About as likely as pigs flying. 23:17:56 <aleth> We should use that for bikeshedding more often :D 23:17:56 <flo> instantbot: botsnacks 23:17:59 <instantbot> flo: Sorry, I've no idea what 'botsnacks' might be. 23:18:10 <flo> :( 23:19:13 <flo> instantbot: botsnack 23:19:14 <instantbot> yay 23:19:44 <flo> (apparently it can only enjoy one snack at a time) 23:21:24 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1445 on bug 1353. 23:21:27 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1446 on bug 1353. 23:21:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1353 nor, --, ---, aletheia2, ASSI, No user feedback when sending a message in a conversation of an offline account 23:24:07 <instantbot> florian@instantbird.org granted review for attachment 1446 on bug 1353. 23:24:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1353 nor, --, ---, aletheia2, ASSI, No user feedback when sending a message in a conversation of an offline account 23:25:49 <flo> now it's time to close bugs :) 23:28:05 <aleth> should get rid of a few blockers :) 23:32:00 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/d5ec6271f566 - Florian Quèze - Bug 1350 - Put back the version number in the default IRC quit message, r=clokep. 23:32:01 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/3dba6fdbf6f6 - aleth - Bug 1415 - Unread ruler should also appear after last context message, r=fqueze. 23:32:02 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/194399651469 - Patrick Cloke - Bug 1418 - No/incorrect error message when joining a channel fails, r=aleth. 23:32:03 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/97f92dbe9f60 - aleth - Bug 1353 - No user feedback when sending a message in a conversation of an offline account, r=fqueze. 23:32:04 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/0e3104136068 - Benedikt Pfeifer - Bug 1135 - Log date is not translated, r=fqueze. 23:32:05 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/74c76a451976 - aleth - Bug 1123 - Tooltips of IRC contacts don't show whois information, r=fqueze. 23:32:06 <instantbot> florian@instantbird.org set the Resolution field on bug 1350 to FIXED. 23:32:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1350 nor, --, 1.2, florian, RESO FIXED, Put back the version number in the default IRC quit message 23:32:33 <instantbot> florian@instantbird.org set the Resolution field on bug 1123 to FIXED. 23:32:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1123 nor, --, 1.2, aletheia2, RESO FIXED, Tooltips of IRC contacts don't show whois information 23:32:59 <flo> aleth: btw, what happens when sending a message to a parted IRC channel? 23:33:40 <aleth> You get an error message 23:33:45 <instantbot> florian@instantbird.org set the Resolution field on bug 1418 to FIXED. 23:33:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1418 nor, --, 1.2, clokep, RESO FIXED, No/incorrect error message when joining a channel fails 23:33:48 <aleth> Its wording could be improved 23:34:07 <aleth> "There is no channel: #channelname" 23:34:27 <instantbot> florian@instantbird.org set the Resolution field on bug 1135 to FIXED. 23:34:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1135 min, --, 1.2, benediktp, RESO FIXED, Log date is not translated 23:34:30 <aleth> But it also crops up in other circumstances, that's probably why 23:35:07 <instantbot> florian@instantbird.org set the Resolution field on bug 1415 to FIXED. 23:35:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1415 min, --, 1.2, aletheia2, RESO FIXED, Unread ruler should also appear after last context message 23:36:39 <instantbot> florian@instantbird.org set the Resolution field on bug 1353 to FIXED. 23:36:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1353 nor, --, 1.2, aletheia2, RESO FIXED, No user feedback when sending a message in a conversation of an offline account 23:37:12 <flo> aleth: can't we detect that left == true, to display a more meaningful message? 23:39:06 <flo> actually, it displays "You cannot send messages to <channel name>." which isn't so bad 23:39:07 <aleth> Probably, if one modified the 401 handler. 23:39:31 <aleth> Oh? OK then :) 23:39:39 <flo> aleth: why is there a handler involved in that? Should it fail before sending anything to the server? 23:39:54 <flo> *shouldn't 23:40:47 <aleth> That would be better actually, for that special case. 23:41:19 <flo> should the check be in the conversation binding of in irc's code? 23:42:12 <aleth> I'm not sure off-hand where it would best be inserted. Probably whenever sending to a channel, check the channel hasn't been left 23:42:13 <flo> *or 23:42:41 <flo> I would be it would be best inserted in bugzilla ;) 23:42:52 <flo> *I would bet 23:42:54 <aleth> Of course, you could check isChat and .left() from conversation.xml sendMsg too 23:42:58 <aleth> not just for IRC then... 23:43:12 <flo> typing is hard at almost 2am on a Friday evening it seems :-S 23:43:15 <aleth> (where we just added 1353 23:43:24 <-- myk has quit (Ping timeout) 23:43:51 <flo> I think I actually wanted to ask that while reviewing that bug, but I forgot :) 23:44:13 <flo> I was offline in the metro when I thought about that 23:45:36 <aleth> A follow-up for another day ;) 23:47:55 <flo> yeah, if someone cares 23:48:01 <flo> the current message isn't a disaster :) 23:49:11 <aleth> Better than none at all ;)