#instantbird log on 11 25 2011

All times are UTC.

00:02:01 <flo> the build system update was a more significant contribution
00:02:26 <flo> but it's possible it was his first patch
00:04:51 <flo> no, it wasn't
00:08:37 <flo> clokep: http://pastebin.instantbird.com/1110
00:09:59 <clokep> Then ohloh is lying to me. :)
00:10:29 <flo> was ohloh claiming that we recruited a new contributor? ;)
00:12:24 <clokep> Yup! 2 new ones in fact: "Quentin Raynaud" and "Quentin Raynayd" ;)
00:17:23 <flo> uh?
00:17:33 <flo> where have I typoed?
00:17:56 <clokep> http://hg.instantbird.org/instantbird/rev/535bf71528c9
00:18:14 <clokep> It looks like.
00:22:47 <flo> :(
00:23:35 <clokep> Apparently you can edit a commit message afterward, but I'm fairly certain it messes up the history after that.
00:25:23 <clokep> http://knowledgestockpile.blogspot.com/2010/12/changing-commit-message-of-revision-in.html
00:45:29 <flo> yeah, I'm not interested in breaking everybody's tree ;)
00:45:51 <clokep> Yup. :)
00:48:00 <-- Mook has quit (Ping timeout)
00:50:09 --> Mook has joined #instantbird
00:55:46 --> billysanca has joined #instantbird
00:59:35 <-- clokep has quit (Ping timeout)
01:04:01 <-- Mook has quit (Ping timeout)
01:06:04 --> Mook has joined #instantbird
01:10:27 <-- flo has quit (Ping timeout)
01:10:59 --> flo has joined #instantbird
01:10:59 * ChanServ sets mode +qo flo flo 
01:19:28 <-- billysanca has quit (Quit: Instantbird 1.2a1pre)
01:19:34 <-- Tomek has quit (Quit: Instantbird 1.1)
01:19:35 --> billysanca has joined #instantbird
01:31:17 * flo has finished merging the XMPPConnection, XMPPSession and XMPPSocket object, and surprisingly, the accounts can still connect!
01:32:25 <flo> Good night :)
01:32:28 <-- flo has quit (Quit: Instantbird 1.2a1pre)
01:35:42 --> clokep has joined #instantbird
01:35:42 * ChanServ sets mode +h clokep 
01:44:09 --> BlueMaxima has joined #instantbird
01:46:09 <-- clokep has quit (Ping timeout)
01:54:51 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
02:38:15 <-- billysanca has quit (Quit: Instantbird 1.2a1pre)
02:53:08 <-- Mook has quit (Ping timeout)
03:44:09 <-- skeledrew has quit (Quit: Instantbird 1.2a1pre)
04:23:25 <-- EionRobb has quit (Quit: Leaving.)
04:39:57 --> Mook has joined #instantbird
04:41:53 <-- Mook has quit (NickServ (GHOST command used by Mook_))
04:42:16 --> Mook has joined #instantbird
04:43:35 <-- Mook has quit (NickServ (GHOST command used by Mook_))
04:44:32 --> Mook has joined #instantbird
04:57:49 <-- Mook has quit (Ping timeout)
04:59:37 --> Mook has joined #instantbird
06:16:26 --> clokep has joined #instantbird
06:16:26 * ChanServ sets mode +h clokep 
06:16:39 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
06:16:48 --> clokep has joined #instantbird
06:16:48 * ChanServ sets mode +h clokep 
06:32:02 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
07:42:35 <-- SM0TVI has quit (Connection reset by peer)
07:48:36 --> SM0TVI has joined #instantbird
07:55:12 --> Mic has joined #instantbird
07:55:13 * ChanServ sets mode +h Mic 
08:14:23 <-- Mic has quit (Connection reset by peer)
08:32:43 --> MadWookiee has joined #instantbird
09:05:28 --> jb has joined #instantbird
09:07:59 <-- gerard-majax has quit (Ping timeout)
09:13:05 <-- Even1 has quit (Quit: Instantbird 1.2a1pre)
09:13:12 --> Even has joined #instantbird
09:13:12 * ChanServ sets mode +o Even 
09:13:16 <-- Even has quit (Quit: Even)
09:13:20 --> Even has joined #instantbird
09:13:21 * ChanServ sets mode +o Even 
09:30:00 --> mmkmou has joined #instantbird
09:31:10 <-- jb has quit (Ping timeout)
09:43:22 --> Tomek has joined #instantbird
09:48:58 --> gerard-majax has joined #instantbird
09:53:31 --> aleth has joined #instantbird
10:05:05 <-- Tomek has quit (Quit: Instantbird 1.1)
10:30:48 --> flo has joined #instantbird
10:30:48 * ChanServ sets mode +qo flo flo 
10:32:39 <-- Mook has quit (Quit: zzz)
10:37:08 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
10:37:17 --> aleth has joined #instantbird
10:37:29 --> Mic has joined #instantbird
10:37:30 * ChanServ sets mode +h Mic 
10:37:54 <Mic> Hello.
10:38:29 <aleth> Hi :)
10:39:50 --> jb has joined #instantbird
10:48:16 <flo> Bonjour :)
10:51:49 <-- aleth has quit (Ping timeout)
11:05:10 --> jb1 has joined #instantbird
11:05:39 <-- jb has quit (Ping timeout)
11:21:17 --> ironhead has joined #instantbird
11:40:09 --> aleth has joined #instantbird
11:44:36 <-- jb1 has quit (Ping timeout)
12:03:18 --> jb has joined #instantbird
12:05:06 <-- jb has quit (Ping timeout)
12:16:12 <-- MadWookiee has quit (Ping timeout)
12:28:17 --> Ron_ has joined #instantbird
12:28:39 --> jb has joined #instantbird
12:44:35 <-- jb has quit (Ping timeout)
13:02:26 --> jb has joined #instantbird
13:08:54 --> Tomek has joined #instantbird
13:19:08 --> MadWookiee has joined #instantbird
13:37:15 <-- ironhead has left #instantbird ()
13:48:39 <-- Ron_ has quit (Quit: )
14:31:48 <-- Tomek has quit (Quit: Instantbird 1.1)
14:40:43 --> clokep has joined #instantbird
14:40:43 * ChanServ sets mode +h clokep 
15:05:55 --> Guido has joined #instantbird
15:16:53 <-- jb has quit (Ping timeout)
15:22:52 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
15:24:29 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
15:26:12 <clokep> Great news that you were able to merge the Connection/Session/Socket objects! Were they really just reflecting the same state across all?
15:26:23 <clokep> (That probably removed a ton of code...)
15:48:21 <flo> clokep: removed a little less than 300 lines
15:48:29 <flo> but I can understand the code much better now! :)
15:57:56 <-- Guido has quit (Quit: Instantbird 1.1)
15:58:17 --> Mic has joined #instantbird
15:58:18 * ChanServ sets mode +h Mic 
16:00:04 <clokep> 300 lines is a good amount (for the total amount of code in the XMPP stuff!) But understanding is more important. :)
16:00:32 <clokep> I hope the GTalk code directly reused only one of those and you didn't need to do a GTalk Connection, GTalkSession and GTalkSocket too. :)
16:00:37 --> Plop has joined #instantbird
16:01:22 <flo> the Gtalk code wasn't touching that
16:01:39 <flo> only extending the account and protocol implementations I think
16:01:52 <flo> clokep: would you like to review the XMPP code soon by the way?
16:02:21 <flo> I still have a long list of things that are used in the current libpurple plugin but not implemented in JS-XMPP, but I should be done cleaningup the code in a few hours
16:02:30 <clokep> flo: I would, I'm afraid I'm not too familiar with the XMPP spec, but I can definitely look over the aspects of how it interacts w/ Instantbird.
16:02:48 <clokep> Great! :)
16:03:04 <flo> the XMPP protocol is super easy to understand (as long as you don't care yet about server specific issues)
16:04:42 <clokep> OK! :) I can look up other parts then (is the best reference the RFCs/XEPs or have you found another good one?)
16:05:17 <flo> seriously? I haven't used any reference
16:05:53 <flo> just googled 2 or 3 details when things were "surprising" (and actually wrong) in Varuna's code
16:06:18 <clokep> Ah, sounds good then.
16:06:37 <flo> however, I've read this book a year or two ago: http://www.amazon.com/XMPP-Definitive-Real-Time-Applications-Technologies/dp/059652126X/
16:06:44 <flo> it's a great introduction to the protocol
16:07:10 <flo> so I already knew how the protocol works... and I haven't felt the need for any reference material yet
16:07:28 <clokep> You could have just said "I read the O'Reilly book on XMPP" ;)
16:07:35 <clokep> And I would have believed you it's great.
16:07:59 <clokep> What do we think that is? A muskrat?
16:08:01 <flo> not the O'Reilly book, Peter Saint-Andre's book! 
16:08:50 <clokep> Ah, well I meant anything published by O'Reilly is pretty legit.
16:09:13 <clokep> Maybe I'll buy it (through Instantbird of course. ;))
16:09:29 <clokep> (Which I've been doing for all my Amazon stuff now btw!)
16:10:34 <flo> it seems there are cheap used copies
16:14:14 <flo> hmm, I've no idea of which email address is associated with that amazon.com instantbird partner id :-S
16:14:58 <flo> ah, it's florian@ ib.org
16:15:22 <clokep> Figuring out the combination of emails + passwords isn't usually fun. :(
16:15:24 <flo> it just thought it wasn't that because amazon.fr sends emails several times a year, and I haven't received anything from amazom.com in a long while
16:15:56 <flo> they haven't emailed me anything since 2009!
16:16:24 <flo> ah, I've unsubscribed from there pointless newsletter apparently
16:18:07 <clokep> Yes, Amazon: one of the biggest providers of spam. ;)
16:18:47 <Mic> clokep: you can always store them in your browser (just to make sure that there is a single point of failure :P)
16:21:09 <flo> we have earned $4.76 on amazon.com
16:21:42 <flo> I think we have a little bit more (9€ maybe?) on amazon.fr
16:23:00 <Mic> :(
16:26:33 <flo> amazon.com has a minimum payment threshold of $100 (it's less for direct deposit but that option is only available in the US. We can also have amazon gift certificates, but that may not be as useful for the association)
16:27:16 <flo> for amazon.fr the minimum is 25€.
16:28:04 <flo> we will need more people to use these urls to really be able to cover our costs ;)
16:34:24 <-- MadWookiee has quit (Ping timeout)
16:34:38 <clokep> flo: There's no way to directly give money (i.e. paypal, etc.) right?
16:35:10 <flo> we could setup some
16:35:20 --> MadWookiee has joined #instantbird
16:35:42 <flo> I thought we would be doing that at the time of the 1.1 release, but that hasn't happened
16:35:53 <flo> (and nobody has noticed 1.1 anyway, so that doesn't really matter)
16:37:23 <clokep> Yes, but I have money in my paypal account I've been meaning to send towards you. :P
16:37:59 <flo> I wonder if we can pay our domain names with paypal
16:38:01 <clokep> Going out for a bit, have a good day. :)
16:49:02 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
17:04:15 <-- clokep has quit (Ping timeout)
17:13:56 --> Guido has joined #instantbird
17:23:33 --> clokep has joined #instantbird
17:23:33 * ChanServ sets mode +h clokep 
17:39:28 <-- MadWookiee has quit (Quit: Instantbird 1.1)
17:49:45 <-- gerard-majax has quit (Ping timeout)
17:53:44 --> aleth has joined #instantbird
17:56:14 --> igorko has joined #instantbird
17:58:20 --> Mic has joined #instantbird
17:58:21 * ChanServ sets mode +h Mic 
18:00:29 <Mic> Is the Instantbird-company page in Facebook 'official'? (there's also an I love Instantbird-group founded by fl o and a russian Instantbird-organisation page)
18:03:21 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
18:03:50 --> aleth has joined #instantbird
18:05:41 <flo> Mic: I don't know/remember who controls https://www.facebook.com/Instantbird
18:06:39 <flo> goulagman (a friend and former contributor) is the founder of the I love Instantbird group. And I became admin later.
18:12:00 <flo> I'm going home (I'll probably be back online later this evening to do some more XMPP hacking). Good evening. :)
18:12:02 <-- flo has quit (Quit: Instantbird 1.2a1pre)
18:18:59 <-- mmkmou has left #instantbird ()
18:21:27 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
18:39:48 --> gerard-majax has joined #instantbird
18:45:11 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
19:14:54 <-- gmoro_ has quit (Client exited)
19:26:25 --> Mnyromyr has joined #instantbird
19:55:38 --> Mic has joined #instantbird
19:55:38 * ChanServ sets mode +h Mic 
19:57:16 --> gmoro_ has joined #instantbird
20:40:26 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1021 on bug 1182.
20:40:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1182 nor, --, 1.2, nobody, NEW, "Reference to undefined property" JS warnings
20:48:51 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1022 on bug 1182.
20:48:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1182 nor, --, 1.2, nobody, NEW, "Reference to undefined property" JS warnings
20:50:06 <-- Guido has quit (Quit: Instantbird 1.1)
20:50:18 <-- aleth has quit (Quit: Instantbird 1.2a1pre)
20:55:02 <-- Mic has quit (Quit: Instantbird 1.2a1pre)
20:55:15 --> aleth has joined #instantbird
21:00:00 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
21:07:10 <aleth> JS question: How can this code possibly produce an "undefined property types[type]" warning? |for (var type in types) this.onTypeAdded(types[type]);|
21:18:32 <-- igorko has quit (Quit: Instantbird 1.1)
21:18:46 --> flo has joined #instantbird
21:18:46 * ChanServ sets mode +qo flo flo 
21:22:06 --> Tomek has joined #instantbird
21:29:44 <flo> aleth: the code in this.onTypeAdded probably changes the array in a way that confuses the for in loop
21:33:54 <aleth> flo: Hmm, onTypeAdded doesn't seem to change types[]. However, is it possible the error is ascribed to the wrong line, i.e. the error occurs in onTypeAdded  when it assumes some types[type] has properties it does not posess?
21:47:45 --> igorko has joined #instantbird
22:08:49 <-- Plop has quit (Ping timeout)
22:10:38 --> Plop has joined #instantbird
22:11:44 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1023 on bug 1182.
22:11:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1182 nor, --, 1.2, nobody, NEW, "Reference to undefined property" JS warnings
22:22:41 --> mmkmou has joined #instantbird
22:39:22 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1024 on bug 1182.
22:39:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1182 nor, --, 1.2, nobody, NEW, "Reference to undefined property" JS warnings
22:46:27 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1025 on bug 1182.
22:46:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1182 nor, --, 1.2, nobody, NEW, "Reference to undefined property" JS warnings
22:53:08 --> Mic has joined #instantbird
22:53:08 * ChanServ sets mode +h Mic 
22:55:50 <flo> aleth: any reason why you are changing the default value of disableTimerID in accounts.js?
22:57:35 <Mic> aleth: here's something that should also work and saves you two lines: http://pastebin.instantbird.com/1116
22:59:56 <-- Plop has quit (Ping timeout)
23:00:11 --> Plop has joined #instantbird
23:00:47 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1026 on bug 1182.
23:00:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1182 nor, --, 1.2, nobody, NEW, "Reference to undefined property" JS warnings
23:01:36 <Mic> I'm glad I'm not CC'ed on this bug ;)
23:02:27 <aleth> Mic: It wouldn't prevent a warning if value is not defined I think.
23:03:49 <-- Plop has quit (Ping timeout)
23:04:12 <aleth> flo: disableTimerID is set to a function by the constructor. Zero doesn't seem appropriate for a variable that carries a function somehow.
23:04:45 <aleth> But there may be subtleties I am missing as I don't know the code well.
23:05:08 <flo> "disableTimerID is set to a function" uh? where?
23:05:31 --> Plop has joined #instantbird
23:05:51 <Mic> aleth: I think it doesn't give a warning.
23:06:11 <aleth> doesn't setTimeout return a function? (have to admit I didn't check)
23:06:34 <flo> https://developer.mozilla.org/en/DOM/window.setTimeout "timeoutID is the ID of the timeout, which can be used later with window.clearTimeout."
23:07:22 <aleth> Right, I misremembered. Better set it back to zero then.
23:07:24 <flo> typeof (window.setTimeout("alert('test')", 1));
23:07:26 <flo> -> number
23:08:02 <aleth> Sorry...
23:08:42 <flo> it's ok :)
23:09:39 <aleth> I was sure I'd used setTimeout somewhere ;)
23:11:22 <Mic> I have strict warnings enabled and this here outputs *bling* and doesn't give a warning when used on the error console:
23:11:25 <Mic> function test() { var obj = {}; return obj.xyz || "*bling*"; } test()
23:13:54 <aleth> flo: Do you know if it's OK to call clearInterval(0) and clearTimeout(0)? That would save some if clauses. (It's not listed in the documentation though).
23:14:09 <flo> aleth: it's ok. It just does nothing.
23:15:46 <flo> Mic: is this a bug that should be filed?
23:16:36 <flo> or is || allowed to silence out that warning?
23:16:43 <aleth> Mic: You're right, but I'm really surprised at that.
23:17:12 <Mic> I think it's to be expected, let me check
23:17:22 <aleth> (ill-defined) || true == true ?
23:17:40 <aleth> I suppose...
23:18:03 <flo> aleth: the value isn't ill-defined. Accessing an undefined property returns the |undefined| value, which evaluates to false and so is replaced by the right part of ||
23:18:36 <aleth> But undefined values are supposed to throw a warning I thought
23:18:40 <flo> the question is: is the || operator supposed to include a "property in object" check before testing the value it replaces
23:19:14 <flo> that is, is the || operator checking for the existence of the value, and not trying to access it, or is it accessing it (which should cause a warning)
23:23:18 --> clokep has joined #instantbird
23:23:18 * ChanServ sets mode +h clokep 
23:30:06 <Mic> hmm... I guess I won't be able to answer this question tonight ;)
23:38:58 <aleth> flo: Is it possible that properties of an object are deleted (not explicitly - that would be obvious) before the unload method is called?
23:39:14 <flo> which unload method?
23:40:07 <aleth> In accounts.js, this._connectedLabelInterval is undefined in unload despite now being properly defined initially, and set by load()
23:41:02 <-- clokep has quit (Ping timeout)
23:41:44 --> clokep has joined #instantbird
23:41:44 * ChanServ sets mode +h clokep 
23:43:47 * Mic tried to read the ECMA script specs to see what || is supposed to do but it's either too late already or ways beyond my reading level in general;)
23:44:24 <clokep> What the ECMA script spec says and what Gecko does might not be the same either. ;)
23:45:24 --> hunsly has joined #instantbird
23:46:40 <-- clokep has quit (Quit: Instantbird 1.2a1pre)
23:49:43 <flo> aleth: that's strange. Are you sure there isn't a typo somewhere?
23:52:16 <aleth> I can't spot any - http://pastebin.instantbird.com/1117
23:52:49 <aleth> What's more, there are only two references to _connectedLabelInterval in all of IB according to LXR
23:52:58 <aleth> (in load and unload)