#instantbird log on 09 13 2011

All times are UTC.

00:05:56 --> clokep has joined #instantbird
00:05:56 * ChanServ sets mode +h clokep 
00:10:53 --> ecaron has joined #instantbird
00:19:19 <clokep> Hello.
00:34:50 <-- Mook_as has quit (Quit: ChatZilla 0.9.87-rdmsoft [XULRunner 1.9.2.13/20101203074205])
00:35:37 <-- hicham has quit (Client exited)
00:51:01 <instantbot> clokep@gmail.com added attachment 813 to bug 1023.
00:51:02 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 813 on bug 1023.
00:51:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1023 enh, --, ---, clokep, ASSI, Tooltips for Twitter participants
01:00:16 <-- ecaron has left #instantbird ()
01:42:47 <instantbot> clokep@gmail.com set the Resolution field on bug 567 to WORKSFORME.
01:42:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=567 maj, --, ---, nobody, RESO WORKSFORME, Crash [@ msim_status_text ] in the myspace protocol plugin.
01:59:23 <-- clokep has left #instantbird ()
03:05:48 --> skeledrew has joined #instantbird
03:48:56 --> waynenguyen has joined #instantbird
04:39:14 --> Mook has joined #instantbird
05:18:13 --> hunsly has joined #instantbird
05:33:23 <-- EionRobb has quit (Quit: Leaving.)
05:40:04 <-- waynenguyen has quit (Ping timeout)
06:06:05 --> waynenguyen has joined #instantbird
06:37:35 * MattATobin is now known as BinaryOutcast
06:49:00 <-- Mook has quit (Quit: ChatZilla 0.9.87-rdmsoft [XULRunner 6.0/20110811165603])
06:52:00 <-- waynenguyen has quit (Ping timeout)
07:29:54 --> Mad_Maks has joined #instantbird
07:39:13 <-- Mad_Maks has quit (Ping timeout)
07:41:40 --> mistraven has joined #instantbird
07:42:37 <-- mistraven has left #instantbird ()
07:46:28 --> Mad_Maks has joined #instantbird
08:15:07 --> myk has joined #instantbird
08:27:39 --> flo has joined #instantbird
08:27:39 * ChanServ sets mode +qo flo flo 
08:27:57 <flo> hello :)
08:31:57 <-- Mad_Maks has left #instantbird ()
08:34:29 --> Mad_Maks has joined #instantbird
08:35:18 <-- Mad_Maks has quit (Client exited)
08:42:14 --> Mic has joined #instantbird
08:42:14 * ChanServ sets mode +h Mic 
08:58:07 <-- gerard-majax has quit (Ping timeout)
08:58:50 <-- myk has quit (Ping timeout)
09:04:11 <-- Mic has quit (Ping timeout)
09:18:59 --> aleth has joined #instantbird
09:21:20 <aleth> hello :)
09:28:02 --> gerard-majax has joined #instantbird
10:00:23 --> waynenguyen has joined #instantbird
10:02:15 <-- waynenguyen has quit (Ping timeout)
10:02:50 --> waynenguyen has joined #instantbird
10:08:35 --> clokep has joined #instantbird
10:08:35 * ChanServ sets mode +h clokep 
10:16:35 <clokep> Good morning.
10:28:38 --> mmkmou1 has joined #instantbird
10:36:42 --> Mad_Maks has joined #instantbird
10:55:34 <-- clokep has left #instantbird ()
10:57:30 <-- Sarafina has quit (Ping timeout)
11:04:46 <-- Mad_Maks has quit (Client exited)
11:08:53 --> Sarafina has joined #instantbird
11:10:25 <instantbot> florian@instantbird.org added attachment 814 to bug 984.
11:10:26 <instantbot> florian@instantbird.org requested review from the wind for attachment 814 on bug 984.
11:10:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=984 nor, --, ---, nobody, NEW, Joining chat should unhide conversation if already existing
11:29:09 --> hicham has joined #instantbird
11:43:31 --> clokep_work has joined #instantbird
11:43:31 * ChanServ sets mode +h clokep_work 
11:54:34 <-- hicham has quit (Ping timeout)
11:56:10 --> hicham has joined #instantbird
12:00:19 <clokep_work> flo: SO the issue with that join chat dialogue is you can't get the name of the conversation w/o requesting that libpurple actually make the conversation?
12:01:16 <flo> no
12:01:25 <flo> I can't get it, even if I request that libpurple make the conversation
12:01:34 <flo> I just can't get it, I have to guess
12:01:41 <flo> + there's no guarantee that the name is unique :(
12:03:17 <clokep_work> :-/ Alright.
12:11:35 <clokep_work> We also have a bug about removing the protocol specific stuff in there, so maybe my suggestion isn't worth it.
12:11:42 <clokep_work> (Or could go into that bug.)
12:12:37 --> jb has joined #instantbird
12:22:44 --> gmoro_ has joined #instantbird
12:23:57 --> devfil has joined #instantbird
12:31:32 <-- hicham has quit (Ping timeout)
12:31:58 <-- gmoro_ has quit (Ping timeout)
12:32:55 --> hicham has joined #instantbird
12:46:37 <-- hicham has quit (Ping timeout)
12:46:46 --> gmoro_ has joined #instantbird
12:47:42 --> hicham has joined #instantbird
12:50:26 --> ecaron has joined #instantbird
12:51:30 <flo> clokep_work: if we detect the base prpl id, then it will also detect facebook.
12:52:09 <flo> probably not wanted, but that may not hurt (as we are don't list the facebook accounts which can't join chats in the join chat dialog in the first place :))
12:53:56 <-- gmoro_ has quit (Ping timeout)
12:54:10 --> gmoro_ has joined #instantbird
12:56:51 <flo> ahah, purpleIOverrideProtocol is a dead interface, nothing implements it. (http://lxr.instantbird.org/instantbird/search?string=purpleIOverrideProtocol)
13:16:13 <clokep_work> flo: Yes, I know it would also find Facebook and other stuff, but those should have in them that they don't support joining chats, so it's a null point.
13:16:23 <clokep_work> I didn't realize that was dead. :(
13:17:02 <clokep_work> r+ then and I'll comment on the other bug saying that the way we do that sucks. ;)
13:25:03 <-- devfil has quit (Client exited)
13:25:34 <instantbot> florian@instantbird.org added attachment 815 to bug 1020.
13:25:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1020 nor, --, ---, nobody, NEW, IRC sends unrecognized commands to active conversation
13:34:42 * clokep_work wonders if IRC supports slashCommandsNative.
13:39:35 <flo> clokep_work: http://lxr.instantbird.org/instantbird/search?string=SLASH_COMMANDS_NATIVE
13:39:42 <flo> only IRC and XMPP do apparently
14:11:18 <-- waynenguyen has quit (Ping timeout)
14:11:26 --> waynenguyen has joined #instantbird
14:16:01 <-- ecaron has quit (Ping timeout)
14:17:20 --> Andrey has joined #instantbird
14:18:26 --> myk has joined #instantbird
14:20:28 <-- myk has quit (Quit: Instantbird 1.0)
14:25:03 <clokep_work> Ah, I see.
14:29:07 --> Mad_Maks has joined #instantbird
14:36:44 <clokep_work> flo: It should flash the taskbar icon as is (although we might have a setting to disable that).
14:37:19 <flo> as the time I developed the add-on it didn't work.
14:38:04 <flo> *at
14:38:31 <clokep_work> Oh? I'm pretty sure I get notified via the taskbar. I'll check later.
14:38:38 * clokep_work will add a word like "the" to it. ;)
14:39:40 <flo> aaah, no!
14:39:42 <flo> that worked
14:39:58 <flo> the bug was that the message wasn't counted for the unread count displayed in the dock
14:41:12 --> devfil has joined #instantbird
14:43:23 <clokep_work> Ah, strange.
14:44:00 <flo> well, not really :). The add-on hacks a field of the message by adding a wrapper around the message object before it is displayed
14:44:28 <flo> the unread counter for the dock is created directly based on the message object received by the new-message notification
14:50:14 <clokep_work> That's unfortunate. :(
14:50:21 <clokep_work> You could file that as a bug now. ;)
14:54:24 <-- jb has quit (Ping timeout)
14:55:12 --> ecaron has joined #instantbird
14:58:45 --> mikk_s has joined #instantbird
15:00:24 <-- ecaron has quit (Ping timeout)
15:00:33 --> ecaron has joined #instantbird
15:01:27 <-- mikk_s has left #instantbird ()
15:06:40 <clokep_work> Just wanted to say there's a couple bugs without specifying anyone's review in particular: https://bugzilla.instantbird.org/request.cgi?action=queue&requester=&product=&type=all&requestee=&component=&group=type
15:08:43 <instantbot> clokep@gmail.com granted review for attachment 814 on bug 984.
15:08:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=984 nor, --, ---, florian, ASSI, Joining chat should unhide conversation if already existing
15:14:29 <instantbot> New Instantbird (UI) bug 1029 filed by michal.stanke@mikk.cz.
15:14:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1029 nor, --, ---, nobody, UNCO, Add support fot XFire protocol
15:19:52 --> Mic has joined #instantbird
15:19:52 * ChanServ sets mode +h Mic 
15:21:47 <clokep_work> I think EionRobb has an XFire plug-in...
15:22:19 <flo> there's http://gfireproject.org/
15:29:16 <clokep_work> Yeah that's the one I was thinking of.
15:33:04 --> jb has joined #instantbird
15:33:14 <-- Mic has quit (Quit: Instantbird 1.1a1pre)
15:35:40 --> igorko has joined #instantbird
15:47:32 <-- hicham has quit (Ping timeout)
15:58:05 <-- jb has quit (Ping timeout)
16:07:01 <-- mmkmou1 has quit (Ping timeout)
16:23:21 --> mmkmou has joined #instantbird
16:28:01 <clokep_work> I think I scared people away w/ my long blog post. :P No comments surprisingly.
16:38:26 <flo> you missed Usul's "Can't wait for 1.1 to get out <link to the post>" tweet?
16:38:38 <flo> people don't read, they need pictures ;)
16:39:09 <clokep_work> I don't think I follow Usul on Twitter actually.
16:39:16 <flo> I don't either
16:39:27 <clokep_work> I need to make a second Twitter account...allt he Mozilla stuff is making me miss things my friends actually say. ;)
16:39:35 <flo> but I track instantbird, and twitter matches it even when the link needs to be expanded to match!
16:39:53 <clokep_work> Ah, that's nifty. :)
16:42:09 --> Mook_as has joined #instantbird
16:42:56 <-- Mad_Maks has left #instantbird ()
16:43:06 <clokep_work> I really wish I could automatically translate tweets though...
16:43:22 <flo> I'm surprised nobody has done that add-on yet
16:43:34 <flo> it doesn't seem complicated, and is probably quite rewarding
16:43:39 <clokep_work> I didn't feel like dealing with web services to translate. :-X
16:44:16 <flo> I didn't mean you ;)
16:44:33 <clokep_work> Hahah, yes. I did think about it though in the past! And just asked for it. :)
16:44:49 <flo> wasn't there a wish page?
16:46:47 <-- gerard-majax has quit (Ping timeout)
16:47:33 <-- hunsly has quit (Ping timeout)
16:48:11 <-- aleth has quit (Quit: Instantbird 1.1a1pre)
16:49:16 <-- gmoro_ has quit (Ping timeout)
16:49:27 <clokep_work> Yes I'm adding it now.
16:50:57 <-- Andrey has quit (Quit: )
17:02:25 --> mistraven has joined #instantbird
17:02:28 <-- mistraven has left #instantbird ()
17:05:40 --> gmoro_ has joined #instantbird
17:15:53 <-- ecaron has left #instantbird ()
17:18:58 --> gerard-majax has joined #instantbird
17:26:23 <-- gerard-majax has quit (Ping timeout)
17:36:12 <instantbot> florian@instantbird.org set the Resolution field on bug 984 to FIXED.
17:36:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=984 nor, --, 1.1a1, florian, RESO FIXED, Joining chat should unhide conversation if already existing
17:37:41 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/6588131c0d0d - Florian Quèze - Add a very basic xpcshell test checking that purplexpcom can be initialized.
17:37:42 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/bad88663ae78 - Florian Quèze - Remove obsolete purpleIOverrideProtocol interface.
17:37:43 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/e323e76ce887 - Florian Quèze - Bug 984 - Joining chat should unhide conversation if already existing, r=clokep.
17:38:25 --> gerard-majax has joined #instantbird
17:39:25 <-- Suiseiseki has quit (Ping timeout)
17:41:25 <flo> clokep_work: is the list of fields displayed in the twitter tooltip ready for review, or do you just want a code review at this point?
17:54:46 <instantbot> florian@instantbird.org denied review for attachment 813 on bug 1023.
17:54:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1023 enh, --, ---, clokep, ASSI, Tooltips for Twitter participants
18:05:13 <instantbot> florian@instantbird.org granted review for attachment 811 on bug 1026.
18:05:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1026 nor, --, ---, nobody, NEW, Email addresses are filtered out of conversations content
18:08:14 <-- flo has quit (Quit: Instantbird 1.1a1pre)
18:24:48 <-- waynenguyen has quit (Ping timeout)
18:34:28 --> mistraven has joined #instantbird
18:34:50 <clokep_work> flo: It's "ready for review" in the sense that I think we'll want AT LEAST those fields.
18:35:00 <clokep_work> I want to look over all the fields again though since I only quickly checked them out.
18:35:12 --> harlock has joined #instantbird
18:36:38 <clokep_work> I was trying to include pretty much the basic information when you looked at your home timeline on Twitter.com btw.
18:41:08 --> aleth has joined #instantbird
18:42:03 <-- mmkmou has left #instantbird ()
18:44:52 <clokep_work> If anyone else has comments on what to include, please feel free. :)
18:58:45 --> linuxwizard has joined #instantbird
19:08:26 <-- chrisccoulson has quit (Ping timeout)
19:10:16 --> chrisccoulson_ has joined #instantbird
19:10:54 <-- mistraven has left #instantbird ()
19:12:53 * chrisccoulson_ is now known as chrisccoulson
19:20:11 --> flo has joined #instantbird
19:20:11 * ChanServ sets mode +qo flo flo 
19:23:13 --> hunsly has joined #instantbird
19:26:37 * flo wonders how big a patch needs to be to deserve to be pushed with one's real name :-D.
19:30:14 <clokep_work> Bigger. ;)
19:40:49 <aleth> maybe a little more than adding a word where I didn't even either diagnose the problem or locate it in the code :)
19:42:50 <-- igorko has quit (Quit: Instantbird 1.1a1pre)
19:43:48 <flo> aleth: if you are interested in producing bigger code contributions, we can probably find something where you could add a bit more than a word ;)
19:44:31 <clokep_work> Besides, Mic has had 1 character patches attributed to him. ;)
19:45:02 <flo> clokep_work: was it before or after he gave us his real name? ;)
19:45:27 <clokep_work> I think it was after. I linked them on ohloh anyway...but then he changed it to not his real name one. ;)
19:45:48 <flo> it?
19:46:33 <clokep_work> "it" to be his linked accounts on there.
19:46:33 <devfil> flo: could give me instruction about how to build instantbird? I'm working on instantbird support
19:46:36 <clokep_work> So I don't think I can check anymore.
19:46:44 <clokep_work> devfil: What OS? ;)
19:46:51 <devfil> ubuntu oneiric
19:47:26 <flo> clokep_work: if you can find the commit message, then you can look for the changeset on hg :)
19:47:31 <flo> or if you find the bug :)
19:48:43 <flo> not a very productive occupation though
19:49:32 <flo> Am I the only one thinking "Number You Follow" is likely difficult to understand?
19:49:52 <devfil> flo: I'll test msn-pecan building it as static lib for the moment
19:50:26 <devfil> then we can use .so/.dll and .xpi files :)
19:50:43 <flo> I don't think you meant "static" in that sentence
19:50:58 <flo> oh well, I don't know :-S
19:51:19 <flo> devfil: building a .so is what will happen by default if you don't explicitly request that the prpl is statically linked
19:51:19 <devfil> flo: yes, I'll change libpurple source in instantbird
19:51:30 <devfil> just to test msn-pecan
19:51:53 <devfil> when I'll fix and set all def I'll build it as dynamic lib
19:52:54 <devfil> flo: can I test msn-pecan without have to build instantbird source?
19:53:33 <devfil> is there a folder where I can copy the .so file?
19:53:35 <flo> not easily
19:54:13 <devfil> ok, then I'll build it as static lib in instantbird source :)
19:55:03 * flo wonders if we will find someone motivated by bug 979
19:55:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=979 nor, --, ---, nobody, NEW, Fix look for "Hidden conversations" /"Contacts" contact list sections and their headers
19:56:41 <clokep_work> I thought about it...and then never got around to finding the code. ;)
19:56:56 <flo> finding the code?
19:58:36 <clokep_work> Just where the styles are, etc.
19:58:52 <clokep_work> I'm sure I can easily, I just never got around to actually looking for it / got distracted by something else.
19:58:57 <flo> you don't have a working DOM Inspector?
19:59:35 <clokep_work> I don't remember if I do or not.
19:59:57 <flo> if you have a debug build, you certainly do
20:00:16 <clokep_work> I've never done a debug build, Windows takes long enough already. ;)
20:00:38 <flo> ah :-/
20:12:51 <aleth> flo: thanks, I do hope to do that if I can when I have a bit more time :)
20:13:20 <flo> np
20:24:49 <flo> http://pastebin.instantbird.com/946 is this all we need to fix bug 1000?
20:24:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1000 enh, --, ---, nobody, NEW, Minimize user interruptions
20:27:25 <flo> hmm, the getAttention call should also request authorization
20:27:56 <flo> and I think the add requests will wait, as we currently have no way to delay them :-/
20:29:14 <clokep_work> That's too long to read right now. :P I'll look at it later.
20:30:19 <flo> that's 20 lines of code :-D
20:36:33 <clokep_work> Looks OK.
20:36:48 <clokep_work> I might have used .some() on the array, but this probably is more efficient.
20:38:12 <clokep_work> And the license header has the wrong date in it (2009 not 2011)
20:39:33 --> myk has joined #instantbird
20:40:53 --> EionRobb has joined #instantbird
20:43:18 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client)
20:46:41 <flo> I would have used some if there was a single argument
20:49:57 <flo> heh, the whole function can be replaced with     this._listeners.every(function (l) l(aReason, aSubject, aType))
20:52:16 <aleth> what does the | do there?
20:52:41 <aleth> have not seen that syntax before
20:55:52 <-- harlock has quit (Quit: Baibai)
20:56:38 <flo> it's a small L
20:57:38 <flo> aleth: https://developer.mozilla.org/en/New_in_JavaScript_1.8#Expression_closures_%28Merge_into_own_page.2Fsection%29
20:58:40 <aleth> flo: thanks!
20:59:32 <flo> you are welcome
21:03:17 <-- myk has quit (Ping timeout)
21:15:35 <Mook_as> flo: for bug 1000, that accounts window is annoying me when I disconnect/reconnect
21:15:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1000 enh, --, ---, nobody, NEW, Minimize user interruptions
21:16:28 <flo> Mook_as: can you detail a bit more what goes wrong with it please? :)
21:16:48 <Mook_as> flo: sure. Step 0: only have the contacts window open.
21:17:03 <Mook_as> Step 1: Get disconnected (for testing, unplug your network or something), until ib notices
21:17:11 <Mook_as> Step 2: Plug it back in.
21:17:23 <Mook_as> Expected results: ib reconnects without any new windows opening
21:17:34 <Mook_as> Actual results: The accounts window opens
21:18:11 <flo> does it open at after step 1 or step 2?
21:18:36 <Mook_as> umm... let me try.
21:19:12 <Mook_as> After step 1, I think? Still checking... it's hard to do that without actually unplugging cables ;)
21:19:57 <flo> I think it's "expected" that the dialog is shown when no account is connected, so that the user has an idea of what to do/click to change the situation
21:20:14 <flo> we could probably avoid it when we know the network is down though
21:20:38 <Mook_as> yeah, that might work
21:20:58 <Mook_as> for me, it's just that... there's nothing I should _do_ to resolve this, other than "close that annoying window that just popped up"
21:21:11 <Mook_as> (since it reconnects automatically anyway...)
21:21:41 <flo> mind filing a bug?
21:22:05 <Mook_as> I'll try to remind myself once I get home :)
21:22:06 <flo> in bug 1000 I'm more targeting the interruptions that come from the IM networks than from UI bugs
21:22:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1000 enh, --, ---, nobody, NEW, Minimize user interruptions
21:22:12 * Mook_as doesn't have ib bugzilla credentials here
21:33:30 --> clokep has joined #instantbird
21:33:30 * ChanServ sets mode +h clokep 
21:42:16 <clokep> Ah, I like the every solution! :)
21:42:32 <flo> :)
21:42:34 <clokep> Might want a description somewhere that a listener is supposed to return true to false.
21:42:40 <clokep> *return false to cancel
21:42:41 <flo> I'm writing a new nickservkiller add-on
21:42:45 <clokep> Or maybe it was true...
21:42:48 <clokep> Ah, nice. :)
21:42:52 <clokep> Will it kill sounds too? ;)
21:42:56 <flo> sure
21:51:23 <flo> https://developer.mozilla.org/en/Extensions/Inline_Options seems nice :)
21:51:45 <flo> we aren't on mozilla7 yet though :-/
21:53:28 <aleth> It was also sorely needed in FF because the Tools menu where add-ons used to put their Prefs is no longer there in the FF button version of the menu :)
21:53:49 <-- gmoro_ has quit (Quit: Leaving)
21:54:00 --> myk has joined #instantbird
21:57:37 <clokep> Yes, inline options are aweosme. :)
22:01:34 <-- flo has quit (Quit: Instantbird 1.1a1pre)
22:01:39 --> flo has joined #instantbird
22:01:39 * ChanServ sets mode +qo flo flo 
22:04:22 <clokep> Anyone have opinions about what Twitter stuff to show?
22:07:27 <flo> clokep: what does "Listed Count" mean?
22:07:46 <clokep> Number of lists the user is listed on.
22:08:28 <flo> is "user" the correct word to refer to someone with a twitter account?
22:08:38 <clokep> Idk, what else would you call them?
22:08:40 <flo> what are the words used on the official twitter UI for all these info?
22:08:40 <clokep> Tweeter? :P
22:09:13 <flo> isn't Protects Tweets a boolean?
22:09:33 <clokep> Yes, but apparently I didn't put that in the code. :)
22:10:07 <flo> some of your localization notes are very vague
22:10:30 <flo> "These are the protocol information that appear in the tooltip." protocol information? uh. "the tooltip" uh! which one? :-P
22:10:58 <flo> (I don't need these answers ;) But localizers may to a better job if they do)
22:11:06 <-- myk has quit (Ping timeout)
22:11:39 <flo> also, if you explain something with the same words, it doesn't explain at all for someone who doesn't understand (or find ambiguous) one of the words used.
22:12:33 <flo> like "Protects Tweets", "whether the user's tweets are protected." If the localizers doesn't know what "protected" means in a twitter context well... you get a random translation
22:13:57 <clokep> Yes. :-/
22:14:44 <flo> "whether the user's tweets are publicly readable or protected"?
22:15:02 <clokep> Yeah I had just changed it to "publicly visible"
22:15:14 <flo> :)
22:16:26 <clokep> Let me make sure it still works. ;)
22:18:16 <clokep> Seems OK.
22:18:39 <clokep> Should I upload a new patch or you have more comments?
22:20:55 <flo> have you kept "Number You Follow"? (it means nothing to me :-S)
22:21:48 <instantbot> clokep@gmail.com added attachment 816 to bug 1023.
22:21:49 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 816 on bug 1023.
22:21:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1023 enh, --, ---, clokep, ASSI, Tooltips for Twitter participants
22:21:52 <clokep> It's the number of people you follow.
22:22:19 <clokep> I don't know how else to descibre that. :-/
22:22:23 <clokep> *describe
22:24:03 <flo> is it what facebook calls "mutual friends"?
22:24:58 --> ironhead has joined #instantbird
22:25:11 <clokep> No.
22:25:18 <clokep> People follow you, you follow them.
22:25:36 <clokep> Twitter doesn't require anything to be "mutual".
22:26:11 <clokep> (I.e. @bar can follow @foo, but that doesn't imply @foo follows @bar)
22:26:28 <flo> then how is it related to the hovered nick that caused the tooltip to be shown?
22:26:32 <clokep> And then @bar would follow 1 person, and @foo would have 1 follower.
22:26:45 <clokep> It's the number of people that follow the hovered nick.
22:27:01 <flo> then what's the "you" doing in that label?
22:27:12 <clokep> Cause I messed up. :)
22:27:37 <clokep> Bah wait.
22:27:43 <clokep> followers_count is the number of followers you have.
22:27:55 <clokep> I'm not positive what friends_count is.
22:28:48 <clokep> Ah it seems to be the number of people that that users follows.
22:28:51 <clokep> That's what I was trying to say.
22:29:10 <flo> followers_count is probably the number of people following USER. friends_count the number of people USER follows.
22:30:24 <clokep> Yes, I agree.
22:30:47 <flo> bah, the twitter UI is displayed in French for me :(
22:30:51 <clokep> I have the descriptions as:
22:30:53 <aleth> followers/friends = celebrity ?
22:31:14 <clokep> They can be anyone.
22:31:16 <aleth> could plot it on a log scale
22:32:17 <clokep> What?
22:32:26 <clokep> flo: Does this help? http://imgur.com/edVlQ
22:32:35 <aleth> the celebrity quotient ;) 
22:32:44 <aleth> (not being serious here)
22:32:48 <clokep> Ah OK.
22:33:30 * flo thinks we could use the exact same words, to avoid *adding* confusing above what's already there
22:33:30 <aleth> but i guess thats what they are used for in practice
22:33:34 <flo> *confusion
22:33:46 * flo wonders why libpurple crashes when his add-on closes a conversation
22:34:00 <flo> clokep: yes, the screenshot is what I was trying to get :)
22:34:28 <devfil> flo: lol, I wonder why in order to fix an error on msn login they added a timeout -.-'
22:34:31 <clokep> So just do "Tweets", "Following" "Followers", "Listed" and that's it.
22:34:52 <flo> devfil: who did that? where? :)
22:35:42 <flo> clokep: yeah. And I think the localization note could suggest looking at the official translation on the website
22:36:08 <flo> clokep: you have a problem with the word "following" which you already use for another meaning though :-/
22:36:35 <clokep> flo: They use it twice in their UI too. :(
22:36:54 <clokep> Is it really necessary though?
22:37:16 <clokep> I can just remove it. ;)
22:37:18 <devfil> flo: http://developer.pidgin.im/viewmtn/revision/info/6fd13fcd41c95794bed286994ba8dc779da0aa01
22:37:31 <flo> it may be useful to decide we want to start following that user
22:37:31 <devfil> I'm trying to fix the same issue, but that stuff looks ridiculous
22:38:31 <clokep> True. :-/ Idk what to call it then.
22:38:37 <flo> devfil: well, as long as they don't forget to remove that timer when they are done with it, I don't mind :)
22:43:39 <flo> so I'm crashing at http://lxr.instantbird.org/instantbird/source/purple/libpurple/account.c#2245
22:47:02 <flo> apparently it dislike that I close the conversation during the write_conv UI op. Receiving a message isn't supposed to close the conversation. Well, ok, let's add a timer there ;).
22:49:39 <flo> clokep: we still haven't added the executeSoon function?
22:50:16 --> Suiseiseki has joined #instantbird
22:54:52 <flo> clokep: http://pastebin.instantbird.com/947
22:55:38 <clokep> Yes, we still hadn't added that.'
22:56:06 <flo> well, do you want us to add it like... now? ;)
22:56:16 <clokep> One second.
22:56:19 <clokep> Page is loading slowly...
22:56:19 <clokep> '
22:57:19 <clokep> flo: There's a Services.tm we should use.
22:58:06 <clokep> r+ with that change.
22:58:50 <flo> do we keep the tm variable?
22:59:10 <clokep> I wouldn't, is there any reason to?
22:59:21 <flo> it's called a second time for tm.DISPATCH_NORMAL
22:59:22 <clokep> Ah, I see.
22:59:25 <clokep> To avoid it twice.
22:59:35 <clokep> Then yes, I'd keep it.
22:59:43 <flo> but   Services.tm.mainThread.dispatch(aFunction, Services.tm.DISPATCH_NORMAL);
22:59:44 <flo>  is only 74 chars :-D
22:59:46 <clokep> Unless maybe it fits on one line. :)
22:59:51 <clokep> Ah then go with that.
23:00:46 <flo> so, know how can I test that it actually work? :-)
23:01:36 <clokep> Write a unit test? :P
23:03:03 <flo> I already pushed one today, that's enough for the day :-P
23:06:26 <clokep> Hah. I don't know how then.
23:07:16 <flo> I added two dump calls
23:07:26 <flo> in imContacts.js
23:07:37 <flo> it seems to behave as expected
23:07:56 <flo> we have probably several setTimeout of 0ms that could/should be replaced
23:08:25 <clokep> I'm sure we do.
23:08:35 <clokep> Maybe aleth would like that do that? ;)
23:09:01 <clokep> Lots of 3 line fixes! Hah. Although maybe those aren't big enough for a name either!
23:12:08 <devfil> flo: a timeout is not the right way to fix that issue
23:12:24 <flo> that's why I added an executeSoon method instead ;)
23:12:56 <flo> clokep: a massive trivial change would be to remove the now optional last parameter of addEventListener calls ;)
23:13:08 <clokep> Is it optional now? :-D
23:13:15 <flo> yes
23:13:23 <clokep> Did you do that? ;)
23:13:28 <flo> but addObserver's last parameter isn't, and I'm always confusing the two :(
23:13:54 <clokep> I'll file bugs on them in a few minutes so we don't forget...
23:15:02 <flo> I haven't found yet an efficient workflow for restartless add-on development :-/
23:16:15 <clokep> Does the normal work flow not really work anymore? Can't you just restart every change?
23:17:16 <flo> I used to put my stuff in the chrome folder of the application with symlinks and just restart for each change
23:17:33 <flo> can restartless add-ons be tested without putting the bootstrap.js file in a xpi file?
23:18:40 <clokep> Yes.
23:18:45 <clokep> Just put it in the folder.
23:21:19 <instantbot> New Instantbird (UI) bug 1030 filed by clokep@gmail.com.
23:21:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1030 tri, --, ---, nobody, NEW, Replace appropriate setTimeout calls with executeSoon calls
23:23:52 <instantbot> New Instantbird (UI) bug 1031 filed by clokep@gmail.com.
23:23:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1031 tri, --, ---, nobody, NEW, Remove the optional last parameter from addEventListener calls
23:25:01 <flo> my nickservkill add-on: http://pastebin.instantbird.com/948
23:25:03 <clokep> Bah I hate getting stuck on UI wording like this Twitter bug.
23:26:03 <flo> just attach what you have an move on to something more interesting?
23:26:47 <clokep> I have two things that say "Following" right now! :P
23:26:49 <flo> I'll try it tomorrow before pushing it, and if there are labels I don't like I'll try to suggest replacements
23:27:13 <flo> "Currently followed"?
23:27:32 <clokep> Works (or at least makes it different...). :)
23:27:54 <flo> yeah, it's ugly too, but whatever...
23:28:30 <instantbot> clokep@gmail.com added attachment 817 to bug 1023.
23:28:31 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 816 on bug 1023.
23:28:32 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 817 on bug 1023.
23:28:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1023 enh, --, ---, clokep, ASSI, Tooltips for Twitter participants
23:28:45 <clokep> So what's more interesting...? ;)
23:29:48 <flo> what's the status of bug 832?
23:29:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=832 enh, --, ---, clokep, ASSI, Differentiate commands that work only in MUCs for /help
23:30:09 <clokep> The status is I'm useless when it comes to libpurple...:-/
23:30:15 <clokep> I have  (had?) a partial patch...
23:30:21 <clokep> One second.
23:31:26 <clokep> I had a partial patch.
23:31:49 <clokep> I don't anymore.
23:32:58 <EionRobb> would you just expose the MUC-only flag, or would you just expose all flags?
23:40:41 <flo> clokep: maybe you can find some nice twitter bug then? :)
23:40:56 * clokep is looking at bug 1020.
23:40:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1020 nor, --, ---, nobody, NEW, IRC sends unrecognized commands to active conversation
23:41:12 <flo> ah yeah, you can finish that
23:42:04 <clokep> Yeah...if I can figure it out haha.
23:43:33 <flo> the twitter bug I had in mind was adding "Follow <user>" "Stop following <user>" in tweet's context menu.
23:43:56 <clokep> The Twitter bug I had in mind was bug 1022. ;)
23:43:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1022 nor, --, ---, nobody, NEW, Twitter RT display/RTs are cut off by character limit
23:44:04 <clokep> If it handles slash commands, do we just feed it into the regular send command?
23:44:29 <flo> I don't understand the question
23:45:21 <clokep> "Indicates that slash commands are native to this protocol. Used as a hint that unknown commands should not be sent as messages."
23:45:55 <clokep> Does that mean that the flag is set and slash commands are native we DO send the command to the server anyway?
23:47:56 <clokep> My point being I don't understand that comment. :-/
23:49:43 <flo> if the flag is set, we should display an error system message instead of sending a message starting with /, except if there's /say before it
23:50:01 <clokep> I found the expected behavior: http://lxr.instantbird.org/pidgin2.6.3/source/pidgin/gtkconv.c#479 ;)
23:54:44 <clokep> Do I need to add a .properties file and a string bundle? You can't programmatically pull out of a dtd right?
23:56:54 <flo> yes
23:57:06 <flo> except if you can find a nearby bundle
23:57:39 <flo> if you are in conversation.xml, there's already this.bundle
23:57:52 <flo> probably going to instantbird.properties
23:58:36 <flo> so my patch for bug 1000 seemed acceptable? :)
23:58:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1000 enh, --, ---, nobody, NEW, Minimize user interruptions
23:58:50 <flo> I'm wondering if I should land it now to benefit from nickservkiller tomorrow :-D
23:59:25 <clokep> Yes, it seemed good.
23:59:45 <flo> I fixed a few details after the first pastebin