All times are UTC.
00:00:31 <clokep> I'll read it now. One sec 00:01:07 <clokep> OK. I'll check out those links. 00:01:13 <clokep> I didn't realize it was serialized. 00:02:24 <clokep> Hmm....maybe it shold be a function handle instead of just a hard coded name? 00:02:47 <flo> isn't this what I proposed? 00:02:52 <clokep> I think so. :) 00:03:15 <clokep> The IRC one is a silly example then cause it's so simple. 00:03:16 <clokep> But oh well. 00:03:38 --> tymerkaev_away has joined #instantbird 00:03:49 <flo> I linked to IRC to show your code would work for this case 00:04:01 <clokep> Yup. 00:06:59 <-- tymerkaev_away has quit (Ping timeout) 00:07:47 <clokep> flo: Something like this I think: http://pastebin.instantbird.com/562 00:09:38 <flo> the string as the value of "this"? :-S 00:10:24 <clokep> Oops. 00:10:34 <clokep> Maybe http://pastebin.instantbird.com/563 instead? ;) 00:10:52 <clokep> (Just removed the call) 00:11:40 <flo> add a "this." ;) 00:11:52 <flo> and I still don't fully understand 00:12:49 <flo> either defaultChatNameField is a function that parses aDefaultChatName and returns an object with a few field. Then you use these fields and their values to override some values that were the default. (this is what I proposed in the bug) 00:13:18 <flo> the second solution is to give defaultFieldValues as a parameter to the function and let it modify the values directly. 00:13:26 <flo> with the first solution you don't need the second parameter 00:13:27 <clokep> flo: I don't see that anywhere in the bug? Unless you just mean that's how libpurple handles it. 00:13:36 <flo> with the second solution you don't need the return value and the assignment 00:14:40 <flo> the name defaultChatNameField is probably not appropriate anyway for a function :) 00:14:55 <clokep> Yeah, probably not. :( 00:15:19 <clokep> If it returns some fields I'd then have to iterate over them and overwrite the object, that's why I figured it'd be easier to just pass both and let it directly modify them. 00:16:04 <flo> clokep: I mentionned it in comment 1. "a function that returns an array (or just an object?) or field names to fill and their respective values." 00:16:41 <clokep> Ah, you're right. Sorry. I must have missed that comment. :( 00:16:44 <flo> well, it depends if you think it could be useful for some other purpose to have a function that parses a serialized chat name 00:18:00 <flo> I've no immediate idea for a use case, so I guess I would r+ the function that modify the values directly. :) 00:18:03 <clokep> That's true, I didn't think about that aspect. :) 00:18:12 <clokep> Nah I'll do it the right way. ;) 00:18:15 <clokep> Just requires more thinking. 00:18:27 <flo> that's 3 lines of thinking ;) 00:19:06 <flo> Good evening/night! :) 00:19:14 <clokep> Goodnight. 00:20:15 <-- flo has quit (Quit: Instantbird 0.3a2pre) 00:30:24 * clokep just got banned from irc.moz.org and can't test anything. :( 00:42:07 --> DGMurdockIII has joined #instantbird 00:42:13 <-- Mathnerd314 has quit (Ping timeout) 00:42:35 --> clokep_js has joined #instantbird 00:42:45 <-- clokep_js has left #instantbird () 00:46:47 <instantbot> clokep@gmail.com added attachment 518 to bug 686. 00:46:49 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 518 on bug 686. 00:46:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=686 nor, --, ---, clokep, ASSI, Implement default chat name for getChatRoomDefaultFieldValues for js-proto 00:58:48 <-- DGMurdockIII has quit (Quit: get satisfied!  :: core-networks.de ««« (Gamers.IRC) »»» gamersirc.net ::) 01:12:39 <instantbot> clokep@gmail.com granted review for attachment 517 on bug 118. 01:12:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=118 min, --, ---, florian, ASSI, Extensions should be able to register commands. 01:13:23 <-- clokep has quit (Quit: Instantbird 0.3a2pre) 01:13:27 --> clokep has joined #instantbird 01:13:27 * ChanServ sets mode +h clokep 02:30:48 --> mepine has joined #instantbird 02:39:58 * clokep is now known as cloke_away 02:40:29 --> clokep_js has joined #instantbird 02:41:20 <-- clokep_js has quit (Client exited) 02:45:16 * cloke_away is now known as clokep 02:48:09 * clokep is now known as clokep_ 02:48:47 * clokep_ is now known as clokep 03:00:48 --> Mook has joined #instantbird 03:03:57 <clokep> Fixed a crash that's been bugging me in IRC. :) 03:05:12 --> skeledrew1 has joined #instantbird 03:06:18 <Mook> oh hi clokep 03:06:20 <instantbot> clokep@gmail.com granted review for attachment 515 on bug 628. 03:06:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=628 nor, --, ---, mook.moz+bugs.instantbird, ASSI, Unable to accept IRC invite 03:06:24 <clokep> Hello Mook. ;) 03:07:04 <-- Mook has quit (NickServ (GHOST command used by Mook_)) 03:07:18 <-- skeledrew has quit (Ping timeout) 03:07:34 --> Mook has joined #instantbird 03:08:26 <clokep> The UI for invites is kind of rough. :( 03:08:46 <Mook> yeah :( 03:08:50 <Mook> better mockups - even in MS paint - welcome! :) 03:09:07 <Mook> (just... needs to magically work on bubbles, simple, and dark :p ) 03:09:13 <clokep> Hahah. :) 03:09:29 <clokep> Let me check your code again. 03:10:11 <Mook> sure. 03:10:22 <Mook> I should probably upload a patch with the jsm removed.... 03:11:56 <clokep> Possibly... 03:12:31 <clokep> flo is interested in having a pop up that appears on mouse over, is that correct? 03:12:35 * clokep is reading through the thread again. 03:13:38 <Mook> right 03:13:48 <Mook> something like IE's old image toolbar 03:14:01 <Mook> (... I feel wrong calling that "old". has it been that long already?) 03:14:59 <clokep> Hahaha, possibly. 03:15:32 <clokep> Isn't that pretty much just a menu drop down with the menu items in it though? 03:16:17 <clokep> What was the problem with the Dark theme? Just the colors? 03:17:07 <Mook> yeah 03:17:26 <Mook> it's odd looking as it is right now... but I feel images would make it worse. 03:17:45 <Mook> perhaps something light with a dark border, or something dark with a light border... hmm. 03:20:47 <clokep> Can we use the theme colors in any way? 03:20:56 <clokep> I don't know much about the theme code though. :-\ 03:21:57 <Mook> not really, no. 03:22:11 <Mook> they're in css... and having things accidentally match sucks :( 03:25:39 <clokep> :-\ Idk. Maybe we should ask flo at some point? :P You're not usually around w/ him though. 03:51:55 <Mook> or do it via bugzilla - has attachments, and makes it easier to track :) 03:52:19 <Mook> damn, I guess 0.3 is too close for "land it now and fix it later" 03:55:51 <clokep> How close do you think 0.3 is? ;) 03:55:57 <clokep> We probably have a good six months. :P 03:56:02 <clokep> But that's total speculation. 03:56:28 <clokep> I'm assuming we won't ship before Firefox 4 (so we have a stable toolkit?) and that keeps slipping...? 03:56:58 <clokep> But yeah, bugzilla could work too. :P Ask flo about a land it and fix it? 03:57:04 <clokep> (He reads the logs too so...) 04:06:08 --> rikki1 has joined #instantbird 04:06:50 <-- rikki has quit (Connection reset by peer) 04:06:53 <clokep> I need to go to bed. Goodnight. ;) Reply in the bug / here if oyu have more comments. 04:06:59 <-- clokep has quit (Quit: Instantbird 0.3a2pre) 04:47:45 --> tymerkaev_away has joined #instantbird 05:12:53 <-- tymerkaev_away has quit (Input/output error) 06:36:58 <-- Mook has quit (Ping timeout) 08:02:15 --> Ornthalas has joined #instantbird 08:53:59 <-- Ornthalas has quit (Quit: KTHXBYE) 09:15:14 --> Even has joined #instantbird 09:15:14 * ChanServ sets mode +o Even 09:17:46 <instantbot> florian@instantbird.org granted review for attachment 518 on bug 686. 09:17:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=686 nor, --, ---, clokep, ASSI, Implement default chat name for getChatRoomDefaultFieldValues for js-proto 09:49:59 --> igorko has joined #instantbird 09:59:04 <-- Even has quit (Quit: Instantbird 0.3a2pre) 10:04:58 <-- igorko has quit (Quit: Instantbird 0.3a2pre) 10:08:25 --> kaie has joined #instantbird 10:12:55 --> Even has joined #instantbird 10:12:55 * ChanServ sets mode +o Even 10:13:11 <-- Even has quit (Quit: Instantbird 0.3a2pre) 10:13:20 --> Even has joined #instantbird 10:13:20 * ChanServ sets mode +o Even 10:13:33 --> GeekShadow has joined #instantbird 10:15:49 --> GeekShad0w has joined #instantbird 10:24:01 <-- GeekShad0w has quit (Quit: The cake is a lie !) 10:36:14 --> flo has joined #instantbird 10:36:15 * ChanServ sets mode +qo flo flo 10:36:36 <flo> hello :) 10:45:57 <flo> the path indicated at https://wiki.instantbird.org/Instantbird:FAQ#Location_of_the_log_files for Linux doesn't seem right. Someone should probably check before modifying the page, the http://www.instantbird.com/faq.html#logfolder seems more likely to be accurate 10:56:42 --> igorko has joined #instantbird 11:09:39 <-- igorko has quit (Quit: Instantbird 0.3a2pre) 11:17:06 --> clokep has joined #instantbird 11:17:06 * ChanServ sets mode +h clokep 11:24:33 --> Mic2 has joined #instantbird 11:25:56 <-- clokep has quit (Quit: Instantbird 0.3a2pre) 11:26:02 <Mic2> flo: http://www.instantbird.com/faq.html#profilefolder seems wrong too 11:32:19 <flo> Mic2: which part? 11:32:56 <Mic2> It's missing the part pointing at the profile 11:33:21 <flo> the mac line should be: ~/Library/Application Support/Instantbird/Profiles/ (I've just checked) 11:33:33 <flo> what's the "part pointing at the profile"? 11:34:28 <flo> hmm, actually, only the Mac OS X line seems right on the wiki page 11:35:00 <flo> on linux I think (but would need to check) it's ~/.instantbird/ (no caps on Instantbird, and no "Profiles" subfolder) 11:35:04 <Mic2> "/Profiles/<your profile name>/" 11:35:35 <Mic2> (on Windows, no idea if it's the same on other OSes) 11:35:36 <flo> does that exist on non-Mac OSes? 11:36:27 <Mic2> Yes, at least on Windows it does. And this time I checked before posting;) 11:36:28 * flo opens 2 VMs 11:40:10 <flo> restoring a VM when the RAM of the physical machine is already full is a sure way to put the machine on its knees... :-/ 11:41:21 <flo> and I can't blame firefox for all the wasted memory, it currently claims only 155MB 11:43:15 <flo> I confirm that on ubuntu it's ~/.instantbird/ 11:43:38 <flo> (and that there's a Profiles subfolder on Windows... my VM was already almost started when you confirmed you checked...) 11:49:38 <flo> I fixed the FAQ on ib.com too 11:52:34 <flo> I'm almost done on the C (libpurple) part of the command work. Will need to attack the purplexpcom part soon :) 11:53:11 <Mic2> It wouldn't be exactly the answer to the question but what about "Go and use the Show-log-folder-button in the options dialog, it will take you there.."? 11:54:05 <Mic2> And we should leave the explanations for the case that the user can't run Ib for some reason 11:54:51 <flo> On linux that button totally sucks 11:55:13 <flo> it basically popups a dialog asking you do select the path of the application to handle the file:// protocol :-S 11:55:29 <flo> *to 12:03:30 --> sabret00the has joined #instantbird 12:03:36 <Mic2> Good luck with the commands, sounds useful :) 12:03:57 <Mic2> bye 12:04:23 <-- Mic2 has quit (Quit: http://www.mibbit.com ajax IRC Client) 12:04:32 <flo> thanks :) 12:16:35 <flo> I've got to go, back in a few hours 12:16:42 <-- flo has quit (Quit: Instantbird 0.3a2pre) 12:17:08 <-- mepine has quit (Quit: é¨ç·£ä¹) 12:39:46 --> Andrey has joined #instantbird 12:48:26 <-- Gizmokid2005 has quit (Ping timeout) 12:53:37 --> rikki has joined #instantbird 12:54:15 <-- rikki1 has quit (Connection reset by peer) 13:13:47 --> clokep_work has joined #instantbird 13:22:33 <-- skeledrew1 has quit (Quit: Instantbird 0.3a2pre) 13:23:46 --> skeledrew has joined #instantbird 13:28:14 --> tymerkaev_away has joined #instantbird 13:56:28 * tymerkaev_away is now known as tymerkaev 14:19:17 --> Gizmokid2005 has joined #instantbird 14:20:39 --> Turkiyem has joined #instantbird 14:20:45 * Turkiyem is now known as RahatSuz 14:20:49 <-- RahatSuz has left #instantbird () 14:21:54 <-- rikki has quit (Quit: Instantbird 0.2) 14:39:20 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client) 14:59:01 <-- chrisccoulson has quit (Quit: Ex-Chat) 15:00:18 --> chrisccoulson has joined #instantbird 15:36:04 <-- tymerkaev has quit (Ping timeout) 15:55:42 --> clokep_work has joined #instantbird 15:55:42 * ChanServ sets mode +h clokep_work 16:11:07 --> flo has joined #instantbird 16:11:07 * ChanServ sets mode +qo flo flo 16:13:47 <-- GeekShadow has quit (Ping timeout) 16:14:29 --> tymerkaev_away has joined #instantbird 16:14:33 <-- tymerkaev_away has quit (Client exited) 16:14:34 --> GeekShadow has joined #instantbird 16:18:13 --> tymerkaev has joined #instantbird 16:26:51 <clokep_work> Bah. Using SVN at work...HG is a lot better. :( 16:37:47 <flo> what do you work on? 16:38:56 <clokep_work> MATLAB code mostly. Government contractor work. 16:40:14 <flo> svn may not be the only painful tool then :-/ 16:41:36 <clokep_work> The distinct lack of comments is an issue as well. :) 16:47:43 <flo> I'm stuck on a stupid purpleIConversation -> PurpleConversation conversation issue on my js command work :-/ 16:51:22 <clokep_work> What's that mean? :( 16:51:42 <flo> s/conversation/conversion/ :) 16:55:58 <clokep_work> Ah hahaha. :) 16:56:54 <flo> I'll just cast it for now so that I can test the rest of the implementation, but I can't keep that cast 16:57:19 <flo> applying a libpurple command on a JS conversation object can't work without some inconvenience (like crashing) 16:58:47 <clokep_work> That's inconvenient. :( 16:59:40 <flo> so I need to detect if a conversation is a libpurple one or not 17:01:58 * tymerkaev is now known as tymerkaev_away 17:04:28 * tymerkaev_away is now known as tymerkaev 17:05:32 <-- Even has quit (Quit: Instantbird 0.3a2pre) 17:07:47 <-- tymerkaev has quit (Client exited) 17:09:00 <clokep_work> That sounds hackish. :-\ 17:20:24 --> mokush has joined #instantbird 17:21:30 <clokep_work> flo: Did you see the conversation Mook and I had in the log? Wondering about whether we could land the actions and do a clean up a little later? 17:22:52 <flo> would the cleanup ever happen? ;) 17:23:26 <flo> I haven't looked enough at the patch to know exactly how much work is still needed for it to be releasable :) 17:26:43 <clokep_work> Ah OK. Did Mook attach an updated patch last night? I don't think so. 17:28:38 <flo> I think for the dark theme I would accept that some adjustments are needed in the theme's css for the buttons to look good 17:28:56 <flo> not for simple though :) 17:29:32 --> tymerkaev has joined #instantbird 17:30:13 <clokep_work> I see. 17:30:23 <clokep_work> I haven't really looked at the issue yet too in depthly. 17:31:08 <flo> ahah, my global libpurple commands don't crash even when on non-libpurple conversations :) 17:31:24 <flo> probably because the conversation pointer is not used at all :) 17:41:52 --> Ornthalas has joined #instantbird 18:04:25 <-- tymerkaev has quit (Client exited) 18:09:34 <-- Andrey has quit (Quit: ) 18:20:27 <flo> I added a dozen lines of ugliness to correctly ensure the purpleIConversation is a libpurple conversation. 18:20:40 <flo> (using the classID from the nsIClassInfo interface) 18:26:54 <-- Ornthalas has quit (Quit: KTHXBYE) 19:08:32 <clokep_work> That sounds ugly. 19:09:00 <flo> do you want to review the patch again before I push it? 19:09:16 <flo> the "final"(?) patch is: 19 files changed, 587 insertions(+), 150 deletions(-) 19:09:30 <flo> I'll to a self-review again before pushing it 19:10:52 <clokep_work> I don't think I'll understand the xpcom stuff well enough. :-/ I'll definitely look tonight at what you push though. 19:11:01 <flo> I haven't tried to make a nice js-proto friendly thing in jsProtoHelper. I assumed you would be interested in at least looking at it 19:11:58 <clokep_work> Yeah I can do that, can you file a follow up and assign to me? 19:12:34 <flo> I'll push it first :) 19:14:20 <instantbot> florian@instantbird.org added attachment 519 to bug 118. 19:14:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=118 min, --, ---, florian, ASSI, Extensions should be able to register commands. 19:15:50 <-- GeekShadow has quit (Ping timeout) 19:16:02 * flo will go eat something before reading that code again. (maybe?) back later :) 19:16:05 <-- flo has quit (Quit: Instantbird 0.3a2pre) 19:18:13 --> DGMurdockIII has joined #instantbird 19:28:38 --> tymerkaev_away has joined #instantbird 19:31:50 * tymerkaev_away is now known as tymerkaev 19:40:35 <-- mokush has quit (Client exited) 19:43:08 --> mark76 has joined #instantbird 19:47:01 --> mokush has joined #instantbird 20:04:23 --> linuxwizard has joined #instantbird 20:05:45 --> hicham has joined #instantbird 20:11:44 <-- DGMurdockIII has quit (Quit: get satisfied!  :: core-networks.de ««« (Gamers.IRC) »»» gamersirc.net ::) 20:13:01 * tymerkaev is now known as tymerkaev_away 20:27:04 --> igorko has joined #instantbird 20:28:17 * tymerkaev_away is now known as tymerkaev 20:30:42 --> Even has joined #instantbird 20:30:43 * ChanServ sets mode +o Even 20:31:15 <-- Even has quit (Quit: Instantbird 0.3a1pre) 20:31:28 --> Even has joined #instantbird 20:31:28 * ChanServ sets mode +o Even 20:38:01 <-- tymerkaev has quit (Ping timeout) 20:38:51 <-- igorko has quit (Quit: Instantbird 0.3a2pre) 20:51:13 --> kaie2 has joined #instantbird 20:53:31 <-- kaie has quit (Ping timeout) 20:53:32 * kaie2 is now known as kaie 21:05:53 <-- mark76 has left #instantbird () 21:09:07 --> mark76 has joined #instantbird 21:10:04 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client) 21:18:02 --> flo has joined #instantbird 21:18:03 * ChanServ sets mode +qo flo flo 21:21:38 <instantbot> florian@instantbird.org added attachment 520 to bug 118. 21:21:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=118 min, --, ---, florian, ASSI, Extensions should be able to register commands. 21:33:02 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/bb4e9c7298ae - Patrick Cloke - Bug 686 - Implement default chat name for getChatRoomDefaultFieldValues for js-proto, r=fqueze. 21:33:03 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/4e8ee81dc102 - Florian Quèze - Bug 118 - Extensions should be able to register commands, r=clokep (for the JS part only). 21:34:25 <instantbot> florian@instantbird.org set the Resolution field on bug 686 to FIXED. 21:34:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=686 nor, --, 0.3a2, clokep, RESO FIXED, Implement default chat name for getChatRoomDefaultFieldValues for js-proto 21:35:15 <instantbot> florian@instantbird.org set the Resolution field on bug 118 to FIXED. 21:35:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=118 min, --, 0.3a2, florian, RESO FIXED, Extensions should be able to register commands. 21:36:08 --> Even1 has joined #instantbird 21:37:38 <-- Even has quit (Ping timeout) 21:48:23 <instantbot> New purplexpcom - General bug 690 filed by florian@instantbird.org. 21:48:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=690 enh, --, ---, nobody, NEW, jsProtoHelper could help registering commands 21:53:19 <flo> ok, I've probably made enough bugmail in clokep's inbox for the evening :). 21:53:22 <flo> Good night :) 21:53:28 <-- flo has quit (Quit: Instantbird 0.3a2pre) 21:53:41 --> Mathnerd314 has joined #instantbird 21:59:09 --> igorko has joined #instantbird 22:13:52 --> Ornthalas has joined #instantbird 22:17:39 <-- mokush has quit (Connection reset by peer) 22:25:10 <-- mark76 has quit (Quit: Instantbird 0.2) 22:25:49 --> mark76 has joined #instantbird 22:35:16 <-- igorko has quit (Quit: Instantbird 0.3a2pre) 22:40:47 <-- Even1 has quit (Ping timeout) 22:41:22 --> Even has joined #instantbird 22:41:23 * ChanServ sets mode +o Even 22:42:05 <-- mark76 has left #instantbird () 22:55:49 --> mark76 has joined #instantbird 23:08:53 <-- Mathnerd314 has quit (Ping timeout) 23:17:54 <-- Even has quit (Quit: Instantbird 0.3a2pre) 23:25:47 --> Mathnerd314 has joined #instantbird