All times are UTC.
00:00:46 <Mook> or even make it a .jsm since it only exposes one object of importance :) 00:02:05 <Mic> The thing is that I want these shortcuts at places where I don't include the menus 00:02:20 --> rikki has joined #instantbird 00:02:22 <Mic> that is I want to have them on the conversation windows on Windows 00:02:31 <-- rikki1 has quit (Connection reset by peer) 00:02:32 <Mic> that's why I couldn't include it from menus.xul 00:02:36 <Mook> yeah; splitting it into <commandset>, <menubar>, and <keyset> overlays could be nice :) 00:03:38 <Mook> sorry, sometimes I go off into fix-the-world mode. just ignore me :p 00:04:53 <flo> hmm, I don't see how sharedKeyboardShortcuts.xul works in instantbird.xul, there doesn't seem to be elements with the ids maincommandset/mainkeyset there. 00:05:32 <Mook> if http://lxr.instantbird.org/instantbird/source/instantbird/content/instantbird.xul#81 is not XP_MAC only it would work 00:05:35 <-- Mic has quit (Quit: Instantbird 0.3a1pre) 00:05:44 <Mook> (it's fine to have, because it doesn't actually contain anything) 00:05:59 <flo> but it's not in the current patch 00:06:03 <Mook> hmm, true 00:08:52 <flo> hmm, would it be a problem to put all the keys/commands defined for the buddy list in conversation windows? 00:10:17 <Mook> hmm. keys,maybe. commands, probably not. 00:11:03 <flo> and then we would duplicate the poor 2 keys? 00:17:12 --> Mic has joined #instantbird 00:17:12 * ChanServ sets mode +h Mic 00:17:16 <instantbot> benediktp@ymail.com added attachment 446 to bug 364. 00:17:17 <instantbot> benediktp@ymail.com requested review from florian@instantbird .org for attachment 446 on bug 364. 00:17:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=364 enh, --, ---, benediktp, NEW, Show in the Themes preference pane which theme are disabled 00:18:50 <Mic> flo, Mook: I wondered this as well and either I did something wrong or it just works as well 00:21:42 <Mic> We don't really want the menubar and the popup stub in the conversation window though, do we? 00:28:11 <-- Ornthalas has quit (Quit: KTHXBYE) 00:28:23 <Mic> That's the result of bug 364 fixed: http://img510.imageshack.us/img510/7487/bug364themelistpreview.png (the incompatible items are only usable because I'm having compatibility checking disabled, otherwise they'd be also greyed out and disabled) 00:28:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=364 enh, --, ---, benediktp, NEW, Show in the Themes preference pane which theme are disabled 00:29:27 <Mic> I think it's OK-behaviour to warn users of enabled but incompatible themes here 01:01:44 <flo> the behavior seems OK to me :) 01:06:29 <flo> Good night! :) 01:08:00 <Mic> Good night 01:10:20 <Mic> Same for me ;) Good night 01:10:46 <-- Mic has quit (Quit: Instantbird 0.3a1pre) 01:59:50 <-- hicham has quit (Client exited) 02:52:20 --> mepine has joined #instantbird 02:53:40 <-- GeekShadow has quit (Quit: The cake is a lie !) 03:04:26 --> skeledrew has joined #instantbird 04:31:19 --> DGMurdockIII has joined #instantbird 04:32:15 <-- mepine has quit (Connection reset by peer) 04:36:37 --> tymerkaev has joined #instantbird 04:43:32 --> mepine has joined #instantbird 04:54:11 <-- DGMurdockIII has quit (Quit: get satisfied! :: www.unitedservers.de ««« (Gamers.IRC) »»» gamersirc.net ::) 05:13:39 --> clokep has joined #instantbird 05:13:39 * ChanServ sets mode +h clokep 05:18:16 <-- clokep has quit (Ping timeout) 05:33:35 <-- tymerkaev has quit (Ping timeout) 05:49:31 <-- Mook has quit (Ping timeout) 06:04:27 --> Mook has joined #instantbird 06:07:08 <-- Mook has quit (Connection reset by peer) 06:25:14 --> Mook has joined #instantbird 07:08:18 --> clokep has joined #instantbird 07:08:18 * ChanServ sets mode +h clokep 07:25:17 <Mook> hmm, libpurple/core.h assumes glib.h has been included 07:26:34 <-- clokep has quit (Quit: Instantbird 0.3a1pre) 07:49:30 <instantbot> mook.moz+bugs.instantbird@gmail.com added attachment 447 to bug 638. 07:49:31 <instantbot> mook.moz+bugs.instantbird@gmail.com requested review from florian@instantbird .org for attachment 447 on bug 638. 07:49:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=638 enh, --, ---, mook.moz+bugs.instantbird, NEW, Split purpleInit.cpp into multiple files 07:51:31 <instantbot> mook.moz+bugs.instantbird@gmail.com added attachment 448 to bug 638. 07:51:32 <instantbot> mook.moz+bugs.instantbird@gmail.com requested review from florian@instantbird .org for attachment 448 on bug 638. 07:51:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=638 enh, --, ---, mook.moz+bugs.instantbird, NEW, Split purpleInit.cpp into multiple files 08:20:55 --> Ornthalas has joined #instantbird 08:58:46 --> Even has joined #instantbird 08:58:46 * ChanServ sets mode +o Even 09:33:53 <-- Ornthalas has quit (Quit: KTHXBYE) 09:50:02 <-- Mook has quit (Ping timeout) 10:04:04 --> Mook has joined #instantbird 10:09:09 <-- mepine has quit (Quit: é¨ç·£ä¹) 10:57:40 --> Mic has joined #instantbird 10:57:40 * ChanServ sets mode +h Mic 10:58:22 <-- Mic has quit (Connection reset by peer) 11:00:14 --> Mic has joined #instantbird 11:00:14 * ChanServ sets mode +h Mic 11:05:29 <instantbot> New Instantbird (UI) bug 640 filed by benediktp@ymail.com. 11:05:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=640 blo, --, ---, nobody, NEW, No check-ins on Christmas 11:39:39 --> sabret00the has joined #instantbird 11:40:43 <-- Even has quit (Connection reset by peer) 11:41:10 --> Even has joined #instantbird 11:41:10 * ChanServ sets mode +o Even 11:53:30 --> tymerkaev has joined #instantbird 11:55:44 <-- Mook has quit (Quit: ChatZilla 0.9.86-rdmsoft [XULRunner 1.9.1.16/2010113000]) 12:40:16 <flo> Mic: ok, your patch will wait :-P 12:58:25 * flo wonders if Mook agrees with bug 640 12:58:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=640 blo, --, ---, nobody, NEW, No check-ins on Christmas 12:58:41 <flo> or maybe that should be no review? :-D 13:02:10 --> GeekShadow has joined #instantbird 13:06:14 --> hicham has joined #instantbird 13:14:02 <Mic> I think we should wait and see if the problem persists ;) 13:28:42 <-- kaie has quit (Quit: Leaving) 13:37:30 <flo> Mic: see if Christmas exists next year? 13:40:27 <Mic> I think it's ok to reopen it if it happens again 14:32:37 --> clokep has joined #instantbird 14:32:37 * ChanServ sets mode +h clokep 14:36:24 <clokep> I was really hoping to get a patch checked in tomorrow Mic! :P 14:50:50 <flo> clokep: a special branding? ;) 14:56:10 <clokep> Yes, we should cover all major holidays. :P 15:00:59 <-- Even has quit (Quit: Instantbird 0.3a1pre) 15:11:03 <flo> We could at least put one for Instantbird's anniversary :-D 15:13:41 <clokep> And have it change each year counting? ;) 15:16:26 <flo> only if you commit a script to generate it :-P 15:16:46 <flo> otherwise, it would be safer to not put the number of years on the cake 15:19:12 <Mic> hmm, a small christmas tree on the icon should be easy 15:19:21 <Mic> and fireworks shouldn't be too hard either 15:24:34 <tymerkaev> svg source is available? 15:29:06 <Mic> I don't think so 15:29:20 <Mic> (if you mean the Instantbird globe) 15:29:32 <Mic> Maybe ask idechix 15:30:45 <flo> I think we decided to not release it 15:33:56 <clokep> Have you looked at # of updates/users anymore recently? Was wondering how 0.2 held on. 15:34:22 <flo> no. 15:34:42 <flo> we should probably automate this 15:37:24 <-- hicham has quit (Client exited) 15:38:34 <flo> ahah, copying a file and then removing most of its content is a great way to fool diffstat into believing a lot of code has been removed :-D 15:38:45 <flo> 4 files changed, 8 insertions(+), 1010 deletions(-) for one of Mook's patches 15:41:31 --> Ornthalas has joined #instantbird 15:42:03 <Mic> There's the same problem with hg addremove 15:51:42 <Mic> flo: the script you used to convert the Adium message styles is not on the repository as it seems? 15:51:50 <Mic> I only found one to create all the screenshots 15:52:01 <Mic> (well, or an extension doing this at least) 15:52:08 <flo> I think I put in the repository the script to convert them, but not to download them 15:52:56 <flo> the download script is in another (private) hg repository where we keep tools that are used for server administration tasks 15:53:22 <flo> and other random things that we should open "someday" once we are sure there's nothing sensitive in there 15:54:14 <instantbot> florian@instantbird.org denied review for attachment 448 on bug 638. 15:54:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=638 enh, --, ---, mook.moz+bugs.instantbird, NEW, Split purpleInit.cpp into multiple files 15:56:01 <Mic> I haven't found the converting script either 15:57:37 <instantbot> florian@instantbird.org granted review for attachment 447 on bug 638. 15:57:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=638 enh, --, ---, mook.moz+bugs.instantbird, NEW, Split purpleInit.cpp into multiple files 15:58:15 <flo> Mic: http://lxr.instantbird.org/instantbird/source/tools/messagestyles/ 15:59:28 <Mic> d'oh 16:01:10 <instantbot> florian@instantbird.org set the Resolution field on bug 441 to FIXED. 16:01:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=441 enh, --, 0.3a1, benediktp, RESO FIXED, minimize with ESC key 16:01:49 --> hicham has joined #instantbird 16:02:37 <Mic> :) 16:03:33 <flo> Mic: it's not Christmas yet, check-ins are allowed, aren't they? ;) 16:03:50 <Mic> No, not today, ok? 16:05:05 <Mic> I'm leaving for today, so merry christmas and have nice holidays, you all 16:05:13 <clokep> You too! 16:05:38 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/73b6e181dc25 - Benedikt P. - Bug 441 - Minimize conversation windows with escape key, r=fqueze. 16:05:39 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/c0df270a2f48 - Mook - Bug 638 - Split purpleInit.cpp into multiple files - part 2: move account and connection uiops and signals to purpleInitAccounts.cpp, r=fqueze. 16:05:44 <Mic> :P 16:06:02 <flo> was just about to ask a question about your patch in bug 364 16:06:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=364 enh, --, ---, benediktp, NEW, Show in the Themes preference pane which theme are disabled 16:06:12 <Mic> ok, quick then 16:06:40 <flo> why a appendThemeMenuItem method instead of the buildThemeList I suggested? 16:07:07 <flo> I thought you were going to factor out the whole list building code, and that way the regexp would be created only once for the whole list 16:07:27 <Mic> Sorry, I misunderstoddd you then 16:07:35 <Mic> will fix this the next days 16:07:37 <Mic> bye 16:07:40 <-- Mic has left #instantbird () 16:08:30 <flo> well... merry Christmas to you too! (if you happen to read the log soon ;)) 16:12:20 <instantbot> florian@instantbird.org denied review for attachment 446 on bug 364. 16:12:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=364 enh, --, ---, benediktp, NEW, Show in the Themes preference pane which theme are disabled 16:15:42 <instantbot> florian@instantbird.org cancelled blocking0.2? on bug 151. 16:15:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=151 enh, --, 0.3, nobody, NEW, Create a Tray Icon. SINGLE-click on tray icon opens and closes Instantbird. 16:17:08 <flo> only 2 review requests remaining: https://bugzilla.instantbird.org/request.cgi?action=queue&requester=&product=&type=all&requestee=florian%40instantbird.org&component=&group=type :) 16:17:35 <clokep> :) 16:17:58 <clokep> Should we put blocking flags on things? ;) 16:18:28 <flo> bah... 16:19:34 <flo> I'm not a fan of blocking flags 16:20:38 <clokep> OK. 16:20:47 <clokep> Just wondering if there's a way we're keeping track of stuff. 16:29:16 <flo> no 16:29:21 <flo> good improvement idea for 2011 ;) 16:31:38 <flo> we also need to look into ways to block the project as little as possible when I'm physically or mentally away (like it happened during a few weeks this year when I was busy emptying and selling my grandparents' house) 16:38:13 <-- clokep has quit (Ping timeout) 16:40:21 --> clokep has joined #instantbird 16:40:21 * ChanServ sets mode +h clokep 16:40:54 <clokep> Does anybody else have commit access? 16:48:36 <clokep> Well I'll be in out and but have a good holiday! 16:48:39 <-- clokep has quit (Quit: Instantbird 0.3a1pre) 17:00:27 <flo> clokep: currently no (Even could technically push something if he really needed because he has accesses to the server hosting the repository, but he would not do it). 17:03:35 <flo> we could grant commit access to another person or two. I think the problem would rather be at the review step, because currently nobody else has an application wide knowledge of the code (we could try and find subareas of the code where some people have enough experience to review though :)). 17:03:42 <flo> thanks, have a good holiday too :) 17:15:51 <-- Ornthalas has quit (Quit: KTHXBYE) 17:41:16 --> clokep has joined #instantbird 17:41:16 * ChanServ sets mode +h clokep 17:44:17 <clokep> Yes, I think some people might be fluent enough in sub-areas? Maybe. :) 18:05:31 <flo> we may end up in a 2 levels review system like in mozilla with review (granted by people with a good knowledge of the touched area) and super-review (for things that have interactions with several areas of the code base) 18:05:49 <flo> and there's also the problem of changes to the UI that needs to stay consistent. 18:08:22 <clokep> r, sr, ui? 18:08:47 <flo> yes... 18:09:12 <flo> the interesting questions will be somewhat around "how do we gradually move to such a system without adding excessive overhead?" ;) 18:11:17 <clokep> I think allowing people to r would be the first stage, just not sure who knows areas besides you. ;) 18:13:38 <flo> the policy would be "people are allowed to review patches changing code they wrote"? 18:20:51 <clokep> Yeah, something like that. 18:21:06 <clokep> And then we'd have a SR if it touches something else as well. 18:21:18 <clokep> Although if a SR gets to it first then they can just review it. 18:21:51 <flo> I'm wondering if sr and ui-r are the same for us. 18:22:04 <clokep> aka "flo"? ;) 18:22:13 <flo> heh 18:22:22 <flo> "aligned with our long term goals" ;) 18:22:26 <clokep> Only one I'd be unsure of for you would be ui-r for anything with Win7, since you don't have it, right? 18:23:21 <flo> I guess I "should" get a VM in some way :-S 18:26:08 <flo> It's hard to think about these issues without imagining the people who would handle these tasks/requests. 18:33:10 <-- tymerkaev has quit (Ping timeout) 18:34:42 <clokep> :( It'll work out one day. 18:36:27 <-- clokep has quit (Quit: Instantbird 0.3a1pre) 18:37:15 --> tymerkaev has joined #instantbird 19:02:37 --> Ornthalas has joined #instantbird 20:22:46 <-- tymerkaev has quit (Ping timeout) 20:54:22 <-- sabret00the has quit (Ping timeout) 21:12:12 --> sabret00the has joined #instantbird 22:11:56 <-- micahg has quit (Ping timeout) 22:18:49 --> clokep has joined #instantbird 22:18:49 * ChanServ sets mode +h clokep 22:29:51 <-- clokep has quit (Quit: Instantbird 0.3a1pre)